From nobody Sat Oct 4 22:35:27 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE1552FDC34 for ; Tue, 12 Aug 2025 17:37:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755020245; cv=none; b=Cn+ox+2phvvF7B9osZtIjQk5h5NSbLMYYwNtnl24l+fG+Ezo3vgZvnHydTMYVoisCVU1RIjVXz0CBzvU69ubxojV5++Mmo+KzejxyqDCqqWmDogb5PR5cyv+xExEZhtsDlYqCZ4Pq9VaoQ8FJlPRxVADEuz9qzPiTUW1+ukSVoY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755020245; c=relaxed/simple; bh=gETWrxYWVvxLZf+CDOgBACKsO/Ab6x5dzjHwdFLboZc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OSJE9MUBZGrY46WyxQnsXQaWuAKAHYgfBIB5o0Y7DiyQrH0Wr6L2UZs9Xye8cF33FwZ9LNYFqvdK95pI9GC6krvyg0iOq8Wk0GgFTT650mwgwnhGlrnsHkq02GTrcrKn8KsGcOi14umAE5Ll6C3MPVW7zTL68q+CDUhohRdKy1k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ulsw5-0008EL-Q6 for linux-kernel@vger.kernel.org; Tue, 12 Aug 2025 19:37:21 +0200 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ulsw4-00DEaD-1Y for linux-kernel@vger.kernel.org; Tue, 12 Aug 2025 19:37:20 +0200 Received: from dspam.blackshift.org (localhost [127.0.0.1]) by bjornoya.blackshift.org (Postfix) with SMTP id 23E7745623E for ; Tue, 12 Aug 2025 17:37:20 +0000 (UTC) Received: from hardanger.blackshift.org (unknown [172.20.34.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by bjornoya.blackshift.org (Postfix) with ESMTPS id C5A2C4561F4; Tue, 12 Aug 2025 17:37:16 +0000 (UTC) Received: from hardanger.blackshift.org (localhost [::1]) by hardanger.blackshift.org (OpenSMTPD) with ESMTP id bcfd501a; Tue, 12 Aug 2025 17:37:15 +0000 (UTC) From: Marc Kleine-Budde Date: Tue, 12 Aug 2025 19:36:51 +0200 Subject: [PATCH 1/7] can: m_can: m_can_plat_remove(): add missing pm_runtime_disable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250812-m_can-fix-state-handling-v1-1-b739e06c0a3b@pengutronix.de> References: <20250812-m_can-fix-state-handling-v1-0-b739e06c0a3b@pengutronix.de> In-Reply-To: <20250812-m_can-fix-state-handling-v1-0-b739e06c0a3b@pengutronix.de> To: Chandrasekar Ramakrishnan , Vincent Mailhol , Patrik Flykt , Dong Aisheng , Fengguang Wu , Varka Bhadram , Wu Bo , Markus Schneider-Pargmann , Philipp Zabel Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-e44bb X-Developer-Signature: v=1; a=openpgp-sha256; l=1237; i=mkl@pengutronix.de; h=from:subject:message-id; bh=gETWrxYWVvxLZf+CDOgBACKsO/Ab6x5dzjHwdFLboZc=; b=owEBbQGS/pANAwAKAQx0Zd/5kJGcAcsmYgBom3u+cPHdBjNIz5j4ILvJaghwn2pC0wrTtotyF es1h6L1rLqJATMEAAEKAB0WIQSf+wzYr2eoX/wVbPMMdGXf+ZCRnAUCaJt7vgAKCRAMdGXf+ZCR nMt0B/0bN1+6x5VPi8pNkbh2SRKEbVMHNIELXp9bL3A4e6/IVip+1l9uxAS0PHXp1OceRjX+Jsg derAi0G5kQmAA/nlF8VsPy65NLPUgyXBREic3FQdPSOyDu6Wowf7nBhI1c4Uz3txtDbScFsNXu3 foc8bne7EmMm8Y4NJU5vpdZIuRRGLpvWasDlk3pfjtVwJ90bkaozu7/WfHGDiClmCQnTErTlSd8 GHjFjKpncmZBHKayz3BNlp8Q8Xi+ibLOmtUWveb9xXVJdATT9v/qdg1bJUWCBhtgH4N9uH1Jg4k HFknJjwPIOwxD0YHRa3a9ZoKcqMAQZOQahQ7XYTHp5iD+VaS X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Commit 227619c3ff7c ("can: m_can: move runtime PM enable/disable to m_can_platform") moved the PM runtime enable from the m_can core driver into the m_can_platform. That patch forgot to move the pm_runtime_disable() to m_can_plat_remove(), so that unloading the m_can_platform driver causes an "Unbalanced pm_runtime_enable!" error message. Add the missing pm_runtime_disable() to m_can_plat_remove() to fix the problem. Cc: Patrik Flykt Fixes: 227619c3ff7c ("can: m_can: move runtime PM enable/disable to m_can_p= latform") Signed-off-by: Marc Kleine-Budde Reviewed-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can_platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can= /m_can_platform.c index b832566efda0..057eaa7b8b4b 100644 --- a/drivers/net/can/m_can/m_can_platform.c +++ b/drivers/net/can/m_can/m_can_platform.c @@ -180,7 +180,7 @@ static void m_can_plat_remove(struct platform_device *p= dev) struct m_can_classdev *mcan_class =3D &priv->cdev; =20 m_can_class_unregister(mcan_class); - + pm_runtime_disable(mcan_class->dev); m_can_class_free_dev(mcan_class->net); } =20 --=20 2.50.1