From nobody Sun Oct 5 00:07:05 2025 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 696642EA495 for ; Tue, 12 Aug 2025 09:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754992351; cv=none; b=L4N/xvMgUVcp1SpI0blM//PqG9EVVgGWdADACtPPj+PdIvHwDmmaZTIM1Er6lveF1QudHA+Rc7tGQJUP81vTDZoo/a1LWLUizEp2RFR3I5rF71lDixOysLNyvKCNx2i/0zZiUlL/z2UMJaXJEBQ0i8mmzYDyG0TTc4KhOTSYIc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754992351; c=relaxed/simple; bh=gsmPjfJ2QmHUYm2T6GbsR3/AGbz0mExN80EXjsadE2I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QEazujyuQ3LiZCZLcxRdX1w6p7PaUjKK+CuNcFdvNTelyWxSjh32qHfSHJQ7+02iGm9FKJBUOxI5zSEbX5li6LaUFwQXvY+WMJgGGmjeXzs8lQNjK9TItYDLP87+rIV2Stqhxl+GrlhurRI2ndfySWpO9+HGU6iN/QofvOWZ7RI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=UBBlWw7k; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="UBBlWw7k" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3b913b7dc01so221960f8f.2 for ; Tue, 12 Aug 2025 02:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1754992348; x=1755597148; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X1M2z9RjV0ZuXBRlE0vMWSKVCPkQUD2amGo6k0F1OlA=; b=UBBlWw7kzE1KBQtzOyBg6bzb+umTFYfVkAwAteg5gPexnhRkPjyjDBRZPCKjv20CVv U05V5ecbZ2jKXM8MgJ4Evh5Y/3Hmhhq7wFGQjOoebX602uCVSYjY+EU2kEh9bjzQeWGs B8OKXc3FSASidOPmZ//V8vOoJOKzCHJa1pfhY6oBDs4j6cdk/N2hVoq3ppO4wNLEIB8y EBZLkfICf1H6lccVC5jdleKnLa4Pad/jgWUJxMIEd3Um5ngR2V2h7xF8vCIBU3/8F2tU lmppkGzdeEN2wK+pOkTTolfgp99RL+NbE4lFKict/GelD/3cFMq9+JZEO3xDxs9aXRh6 0vIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754992348; x=1755597148; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X1M2z9RjV0ZuXBRlE0vMWSKVCPkQUD2amGo6k0F1OlA=; b=YsQwty6Nrh3NYiY60aBGAUEcqVksic/SpQmioqX4JcsaMqtGDNVFvc9/XU0GqQHKBz hlBq3jrlbbRWSBoYZRwpbFEZfxreewNH0FjTQFhJsL2l0NFZgGf2CZJ8IQSJOd6EY167 9NZS3BW3nW8BsMXCt6I1H6pCHYN3PgjmUEZEPPnRFSoqxzZA6wCAYR9kquRdE3vLqepL u82eGsLEgw69zu6LYwhGCf04UgVcjKNYrFK7AZ0Tn9CUhfuAc3DtBXv7uzAdzOl5nJZ4 MMl6JSsn/YxbWtDgxpHSM9BVyOnU4qMdziEV8Nboeui41lywOHsXuLm8qEL8ZbgHvvlZ k2kQ== X-Forwarded-Encrypted: i=1; AJvYcCUSn8swiqy2nv6kJKH5aSvAROefY7zqMuRaVSXuR8FlI+ri5IWRifcO36vOyMtCdgGJIO1W6HJjKILRSb4=@vger.kernel.org X-Gm-Message-State: AOJu0YwvDVGerNzuQn/c6xkfphj42jn/qq68isMFOcOoDMtxthrK7BOH DTp2+SA642cA7pU4XaTqZ1VT1sLoEId2ZPbG0LUmD8Y5dGyyHKAYSrtl1xHoeHx8w98= X-Gm-Gg: ASbGnctCjS9HiO6iMm/Pgp77q8AzPOvDTfojRKV8VCPJlMdPRA6ozfZyJ0DQitcsLk8 bOD4xq04yLs8zf8KjUCqGg9ilaGL0YeIs5oYu8XcCKADLwI0OfOzCg4jYPR1uTD/A7Ry04rUQrS bJ+iqKgIRhLsp2fZtrf1MjranNO7flGhtesGLJwhN2GCnxKoQ7iF3EoWe1ULhwJCceG7p8sFBaJ RZJpYhgGZekZB6hLhWe5pqP7HhfpUzv7opc4Rg164ocffe1ycyIbEIaadi3pCTHDeLcw/1wsgHA diY5YrVoLRVxQMhDqPj9v2oL96bFWiwgNnMWUJEnnnqT227rJzGvdBvswKwKhIBFZqFUcnyOTZs 7sTQ9fFv4Ib29TjE= X-Google-Smtp-Source: AGHT+IEaXb74g++gnnRWRNlRWlIzQG/C+rEn8w7KrjKK2Ka2Ylgk9xZIu5ATuK2+3VNjfEtrz9Ay2w== X-Received: by 2002:a05:6000:401f:b0:3b8:5b26:b3ce with SMTP id ffacd0b85a97d-3b900b7a297mr13601145f8f.44.1754992347601; Tue, 12 Aug 2025 02:52:27 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:16c8:50:27fe:4d94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459e587e154sm312580295e9.27.2025.08.12.02.52.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Aug 2025 02:52:22 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 12 Aug 2025 11:52:00 +0200 Subject: [PATCH 03/14] gpio: hisi: use the BGPIOF_UNREADABLE_REG_DIR flag Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250812-gpio-mmio-gpio-conv-v1-3-9f43e95dea98@linaro.org> References: <20250812-gpio-mmio-gpio-conv-v1-0-9f43e95dea98@linaro.org> In-Reply-To: <20250812-gpio-mmio-gpio-conv-v1-0-9f43e95dea98@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Yinbo Zhu , Hoan Tran , Manivannan Sadhasivam , Yang Shen Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-unisoc@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1294; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=LGZlUs6AQDs8ng5Nn7ommqnFHh3w6/vhUJqzq5JniBE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBomw7GNzp6mz6xT0Tkum8iFoKh0J5iSYXuA3pFJ 8nbXyZ4STGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaJsOxgAKCRARpy6gFHHX cgxmD/497q2XFPdy3fQQUNTYyp+gDsJb0sHRX+VTofvSRmH0ZdkO74xDWvcSMGDe99ZcDOCO0UD osIU30qbFlAGXn8dLl36tH/G5aod0oTl1+8JsNgQHXnlglckq0lRPCzpSj4dCmYYaJLj2rcueh1 7wWIEmGcIWObGgoYw2Ekl3HtMd6Lt2YxIia0e72oWpQbfhBKgE4KkSbyhPpFjDpunyg7MkS1zAW 5cZ/ph/m2253NOMdtVq/aB8PHB+3H6A6wgWYBJQwXRhEbdpmaiHHRMSi5G4XSpX4T2z/HRttXFp 5EsQVEOkQt0OA3Nq7DkVVxUns9ITQryOlUWR1gUf01eBT9n5cknde/JLDzmOQ42AN+vcEBshjG6 yVeheK1PkKiwkGkrQMywnTGMnm2tWXDLbY+DPCRaHXjdDvfNm4RLj1zldaL6jRO/wGJI1yg0zJw ysOKCDzvnMe8ytfJYRgHcHtlmWvkbPksICUfGOnEdGGpxpDu6Fq0ZO7XA0cXgs4Xgi8GPVdnIgC l/4CILTByewxnpCVfniUzQT229274lX8VItp3Oiv8/Fjk2aOtH2pyn9Bw+MjZ3xSsOrcRFOgofQ hoduXd+dwZzH56V0pXT2koOAaHZUXIroGErk2068CRSi/2hUM46vDkKoE+L1xHOKCtGky7uoMjl Ih+Bp7CDME2Wxdw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski There's no reason for this driver to touch the gpio-mmio internals, we have a dedicated flag passed to bgpio_init() indicating to the module that the DIR register is unreadable. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-hisi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-hisi.c b/drivers/gpio/gpio-hisi.c index ef5cc654a24e2327510b872563e68fb0b9aaef71..6016e6f0ed0fb80ea670ebb5754= 52d9ec23976fa 100644 --- a/drivers/gpio/gpio-hisi.c +++ b/drivers/gpio/gpio-hisi.c @@ -295,7 +295,7 @@ static int hisi_gpio_probe(struct platform_device *pdev) hisi_gpio->reg_base + HISI_GPIO_SWPORT_DR_CLR_WX, hisi_gpio->reg_base + HISI_GPIO_SWPORT_DDR_SET_WX, hisi_gpio->reg_base + HISI_GPIO_SWPORT_DDR_CLR_WX, - BGPIOF_NO_SET_ON_INPUT); + BGPIOF_NO_SET_ON_INPUT | BGPIOF_UNREADABLE_REG_DIR); if (ret) { dev_err(dev, "failed to init, ret =3D %d\n", ret); return ret; @@ -303,7 +303,6 @@ static int hisi_gpio_probe(struct platform_device *pdev) =20 hisi_gpio->chip.set_config =3D hisi_gpio_set_config; hisi_gpio->chip.ngpio =3D hisi_gpio->line_num; - hisi_gpio->chip.bgpio_dir_unreadable =3D 1; hisi_gpio->chip.base =3D -1; =20 if (hisi_gpio->irq > 0) --=20 2.48.1