From nobody Sun Oct 5 00:12:44 2025 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3085A2EB5C7 for ; Tue, 12 Aug 2025 09:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754992696; cv=none; b=BYLTvA4DkB20CF4y0cF/rUoV2fqYl+75OLJXvpCpVmHMhcvadbCCKATuxbH1/PRKTQx+HJrQ+ewWNWdt+GXdKayymqmT+qKLQp0fW+bTMBmFqZpiP/a6qK4IQ222scOA4M1JxCeVfTYfYn3XN0Uf6cB934PlhKCSEGQYBN3Nv+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754992696; c=relaxed/simple; bh=gsmPjfJ2QmHUYm2T6GbsR3/AGbz0mExN80EXjsadE2I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pVZt7ne9fL0UiOKaUbIGdYeqrkq1/Sx1VOCNf4s2+ChCh/iMrItfNqfjmx5WgMsj38P1m+M82ZLpyFEu6Z6MGgj3mUABjOONJZmo7yKF9g2sm0lwCsSeG7TCPsTox/lqkuF7+yJDfxpMyeYhj1FHg9QaFgk7zPmJ0frL0WvWbdU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=2LZQKdWC; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="2LZQKdWC" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3b8db5e9b35so3143591f8f.1 for ; Tue, 12 Aug 2025 02:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1754992693; x=1755597493; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=X1M2z9RjV0ZuXBRlE0vMWSKVCPkQUD2amGo6k0F1OlA=; b=2LZQKdWCzYwBTfA00AoaoF8T8YQt25e5vJ20kgCZa9erVbXnPwuHtsKmNMjxcnKmtq USxbgvoqpB3JPgXVAPuCLUk+9FSCt+SMCodburgzdHvT+pj/Fvc3ttsRXYWIOblGFBbR dFzUN5wQQFU+U34D8aGVmC2hw7g1BUclyBNvq/85EG3QtgXe7K9fh+lTNgHJyXES3xdb NtXgJxSkXI5vnP1VgEcntz46YPE4/YbPk9V32bogSZGbgMzjTu4CUWsRMOB+jD+B7BZy gL/GiNPRQ+9Lel3MA31m+kQcsg9LV4L/b+YRjqIyaH7l10tw0YvnvLDTWJq54tLGi4X6 JIcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754992693; x=1755597493; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X1M2z9RjV0ZuXBRlE0vMWSKVCPkQUD2amGo6k0F1OlA=; b=jXeecDHDlnF3DFY2qAxUpHOxPBf2lSxZfRHj/JhE4UgxvktPatvnKlMz7umk1UlOdo tVM2qMGdDshiIprgDG1Vj838vRZORsGp//ssBkJiTUCyJWzwWjHMjnoB5LE6zDx5F++F edNMSRjSnNMlkNNTl3Ko+2ybV3ysHoFQkJ8gct9fS2KnZVuIfR4yRcpvBoiQIS/kdKPQ FFmY/e0ri5qW/EOgrHPtfhWrIe6mgCXiBQBSX+IaFaZdqM/7LZzEEpWq8O4ubKjmERg+ Vc7aJhzCT0xeB3+twdzKQVTskjtQ+afrS1yR6nnCpuwHq8WoiITpaAg4SKQn43xoVIVD btiQ== X-Forwarded-Encrypted: i=1; AJvYcCW8ORgZeeLnmTpBGoohczrnKO8OqM5sJ42I1JGhpP2M46wulcLoLcOu945+RxEE2OKp8aaRxgDGpr4jKQg=@vger.kernel.org X-Gm-Message-State: AOJu0YyNBMgZx8nqAaByi7JpQmcDMwGGVJL14HAcg9uGUjqDxF64Lk+U AZz+EXkS7eH8eh4NkEn5PkTPiWUxBpyfIZHl1dEaFEpv+dSxQ4c9u9lzb5C2pdu1sEU= X-Gm-Gg: ASbGnctmwq3TQ0xsxwGUf1QNDDHvxT9zTgkeYRmUuDV/45UMc1TuHGvLOfvSGcyIRSY ysCE/fhgrJ5KHR6MsWGcJgbzP63sKqdOTWTDxXbBRegKpAS/hMgtH2P+NxqJFLkVuMXBLEpH6rz XzcJhPB8F2CMcWcKpSZQD4OwPKd9kdrZy/VL7Wei4wnSu8TWkTeJdbz5T4BELb52TIme9UXs8V1 7A4JUY3t3290Jskj6Rpa1BJ8+Kn3G43RTT0QleR9pSk0tRqWuHWBJJV0qRxvU/nZDjDhXsaILl8 B8R6kzHNHLctPbg/XMGeA6u6kkfvZNEVzFYLsNgkrLo7+0QcUMkI9dte2cA8fxaYYclUCagXfnB EHD8/PKmMtiThbeQCCfbi4aiv X-Google-Smtp-Source: AGHT+IHrrvfILBNWEhNV7XMQSmR0S8nHoKaZJjsiFHryRf1RqUPgUP6MkXc2ValXGBQCI1vagLTAeA== X-Received: by 2002:a05:6000:40e1:b0:3b9:48f:1960 with SMTP id ffacd0b85a97d-3b91100f193mr2267978f8f.49.1754992693349; Tue, 12 Aug 2025 02:58:13 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:16c8:50:27fe:4d94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b8e0b2d2fasm33098977f8f.50.2025.08.12.02.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Aug 2025 02:58:10 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 12 Aug 2025 11:57:58 +0200 Subject: [PATCH RESEND 03/14] gpio: hisi: use the BGPIOF_UNREADABLE_REG_DIR flag Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250812-gpio-mmio-gpio-conv-v1-3-8492f4a4c1e4@linaro.org> References: <20250812-gpio-mmio-gpio-conv-v1-0-8492f4a4c1e4@linaro.org> In-Reply-To: <20250812-gpio-mmio-gpio-conv-v1-0-8492f4a4c1e4@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Yinbo Zhu , Hoan Tran , Manivannan Sadhasivam , Yang Shen Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-unisoc@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1294; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=LGZlUs6AQDs8ng5Nn7ommqnFHh3w6/vhUJqzq5JniBE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBomxAmHBp1qfofMqe+al1PpQUT2nv72TJvV/tSC dbDQW6TtPyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaJsQJgAKCRARpy6gFHHX cuEuEACD9yCaDP2SiUwlOEFzSZLdWmr/Aao5dlNo1IQ84lWUR7l/e5LK6BN6YMzKATYfiioPgaz 4V3/DFMPo9kfYdzp0l/orxKzYWGpveBtOuL1FXuCL/boOBtikj9G7FXzp0iRcdHd9bTyUr+c/uT SXRr2wsbX0eY8bSrjfDBbmTKDLs9tFlKrSZVW8SXzj2TqXqiL2KopwLFHRBMXKGtqdRG7cEthcc 7nkB6HQ2h1y9Kl4HNngUVJVCIDBRj3ujuAQrxGgiLxN2m3ENkf3y4DjqpM3S+XolGf3Y3Om84/D CnqLQGvSVp4I2xLC36GHRf48xuo6EirL+ttZlCyQyEDQoeHYU17c+3osUGC3oi94llnqYMndyey vpUZTS/6mKzIC84s2vsOBoLHYytFwAWfDj6Ox/fLDJagdB6tFI0rcPaSd6smM0E5weHAKuNu1fU smjz0mME1HDeRVATjQ59yY/ADLm5eSifkk0ABGIEqaWvJSa0+33NEL27OPWz3PMJ1twrCcOKCF8 4WJVuzyRaM1nSm2RB2Nm+jKBf0xuEQFFaCljw2FYqF6mV9zBYEwbrb5XebrAb4rnFpG6B/Xb54U cwJqAmYkYB2S3utN0Fq2KpJ/W48akbXxxUT/4fDFjtsSMcLs/Bm8sVq/o0T76d2zoxDiXdpnv29 C29VhwWunWo/dIA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski There's no reason for this driver to touch the gpio-mmio internals, we have a dedicated flag passed to bgpio_init() indicating to the module that the DIR register is unreadable. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-hisi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-hisi.c b/drivers/gpio/gpio-hisi.c index ef5cc654a24e2327510b872563e68fb0b9aaef71..6016e6f0ed0fb80ea670ebb5754= 52d9ec23976fa 100644 --- a/drivers/gpio/gpio-hisi.c +++ b/drivers/gpio/gpio-hisi.c @@ -295,7 +295,7 @@ static int hisi_gpio_probe(struct platform_device *pdev) hisi_gpio->reg_base + HISI_GPIO_SWPORT_DR_CLR_WX, hisi_gpio->reg_base + HISI_GPIO_SWPORT_DDR_SET_WX, hisi_gpio->reg_base + HISI_GPIO_SWPORT_DDR_CLR_WX, - BGPIOF_NO_SET_ON_INPUT); + BGPIOF_NO_SET_ON_INPUT | BGPIOF_UNREADABLE_REG_DIR); if (ret) { dev_err(dev, "failed to init, ret =3D %d\n", ret); return ret; @@ -303,7 +303,6 @@ static int hisi_gpio_probe(struct platform_device *pdev) =20 hisi_gpio->chip.set_config =3D hisi_gpio_set_config; hisi_gpio->chip.ngpio =3D hisi_gpio->line_num; - hisi_gpio->chip.bgpio_dir_unreadable =3D 1; hisi_gpio->chip.base =3D -1; =20 if (hisi_gpio->irq > 0) --=20 2.48.1