From nobody Sun Oct 5 01:47:26 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ED802E2DCA for ; Mon, 11 Aug 2025 18:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754936262; cv=none; b=illfOVTLSJ+m6QCz8niNxwl7FwbZ1Ih5wlAR1+U++ipQYB4pjGHscp/dudIdjJiW3ONGyNZUJo76ta+JNqtVNlQ0tkOCHu72hR7gNa3+36gvGi3jINVZEjOiwrOICu/RJGnfHTt9L2uTv3dMaD7laIeoOnwZzdjeBHjBM9iWWC8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754936262; c=relaxed/simple; bh=gnLa9WvyRdjIUFjfbMI1N4aTtFJiDEPN/R7F6YbjB9M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ApxR5FCvuPNC8c4Md3TempaSHTKZfulXK3s6F1De44tilf9+CCyf4NYYLtE642r6x/DmLDL9fc+U33cLBjLxVoeBqeYkOzxCO3tzLK7o8wkq38VTseToFZnhgqj3E0WRNAvsKlBdgYoMjbNmhFR3h1C8+ugrN/43RO9IRzlehtg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YZkXJeB7; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YZkXJeB7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1754936261; x=1786472261; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gnLa9WvyRdjIUFjfbMI1N4aTtFJiDEPN/R7F6YbjB9M=; b=YZkXJeB7BROifefMXoLoZf7/wPDt+DHkoDn4KvZVuG/PGmv2RKCJk/Zb 354HUoWxYNWbsTetahiiA0RYHDFc11cC430lvltdud8LY/FM7PL22iAKo g1UWCGm+LvSwE1vvqeX+Gdjs3zmgiX1VTR3gt9RpLRyyCsN4zdcZXkWZD p1WZDhUbQLXHHqnkG5ywrxN4mZw1ly/dP5j6MJ3Fd8hIR3D6astQ5Lg8v 9PbswOnTmEzVsBF3uSc3bwkiPNTJg2UFeW6XIZVnTy8Az6jwxh2lp47Bb k80C4WMLm+hxh1DyM1LsOw6DCfS2cS9hVWia3n8BgzIhQgp97xNRIHkxy Q==; X-CSE-ConnectionGUID: t26UEsBuS0amyoCy40dTWw== X-CSE-MsgGUID: 6nQmyErmQ3GK/stIxctkOg== X-IronPort-AV: E=McAfee;i="6800,10657,11518"; a="68277382" X-IronPort-AV: E=Sophos;i="6.17,278,1747724400"; d="scan'208";a="68277382" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2025 11:17:27 -0700 X-CSE-ConnectionGUID: /FtfbUo3QRChOZIC8+aMDg== X-CSE-MsgGUID: lP23JNMuSN6SmvVVc9cE9w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,278,1747724400"; d="scan'208";a="196825635" Received: from puneetse-mobl.amr.corp.intel.com (HELO agluck-desk3.home.arpa) ([10.124.221.229]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2025 11:17:23 -0700 From: Tony Luck To: Fenghua Yu , Reinette Chatre , Maciej Wieczor-Retman , Peter Newman , James Morse , Babu Moger , Drew Fustini , Dave Martin , Anil Keshavamurthy , Chen Yu Cc: x86@kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Tony Luck Subject: [PATCH v8 08/32] x86/resctrl: Clean up domain_remove_cpu_ctrl() Date: Mon, 11 Aug 2025 11:16:42 -0700 Message-ID: <20250811181709.6241-9-tony.luck@intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250811181709.6241-1-tony.luck@intel.com> References: <20250811181709.6241-1-tony.luck@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For symmetry with domain_remove_cpu_mon() refactor to take an early return when removing a CPU does not empty the domain. Signed-off-by: Tony Luck --- arch/x86/kernel/cpu/resctrl/core.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resct= rl/core.c index 448c2bf9837d..911100994fcd 100644 --- a/arch/x86/kernel/cpu/resctrl/core.c +++ b/arch/x86/kernel/cpu/resctrl/core.c @@ -603,25 +603,24 @@ static void domain_remove_cpu_ctrl(int cpu, struct rd= t_resource *r) if (!domain_header_is_valid(hdr, RESCTRL_CTRL_DOMAIN, r->rid)) return; =20 + cpumask_clear_cpu(cpu, &hdr->cpu_mask); + if (!cpumask_empty(&hdr->cpu_mask)) + return; + d =3D container_of(hdr, struct rdt_ctrl_domain, hdr); hw_dom =3D resctrl_to_arch_ctrl_dom(d); =20 - cpumask_clear_cpu(cpu, &d->hdr.cpu_mask); - if (cpumask_empty(&d->hdr.cpu_mask)) { - resctrl_offline_ctrl_domain(r, d); - list_del_rcu(&d->hdr.list); - synchronize_rcu(); - - /* - * rdt_ctrl_domain "d" is going to be freed below, so clear - * its pointer from pseudo_lock_region struct. - */ - if (d->plr) - d->plr->d =3D NULL; - ctrl_domain_free(hw_dom); + resctrl_offline_ctrl_domain(r, d); + list_del_rcu(&d->hdr.list); + synchronize_rcu(); =20 - return; - } + /* + * rdt_ctrl_domain "d" is going to be freed below, so clear + * its pointer from pseudo_lock_region struct. + */ + if (d->plr) + d->plr->d =3D NULL; + ctrl_domain_free(hw_dom); } =20 static void domain_remove_cpu_mon(int cpu, struct rdt_resource *r) --=20 2.50.1