From nobody Sun Oct 5 00:12:22 2025 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C213929BDB9 for ; Mon, 11 Aug 2025 16:51:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754931099; cv=none; b=gcXKtqmgQxomK/XPlnYOf2pI0ZIsljTxcV67jS69Rk5ZVRMIVvynzEi949cxBrb2KdWHSozu5+FvvPCs2/LGs0dWFE/9zslTrm/n3CARdYU5pf4ya693QXTjkNS+eDU5yce/ltzMsJR2E5LWOteCaadCwPQkFueDVL9EWFSXIgI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754931099; c=relaxed/simple; bh=pZ1YEM+fTKhwuKz7ombDLOpoW/klWGD6VizkuuMGbQ0=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ipWJ9lnKbQH/3HF5iEmbIHS4JWEQFLtxp8i4NcOyu492NuEOz5giSisjh79t0ccWbkW9ifgLG+VLDoz6madnSCRAfY+cDBhuQ9lBDn7qHpPOLYKUgGtu2r24+QjC00rMmMG2C6Et778yEp76Z2ERbiOWt9Ix1iay2H8b6NVE3SE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e8CromvX; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e8CromvX" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-23c8f179e1bso56730295ad.1 for ; Mon, 11 Aug 2025 09:51:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754931097; x=1755535897; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=V59vbtFhyjRpFQ5fJVEOadJDZUONYR/hv3IrR/WcujM=; b=e8CromvXX6a5voQTfIxN7VLqzOec9aPI8N8QhtkzACSygG5T1uZc1gOvhjDCfwqnwr WdoxvfvhkSJu8VGzgqloGRSwAXb77KQYoiqyqv7Y5pvm0IgLXpcdeRvDcgS43VDLLZ7F Vs/6Qr8/qDk/Iyb7n0jmAK/tpQX2jX/a7gOLiPe2RYUksaw7yDToqVY5l35lUoi8e5aa a3cYKKIZGWQS1FjJ4FzG12AEloJnEQ2Vosa5SQ2iATMrOsTs/gXZ0V3XnHOs3ljaJB4H dp5z96+2HHcPpkeES2e2BwQoUqsGocR2s/hoU6nc3x6eiSIUHx5GDstfqFGtlgMfxql+ ud2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754931097; x=1755535897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V59vbtFhyjRpFQ5fJVEOadJDZUONYR/hv3IrR/WcujM=; b=FPlcUzOguWC7m2nNtTFtCkfM+1gLxfg19bd5U0B5SD562vZGb6ezv5K3B5EzXoArTw x/3hBUfQuE4I67id+XaN6cqGMupMrFLJcrr09hn0SWS0HrWGTBEB6aeOCEd5ALeBAgfD q04XkisLrZyH7+J5ZMZ3KVdGM5OZk9oKFnWpot33fkhuiPxx8cmQvqbbrfJlzVnRmqp5 t+IX5NudCfMyEdp6fCGCa75fNUvViNgZb7fB0LRvM1z7t4Or6iq7+5AyU48l5DC/RqHZ hT9fu03G8UwdX/fiv5uXzmCLGlsmjYXWbfj8MP/Nm46x32R9YPPFo31cItWWgA2eJrQ6 RCBw== X-Forwarded-Encrypted: i=1; AJvYcCV6FYcl/1oIQwa/s/uvm9F9YVCk9lzk8UGD48tyqTYlirf4l03foO8RJahWrqTBfNNHmH5OTsPtEOfx2m0=@vger.kernel.org X-Gm-Message-State: AOJu0YxbH7DMiImszN8JcfTbvaDcnbOfMylJyvykl0aZvY7lHLsrdQOZ 6p5fXAKI9T52Nbrpy9BsDQcSCtFKM5BRDcMJfUMK6RUyxd0lXUEecoNF X-Gm-Gg: ASbGnctgFyeOxatqgzDfdxdD4f7ynkyJiLSe55ZxuCfP73wVeiWgoyOZ4eejUKtw2CI I5VMUZUpsMp9wiYd42W9IbQvHi8ovfjm0iMlj7CXT33+X6NLL7UK/dYi4eah2qdQxiN/td8i+Fh 6/2MI6pb+z1Fj9e2vA8yUTBYrhegs9HrsstWhlhPVKTeSSA11WI9qAFvOgE4gLslN/iQnjGDbGS /7ko8NEItcQcPB39pzkivg4Ji6nMePUe9CrulZS+Vr9yF8zSgF+RwrKogm3keOoNqcvjdqApKJ+ k+deroAKpSv+unjrgsG1OdBJotwQPbsnOrTx+i6w9+70rPbg+h/lzXVirTFn2SLk+m9lhBrhWcL AIl9FQ7T4e+/cAZKT6B8PBbNA1LkP9rJ3 X-Google-Smtp-Source: AGHT+IHrlZuWLZF8EU4mdBEryzaojxXSQaEV+/9U9HehfZdfYG3EEBW/xI/YXxLD2sNk9njvPGHeBQ== X-Received: by 2002:a17:902:fc4e:b0:240:469d:beb0 with SMTP id d9443c01a7336-242c21fc427mr228926965ad.31.1754931096947; Mon, 11 Aug 2025 09:51:36 -0700 (PDT) Received: from localhost ([216.228.127.130]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31f63ee49c7sm31908373a91.21.2025.08.11.09.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 09:51:36 -0700 (PDT) From: Yury Norov To: "Jiri Slaby (SUSE)" , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Thomas Gleixner , Frederic Barrat , Andrew Donnellan , Yury Norov , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] powerpc: pci-ioda: use bitmap_alloc() in pnv_ioda_pick_m64_pe() Date: Mon, 11 Aug 2025 12:51:27 -0400 Message-ID: <20250811165130.37552-2-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250811165130.37552-1-yury.norov@gmail.com> References: <20250811165130.37552-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Yury Norov (NVIDIA)" Use the dedicated bitmap_alloc() in pnv_ioda_pick_m64_pe() and drop some housekeeping code. Because pe_alloc is local, annotate it with __free() and get rid of the explicit kfree() calls. Suggested-by: Jiri Slaby Signed-off-by: Yury Norov (NVIDIA) --- arch/powerpc/platforms/powernv/pci-ioda.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platf= orms/powernv/pci-ioda.c index d8ccf2c9b98a..e2b0132fb6a1 100644 --- a/arch/powerpc/platforms/powernv/pci-ioda.c +++ b/arch/powerpc/platforms/powernv/pci-ioda.c @@ -292,18 +292,16 @@ static void pnv_ioda_reserve_m64_pe(struct pci_bus *b= us, =20 static struct pnv_ioda_pe *pnv_ioda_pick_m64_pe(struct pci_bus *bus, bool = all) { + unsigned long *pe_alloc __free(bitmap) =3D NULL; struct pnv_phb *phb =3D pci_bus_to_pnvhb(bus); struct pnv_ioda_pe *master_pe, *pe; - unsigned long size, *pe_alloc; int i; =20 /* Root bus shouldn't use M64 */ if (pci_is_root_bus(bus)) return NULL; =20 - /* Allocate bitmap */ - size =3D ALIGN(phb->ioda.total_pe_num / 8, sizeof(unsigned long)); - pe_alloc =3D kzalloc(size, GFP_KERNEL); + pe_alloc =3D bitmap_alloc(phb->ioda.total_pe_num, GFP_KERNEL); if (!pe_alloc) { pr_warn("%s: Out of memory !\n", __func__); @@ -319,7 +317,6 @@ static struct pnv_ioda_pe *pnv_ioda_pick_m64_pe(struct = pci_bus *bus, bool all) * pick M64 dependent PE#. */ if (bitmap_empty(pe_alloc, phb->ioda.total_pe_num)) { - kfree(pe_alloc); return NULL; } =20 @@ -345,7 +342,6 @@ static struct pnv_ioda_pe *pnv_ioda_pick_m64_pe(struct = pci_bus *bus, bool all) } } =20 - kfree(pe_alloc); return master_pe; } =20 --=20 2.43.0 From nobody Sun Oct 5 00:12:22 2025 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 280CA2C21D2 for ; Mon, 11 Aug 2025 16:51:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754931102; cv=none; b=hAQj1fGv07cfMwdS5dRJyw5PENwkVL3qxp99McB20BfJLH1fsIlfXCSjXisvK+GVZJSCNGQLlbQaj+2qReSS507/eF6666S+FwSzecFxAScVEHVcrcCodwC3lCl109kWXiWOpDba2YfyoFzY/nAcT9luQ7bUvzZUD2nArwolaSs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754931102; c=relaxed/simple; bh=e9yKw4eA58BTZKeDv2Jej1x0ccHoLMbCSmGwGW2NjKg=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iNphGn9yu02mOVgk35RIFJTxij3yd/8MxdFUcG8+3SsXNRit0mIoJRUinNk1+zvfc7piFTqfsdrwQDsvXnSCmUfw/sXfHKV3rgMDaHQyK/1vV/XEgI1k75eiqTR41NKf4YSwoSzQsz6bmMdCEJZfywwTC7IWX9WGqy59qurOub0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=giBcKOCU; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="giBcKOCU" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-31ec651c2a1so3735275a91.0 for ; Mon, 11 Aug 2025 09:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754931100; x=1755535900; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=TpaBsV9SP95dUvhDAYzFMq9u9AsNNIRTwXToAnWSLqY=; b=giBcKOCUv623QF/8SXFRO0uUs108TR4AOvCOEQo1xeAxIHFKazTXLUrBO+/H8h8Giz aFzHvaMIqt40zx70NZTNd8G3wcIcFmTr4ajAA9LgmLLSbIjhORis3nVZhY4EGMCT4/jo 3UDv4vERY0dybk3ERG31258owHoy9n6UbQS8gznQm+MKdTC12C8nXX4m3si/+IbgoR5q wow3LmhS4fpTXDFn3YbceTxejJDbUdGaISKeFpVeIO6rnVOASQo+llRaRoWABjbux/r9 KPUcCFx5tFcdtTc8QUAeyk3scOhbp67NPpZ38j53UNqHnu6Ed+ZrW7kBdSqiFvDmctRb NT8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754931100; x=1755535900; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TpaBsV9SP95dUvhDAYzFMq9u9AsNNIRTwXToAnWSLqY=; b=a2D+bT9Q2yXnWC/KSebhTEqieGpgUIVI9b5wbwj/ZD84qipZFJwWSNL7+iPJZ/MQ3X uFDswRdMumqb81PIrIGyRiQqS/z8SPYgOXkgHpjN3ovth5jDSozyBAd0SfZGy3txvzZ0 CZBi5jaSNKXl4SawINwN640hRmnOL8DqHacnscjq3Yx1SXeC6a98vaUatPXzA1MD1EP0 s2OSIoXycFiXT7hquQLnsQYDsgMDfzGxhhiKVLMKlylkn9c4KYdSf9m5yDiwmOvxKu7K G8laZwQo15UNCorzXbtwzVssr7PrkCkvOC1+LhcmSolshMIRJiNyOFIK/ofOeplZKoCg t4GA== X-Forwarded-Encrypted: i=1; AJvYcCV5RKRu3C9Jpx6kXysDuGZoRajkaYMusc0Tts9vqB7XsJqQiGOGkB4YCN2wMaqDlU2rINatqmD2Ib70Dwk=@vger.kernel.org X-Gm-Message-State: AOJu0YxlgeuUHZ1zwI8bh8q78MaHYrzKg8ZQkVsgkAyOS35GcNWKD5jh UTc6CHp9qpfVAFM40H99GI0egHx/X3xcG3eK7gPI57H1t+jQJVN21Vw2 X-Gm-Gg: ASbGncujy16NyAntW2IvpSTrc+GoQls92uw0uM/AiVnX/OvWopUZIqploD52P95PTSm iCWtBqgcpmdhCsUpL5UpQtWM2Qyve8uiF4VPtFO9o7j6jwWtT50T2enYsoLPdPgxXZiAizP/4Q7 NK96pYKU5CqqbWAEEK83GvwY8ZzIFrLYEqeUzSwpv5K2yIZsgXaJzyVVpXGCc+jBOtuA5Uv4liT qvtrLMwhGZnyhfBdzZ/uGM+NkjlD8yoCpecwkl288gkwR75HezAjQZpUwb/Zdz0DPf1ectxtoi+ e0odcx9FI7Odw/kg5xRwAuxDb7gMgZ5bawFtD9e2/KwMa9+e6LtcP0vAMV8mMW8zUUID6Rzo7jC SfBp0K1oCr/vIPfhPBlF7DSQs3XswZ8+k X-Google-Smtp-Source: AGHT+IEnMob+OASgMciN2iOwD3AQExjTZg0txKEu5PZg0AB3URB7DM8uN2lLQYYlMVfKbzDw45a7AA== X-Received: by 2002:a17:90b:2fc8:b0:321:87fa:e206 with SMTP id 98e67ed59e1d1-32187fae455mr15484709a91.20.1754931100403; Mon, 11 Aug 2025 09:51:40 -0700 (PDT) Received: from localhost ([216.228.127.130]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31f63da5719sm32201110a91.6.2025.08.11.09.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 09:51:39 -0700 (PDT) From: Yury Norov To: "Jiri Slaby (SUSE)" , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Thomas Gleixner , Frederic Barrat , Andrew Donnellan , Yury Norov , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] powerpc: pci-ioda: Optimize pnv_ioda_pick_m64_pe() Date: Mon, 11 Aug 2025 12:51:28 -0400 Message-ID: <20250811165130.37552-3-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250811165130.37552-1-yury.norov@gmail.com> References: <20250811165130.37552-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Yury Norov (NVIDIA)" bitmap_empty() in pnv_ioda_pick_m64_pe() is O(N) and useless because the following find_next_bit() does the same work. Drop it, and while there replace a while() loop with the dedicated for_each_set_bit(). Signed-off-by: Yury Norov (NVIDIA) Reviewed-by: Andrew Donnellan --- arch/powerpc/platforms/powernv/pci-ioda.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platf= orms/powernv/pci-ioda.c index e2b0132fb6a1..325197ac19e5 100644 --- a/arch/powerpc/platforms/powernv/pci-ioda.c +++ b/arch/powerpc/platforms/powernv/pci-ioda.c @@ -295,7 +295,7 @@ static struct pnv_ioda_pe *pnv_ioda_pick_m64_pe(struct = pci_bus *bus, bool all) unsigned long *pe_alloc __free(bitmap) =3D NULL; struct pnv_phb *phb =3D pci_bus_to_pnvhb(bus); struct pnv_ioda_pe *master_pe, *pe; - int i; + unsigned int i; =20 /* Root bus shouldn't use M64 */ if (pci_is_root_bus(bus)) @@ -311,23 +311,16 @@ static struct pnv_ioda_pe *pnv_ioda_pick_m64_pe(struc= t pci_bus *bus, bool all) /* Figure out reserved PE numbers by the PE */ pnv_ioda_reserve_m64_pe(bus, pe_alloc, all); =20 - /* - * the current bus might not own M64 window and that's all - * contributed by its child buses. For the case, we needn't - * pick M64 dependent PE#. - */ - if (bitmap_empty(pe_alloc, phb->ioda.total_pe_num)) { - return NULL; - } - /* * Figure out the master PE and put all slave PEs to master * PE's list to form compound PE. + * + * The current bus might not own M64 window and that's all + * contributed by its child buses. For the case, we needn't + * pick M64 dependent PE#. */ master_pe =3D NULL; - i =3D -1; - while ((i =3D find_next_bit(pe_alloc, phb->ioda.total_pe_num, i + 1)) < - phb->ioda.total_pe_num) { + for_each_set_bit(i, pe_alloc, phb->ioda.total_pe_num) { pe =3D &phb->ioda.pe_array[i]; =20 phb->ioda.m64_segmap[pe->pe_number] =3D pe->pe_number; --=20 2.43.0