From nobody Sun Oct 5 01:52:59 2025 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021138.outbound.protection.outlook.com [40.107.51.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B46D2DC34C; Mon, 11 Aug 2025 08:59:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.138 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754902758; cv=fail; b=WpeMh37iwoeWf5qKZibxIGf0fdJxy+edHMIkBDT480+RE9qdPWPD44PUX26qyfy5iHdogsai9bsMLh4wO26gTqvJnqVuc5YvqvroykEHWiuWBluNO8pr8CoV4WL8MlTjb4PxUVN2MXXJbIzM78BbEMc+4Mfl9P3Mg1xnxblyR6Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754902758; c=relaxed/simple; bh=jr5lp16Byqkn3XmopsMph8KlenM0DbIzdn/3mF/XjuQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=jPRhLi5Qk+xKyPB1wj6richYOAGxozEfXAAj2eiemx+Flpoasep899Kg07b1bCyZlY/MFrbspLOd23beJtRBRet86dOgs0qELfgumV0pVZ6Z8zIe0bxHkTMTJGuGxqRONHNYSh1EC+UmBK+VhrmEUVK5coh69Vt2O1v6ctgoSLM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io; spf=fail smtp.mailfrom=siliconsignals.io; arc=fail smtp.client-ip=40.107.51.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=siliconsignals.io ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KIeDvFt31xh+2bUaDBjHnW9DSWW8dh0DVPe9zy7VcvciML0541ho8ZZQzy7ZekZdwriK/6Gsb8WB4DgSLteciFTNyFGEGOusPCFFvGdRESVOYmCDjnD5A2oahAa4rmBzUQ7CH6kX9vLD7aIbxZbMyshflOhTpjnwtCysofariATe1LiBOkAztH1i9ZLdbzxF4LsquE16vPFbLtg4LW+bJTqMABUvOwBghNQ3IxdORiqUN0F1lD8j4/NvQxzKbr7Ls4UDzsIkNEw175EXi1QCTIRLauCRSepRrdo/w2dDRIejAZUG58eZ8pHcdvKAzz3CsdDUWqwyIkTMJse1rykMug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FRwBmvmZcf0SGSEbKlgKOXEUoqe5xk7PCdFYgzxXM1w=; b=cIrYNYVrmrAhXdCUXW5WUhJW2Oznkl4jY6cvQpSPgSj79jplvopy6hT2j/bQpMEoSRa56hk+H9oDzRJoyEgdT0sJ9t49UdSjwPB+H4AQkbWyvvYZ7GT0XOFP6RIgWLVR1jasEDsCs5qwQyG5Kdwhydgq/2hbh79CkWRPdOCo2T+IDDG4kpY1fm/INPUqTeeavGt0PzdyKYWTpwZfxzI2993ZZ1ldSYpjMJM8dIj56wzcxxNA4i0bemhAwCQC1w1zBilaC9vERmPCACMpggPtfw1AVzDtSHq8Ig3ifoFPLFe6uCrqtIecz1rONdY33H33X8HoIc3eZP+XUCnomV3bjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) by PN0P287MB1716.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:18e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9009.21; Mon, 11 Aug 2025 08:59:07 +0000 Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418]) by PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418%6]) with mapi id 15.20.9009.018; Mon, 11 Aug 2025 08:59:07 +0000 From: Hardevsinh Palaniya To: sakari.ailus@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, Himanshu Bhavani , Hardevsinh Palaniya , Krzysztof Kozlowski , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , Hans de Goede , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Ricardo Ribalda , Benjamin Mugnier , Jingjing Xiong , Sylvain Petinot , Dongcheng Yan , Matthias Fend , Arnd Bergmann , "Bryan O'Donoghue" , Heimir Thor Sverrisson , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 1/2] dt-bindings: media: i2c: Add ov2735 sensor Date: Mon, 11 Aug 2025 14:28:04 +0530 Message-Id: <20250811085814.111073-2-hardevsinh.palaniya@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250811085814.111073-1-hardevsinh.palaniya@siliconsignals.io> References: <20250811085814.111073-1-hardevsinh.palaniya@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:2af::11) To PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB3519:EE_|PN0P287MB1716:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f265be6-0123-49cf-5819-08ddd8b55418 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|376014|7416014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mjnaa9eONrzWfOcZEZfRofucsokMa5R7EFSh6kt3vUcqn+KffoPE4QSSXA6E?= =?us-ascii?Q?DF9q9m9IW4RcC019A/Z+2OH0MkKHLR8Bt+Gtcr10EAM3w4WKTBAaF9ZbMKKX?= =?us-ascii?Q?5jFmLjVv8cpdabGYBFv1hBNk2mhUJJi3lJTbeY1tl6PSo6q5BqPhWtUQPjL5?= =?us-ascii?Q?s69ykFOwdIssHckbYC5YVVPXRWPZjgi7x3ZOq9Vq2sJkJl+kQ6w4bF/EMZRU?= =?us-ascii?Q?rLS3vLwLKEg+oY7AwnQcaWtrz61qxicOzwZeLXfdg0eeq27z9GTlkwlbIDgw?= =?us-ascii?Q?Zmcf96A2yPrLf6r74SFEP1W/IgnRXDhKyWs6/qHuR4NbxgFYkBD2gSvMTiL3?= =?us-ascii?Q?4RZUX6RchSzH1Oc78bOez9EimG327DrqTu2mvigLGfKnmSQ3x+YgmDIrQaP3?= =?us-ascii?Q?14F9u8BYnokSxC/ZQ0wKWqSk0RyOBfGNC/NlxzHHi5wQHTnIhqFsbz9aNfTK?= =?us-ascii?Q?ln4+XgGvXI6TNvbtHjY+2Mxuz6YHNJA7TCOzCehJ3M29wACChpiEM+XGkqy0?= =?us-ascii?Q?pjlJdOCgufLufInE+z2JiVfaRIXE0Ce/IH+2+tP3ttbndNNi+lpGl13E4WJL?= =?us-ascii?Q?K/Y2T1cItbEBuOggRq9fED81YQiGQtYydooSQ/FxqhffXJHZ3ZWstvg+I8Ed?= =?us-ascii?Q?Z7RNNdv1jYnhLFse7nI0HmiCpC62Vn1y2yHvPN0OwYceobNiAclHDTiEL0Nm?= =?us-ascii?Q?NOKmI0c8odH0O3Kzd80bsH65kK/8oHfI98tClHh6aVAwrJkidTy+Iwf01BvH?= =?us-ascii?Q?UcxwURlK1t8QS6RX+BwEVA5XlRyt1AXnJNRj0bwvXb83DHGcJkhfcZ3QvOr5?= =?us-ascii?Q?1pzRUYFVZAxZ2033YsHlZSQPvFhnEeN6Q11AN8gXzB+DX019nuM54bf5maBO?= =?us-ascii?Q?fq972CP8bLr4GgfgoirEEeXVfNb986UOEbUAdRdtwTz71Arpy7G79XiJ3x8k?= =?us-ascii?Q?m4/Q+V8IWdtM03L0+NPGYoKj6ILRrAOCtRJ9cfKK6M54BI+bMEys2ZyAeGhY?= =?us-ascii?Q?o28V2BQKVet+jUh8824T8H/P5nidDNnSA6RdIux1rzKgdWKMFNgEP5VnUj0D?= =?us-ascii?Q?zuOafLN5KeEhO1ZTSkwHVUCRwn2l4+OnwcBzZsjDTgcO4VOmyu86ri74JCVU?= =?us-ascii?Q?ovynezpoThvKHEn+1v992PpV7Y4E0AL/ImGxDtjN0MKVEsznp+9DloodZMqd?= =?us-ascii?Q?sx2mB93mjb4P8Am44fTC5xEHUtTZDOOISQ5otUttYDqU8fzJMLs6LacDjOj8?= =?us-ascii?Q?YEOMHrZ9pykZPTvCt8zRD4opyH6s28yCq8pTMGytRhF5WqIiVpINVxNTwC3v?= =?us-ascii?Q?JW6lYuUWt/MFaZ7u7Kk+MZdT+Wt05ly/NfAwolQcCbcRk3im78lt6fT2NuO6?= =?us-ascii?Q?7sHbEdkrLtrY5B8m4tNsgjAHWGrg8rL+tfBT9UITcMWe8kKkG3DyVV1i+TI3?= =?us-ascii?Q?V7JK0laKPOk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB3519.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(376014)(7416014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U5ydF58CAMnnoArBPlvHr4p5zg7PQ8qfDBLJNs7bgKDK8s1E+F/xTAiWaKfO?= =?us-ascii?Q?vuyUrwm8oDqC+DJkdbwqz4rFW3tVlBYvbVQEBozjZ6vW7sfUM6kIAZ7+snCr?= =?us-ascii?Q?Q/lBsy93s6oLPg37crrCjSfaY8s0UbTmZP7mzpiT/17GNrn2mMxayKDzSeyM?= =?us-ascii?Q?s0qk1fORHTOm9WPfjjJghvvGdqml57OzQvzQPJvecuPgG3roRNei7cpviED7?= =?us-ascii?Q?N0w+8VCeIVXAC/jz82dQIskf9ynwZ4aw/pn3tWXOSQPb36FUGpV7JBiuLZnV?= =?us-ascii?Q?cfbs6rWg+CpfOFzEQnMdxXpY18lE2nz3acjdqwB1+jaXjsA1YxDMzrpBnjCl?= =?us-ascii?Q?tcSKcCIBCQiMBkkySpiFFjKJsYhBZ6NP8n4+MkMZA9il48SqvoPL5ZUXvks7?= =?us-ascii?Q?IBhaHpnGfNBh3TwABrPHuhXZ2s0jyJNAzYo2wt+Hx5RYb1sSTCknwtE12+qf?= =?us-ascii?Q?Tir+ctdJDtV7hfEoM4DGQqg4g7UVZmU8/jzq4U0sVss3hRrfkDq7AjWlJFAx?= =?us-ascii?Q?t/ioM/Z2PEn0+vRQjB7HqqiuLLOmVkzlX4TDIf7QQJVIFvBk6sp5ohRHBJ5b?= =?us-ascii?Q?chEymkQzH6HGzaGXppx6e2zm9EFHzMykxVmKq+gRWX4zpNh5EKBMdpzAtQXZ?= =?us-ascii?Q?1OVXpPtDtO2OlMEWdPS+N/JdUwlirqvIJJb8qQX7QqTni/CAoLTgPSZMZ3k9?= =?us-ascii?Q?gNVBLP6SzisO89iYFrhW7q7asewywtDab4SOQ/uJm4vtFhl6kYwzFaOj25pw?= =?us-ascii?Q?Y1zul/VD3VLaVGfYj3Sg5hTGeWBXvLTntvnOEWKT63s8d4hOKcTzCN6k1rsB?= =?us-ascii?Q?Bzplf7qRD3N1+bO0aWSwRkPjkjSUE1e7LwOWto7vTCzeF04AeGO6N0fySDbL?= =?us-ascii?Q?r02mnMQ/08T92vqIpolqd/qpthUsGWp7jPJKSJnZYPtGgjXhL4EaEAX64Rwj?= =?us-ascii?Q?9ZN9poORrsXlf3NqlCiZW7wAVwDKR+KIzxM+ANPPD9CvEBLqG8u0IxgRHZ5D?= =?us-ascii?Q?wHnxi8X1mcVWr8EUSgxHBCM9XLMJ24gsc37ZdYKeL+e60Kb/8JIw+H9J5H3+?= =?us-ascii?Q?dBqQizDr4UYevUsNnLGud3xeR99mXHX5WuyI1YkujZKwcQYx+fyW9XFJydGC?= =?us-ascii?Q?rZZjfzarZI6tTtQgFLYBLsIz3MCCZ+7rRWELoA9lzzsnJP/yLS4GhQWLD6OM?= =?us-ascii?Q?p/9DAqDE81VrhTi87nbUJEvtXMmOXYlDpEYvIUsAszQ+yUyqocmWpo37DCqD?= =?us-ascii?Q?NJ0sX/HbJLVMbNnVkb04K7dfcnEFx5tEsfUZDPQBqc2N1Qb6dVZhemLD+bhJ?= =?us-ascii?Q?8CFP6eA+FGq5KxpLZBK9y9YkjF7+bHbhkcJSL1CBfi/imldXVYJSngrMsMCd?= =?us-ascii?Q?o5yeafBx07eV8K4sWvkMF7uDYyOqw0S/jLYJx1e5muk9AtcqwNDd2w4hNKFC?= =?us-ascii?Q?MIatgw4cG1Nj+aYJwi/vZ1CfIMQuTqntp+CBV9Ui8AZgxX110BTqfZTiyEc+?= =?us-ascii?Q?E2RlndDBnJzR20Tra/je+B9sPbl7+XcNzyTopTHlUu4drCI0M9567+/FIgf3?= =?us-ascii?Q?yZdhJz61jVl5wdmJTbzUd7fgUbJadQcDt4WBP7J/qi4fi/cxxRRokxQj7LaF?= =?us-ascii?Q?CKmPD5b1pYXtYNB6LyP2UCc=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 8f265be6-0123-49cf-5819-08ddd8b55418 X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB3519.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2025 08:59:06.9799 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Om38YZ876qbMBV12Cbb5J1EqfafCuPD18z1Bp4nIFdh9Fv0mgPQWzoOgpeZqWRrIWuVsBTM2bJzQMcNXLEPjt3neVz/4IgaUIgw7pJydohEr+esZJHybSdfHTNeubUdb X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0P287MB1716 Content-Type: text/plain; charset="utf-8" From: Himanshu Bhavani Add bindings for Omnivision OV2735 sensor. Add MAINTAINERS entry for Omnivision OV2735 binding documentation Signed-off-by: Himanshu Bhavani Signed-off-by: Hardevsinh Palaniya Reviewed-by: Krzysztof Kozlowski --- .../bindings/media/i2c/ovti,ov2735.yaml | 108 ++++++++++++++++++ MAINTAINERS | 8 ++ 2 files changed, 116 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov2735= .yaml diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml b= /Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml new file mode 100644 index 000000000000..bb34f21519c8 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml @@ -0,0 +1,108 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ovti,ov2735.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: OmniVision OV2735 Image Sensor + +maintainers: + - Himanshu Bhavani + +description: + The OmniVision OV2735 is a 2MP (1920x1080) color CMOS image sensor contr= olled + through an I2C-compatible SCCB bus. it outputs RAW10 format and uses a 1= /2.7" + optical format. + +properties: + compatible: + const: ovti,ov2735 + + reg: + maxItems: 1 + + clocks: + items: + - description: XVCLK clock + + avdd-supply: + description: Analog Domain Power Supply + + dovdd-supply: + description: I/O Domain Power Supply + + dvdd-supply: + description: Digital Domain Power Supply + + reset-gpios: + maxItems: 1 + description: Reset Pin GPIO Control (active low) + + enable-gpios: + maxItems: 1 + description: + Active-low enable pin. Labeled as 'PWDN' in the datasheet, but acts = as + an enable signal. During power rail ramp-up, the device remains powe= red + down. Once power rails are stable, pulling this pin low powers on the + device. + + port: + description: MIPI CSI-2 transmitter port + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + items: + - const: 1 + - const: 2 + + required: + - data-lanes + - link-frequencies + +required: + - compatible + - reg + - clocks + - avdd-supply + - dovdd-supply + - dvdd-supply + - port + +additionalProperties: false + +examples: + - | + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + camera-sensor@3c { + compatible =3D "ovti,ov2735"; + reg =3D <0x3c>; + clocks =3D <&ov2735_clk>; + + avdd-supply =3D <&ov2735_avdd>; + dovdd-supply =3D <&ov2735_dovdd>; + dvdd-supply =3D <&ov2735_dvdd>; + + reset-gpios =3D <&gpio1 6 GPIO_ACTIVE_LOW>; + enable-gpios =3D <&gpio2 11 GPIO_ACTIVE_LOW>; + + port { + cam_out: endpoint { + remote-endpoint =3D <&mipi_in_cam>; + data-lanes =3D <1 2>; + link-frequencies =3D /bits/ 64 <420000000>; + }; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 92e9d8c7708f..474eefbd1363 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18471,6 +18471,14 @@ T: git git://linuxtv.org/media.git F: Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml F: drivers/media/i2c/ov2685.c =20 +OMNIVISION OV2735 SENSOR DRIVER +M: Hardevsinh Palaniya +M: Himanshu Bhavani +L: linux-media@vger.kernel.org +S: Maintained +T: git git://linuxtv.org/media.git +F: Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml + OMNIVISION OV2740 SENSOR DRIVER M: Tianshu Qiu R: Sakari Ailus --=20 2.34.1 From nobody Sun Oct 5 01:52:59 2025 Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazon11020095.outbound.protection.outlook.com [52.101.227.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48C6B2DCC11; Mon, 11 Aug 2025 08:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.227.95 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754902773; cv=fail; b=pYRfdFO8zTuLOf1050t3jNw0PSLCga8VWcnLy92ubZ9n88SsmtfLgGGAfOGuxzcX4lVufzZx8bwOI25EfxHFpdJ7QUgQQhRsHCMt8AVMfEpPE8zsSEhkkJnNQ+rviNSeyoAeOGS2D99IJoXHNV71LP05ON4n1iZl8Aw+XFdcXSY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754902773; c=relaxed/simple; bh=7ixMh15Hi512nEv+uTLn6s9slBTEw4wLEE6DL9GV1Rg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=aO5ZAqfQa5Fx7hCIdHkKmgxlm1US/duY+ZKZWpqpMn1lL5GLeBqcNwAA9b1OwkR7mS+CQRXDfpFj/qIRCfq+/gn+wXAdY9fbitDaM5wNajn1996Do20pHBQKTixHFkyC8Zjdyr9PxmiWQ3BI4Hqhp565Ck9OpZEmVPli4NrUPmA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io; spf=fail smtp.mailfrom=siliconsignals.io; arc=fail smtp.client-ip=52.101.227.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=siliconsignals.io ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mnOuqPeTiy4E+ASqAJ1cXQL+sz2uFCdARbCIOkD+RPtkGRiS+tIxSckWOggBfefsJ/pewF3GUXOtvn3LVjOav6ULgFWQmVzzASiFAJp/06uDRKTbeJnQ339R2KNXzYNCfi+DH9D5G9rfB0D7BlzWRw0jqcwztHjxRYLRhLucznpVG5s9I5IjWA5V9IREVuC8fTkuSbdMYrCTu2u/D53pGKxoL2F95b9sb14HftJXQ7bUcceWnuBj+25bA9/3d1rYyc5BHH/p4V2w/3TNC+RsrKwiFNetQbFM0vAk9aSTLi1KcoI8Fe1LJcSW8jrfSGvDH2a8/FhUv/8wcaDc69oyWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=93n9njG2nOm8t6W1P66DZFqz7wT8dbmE9G51V7LOQt4=; b=iHm5sensWPpc9nx5ZLI8ZTTRCctl6gBKfP7lvO/1R9UPlKBaWaPl5GslpzpDnKzRz0sinrgGrCLIxnqIUYVMAySS6q0Cn8C7ILUtrdg+KQEO0ti5R78fTSs0miyfW36u2r1UgJ6MNEQG911QriLGXKfHO1mdLDTo6Y2QdcSc5uL1Tn9j8zMSse2vkC1WE2+RTGjv689sagtqiZSXpZFv0c3aENpArCYKj5IGbrxK9ZQ/Ta54niiNgFauC7Rr9DuIdZI99St1mm0We0quT2DXpUrHYfvKocaiQ8pHzQoN+7OO8qp7E0ZaAPA8kibS2fplAEKImGZ5uGgsqgnZK5GAaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) by PN3P287MB1317.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:197::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9009.21; Mon, 11 Aug 2025 08:59:25 +0000 Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418]) by PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418%6]) with mapi id 15.20.9009.018; Mon, 11 Aug 2025 08:59:25 +0000 From: Hardevsinh Palaniya To: sakari.ailus@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, Hardevsinh Palaniya , Himanshu Bhavani , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Ricardo Ribalda , "Bryan O'Donoghue" , Benjamin Mugnier , Dongcheng Yan , Sylvain Petinot , Heimir Thor Sverrisson , Matthias Fend , Arnd Bergmann , Hans de Goede , Jingjing Xiong , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 2/2] media: i2c: add ov2735 image sensor driver Date: Mon, 11 Aug 2025 14:28:05 +0530 Message-Id: <20250811085814.111073-3-hardevsinh.palaniya@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250811085814.111073-1-hardevsinh.palaniya@siliconsignals.io> References: <20250811085814.111073-1-hardevsinh.palaniya@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN4PR01CA0093.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:2af::11) To PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB3519:EE_|PN3P287MB1317:EE_ X-MS-Office365-Filtering-Correlation-Id: 841f14fc-802c-41c8-882c-08ddd8b55ed0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mZNjlClFm8GHiDBgZThehdfKY2UCkPihZ+Fkky4iL+grFMPnk/bwG57PPjYm?= =?us-ascii?Q?DQivpGCSf/RDCu7wNyRz9CanRhQlyTf7a55kGUJ8WCCDwVv/vQJDedTRcdFQ?= =?us-ascii?Q?vWMx/245nSRGr9rNVeYzc8KmauRnaLwnyJQ9NE8b/eyE1ln7QOV+Me4WT1W9?= =?us-ascii?Q?6mqndtYgwMbqoK78Ypj5IqC0YnkiUt6nesJ9c32qODaVugwL1kT1GjCg5nda?= =?us-ascii?Q?Vu+ryhcORPgs0XiXnSZVytFnVg7/ZuUTYr83GNcHaU8j3FI+Jaou/NnyTTlX?= =?us-ascii?Q?wF2W1vjtZoYWuId46ZRe9q5uRmRs6QaMue/OA66pbeEDZlzexWGirzP7cg39?= =?us-ascii?Q?ThwPMklytXhiuFzUnUvCKtF3p9glT95WzwsQg6qMu19gjunZ0rEtOjjRG77W?= =?us-ascii?Q?BtB3Z66hY5BW0qTBKx/FBwE4HivTz22+f8MMv/2iwkWUF1I8l9v8Pw3CLbw9?= =?us-ascii?Q?qXbNG4rxZVa6cMIM+Jxgw57u5318DvrNoEv3UFBZdZSfob9alaI2xZ2tfCMy?= =?us-ascii?Q?auMzjW+Rip1nwkssLeDSD53Yk4UzNWd2TpT2aWki5C2bRe4ugaY5x5L0drWz?= =?us-ascii?Q?trRUH0UMBUr2DRzbwkYnM0mmkSJrqjlVYH0AEcNt/zBQ7KofD+nLj2xvrTbp?= =?us-ascii?Q?Neu9E2WFqMj29PAWNvp6PApZqpWwARc+xgMrzx4tTZ1Eem4DcNPhqzpD4HhL?= =?us-ascii?Q?cXLHpi3TRzKKPFZP90XsKB4XrrHNehgDdalAHLVIMQrTzKlTNZvqpEFQHarS?= =?us-ascii?Q?67BZS4CwAg3XDvRYbriX5eLFn31AD+5YWTNbdZJmpcL0iOoUh00hRV0Q1g2Z?= =?us-ascii?Q?RXvOqXq2TWxm3eURMmI+OVaVyrcEIEJSgnKcZuNg0gTXXvaIG2txQOB5tFEq?= =?us-ascii?Q?1cVLtpuv6YLiqLoJOgFb8ZDMn1JIwUw9kYqrKrTWn3ZLozHTfWc8It5DtVwp?= =?us-ascii?Q?NEC5oyl8BtXdLaJPrnzTZucVghSEKql2hb1GpTM4qITZIuOb/Rw8BVUjez2i?= =?us-ascii?Q?k2qJvcknhbZ3N8SfFP+x70IygV//fPzYbd5LE+i3gItRZkxB7H0babO7YjoK?= =?us-ascii?Q?TJU5++mv0ITm+nSOrpSc8lWq7bHUQvHl1uhi2EufDJaV1X0skx5Uvhrael/R?= =?us-ascii?Q?QK+eUlEE9TjA3Y4j8W5Lscyr/Vp3BvZh8RIVNmGOKkUrguNnGy+HxMXVfR5m?= =?us-ascii?Q?odnMImMP6noQBaPvHAVuLWpGUu6nl0ok0MamOhb60aSLyjxF5cmNOshQjI6B?= =?us-ascii?Q?8W9l1XfDadHQ2GbvKf9WVEQP2kWA+/WCdIoUEBSeA/OWxa7Y6t51XnzHNDmr?= =?us-ascii?Q?7/zMMwknf3gzj8KRwtuujY1j84JbFQQfnpCBm3qo2wEyynDVs2CQQ4VmmHgw?= =?us-ascii?Q?xP/XBfzM5Cakfrk0Kjva17EMEhAGjqzOmK6G5C+JbaOihUOhsEX3hWRPHEZq?= =?us-ascii?Q?lwQwjcouMycPa3VVTIB1s1fKURj4jJ5YENovA4UjWE5SRDifXz9gCQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB3519.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M3PwphViBjHlWiqEPISHLaKcMdN6Xn3oynjkzxrPQWoScCXr6vTsDYIJFWRs?= =?us-ascii?Q?ChzSP9Bvua27iVmcDvmf08QWrCcgrClD6wfS5RqxtQ6K0rMfR7CXds3k198x?= =?us-ascii?Q?2hYxnTmaKix3tpuwAnn0naA0yE3VTmXMqYzhM3qCD70ktCnldwtzEtYdS0re?= =?us-ascii?Q?JFhGgQFdtbYOfRXN9qS0gtYeHcH+GE3UiEWLSQVckv4KX0Sf0wFVRrnUd9SF?= =?us-ascii?Q?aguAA9PmVYwwWgZbSZZMOICUgOOflT+N3T38f+qg5q0YnrIINJLVs16W7DSg?= =?us-ascii?Q?ISEk77vLEXXTY4qW//CcsvABtCGj+6eV4ftCgL/IOXxzdHfRVB18ykqxfSiv?= =?us-ascii?Q?c7zr76HvgTDTr98QNJUG5IaeQQ49rKB5hZopvwBPda69YoU4PCuLJkvWHful?= =?us-ascii?Q?gX5NbSjVdubImGdIesiA/HLXenvcSG89TG1ZufqfsVYNdmrTW29NesKo4LRl?= =?us-ascii?Q?y1rv8Fhhc7mXERORP2+My7UNcqrFKmKlJkfGOjqY8mR4G6Bq3sPp9/KcEPg/?= =?us-ascii?Q?uefOhvG0xMZJCpqtGe76dTkn1wDYpghG6mkMHmNcCNUA07VOGuJgU121BPps?= =?us-ascii?Q?WnFnnPz4Wb0/4MV1RL384SkVXhGQSRUz+12w1iwz1I9ynyIRrjrKSsQSNCfw?= =?us-ascii?Q?GB9UgmBXe714dJkrMQV6/fw1S79Snd73OsmUBjXgJec0HFB2ov6v37K0/dY2?= =?us-ascii?Q?GuNfh2qHl6hfwn2DFd3YUqi9jab5dT9v1ero9CweDgKoYux/U/p1M8oQgftL?= =?us-ascii?Q?mElCmdzEjfreqyxucMB2nXzL7H7AUr5inQKnUyUABsqAsqm1R7PegUpUqUiV?= =?us-ascii?Q?WtkoRse58FSrZmI8h4LM9Ebd7Ef6bI52p4nQ9eluWgXG/Vd42rpKJqTPcaTR?= =?us-ascii?Q?trHjk4hScDLRunyRqNOgtVsY+lB4UC7R4vQPzlWwfVrBcvo4Ua3HXS1MJ2LD?= =?us-ascii?Q?jbRNTfix+e+NIBbtB/JfPK3kypmzPe8svkxsX5/9qWuR9pZa6lAZJbV53S1Y?= =?us-ascii?Q?h5RTCsKx58xce+fIWzF6i2h3gK9aIP8xzVSE4Ex0nqzsXMDOE/O02C6vzjiM?= =?us-ascii?Q?h95TKeXfPLULwQCAEA644G/4LpC54yzfW8nWIiJQ6PPho8l71PMQtpXk2xeS?= =?us-ascii?Q?vFzCaVJLfBoaCm6OE12U22Gdwd5gUsPor0P7PJO1Vbuak4mKq8digIn452NQ?= =?us-ascii?Q?5fWjrThbWocl1qQmEyAyHIklDd7nDVO8JBo87tnmBUoZbX/79qhyLNcJ6fA3?= =?us-ascii?Q?8yPxvB+uiVoAJIWdo/xB6CrHWcKs/J2naYsX9uW+htSzuYa0537eo5VURoCx?= =?us-ascii?Q?RHSII5ai+QUThAFyjkuvhPFdiUfSBV2aGNuEm59NTlyjhw2xhqlIu6oY6LSe?= =?us-ascii?Q?/WA8yaieQMvvKKLiXQO4ZJnFuZMEEk88v9xjmio3R4w7DQzKLYvh7w+Rge5K?= =?us-ascii?Q?X0+isXsJFYoDA85j7lYJZjTG3zYeAhvH8VgHAQIuFeHQDYaPW9uQi9DcVZW1?= =?us-ascii?Q?4YZW0sPz9ChSJhmqK9Vd3K3xkue/Sa00SM6VVe028clbySahc6H+rc7GsBEq?= =?us-ascii?Q?jNuDwGneXGRqNY4+uMMPA8T0dkdBOmWL8cZWBjHjHU8n1xdLiNHXYOh2y7Sm?= =?us-ascii?Q?M3RyeKnxTIB05EHAFaGlJ5Y=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 841f14fc-802c-41c8-882c-08ddd8b55ed0 X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB3519.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2025 08:59:24.9994 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /+mKYbt2PwLpF4HEkEoFCYsbUR/F5VCRrjX+rAAKBjc7RHDlnY86Gtbmx6OJIwdq2Z1rbEctwuTGnMB0+KOD33OsryR1iIgT9X9CHZe+epsH49eLdsGahtB2Et683KTM X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3P287MB1317 Content-Type: text/plain; charset="utf-8" Add a v4l2 subdevice driver for the Omnivision OV2735 sensor. The Omnivision OV2735 is a 1/2.7-Inch CMOS image sensor with an active array size of 1920 x 1080. The following features are supported: - Manual exposure an gain control support - vblank/hblank control support - Test pattern support control - Supported resolution: 1920 x 1080 @ 30fps (SGRBG10) Co-developed-by: Himanshu Bhavani Signed-off-by: Himanshu Bhavani Signed-off-by: Hardevsinh Palaniya --- MAINTAINERS | 1 + drivers/media/i2c/Kconfig | 10 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/ov2735.c | 1073 ++++++++++++++++++++++++++++++++++++ 4 files changed, 1085 insertions(+) create mode 100644 drivers/media/i2c/ov2735.c diff --git a/MAINTAINERS b/MAINTAINERS index 474eefbd1363..058bbfd9523b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18478,6 +18478,7 @@ L: linux-media@vger.kernel.org S: Maintained T: git git://linuxtv.org/media.git F: Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml +F: drivers/media/i2c/ov2735.c =20 OMNIVISION OV2740 SENSOR DRIVER M: Tianshu Qiu diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 4b4c199da6ea..9646eab1b177 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -446,6 +446,16 @@ config VIDEO_OV2685 To compile this driver as a module, choose M here: the module will be called ov2685. =20 +config VIDEO_OV2735 + tristate "OmniVision OV2735 sensor support" + select V4L2_CCI_I2C + help + This is a Video4Linux2 sensor driver for the Sony + OV2735 camera. + + To compile this driver as a module, choose M here: the + module will be called ov2735. + config VIDEO_OV2740 tristate "OmniVision OV2740 sensor support" depends on ACPI || COMPILE_TEST diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile index 5873d29433ee..1adb27743fa1 100644 --- a/drivers/media/i2c/Makefile +++ b/drivers/media/i2c/Makefile @@ -93,6 +93,7 @@ obj-$(CONFIG_VIDEO_OV2640) +=3D ov2640.o obj-$(CONFIG_VIDEO_OV2659) +=3D ov2659.o obj-$(CONFIG_VIDEO_OV2680) +=3D ov2680.o obj-$(CONFIG_VIDEO_OV2685) +=3D ov2685.o +obj-$(CONFIG_VIDEO_OV2735) +=3D ov2735.o obj-$(CONFIG_VIDEO_OV2740) +=3D ov2740.o obj-$(CONFIG_VIDEO_OV4689) +=3D ov4689.o obj-$(CONFIG_VIDEO_OV5640) +=3D ov5640.o diff --git a/drivers/media/i2c/ov2735.c b/drivers/media/i2c/ov2735.c new file mode 100644 index 000000000000..d64e6bfcb831 --- /dev/null +++ b/drivers/media/i2c/ov2735.c @@ -0,0 +1,1073 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * V4L2 Support for the OV2735 + * + * Copyright (C) 2025 Silicon Signals Pvt. Ltd. + * + * Based on Rockchip ov2735 Camera Driver + * Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd. + * + * Inspired from ov8858, imx219, imx283 camera drivers. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#define OV2735_XCLK_FREQ (24 * HZ_PER_MHZ) + +/* Add page number in CCI private bits [31:28] of the register address */ +#define OV2735_PAGE_REG8(p, x) (((p) << CCI_REG_PRIVATE_SHIFT) | CCI_REG8(= x)) +#define OV2735_PAGE_REG16(p, x) (((p) << CCI_REG_PRIVATE_SHIFT) | CCI_REG1= 6(x)) + +#define OV2735_REG_PAGE_SELECT CCI_REG8(0xfd) + +/* Page 0 */ +#define OV2735_REG_CHIPID OV2735_PAGE_REG16(0x00, 0x02) +#define OV2735_CHIPID 0x2735 + +#define OV2735_REG_SOFT_RESET OV2735_PAGE_REG8(0x00, 0x20) + +/* Clock Settings */ +#define OV2735_REG_PLL_CTRL OV2735_PAGE_REG8(0x00, 0x2f) +#define OV2735_PLL_CTRL_ENABLE 0x7f +#define OV2735_REG_PLL_OUTDIV OV2735_PAGE_REG8(0x00, 0x34) +#define OV2735_REG_CLK_MODE OV2735_PAGE_REG8(0x00, 0x30) +#define OV2735_REG_CLOCK_REG1 OV2735_PAGE_REG8(0x00, 0x33) +#define OV2735_REG_CLOCK_REG2 OV2735_PAGE_REG8(0x00, 0x35) + +/* Page 1 */ +#define OV2735_REG_STREAM_CTRL OV2735_PAGE_REG8(0x01, 0xa0) +#define OV2735_STREAM_ON 0x01 +#define OV2735_STREAM_OFF 0x00 + +#define OV2735_REG_UPDOWN_MIRROR OV2735_PAGE_REG8(0x01, 0x3f) +#define OV2735_REG_BINNING_DAC_CODE_MODE OV2735_PAGE_REG8(0x01, 0x30) +#define OV2735_REG_FRAME_LENGTH OV2735_PAGE_REG16(0x01, 0x0e) +#define OV2735_VTS_MAX 0x0fff +#define OV2735_REG_FRAME_EXP_SEPERATE_EN OV2735_PAGE_REG8(0x01, 0x0d) +#define OV2735_FRAME_EXP_SEPERATE_EN 0x10 +#define OV2735_REG_FRAME_SYNC OV2735_PAGE_REG8(0x01, 0x01) + +#define OV2735_REG_HBLANK OV2735_PAGE_REG16(0x01, 0x09) + +#define OV2735_REG_HS_MIPI OV2735_PAGE_REG8(0x01, 0xb1) +#define OV2735_REG_MIPI_CTRL1 OV2735_PAGE_REG8(0x01, 0x92) +#define OV2735_REG_MIPI_CTRL2 OV2735_PAGE_REG8(0x01, 0x94) +#define OV2735_REG_MIPI_CTRL3 OV2735_PAGE_REG8(0x01, 0xa1) +#define OV2735_REG_MIPI_CTRL4 OV2735_PAGE_REG8(0x01, 0xb2) +#define OV2735_REG_MIPI_CTRL5 OV2735_PAGE_REG8(0x01, 0xb3) +#define OV2735_REG_MIPI_CTRL6 OV2735_PAGE_REG8(0x01, 0xb4) +#define OV2735_REG_MIPI_CTRL7 OV2735_PAGE_REG8(0x01, 0xb5) +#define OV2735_REG_PREPARE OV2735_PAGE_REG8(0x01, 0x95) +#define OV2735_REG_R_HS_ZERO OV2735_PAGE_REG8(0x01, 0x96) +#define OV2735_REG_TRAIL OV2735_PAGE_REG8(0x01, 0x98) +#define OV2735_REG_R_CLK_ZERO OV2735_PAGE_REG8(0x01, 0x9c) +#define OV2735_REG_MIPI_COLOMN_NUMBER OV2735_PAGE_REG16(0x01, 0x8e) +#define OV2735_REG_MIPI_LINE_NUMBER OV2735_PAGE_REG16(0x01, 0x90) + +#define OV2735_REG_ANALOG_CTRL3 OV2735_PAGE_REG8(0x01, 0x25) +#define OV2735_REG_VNCP OV2735_PAGE_REG8(0x01, 0x20) + +/* BLC registers */ +#define OV2735_REG_BLC_GAIN_BLUE OV2735_PAGE_REG8(0x01, 0x86) +#define OV2735_REG_BLC_GAIN_RED OV2735_PAGE_REG8(0x01, 0x87) +#define OV2735_REG_BLC_GAIN_GR OV2735_PAGE_REG8(0x01, 0x88) +#define OV2735_REG_BLC_GAIN_GB OV2735_PAGE_REG8(0x01, 0x89) +#define OV2735_REG_GB_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf0) +#define OV2735_REG_BLUE_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf1) +#define OV2735_REG_RED_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf2) +#define OV2735_REG_GR_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf3) +#define OV2735_REG_BLC_BPC_TH_P OV2735_PAGE_REG8(0x01, 0xfc) +#define OV2735_REG_BLC_BPC_TH_N OV2735_PAGE_REG8(0x01, 0xfe) + +#define OV2735_REG_TEST_PATTERN OV2735_PAGE_REG8(0x01, 0xb2) +#define OV2735_TEST_PATTERN_ENABLE 0x01 +#define OV2735_TEST_PATTERN_DISABLE 0xfe + +#define OV2735_REG_LONG_EXPOSURE OV2735_PAGE_REG16(0x01, 0x03) +#define OV2735_EXPOSURE_MIN 4 +#define OV2735_EXPOSURE_STEP 1 +#define OV2735_EXPOSURE_MARGIN 4 + +#define OV2735_REG_ANALOG_GAIN OV2735_PAGE_REG8(0x01, 0x24) +#define OV2735_ANALOG_GAIN_MIN 0x10 +#define OV2735_ANALOG_GAIN_MAX 0xff +#define OV2735_ANALOG_GAIN_STEP 1 +#define OV2735_ANALOG_GAIN_DEFAULT 0x10 + +/* Page 2 */ +#define OV2735_REG_V_START OV2735_PAGE_REG16(0x02, 0xa0) +#define OV2735_REG_V_SIZE OV2735_PAGE_REG16(0x02, 0xa2) +#define OV2735_REG_H_START OV2735_PAGE_REG16(0x02, 0xa4) +#define OV2735_REG_H_SIZE OV2735_PAGE_REG16(0x02, 0xa6) + +#define OV2735_LINK_FREQ_420MHZ (420 * HZ_PER_MHZ) +#define OV2735_PIXEL_RATE (168 * HZ_PER_MHZ) + +/* OV2735 native and active pixel array size */ +static const struct v4l2_rect ov2735_native_area =3D { + .top =3D 0, + .left =3D 0, + .width =3D 1936, + .height =3D 1096, +}; + +static const struct v4l2_rect ov2735_active_area =3D { + .top =3D 8, + .left =3D 8, + .width =3D 1920, + .height =3D 1080, +}; + +static const char * const ov2735_supply_name[] =3D { + "avdd", /* Analog power */ + "dovdd", /* Digital I/O power */ + "dvdd", /* Digital core power */ +}; + +/* PLL_OUT =3D [PLL_IN * (pll_nc +3)] / [(pll_mc + 1) * (pll_outdiv + 1)] = */ +struct ov2735_pll_parameters { + u8 pll_nc; + u8 pll_mc; + u8 pll_outdiv; +}; + +struct ov2735 { + struct device *dev; + struct regmap *cci; + struct v4l2_subdev sd; + struct media_pad pad; + struct clk *xclk; + struct gpio_desc *reset_gpio; + struct gpio_desc *enable_gpio; + struct regulator_bulk_data supplies[ARRAY_SIZE(ov2735_supply_name)]; + + /* V4L2 Controls */ + struct v4l2_ctrl_handler handler; + struct v4l2_ctrl *link_freq; + struct v4l2_ctrl *pixel_rate; + struct v4l2_ctrl *hblank; + struct v4l2_ctrl *vblank; + struct v4l2_ctrl *gain; + struct v4l2_ctrl *exposure; + struct v4l2_ctrl *test_pattern; + + u32 link_freq_index; + + u8 current_page; + struct mutex page_lock; +}; + +struct ov2735_mode { + u32 width; + u32 height; + u32 hts_def; + u32 vts_def; + u32 exp_def; + struct v4l2_rect crop; +}; + +static struct cci_reg_sequence ov2735_common_regs[] =3D { + { OV2735_REG_CLK_MODE, 0x15 }, + { OV2735_REG_CLOCK_REG1, 0x01 }, + { OV2735_REG_CLOCK_REG2, 0x20 }, + { OV2735_REG_BINNING_DAC_CODE_MODE, 0x00 }, + { OV2735_PAGE_REG8(0x01, 0xfb), 0x73 }, + { OV2735_REG_FRAME_SYNC, 0x01 }, + + /* Timing ctrl */ + { OV2735_PAGE_REG8(0x01, 0x1a), 0x6b }, + { OV2735_PAGE_REG8(0x01, 0x1c), 0xea }, + { OV2735_PAGE_REG8(0x01, 0x16), 0x0c }, + { OV2735_PAGE_REG8(0x01, 0x21), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x11), 0x63 }, + { OV2735_PAGE_REG8(0x01, 0x19), 0xc3 }, + + /* Analog ctrl */ + { OV2735_PAGE_REG8(0x01, 0x26), 0x5a }, + { OV2735_PAGE_REG8(0x01, 0x29), 0x01 }, + { OV2735_PAGE_REG8(0x01, 0x33), 0x6f }, + { OV2735_PAGE_REG8(0x01, 0x2a), 0xd2 }, + { OV2735_PAGE_REG8(0x01, 0x2c), 0x40 }, + { OV2735_PAGE_REG8(0x01, 0xd0), 0x02 }, + { OV2735_PAGE_REG8(0x01, 0xd1), 0x01 }, + { OV2735_PAGE_REG8(0x01, 0xd2), 0x20 }, + { OV2735_PAGE_REG8(0x01, 0xd3), 0x04 }, + { OV2735_PAGE_REG8(0x01, 0xd4), 0x2a }, + { OV2735_PAGE_REG8(0x01, 0x50), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x51), 0x2c }, + { OV2735_PAGE_REG8(0x01, 0x52), 0x29 }, + { OV2735_PAGE_REG8(0x01, 0x53), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x55), 0x44 }, + { OV2735_PAGE_REG8(0x01, 0x58), 0x29 }, + { OV2735_PAGE_REG8(0x01, 0x5a), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x5b), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x5d), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x64), 0x2f }, + { OV2735_PAGE_REG8(0x01, 0x66), 0x62 }, + { OV2735_PAGE_REG8(0x01, 0x68), 0x5b }, + { OV2735_PAGE_REG8(0x01, 0x75), 0x46 }, + { OV2735_PAGE_REG8(0x01, 0x76), 0x36 }, + { OV2735_PAGE_REG8(0x01, 0x77), 0x4f }, + { OV2735_PAGE_REG8(0x01, 0x78), 0xef }, + { OV2735_PAGE_REG8(0x01, 0x72), 0xcf }, + { OV2735_PAGE_REG8(0x01, 0x73), 0x36 }, + { OV2735_PAGE_REG8(0x01, 0x7d), 0x0d }, + { OV2735_PAGE_REG8(0x01, 0x7e), 0x0d }, + { OV2735_PAGE_REG8(0x01, 0x8a), 0x77 }, + { OV2735_PAGE_REG8(0x01, 0x8b), 0x77 }, + + { OV2735_REG_HS_MIPI, 0x83 }, + { OV2735_REG_MIPI_CTRL5, 0x0b }, + { OV2735_REG_MIPI_CTRL6, 0x14 }, + { OV2735_PAGE_REG8(0x01, 0x9d), 0x40 }, + { OV2735_REG_MIPI_CTRL3, 0x05 }, + { OV2735_REG_MIPI_CTRL2, 0x44 }, + { OV2735_REG_PREPARE, 0x33 }, + { OV2735_REG_R_HS_ZERO, 0x1f }, + { OV2735_REG_TRAIL, 0x45 }, + { OV2735_REG_R_CLK_ZERO, 0x10 }, + { OV2735_REG_MIPI_CTRL7, 0x70 }, + { OV2735_REG_ANALOG_CTRL3, 0xe0 }, + { OV2735_REG_VNCP, 0x7b }, + + /* BLC */ + { OV2735_REG_BLC_GAIN_BLUE, 0x77 }, + { OV2735_REG_BLC_GAIN_GB, 0x77 }, + { OV2735_REG_BLC_GAIN_RED, 0x74 }, + { OV2735_REG_BLC_GAIN_GR, 0x74 }, + { OV2735_REG_BLC_BPC_TH_P, 0xe0 }, + { OV2735_REG_BLC_BPC_TH_N, 0xe0 }, + { OV2735_REG_GB_SUBOFFSET, 0x40 }, + { OV2735_REG_BLUE_SUBOFFSET, 0x40 }, + { OV2735_REG_RED_SUBOFFSET, 0x40 }, + { OV2735_REG_GR_SUBOFFSET, 0x40 }, +}; + +static const struct ov2735_mode supported_modes[] =3D { + { + .width =3D 1920, + .height =3D 1080, + .exp_def =3D 399, + .hts_def =3D 2200, + .vts_def =3D 2545, + .crop =3D { + .top =3D 8, + .left =3D 8, + .width =3D 1920, + .height =3D 1080, + }, + }, +}; + +static const s64 link_freq_menu_items[] =3D { + OV2735_LINK_FREQ_420MHZ, +}; + +static const struct ov2735_pll_parameters pll_configs[] =3D { + /* For 420MHz pll_configs */ + { + .pll_nc =3D 4, + .pll_mc =3D 0, + .pll_outdiv =3D 1, + }, +}; + +static const char * const ov2735_test_pattern_menu[] =3D { + "Disabled", + "Vertical Color", +}; + +static int ov2735_page_access(struct ov2735 *ov2735, u32 reg, int *err) +{ + u8 page =3D reg >> CCI_REG_PRIVATE_SHIFT; + int ret =3D 0; + + if (err && *err) + return *err; + + guard(mutex)(&ov2735->page_lock); + + /* Perform page access before read/write */ + if (ov2735->current_page !=3D page) { + ret =3D cci_write(ov2735->cci, OV2735_REG_PAGE_SELECT, page, err); + if (!ret) + ov2735->current_page =3D page; + } + + return ret; +} + +static int ov2735_read(struct ov2735 *ov2735, u32 reg, u64 *val, int *err) +{ + u32 addr =3D reg & ~CCI_REG_PRIVATE_MASK; + int ret; + + ret =3D ov2735_page_access(ov2735, reg, err); + if (ret) + return ret; + + return cci_read(ov2735->cci, addr, val, err); +} + +static int ov2735_write(struct ov2735 *ov2735, u32 reg, u64 val, int *err) +{ + u32 addr =3D reg & ~CCI_REG_PRIVATE_MASK; + int ret; + + ret =3D ov2735_page_access(ov2735, reg, err); + if (ret) + return ret; + + return cci_write(ov2735->cci, addr, val, err); +} + +static int ov2735_multi_reg_write(struct ov2735 *ov2735, + const struct cci_reg_sequence *regs, + unsigned int num_regs, int *err) +{ + unsigned int i; + int ret; + + for (i =3D 0; i < num_regs; i++) { + ret =3D ov2735_write(ov2735, regs[i].reg, regs[i].val, err); + if (ret) + return ret; + } + + return 0; +} + +static inline struct ov2735 *to_ov2735(struct v4l2_subdev *_sd) +{ + return container_of(_sd, struct ov2735, sd); +} + +static int ov2735_enable_test_pattern(struct ov2735 *ov2735, u32 pattern) +{ + int ret; + u64 val; + + ret =3D ov2735_read(ov2735, OV2735_REG_TEST_PATTERN, &val, NULL); + if (ret) + return ret; + + switch (pattern) { + case 0: + val &=3D ~OV2735_TEST_PATTERN_ENABLE; + break; + case 1: + val |=3D OV2735_TEST_PATTERN_ENABLE; + break; + } + + return ov2735_write(ov2735, OV2735_REG_TEST_PATTERN, val, NULL); +} + +static int ov2735_set_ctrl(struct v4l2_ctrl *ctrl) +{ + struct ov2735 *ov2735 =3D container_of(ctrl->handler, struct ov2735, + handler); + struct v4l2_mbus_framefmt *fmt; + struct v4l2_subdev_state *state; + u64 vts; + int ret =3D 0; + + state =3D v4l2_subdev_get_locked_active_state(&ov2735->sd); + fmt =3D v4l2_subdev_state_get_format(state, 0); + + if (ctrl->id =3D=3D V4L2_CID_VBLANK) { + /* Honour the VBLANK limits when setting exposure */ + s64 max =3D fmt->height + ctrl->val - OV2735_EXPOSURE_MARGIN; + + ret =3D __v4l2_ctrl_modify_range(ov2735->exposure, + ov2735->exposure->minimum, max, + ov2735->exposure->step, + ov2735->exposure->default_value); + if (ret) + return ret; + } + + if (pm_runtime_get_if_in_use(ov2735->dev) =3D=3D 0) + return 0; + + switch (ctrl->id) { + case V4L2_CID_EXPOSURE: + ov2735_write(ov2735, OV2735_REG_LONG_EXPOSURE, ctrl->val, &ret); + break; + case V4L2_CID_ANALOGUE_GAIN: + ov2735_write(ov2735, OV2735_REG_ANALOG_GAIN, ctrl->val, &ret); + break; + case V4L2_CID_HBLANK: + ov2735_write(ov2735, OV2735_REG_HBLANK, ctrl->val, &ret); + break; + case V4L2_CID_VBLANK: + vts =3D ctrl->val + fmt->height; + ov2735_write(ov2735, OV2735_REG_FRAME_EXP_SEPERATE_EN, + OV2735_FRAME_EXP_SEPERATE_EN, &ret); + ov2735_write(ov2735, OV2735_REG_FRAME_LENGTH, vts, &ret); + break; + case V4L2_CID_TEST_PATTERN: + ret =3D ov2735_enable_test_pattern(ov2735, ctrl->val); + break; + default: + dev_err(ov2735->dev, "ctrl(id:0x%x, val:0x%x) is not handled\n", + ctrl->id, ctrl->val); + break; + } + ov2735_write(ov2735, OV2735_REG_FRAME_SYNC, 0x01, &ret); + + pm_runtime_put(ov2735->dev); + + return ret; +} + +static const struct v4l2_ctrl_ops ov2735_ctrl_ops =3D { + .s_ctrl =3D ov2735_set_ctrl, +}; + +static int ov2735_init_controls(struct ov2735 *ov2735) +{ + struct v4l2_ctrl_handler *ctrl_hdlr; + struct v4l2_fwnode_device_properties props; + const struct ov2735_mode *mode =3D &supported_modes[0]; + u64 hblank_def, vblank_def, exp_max; + int ret; + + ctrl_hdlr =3D &ov2735->handler; + v4l2_ctrl_handler_init(ctrl_hdlr, 9); + + ov2735->pixel_rate =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_PIXEL_RATE, 0, + OV2735_PIXEL_RATE, 1, + OV2735_PIXEL_RATE); + + ov2735->link_freq =3D v4l2_ctrl_new_int_menu(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_LINK_FREQ, + ov2735->link_freq_index, + 0, link_freq_menu_items); + if (ov2735->link_freq) + ov2735->link_freq->flags |=3D V4L2_CTRL_FLAG_READ_ONLY; + + hblank_def =3D mode->hts_def - mode->width; + ov2735->hblank =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_HBLANK, hblank_def, + hblank_def, 1, hblank_def); + + vblank_def =3D mode->vts_def - mode->height; + ov2735->vblank =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_VBLANK, vblank_def, + OV2735_VTS_MAX - mode->height, + 1, vblank_def); + + exp_max =3D mode->vts_def - OV2735_EXPOSURE_MARGIN; + ov2735->exposure =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_EXPOSURE, + OV2735_EXPOSURE_MIN, exp_max, + OV2735_EXPOSURE_STEP, mode->exp_def); + + ov2735->gain =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_ANALOGUE_GAIN, OV2735_ANALOG_GAIN_MIN, + OV2735_ANALOG_GAIN_MAX, OV2735_ANALOG_GAIN_STEP, + OV2735_ANALOG_GAIN_DEFAULT); + + ov2735->test_pattern =3D v4l2_ctrl_new_std_menu_items(ctrl_hdlr, + &ov2735_ctrl_ops, V4L2_CID_TEST_PATTERN, + ARRAY_SIZE(ov2735_test_pattern_menu) - 1, + 0, 0, ov2735_test_pattern_menu); + if (ctrl_hdlr->error) { + ret =3D ctrl_hdlr->error; + dev_err(ov2735->dev, "control init failed (%d)\n", ret); + goto err_handler_free; + } + + ret =3D v4l2_fwnode_device_parse(ov2735->dev, &props); + if (ret) + goto err_handler_free; + + ret =3D v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, + &ov2735_ctrl_ops, &props); + if (ret) + goto err_handler_free; + + ov2735->sd.ctrl_handler =3D ctrl_hdlr; + + return 0; + +err_handler_free: + v4l2_ctrl_handler_free(ctrl_hdlr); + + return ret; +} + +static int ov2735_set_pll_ctrl(struct ov2735 *ov2735) +{ + const struct ov2735_pll_parameters *pll_parameters; + u8 pll_ctrl; + u8 pll_outdiv; + int ret =3D 0; + + pll_parameters =3D &pll_configs[ov2735->link_freq_index]; + + /* BIT[7]: pll_clk_sel, BIT[6:2]: pll_nc, BIT[1:0]: pll_mc */ + pll_ctrl =3D ((pll_parameters->pll_nc << 2) | (pll_parameters->pll_mc << = 0)) & + OV2735_PLL_CTRL_ENABLE; + + pll_outdiv =3D pll_parameters->pll_outdiv; + + ov2735_write(ov2735, OV2735_REG_PLL_CTRL, pll_ctrl, &ret); + ov2735_write(ov2735, OV2735_REG_PLL_OUTDIV, pll_outdiv, &ret); + + return ret; +} + +static int ov2735_set_framefmt(struct ov2735 *ov2735, + struct v4l2_subdev_state *state) +{ + const struct v4l2_mbus_framefmt *format; + const struct v4l2_rect *crop; + int ret =3D 0; + + format =3D v4l2_subdev_state_get_format(state, 0); + crop =3D v4l2_subdev_state_get_crop(state, 0); + + ov2735_write(ov2735, OV2735_REG_V_START, crop->top, &ret); + ov2735_write(ov2735, OV2735_REG_V_SIZE, format->height, &ret); + ov2735_write(ov2735, OV2735_REG_MIPI_LINE_NUMBER, format->height, &ret); + ov2735_write(ov2735, OV2735_REG_H_START, crop->left, &ret); + /* OV2735_REG_H_SIZE: Image half horizontal size */ + ov2735_write(ov2735, OV2735_REG_H_SIZE, (format->width / 2), &ret); + ov2735_write(ov2735, OV2735_REG_MIPI_COLOMN_NUMBER, format->width, &ret); + + return ret; +} + +static int ov2735_enable_streams(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state, u32 pad, + u64 streams_mask) +{ + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret; + + ret =3D pm_runtime_resume_and_get(ov2735->dev); + if (ret < 0) + return ret; + + /* Apply pll settings */ + ret =3D ov2735_set_pll_ctrl(ov2735); + if (ret) { + dev_err(ov2735->dev, "failed to set frame format: %d\n", ret); + goto err_rpm_put; + } + + ret =3D ov2735_multi_reg_write(ov2735, ov2735_common_regs, + ARRAY_SIZE(ov2735_common_regs), NULL); + if (ret) { + dev_err(ov2735->dev, "%s failed to send mfg header\n", __func__); + goto err_rpm_put; + } + + /* Apply format settings */ + ret =3D ov2735_set_framefmt(ov2735, state); + if (ret) { + dev_err(ov2735->dev, "failed to set frame format: %d\n", ret); + goto err_rpm_put; + } + + /* Apply customized values from user */ + ret =3D __v4l2_ctrl_handler_setup(ov2735->sd.ctrl_handler); + if (ret) + goto err_rpm_put; + + ret =3D ov2735_write(ov2735, OV2735_REG_STREAM_CTRL, OV2735_STREAM_ON, NU= LL); + if (ret) + goto err_rpm_put; + + return 0; + +err_rpm_put: + pm_runtime_put(ov2735->dev); + return ret; +} + +static int ov2735_disable_streams(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state, u32 pad, + u64 streams_mask) +{ + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret; + + ret =3D ov2735_write(ov2735, OV2735_REG_STREAM_CTRL, OV2735_STREAM_OFF, N= ULL); + if (ret) + dev_err(ov2735->dev, "%s failed to set stream\n", __func__); + + pm_runtime_put(ov2735->dev); + + return ret; +} + +static int ov2735_get_selection(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_selection *sel) +{ + switch (sel->target) { + case V4L2_SEL_TGT_CROP: + sel->r =3D *v4l2_subdev_state_get_crop(sd_state, 0); + return 0; + case V4L2_SEL_TGT_NATIVE_SIZE: + sel->r =3D ov2735_native_area; + return 0; + case V4L2_SEL_TGT_CROP_DEFAULT: + case V4L2_SEL_TGT_CROP_BOUNDS: + sel->r =3D ov2735_active_area; + return 0; + default: + return -EINVAL; + } +} + +static int ov2735_enum_mbus_code(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_mbus_code_enum *code) +{ + if (code->index >=3D 0) + return -EINVAL; + + code->code =3D MEDIA_BUS_FMT_SGRBG10_1X10; + + return 0; +} + +static int ov2735_enum_frame_size(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_frame_size_enum *fse) +{ + u32 code; + + if (fse->index >=3D ARRAY_SIZE(supported_modes)) + return -EINVAL; + + code =3D MEDIA_BUS_FMT_SGRBG10_1X10; + if (fse->code !=3D code) + return -EINVAL; + + fse->min_width =3D supported_modes[fse->index].width; + fse->max_width =3D fse->min_width; + fse->min_height =3D supported_modes[fse->index].height; + fse->max_height =3D fse->min_height; + + return 0; +} + +static int ov2735_set_framing_limits(struct ov2735 *ov2735, + const struct ov2735_mode *mode) +{ + u32 hblank, vblank_def; + int ret; + + hblank =3D mode->hts_def - mode->width; + ret =3D __v4l2_ctrl_modify_range(ov2735->hblank, hblank, hblank, 1, hblan= k); + if (ret) + return ret; + + vblank_def =3D mode->vts_def - mode->height; + return __v4l2_ctrl_modify_range(ov2735->vblank, vblank_def, + OV2735_VTS_MAX - mode->height, 1, + vblank_def); +} + +static int ov2735_set_pad_format(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_format *fmt) +{ + struct v4l2_mbus_framefmt *format; + const struct ov2735_mode *mode; + struct v4l2_rect *crop; + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret; + + format =3D v4l2_subdev_state_get_format(sd_state, 0); + + mode =3D v4l2_find_nearest_size(supported_modes, + ARRAY_SIZE(supported_modes), + width, height, + fmt->format.width, fmt->format.height); + + fmt->format.width =3D mode->width; + fmt->format.height =3D mode->height; + fmt->format.field =3D V4L2_FIELD_NONE; + fmt->format.colorspace =3D V4L2_COLORSPACE_RAW; + fmt->format.quantization =3D V4L2_QUANTIZATION_FULL_RANGE; + fmt->format.xfer_func =3D V4L2_XFER_FUNC_NONE; + + if (fmt->which =3D=3D V4L2_SUBDEV_FORMAT_ACTIVE) { + ret =3D ov2735_set_framing_limits(ov2735, mode); + if (ret) + return ret; + } + + *format =3D fmt->format; + + /* Initialize crop rectangle */ + crop =3D v4l2_subdev_state_get_crop(sd_state, 0); + *crop =3D mode->crop; + + return 0; +} + +static int ov2735_init_state(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state) +{ + struct v4l2_subdev_format fmt =3D { + .which =3D V4L2_SUBDEV_FORMAT_TRY, + .format =3D { + .code =3D MEDIA_BUS_FMT_SGRBG10_1X10, + .width =3D supported_modes[0].width, + .height =3D supported_modes[0].height, + }, + }; + + ov2735_set_pad_format(sd, state, &fmt); + + return 0; +} + +static const struct v4l2_subdev_video_ops ov2735_video_ops =3D { + .s_stream =3D v4l2_subdev_s_stream_helper, +}; + +static const struct v4l2_subdev_pad_ops ov2735_pad_ops =3D { + .enum_mbus_code =3D ov2735_enum_mbus_code, + .get_fmt =3D v4l2_subdev_get_fmt, + .set_fmt =3D ov2735_set_pad_format, + .get_selection =3D ov2735_get_selection, + .enum_frame_size =3D ov2735_enum_frame_size, + .enable_streams =3D ov2735_enable_streams, + .disable_streams =3D ov2735_disable_streams, +}; + +static const struct v4l2_subdev_ops ov2735_subdev_ops =3D { + .video =3D &ov2735_video_ops, + .pad =3D &ov2735_pad_ops, +}; + +static const struct v4l2_subdev_internal_ops ov2735_internal_ops =3D { + .init_state =3D ov2735_init_state, +}; + +static int ov2735_power_on(struct device *dev) +{ + struct v4l2_subdev *sd =3D dev_get_drvdata(dev); + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret; + + gpiod_set_value_cansleep(ov2735->enable_gpio, 0); + /* + * Ensure device is inactive (PWDN high) before enabling power rails. + * As per datasheet, the PWDN pin (named 'enable_gpio' here) should be + * pulled low only after all power rails are stable. + */ + fsleep(3 * USEC_PER_MSEC); + + ret =3D regulator_bulk_enable(ARRAY_SIZE(ov2735_supply_name), + ov2735->supplies); + if (ret) { + dev_err(ov2735->dev, "failed to enable regulators\n"); + return ret; + } + + gpiod_set_value_cansleep(ov2735->enable_gpio, 1); + /* T4: delay from PWDN pulling low to RSTB pulling high */ + fsleep(4 * USEC_PER_MSEC); + + ret =3D clk_prepare_enable(ov2735->xclk); + if (ret) { + dev_err(ov2735->dev, "failed to enable clock\n"); + goto err_regulator_off; + } + + gpiod_set_value_cansleep(ov2735->reset_gpio, 0); + /* T5: delay from RSTB pulling high to first I2C command */ + fsleep(5 * USEC_PER_MSEC); + + return 0; + +err_regulator_off: + regulator_bulk_disable(ARRAY_SIZE(ov2735_supply_name), ov2735->supplies); + return ret; +} + +static int ov2735_power_off(struct device *dev) +{ + struct v4l2_subdev *sd =3D dev_get_drvdata(dev); + struct ov2735 *ov2735 =3D to_ov2735(sd); + + gpiod_set_value_cansleep(ov2735->enable_gpio, 0); + clk_disable_unprepare(ov2735->xclk); + gpiod_set_value_cansleep(ov2735->reset_gpio, 1); + regulator_bulk_disable(ARRAY_SIZE(ov2735_supply_name), ov2735->supplies); + + return 0; +} + +static int ov2735_get_regulators(struct ov2735 *ov2735) +{ + unsigned int i; + + for (i =3D 0; i < ARRAY_SIZE(ov2735_supply_name); i++) + ov2735->supplies[i].supply =3D ov2735_supply_name[i]; + + return devm_regulator_bulk_get(ov2735->dev, + ARRAY_SIZE(ov2735_supply_name), + ov2735->supplies); +} + +static int ov2735_identify_module(struct ov2735 *ov2735) +{ + u64 chip_id; + int ret; + + ret =3D ov2735_read(ov2735, OV2735_REG_CHIPID, &chip_id, NULL); + if (ret) + return dev_err_probe(ov2735->dev, ret, "failed to read chip id %x\n", + OV2735_CHIPID); + + if (chip_id !=3D OV2735_CHIPID) + return dev_err_probe(ov2735->dev, -EIO, "chip id mismatch: %x!=3D%llx\n", + OV2735_CHIPID, chip_id); + + return 0; +} + +static int ov2735_parse_endpoint(struct ov2735 *ov2735) +{ + struct fwnode_handle *fwnode =3D dev_fwnode(ov2735->dev); + struct v4l2_fwnode_endpoint bus_cfg =3D { + .bus_type =3D V4L2_MBUS_CSI2_DPHY, + }; + struct fwnode_handle *ep; + unsigned long link_freq_bitmap; + int ret; + + ep =3D fwnode_graph_get_next_endpoint(fwnode, NULL); + if (!ep) + return dev_err_probe(ov2735->dev, -ENXIO, + "Failed to get next endpoint\n"); + + ret =3D v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg); + fwnode_handle_put(ep); + if (ret) + return ret; + + if (bus_cfg.bus.mipi_csi2.num_data_lanes !=3D 2) { + ret =3D dev_err_probe(ov2735->dev, -EINVAL, + "only 2 data lanes are supported\n"); + goto error_out; + } + + ret =3D v4l2_link_freq_to_bitmap(ov2735->dev, bus_cfg.link_frequencies, + bus_cfg.nr_of_link_frequencies, + link_freq_menu_items, + ARRAY_SIZE(link_freq_menu_items), + &link_freq_bitmap); + if (ret) { + ret =3D dev_err_probe(ov2735->dev, -EINVAL, + "only 420MHz frequency is available\n"); + goto error_out; + } + + ov2735->link_freq_index =3D __ffs(link_freq_bitmap); + +error_out: + v4l2_fwnode_endpoint_free(&bus_cfg); + + return ret; +}; + +static int ov2735_probe(struct i2c_client *client) +{ + struct ov2735 *ov2735; + unsigned int xclk_freq; + int ret; + + ov2735 =3D devm_kzalloc(&client->dev, sizeof(*ov2735), GFP_KERNEL); + if (!ov2735) + return -ENOMEM; + + ov2735->dev =3D &client->dev; + + v4l2_i2c_subdev_init(&ov2735->sd, client, &ov2735_subdev_ops); + ov2735->sd.internal_ops =3D &ov2735_internal_ops; + + ov2735->cci =3D devm_cci_regmap_init_i2c(client, 8); + if (IS_ERR(ov2735->cci)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->cci), + "failed to initialize CCI\n"); + + /* Set Current page to 0 */ + ov2735->current_page =3D 0; + + ret =3D devm_mutex_init(ov2735->dev, &ov2735->page_lock); + if (ret) + return dev_err_probe(ov2735->dev, ret, + "Failed to initialize lock\n"); + + /* Get system clock (xvclk) */ + ov2735->xclk =3D devm_v4l2_sensor_clk_get(ov2735->dev, NULL); + if (IS_ERR(ov2735->xclk)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->xclk), + "failed to get xclk\n"); + + xclk_freq =3D clk_get_rate(ov2735->xclk); + if (xclk_freq !=3D OV2735_XCLK_FREQ) + return dev_err_probe(ov2735->dev, -EINVAL, + "xclk frequency not supported: %u Hz\n", + xclk_freq); + + ret =3D ov2735_get_regulators(ov2735); + if (ret) + return dev_err_probe(ov2735->dev, ret, + "failed to get regulators\n"); + + ret =3D ov2735_parse_endpoint(ov2735); + if (ret) + return dev_err_probe(ov2735->dev, ret, + "failed to parse endpoint configuration\n"); + + ov2735->reset_gpio =3D devm_gpiod_get_optional(ov2735->dev, + "reset", GPIOD_OUT_LOW); + if (IS_ERR(ov2735->reset_gpio)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->reset_gpio), + "failed to get reset GPIO\n"); + + ov2735->enable_gpio =3D devm_gpiod_get_optional(ov2735->dev, + "enable", GPIOD_OUT_LOW); + if (IS_ERR(ov2735->enable_gpio)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->enable_gpio), + "failed to get enable GPIO\n"); + + ret =3D ov2735_power_on(ov2735->dev); + if (ret) + return ret; + + ret =3D ov2735_identify_module(ov2735); + if (ret) + goto error_power_off; + + ret =3D ov2735_init_controls(ov2735); + if (ret) + goto error_power_off; + + /* Initialize subdev */ + ov2735->sd.flags |=3D V4L2_SUBDEV_FL_HAS_DEVNODE; + ov2735->sd.entity.function =3D MEDIA_ENT_F_CAM_SENSOR; + ov2735->pad.flags =3D MEDIA_PAD_FL_SOURCE; + + ret =3D media_entity_pads_init(&ov2735->sd.entity, 1, &ov2735->pad); + if (ret) { + dev_err_probe(ov2735->dev, ret, "failed to init entity pads\n"); + goto error_handler_free; + } + + ov2735->sd.state_lock =3D ov2735->handler.lock; + ret =3D v4l2_subdev_init_finalize(&ov2735->sd); + if (ret) { + dev_err_probe(ov2735->dev, ret, "subdev init error\n"); + goto error_media_entity; + } + + ret =3D devm_pm_runtime_get_noresume(ov2735->dev); + if (ret) { + dev_err_probe(ov2735->dev, ret, + "failed to get runtime PM noresume\n"); + goto error_subdev_cleanup; + } + + ret =3D devm_pm_runtime_set_active_enabled(ov2735->dev); + if (ret) { + dev_err_probe(ov2735->dev, ret, + "failed to set runtime PM active+enabled\n"); + goto error_subdev_cleanup; + } + + ret =3D v4l2_async_register_subdev_sensor(&ov2735->sd); + if (ret) { + dev_err_probe(ov2735->dev, ret, + "failed to register ov2735 sub-device\n"); + goto error_subdev_cleanup; + } + + return 0; + +error_subdev_cleanup: + v4l2_subdev_cleanup(&ov2735->sd); + +error_media_entity: + media_entity_cleanup(&ov2735->sd.entity); + +error_handler_free: + v4l2_ctrl_handler_free(ov2735->sd.ctrl_handler); + +error_power_off: + ov2735_power_off(ov2735->dev); + + return ret; +} + +static void ov2735_remove(struct i2c_client *client) +{ + struct v4l2_subdev *sd =3D i2c_get_clientdata(client); + struct ov2735 *ov2735 =3D to_ov2735(sd); + + v4l2_async_unregister_subdev(sd); + v4l2_subdev_cleanup(&ov2735->sd); + media_entity_cleanup(&sd->entity); + v4l2_ctrl_handler_free(ov2735->sd.ctrl_handler); +} + +static DEFINE_RUNTIME_DEV_PM_OPS(ov2735_pm_ops, + ov2735_power_off, ov2735_power_on, NULL); + +static const struct of_device_id ov2735_id[] =3D { + { .compatible =3D "ovti,ov2735" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, ov2735_id); + +static struct i2c_driver ov2735_driver =3D { + .driver =3D { + .name =3D "ov2735", + .pm =3D pm_ptr(&ov2735_pm_ops), + .of_match_table =3D ov2735_id, + }, + .probe =3D ov2735_probe, + .remove =3D ov2735_remove, +}; +module_i2c_driver(ov2735_driver); + +MODULE_DESCRIPTION("OV2735 Camera Sensor Driver"); +MODULE_AUTHOR("Hardevsinh Palaniya = "); +MODULE_AUTHOR("Himanshu Bhavani "); +MODULE_LICENSE("GPL"); --=20 2.34.1