From nobody Sun Oct 5 01:49:23 2025 Received: from vs81.iboxed.net (vs10.datenmanufaktur-hosting.net [213.160.73.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B91E29CEB; Mon, 11 Aug 2025 06:45:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.160.73.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754894760; cv=none; b=AoWw31alqXohqoDRqaH4EX+7sbdUzH20CsXxTGPnyI+ZWaVvYjYdZdGdx0GkhmwKBbtVx7mOyYSV3hoUeoj+k52zW4tDq/deD8SaNXhxSh2BpVNtC21eqmmkYjUTgsLfFe4QtDANIkhwoeuFkEMjBU8mLH0lfr7l+zznzap8Sck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754894760; c=relaxed/simple; bh=+fzJxtFZICNlOTaShUCCSdZQ98cKC6NPiRTRpgHgNb0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=OLfoDRSNg1hA9jvMCyAu3+INEAEsmFHAYvvhgG/ZCbTltVTKmqJCcuea6pevKnZJ6uZxKoZ2ycCPxFRK3PaVqf/TsNttjACY1c+4Vrnqmif18ZXerdimucdQZg1VSkQF0v1sBzGiFknbM3vUY7wqqrnj91Yf0/shw38sh1UhnyA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blala.de; spf=pass smtp.mailfrom=blala.de; arc=none smtp.client-ip=213.160.73.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blala.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=blala.de Received: from blala.de (localhost [127.0.0.1]) by vs81.iboxed.net (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 57B6iF0X001704; Mon, 11 Aug 2025 06:44:15 GMT Received: (from akurz@localhost) by blala.de (8.15.2/8.15.2/Submit) id 57B6iFQD001703; Mon, 11 Aug 2025 06:44:15 GMT From: Alexander Kurz To: Alexandre Belloni , Dmitry Torokhov , Lee Jones Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-input@vger.kernel.or, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Alexander Kurz Subject: [PATCH] Drivers: mc13783: remove deprecated mc13xxx_irq_ack() Date: Mon, 11 Aug 2025 06:43:58 +0000 Message-Id: <20250811064358.1659-1-akurz@blala.de> X-Mailer: git-send-email 2.20.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mc13xxx_irq_ack() got deprecated and became dead code with commit 10f9edaeaa30 ("mfd: mc13xxx: Use regmap irq framework for interrupts"). It should be safe to remove it now. Signed-off-by: Alexander Kurz Acked-by: Alexandre Belloni Acked-by: Dmitry Torokhov # for input Acked-by: Uwe Kleine-K=C3=B6nig --- drivers/input/misc/mc13783-pwrbutton.c | 1 - drivers/input/touchscreen/mc13783_ts.c | 4 ---- drivers/rtc/rtc-mc13xxx.c | 13 ------------- include/linux/mfd/mc13xxx.h | 6 ------ 4 files changed, 24 deletions(-) diff --git a/drivers/input/misc/mc13783-pwrbutton.c b/drivers/input/misc/mc= 13783-pwrbutton.c index 1c7faa9b7afe..b83d762ae2e9 100644 --- a/drivers/input/misc/mc13783-pwrbutton.c +++ b/drivers/input/misc/mc13783-pwrbutton.c @@ -57,7 +57,6 @@ static irqreturn_t button_irq(int irq, void *_priv) struct mc13783_pwrb *priv =3D _priv; int val; =20 - mc13xxx_irq_ack(priv->mc13783, irq); mc13xxx_reg_read(priv->mc13783, MC13783_REG_INTERRUPT_SENSE_1, &val); =20 switch (irq) { diff --git a/drivers/input/touchscreen/mc13783_ts.c b/drivers/input/touchsc= reen/mc13783_ts.c index 33635da85079..47b8da00027f 100644 --- a/drivers/input/touchscreen/mc13783_ts.c +++ b/drivers/input/touchscreen/mc13783_ts.c @@ -42,8 +42,6 @@ static irqreturn_t mc13783_ts_handler(int irq, void *data) { struct mc13783_ts_priv *priv =3D data; =20 - mc13xxx_irq_ack(priv->mc13xxx, irq); - /* * Kick off reading coordinates. Note that if work happens already * be queued for future execution (it rearms itself) it will not @@ -137,8 +135,6 @@ static int mc13783_ts_open(struct input_dev *dev) =20 mc13xxx_lock(priv->mc13xxx); =20 - mc13xxx_irq_ack(priv->mc13xxx, MC13XXX_IRQ_TS); - ret =3D mc13xxx_irq_request(priv->mc13xxx, MC13XXX_IRQ_TS, mc13783_ts_handler, MC13783_TS_NAME, priv); if (ret) diff --git a/drivers/rtc/rtc-mc13xxx.c b/drivers/rtc/rtc-mc13xxx.c index e7b87130e624..2494d13fd767 100644 --- a/drivers/rtc/rtc-mc13xxx.c +++ b/drivers/rtc/rtc-mc13xxx.c @@ -137,10 +137,6 @@ static int mc13xxx_rtc_set_time(struct device *dev, st= ruct rtc_time *tm) } =20 if (!priv->valid) { - ret =3D mc13xxx_irq_ack(priv->mc13xxx, MC13XXX_IRQ_RTCRST); - if (unlikely(ret)) - goto out; - ret =3D mc13xxx_irq_unmask(priv->mc13xxx, MC13XXX_IRQ_RTCRST); } =20 @@ -208,10 +204,6 @@ static int mc13xxx_rtc_set_alarm(struct device *dev, s= truct rtc_wkalrm *alarm) if (unlikely(ret)) goto out; =20 - ret =3D mc13xxx_irq_ack(priv->mc13xxx, MC13XXX_IRQ_TODA); - if (unlikely(ret)) - goto out; - s1970 =3D rtc_tm_to_time64(&alarm->time); =20 dev_dbg(dev, "%s: %s %lld\n", __func__, alarm->enabled ? "on" : "off", @@ -239,12 +231,9 @@ static int mc13xxx_rtc_set_alarm(struct device *dev, s= truct rtc_wkalrm *alarm) static irqreturn_t mc13xxx_rtc_alarm_handler(int irq, void *dev) { struct mc13xxx_rtc *priv =3D dev; - struct mc13xxx *mc13xxx =3D priv->mc13xxx; =20 rtc_update_irq(priv->rtc, 1, RTC_IRQF | RTC_AF); =20 - mc13xxx_irq_ack(mc13xxx, irq); - return IRQ_HANDLED; } =20 @@ -293,8 +282,6 @@ static int __init mc13xxx_rtc_probe(struct platform_dev= ice *pdev) =20 mc13xxx_lock(mc13xxx); =20 - mc13xxx_irq_ack(mc13xxx, MC13XXX_IRQ_RTCRST); - ret =3D mc13xxx_irq_request(mc13xxx, MC13XXX_IRQ_RTCRST, mc13xxx_rtc_reset_handler, DRIVER_NAME, priv); if (ret) diff --git a/include/linux/mfd/mc13xxx.h b/include/linux/mfd/mc13xxx.h index f372926d5894..dd46fe424a80 100644 --- a/include/linux/mfd/mc13xxx.h +++ b/include/linux/mfd/mc13xxx.h @@ -31,12 +31,6 @@ int mc13xxx_adc_do_conversion(struct mc13xxx *mc13xxx, unsigned int mode, unsigned int channel, u8 ato, bool atox, unsigned int *sample); =20 -/* Deprecated calls */ -static inline int mc13xxx_irq_ack(struct mc13xxx *mc13xxx, int irq) -{ - return 0; -} - static inline int mc13xxx_irq_request_nounmask(struct mc13xxx *mc13xxx, in= t irq, irq_handler_t handler, const char *name, void *dev) --=20 2.39.5