From nobody Sun Oct 5 00:06:45 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DB832DFA25 for ; Mon, 11 Aug 2025 15:07:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754924823; cv=none; b=ccjvIzsnaowKpV9lpVU7Qp+NFWeHJNvEeS3NB6KP49hpqeYcFjSHfzgVPrVPaFeRxATvaCEoyYaK8hktgDd+ck/mAHUD5WmTHqWoKk7E3x67XFBmjSeYCjW0sNj18wdVSz9ej+VR2TjtIVJVD+86NyvG4zx/mkwHULkEUvgrLj8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754924823; c=relaxed/simple; bh=3p5hcBViOeL2xgiNJ699bYMhAUyttuVRwHkczSRJSbc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cFBFoMJGq8/gYd90sOkmVeIZhocQMmpMt7QqcqPZyPMu98c8juj0Mk+i3wP3XBgr8wy7t/zw7H/bIQis78Lleh66pLu2mYqEOKRcsvJ1LVw1FSPB2UZPCr1/xh+Od0RZBBcdXXCB/a0xLUrGwdPiKKfLV9OjEtoPbUN9pEl84kE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=hnfqNvzK; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="hnfqNvzK" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-459e39ee7ccso44458455e9.2 for ; Mon, 11 Aug 2025 08:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1754924819; x=1755529619; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=y0Oy8wSgLdlcIY+gXHw1NOZYFR+FdOb96GdIigh4L3Y=; b=hnfqNvzKKCHGEvUgt/EJkxQ3DAYw87KZzMiP5f6IqyMNjANoSMuMPJLBDk7vY23KSz 79VqxNOKZnHOCMUVz503+xCqdhVfo6tQ/I9ON7K3PcyDw1Wi+HKjKEknyzenaTxzvkBB IhdQwkNEc4+hOYE2ob0AcuOtpbzNoV5ueuH8FdvxyvcxDzUGWUN4lgr13MNx8W+u3bw+ EAMchlajIipl0DB58RNnr+rrNEFGVWsXNKcxBqGgjiQku6TsPWY7KUvDL6yNFFQMtzxY vsF6WYqFJaPSpY6YKAIcppLEUEJ/oKTG4sityCMNhXH6uaMge1PWekSNmqEbmXDMjfvU 6LYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754924819; x=1755529619; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y0Oy8wSgLdlcIY+gXHw1NOZYFR+FdOb96GdIigh4L3Y=; b=IKCmtt+IpFPMAMwd11K75mmvWJ1tNusnwFCEBApGIegEyGnb28LrWhS8zmprH3fS7e k4qZUcJdmSH4ZDUle99LwO7yBMGVT+kRiCPKR+FPE+T6sTQqploOe92Or7bg2wU0N5kb ZsTcgklF9iiOQ544Xw5rmTj1AumckWiq3PgMsdxNcApSrhYQqUQM+L2TAUOl3VyprBJU /nVWDfJtvPhVI3QeeuUGy9XDGAvtuthWIrAfRK2jAUVWu26STkPLERUFS3d116+ncvCR 9V/wVK2vieX3nnLCXW3T7R8rtPwBOQrfuDPx00Mb+6Jr+m7R1jPpSn1JoucvOPjXZZ8c C/qw== X-Forwarded-Encrypted: i=1; AJvYcCWhcWqQQ6eSEeg6WjzTLRz5A0TGCHLweu7Tn7FigdULEIz6vkzPWrr0g7v+EZOPTDkje9CYXFb+ddfsQbo=@vger.kernel.org X-Gm-Message-State: AOJu0YwJDoGbwnwyO1DZfR7dZtQy61keXV0wTOY7TbJbu/CftmnMLL34 jxwJlJaogaNKAwQevmJ8VdrCSatc7/dsMm++tJNgctl/qUdalHR+/ncq4kcTi0FnwJA= X-Gm-Gg: ASbGncs6aegrpT113vcCElZlakwzv1kFt6KvLyvFRvUNZELby9uEmLjucf52kLXWScp Q+FKRZQSVqkMIfUle14k2Gekw5pVX6OZbn5eKTrPdzALG9b6Osm0b1RHbRAiu6u1A74NCuuO3ZZ pkvU/gpmJnghZynmloCSX1OyQTTXLevLcmhj1+1sEJ8sLDyT7Gh58pNh2iTi09o/8AaIeouOcFJ B8sjpj5JWTtMQQpmbIG1Xh/3J86HF67kB8RvnMiFM2K9zf+Pn5j4rRFB623VonQxAskvePL8wLs tkQVx3D1Lb6gYCVRVBfFNmPz0ToBQOAsve1ovP0PZMLHV5DLRXEZIxJfVn4r0JDfgDYw5PQb4uf F5aMe9fYIX2Mz4Bz2Hw== X-Google-Smtp-Source: AGHT+IGH6IgoeqeXukrgS3hPdlTrL8/hFM2akIjvjNIrVv2Rl95G6ZAYGTxaQu9g+oIYMhO7raaS2w== X-Received: by 2002:a05:600c:4e89:b0:459:dfa8:b881 with SMTP id 5b1f17b1804b1-45a10b95532mr658835e9.7.1754924819497; Mon, 11 Aug 2025 08:06:59 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6841:8926:4410:c880]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c3abf0csm40107411f8f.14.2025.08.11.08.06.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 08:06:57 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 11 Aug 2025 17:06:48 +0200 Subject: [PATCH RESEND 1/3] arm64: dts: qcom: qrb2210-rb1: fix GPIO lookup flags for i2c SDA and SCL Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250811-qcom-gpio-lookup-open-drain-v1-1-b5496f80e047@linaro.org> References: <20250811-qcom-gpio-lookup-open-drain-v1-0-b5496f80e047@linaro.org> In-Reply-To: <20250811-qcom-gpio-lookup-open-drain-v1-0-b5496f80e047@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Alexey Klimov , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1371; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=TMD6A256PGlZL2cGXyLS2Wh/cdu83URj71C5IQiDtPI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBomgcO4YgjPDJ47wzCZZhdZl4XEBlevsW4myYIS TusbY6YNfeJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaJoHDgAKCRARpy6gFHHX csujEADNmkYAfUEumm4DG2TePnFbmkN8bmN1HgR9q0FqnY1yvsRKmMZEksOB3t+RMBd9kCWGl4V 7oYhFEryrw0TkrR+Eqlfe5qCvJZd15tJFeaCYYAvolFiJxt1hiKJ8GWk+uCXMVqTQYlB/wZHwB1 eDrPMtM6hFpJ4lvovw7ile6eUFL3uv3umj4uqEFx0afFj9QhrO0/cyZuXjnodWMhwdElpE441Sq gp9fkkr4faC6tDGOTLDpIbkWRKkq1+ON4IdyXP+Cqp0kLaEe26m6sHnZTstqI1NZfps8sepy7Lr hn/AiDjoZm0YSNfYm02fKRhfrXmHcdkcwx651SXD0FAHL7y0VZ4r29IygWVaAMvORpwjX0OHOwH AQnpUpASc1kG7muzoNaAW54PpwQn5r87ruoyAZM5QONnIqnUWAi/QxPmfn5YgRSWfjWcVL6jqq2 iFLcc20XUjOy39It/SzICoTrUyvzowwDPYNI7JvnbVFqyQbxHXNW17lu2xLHJ0maQyQ67kS3ox+ bcLzHAaQZFw0weae4U9jKoL6iWUkykrDW9dJChHuy0nZ9m9X7tBGDw/5o8lqiS1qXwsSrx1E67f WZfdrGODYGe5E0dp/L/u1IG15P/8Gl23bnmv8oQz1hCQ3NCN4UMS7JJUwuFnFXBbfF6y3dexp2N Y3PlaSwZwi1NQWQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski The I2C GPIO bus driver enforces the SDA and SCL pins as open-drain outputs but the lookup flags in the DTS don't reflect that triggering warnings from GPIO core. Add the appropriate flags. Tested-by: Alexey Klimov Reported-by: Alexey Klimov Reviewed-by: Konrad Dybcio Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts b/arch/arm64/boot/dts= /qcom/qrb2210-rb1.dts index b2e0fc5501c1eefc7e037b2efd939126b483b226..277b33100ac07cb1e8477e9e513= 31f974b65092b 100644 --- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts +++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts @@ -5,6 +5,7 @@ =20 /dts-v1/; =20 +#include #include #include "qcm2290.dtsi" #include "pm4125.dtsi" @@ -63,8 +64,8 @@ hdmi_con: endpoint { i2c2_gpio: i2c { compatible =3D "i2c-gpio"; =20 - sda-gpios =3D <&tlmm 6 GPIO_ACTIVE_HIGH>; - scl-gpios =3D <&tlmm 7 GPIO_ACTIVE_HIGH>; + sda-gpios =3D <&tlmm 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; + scl-gpios =3D <&tlmm 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; #address-cells =3D <1>; #size-cells =3D <0>; =20 --=20 2.48.1 From nobody Sun Oct 5 00:06:45 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDBCB2E03E8 for ; Mon, 11 Aug 2025 15:07:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754924825; cv=none; b=Inbkp+2xlk/U1DQ+l3OoYL5CVJIQgqWyN/NoN0dkJlQ/otHk5ClR3Ws2ZDP6lzc4WxRBw96jfxMF9IK0d4oR2RyF+R8kAQSd/VqbBADwanvJtzc9YFL+LWD17qg0yQKZ7b2sxvlErsSGiMNka8Qs66yN987gnCNMTx62qD4zcaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754924825; c=relaxed/simple; bh=/9MsFh2r2VMET8J42cizbyswwP2JrhOPED52i3Bh3D4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=icCdWLpqmFcbyi5bQ680efofJAKcURGnEmFJdKFw2WG1z8X7lkR3TB8NJ80kEGuAuUQxwSfCY/7caHPeWffyPgelv+ceRedQyp4VuyHBU9zhThSv3uVPI8CVz7N+63WFK5gGokaQcHhC9Y/JyXAFKvzGiRLZgkkkh+fiL+WYrTE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=C98SUiws; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="C98SUiws" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-45a0dc77a15so4360035e9.2 for ; Mon, 11 Aug 2025 08:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1754924822; x=1755529622; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GALMUBIly8zOO2APNJmpi6ZZbZQ8t1lcCF5GzlyI0P8=; b=C98SUiws96u8bsW7Xb/jEShuGnhPNDW+8jKVwHLWx2/cF/IGEq2ZvhzeZTa/XrPUNI 8zj+2cCFUatvtFc0YBUwBja4pwyX6bU6yTarmDusXuIFuKL0bFFDFmuSnWALR/lhGwjx JW0DJVUuLRKWH3T8UNtF1lpnQf3JEUH3jgcwJ7bdYuusCPgag/tEIs+kKlYOK9IH4wiV HiovBhsLRJSeQTHH+LrZjxrN/DXquflcs7Do3lVWS47/zrA6Kj03/UZ4fcEkCsbw9Z+a umVJEQmzRKmW1ND2s6VyTpejEGkWLACUHJ5H/UxS3au0deRb8SqlhctKDN5DAJp7yCNt 9oHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754924822; x=1755529622; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GALMUBIly8zOO2APNJmpi6ZZbZQ8t1lcCF5GzlyI0P8=; b=nbFYm9xLZNVlBNiY8HURmWxV0YrZVvW99VHbC5Etob1ZHFHgNhfFrGPJNgG0bpCy8z AD5MUfv/lDtPJD3EwsfNfmZ9vL+DmPjf2N/eGqkPxm1tlcboAElA8M5xYEFaW1hFsV1v n9hvoETIX2AqumbqRRQZiuG72+VM+xu6WJ7luVVfhLaqQXh5qHFm2haEERw0idYHX7wG tmuKDM05HyjKbR0i2XIFExwBVtVuBD90ADUkDac+xj4EC9k2Wm6SSDCADFoPXvnL/67o s6oYJeXfk3hcNiqAZ1XwHpyRKQhcT0UyJkeUJxJS2fU0rRwe/16TiSxEqSS6z0/fxoJf 4VGw== X-Forwarded-Encrypted: i=1; AJvYcCX1BvHsDfMmRDrusPxEWilDom8fbsaBvsVmCOgb92xK2/ds40h9wHceu4VVaKgksQJ8cUzhS9l8M8Tnqgw=@vger.kernel.org X-Gm-Message-State: AOJu0YwnIJ1x43QDrHNPbqdSSyVQ0Z4aWPhyEWt4TmBsBo6cNFhdIoNb aKiea7Rvir2cX0vKidTXsQxPUGTP76TODntn1MNEaf3sCqGikr1igk3A7uYBsyggpl4= X-Gm-Gg: ASbGncv5oJo3LNQSD0nLH6ceLO8L3DKmpMvlYP8BErDb+A3N1w9+1E3mLYzPTkIaeC7 tN1hiEFytDpJQOlI5WpIB/wfGwZXtcNLHxZqVwocfTjB98Bknfm7hzHwmZEkhbC8EG7zb5ElFmO OigB51nhYyWI+ePWtK5ZeVigTs5CLcnHx4aSGq9yWkQHBzbgllM1Ev4C/t85qOg/1QqF2ZlcpPf 6dnrWQuGoGQNTrc6d+EnNE4ink6FLpuj1CY9oKaZpDnTl5pJ+9mFcI/vwf3ifTwSdMS+Il6af6a VAYW9PgmmdGkFl8gkfvNYYfHVuh5hAIp9sY1V5TUlOZnNGYbAM+zY3WyWewZNjZs6Fzt17+aagQ CTs2WNSi6dZx1ql1Wgg== X-Google-Smtp-Source: AGHT+IH+9Qhcx6eMynQ3lLVh6i5WjIyNopYRiP35jmm71sAsMABoEGgm79ya3Du/LU3oMPdwgp3Adg== X-Received: by 2002:a05:600c:470c:b0:459:d709:e5cf with SMTP id 5b1f17b1804b1-45a10bad987mr622665e9.3.1754924822216; Mon, 11 Aug 2025 08:07:02 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6841:8926:4410:c880]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c3abf0csm40107411f8f.14.2025.08.11.08.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 08:07:00 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 11 Aug 2025 17:06:49 +0200 Subject: [PATCH RESEND 2/3] arm64: dts: qcom: qrb4210-rb2: fix GPIO lookup flags for i2c SDA and SCL Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250811-qcom-gpio-lookup-open-drain-v1-2-b5496f80e047@linaro.org> References: <20250811-qcom-gpio-lookup-open-drain-v1-0-b5496f80e047@linaro.org> In-Reply-To: <20250811-qcom-gpio-lookup-open-drain-v1-0-b5496f80e047@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Alexey Klimov , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1355; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=SCoXHXKdSwdMxFT2nQDPdrs2Yg24n21obueLXUFmnvQ=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBomgcO5Bz0IqWJSIm2DzpVSScLMYEbwvwHqSE/d B79ouluVzOJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaJoHDgAKCRARpy6gFHHX ctOGD/0cSYDZW/goxRDxXIAufr1SeifOHNgUAptcTBvVkFJAPfPOfH5TK4at42v1eOokOLXNoEC sTuGkhKZfqOaOg9x8yt7W1vomvviGuGTY7gf6PHUoy7wbnTn3qbY60aVClUWShpIdQQUB0nCsoB m+OIv/U8dicisHk48UQQqZySVUrksr0MVkakj5k3X3pcO9LO0c1qO7vBAXEHnSigKZ9tvFf4RX/ hW1OumHHZzV1Dg3H1G8AxpJBwVLvy33pv3Ttu1RzDxrg2krzWpTM0s3lJaBErEO5layELONQXH+ sQ13qCTZfsJ8rycZenN9DKJO8wr85Dlghk0FwFwFypKgvop+VrtslDqZiO2zAmC+PnhYHznUiTJ biTV44inSyVz6RCRmt/0aP2XEVNAk0lXRfymM6S2GGwUEa8re4f8Ng3AAiUoFByBOsNSqASvVj/ XmGxUqi7698cHhlGTYofoLfs10dENmzPcw9wzbjUwNjdzyhadfZzLbrT6o0rNm8aj7fjZWRU+FQ 9j8wiphcuNBGLafNGrvkoF+lAbSPsKDnUTsRvypvBcpMYMt0ZSBMD/ZGTLlQGrYDRS+D4LphCpb kMOFhsBFb3JYE6qdkE5y1GehoNCTw/x/vd+FwKJ0A1dGRJ2j2SQuGznINMv8cOp8dG75C7jvEwM h3uAFZfJJL+af4Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski The I2C GPIO bus driver enforces the SDA and SCL pins as open-drain outputs but the lookup flags in the DTS don't reflect that triggering warnings from GPIO core. Add the appropriate flags. Reported-by: Alexey Klimov Reviewed-by: Konrad Dybcio Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts= /qcom/qrb4210-rb2.dts index a37860175d2733214f1b257e84d5cb4821033242..bdf2d66e40c62596b8b024de833= 835a0750df35d 100644 --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts @@ -5,6 +5,7 @@ =20 /dts-v1/; =20 +#include #include #include #include @@ -65,8 +66,8 @@ hdmi_con: endpoint { i2c2_gpio: i2c { compatible =3D "i2c-gpio"; =20 - sda-gpios =3D <&tlmm 6 GPIO_ACTIVE_HIGH>; - scl-gpios =3D <&tlmm 7 GPIO_ACTIVE_HIGH>; + sda-gpios =3D <&tlmm 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; + scl-gpios =3D <&tlmm 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; #address-cells =3D <1>; #size-cells =3D <0>; =20 --=20 2.48.1 From nobody Sun Oct 5 00:06:45 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 195392DECB9 for ; Mon, 11 Aug 2025 15:07:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754924828; cv=none; b=Vlc6MhFRqRPsilQIxyUf8+QryFeK0ijqTXxQb9Jb3FasSQr2B4wkDrrSVrzpi+ZJqaJ0xHWzVgt49+rZ01Fp8gGqMawCAIGKg8AWV++S3ZSmxz5gQCJGfmZRY0B7d33mybwlbQyE+YVtSwbPqfxkcXNbZcfVXYlmwT68GOaDSAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754924828; c=relaxed/simple; bh=Rlzycctntzu3MKLfHab3z+M8eAwhKWoMgPypGF15b6w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r+LFAm+BjyhY26qbW6qZBGfAajDy+Go5npx/1iSekqoGFwO/aAMOWfc1VSdH4VlipJHY1SdDzTVuQC9VIoHVgnOpzO1fS/nzFnVo0aByb5oWLBo7dnGbX1gX47FSIT5dN5wSxSr/NbH0V1kKOrESx3RC+NAx2YbqRxylc3qUVx0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Is1Ec82t; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Is1Ec82t" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-458bdde7dedso30389885e9.0 for ; Mon, 11 Aug 2025 08:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1754924825; x=1755529625; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=umNMW1zVA+xnt6ls9ddcILK5xFK/tWBrUkTSc9l7PlY=; b=Is1Ec82t8yxI2xD+D4hpj42fpP3tNLs9XYn5PsMaHGVx4lwqXItt6YiednHUC/Io+4 dwsefo95PE70f3wXZde5I9A0xbqNFpuKQVwnI62HXklpGZ6lVYcW2CnzAsT1v9kOirP2 BnlqYzwBSc/t0KfExua8i4N3oquPG5jFI94Yo7RhGo5V2ghoHQW44JjjnalMDrhI3rP3 XR1MmHx/6oVk+SCPQdyUctt+7d1RpsYDZbXmNLUyNfGDUz6AbF55VsNBTO9hLyvt7bcq +Aypx2Au6baIlRIYZ2LHHNNL9Chl/ddxZ9qN0B15IZUQtC8ZHcuzK/DlGX/MSnIy6mEb 0TIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754924825; x=1755529625; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=umNMW1zVA+xnt6ls9ddcILK5xFK/tWBrUkTSc9l7PlY=; b=AFMmeKq/u1Bqrg+LTLiQj/E1hJEFt8UPUeDHjg6pMy5iD1An4ZCB977qbrxRMcyoSx wOAmz6GoSLZRLv8LtXCi7XsuW1OK/VKtgsq+UJ3yo6JGYfigCJkScSjPgJnia3BTaitf 3EZLTB2PhjNbelV12YLF/G+LYbLQNgy5sCHC9mKA5H2V+aapU1kBHWdrz+t7sPL/ZFYy Cc9dBo8z4IIZZlYnMpfYtQo/+zUGjYsQijzSH1j4ilfjgpHFMJV3I2WwVe7g2k7PL1Df YPS/qDaCY9xhrsDvfW36Jg1JeTYZSgfacxANPdlLhW9A9+qcIfWoVOr3azeWnvM8BDu5 BHmQ== X-Forwarded-Encrypted: i=1; AJvYcCWc5bd7XCViAPMkSuo/XkBrEhtXTFA9pD7IAJsUYB01lixKAXcKkSpThoSTSsVkTHLyvYFa6UF8CUyozXU=@vger.kernel.org X-Gm-Message-State: AOJu0YySbcHmKMKP0OlrDgUgyZ1QlaY8uEiKuHTt/mQZqyN7OHjLjwNR HESxHN2cfLAcemnVPu/9od0S7iyLKvX+gx1LggeMNtXRkif8lOUW4x+buc9HK86Eviobg6Dg+uh lCulQ X-Gm-Gg: ASbGncuq9jqdQlFtc0UKfDAsoxGZJwEgYGkXkBWjuUxwmC/bEwOHH6QY0b8SBRionw9 hVEHnpE8nqBIcP8kJNe4l/xnUNAhb0w+5v0nc9laE5E//AlaZS6vGKl9JC2Cd1qrLAzX0UXYVKK tdicoNZguhez++VGZvwOu+OfF3FzARSESfhk6WuFuTm5bC5xFkXPRlm4DUCXI/VXUQ2PiAf89ab tBgcBlLFSgchfXpaVoJw/utoH/yIda/upJ8gqk7qbaDxoHB8y2ujMw3Mywa8QCJKRktIdJCtd4N wKRYSQRN5XB//ZdGK/k4sZ0kcqFdzr/hIjuW63u0f3scVIl0WhAnA2PrE2QTWviKUlKvzqzcNBg fjIfbFQwmTvjWAA7IWJvdzifE41qn X-Google-Smtp-Source: AGHT+IFsYp5+kmZAd8W7I1XRVAz3j1CWDnQ9mLcNlFcNDbLKroEh4NRpqfG+U9oyhuKbb8qf9DR3wA== X-Received: by 2002:a05:600c:4fc4:b0:456:db0:4f3d with SMTP id 5b1f17b1804b1-45a10c05aefmr270445e9.24.1754924825331; Mon, 11 Aug 2025 08:07:05 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:6841:8926:4410:c880]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c3abf0csm40107411f8f.14.2025.08.11.08.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 08:07:02 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 11 Aug 2025 17:06:50 +0200 Subject: [PATCH RESEND 3/3] arm64: dts: qcom: sdm845-samsung-starqltechn: fix GPIO lookup flags for i2c SDA and SCL Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250811-qcom-gpio-lookup-open-drain-v1-3-b5496f80e047@linaro.org> References: <20250811-qcom-gpio-lookup-open-drain-v1-0-b5496f80e047@linaro.org> In-Reply-To: <20250811-qcom-gpio-lookup-open-drain-v1-0-b5496f80e047@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1248; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=6wc+M2Tic42xKT7JSdCDpm9lQ5MO1L7g7K2EIBEDGpc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBomgcOK+MnI5vyPYOBq5tG/nekBDWPVQIiZ98kP myoiQD3QQOJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaJoHDgAKCRARpy6gFHHX ctHEEADA6N4wnWwVaaUUYAIXtqlRIzTgcCv39CoSkVBuPwLys+SiZsORtY1Y9VrQRVPmM54SVUz BSNdBoH3T8pz2yCSQFISICp8s32k1jcK53KFPLw2ShkaJv1V7+JmnoD/Hvvjqg+1+C2r+xMVSs3 NDF1HSw9p3IFXBeZRPXqI5O5TQeBNBAqzTBy9NhTfQeuYOT8GyqXY8b1nz6X8hhTF3zlXrSWI8l xh/6R8jdyKdt598UL1Akgwmz39iTx3vW6vK3OfgFMYHUHJwqX6ZZJPRkkaEl9UKiH3ZJAVffCy5 sS2LHCv42qqyEr2hnGu//sbq0g1OBXO1+JGGBx+YsvXWt1bLaJ9of/Ftdw4xBJD1l3r2Faui6Lc 3Xqv8OMDZHh68VbK2XiTeDMkTIaX2Dj2Qnm1YY9Q6jyHbD1TX4+fT3ULhWCSVjc2yiGSeW3hcDp wUdZS+TGpwzbUYAmSU9cQrJnhiwTQrqjskU+0miD6s6Bobc6hnTbIzxntDMF2Ch0o9UDCGG8cem 85OkCMj931eJq638gazfUAclilRRCgeGV6xfQUNFosgGQYvHd5PHpfSEdycK55U4SEIslE5XUSc 3PxA8iuXyyRi+sQr9/QkpjOu1c6SNJ6e67rSsZvbXU+Icua2n1NEXAj7QS5iL23YkrPPcyBSRDv dPRo2TkgmPqe2pw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski The I2C GPIO bus driver enforces the SDA and SCL pins as open-drain outputs but the lookup flags in the DTS don't reflect that triggering warnings from GPIO core. Add the appropriate flags. Reviewed-by: Konrad Dybcio Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts b/arch= /arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts index d686531bf4eacae2105bbed3a9d5478b45a4b2a3..9076d8eb4d50af736d5c4de7158= fbf32231f6629 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-samsung-starqltechn.dts @@ -145,8 +145,8 @@ rmtfs_mem: rmtfs-mem@fde00000 { =20 i2c21 { compatible =3D "i2c-gpio"; - sda-gpios =3D <&tlmm 127 GPIO_ACTIVE_HIGH>; - scl-gpios =3D <&tlmm 128 GPIO_ACTIVE_HIGH>; + sda-gpios =3D <&tlmm 127 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; + scl-gpios =3D <&tlmm 128 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; i2c-gpio,delay-us =3D <2>; pinctrl-0 =3D <&i2c21_sda_state &i2c21_scl_state>; pinctrl-names =3D "default"; --=20 2.48.1