From nobody Sun Oct 5 03:35:54 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D668C27875C for ; Mon, 11 Aug 2025 10:56:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909820; cv=none; b=mWd5tlNEVlQ2eWtwgOZ4baZcAtMJ2f9ovjG+ro2A8wltL9XnA3IrlyN4bZYBub1j7N5MiXJuC229LUBIYEzjgxL4d2iw03qj/CrCCjzGlYfyCD0pgqblQMUeEIfrc4d6JCW/E6HyDSvBBKeP13YspjNaQqSf09uwDkMocAV3CHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754909820; c=relaxed/simple; bh=y0KLkFzoWiBCsjyKHVyFf5yBXdH+nrgv9bMtrhIbLXo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VCxQIAA/K9uDRafuthf8e3zj/F3pcbKyWtNtymUWzyTSVC6PzCyn5fNw0OEZKDyHJe90+uWdr/wfqwCTPNy3WmMSN3yEZ+dOp6AAjRGDsjR0QoRTVjKY60icISJ2jhIpcTP38XkhsmVTkQwTDJt6/qHsMRa5bq87DrplbWLyqx0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BH1brTqz; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BH1brTqz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754909818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CR+LHOxQNJH4mrdkRrblEPU2A6Ou6dlR4qZMmeyZ4e8=; b=BH1brTqzguJfDbxIemXjvT3RlzqAgYCptrJt797t04nTVIU5hl9qsvIjg0/+d6u/cdjrzg GrT2rSZqNiivVjqRZIigTpPta3q+T+5e2FYeWajy4VOrI3QVhyjd/USLbbBieWUyiP1I0b SujHSzsW4KS2Wrfre2eWCfX8LNpjiHI= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-8KCR8Nl3PrC46z-rDceuVA-1; Mon, 11 Aug 2025 06:56:57 -0400 X-MC-Unique: 8KCR8Nl3PrC46z-rDceuVA-1 X-Mimecast-MFC-AGG-ID: 8KCR8Nl3PrC46z-rDceuVA_1754909816 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7e69c14e992so834375785a.3 for ; Mon, 11 Aug 2025 03:56:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754909816; x=1755514616; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CR+LHOxQNJH4mrdkRrblEPU2A6Ou6dlR4qZMmeyZ4e8=; b=IWE2QMjUcHM/+quE682tJeU7h6Y+aZC8cZregxpaU0h50p3Glll8QCs81RaVVLJlCH allqVdPpMc5qqIiEftE5SfkVGOoA8XIcmh+OHHrsc9NajuLuJellJKU38MkEWrpIxatk IsDSP/RXERbQCUSPYh2POH5Imm5yb/mXfI7wEKEWTEDY0kFU5J3KKAOz+1z1N5Db/Hm0 k1YpSa7IlBRq+8oIsoJlPVJU9hTnzOieLD8Py1Zn+OBZj3yvGGf12es96RbY7joike++ fhzbTp0MGqOjGo8UKI2+OQyqLrvTy46loTXLGK2eA1qNqwroBfbbN4nUf0hFBkrjKaZx tjcQ== X-Forwarded-Encrypted: i=1; AJvYcCXuL1QHEofhB0zt7qV1CWhEJII45Z9kwVZDcvpqBiKEkGh/2rnYVxS+8va3CI1HYqAURxvF8fiP6duH5IE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx70eUOmZb32C6Fu6lEmKVwzo9C4GgI1hJLmfsFjZcmW5DW3vmB kgopwul+kbGyk7rcGkwt+EyBm7DKxGQiPv9I489WGNVX5Z3Rk9qPG1Q17CGbyDqbNdsQENNGzM7 9IUpsggDS6gJD20lM+zxoxCvnewEM59GDurIgT2z5sFaodt+NVoKIRfeUxznMYgJ+Ew== X-Gm-Gg: ASbGncss9AypdWuSArynFO+bo+y34YQm4UltxDftIBm9M4bSmF9i4kaDVHp+HpKVrvO llQr9LtO5yogHPq42A8QhBFyNxfuL2nkHWt0xMpmiXehCcaeSqOlsYZRbXNAe6tL0/r/637h0WJ nWRju+edn/P4jhUDsJs9peZBCgO2PyqevfySIcOKTAUD5Rj4EEZHRETVIJ0X9WylqFNK0M8hSN6 4kobYWy8gwCH066I2IL2epPV+eOim+olmixECL7ZmtQiLRPmExsARBVYY+jbX4C9y025rE5V5Q1 L28jLprEm7j4+5Y+HAD3Htf4oop17XuLWmmjWyP90vH6n9pDARC3HHji8IpQhQinB5dTqeHFTRw uAW0= X-Received: by 2002:a05:620a:1996:b0:7e8:54f7:67cd with SMTP id af79cd13be357-7e854f76862mr91495085a.50.1754909816404; Mon, 11 Aug 2025 03:56:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFSii5P15b+af3L4E7F/cQGCM1Xz8KwmyfhCdGkZGKODW+eFh6Bky1dDzTK+GfwnJZiiMZJQQ== X-Received: by 2002:a05:620a:1996:b0:7e8:54f7:67cd with SMTP id af79cd13be357-7e854f76862mr91484185a.50.1754909814934; Mon, 11 Aug 2025 03:56:54 -0700 (PDT) Received: from [192.168.1.15] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e698de2df7sm1273446485a.80.2025.08.11.03.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 03:56:53 -0700 (PDT) From: Brian Masney Date: Mon, 11 Aug 2025 06:56:13 -0400 Subject: [PATCH v2 9/9] drm/sun4i/sun4i_tcon_dclk: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250811-drm-clk-round-rate-v2-9-4a91ccf239cf@redhat.com> References: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> In-Reply-To: <20250811-drm-clk-round-rate-v2-0-4a91ccf239cf@redhat.com> To: Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stephen Boyd Cc: linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754909781; l=2307; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=y0KLkFzoWiBCsjyKHVyFf5yBXdH+nrgv9bMtrhIbLXo=; b=j1ZnE8gcsk3YjO3zCEvUNiC5B3rrw/rsR6rCeLo5Q9BxZp8jvK69xEFMszvH1iDCwux2pSDHd eRkR0peMpaDCxDNa8Bi3chrL3Nda3ZZTmewCk0Eb5cefUz9pD7/Qw2Q X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Acked-by: Maxime Ripard Signed-off-by: Brian Masney --- drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c b/drivers/gpu/drm/sun4= i/sun4i_tcon_dclk.c index 03d7de1911cd654f395ea85ad914588c4351f391..4afb12bd5281f0d1720cfe2c8f7= 9b80d97244ef2 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon_dclk.c @@ -67,8 +67,8 @@ static unsigned long sun4i_dclk_recalc_rate(struct clk_hw= *hw, return parent_rate / val; } =20 -static long sun4i_dclk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int sun4i_dclk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct sun4i_dclk *dclk =3D hw_to_dclk(hw); struct sun4i_tcon *tcon =3D dclk->tcon; @@ -77,7 +77,7 @@ static long sun4i_dclk_round_rate(struct clk_hw *hw, unsi= gned long rate, int i; =20 for (i =3D tcon->dclk_min_div; i <=3D tcon->dclk_max_div; i++) { - u64 ideal =3D (u64)rate * i; + u64 ideal =3D (u64)req->rate * i; unsigned long rounded; =20 /* @@ -99,17 +99,19 @@ static long sun4i_dclk_round_rate(struct clk_hw *hw, un= signed long rate, goto out; } =20 - if (abs(rate - rounded / i) < - abs(rate - best_parent / best_div)) { + if (abs(req->rate - rounded / i) < + abs(req->rate - best_parent / best_div)) { best_parent =3D rounded; best_div =3D i; } } =20 out: - *parent_rate =3D best_parent; + req->best_parent_rate =3D best_parent; =20 - return best_parent / best_div; + req->rate =3D best_parent / best_div; + + return 0; } =20 static int sun4i_dclk_set_rate(struct clk_hw *hw, unsigned long rate, @@ -155,7 +157,7 @@ static const struct clk_ops sun4i_dclk_ops =3D { .is_enabled =3D sun4i_dclk_is_enabled, =20 .recalc_rate =3D sun4i_dclk_recalc_rate, - .round_rate =3D sun4i_dclk_round_rate, + .determine_rate =3D sun4i_dclk_determine_rate, .set_rate =3D sun4i_dclk_set_rate, =20 .get_phase =3D sun4i_dclk_get_phase, --=20 2.50.1