From nobody Sun Oct 5 03:36:55 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FBAB2D8384 for ; Sun, 10 Aug 2025 22:57:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866667; cv=none; b=IqsscLvesCdr4QdSFjwLVJIaHqNXwE9w6sZmjJXnO1ArW6we9hF13sU1BnC5Ahw2EfLfCTiVGyk/SrWFiHzkIK4X6Oo2Kwr2y9F038pyM044smWd75BvxUoSlxf9k9dIc54PQf2Uu1p88o6mCr8PHhmhe/vHwRmXEPvco+mM/9I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866667; c=relaxed/simple; bh=mlZH8VUTbF6GjSuW92dEJqa/xMC0PXyQyKOZ+vDaxME=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q3GrzMhqaH+sBFUVAI//LmxUq9Ynm5cmXaAOseg/mxUjhAIUVjxMKVZGOEnF++TiESeaucbRbvrcf/4eT5VU9NdsOW/b3xVwvpeBsq1cRD+HEfxtHqOkaHa0yHzsF4oqeFrxfn/zigTZHFOf1WMm/y9ieMKjF6rgKrq585U8udc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UvucMBJN; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UvucMBJN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754866664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bVC0fsmzSbmTSL6eyVRHt/hFHyj+fClbPc4jjMQBQNc=; b=UvucMBJNkkznm4M7nwGZX/p6h8Weq+K2EPxtcd8QsuFvBIK5NVN5qZeavgdnV3d9QoR4hL 8axkZahunuip+2WP05oaUK4tgeyCzveUITZjY5Sd3XTzwcTj+ZrzmJfvUBrTakAP/Ee5cZ JV4Pid4zgOJ6aR/B5z9uHgbXizGC0SI= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-68--hqm_1zaMPyW2mU9mqNZ8Q-1; Sun, 10 Aug 2025 18:57:42 -0400 X-MC-Unique: -hqm_1zaMPyW2mU9mqNZ8Q-1 X-Mimecast-MFC-AGG-ID: -hqm_1zaMPyW2mU9mqNZ8Q_1754866662 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-70707168c59so40446176d6.2 for ; Sun, 10 Aug 2025 15:57:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754866662; x=1755471462; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bVC0fsmzSbmTSL6eyVRHt/hFHyj+fClbPc4jjMQBQNc=; b=GyyUw4ZSZhisgnKTG2lSvLONcgEmQz1ALUWcYFUgqTCLmquyhNH7B7VFQF8xu+8dOe uUp1RNiypF6iENbJuHCfFi6el26wcHRbJcDFknEiFKk1e+v1QA/wOVGDT34qmTjZLUDw G/H58hZG6QhWs6GX/IPUpgX9cRTU2YYImptQ6qHBE40oTTEzg7Jdb/hAy9gbisDhc40j GIitrmhlcnYeBPqj8m6tHPyYXlmQtEefA0/IV8n/dcPLi4Pq5UUjcAOsv/AMaA2hCe9Q dOfG9KIcrHiisNaJZ+7Ea6PAHUZ+Dkbz2TOhnLxgc9QYbZyomcE7F2BXTE+jc33DdROU qZ5w== X-Forwarded-Encrypted: i=1; AJvYcCXX814zzJo7J5bV1Gc7LFIpTdMvn1nWwaQ+R8XCVWTeeCxDM638y6kgEn08BEsYCwv6nK2vRK8uljFGX7c=@vger.kernel.org X-Gm-Message-State: AOJu0YxkEfn0WnH2DSTkX+VeX7XRDbJ8X+qPSHM6i/VcZU85DIe4AgQH 30mD7porM1xXyDeGQGZ5NkCV0nJhBwlDzTGMGbMRNpdQXaCgIi8RYEM2zXkx4HjBSmwg9agw/DQ 70jzBLMui0823eWMDLN5OuivdcErjqjhIRj8X/57xGO9s9qVEheU0AeJIuyMFVMK1KQ== X-Gm-Gg: ASbGnct9AgKcXBDkXNdeBa4mTwEF4Dh4Ekc6Zx95Fjk1dfe1EXirYLTV1KoioqrP+O+ Fj2W0d7siGTPr4nkqWkQggAnBxBgWcWXZ2HI9PXXYw/sMXdhLCaJkb6qxdsV4H94yRCpSIIr9Dj 9Nqk02v+E5uOueeT6uki+nLQ5bLK+JSjJn1ZtN8l6NVbEnbbw899HO4Y/38WFDuKV6sPjK6QW4j 93sOJZXKJCV2JT0uSbLUcfWcaNx3VFgTCPoG8lS5XJ7ptL918obYqNmpWR7iYWyUWxHAPHmqol+ UNw6wJm0lcLIi+NylfCjBr0H48LhfzLOmvwRAaq5xTmO4mfbnJgU3iCOcNAGhlaYjA6lL2dh7aZ Seg5RLw== X-Received: by 2002:a05:6214:2a45:b0:704:e0ab:a9bd with SMTP id 6a1803df08f44-7099a3e56f8mr122299126d6.24.1754866662366; Sun, 10 Aug 2025 15:57:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcMnOEXwtR8lN8UlPgOjL9+Zy3/GaRT4D7BPMh+oeXRYAdB1ptGpb4wo7alWACslPJfTQXCQ== X-Received: by 2002:a05:6214:2a45:b0:704:e0ab:a9bd with SMTP id 6a1803df08f44-7099a3e56f8mr122298976d6.24.1754866661965; Sun, 10 Aug 2025 15:57:41 -0700 (PDT) Received: from [10.144.145.224] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7077cdd9916sm144266336d6.61.2025.08.10.15.57.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Aug 2025 15:57:40 -0700 (PDT) From: Brian Masney Date: Sun, 10 Aug 2025 18:57:25 -0400 Subject: [PATCH v2 1/7] drm/msm/dsi_phy_10nm: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250810-drm-msm-phy-clk-round-rate-v2-1-0fd1f7979c83@redhat.com> References: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> In-Reply-To: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754866653; l=1786; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=mlZH8VUTbF6GjSuW92dEJqa/xMC0PXyQyKOZ+vDaxME=; b=x0tYnThWbgPO4mmw+Gsp2C+ceOXEYoVMWAX/rkUBoIKXhbcdtiiiH5Qx0bZYWg7rb85fOnwgn te+Em4v6YAqCUom67xxN5Ay9xj6+tIi+ghcjTR1lViL5pmDtQqvYeDu X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. The change to use clamp_t() was done manually. Signed-off-by: Brian Masney Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c b/drivers/gpu/drm/m= sm/dsi/phy/dsi_phy_10nm.c index af2e30f3f842a0157f161172bfe42059cabe6a8a..ec486ff02c9b5156cdf0902d054= 64cf57dc9605b 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c @@ -444,21 +444,19 @@ static unsigned long dsi_pll_10nm_vco_recalc_rate(str= uct clk_hw *hw, return (unsigned long)vco_rate; } =20 -static long dsi_pll_10nm_clk_round_rate(struct clk_hw *hw, - unsigned long rate, unsigned long *parent_rate) +static int dsi_pll_10nm_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dsi_pll_10nm *pll_10nm =3D to_pll_10nm(hw); =20 - if (rate < pll_10nm->phy->cfg->min_pll_rate) - return pll_10nm->phy->cfg->min_pll_rate; - else if (rate > pll_10nm->phy->cfg->max_pll_rate) - return pll_10nm->phy->cfg->max_pll_rate; - else - return rate; + req->rate =3D clamp_t(unsigned long, req->rate, + pll_10nm->phy->cfg->min_pll_rate, pll_10nm->phy->cfg->max_pll_rate); + + return 0; } =20 static const struct clk_ops clk_ops_dsi_pll_10nm_vco =3D { - .round_rate =3D dsi_pll_10nm_clk_round_rate, + .determine_rate =3D dsi_pll_10nm_clk_determine_rate, .set_rate =3D dsi_pll_10nm_vco_set_rate, .recalc_rate =3D dsi_pll_10nm_vco_recalc_rate, .prepare =3D dsi_pll_10nm_vco_prepare, --=20 2.50.1 From nobody Sun Oct 5 03:36:55 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E20DF2D8384 for ; Sun, 10 Aug 2025 22:57:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866672; cv=none; b=j6VV0VA366kFy1L4C+AcwVb+qUEPnVI27XFkV+c2552SWBqhJz3cfFpCOHlOWOhwZNrJx/efjbGKwVAE3PMJxnkpILGtk9+laZ774fHpYDKN0yjT2VT6rOpAAaXY9uM68hDF/0EqGudfXEplYruyPa6sIIFHWtugvVvWD4dZlfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866672; c=relaxed/simple; bh=zgC0RAqMfe4QHFoCK3ImKc6JYhHbtGs2pWeVB9da7xM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OO8MfT3OYd9YEZ9p7y4iElrU5B1zjgisJFTSIKMCpFd8Deyjb8+pufAIRq9NMQeLpE8VTyIl3lZ0MWJASkY5FMDH87PCo55GLRGn3rxid+GOu4Hs3wjRXmUZw/Sz0OUnYiEfc/uyrgjODHYv6FVoUlarxnvZRqA8Q1GBZRno4nA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BHHfrfUB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BHHfrfUB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754866670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8SfCqXrLXFpaQOsEIXkeTXLB3lBS80oYBheI2i61aRI=; b=BHHfrfUBzolgUbq/K8ygy+h/KTXAXJJj0IJFH5VoRwcEnnSQUJodA5BxoPfPvJpVvNZAWY fyW7XjiQKgpdj1mSS/qvj5DYNV0CgC3ksEg55Weap2Gipog3zNqYBpfFbVR3L4ft028uFD bIIWtrwUDKr0zYnOimX99c7bvjhh5lo= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-zqJYlU6eOWWducw5gVwtOA-1; Sun, 10 Aug 2025 18:57:48 -0400 X-MC-Unique: zqJYlU6eOWWducw5gVwtOA-1 X-Mimecast-MFC-AGG-ID: zqJYlU6eOWWducw5gVwtOA_1754866668 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-7075a0b5580so79079766d6.2 for ; Sun, 10 Aug 2025 15:57:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754866667; x=1755471467; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8SfCqXrLXFpaQOsEIXkeTXLB3lBS80oYBheI2i61aRI=; b=XVuRWqnC5+dMl0ParqR+cLZYrIUaRMFzeFO3KmjHMvwK9K54gdZ5ChzXXAxa6tYQPA L4GgcI2lSeJxLM12um/vjrg3sU/xA1edEQ/91c5ZlqJxWXqYkQYaOQ9Kchquk8EupMy3 UtSzefUfdu07VpWQKnDn5fS++lX+w7un3VMH5Zx+fLkDxr0xNprVcbm1T0uoPNMYpjQE YyG4gwfkHZdtV2N+J6MMSHSFe4bC+ybcDK1SMS1X+mKwoYIsqipRfAgeT9UjN8ULI6NY OPiwLYg7mWTRAGgSoZOb02yhlUKl7EhcxeB+VaSVYjOZ3qDBALvqIL4+MXaaRdeH2E1A 4HfQ== X-Forwarded-Encrypted: i=1; AJvYcCVxGq1/Fi9MzYiL+0kWIE9OfFGjicH7exAmBRhYIOH//1BPoGRV+iUVVqjSZSy3f3ghKcugVmApdnMIyjg=@vger.kernel.org X-Gm-Message-State: AOJu0YzHvAoEoRtjobFI9GePFM+/hkJ+GpC39RaIkgXwRng2gAQtkqbd rlM6v/eDBI59+ui5IOpLbqO+ZM6N1f6alvYyrTs6+k50nUgSmOUc+0dljnBWA93EQ9U1c51P2VH r9MFJwo3DuNn+MV7sw3Q9va9V1Oels+Hv1RTbeuaj2qUO65m4SUTfEiel3p8XASroOA== X-Gm-Gg: ASbGncvGpuOdbG2udXVwegbyRWF93LEqHOHRN0KIY+Ms/Gwl5MtTDzT22X7TOn9IoV0 VZNaVs6L70sV69vW2om1izqPYm2Rm1vGQUYWxbR3Nt3cseLD4VQVNTqLgAT58OoZdROqEFyAFkV zIsd8zJzkw7st6rPw+we82sIV5LxMXwtnnmId0STVerk8AI2LFd95tMP2APLCkbjfqHQBwf44vq b3uUREbKNzqUBCgkst8q+z4+I7zjrOMS+WRRUTszLB8kv5BSYRr4LDFXTLnr4TpI8PgiZq3Qxsu R3Jn725OFUQlRXJtUFrRyfsU7Za6loRHOe9iqA609CqbRw1PfFh3MZsFzTzrT1kmX3ux+M7SHWR 8wiW0Mw== X-Received: by 2002:a05:6214:21e3:b0:707:616f:fff4 with SMTP id 6a1803df08f44-7099a199543mr177311406d6.10.1754866667578; Sun, 10 Aug 2025 15:57:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmz3g1MbcKxpKoE+L/OvCm0G94lPBEhAXAtzenne1OaexYFo15GBJiT3E87eJ0e4mZmWm1MQ== X-Received: by 2002:a05:6214:21e3:b0:707:616f:fff4 with SMTP id 6a1803df08f44-7099a199543mr177311176d6.10.1754866667214; Sun, 10 Aug 2025 15:57:47 -0700 (PDT) Received: from [10.144.145.224] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7077cdd9916sm144266336d6.61.2025.08.10.15.57.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Aug 2025 15:57:46 -0700 (PDT) From: Brian Masney Date: Sun, 10 Aug 2025 18:57:26 -0400 Subject: [PATCH v2 2/7] drm/msm/dsi_phy_14nm: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250810-drm-msm-phy-clk-round-rate-v2-2-0fd1f7979c83@redhat.com> References: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> In-Reply-To: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754866653; l=3160; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=zgC0RAqMfe4QHFoCK3ImKc6JYhHbtGs2pWeVB9da7xM=; b=g/OyIxfyVmL0j+PhW5RWDXbEs2uOlzP1vLM9nzajU+5emPdyje17xtKS5Qd4HfejxqWdsQWeZ 8ROBSPZGhvzDt9b3VBZA5OUUGLIt5EVJPoH+qM81ctxrdXWei/umj9J X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. The change to use clamp_t() was done manually. Signed-off-by: Brian Masney Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 34 +++++++++++++++-----------= ---- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/m= sm/dsi/phy/dsi_phy_14nm.c index 3a1c8ece6657c988cfb0c26af39b5d145bc576f8..fdefcbd9c2848a1c76414a41b81= 1b29e5fed9ddc 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c @@ -578,21 +578,19 @@ static void dsi_pll_14nm_vco_unprepare(struct clk_hw = *hw) pll_14nm->phy->pll_on =3D false; } =20 -static long dsi_pll_14nm_clk_round_rate(struct clk_hw *hw, - unsigned long rate, unsigned long *parent_rate) +static int dsi_pll_14nm_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dsi_pll_14nm *pll_14nm =3D to_pll_14nm(hw); =20 - if (rate < pll_14nm->phy->cfg->min_pll_rate) - return pll_14nm->phy->cfg->min_pll_rate; - else if (rate > pll_14nm->phy->cfg->max_pll_rate) - return pll_14nm->phy->cfg->max_pll_rate; - else - return rate; + req->rate =3D clamp_t(unsigned long, req->rate, + pll_14nm->phy->cfg->min_pll_rate, pll_14nm->phy->cfg->max_pll_rate); + + return 0; } =20 static const struct clk_ops clk_ops_dsi_pll_14nm_vco =3D { - .round_rate =3D dsi_pll_14nm_clk_round_rate, + .determine_rate =3D dsi_pll_14nm_clk_determine_rate, .set_rate =3D dsi_pll_14nm_vco_set_rate, .recalc_rate =3D dsi_pll_14nm_vco_recalc_rate, .prepare =3D dsi_pll_14nm_vco_prepare, @@ -622,18 +620,20 @@ static unsigned long dsi_pll_14nm_postdiv_recalc_rate= (struct clk_hw *hw, postdiv->flags, width); } =20 -static long dsi_pll_14nm_postdiv_round_rate(struct clk_hw *hw, - unsigned long rate, - unsigned long *prate) +static int dsi_pll_14nm_postdiv_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dsi_pll_14nm_postdiv *postdiv =3D to_pll_14nm_postdiv(hw); struct dsi_pll_14nm *pll_14nm =3D postdiv->pll; =20 - DBG("DSI%d PLL parent rate=3D%lu", pll_14nm->phy->id, rate); + DBG("DSI%d PLL parent rate=3D%lu", pll_14nm->phy->id, req->rate); =20 - return divider_round_rate(hw, rate, prate, NULL, - postdiv->width, - postdiv->flags); + req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, + NULL, + postdiv->width, + postdiv->flags); + + return 0; } =20 static int dsi_pll_14nm_postdiv_set_rate(struct clk_hw *hw, unsigned long = rate, @@ -680,7 +680,7 @@ static int dsi_pll_14nm_postdiv_set_rate(struct clk_hw = *hw, unsigned long rate, =20 static const struct clk_ops clk_ops_dsi_pll_14nm_postdiv =3D { .recalc_rate =3D dsi_pll_14nm_postdiv_recalc_rate, - .round_rate =3D dsi_pll_14nm_postdiv_round_rate, + .determine_rate =3D dsi_pll_14nm_postdiv_determine_rate, .set_rate =3D dsi_pll_14nm_postdiv_set_rate, }; =20 --=20 2.50.1 From nobody Sun Oct 5 03:36:55 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66F631EB9FA for ; Sun, 10 Aug 2025 22:57:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866675; cv=none; b=thjGpwRn4YCB5/cLYzhg6Ashj51zREnqo2zcvOvjZovyTdTYT66vu5zKd5qOGzIM1XeHDSXdgkR9DGikbYPlQGROXusI7zt/vXtfBd8CP1qLZifOQC4EQtEx3qH9+vCCLTVW+YdcAmHn5O5EWElnvnH7sDGmK7OUi2p+ZaAYiX8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866675; c=relaxed/simple; bh=S1ThvUuOJst13Y/YlkE34LQrjuUVO54/oWHL+6E9CBo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jSYbeVFppvBbpc85qQ9etr5bDzYB6c+ZoQ2/cQAbxYQRcOT4FXsOae7V3FJCXD83Md4PHjXJrKdw/KPHAOGquBKAyqPwJTYR7omZp41+4+iR5JwZQH8K//tg75/3mAsAqnxEJLMt7PTe8s+IMZus63id34dZPuxSTbTYH58/tu0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=STG8J45A; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="STG8J45A" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754866673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UO4UTVA/mzla0cfFiIXtkcaKSPEU88yVqzjz85er5YU=; b=STG8J45AD+ceA/9DBiKAsNZN1OqegcradKjcfVE0DRCgCspIbnwAdb8Kyr/hxi0ER1SG/S uW1ttb4V3YZXQ8XGtuLhUzcIRbPSS1DoS4mOdY4u+/JNfZxfChiOGHjIXssWbytEhs/BBp I6Em4q/5zIMBQQgSoUPGS4DwFy9QFwE= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-313-Tx4EVvjLO-WWpsV3BEWoRw-1; Sun, 10 Aug 2025 18:57:52 -0400 X-MC-Unique: Tx4EVvjLO-WWpsV3BEWoRw-1 X-Mimecast-MFC-AGG-ID: Tx4EVvjLO-WWpsV3BEWoRw_1754866672 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-70743a15d33so89404206d6.0 for ; Sun, 10 Aug 2025 15:57:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754866672; x=1755471472; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UO4UTVA/mzla0cfFiIXtkcaKSPEU88yVqzjz85er5YU=; b=rJBE+zc0L/dFrKz/sU5KwgAcPQp3GnjLHjrf6nJ5hlpSOTdkWq0YFCjVzEV3B0sUl+ xa7eNhaP8ZuWGkp0XqLdj/Zrv216NyIWPSsLg04+I1BRig7KDThtMN/78l5aGeTL2+Mn 0tPQdWs9DA4MMAoPESmJpnRAE1Cm7m68O0wNJwL35WlINCgfEJtgGnrSHAewMvpnKnn+ N3/ckvpylMEBUW0WSaYSc+MdAEPuDIrcrHuslBSi3iQz/2U6YmlGpOsi4EBOsz9L0YVz HyEv4sMGDKAmaMfyxBzUKFkJyTExPzoUBskD1rTMj/C6al3GUSZHn9KMmJ1k/Gv0yam7 DH7Q== X-Forwarded-Encrypted: i=1; AJvYcCXejRlmqTV8HmJe+kDGp0PfbACd5UODvnerAGfrQyDHnwBHPXD+dJThBvF29ArVM31t1exd2JJdd7sqsm8=@vger.kernel.org X-Gm-Message-State: AOJu0YwwQQtMDW4XacJ3WCMIXRRh2ZNKCRiPlwIzPB8cT5t8DyrlfABf eruqtZ0m+8Cv0I+0lltlK4hv7yw/+laqZPVxX6V/3Lj2Z6RGg3iWmQxzDZ6kLRfz5DhRUifINh3 AgSotky4LMQiSt+pO6/cDKvz4jv9rMmkINQNukKH+VE3w+JOKgLXxtUjU+cB3WfrGhg== X-Gm-Gg: ASbGnct94mAylgk2cTx0JzDvTWtl3jJopVIorWr2NyB4VN0joeVeMWsAYgjWVT5u3zp M7ydALZ/z58zJ/ix+ER4T1zKr693AQRSc6hEEVkXsS6Bia38pXT6yxKSpHW09F+gNCSWftnaW9S ysnHBjTh7pvy9Sy8LiUfkNEq6rf9mBWjJwiU+GQErkx/ONCnnlbjkS6SfMAY/Wpx7aqLXGaF0ok cLqTe5+wiRsNj294yvdScEaq80NMmJtvEGOqSnlSR0rfEfnb7ZRaFVsu2RObc8NuvkxT2L5iQg5 PAbZqMiFTMyyJqd26M4oXH6izwl6kyBFgrtPvpb0I3d3Kv/CK07MkwXEjn7zMsgnlXkYX/5TwL7 pz4mHHQ== X-Received: by 2002:a05:6214:d02:b0:707:4b51:a490 with SMTP id 6a1803df08f44-7099a19aad2mr137562926d6.5.1754866671695; Sun, 10 Aug 2025 15:57:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8jqqdlU+xWojFno54cfUqsUBZEN8YO23eSx1vJ00mPnhAbDT9uCqATLlZeCwNyroK4P6n/g== X-Received: by 2002:a05:6214:d02:b0:707:4b51:a490 with SMTP id 6a1803df08f44-7099a19aad2mr137562776d6.5.1754866671327; Sun, 10 Aug 2025 15:57:51 -0700 (PDT) Received: from [10.144.145.224] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7077cdd9916sm144266336d6.61.2025.08.10.15.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Aug 2025 15:57:50 -0700 (PDT) From: Brian Masney Date: Sun, 10 Aug 2025 18:57:27 -0400 Subject: [PATCH v2 3/7] drm/msm/dsi_phy_28nm_8960: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250810-drm-msm-phy-clk-round-rate-v2-3-0fd1f7979c83@redhat.com> References: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> In-Reply-To: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754866653; l=3029; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=S1ThvUuOJst13Y/YlkE34LQrjuUVO54/oWHL+6E9CBo=; b=4rVxfvm9gI5nV5UAVPsesymzsnSyxITGfXVS5e8nQ7ETrG0DkGZDJjcM2GeRttJ1xTdECTbGI s8fyPCx6Vs0B/8HLHCZbs2HwuxniL7G5vx63VQcoWh5nqmwlomL+2OO X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. The change to use clamp_t() was done manually. Signed-off-by: Brian Masney Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 32 ++++++++++++---------= ---- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c b/drivers/gpu/= drm/msm/dsi/phy/dsi_phy_28nm_8960.c index f3643320ff2f2bae5301bb94f1fe19fa03db584c..8dcce9581dc38730ab725e0e435= ab93a04c527ed 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c @@ -231,21 +231,19 @@ static void dsi_pll_28nm_vco_unprepare(struct clk_hw = *hw) pll_28nm->phy->pll_on =3D false; } =20 -static long dsi_pll_28nm_clk_round_rate(struct clk_hw *hw, - unsigned long rate, unsigned long *parent_rate) +static int dsi_pll_28nm_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dsi_pll_28nm *pll_28nm =3D to_pll_28nm(hw); =20 - if (rate < pll_28nm->phy->cfg->min_pll_rate) - return pll_28nm->phy->cfg->min_pll_rate; - else if (rate > pll_28nm->phy->cfg->max_pll_rate) - return pll_28nm->phy->cfg->max_pll_rate; - else - return rate; + req->rate =3D clamp_t(unsigned long, req->rate, + pll_28nm->phy->cfg->min_pll_rate, pll_28nm->phy->cfg->max_pll_rate); + + return 0; } =20 static const struct clk_ops clk_ops_dsi_pll_28nm_vco =3D { - .round_rate =3D dsi_pll_28nm_clk_round_rate, + .determine_rate =3D dsi_pll_28nm_clk_determine_rate, .set_rate =3D dsi_pll_28nm_clk_set_rate, .recalc_rate =3D dsi_pll_28nm_clk_recalc_rate, .prepare =3D dsi_pll_28nm_vco_prepare, @@ -296,18 +294,20 @@ static unsigned int get_vco_mul_factor(unsigned long = byte_clk_rate) return 8; } =20 -static long clk_bytediv_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_bytediv_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { unsigned long best_parent; unsigned int factor; =20 - factor =3D get_vco_mul_factor(rate); + factor =3D get_vco_mul_factor(req->rate); + + best_parent =3D req->rate * factor; + req->best_parent_rate =3D clk_hw_round_rate(clk_hw_get_parent(hw), best_p= arent); =20 - best_parent =3D rate * factor; - *prate =3D clk_hw_round_rate(clk_hw_get_parent(hw), best_parent); + req->rate =3D req->best_parent_rate / factor; =20 - return *prate / factor; + return 0; } =20 static int clk_bytediv_set_rate(struct clk_hw *hw, unsigned long rate, @@ -328,7 +328,7 @@ static int clk_bytediv_set_rate(struct clk_hw *hw, unsi= gned long rate, =20 /* Our special byte clock divider ops */ static const struct clk_ops clk_bytediv_ops =3D { - .round_rate =3D clk_bytediv_round_rate, + .determine_rate =3D clk_bytediv_determine_rate, .set_rate =3D clk_bytediv_set_rate, .recalc_rate =3D clk_bytediv_recalc_rate, }; --=20 2.50.1 From nobody Sun Oct 5 03:36:55 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69D242D879E for ; Sun, 10 Aug 2025 22:57:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866681; cv=none; b=AEqCv+A63OqsXqEeXXSF6TA1WTaqTgvv01ifvIEDgHvxbDZQRsaNUDSd+qzCo7Cwoy3+9VFKVRrNauydmG9InwzOBUloeMhXgTDhnhGZgoy6XQ+TJ02c4UjHZo6D6Vsn8rvbDPq9F9aDOMZ4MzTYxnaydE2Benlbzlt55EPPNb4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866681; c=relaxed/simple; bh=p3ik0LUSdZ7pAUi9CZauKm9YuXyhxLdYH6tXOMz9RD8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TPZXKcKoN8DPaep12t1+DcRv9sNP1ZQP4PSYMiCLFxijt8jOSb2Vxkh/97J8cxGCf1rJp3XpFZVY1nZP+IMiPSqciiXCIVQyKjEdLudG7OxNkgQjsVpZZ1ZFYVF982ekgSau3SDHcg88N8eM3lQD7ZLdDI0K5+XkbmRhhx+TwAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YGvPqkJT; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YGvPqkJT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754866678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dBLZ3cfmxr+kqQkwT3NrM5Of/dkFLZw54pOqr7tKcVM=; b=YGvPqkJTqPF18WrxSjlm2zaooXZGPHxoUAYSyqJHo33ZuHpLuBG1QlEQGV9+nZ0PIjS4K6 pddYqkr/uNMUjWfUP+gIjn9z4sI9HWecPFRMb+bZCoVSmyo9bzH7vevdtjpbcXfI0BGsA7 szZ7cN2Y64oK9Ry2GnJECugw7HQ1/S0= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-8RZeFMeuNWuGne48EWHwHg-1; Sun, 10 Aug 2025 18:57:57 -0400 X-MC-Unique: 8RZeFMeuNWuGne48EWHwHg-1 X-Mimecast-MFC-AGG-ID: 8RZeFMeuNWuGne48EWHwHg_1754866676 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-7074f138855so71734336d6.1 for ; Sun, 10 Aug 2025 15:57:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754866676; x=1755471476; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dBLZ3cfmxr+kqQkwT3NrM5Of/dkFLZw54pOqr7tKcVM=; b=W6TQWUilr54EK70QW30HAS9thJZdKpzAbDC2Dj6i6B31ge2EcYbD01cpjkiY87rfzL uu3M0wyL++yg9kv7Z9lJ4/CLCh5OwQqz+G4zbNRxoI5LilRfZk4Sxbza5eUKQhyrJKim z84OY4vJzg/5PKbZXSRqKpRllfuAna4MZ2zwIuDCGZWoUQx2c6DKlmoCq2KMZBJdfnCl uAvk0Fy2plgJZU0ajNcxdxIB8vHUcb3b+fFlvcTVrp/ZETmZDlLDxAJiJlPg596q0vfo lEASTKgK5lH0D0iy0PlXUZAiqdLJUY9X4nE6EiTAc+ThQBfsX3ztLQj+H3nAIcxa1JK9 jWVA== X-Forwarded-Encrypted: i=1; AJvYcCU6aGcbFzkakktbaEzZR5F8p1fF9o4S+9ldCQlzkFr4sXaLcqIEh9wInxyJBaS5KU/QdT5eUKNrHmi2BDw=@vger.kernel.org X-Gm-Message-State: AOJu0YwaSKUnI8VM2vcBloEuCJxoImY5qdNSjRlyCCBEXVHLu4vZE6yH yYP+PUsGHveITf83e59NNHXm0S+p0Jk4W0TNVYXoimLyt9nlEJ65R1QlhMWJ+xI61X4B0a7ymzd PYiTymAtULTuBAlhkYlEK8U7oZI1m9lZ6OqzUvhsgzj4U8MPzMN8ZhTNxGmBetECQIQ== X-Gm-Gg: ASbGncvB4xqbGpe0APuvc8pitSZUopGmSCSoZh8t8qqrmKAHzzRlp/jMSwky4eNVjiS +aLigxVoKIryVO8zUpmMGO+QK5Gr61PoUlyofXy3OHZM3fPSk0KijCV8xlIJe69sQyyrlzqcH1V XYO/w3NEbyuLuR20TeseA7+6BipbclVapJEZCmli2+myKM9xpqb1pJwV1zggCzJ5abAQEay1rl/ 6ZOOEgyg40VCpRLl55kdXlB1QWKqnGOH0QI/23THm28I+hCYIkkuV5SnutCIFcFqdICcyOJLdFD ET/5Y0EWThfJ8+lDuv24ogSooAk28tvoYdaB/2IfWIQqUFYpAjnfeFQ9nSUAioAiNKPVN/LCgdi b6PQEbA== X-Received: by 2002:a05:6214:4585:b0:709:b911:5f9a with SMTP id 6a1803df08f44-709b9116168mr79859956d6.15.1754866676475; Sun, 10 Aug 2025 15:57:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGd1TtWL5ynfgJb6QbL2wAAD9tHrHovMXdTygkPUrPT2VeRi/mGn+68aKi3/k5cra2LUregkg== X-Received: by 2002:a05:6214:4585:b0:709:b911:5f9a with SMTP id 6a1803df08f44-709b9116168mr79859716d6.15.1754866676119; Sun, 10 Aug 2025 15:57:56 -0700 (PDT) Received: from [10.144.145.224] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7077cdd9916sm144266336d6.61.2025.08.10.15.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Aug 2025 15:57:55 -0700 (PDT) From: Brian Masney Date: Sun, 10 Aug 2025 18:57:28 -0400 Subject: [PATCH v2 4/7] drm/msm/dsi_phy_28nm: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250810-drm-msm-phy-clk-round-rate-v2-4-0fd1f7979c83@redhat.com> References: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> In-Reply-To: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754866653; l=2571; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=p3ik0LUSdZ7pAUi9CZauKm9YuXyhxLdYH6tXOMz9RD8=; b=R7LKKqyn/rze/YXErkV3FfpM8ZZMu5HZaOQr/tvP8aTxcbbN5RaDR0RWZNNF6WqbyaV3q+ft9 fhWV9Cc8U6ZAQX8LrMGjTqjByHpN1lvRTa0Cj7+2O1r3z78hDY0dUWJ X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. The change to use clamp_t() was done manually. Signed-off-by: Brian Masney Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c b/drivers/gpu/drm/m= sm/dsi/phy/dsi_phy_28nm.c index 90348a2af3e9dac72924561b23b169a268abc3b0..d00e415b9a991cd515e01d78a48= ac6fe3e830b04 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c @@ -533,21 +533,20 @@ static void dsi_pll_28nm_vco_unprepare(struct clk_hw = *hw) pll_28nm->phy->pll_on =3D false; } =20 -static long dsi_pll_28nm_clk_round_rate(struct clk_hw *hw, - unsigned long rate, unsigned long *parent_rate) +static int dsi_pll_28nm_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dsi_pll_28nm *pll_28nm =3D to_pll_28nm(hw); =20 - if (rate < pll_28nm->phy->cfg->min_pll_rate) - return pll_28nm->phy->cfg->min_pll_rate; - else if (rate > pll_28nm->phy->cfg->max_pll_rate) - return pll_28nm->phy->cfg->max_pll_rate; - else - return rate; + req->rate =3D clamp_t(unsigned long, req->rate, + pll_28nm->phy->cfg->min_pll_rate, + pll_28nm->phy->cfg->max_pll_rate); + + return 0; } =20 static const struct clk_ops clk_ops_dsi_pll_28nm_vco_hpm =3D { - .round_rate =3D dsi_pll_28nm_clk_round_rate, + .determine_rate =3D dsi_pll_28nm_clk_determine_rate, .set_rate =3D dsi_pll_28nm_clk_set_rate, .recalc_rate =3D dsi_pll_28nm_clk_recalc_rate, .prepare =3D dsi_pll_28nm_vco_prepare_hpm, @@ -556,7 +555,7 @@ static const struct clk_ops clk_ops_dsi_pll_28nm_vco_hp= m =3D { }; =20 static const struct clk_ops clk_ops_dsi_pll_28nm_vco_lp =3D { - .round_rate =3D dsi_pll_28nm_clk_round_rate, + .determine_rate =3D dsi_pll_28nm_clk_determine_rate, .set_rate =3D dsi_pll_28nm_clk_set_rate, .recalc_rate =3D dsi_pll_28nm_clk_recalc_rate, .prepare =3D dsi_pll_28nm_vco_prepare_lp, @@ -565,7 +564,7 @@ static const struct clk_ops clk_ops_dsi_pll_28nm_vco_lp= =3D { }; =20 static const struct clk_ops clk_ops_dsi_pll_28nm_vco_8226 =3D { - .round_rate =3D dsi_pll_28nm_clk_round_rate, + .determine_rate =3D dsi_pll_28nm_clk_determine_rate, .set_rate =3D dsi_pll_28nm_clk_set_rate, .recalc_rate =3D dsi_pll_28nm_clk_recalc_rate, .prepare =3D dsi_pll_28nm_vco_prepare_8226, --=20 2.50.1 From nobody Sun Oct 5 03:36:55 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED0D623B629 for ; Sun, 10 Aug 2025 22:58:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866688; cv=none; b=UhZ10X4KxMHl2wxxq8oW999Dw0nTuXPHD1CuQTdSjH+r46vpgoosOiXG+aKoYRqGYsGY6WvkyqECyg8FS+bx901Uqf9kM4tqJdt+yXKg96v91jDjdFgRA+xUYO9M3sZEMvx5Uob+HdaxylDvSI3nYXGDTAx+RSLzztlTEdkgBBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866688; c=relaxed/simple; bh=TCVYIFivGNX+30I7CcW+hQ/ILyWbQUzfCulxzbwFiso=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hnBG8KmQoZNdsnt/O6Rv6nirVMs/RFPocW3Zj5+RiP5LksShM7I3GdDEpxIk1Y9CpCB2vzzKO7DUUxXEQSKC0ok/6TIj/hO2gQWZHfT+Wq0yUQ1gRFKTWa9xFxblEDocUGLeEKSzOxnMNtsM14qqLXW6wb/O7oNJ2xMKIM+dz5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RjTmiGNL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RjTmiGNL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754866685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e+jg/1yqiU75KoHv1FanEm2OpTvKZ33dl3uYGaGgUwg=; b=RjTmiGNL2tjpiJzMXUy9oCYJ0aLb3y2RWfg/bbkUHb++BM9eO6h+IMwwhbDrFwaqLc4lUJ ENh11W+/GmLhEvd7WEf39j4Ke9cFhCGaAcALSdqQX4NC5/wvOngKisFysRgXf/khw/X3SO d9hC6S5C5WOwC++nfIQwpBAT4E8Jp+U= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-vDcKZO7vOqm_u7FsF1o9kw-1; Sun, 10 Aug 2025 18:58:04 -0400 X-MC-Unique: vDcKZO7vOqm_u7FsF1o9kw-1 X-Mimecast-MFC-AGG-ID: vDcKZO7vOqm_u7FsF1o9kw_1754866684 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-7073cd24febso38312456d6.0 for ; Sun, 10 Aug 2025 15:58:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754866683; x=1755471483; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e+jg/1yqiU75KoHv1FanEm2OpTvKZ33dl3uYGaGgUwg=; b=l05h3rnXsQTVfLbl9D0+FMKDfH0ZNjBwBTeUrEEmVD+53P+CpkkmoP0quAs57CJROz 8dokbokBqrnvcRXjvxp5DFvhc14nCLDJ042mxDOWkuiiEu0Neo5+LahPx9CtI7rpNTuj Zhdpq55PX8Sx7oVEjna/wFPFHjligfbsWUZsf95xoexLaMzEYWQ+s2J79XBdhOaMwMQP 9agW8j/hrN3VIjHvnw/YxigAKjJM8f1g01wQSpOLYE+Fg9VlrAPzHATwpNturlj64/cB vb3IfVIYiIHBMRjlIl7iPmkr8OU5nKk+eGWyZ5TSljP+2vS1FE+4y0/VIrmiPgSJW4hh El0g== X-Forwarded-Encrypted: i=1; AJvYcCXhMS4QxRbXB00GZIfrzDIAjj6NsTCFbpebjqAZPxpehrQgGgBCvKIeIZ2jswMJBFFnr0c7YlJNerRea2M=@vger.kernel.org X-Gm-Message-State: AOJu0Yxv16iUY/I9TOHu3nEUw90NCNn/MGxg7QPYLr+pF9w/Pzm0QEqr js7gCM0Xay5d0T7l+mkI+J0XNlKh5Gja3FBg9jVW3ssAMRvGU+nbv8PiOhfy6g8yLfBfrK1E0+F /XFQMYLoNSzAa2xU5GAfQbGoznO9deWTl8tPQmES/L9CKxYHSG2l1X/iYdffIeEHUL4nlTxTotw == X-Gm-Gg: ASbGncuKEsxKHke+GOdZIlyx5/a28Flzsih1uLn24u0tjdTfmD04wW1jiEqlxeYR0i+ QDlAnW+MniFqrC4FbnU56sueec60AtBr3BhNtb7pjQ75++JiFccnuu881hUOWEfg7AKkpt+t9cc 7cyvViOvTPGaOVyiy5pSkZqC7IpYrC7wFWd20LyXuU3NtAEcluDoVbFOgdBGhKSjbEqPyQ12kX9 wmifZZQk0rOl8ZLyhaHmGrJ8dN9IUu9w7pg8hYCtqN6zJZ6JpJ4JhYFkZL5Uxz64JfQcNVYG9jY yOmkjRNbz7Fg2Wpi1HNNzl+XktqEJUve2e6TX5a4z0CqCpAEF4hRWrvHdUmKU6tsFrbKr1x4Nvf Ukc/gfw== X-Received: by 2002:a05:6214:4e17:b0:709:ade9:742c with SMTP id 6a1803df08f44-709ade97506mr71682856d6.43.1754866683162; Sun, 10 Aug 2025 15:58:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFkOu59xQUnrcN/f1twSlF1BrFwL5WoLAQ12FYDXq2PWIP1hHCC8VcITCPbW5zGS+dtgeykrQ== X-Received: by 2002:a05:6214:4e17:b0:709:ade9:742c with SMTP id 6a1803df08f44-709ade97506mr71682586d6.43.1754866682705; Sun, 10 Aug 2025 15:58:02 -0700 (PDT) Received: from [10.144.145.224] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7077cdd9916sm144266336d6.61.2025.08.10.15.57.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Aug 2025 15:58:01 -0700 (PDT) From: Brian Masney Date: Sun, 10 Aug 2025 18:57:29 -0400 Subject: [PATCH v2 5/7] drm/msm/dsi_phy_7nm: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250810-drm-msm-phy-clk-round-rate-v2-5-0fd1f7979c83@redhat.com> References: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> In-Reply-To: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754866653; l=1762; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=TCVYIFivGNX+30I7CcW+hQ/ILyWbQUzfCulxzbwFiso=; b=hYrBk5VBcqe8AFaw5M0JbEMNQ/+5/EqgXMuDpqvpMtHJTmo1+Ev+Hog1C/ZssRnCSzPfMgO4W 91f5Z5fMemWBs805qoxKufqYrIgn1TJu66F/ixECjawgTEoSUzz+mJo X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. The change to use clamp_t() was done manually. Signed-off-by: Brian Masney Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/ms= m/dsi/phy/dsi_phy_7nm.c index 8c98f91a5930c9f2563a6b4824690ceef56987c0..c3bd3f89434eb7d3d0f3bb9455d= 22aa00915e797 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c @@ -561,21 +561,19 @@ static unsigned long dsi_pll_7nm_vco_recalc_rate(stru= ct clk_hw *hw, return (unsigned long)vco_rate; } =20 -static long dsi_pll_7nm_clk_round_rate(struct clk_hw *hw, - unsigned long rate, unsigned long *parent_rate) +static int dsi_pll_7nm_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dsi_pll_7nm *pll_7nm =3D to_pll_7nm(hw); =20 - if (rate < pll_7nm->phy->cfg->min_pll_rate) - return pll_7nm->phy->cfg->min_pll_rate; - else if (rate > pll_7nm->phy->cfg->max_pll_rate) - return pll_7nm->phy->cfg->max_pll_rate; - else - return rate; + req->rate =3D clamp_t(unsigned long, req->rate, + pll_7nm->phy->cfg->min_pll_rate, pll_7nm->phy->cfg->max_pll_rate); + + return 0; } =20 static const struct clk_ops clk_ops_dsi_pll_7nm_vco =3D { - .round_rate =3D dsi_pll_7nm_clk_round_rate, + .determine_rate =3D dsi_pll_7nm_clk_determine_rate, .set_rate =3D dsi_pll_7nm_vco_set_rate, .recalc_rate =3D dsi_pll_7nm_vco_recalc_rate, .prepare =3D dsi_pll_7nm_vco_prepare, --=20 2.50.1 From nobody Sun Oct 5 03:36:55 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E52EE2D8DD0 for ; Sun, 10 Aug 2025 22:58:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866691; cv=none; b=kORBz1CZfCDG/Emu5J2FcNRaZYrSpvw1Kv+2yCEk0l1s9n6xZt5ZlRAmHhOHhIiDIbr76UNJ+AdwywxXfNh/OTm8MtdYy0cB3o7OVr+1zHWjHcychKbeQK24hJN3ZG+b6jH8YbOA4hyTTnU/wsPfz3XB9xYrJI8/Oi5EruAsh+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866691; c=relaxed/simple; bh=09r1lPX7B14MLSuVQJ4dsJkrsJaORU9d2LSd/fRzU/Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kxZI4O7bkeZ43ydqoAXot5UZCow5DO1nmZWOxXt/wfF4jMfFZhC1mUsWmicsM++DK6B8+cih3dlP7UjiIMMG3u3tgxWA139BvaVwdM1sr1m3xKWn5/1yUvDdXa+ToMFZG/KFSN5N4tzCPFgP0kQr5RwXivQ9h0xmdvRNjGJaY1A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Zqz+NHMQ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zqz+NHMQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754866688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fp8kcGzYjp0wtOJJXm9d94iWK2Lu7bI5800+AHFvd0g=; b=Zqz+NHMQMlAMLdtcFzqxnidA6dCBb/wXSZS25bH+/2m+EM8oiUY2kvPWvs6KyB7U5mjoYJ 71prUimDXUxFaNSz6ShgTzVsSCnkhG53R1eYOXVMijYolCUv2yKG+nczJn5QOgBn99wzsz IriGlQadQUToPNq9QeNKoLUlWvuQ+UM= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-J9Tl4p6yN4628pqmg5Gtbg-1; Sun, 10 Aug 2025 18:58:07 -0400 X-MC-Unique: J9Tl4p6yN4628pqmg5Gtbg-1 X-Mimecast-MFC-AGG-ID: J9Tl4p6yN4628pqmg5Gtbg_1754866687 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-7073b4fb53eso80773336d6.0 for ; Sun, 10 Aug 2025 15:58:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754866687; x=1755471487; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fp8kcGzYjp0wtOJJXm9d94iWK2Lu7bI5800+AHFvd0g=; b=PKf8U20gF6xeje5h4UjLYfmFvlUNZpw9EQ/gPRHbhnnzPnjsSWcdZf4uDdnHhhBEnX 1F2O8YVXHKN40pWF1147QD0ODJmlLJRSJPCzLP/sZ4EM0r7P4b3ijek/4V8IgikCOyJT y7Igxh+blfcGHRjFdW4yC+46ye+e4DFyjZysXzJRoF2a1Amxlkn3nv8+pj6p1LzoQDV3 SdPWtaRjYdKfyGJHvh/q5ZyTK/9w8q9i9fgteJfDv54MTZYS2rsdKoLE+eIdX7D5y6XC pz81XiWNudijoswsDETcgQbbXgJyJSoI1Pm8GuIdEw78VcrZ/gvflZ0WZlmP3EZdA1gi 5V9g== X-Forwarded-Encrypted: i=1; AJvYcCWNh6MHbjjCKz3IhCnwpqCx6cbGIGhnOQA2cusqDqNsPnd/CGBU4vJmRNcbpC424nSgkuPxHik6lunFQbA=@vger.kernel.org X-Gm-Message-State: AOJu0YxX9yLmL8guqTi4KCkcv9p9GXbPgpqnbj/nTazorsVTZG5X5nkA /aWbgA+rGoE4drsI4tpzfW74mC/Rd3VS5uVHq6nZTCmqdPQ7beCi18rIONpz60UVn1XoquTAIYm sXa6QlH/OM9Jk6EGkVA0c9q5uNgFX6mN6bEsqGs5tw53SWVPkppShZtX5dnG14+Ne+w== X-Gm-Gg: ASbGnctj7UD9b+KdOgmMAYRHqUfly4nxQeZ1vLk9nQZ6Q1hnTEuCxPDIJPu1K5ojRAl gJdsre5srQWyB2Jo6VDDHwrbhG9JV0ZE+JG8DonMgCeYIMUV3/e9HsGoYpzOidlQIKN52ZVYZgc cHi1rj41jknJuODcnxazfJuFvffPemjZR9cmOc1XE2LiQmpGzbrNbRx5NY8KGCPNLd81Pd5q06B Zbq4Mh52IATM5WczBxBQBXfX5G+RJWKfn2hHzNIWsoVKx0KSIocKboQ+Z9gASjHxdAgLp2cK3B0 LpkfsgEsWPcEsAa55gnBT+HNe8R0JOoYS8hyavgvH0WrmRDLjkO/eFH9ZDFfZVmLLWutwLiuIA4 bR1VdIQ== X-Received: by 2002:ad4:5ced:0:b0:702:d6e2:3894 with SMTP id 6a1803df08f44-7099a283fc6mr144909886d6.9.1754866686901; Sun, 10 Aug 2025 15:58:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF+GPlWVCW9ekKhJg+4g3e28+6oQCiHZCjU/hLom4Wlvy0t+z7ug+DcZyM9qyvldH93bCaBnw== X-Received: by 2002:ad4:5ced:0:b0:702:d6e2:3894 with SMTP id 6a1803df08f44-7099a283fc6mr144909686d6.9.1754866686533; Sun, 10 Aug 2025 15:58:06 -0700 (PDT) Received: from [10.144.145.224] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7077cdd9916sm144266336d6.61.2025.08.10.15.58.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Aug 2025 15:58:05 -0700 (PDT) From: Brian Masney Date: Sun, 10 Aug 2025 18:57:30 -0400 Subject: [PATCH v2 6/7] drm/msm/hdmi_phy_8996: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250810-drm-msm-phy-clk-round-rate-v2-6-0fd1f7979c83@redhat.com> References: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> In-Reply-To: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754866653; l=1762; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=09r1lPX7B14MLSuVQJ4dsJkrsJaORU9d2LSd/fRzU/Y=; b=Ltcr7gblllRTjthopo3qUDdfH31xXqXg3Eunr1kVSjwIRzMGT80F8gmAILsYimdJaEURAIIXT DQUfMhrW4ldDGWChbsCXStaOBBf3jn9wUuWO/HCkvaN+TS3qKQngYao X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. The change to use clamp_t() was done manually. Signed-off-by: Brian Masney Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c b/drivers/gpu/drm/msm= /hdmi/hdmi_phy_8996.c index 8c8d80b59573a37a4008752b16e094a218802508..36e928b0fd5a319b6a12b9be527= 05c067d51c20b 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c @@ -629,16 +629,12 @@ static int hdmi_8996_pll_prepare(struct clk_hw *hw) return 0; } =20 -static long hdmi_8996_pll_round_rate(struct clk_hw *hw, - unsigned long rate, - unsigned long *parent_rate) +static int hdmi_8996_pll_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - if (rate < HDMI_PCLK_MIN_FREQ) - return HDMI_PCLK_MIN_FREQ; - else if (rate > HDMI_PCLK_MAX_FREQ) - return HDMI_PCLK_MAX_FREQ; - else - return rate; + req->rate =3D clamp_t(unsigned long, req->rate, HDMI_PCLK_MIN_FREQ, HDMI_= PCLK_MAX_FREQ); + + return 0; } =20 static unsigned long hdmi_8996_pll_recalc_rate(struct clk_hw *hw, @@ -684,7 +680,7 @@ static int hdmi_8996_pll_is_enabled(struct clk_hw *hw) =20 static const struct clk_ops hdmi_8996_pll_ops =3D { .set_rate =3D hdmi_8996_pll_set_clk_rate, - .round_rate =3D hdmi_8996_pll_round_rate, + .determine_rate =3D hdmi_8996_pll_determine_rate, .recalc_rate =3D hdmi_8996_pll_recalc_rate, .prepare =3D hdmi_8996_pll_prepare, .unprepare =3D hdmi_8996_pll_unprepare, --=20 2.50.1 From nobody Sun Oct 5 03:36:55 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63C422D8DCF for ; Sun, 10 Aug 2025 22:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866695; cv=none; b=GegrfkYJXjPeeDTmQxkM80KxRd2ZBR8KLMxJkcTdLniO/1v2irhNBIO8AMTJwdXDpE4Bb7QsrW2N5wU8v6tqpapKouU9axi+nvDOxPTOxltL5RG5DL7ke03DLk4JgO6AwdHd47stFgMx0NGdLNqANCizCrXgBWZzlBJxzvFqH6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754866695; c=relaxed/simple; bh=b3lpeRdsfILZNbKt0s4jDvsKWYmd9ZM6thqzD9ovEpA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nScwgQUnXHve7m5Rtnnss/QOhWan3n9KWcQb0v4TuvHsmfWR4E4LJieXBs325EK2RO3Om5DYjWSdDGWrMeY9TADsj7jdulmZL/AVdpcqFcBlQRp+FS7jffs1pd1tAEtYEeR87wNch+aHQu7D8L4rYX75moVHL/BjriIBogbSU4Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=D2kM4GYt; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="D2kM4GYt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754866692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FbrTb5TIWzNpxLExdP2beMCh0zMQGTK+0dHd5wdG15k=; b=D2kM4GYtpy3MRtgGqEIc73oaruJOEH5xA+MD5zSi2oR3aKMcCc9+MdOSLk12qiBL8v5MuB NeMIMe4KNmxCPrAGR3TjljxLmpM5GmAmMhj8DTCFuc+TMxy2IUgeTpRCyYzUvKVyx8vBG4 HNclJAcJUJtyp7KcEl/1RqDeocrY4+s= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-N5EiRmIAMz2PSSsJPhoOPw-1; Sun, 10 Aug 2025 18:58:11 -0400 X-MC-Unique: N5EiRmIAMz2PSSsJPhoOPw-1 X-Mimecast-MFC-AGG-ID: N5EiRmIAMz2PSSsJPhoOPw_1754866691 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7e7ffcbce3bso1229839385a.0 for ; Sun, 10 Aug 2025 15:58:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754866690; x=1755471490; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FbrTb5TIWzNpxLExdP2beMCh0zMQGTK+0dHd5wdG15k=; b=Odo7W4KrTI+LkcpOe4HNbSRcubattrUcqOMaeg+7pVhHOcenOzJzQigFZ2F6z5z7EI 3a3Iv0uq0sI2V0tum3Ri09G169T9/y7iTpPaGiBSp6XsAcnq1wGiz21jaU4q89hQwr2V FmtCqWBgAvG4EIkAJRKSnSrA5BLRxC1XTooFvi1JS0IgqajYuwX1swqEYDP1WimCBBBE hyahuLDaGW8OBGv1ad2cjxvW5o16p4g2x05Bk9g6XtcwZ+DmCjQeQdl19+V7E7N1lgTL 5Yz/atTgkkrnd7PNEL9Z4oATaQfY+C68yZb9bN6sM08Jf8wr1clRq8O+53dy7A5/3C9n 4hcw== X-Forwarded-Encrypted: i=1; AJvYcCWznnz4TKE9wAez9vXC54s6qjEONCGYthGxnCcrIKeJf3HTo9pTfblZzs1jY0Nv62bL/4aj7klSW+pwuDs=@vger.kernel.org X-Gm-Message-State: AOJu0YyUMITTyBIrQCi8thgv8SlU8cR2NkGjajWU79hen88luNd527cj d4bulM+sP8+b2nPQJ3LMq43CTAxX+H4zqIdjmIYM53h2Xm98IPX77V+WnQ4GpqqO2Hx9o3V//ss 4FzSiWwVnfB3eHAKJ1KCp6IzRkFAT7D3YH2fEstn4/e2YApNz5tQADU2nAPl8WfiEbA== X-Gm-Gg: ASbGncuTWsJHBDnZpCKGOetUyjgBK9P8FNnAOvFmPekWLK+4aooHnQLBYYcTy7aVvGc I3w/C7wxXc6p4b9mGxytRT1VTBmKoZMXTVukDQPQdKpsobQB1iWWGRWnyI5df6iyKlmg3YJk0Aj cbUfohkwx+8YyEBkPbx6pv/VQtMOpgfd4idx/t4LyMMbVuTrXODhqYA4haKpI9c4IQ5C8HdoY1q fl9FH8fAU8PkCFxLM1ZLI+0FM4VqzExotEmguRmf0QdZbanOhwipifb0QfueEu9ORqtK2jP1Rje hmw5a3rLPFAfj1STaBVr+nQb2WHYo2kt/PGeUpyN0mntTn8xkq15OK+SP1MYWWUR01UyciGUODf R+Kzp8Q== X-Received: by 2002:a05:6214:2469:b0:707:48b6:bcd4 with SMTP id 6a1803df08f44-7099a51356fmr150862576d6.48.1754866690662; Sun, 10 Aug 2025 15:58:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGUGt1AwSBne/o9+rNR3LtSm/WoA2RbHO8v9LNVgg4wnAMJx+OP+IR27C+Pk0SSrEVzMCAAA== X-Received: by 2002:a05:6214:2469:b0:707:48b6:bcd4 with SMTP id 6a1803df08f44-7099a51356fmr150862326d6.48.1754866690271; Sun, 10 Aug 2025 15:58:10 -0700 (PDT) Received: from [10.144.145.224] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7077cdd9916sm144266336d6.61.2025.08.10.15.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Aug 2025 15:58:09 -0700 (PDT) From: Brian Masney Date: Sun, 10 Aug 2025 18:57:31 -0400 Subject: [PATCH v2 7/7] drm/msm/hdmi_phy_8998: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250810-drm-msm-phy-clk-round-rate-v2-7-0fd1f7979c83@redhat.com> References: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> In-Reply-To: <20250810-drm-msm-phy-clk-round-rate-v2-0-0fd1f7979c83@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1754866653; l=1762; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=b3lpeRdsfILZNbKt0s4jDvsKWYmd9ZM6thqzD9ovEpA=; b=bPI+bgndtQjl8U/B8CPlCWIm4ICh/KSI/9pQqEc+JGzlNlWdm7ffMObXa6FktebNdwMw2IQ7l yRXvUD2K69rChwg8WTjpcfmYgZ91P/5xMLfzNQFm4R78kNC3NkqT/fj X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. The change to use clamp_t() was done manually. Signed-off-by: Brian Masney Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm= /hdmi/hdmi_phy_8998.c index 33bb48ae58a2da13b7e90ff419c6e05fec1466af..a86ff370636972168124da19e11= 4f0acab2249d2 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c @@ -646,16 +646,12 @@ static int hdmi_8998_pll_prepare(struct clk_hw *hw) return 0; } =20 -static long hdmi_8998_pll_round_rate(struct clk_hw *hw, - unsigned long rate, - unsigned long *parent_rate) +static int hdmi_8998_pll_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - if (rate < HDMI_PCLK_MIN_FREQ) - return HDMI_PCLK_MIN_FREQ; - else if (rate > HDMI_PCLK_MAX_FREQ) - return HDMI_PCLK_MAX_FREQ; - else - return rate; + req->rate =3D clamp_t(unsigned long, req->rate, HDMI_PCLK_MIN_FREQ, HDMI_= PCLK_MAX_FREQ); + + return 0; } =20 static unsigned long hdmi_8998_pll_recalc_rate(struct clk_hw *hw, @@ -688,7 +684,7 @@ static int hdmi_8998_pll_is_enabled(struct clk_hw *hw) =20 static const struct clk_ops hdmi_8998_pll_ops =3D { .set_rate =3D hdmi_8998_pll_set_clk_rate, - .round_rate =3D hdmi_8998_pll_round_rate, + .determine_rate =3D hdmi_8998_pll_determine_rate, .recalc_rate =3D hdmi_8998_pll_recalc_rate, .prepare =3D hdmi_8998_pll_prepare, .unprepare =3D hdmi_8998_pll_unprepare, --=20 2.50.1