From nobody Sun Oct 5 03:41:04 2025 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D8A82264AB for ; Fri, 8 Aug 2025 20:18:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754684293; cv=none; b=eGJyRpJOU9dhttn6S6uhWn8hoOBFj6hQ7JqJr/EQPs8kS0A9DwBhv2E/4J0z28RKplSNDO5ek3R/HdgK6saKtLwjDH58erLP2yW4cTY64sjgy2P75LAF76lzP2M0Bvi+Je2xXKn+w760g6m4hrpREssRyCGxU3FBXdeMzg9vhvg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754684293; c=relaxed/simple; bh=hh6xjVWEK8/ibl/z6rRGG2rNPMSMa2xpL+TIUlbRNGY=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FcAsotNGJJNSfVdLbIv4GVP+HSS2bHNeuxHMjy5rRpVdzNvkhUxFWrBDPjBxeATrIoQnXYhkFSLJtbR4k5ssILLtQgpl5UlVpd8xNQdp++hEh5Amrxf1VQ2DLAVHpeJsvd0/ikfqLW9373b1aAfHsGp2ibTAyhGclNH5hjTmtY8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=U35PKGXM; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="U35PKGXM" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-4b070e57254so27613011cf.3 for ; Fri, 08 Aug 2025 13:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1754684289; x=1755289089; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=/IhL/CIlLPj6jA+N2gUQ5Qd+JhoFqSryy5qQsBgiWqg=; b=U35PKGXMonKHRrpQf8M8GN+lHetlDD7vC9IBYwq6F1l4A8N1yK6dkiKKB9z0iF7k+N UsUmzRw/fvUnVbEV1NUaqWbRPKWraCl5XPBBp/eKC/duBIaS6RGbICJf33U8UERuo36D fNKMOEXj6CDWPd7JwevihfoP1PwZpjxh5PmKSbbI767NFSHNkIrnS9/5F9PkNl1zAFUn Z9H7XqQL8zeU+98wXYrUBtwKtdOekWkUsXfc3vgSATacZfT8UTfqTBq23FvDi4rkz6CB WZJfUtHpi+hh6gU6pOxvUEXrCvEY5NzGwKbeTF56AMuFTYo7qHbWNceWd2DX9wqMuNGC E/nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754684289; x=1755289089; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/IhL/CIlLPj6jA+N2gUQ5Qd+JhoFqSryy5qQsBgiWqg=; b=DGFYrm6U5B65MoFMBeQ/Anyu1AKKjgEdlufDiuoPFEaf0TyynnlKTDUBvANmX80VTm DA7s2uVNFB7Z2ASifykZif2TMMXvIfw3XeeMuilrHCCGfYRKf9oElwoo/onCnyQkJeST Wk5ib+EICmN7VWR1ibncneuiJqXyuukU17rExBqP/FUs/WdhQQTlNqCYuTcOHdOAHsdu HcZTSPEG9cXY4nKFPf0wQNaESFOZg9A0jkc0PZWHoEP0JaaPvC17CzNIBDBww4I9so3v LK5xXA8aTK2qhXe1gkyaNFnnr69IZoOdZku119G9e20chCH1vOpwAUW1l3Gzclv3ICha /a3Q== X-Forwarded-Encrypted: i=1; AJvYcCWjAFCbwB9W8K0+lpjTjMR4mXwM3Eyahf3/8ToivynBlH1//MJ0Nd8aNabkbFzlE1nfPnaFBBkTY2tWjtU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyqtk20ZDWE32UHx/5hOoaOYI9guHpvVoN23MngLEPV3prba6Kr J4hEPtR8TwLpy5SUpWR3XDVxp858Ii47iHR9HL6sEXox2zFxvL8zB1BYoxuafVADzUk= X-Gm-Gg: ASbGncvP0uJokizb6oZKUMRfdT+b5wPKywV4SE3qV4h3NkyRpiUio+mxn4sbBrVww48 mlDYfMzaga4B4fXKJB035uluyWPNRcnSv3izHVHDOHP2+o0pxtYOYj3GxqapT9Pe3xFB/f4gs0G BSA5ap5PL13vVWH0ZFs/HZ+iy9aNcqNtxjSX4exAiUiQB4NBbIw0osNeCrX0sewI1EE1Nyva4wn syoM8mHv06jwxoI0ADI3wl9u1BbOBXGnEuKQXXzO3AkkHvFdYmmuHe9FgSSF8W3alDjcdZ1uPeV dUOOMtkuA+aiijodgJxTq/lWfM1Z9BMmYUGssvg0mUjrZMbQi3v1gGAicvtvou1iHpL21hjuOuE aAZ1ivpJuSTKlrQTN0ZeX8iXDvoehCQDKOSLjIDeuKWJ1/EPtxi8LxXsd4AGR7dqILqcghq0yzj orh6MgL7D/T13H X-Google-Smtp-Source: AGHT+IGD0W3/4r3I4y7shiD9XqPrTR2Wufmh8nPmwN+kRpU8+fKQFyJQNnxe7IT04T5XIjK11kh55A== X-Received: by 2002:a05:622a:293:b0:4b0:74ac:db48 with SMTP id d75a77b69052e-4b0aed032eamr52138771cf.5.1754684289383; Fri, 08 Aug 2025 13:18:09 -0700 (PDT) Received: from soleen.c.googlers.com.com (235.247.85.34.bc.googleusercontent.com. [34.85.247.235]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4b07c80ddbbsm59490131cf.57.2025.08.08.13.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Aug 2025 13:18:08 -0700 (PDT) From: Pasha Tatashin To: akpm@linux-foundation.org, bhe@redhat.com, pasha.tatashin@soleen.com, rppt@kernel.org, arnd@arndb.de, coxu@redhat.com, dave@vasilevsky.ca, ebiggers@google.com, graf@amazon.com, changyuanl@google.com, kees@kernel.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org Subject: [PATCH v3 1/3] kho: init new_physxa->phys_bits to fix lockdep Date: Fri, 8 Aug 2025 20:18:02 +0000 Message-ID: <20250808201804.772010-2-pasha.tatashin@soleen.com> X-Mailer: git-send-email 2.50.1.703.g449372360f-goog In-Reply-To: <20250808201804.772010-1-pasha.tatashin@soleen.com> References: <20250808201804.772010-1-pasha.tatashin@soleen.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Lockdep shows the following warning: INFO: trying to register non-static key. The code is fine but needs lockdep annotation, or maybe you didn't initialize this object before use? turning off the locking correctness validator. [] dump_stack_lvl+0x66/0xa0 [] assign_lock_key+0x10c/0x120 [] register_lock_class+0xf4/0x2f0 [] __lock_acquire+0x7f/0x2c40 [] ? __pfx_hlock_conflict+0x10/0x10 [] ? native_flush_tlb_global+0x8e/0xa0 [] ? __flush_tlb_all+0x4e/0xa0 [] ? __kernel_map_pages+0x112/0x140 [] ? xa_load_or_alloc+0x67/0xe0 [] lock_acquire+0xe6/0x280 [] ? xa_load_or_alloc+0x67/0xe0 [] _raw_spin_lock+0x30/0x40 [] ? xa_load_or_alloc+0x67/0xe0 [] xa_load_or_alloc+0x67/0xe0 [] kho_preserve_folio+0x90/0x100 [] __kho_finalize+0xcf/0x400 [] kho_finalize+0x34/0x70 This is becase xa has its own lock, that is not initialized in xa_load_or_alloc. Modifiy __kho_preserve_order(), to properly call xa_init(&new_physxa->phys_bits); Fixes: fc33e4b44b27 ("kexec: enable KHO support for memory preservation") Signed-off-by: Pasha Tatashin Acked-by: Mike Rapoport (Microsoft) Cc: stable@vger.kernel.org --- kernel/kexec_handover.c | 28 ++++++++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/kernel/kexec_handover.c b/kernel/kexec_handover.c index e49743ae52c5..65145972d6d6 100644 --- a/kernel/kexec_handover.c +++ b/kernel/kexec_handover.c @@ -144,14 +144,34 @@ static int __kho_preserve_order(struct kho_mem_track = *track, unsigned long pfn, unsigned int order) { struct kho_mem_phys_bits *bits; - struct kho_mem_phys *physxa; + struct kho_mem_phys *physxa, *new_physxa; const unsigned long pfn_high =3D pfn >> order; =20 might_sleep(); =20 - physxa =3D xa_load_or_alloc(&track->orders, order, sizeof(*physxa)); - if (IS_ERR(physxa)) - return PTR_ERR(physxa); + physxa =3D xa_load(&track->orders, order); + if (!physxa) { + int err; + + new_physxa =3D kzalloc(sizeof(*physxa), GFP_KERNEL); + if (!new_physxa) + return -ENOMEM; + + xa_init(&new_physxa->phys_bits); + physxa =3D xa_cmpxchg(&track->orders, order, NULL, new_physxa, + GFP_KERNEL); + + err =3D xa_err(physxa); + if (err || physxa) { + xa_destroy(&new_physxa->phys_bits); + kfree(new_physxa); + + if (err) + return err; + } else { + physxa =3D new_physxa; + } + } =20 bits =3D xa_load_or_alloc(&physxa->phys_bits, pfn_high / PRESERVE_BITS, sizeof(*bits)); --=20 2.50.1.703.g449372360f-goog From nobody Sun Oct 5 03:41:04 2025 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DA3922C339 for ; Fri, 8 Aug 2025 20:18:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754684293; cv=none; b=kcXQ0uRrvXFsoPSJPERG/Y3xbEFxDH6DJZD0I/h8mu6I0KLscrSGrnoDrVS13beMc6KEvb8qWNJGSKC55GtM61QQHmHd9CFHkCwXwfBYII6tyyA8IsjH5N3h5p7ni+0wxPsUCjrirWvDA/buXrl1P+6S5IqscNBCUaKqPbw+ZfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754684293; c=relaxed/simple; bh=Kq8+ejvIFPau5DE9L114jOiMGsVkvN/+RkJoqrEnsEY=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jmo01+Pm64YIBLaaYvxujXhR7+6oeSTSfqOmyRGIrk0uex1xc5D2OpM7QqpnzjzSGWaJ53x+5MD+UbtDhHn4Ickzal6Bk0Vq1jklUgz+Hussx84qMCl36+RUfq+TXiFiYED7C4kCcGntUF2JD+KxOUuexT800YgwaqmpcgTSOzw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=JcA2Z/7n; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="JcA2Z/7n" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-4b0a27ebf01so14009401cf.1 for ; Fri, 08 Aug 2025 13:18:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1754684291; x=1755289091; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=v/EURho8HdzYkRlNQqj4Jp25lWoftNvoIKLrAmtRbxc=; b=JcA2Z/7npS5SkHRQEmgLgih7v0cDldqcChbz7jvffbKPBZmIpMVrNPEsjo2cajRrt/ SJ0cYv04yeiVB6sRzrjR5n/z968kMXBkWviOX45762zJM7XvZLzAG4KcY+o+N8wVa/9Z ZNOCy7WCH/+UKZ93G9cy2kEDd0FuhSoNgukLX5vIfqhz37K8Afp3fi28vbhL+ITGWpqn L3KJdpJSYjHjySD4jfoQl/58qVSnMv5uKagzq/TBNQP0T02Adrm9zjtWTvQ1RQI9EB51 W34+1zpMP4QNz5y6P+A9b42Bb9B2jyuopJhVEE4Qdq4XfzihmSTw65GUBBQCLTL6BMnx OXvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754684291; x=1755289091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v/EURho8HdzYkRlNQqj4Jp25lWoftNvoIKLrAmtRbxc=; b=suCxUWOALOtileFpqcuY5u99QNdUDF83Jmp5Ga+sd/ub/Iuoyfwl9Dtu9Bhs47kSMa PYd1hvlZ8ZvEwRIjBdgOtxzohdIUX3vZSWjIyN/6hu5Lq18VW9h8tfxrdGZOSlZNxi1K w9c4TafPk1rubj/TKf2b5xd+ViQn9Bl4YLOK56g3fwyAPrjGMsGAFJSpJ63zlSGrJN1f 92mo+zEsLeiDo7HGAJmJWV3F/zUVq/MzmI8L0fBxNbGaRy7/8xB+PszlOkqp2omKqcxk tLiGyTocUQSydpYzlmgA02fSt3bI+3Esel8qoo+Hjo5yiDfQ5+LxuSdHqpzJO5NKBn23 tFEA== X-Forwarded-Encrypted: i=1; AJvYcCVOcneOmTDs24hegYIkV+Y9VWu7qoOBMZrKIpKzwl96mnWkAC+k/l72p/YaBtR9ZDGmw8WDXFxhOibMbyU=@vger.kernel.org X-Gm-Message-State: AOJu0YwMicHAnxb5bwtQ3zaArvJh66daEBNdUpdeejIfVNBQ5uBSqtlO WEFZm317uxv36/SLZJO4ewPV956P2mTf0iytn6oG+pfBewgvSSLFNjWM6RNbwoKHVFo= X-Gm-Gg: ASbGnctOmH3PE4dulmRYbW1JxGz74xWid80IgcmFmpwzXvsBPaAmMvF4IXrO55u4fn7 A7cL92MG6Sb9Cpq2qJnC9IpPf3I0ua4ZCgJYXOlhFn3esGOMBlXP43f2sl480cKdLm0+ve8dIUz 8yn8xUo19lvC4adGQ6Kg+kWlj+1XiuL2KivledBti7oOfxo6UDgXhbJ7/akUZI17EeOAu7SWW5V vf//oX19WOVErI5X7WgBj+3+Wo4p9IAnKP3RW6gWvLAyWAltd7tYEkQSUIucuHaIE80rpDfk6gA 3R3p2Mp8bAbiT/enyqRcS0dvm6ywbsIUy/zQbZHmuE/soDVXhwyjxO+XdgqxiOrdQrmaBAGjxr+ Z983I+ccqNRZNbd5MMmckL0u8cVnrqyTZQ/v13BZinANlWI5Gy/S7G1yVbaV/8938sd3gTEx83z 7BHsvWbU85ujiL X-Google-Smtp-Source: AGHT+IGRsYIjYMDPHPWyETlwLlG2Zy30jh5DmGcJISmzXiHxweHbcXx7yy5GDLFSE/EbxlmscbGNTQ== X-Received: by 2002:ac8:5701:0:b0:4b0:695d:9ad0 with SMTP id d75a77b69052e-4b0aed0ba35mr50986991cf.3.1754684290662; Fri, 08 Aug 2025 13:18:10 -0700 (PDT) Received: from soleen.c.googlers.com.com (235.247.85.34.bc.googleusercontent.com. [34.85.247.235]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4b07c80ddbbsm59490131cf.57.2025.08.08.13.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Aug 2025 13:18:09 -0700 (PDT) From: Pasha Tatashin To: akpm@linux-foundation.org, bhe@redhat.com, pasha.tatashin@soleen.com, rppt@kernel.org, arnd@arndb.de, coxu@redhat.com, dave@vasilevsky.ca, ebiggers@google.com, graf@amazon.com, changyuanl@google.com, kees@kernel.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org Subject: [PATCH v3 2/3] kho: mm: Don't allow deferred struct page with KHO Date: Fri, 8 Aug 2025 20:18:03 +0000 Message-ID: <20250808201804.772010-3-pasha.tatashin@soleen.com> X-Mailer: git-send-email 2.50.1.703.g449372360f-goog In-Reply-To: <20250808201804.772010-1-pasha.tatashin@soleen.com> References: <20250808201804.772010-1-pasha.tatashin@soleen.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" KHO uses struct pages for the preserved memory early in boot, however, with deferred struct page initialization, only a small portion of memory has properly initialized struct pages. This problem was detected where vmemmap is poisoned, and illegal flag combinations are detected. Don't allow them to be enabled together, and later we will have to teach KHO to work properly with deferred struct page init kernel feature. Fixes: 990a950fe8fd ("kexec: add config option for KHO") Signed-off-by: Pasha Tatashin Acked-by: Mike Rapoport (Microsoft) Acked-by: Pratyush Yadav Cc: stable@vger.kernel.org --- kernel/Kconfig.kexec | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/Kconfig.kexec b/kernel/Kconfig.kexec index 2ee603a98813..1224dd937df0 100644 --- a/kernel/Kconfig.kexec +++ b/kernel/Kconfig.kexec @@ -97,6 +97,7 @@ config KEXEC_JUMP config KEXEC_HANDOVER bool "kexec handover" depends on ARCH_SUPPORTS_KEXEC_HANDOVER && ARCH_SUPPORTS_KEXEC_FILE + depends on !DEFERRED_STRUCT_PAGE_INIT select MEMBLOCK_KHO_SCRATCH select KEXEC_FILE select DEBUG_FS --=20 2.50.1.703.g449372360f-goog From nobody Sun Oct 5 03:41:04 2025 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91952232369 for ; Fri, 8 Aug 2025 20:18:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754684294; cv=none; b=l9QxQWURghgtz+OucLEy885hajJMPnsuzEmJN4q7a1HqAGy51Fn/tFVYUkWJOHzjXBFbddVZzVryes7LJa5WI4uRf/FfjM0vf/DkKZmtb687qNb3Wgc4O2whOQs6satdxNvJiR8585nPPP+KN9n6H1YSgcBp6ToXPTSx5IhH3ho= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754684294; c=relaxed/simple; bh=EZOsRx6ADKpX4dGzXjqHzAFI3ma9q/+tVtAqcixVW2k=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eCdNagufC7yxOdIr2BW8Br9R8Z7HE/kujBjYLnXIIhP3FDqNXAVteOa6Uly/kKAt/5c2uSUDz2S5NFEvtusRSxiV0txgkizwxfDDm54X3Ha/zX0zKKfGz4vp7iRs5bDpE4wvMsiZCL5QVKSzfAMoaQd05YLiuPkvmT5Em5TD4VA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=FbQ72CmK; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="FbQ72CmK" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4b07275e0a4so29887691cf.3 for ; Fri, 08 Aug 2025 13:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1754684291; x=1755289091; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=yc1Ft/b3qye0Nn2AQUyZWguJ2koiO3eAJtJCginIFUo=; b=FbQ72CmKRH8iFcO6bUfdRn1kNeJMg/5VI4Ja1c4uxqykg3V4FYaUzmX8FwHomI8dQf D2C32kJ49jATPA93WNQrxTt3CvLbwH/ojM9BxG189MYX7oe4AykGnKmBwKnGGuy7atsH EEThjxkM341lt4qcalvoemAx4HwaM1rVB9tkbPsaeeijhQbgJyvZ2NF1DXN3aYCLFhnI 024STp1hCucihfgEbIHDHxlBNjA4IU4Ovx7+0BU3Si5f7P4nFdgblzKLoUOhOiIx4j8f 7vsOWuI5zqwnzvsa5GFWuOFO8u8iUrGNK+MtxUlxwAvfHU+Z7SQie8XMQkP8SKGwtKeA KnsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754684291; x=1755289091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yc1Ft/b3qye0Nn2AQUyZWguJ2koiO3eAJtJCginIFUo=; b=g57J9a/zHfBFNacQ1YnXrueBgi1FPnAa6a7/2L24mtlVlEVumHY5uTsR8IVXXLGzOf pvfBU1Jb8rdlKNoXsi+/40mSjYZB4t3RNh3XqgWu4MBhqO2p27Exjffu5crXb5Ea9vlJ dsybm2BwlThBbRLT2RyJyzzCoFG5mIDeNp9ahbzjU+LHcClT/Qw8wUvF+UjcJAfn9j47 VSb2MbXidPevw1GfVRddtMwb42/xfgp/Imtm3BHlfjtQYJjrVNmGwzzq6dgVE04QBIyK eQUuXLaEC4oK058W0dYC5mSumSPWao8oXlsCk9/bR/OdikElhhEt/nP8cO3FE1yyCOfd 8gzg== X-Forwarded-Encrypted: i=1; AJvYcCXzg09PL0/788x/UERZoKG2CKDvrUJwLNvHzvfsGW2WXtxJmK7h/pb3g6ZH7kvQ0OVToMnyKwU5R6fbe8c=@vger.kernel.org X-Gm-Message-State: AOJu0YzQRW8iPXPHlrInFfkwUpVJl/27+T4NyBTXEa5eXzPDc5DcwNee Q5kj0DoK/03ipdYVjDYnqfxwDIJxlnAEzuI08sM9essbRTGshDTzgC0ECNZ3LXyLpIs= X-Gm-Gg: ASbGncuq/u+7CQG9Uh3SelsRvTrbRV9zorQbQw3rT3CIGDjBkmddHigGs93IXwZ3ygS 2R+fCi7oBH6tNMEpwfkBvLJsTjh98ZmnA2jLmEV6HbQLMSInXWD+RfYn5e7JLxZnGgsuSm8zyO5 e28AIQcqlh6z0UtpKHZv6FHqOjawgeaQs5PeRyS6IZr2PXUXOgqhyJNzt90Y+sWkJXKdxeKmO9a 8s+NEaz87RNvN1J+4I3jHOHMJ8wvOXEBQ0ZbQ7xIRlsszzmNkZ3jeI4ZsFjqXbpB6Z2NhotQ3xW YDEIFpBjR+yKzTnsW3BMTXjHf25tspTyMNnHwpTAjvY+Ce8XszmtC2WW2u/afsfv8GonDyGU88X 2/P3iCl8p8/EbbNkbsts/XC4DlAkA6ke6kS2kbJ2YoV5Ve5TGg5MCRmRR9GhatlIi72w+hrI+o9 m1dwGpMvkcekQNJWLTh+oic7w= X-Google-Smtp-Source: AGHT+IEe17+1VnFzVVxjjjvnJD4w9EO7qMdCyqSXThf7XuoxHsa6VF4qQAx4towsxC8CogahdlN4Jw== X-Received: by 2002:ac8:58c5:0:b0:4b0:8773:9b0f with SMTP id d75a77b69052e-4b0aed0f079mr63563811cf.10.1754684291399; Fri, 08 Aug 2025 13:18:11 -0700 (PDT) Received: from soleen.c.googlers.com.com (235.247.85.34.bc.googleusercontent.com. [34.85.247.235]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4b07c80ddbbsm59490131cf.57.2025.08.08.13.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Aug 2025 13:18:10 -0700 (PDT) From: Pasha Tatashin To: akpm@linux-foundation.org, bhe@redhat.com, pasha.tatashin@soleen.com, rppt@kernel.org, arnd@arndb.de, coxu@redhat.com, dave@vasilevsky.ca, ebiggers@google.com, graf@amazon.com, changyuanl@google.com, kees@kernel.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org Subject: [PATCH v3 3/3] kho: warn if KHO is disabled due to an error Date: Fri, 8 Aug 2025 20:18:04 +0000 Message-ID: <20250808201804.772010-4-pasha.tatashin@soleen.com> X-Mailer: git-send-email 2.50.1.703.g449372360f-goog In-Reply-To: <20250808201804.772010-1-pasha.tatashin@soleen.com> References: <20250808201804.772010-1-pasha.tatashin@soleen.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" During boot scratch area is allocated based on command line parameters or auto calculated. However, scratch area may fail to allocate, and in that case KHO is disabled. Currently, no warning is printed that KHO is disabled, which makes it confusing for the end user to figure out why KHO is not available. Add the missing warning message. Signed-off-by: Pasha Tatashin Acked-by: Mike Rapoport (Microsoft) Acked-by: Pratyush Yadav Cc: stable@vger.kernel.org --- kernel/kexec_handover.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/kexec_handover.c b/kernel/kexec_handover.c index 65145972d6d6..ecd1ac210dbd 100644 --- a/kernel/kexec_handover.c +++ b/kernel/kexec_handover.c @@ -564,6 +564,7 @@ static void __init kho_reserve_scratch(void) err_free_scratch_desc: memblock_free(kho_scratch, kho_scratch_cnt * sizeof(*kho_scratch)); err_disable_kho: + pr_warn("Failed to reserve scratch area, disabling kexec handover\n"); kho_enable =3D false; } =20 --=20 2.50.1.703.g449372360f-goog