From nobody Sun Oct 5 05:27:12 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94A05258CC9 for ; Sat, 9 Aug 2025 00:35:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754699755; cv=none; b=e8MqXrW30uiULl9FQV2TGaR0fMbO6e3gADVa8wHvGn4T0QTnDQnB4Sg84RDlbyk2cZJmhWyQHPxPbb7EERMGlGBwgRjeaLAf6/0VkUV1GKeFbGArqLnP62QDnBRWg5WD0Rp1trQTCecdjFEosXU3bi86TP5S3Ner0JPIF/isJ3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754699755; c=relaxed/simple; bh=JQn53FWdqnsenAxhsXtXftYUURqXJ8dtPT1Q4jRdnDU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EzHXx/bCkBSmoJhK26Muk4PZEBI5Qqui6duJqnjPj5vu1t+Ddd0LGaWbo7WnY4JJIA8+a29gt8tncZbuRJZhVeBb1Zc0Aj0GxwIW1319XX8v7K8czd51Hc5s72WE1qmlP7r/+x0Zs94dHwqWL10k5BOGmu53RSwbes9KME/HpuE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=J71t2Ve+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="J71t2Ve+" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 578DhDaT022425 for ; Sat, 9 Aug 2025 00:35:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lygnt7Zi/DkDBsXWW/2tMmsIMiJD5/QBa7Q1HdwAysI=; b=J71t2Ve+xg0D+Yw9 +Bs7s5zBjwvaNfF4eswxmyQNq3gopOMpfOaSBAuX18u+UZWwuOjMDeA8NdXkuT3U pL0GlnI3zDkMj5Ed29gs8AVaZmkWi+U4xRlkqQ9tCLg7Hycp35tK4YoUy2r/jD6V 58BUZg+J1kDC0phV6l0tc2sjmlbiTBoW+U8eYgGlhzMlBXhFOJReMaNVhrH7lBgB vH3duJW74/OYT9x9KpUIrWsjfApUBuBx3YLaHJHOTbrQL0dd3J3f1ynLJG5wyqTP 1piGel42/S7+ka33rRiD3jyVCLICRqCx+6JAFsYbZ6hSdltQx8FX+Xzld5+LxfLp Vy5/YA== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48cs5ndtwt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 09 Aug 2025 00:35:52 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b2fa1a84566so2335051a12.1 for ; Fri, 08 Aug 2025 17:35:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754699752; x=1755304552; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lygnt7Zi/DkDBsXWW/2tMmsIMiJD5/QBa7Q1HdwAysI=; b=TOAeM+F7AmDu2KGqcO3XAWAvir5BApbOifou75cIuac4lYD38/voV3JyQ59AMdlOGy 4f4OZoQnl8i++N3JO3G2rGgCrt3BccnBxRUme561rkmztQUHSsv/OiVolCiD5E/9zaJM 0tppN/KxrCcoyAwMHxhIjHLkdPPCM6TMpT5j5ytY5JzwJ1LDy3bdOrJaXFzkHqto5STL cjFYV/M69y9ZzlewzioEf+dMjUrET/lUzKQa6VWCrVTtTHStFCfSHtbrmkmnfIRQzpRT 39pFMrG8tWRsiVuDExeBm0M64kg7wq0JkhIhp06dg+8L29dDH9Vc7idwtDwn8Z8v8J7r Risw== X-Forwarded-Encrypted: i=1; AJvYcCUNulGY9TEpM/D+u77+z6c/Yak6gz84q9esk+czbGFMR6w1sPvAriWoVCEjEfYyfiYQL4u6F9KRe1rqgGY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8ItspqpN+I9QavFFBDiG1+8ZEitEbyn0mpPchF05lb6XosP72 7mp7ZniWXLIjxY95hOKnS+9UKnPiJ6J3wavegpij5qUpuLOosZKqS3t+Hy/n6xwf/GG+ams5hfU HZnmahHRyK7Jrl4APpPurp7lvXnMabapJJkCbU8kCRbHh3E2E57sJ5BcMTS1HkEDJ7o8= X-Gm-Gg: ASbGncsG/cOvq266VK3H+AspLUbumi445K3ARqf5Cf2Kewgr/n11TxkByoMP3WZqn+e J2XJ+0SpYd8y5xt5eFLtrql+AJs7frwz+t6n3bmBzQGMQxCuf/hiMXeRmXaYMLqSi8Mx3tMwcYl 9v5tTJmHBqcXWAwzRVofnFqbtakmuooxZ3pxNVR58hlISk1ajD1I74IfR4vG5lnV9oEV7S/6FqL SWRPB0UbF6POEczXZIlzPaxpz8t8Y1t0r41JkMl0YhWETgFNHd+qw79XouZw3TcVwH44MGmaBOd 4zjX8bGHLXKHMgvJUFf+VVJcXcQvUT4glCAU7OhboZVDRhjaiEvr5wL0RGRWv+as4aoc/pU1T4X nEe6SRt+cBE9/dCBK9EoNFwrE X-Received: by 2002:a17:902:e550:b0:240:bf61:fee3 with SMTP id d9443c01a7336-242c225701dmr76135355ad.44.1754699752005; Fri, 08 Aug 2025 17:35:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE33DCMAedQDUiF2/I3ZWb+fz5inLjDwdHMAuwQmrl6+a26bmnVEJtkyEOMMqC99p7LJwIB1g== X-Received: by 2002:a17:902:e550:b0:240:bf61:fee3 with SMTP id d9443c01a7336-242c225701dmr76135015ad.44.1754699751568; Fri, 08 Aug 2025 17:35:51 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241d1ef678dsm219865355ad.39.2025.08.08.17.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Aug 2025 17:35:51 -0700 (PDT) From: Jessica Zhang Date: Fri, 08 Aug 2025 17:35:24 -0700 Subject: [PATCH v2 12/12] drm/msm/dp: Add sink_count and link_ready to debug logs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250808-hpd-refactor-v2-12-7f4e1e741aa3@oss.qualcomm.com> References: <20250808-hpd-refactor-v2-0-7f4e1e741aa3@oss.qualcomm.com> In-Reply-To: <20250808-hpd-refactor-v2-0-7f4e1e741aa3@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang , Kuogee Hsieh Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1754699734; l=3874; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=JQn53FWdqnsenAxhsXtXftYUURqXJ8dtPT1Q4jRdnDU=; b=UfAJZEmii2W1xg/n7I3OixqLYvkqxFi5dqufHjpIdry9W5CQqZsyJUliQA/+ckK85WtgecgCZ CVY9K6KZqniDV8ngdPtL9w803gnE4hUnfeNcWL8TSsh2p37Dk/WXnlm X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Authority-Analysis: v=2.4 cv=Q+XS452a c=1 sm=1 tr=0 ts=689697e9 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=nsv5_4zRg9i3qj8PKKQA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: X8G3rWTDVQWbxcIKqhvJX4QGzVUTPJDE X-Proofpoint-ORIG-GUID: X8G3rWTDVQWbxcIKqhvJX4QGzVUTPJDE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA3MDA2OSBTYWx0ZWRfX33bBFsqK4+f5 R+MNeqxYHv7JJ6SMseFuWFU1NLW0Ip31IRcDUkv3Lrb72rwV0T4yDUp+mr4JAHXDdyQ/orlKU4N D+49k/Vn7kH7c1Woo2HOqg1qDiS2feHh+NbiZNkNNBnhJ0CWo/hcY7RMFLYGKpymYkjK8luibtI teH0wvvO4bj6D2+cNd9bGNeJl3YinMl8WlRaZ7wIQtf37Fju0KyQVEGE1WK+zDsBKcHZKqeMemN D0Xgra0p8Shblh0itLaVolNbY7gqUYJDtr0pR1Zc88qH0PM+QrJc8QkIYsXyMPyXpcXi30y2KQr KV5qQC7iBVUth2PNrPzk0kiup5jEInhRx6CGylVpxaHB63wADF1UHpLtCcO5Pe+aQtOTSvynLnu z8bTcwpn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-08_08,2025-08-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 impostorscore=0 phishscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508070069 Add sink count and link_ready to the debug logs for [un]plug and HPD IRQ handling. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 38 ++++++++++++++++++++++++---------= ---- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index dd529942f7db..93ea623473f4 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -455,8 +455,10 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_displa= y_private *dp, u32 data) =20 msm_dp_aux_enable_xfers(dp->aux, true); =20 - drm_dbg_dp(dp->drm_dev, "Before, type=3D%d\n", - dp->msm_dp_display.connector_type); + drm_dbg_dp(dp->drm_dev, "Before, type=3D%d sink_count=3D%d, link_ready=3D= %d\n", + dp->msm_dp_display.connector_type, + dp->link->sink_count, + dp->msm_dp_display.link_ready); =20 if (dp->msm_dp_display.link_ready) return 0; @@ -473,8 +475,10 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_displa= y_private *dp, u32 data) pm_runtime_put_sync(&pdev->dev); } =20 - drm_dbg_dp(dp->drm_dev, "After, type=3D%d\n", - dp->msm_dp_display.connector_type); + drm_dbg_dp(dp->drm_dev, "After, type=3D%d sink_count=3D%d, link_ready=3D%= d\n", + dp->msm_dp_display.connector_type, + dp->link->sink_count, + dp->msm_dp_display.link_ready); =20 /* uevent will complete connection part */ return 0; @@ -500,8 +504,10 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_disp= lay_private *dp, u32 data) =20 msm_dp_aux_enable_xfers(dp->aux, false); =20 - drm_dbg_dp(dp->drm_dev, "Before, type=3D%d\n", - dp->msm_dp_display.connector_type); + drm_dbg_dp(dp->drm_dev, "Before, type=3D%d sink_count=3D%d, link_ready=3D= %d\n", + dp->msm_dp_display.connector_type, + dp->link->sink_count, + dp->msm_dp_display.link_ready); =20 if (!dp->msm_dp_display.link_ready) return 0; @@ -528,8 +534,10 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_disp= lay_private *dp, u32 data) /* signal the disconnect event early to ensure proper teardown */ msm_dp_display_handle_plugged_change(&dp->msm_dp_display, false); =20 - drm_dbg_dp(dp->drm_dev, "After, type=3D%d\n", - dp->msm_dp_display.connector_type); + drm_dbg_dp(dp->drm_dev, "After, type=3D%d, sink_count=3D%d, link_ready=3D= %d\n", + dp->msm_dp_display.connector_type, + dp->link->sink_count, + dp->msm_dp_display.link_ready); =20 /* uevent will complete disconnection part */ pm_runtime_put_sync(&pdev->dev); @@ -539,13 +547,17 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_dis= play_private *dp, u32 data) static int msm_dp_irq_hpd_handle(struct msm_dp_display_private *dp, u32 da= ta) { /* irq_hpd can happen at either connected or disconnected state */ - drm_dbg_dp(dp->drm_dev, "Before, type=3D%d\n", - dp->msm_dp_display.connector_type); + drm_dbg_dp(dp->drm_dev, "Before, type=3D%d, sink_count=3D%d, link_ready= =3D%d\n", + dp->msm_dp_display.connector_type, + dp->link->sink_count, + dp->msm_dp_display.link_ready); =20 msm_dp_display_usbpd_attention_cb(&dp->msm_dp_display.pdev->dev); =20 - drm_dbg_dp(dp->drm_dev, "After, type=3D%d\n", - dp->msm_dp_display.connector_type); + drm_dbg_dp(dp->drm_dev, "After, type=3D%d, sink_count=3D%d, link_ready=3D= %d\n", + dp->msm_dp_display.connector_type, + dp->link->sink_count, + dp->msm_dp_display.link_ready); =20 return 0; } @@ -1540,7 +1552,7 @@ void msm_dp_bridge_hpd_notify(struct drm_bridge *brid= ge, hpd_link_status =3D msm_dp_aux_is_link_connected(dp->aux); } =20 - drm_dbg_dp(dp->drm_dev, "type=3D%d link connected=3D0x%x, link_ready=3D%d= , status=3D%d\n", + drm_dbg_dp(dp->drm_dev, "type=3D%d link hpd_link_status=3D0x%x, link_read= y=3D%d, status=3D%d\n", msm_dp_display->connector_type, hpd_link_status, msm_dp_display->link_ready, status); =20 --=20 2.50.1