From nobody Sun Oct 5 07:26:07 2025 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEAFE27A460 for ; Thu, 7 Aug 2025 20:17:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754597825; cv=none; b=TOkuqXwV1mkZQAU7jSLJ8Ai73Q3KmSfPNwbdNNBiA88pjBYYXzfENiaO4HmXZfk57IleWHyfDo58lpyYZrgBd7h0r5P48bJ5bRX5AWmV1imBTQ8S3VPyq2tNR/6ENMZ3PPirno7BWN2SUWzUEnTka4xk2jLPK+B3gJo5UcNSCa0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754597825; c=relaxed/simple; bh=1lLJEQt553XarCyVGURP6/QnoZ2UebtBy96ceC/3gK8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=VK2sw09V607NJCVGRoHz9uToXwjtqN2Xru1MauQR1J9qPOEiUZLOxVPczf+JCxQtJxzI4pOmY7DkRJd+DjpNG3GK61Ywm3nKl/bvtPxt+x+OkUwRFe4VJOIwROsBdXLDQ7X7jtBGsZhHAInLd74/GEfRJLnQpMd/w5ebZcNooUk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--sagis.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=e3AVs2QC; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--sagis.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="e3AVs2QC" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2425e41424cso16922495ad.1 for ; Thu, 07 Aug 2025 13:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1754597823; x=1755202623; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=fHXS+IMdX42x6FMeqA3gkQMVcireV7tMgGO8OV5Mnhw=; b=e3AVs2QCc9NnGFsBQYPSG2Akl7trxCTBwBcYRxpPLgXqSDAJDth5/pm8s+O9xwxJM3 fE1JfYtShwXfOyc8SLHQKn9WC6kEotQfyhZx3pWEeUXvrHX6z0LxJjWqASybeLMRjvVh 74AKk+1ss7gmrfRFrQ3sQMIuOMVzl6X/rj2r9oMvIwHMts4fWxueHjAjtY6EpayyYqYb 2yHtud1UxK5yhxzwRAd1N0BxUb5hZL0d6XRZaY5lEcfE5to4Ar9SKYaIFcpQlerjzJDz H7VfdMgPr/t37KiNjCwUX+EUrraWtt1N2aEj9Pmcw2C4zJJj4hy+cmx3KrfcSTPtBDOM HcjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754597823; x=1755202623; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fHXS+IMdX42x6FMeqA3gkQMVcireV7tMgGO8OV5Mnhw=; b=MICd4YFCvP5ImihMl/Yi7ZesxvfKW3MOT1ixBVWqvXg8eMN+EAEXL5b0gPOH08uIOw VJwNfABi/HFZ/ot1RegZEP6Li99jtNrP6Alyg7fqVMCW85qVmVbwgbfON2OiAlx+F3IV p2tA74siv+ePARp1zHR3UNcaCRwj0D1ljVKms7SgWMRnIZm8QHq28krDNmzwXKiKEVME 6hMsHpTCa/l0CAbLKHmAtMPRUQe8yNmOQehuXMcuxZBg6eEH1Kl1umOAbumXE7hGSV5Z SgHt7sHYH7Ba/e+LK6Qn1fBajReV1Wcp59u+k34fTOvWv1qNeyvy/q8fP6KIg/jJaQPd iYMg== X-Gm-Message-State: AOJu0YwIx1ZDGGFn1iDYaDh061AozlnkdzFPhJgXUnOx8EoYHUI/qDYX GZ4ejAWIoX1bv+tZ741++1EhKCPcwsCVv39lPwlDDAieNzbrpGoGqbrnGpX6raTkaOGULd7CaiD d+w== X-Google-Smtp-Source: AGHT+IFqenLs+t/iiOJ8dl6m0BMR2FI1dhWrueWing11YrkV8I+u/puGCyRBZbK2SKvLUeG3O0QjlAxWLw== X-Received: from plbkh8.prod.google.com ([2002:a17:903:648:b0:240:1bbf:686b]) (user=sagis job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:19ce:b0:240:cd3e:d860 with SMTP id d9443c01a7336-242c220df9cmr4079385ad.41.1754597823307; Thu, 07 Aug 2025 13:17:03 -0700 (PDT) Date: Thu, 7 Aug 2025 13:16:13 -0700 In-Reply-To: <20250807201628.1185915-1-sagis@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250807201628.1185915-1-sagis@google.com> X-Mailer: git-send-email 2.51.0.rc0.155.g4a0f42376b-goog Message-ID: <20250807201628.1185915-18-sagis@google.com> Subject: [PATCH v8 17/30] KVM: selftests: TDX: Add TDX HLT exit test From: Sagi Shahar To: linux-kselftest@vger.kernel.org, Paolo Bonzini , Shuah Khan , Sean Christopherson , Ackerley Tng , Ryan Afranji , Andrew Jones , Isaku Yamahata , Erdem Aktas , Rick Edgecombe , Sagi Shahar , Roger Wang , Binbin Wu , Oliver Upton , "Pratik R. Sampat" , Reinette Chatre , Ira Weiny Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Erdem Aktas The test verifies that the guest runs TDVMCALL and the guest vCPU enters to the halted state. Co-developed-by: Sagi Shahar Signed-off-by: Sagi Shahar Signed-off-by: Erdem Aktas Signed-off-by: Sagi Shahar --- .../selftests/kvm/include/x86/tdx/tdx.h | 2 + tools/testing/selftests/kvm/lib/x86/tdx/tdx.c | 10 +++ tools/testing/selftests/kvm/x86/tdx_vm_test.c | 81 ++++++++++++++++++- 3 files changed, 92 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/include/x86/tdx/tdx.h b/tools/test= ing/selftests/kvm/include/x86/tdx/tdx.h index 56359a8c4c19..b5831919a215 100644 --- a/tools/testing/selftests/kvm/include/x86/tdx/tdx.h +++ b/tools/testing/selftests/kvm/include/x86/tdx/tdx.h @@ -9,6 +9,7 @@ #define TDG_VP_VMCALL_GET_TD_VM_CALL_INFO 0x10000 #define TDG_VP_VMCALL_REPORT_FATAL_ERROR 0x10003 =20 +#define TDG_VP_VMCALL_INSTRUCTION_HLT 12 #define TDG_VP_VMCALL_INSTRUCTION_IO 30 #define TDG_VP_VMCALL_INSTRUCTION_RDMSR 31 #define TDG_VP_VMCALL_INSTRUCTION_WRMSR 32 @@ -20,4 +21,5 @@ uint64_t tdg_vp_vmcall_get_td_vmcall_info(uint64_t *r11, = uint64_t *r12, uint64_t *r13, uint64_t *r14); uint64_t tdg_vp_vmcall_instruction_rdmsr(uint64_t index, uint64_t *ret_val= ue); uint64_t tdg_vp_vmcall_instruction_wrmsr(uint64_t index, uint64_t value); +uint64_t tdg_vp_vmcall_instruction_hlt(uint64_t interrupt_blocked_flag); #endif // SELFTEST_TDX_TDX_H diff --git a/tools/testing/selftests/kvm/lib/x86/tdx/tdx.c b/tools/testing/= selftests/kvm/lib/x86/tdx/tdx.c index 99ec45a5a657..e89ca727286e 100644 --- a/tools/testing/selftests/kvm/lib/x86/tdx/tdx.c +++ b/tools/testing/selftests/kvm/lib/x86/tdx/tdx.c @@ -93,3 +93,13 @@ uint64_t tdg_vp_vmcall_instruction_wrmsr(uint64_t index,= uint64_t value) =20 return __tdx_hypercall(&args, 0); } + +uint64_t tdg_vp_vmcall_instruction_hlt(uint64_t interrupt_blocked_flag) +{ + struct tdx_hypercall_args args =3D { + .r11 =3D TDG_VP_VMCALL_INSTRUCTION_HLT, + .r12 =3D interrupt_blocked_flag, + }; + + return __tdx_hypercall(&args, 0); +} diff --git a/tools/testing/selftests/kvm/x86/tdx_vm_test.c b/tools/testing/= selftests/kvm/x86/tdx_vm_test.c index 079ac266a44e..720ef5e87071 100644 --- a/tools/testing/selftests/kvm/x86/tdx_vm_test.c +++ b/tools/testing/selftests/kvm/x86/tdx_vm_test.c @@ -642,6 +642,83 @@ void verify_guest_msr_writes(void) printf("\t ... PASSED\n"); } =20 +/* + * Verifies HLT functionality. + */ +void guest_hlt(void) +{ + uint64_t interrupt_blocked_flag; + uint64_t ret; + + interrupt_blocked_flag =3D 0; + ret =3D tdg_vp_vmcall_instruction_hlt(interrupt_blocked_flag); + tdx_assert_error(ret); + + tdx_test_success(); +} + +void _verify_guest_hlt(int signum); + +void wake_me(int interval) +{ + struct sigaction action; + + action.sa_handler =3D _verify_guest_hlt; + sigemptyset(&action.sa_mask); + action.sa_flags =3D 0; + + TEST_ASSERT(sigaction(SIGALRM, &action, NULL) =3D=3D 0, + "Could not set the alarm handler!"); + + alarm(interval); +} + +void _verify_guest_hlt(int signum) +{ + static struct kvm_vcpu *vcpu; + struct kvm_vm *vm; + + /* + * This function will also be called by SIGALRM handler to check the + * vCPU MP State. If vm has been initialized, then we are in the signal + * handler. Check the MP state and let the guest run again. + */ + if (vcpu) { + struct kvm_mp_state mp_state; + + vcpu_mp_state_get(vcpu, &mp_state); + TEST_ASSERT_EQ(mp_state.mp_state, KVM_MP_STATE_HALTED); + + /* Let the guest to run and finish the test.*/ + mp_state.mp_state =3D KVM_MP_STATE_RUNNABLE; + vcpu_mp_state_set(vcpu, &mp_state); + return; + } + + vm =3D td_create(); + td_initialize(vm, VM_MEM_SRC_ANONYMOUS, 0); + vcpu =3D td_vcpu_add(vm, 0, guest_hlt); + td_finalize(vm); + + printf("Verifying HLT:\n"); + + printf("\t ... Running guest\n"); + + /* Wait 1 second for guest to execute HLT */ + wake_me(1); + tdx_run(vcpu); + + tdx_test_assert_success(vcpu); + + kvm_vm_free(vm); + printf("\t ... PASSED\n"); +} + +void verify_guest_hlt(void) +{ + _verify_guest_hlt(0); +} + int main(int argc, char **argv) { ksft_print_header(); @@ -649,7 +726,7 @@ int main(int argc, char **argv) if (!is_tdx_enabled()) ksft_exit_skip("TDX is not supported by the KVM. Exiting.\n"); =20 - ksft_set_plan(9); + ksft_set_plan(10); ksft_test_result(!run_in_new_process(&verify_td_lifecycle), "verify_td_lifecycle\n"); ksft_test_result(!run_in_new_process(&verify_report_fatal_error), @@ -668,6 +745,8 @@ int main(int argc, char **argv) "verify_guest_msr_writes\n"); ksft_test_result(!run_in_new_process(&verify_guest_msr_reads), "verify_guest_msr_reads\n"); + ksft_test_result(!run_in_new_process(&verify_guest_hlt), + "verify_guest_hlt\n"); =20 ksft_finished(); return 0; --=20 2.51.0.rc0.155.g4a0f42376b-goog