From nobody Sun Oct 5 05:29:03 2025 Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FF3C2206A6 for ; Thu, 7 Aug 2025 18:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=85.215.255.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754593000; cv=pass; b=PNFCw4XUHn142SxA8dtPkLsSzSfVKX8+IuJMd2A5okcRXbNAVW9DW4rIAP3CmMp4uMaX+ByVmpVNVOW6lMuHg3eUPXD/0F/IG6uitsVwy0hSyzFEFlZc4Xjh7B7q41j54YLw9NPL+weayspJiLHJ0OyzxR5C9RZhd/5M+xU+Ze0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754593000; c=relaxed/simple; bh=NnDtTwFvLQ0Rr2HPPVNQHfOWHto9wSQDfYXWq60KuXo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=ET8qebvGH/fd0aPkHKX1f9yBNiBo/Qkx2TT/zkpSOspuGfiQgJ6QjYejPyPDLWbgBcFV+u/z3yDk+4cVbC2pi+4q1PoaH5N+9yps+ZhVAVj3kMZpsTJ112XGwGF6vrmbuDqaB+Rvq9wc2fNb1SFPrYgOJqofrBHvQufgTW5J2Gg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=jrehkemper.de; spf=none smtp.mailfrom=jrehkemper.de; dkim=pass (2048-bit key) header.d=jrehkemper.de header.i=@jrehkemper.de header.b=XwqXkt2x; dkim=permerror (0-bit key) header.d=jrehkemper.de header.i=@jrehkemper.de header.b=yTYBaQon; arc=pass smtp.client-ip=85.215.255.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=jrehkemper.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=jrehkemper.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=jrehkemper.de header.i=@jrehkemper.de header.b="XwqXkt2x"; dkim=permerror (0-bit key) header.d=jrehkemper.de header.i=@jrehkemper.de header.b="yTYBaQon" ARC-Seal: i=1; a=rsa-sha256; t=1754592989; cv=none; d=strato.com; s=strato-dkim-0002; b=LMq1OD3q5MaWC1TM6LuUTTyvjpB+GYARlQfZexQF93o/Q8tZwS0iAybqBiSfKiqu8L sNXNxc4oIBmIb6+jBOsO2cVLpFeRFXDREYjRIyNQE64f54ibM19QD+PV1hoxzMpUn4gq Z286WAdxNnfdNLM4zgEWYViJx8qLGfC0YT/Einqrb2eCsZq1Edi8rYEZ6inSUANZ7vKn a0yzI8DtiKPiUDvwzSdktMSafNN1SY9m7zVej71SclciA+wvXPZVztfr9tD2SvEWqAD8 KBuTlnpyWcLeKUdkxoAiYNR+cgPb9wTiZAuZ1xndnn/SfgP3FhF9ogO3lKf2x8LlN/r0 RBlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1754592989; s=strato-dkim-0002; d=strato.com; h=Message-ID:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=YzDBe2sAGz/FOk8/LhAxz0Yhd2qb63gxZFWAqhaO1/c=; b=gbcHsLvYCk1LgbWSDRc5jDuFgo3FEKf1BJnpoktotxYqo6H754sZSh9BZhuZPbwOS+ qGG24w0W2H1dTJH6maNpMTRO/SjhsFYX6wEob4Mv8VqTraVxk06b9gzO/gWvXqaT8f5i +8999MOKOB98pEM33KBPS+bp0dvtIys0bo/s0rZNjRSZZDiUUHc8yRRTCHzEfoUS9wOD KHAPkK1VSt7TSXepNdtjaPXwDfq6VGuiFeZkafeAwmxsKtSRCSqWFJgP89tQkmgxf678 vzQS8Ld8oTxYmfqKoe3Em1vSEnBwsaXHRbNwP+5A+OXxSNq+tV7HcYQuFpMLoKNmKkmU swzg== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1754592989; s=strato-dkim-0002; d=jrehkemper.de; h=Message-ID:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=YzDBe2sAGz/FOk8/LhAxz0Yhd2qb63gxZFWAqhaO1/c=; b=XwqXkt2xmo6i0n686iOj+HzxbhD0JMG+HlKt5+pJozLDb+c+e6Jlj1kS63Q2L9Xk7/ ODuwNiHjrz4OlTAaFEWFa2MZedPHaJYhKv4JKQI0owPA2Hf5hnVlmhVpl/4UAnA5dz5l ZDLQaUdeN+YzND7EyEHEivk3M2BLvCInjzIIO88BdtMgA/pqfjY9C+igBuWtSQ87NYxW FSeqbbbef7BlBDG/E8cGHJLRwtcZxwvH9PKn9qt8fSpDaLxdM0NNXL26hbS3QhOGfDiC 5mFhKcwyxWtWFV5Lv02dzB+lld0Hm2CGdbSx7huvPAnB63vIJi3FSrMM72szxf2hyJ7B dbJw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1754592989; s=strato-dkim-0003; d=jrehkemper.de; h=Message-ID:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=YzDBe2sAGz/FOk8/LhAxz0Yhd2qb63gxZFWAqhaO1/c=; b=yTYBaQonpKAl5cDqrrwFMGDyxt56LMjPhbgSgDpN9qr+MXhJglu1W/l7+gVp2AnIOR K7Q1ihgsSobky5SC9GDg== X-RZG-AUTH: ":P3UXYUWlW/UH7OuSEKkxZGZB7CoZcv/KhgufPjlnnfm8Lzx4y5P5Ne1ZkYm0mIrMdSfG" Received: from localhost by smtp.strato.de (RZmta 52.1.2 AUTH) with ESMTPSA id y4e242177IuTSru (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 7 Aug 2025 20:56:29 +0200 (CEST) From: Jannik Rehkemper To: gregkh@linuxfoundation.org, vivek6429.ts@gmail.com Cc: philipp.g.hortmann@gmail.com, dan.carpenter@linaro.org, hansg@kernel.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Jannik Rehkemper Subject: [PATCH] staging: rtl8723bs: fix checkpatch spaces preferred around that Date: Thu, 7 Aug 2025 20:54:37 +0200 Message-ID: <20250807185436.853318-2-jannik@jrehkemper.de> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Added spaces where prefered or required by the checkpatch.pl script to adhere codestyle. Signed-off-by: Jannik Rehkemper --- .../staging/rtl8723bs/core/rtw_wlan_util.c | 60 +++++++++---------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 0c6072d08661..1def9758852c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -170,10 +170,10 @@ void get_rate_set(struct adapter *padapter, unsigned = char *pbssrate, int *bssrat =20 void set_mcs_rate_by_mask(u8 *mcs_set, u32 mask) { - u8 mcs_rate_1r =3D (u8)(mask&0xff); - u8 mcs_rate_2r =3D (u8)((mask>>8)&0xff); - u8 mcs_rate_3r =3D (u8)((mask>>16)&0xff); - u8 mcs_rate_4r =3D (u8)((mask>>24)&0xff); + u8 mcs_rate_1r =3D (u8)(mask & 0xff); + u8 mcs_rate_2r =3D (u8)((mask >> 8) & 0xff); + u8 mcs_rate_3r =3D (u8)((mask >> 16) & 0xff); + u8 mcs_rate_4r =3D (u8)((mask >> 24) & 0xff); =20 mcs_set[0] &=3D mcs_rate_1r; mcs_set[1] &=3D mcs_rate_2r; @@ -267,21 +267,21 @@ inline void rtw_set_oper_ch(struct adapter *adapter, = u8 ch) dvobj->on_oper_ch_time =3D jiffies; =20 #ifdef DBG_CH_SWITCH - cnt +=3D scnprintf(msg+cnt, len-cnt, "switch to ch %3u", ch); + cnt +=3D scnprintf(msg + cnt, len - cnt, "switch to ch %3u", ch); =20 for (i =3D 0; i < dvobj->iface_nums; i++) { struct adapter *iface =3D dvobj->padapters[i]; =20 - cnt +=3D scnprintf(msg+cnt, len-cnt, " [%s:", ADPT_ARG(iface)); + cnt +=3D scnprintf(msg + cnt, len - cnt, " [%s:", ADPT_ARG(iface)); if (iface->mlmeextpriv.cur_channel =3D=3D ch) - cnt +=3D scnprintf(msg+cnt, len-cnt, "C"); + cnt +=3D scnprintf(msg + cnt, len - cnt, "C"); else - cnt +=3D scnprintf(msg+cnt, len-cnt, "_"); + cnt +=3D scnprintf(msg + cnt, len - cnt, "_"); if (iface->wdinfo.listen_channel =3D=3D ch && !rtw_p2p_chk_state(&iface= ->wdinfo, P2P_STATE_NONE)) - cnt +=3D scnprintf(msg+cnt, len-cnt, "L"); + cnt +=3D scnprintf(msg + cnt, len - cnt, "L"); else - cnt +=3D scnprintf(msg+cnt, len-cnt, "_"); - cnt +=3D scnprintf(msg+cnt, len-cnt, "]"); + cnt +=3D scnprintf(msg + cnt, len - cnt, "_"); + cnt +=3D scnprintf(msg + cnt, len - cnt, "]"); } =20 #endif /* DBG_CH_SWITCH */ @@ -381,7 +381,7 @@ int is_client_associated_to_ap(struct adapter *padapter) pmlmeext =3D &padapter->mlmeextpriv; pmlmeinfo =3D &(pmlmeext->mlmext_info); =20 - if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && ((pmlmeinfo->state&0x03= ) =3D=3D WIFI_FW_STATION_STATE)) + if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && ((pmlmeinfo->state & 0x= 03) =3D=3D WIFI_FW_STATION_STATE)) return true; else return _FAIL; @@ -392,7 +392,7 @@ int is_client_associated_to_ibss(struct adapter *padapt= er) struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); =20 - if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && ((pmlmeinfo->state&0x03= ) =3D=3D WIFI_FW_ADHOC_STATE)) + if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && ((pmlmeinfo->state & 0x= 03) =3D=3D WIFI_FW_ADHOC_STATE)) return true; else return _FAIL; @@ -431,7 +431,7 @@ void invalidate_cam_all(struct adapter *padapter) =20 spin_lock_bh(&cam_ctl->lock); cam_ctl->bitmap =3D 0; - memset(dvobj->cam_cache, 0, sizeof(struct cam_entry_cache)*TOTAL_CAM_ENTR= Y); + memset(dvobj->cam_cache, 0, sizeof(struct cam_entry_cache) * TOTAL_CAM_EN= TRY); spin_unlock_bh(&cam_ctl->lock); } =20 @@ -453,7 +453,7 @@ void _write_cam(struct adapter *padapter, u8 entry, u16= ctrl, u8 *mac, u8 *key) break; default: i =3D (j - 2) << 2; - val =3D (key[i] | (key[i+1] << 8) | (key[i+2] << 16) | (key[i+3] << 24)= ); + val =3D (key[i] | (key[i + 1] << 8) | (key[i + 2] << 16) | (key[i + 3] = << 24)); break; } =20 @@ -522,7 +522,7 @@ static bool _rtw_camid_is_gk(struct adapter *adapter, u= 8 cam_id) if (!(cam_ctl->bitmap & BIT(cam_id))) goto exit; =20 - ret =3D (dvobj->cam_cache[cam_id].ctrl&BIT6)?true:false; + ret =3D (dvobj->cam_cache[cam_id].ctrl & BIT6) ? true : false; =20 exit: return ret; @@ -537,7 +537,7 @@ static s16 _rtw_camid_search(struct adapter *adapter, u= 8 *addr, s16 kid) for (i =3D 0; i < TOTAL_CAM_ENTRY; i++) { if (addr && memcmp(dvobj->cam_cache[i].mac, addr, ETH_ALEN)) continue; - if (kid >=3D 0 && kid !=3D (dvobj->cam_cache[i].ctrl&0x03)) + if (kid >=3D 0 && kid !=3D (dvobj->cam_cache[i].ctrl & 0x03)) continue; =20 cam_id =3D i; @@ -571,7 +571,7 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta= _info *sta, u8 kid) =20 mlmeinfo =3D &adapter->mlmeextpriv.mlmext_info; =20 - if ((((mlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) || ((mlmeinfo->stat= e&0x03) =3D=3D WIFI_FW_ADHOC_STATE)) + if ((((mlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) || ((mlmeinfo->st= ate & 0x03) =3D=3D WIFI_FW_ADHOC_STATE)) && !sta) { /* AP/Ad-hoc mode group key: static alloction to default key by key ID */ if (kid > 3) { @@ -585,7 +585,7 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta= _info *sta, u8 kid) cam_id =3D kid; } else { int i; - u8 *addr =3D sta?sta->hwaddr:NULL; + u8 *addr =3D sta ? sta->hwaddr : NULL; =20 if (!sta) { if (!(mlmeinfo->state & WIFI_FW_ASSOC_SUCCESS)) { @@ -792,7 +792,7 @@ void WMMOnAssocRsp(struct adapter *padapter) switch (ACI) { case 0x0: rtw_hal_set_hwreg(padapter, HW_VAR_AC_PARAM_BE, (u8 *)(&acParm)); - acm_mask |=3D (ACM ? BIT(1):0); + acm_mask |=3D (ACM ? BIT(1) : 0); edca[XMIT_BE_QUEUE] =3D acParm; break; =20 @@ -804,13 +804,13 @@ void WMMOnAssocRsp(struct adapter *padapter) =20 case 0x2: rtw_hal_set_hwreg(padapter, HW_VAR_AC_PARAM_VI, (u8 *)(&acParm)); - acm_mask |=3D (ACM ? BIT(2):0); + acm_mask |=3D (ACM ? BIT(2) : 0); edca[XMIT_VI_QUEUE] =3D acParm; break; =20 case 0x3: rtw_hal_set_hwreg(padapter, HW_VAR_AC_PARAM_VO, (u8 *)(&acParm)); - acm_mask |=3D (ACM ? BIT(3):0); + acm_mask |=3D (ACM ? BIT(3) : 0); edca[XMIT_VO_QUEUE] =3D acParm; break; } @@ -1170,7 +1170,7 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *p= frame, u32 packet_len) ht_info_infos_0 =3D 0; } if (ht_cap_info !=3D cur_network->bcn_info.ht_cap_info || - ((ht_info_infos_0&0x03) !=3D (cur_network->bcn_info.ht_info_infos_0&0= x03))) { + ((ht_info_infos_0 & 0x03) !=3D (cur_network->bcn_info.ht_info_infos_0= & 0x03))) { { /* bcn_info_update */ cur_network->bcn_info.ht_cap_info =3D ht_cap_info; @@ -1238,12 +1238,12 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 = *pframe, u32 packet_len) goto _mismatch; =20 if (encryp_protocol =3D=3D ENCRYP_PROTOCOL_WPA || encryp_protocol =3D=3D = ENCRYP_PROTOCOL_WPA2) { - pbuf =3D rtw_get_wpa_ie(&bssid->ies[12], &wpa_ielen, bssid->ie_length-12= ); + pbuf =3D rtw_get_wpa_ie(&bssid->ies[12], &wpa_ielen, bssid->ie_length - = 12); if (pbuf && (wpa_ielen > 0)) { rtw_parse_wpa_ie(pbuf, wpa_ielen + 2, &group_cipher, &pairwise_cipher, &is_8021x); } else { - pbuf =3D rtw_get_wpa2_ie(&bssid->ies[12], &wpa_ielen, bssid->ie_length-= 12); + pbuf =3D rtw_get_wpa2_ie(&bssid->ies[12], &wpa_ielen, bssid->ie_length = - 12); =20 if (pbuf && (wpa_ielen > 0)) rtw_parse_wpa2_ie(pbuf, wpa_ielen + 2, &group_cipher, @@ -1630,7 +1630,7 @@ void process_addba_req(struct adapter *padapter, u8 *= paddba_req, u8 *addr) =20 if (psta) { param =3D le16_to_cpu(preq->BA_para_set); - tid =3D (param>>2)&0x0f; + tid =3D (param >> 2) & 0x0f; =20 preorder_ctrl =3D &psta->recvreorder_ctrl[tid]; =20 @@ -1648,7 +1648,7 @@ void update_TSF(struct mlme_ext_priv *pmlmeext, u8 *p= frame, uint len) pIE =3D pframe + sizeof(struct ieee80211_hdr_3addr); pbuf =3D (__le32 *)pIE; =20 - pmlmeext->TSFValue =3D le32_to_cpu(*(pbuf+1)); + pmlmeext->TSFValue =3D le32_to_cpu(*(pbuf + 1)); =20 pmlmeext->TSFValue =3D pmlmeext->TSFValue << 32; =20 @@ -1674,14 +1674,14 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlme= ext, u8 *pframe, uint len) pIE =3D pframe + sizeof(struct ieee80211_hdr_3addr); pbuf =3D (__le32 *)pIE; =20 - tsf =3D le32_to_cpu(*(pbuf+1)); + tsf =3D le32_to_cpu(*(pbuf + 1)); tsf =3D tsf << 32; tsf |=3D le32_to_cpu(*pbuf); =20 /* delay =3D (timestamp mod 1024*100)/1000 (unit: ms) */ /* delay_ms =3D do_div(tsf, (pmlmeinfo->bcn_interval*1024))/1000; */ - delay_ms =3D do_div(tsf, (pmlmeinfo->bcn_interval*1024)); - delay_ms =3D delay_ms/1000; + delay_ms =3D do_div(tsf, (pmlmeinfo->bcn_interval * 1024)); + delay_ms =3D delay_ms / 1000; =20 if (delay_ms >=3D 8) pmlmeext->bcn_delay_cnt[8]++; --=20 2.50.1