From nobody Sun Oct 5 07:22:39 2025 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 672DB25F798; Thu, 7 Aug 2025 13:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754574962; cv=none; b=HIEK6PcgUA5qxMQiyHIHktoZFu2XW9LUxUr0FzuzrBimDSkoCntvFZiwajpNCyWIY1VTETkYLxUC+SJiBEZRcps1YiuRkUpMR0gJOzjWA3JRupt7n6R/jFSPnoeOrJ32CSXEZ6/sCY6jtUNs92Ehee4HhhIKoy4kZMJlWCkrkr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754574962; c=relaxed/simple; bh=/TDoLoAhctmjAWMVE7SheYXDr42tTImW0wlVGjr8Rgc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Yt3yCHN7To9gLwvukbiS2pkxruJIFTJtQniVkv7eNh6vFOkMvFnzwd+s52nsvqm35qtmDE7GMqTuZ+xUubwxgeahSvnGynzl9nyrBzgdiFfimeqJYvTROdSN2gJzmF2mJhb2QbRkdZN0JMBto8nsIVUwKkiR+nQvK632i4R0I4I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=nbNf+TEC; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="nbNf+TEC" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 577DJQH2012314; Thu, 7 Aug 2025 13:55:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=jkQ7QH 69gsRvGYUyPEqL7QOSe+6tJjj6DmYw3MwPqNE=; b=nbNf+TECkoaIlHlgRVQpnk 1tTYH9Iy1H1LZhJAzI9cTBKbX3B5czYxrQGpGW3Lqg05bBDzjbO4J/q6kglOcbQE NZr2BvIykfhxz8Lo9mLNIX5VsUgc2+6ABYrjLgFMjC139Gcxkk039bx3BuOlUf49 uBsmqoQkAob8Epxw7Y/EKSkBX+t9gz7CanR4kung07qFo9vH595aeQ6GJXGvvv+l zCeKzFD195SSsqH7xRu4vIqUlqJgRCKQiJJVxn531KruuGm8kTZZk7hWR2wIT2Ml hO2AahF6BZo631MtaSpL6OvvtOCSu6gUzzMs64S8QZ9FayGBsaVu4oFCJPtWQKAg == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48bq63tcwd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 13:55:51 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 577DtpJo011134; Thu, 7 Aug 2025 13:55:51 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48bq63tcw6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 13:55:51 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 577Ds8xT025959; Thu, 7 Aug 2025 13:55:50 GMT Received: from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 48bpwn8vx8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 13:55:50 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 577DtmHv29491774 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Aug 2025 13:55:48 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4AA6558052; Thu, 7 Aug 2025 13:55:48 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7FA9D58064; Thu, 7 Aug 2025 13:55:45 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 7 Aug 2025 13:55:45 +0000 (GMT) From: Niklas Schnelle Date: Thu, 07 Aug 2025 15:55:38 +0200 Subject: [PATCH v5 1/3] PCI/AER: Fix missing uevent on recovery when a reset is requested Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250807-add_err_uevents-v5-1-adf85b0620b0@linux.ibm.com> References: <20250807-add_err_uevents-v5-0-adf85b0620b0@linux.ibm.com> In-Reply-To: <20250807-add_err_uevents-v5-0-adf85b0620b0@linux.ibm.com> To: Bjorn Helgaas , Lukas Wunner , Mahesh J Salgaonkar Cc: Linas Vepstas , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Manivannan Sadhasivam , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Peter Oberparleiter , Matthew Rosato , "Oliver O'Halloran" , Sinan Kaya , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Niklas Schnelle , Keith Busch X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1239; i=schnelle@linux.ibm.com; h=from:subject:message-id; bh=/TDoLoAhctmjAWMVE7SheYXDr42tTImW0wlVGjr8Rgc=; b=owGbwMvMwCX2Wz534YHOJ2GMp9WSGDKmbIh9uu69I+fbv+90D8ncCH1wq+ZDhdjuc6uaPUSkz wv4SFU/7yhlYRDjYpAVU2RZ1OXst65giumeoP4OmDmsTCBDGLg4BWAiHlMZ/vB4BKxUfi4Rf2lx pNmZ/Cqh+N1ZkcrMX1hYTn56cnBBKAfDf2+mFvP5LN37BUwfSa3M36ltVpMzvTwhLH7ZA6bH6Vb ZjAA= X-Developer-Key: i=schnelle@linux.ibm.com; a=openpgp; fpr=9DB000B2D2752030A5F72DDCAFE43F15E8C26090 X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA3MDExMiBTYWx0ZWRfX/Wsfsd3duAV+ gB09k35NtU7zgEf2kV5bD4kA4j7MLNVQ4Cvx+eQjKcBFrttwnKzid+2nhYDi+kzG7cixdcaQMbX 7JOINajx/vXuiHAuo/i7abgGHMPwIjdkCQsVsxSDPexakVgzg30KH/CFpJgcj/1yxqvAepH+D1Z SZ3AfwYFuaozlmgC5TJsDhyUgWFV9XfLGnpOekvztxpHwKlDP9kbHnY6Wa7/0dUob+0i+opbNB6 M3VTs24EAxK6OzPFoHDA29Z1oqdB5xTrwSzEZg3jL+0UMtP+Edo0EIIbd3Z47oPiiPw4KlGLhMD J8xtxFWVL1sidUXR1CbyHEA8NbchXUPHjMrbH5ZWCaCNf6tAKY/kEQX5MJGo6z9mSNrjLqzFYzC 5x2Fzr/yZ4PB3/BPBKmTX4IowPHS2QsuHkj3c4V4WWF5dU0uPLzZpTtX4N8mCEM9r1sMpJZe X-Proofpoint-ORIG-GUID: 2dtXW_pF9OBePDYon2CoX1t3L3veg34U X-Authority-Analysis: v=2.4 cv=LreSymdc c=1 sm=1 tr=0 ts=6894b067 cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=Tbr2KL6GNvhcKcAIiBYA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: BcmCkv8-ZkfKRRNsvXXt4tPM_dDmpQdI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-07_02,2025-08-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 impostorscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508070112 Since commit 7b42d97e99d3 ("PCI/ERR: Always report current recovery status for udev") AER uses the result of error_detected() as parameter to pci_uevent_ers(). As pci_uevent_ers() however does not handle PCI_ERS_RESULT_NEED_RESET this results in a missing uevent for the beginning of recovery if drivers request a reset. Fix this by treating PCI_ERS_RESULT_NEED_RESET as beginning recovery. Cc: stable@vger.kernel.org Fixes: 7b42d97e99d3 ("PCI/ERR: Always report current recovery status for ud= ev") Reviewed-by: Lukas Wunner Signed-off-by: Niklas Schnelle --- drivers/pci/pci-driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index 67db34fd10ee7101baeeaae1bb9bec3b13e2fdeb..94ba6938b7c6271b557cc7f17ff= b89631d83827e 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -1592,6 +1592,7 @@ void pci_uevent_ers(struct pci_dev *pdev, enum pci_er= s_result err_type) switch (err_type) { case PCI_ERS_RESULT_NONE: case PCI_ERS_RESULT_CAN_RECOVER: + case PCI_ERS_RESULT_NEED_RESET: envp[idx++] =3D "ERROR_EVENT=3DBEGIN_RECOVERY"; envp[idx++] =3D "DEVICE_ONLINE=3D0"; break; --=20 2.48.1 From nobody Sun Oct 5 07:22:39 2025 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7164B262FE6; Thu, 7 Aug 2025 13:56:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754574965; cv=none; b=tsrVs9mfSjr1zIbmJ8E9jFv1SmAiW+hMPTrdNGZjovia/zbVmMYciWWgDQnBoIZGbfAcrVqNTEw7qDO4pgiPSDcYW6ntqzDlFYG470LQMKL0SjbmXBj9K4hiwwNR6EzvEh5zvGOigIJfMM/lBHt32DGpxM4QkS+RSoxKeAGGKSY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754574965; c=relaxed/simple; bh=052dvgQxomwEVj6h89TauZrrC59BaSmnJfbTE7aDz2E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pfXIduLAZtZg5irJmpDq/Swr46OdZ4C8/P2PeXfvuTH9h/cFZOcKiKIUDRyLaSjNO+PcN7C/uCnXXFvGJzPu1cEuYufJWJf1lrMnslINBO8IDcR8z3JTxju7p5DKwu/BrfaKUWZLNH1GH8N7mYqY4farLtX17XdWSzkkXkPY/DU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=DzAWEm8p; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="DzAWEm8p" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5776W1CQ017986; Thu, 7 Aug 2025 13:55:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=dnzNl6 nzTzRC5x2v/gK2+9RF29p0evKhXuLll1Ad/j8=; b=DzAWEm8pVcOc8PZtNDL102 TsfJldKBQdW4W9Wa83M7pMWWUALGCkCgKO0JmvRU4WTZFnmh8RMJJN+xjdNi3REs Fts0Eg+V2T8U6D1gKGiUY+fZ9RQ7FBxwmo5jsgcg6NCGIH3fC0zs95IqALSu2uxT rhFXGzmfgl4Z8xZDfnHlUzXgXlGFdr1Zsrq2MmyF8lHDUeN6h+yGdCWfWIf82rou sbnikQCUoy7riCh6LSr61VYsG8Ws2F/nCE8iPl5FWaLconab9jZHFC/hXVo6sh/h s7Ugjyh1TVYwWDOsBRx21nasTX3SsmZpOba/5wwN1CcLB3DQNEBs2jeuh+1B3a5g == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48bq63ac32-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 13:55:54 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 577DsbFP010838; Thu, 7 Aug 2025 13:55:53 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48bq63ac2y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 13:55:53 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 577DZbdw001602; Thu, 7 Aug 2025 13:55:52 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 48bpwr0vmh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 13:55:52 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 577DtpOw31916682 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Aug 2025 13:55:51 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4FAAA58052; Thu, 7 Aug 2025 13:55:51 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 847E65805A; Thu, 7 Aug 2025 13:55:48 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 7 Aug 2025 13:55:48 +0000 (GMT) From: Niklas Schnelle Date: Thu, 07 Aug 2025 15:55:39 +0200 Subject: [PATCH v5 2/3] PCI/ERR: s390/pci: Use pci_uevent_ers() in PCI recovery Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250807-add_err_uevents-v5-2-adf85b0620b0@linux.ibm.com> References: <20250807-add_err_uevents-v5-0-adf85b0620b0@linux.ibm.com> In-Reply-To: <20250807-add_err_uevents-v5-0-adf85b0620b0@linux.ibm.com> To: Bjorn Helgaas , Lukas Wunner , Mahesh J Salgaonkar Cc: Linas Vepstas , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Manivannan Sadhasivam , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Peter Oberparleiter , Matthew Rosato , "Oliver O'Halloran" , Sinan Kaya , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Niklas Schnelle , Keith Busch X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3021; i=schnelle@linux.ibm.com; h=from:subject:message-id; bh=052dvgQxomwEVj6h89TauZrrC59BaSmnJfbTE7aDz2E=; b=owGbwMvMwCX2Wz534YHOJ2GMp9WSGDKmbIhVbLRuv3BuT0vgX/7Ib1/8eFmXfd96e3nt6gmfv vu8ell9uaOUhUGMi0FWTJFlUZez37qCKaZ7gvo7YOawMoEMYeDiFICJLFNm+Kf7y+Xm/Z9tHxYe 3eLmudf/t9v7tpNRWVdjH21763tyiu8shn8qLydvm+N7zCBk2sFc1st35s+98F2xcJ7fpFM8U7Y Y3HjEBQA= X-Developer-Key: i=schnelle@linux.ibm.com; a=openpgp; fpr=9DB000B2D2752030A5F72DDCAFE43F15E8C26090 X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA3MDExMiBTYWx0ZWRfX3BnmexlpZn4U NXjEZRDwQkgq1QhDl/PQ4qehI2GvxSJZZZRe1xOxq1gQEoMsRMBkyXfC2bN0np3WMeWah4Isk3V Og3QOdU6tFDqFmlVsO1HpBFGOVaRUlu1dgax9h4YO33wssSIEti7KrmXKHeiKMrUVdE/UOfi9qQ RGY72VSG5+CkiKHGQ1qR0yxO0K+GaJYFOrUvKew8uG7wwa+akxIQPHASmF43DvmLBZcqcu8v4GW BKmyafA5/HqgBPM0XM0O4EFUSPO8VzSD6XgvE24oapgCOTvYiV4lsna09qRRUpfrYLYrsgbVW3r ydasgJVT8ygeut+5ySAy+pYeX/awUUtoFLbQiCQ6FFgizL44Kp4MMfFDKomu/8Hobep/g/zTvK2 cplFeWKJAOM8wHO3pAty7UuIE+Ah4eMDe9kL25wsPNezK2tdxCSci6AXeZMTfUoibUkVFSxh X-Proofpoint-GUID: nHya5UDH_yIJ-SbsMQKXdVfnF2JR6az_ X-Authority-Analysis: v=2.4 cv=PoCTbxM3 c=1 sm=1 tr=0 ts=6894b06a cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=VnNF1IyMAAAA:8 a=EcUHtpB8bGtrbQ9pWRIA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: aH0YwnQ8fdHLWD9sv5Vb-CVXmSlBKpSt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-07_02,2025-08-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 adultscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 impostorscore=0 mlxlogscore=880 mlxscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508070112 Issue uevents during PCI recovery using pci_uevent_ers() as done by EEH and AER PCIe recovery routines. Reviewed-by: Lukas Wunner Signed-off-by: Niklas Schnelle --- arch/s390/pci/pci_event.c | 3 +++ drivers/pci/pci-driver.c | 2 +- include/linux/pci.h | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/s390/pci/pci_event.c b/arch/s390/pci/pci_event.c index d930416d4c903f709764b75fe45fb66e529fcc5b..b95376041501f479eee20705d45= fb8c68553da71 100644 --- a/arch/s390/pci/pci_event.c +++ b/arch/s390/pci/pci_event.c @@ -88,6 +88,7 @@ static pci_ers_result_t zpci_event_notify_error_detected(= struct pci_dev *pdev, pci_ers_result_t ers_res =3D PCI_ERS_RESULT_DISCONNECT; =20 ers_res =3D driver->err_handler->error_detected(pdev, pdev->error_state); + pci_uevent_ers(pdev, ers_res); if (ers_result_indicates_abort(ers_res)) pr_info("%s: Automatic recovery failed after initial reporting\n", pci_n= ame(pdev)); else if (ers_res =3D=3D PCI_ERS_RESULT_NEED_RESET) @@ -244,6 +245,7 @@ static pci_ers_result_t zpci_event_attempt_error_recove= ry(struct pci_dev *pdev) ers_res =3D PCI_ERS_RESULT_RECOVERED; =20 if (ers_res !=3D PCI_ERS_RESULT_RECOVERED) { + pci_uevent_ers(pdev, PCI_ERS_RESULT_DISCONNECT); pr_err("%s: Automatic recovery failed; operator intervention is required= \n", pci_name(pdev)); status_str =3D "failed (driver can't recover)"; @@ -253,6 +255,7 @@ static pci_ers_result_t zpci_event_attempt_error_recove= ry(struct pci_dev *pdev) pr_info("%s: The device is ready to resume operations\n", pci_name(pdev)); if (driver->err_handler->resume) driver->err_handler->resume(pdev); + pci_uevent_ers(pdev, PCI_ERS_RESULT_RECOVERED); out_unlock: pci_dev_unlock(pdev); zpci_report_status(zdev, "recovery", status_str); diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index 94ba6938b7c6271b557cc7f17ffb89631d83827e..2f3037050fd011108ef93e39d2d= 78a5c7e22fd05 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -1578,7 +1578,7 @@ static int pci_uevent(const struct device *dev, struc= t kobj_uevent_env *env) return 0; } =20 -#if defined(CONFIG_PCIEAER) || defined(CONFIG_EEH) +#if defined(CONFIG_PCIEAER) || defined(CONFIG_EEH) || defined(CONFIG_S390) /** * pci_uevent_ers - emit a uevent during recovery path of PCI device * @pdev: PCI device undergoing error recovery diff --git a/include/linux/pci.h b/include/linux/pci.h index 05e68f35f39238f8b9ce08df97b384d1c1e89bbe..bcc412a21d93a6dcc566f011258= ed39d80d896c2 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -2737,7 +2737,7 @@ static inline bool pci_is_thunderbolt_attached(struct= pci_dev *pdev) return false; } =20 -#if defined(CONFIG_PCIEPORTBUS) || defined(CONFIG_EEH) +#if defined(CONFIG_PCIEPORTBUS) || defined(CONFIG_EEH) || defined(CONFIG_S= 390) void pci_uevent_ers(struct pci_dev *pdev, enum pci_ers_result err_type); #endif =20 --=20 2.48.1 From nobody Sun Oct 5 07:22:39 2025 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0F91262FEC; Thu, 7 Aug 2025 13:56:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754574965; cv=none; b=KY5lp2QmRJQEurqkof5ad3iNJ0Dfy1/1MufjGsaGuRRSZOpuqy2P/nBiepXe1T4W81QIzW1WNy8vGGU2T3sRbv2U+zkH5MB8x59p9E3dL6hqB2SFJd9U+wmhX8LcMa8VhU6eIhIExKUdpAVmhqwEAv2UC43MwGNbIhdBOMgyf4I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754574965; c=relaxed/simple; bh=mOG87tayZw5x3IBqjx1AAyFnN9RUxt9soJwUnbs0X6I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Tx/89AyaT9tVzwQo9rGuzk8XPrTKCwa+WJQ9MxdHCMJ3x731oPUnCgLLwdFGxzmcE6J6ciP+UV9vuo7dLazhAbSJHsKd+RPJFNAuOGvK7fajSlqD6W8AeqemdEYuteBcHRtfEatjpLrSDseSUeKUETla8sXI6x8jQ8y+TL2mvwA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=CyXgfXXv; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="CyXgfXXv" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5773uSAH019831; Thu, 7 Aug 2025 13:55:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=P6h6pE ygabob+MKMluPz2iaWqjq/rfYE+mrRUjaz2zM=; b=CyXgfXXvrSI39MIxCFgnqr vh4FTQ+YxOF5MUP1J+j/xiEAyN+3/7Pr2jXYx/qn5q36gi+DHr1Q6ONcIM0f/PDd D1SZYwNW6fJsEcaBZcXXLKH4P3f+nR+fjbchS8QlH9jbXWcgSjzaLJYFB+RK+rTj WOwXZsOLRSkHXnzOR4GxvdcMcw8bbAUITKeARKj2c7aprDnFbompLyiS/koy8Ppk nj9UqVirTMswX16qblRxiLxmSf4qM5GgGPoWSdPzKEJp3sGOOMVdAynXAVX8rlS2 bUbF5zYj9tPnm2qMFjIm6JUHkB+r8PG8FMWYdESbhkkoQ11Cc7O6Es+fE8BsNQow == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48c26tyv47-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 13:55:57 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 577DZujP010443; Thu, 7 Aug 2025 13:55:57 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48c26tyv43-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 13:55:57 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 577DRW5u022640; Thu, 7 Aug 2025 13:55:55 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 48bpwqgw40-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 13:55:55 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 577Dts6B11666480 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Aug 2025 13:55:54 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 54D7D5805A; Thu, 7 Aug 2025 13:55:54 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8993D58052; Thu, 7 Aug 2025 13:55:51 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 7 Aug 2025 13:55:51 +0000 (GMT) From: Niklas Schnelle Date: Thu, 07 Aug 2025 15:55:40 +0200 Subject: [PATCH v5 3/3] powerpc/eeh: Use result of error_detected() in uevent Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250807-add_err_uevents-v5-3-adf85b0620b0@linux.ibm.com> References: <20250807-add_err_uevents-v5-0-adf85b0620b0@linux.ibm.com> In-Reply-To: <20250807-add_err_uevents-v5-0-adf85b0620b0@linux.ibm.com> To: Bjorn Helgaas , Lukas Wunner , Mahesh J Salgaonkar Cc: Linas Vepstas , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Manivannan Sadhasivam , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Peter Oberparleiter , Matthew Rosato , "Oliver O'Halloran" , Sinan Kaya , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Niklas Schnelle , Keith Busch X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1301; i=schnelle@linux.ibm.com; h=from:subject:message-id; bh=mOG87tayZw5x3IBqjx1AAyFnN9RUxt9soJwUnbs0X6I=; b=owGbwMvMwCX2Wz534YHOJ2GMp9WSGDKmbIh1Xf15eSUry3F3oxLJStUlDkL2l8OCwo2dwqT5j vJquLN2lLIwiHExyIopsizqcvZbVzDFdE9QfwfMHFYmkCEMXJwCMJEbgQz/6182btbxe8CgHMrm svNxf9hE1RIp7ezuFTkGn5kLNi7PZGS41y4REPRnm/urK8UFQXaf72ye+/rza99An+6v4Y95Wxw ZAA== X-Developer-Key: i=schnelle@linux.ibm.com; a=openpgp; fpr=9DB000B2D2752030A5F72DDCAFE43F15E8C26090 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: YH0b8-6YXjdsqzw7jV_FMU1BENykmw9c X-Authority-Analysis: v=2.4 cv=F/xXdrhN c=1 sm=1 tr=0 ts=6894b06d cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=USTt9hxsF4_VS_TezIQA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: fQbQG1xr9EhhieZp8D-XY0qjJ3wzijgZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA3MDExMiBTYWx0ZWRfX/XXI7Fr1FvJY FOXThBrUUHzXjsk98nkr2a80J2h7wW/6Z7XWUTlp0cEOL4j+Zy49UU65Jrb+mXZoIo4m5p/8xxO Nrm7OlcUW3ahqemn/ryOEdRhyUV+1VxGMB2WWOzaba4A/V/UBtDzBVzijlu8Vi8IcWJcHUYfExE an9a156D2a+5kusq+clnieK9jxfWZD9Npe0SFNhvyEU/kS0++D4T1o4Od95b+b9sJPflrzd9Kkr vA9XYjtzjiTF+aeKxWHw6Lxc7Ntl+UUmCGdCZK6vFzd2FOWT3TEBmHUm8nuai3JAxa4K4PrEdzP 6GvPnjYFnA/4tJ2G0SN505iiY58F3y5QFBHEQ9DI+QRn6JHjpNKmbzLPIZUuNwl0I260Gy7QwLd k5FhPacQt+sqjS1y3GoGU6e1mkF2q7jx33J+4XZ+/o+0N9uHDBxfR1zfPSv+/EMui4d7kW2k X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-07_02,2025-08-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 spamscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508070112 Ever since uevent support was added for AER and EEH with commit 856e1eb9bdd4 ("PCI/AER: Add uevents in AER and EEH error/resume"), it reported PCI_ERS_RESULT_NONE as uevent when recovery begins. Commit 7b42d97e99d3 ("PCI/ERR: Always report current recovery status for udev") subsequently amended AER to report the actual return value of error_detected(). Make the same change to EEH to align it with AER and s390. Suggested-by: Lukas Wunner Link: https://lore.kernel.org/linux-pci/aIp6LiKJor9KLVpv@wunner.de/ Reviewed-by: Lukas Wunner Signed-off-by: Niklas Schnelle Acked-by: Mahesh Salgaonkar Reviewed-by: Kuppuswamy Sathyanarayanan --- arch/powerpc/kernel/eeh_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_dri= ver.c index 7efe04c68f0fe3fb1c3c13d97d58e79e47cf103b..20ed9685da8b7e6d419a4b02f71= 5b52acfe715d3 100644 --- a/arch/powerpc/kernel/eeh_driver.c +++ b/arch/powerpc/kernel/eeh_driver.c @@ -334,7 +334,7 @@ static enum pci_ers_result eeh_report_error(struct eeh_= dev *edev, rc =3D driver->err_handler->error_detected(pdev, pci_channel_io_frozen); =20 edev->in_error =3D true; - pci_uevent_ers(pdev, PCI_ERS_RESULT_NONE); + pci_uevent_ers(pdev, rc); return rc; } =20 --=20 2.48.1