From nobody Sun Oct 5 07:22:38 2025 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC5222185BD; Thu, 7 Aug 2025 10:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754561753; cv=none; b=iC6ClqnEkdtdduGo/pvaqKPgsayUPTklQK4NQFzloym8FDdw9eNG1QYbmMsF2EU1ntC1bihKDDwW2QJOkGx58EnmeCxfsBBex5WbkV8iTBb1kBfvAb9ZkoTmKm6cXxEJmdK6Vg17KNBZnPs4Kjn9D9Y6NZAHrtiE8tyZ1UFhSk8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754561753; c=relaxed/simple; bh=/TDoLoAhctmjAWMVE7SheYXDr42tTImW0wlVGjr8Rgc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gwRmuKoDOa+U+G6IQB2pl+1S6FdvtEYK67o7H/3UtFoqv7JLJbGnews5h8b56B25DFn/WL9PBTP8z3k1Qq1F7tM2fgXjyCCme/eL46guFx54GMYYgLHK8pTaT7X8+bEYKRGCPtTU6uFUDAYnBoHV9luOfMbk7+FFKusCEGGS4jY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=bgCJ1Hjo; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="bgCJ1Hjo" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5772qNPC029069; Thu, 7 Aug 2025 10:15:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=jkQ7QH 69gsRvGYUyPEqL7QOSe+6tJjj6DmYw3MwPqNE=; b=bgCJ1HjoIa2zta5pOUGj5q DLY7C/pk3g/gjgS98LddFu3iMWy2Yy5vih9vI1NmFa51aOae52nbLkjTidu792D4 +vpXTszBkqCj04D0KFiGmuLcIFnmDE1CU8b9g+bys7qUegTxtil8EjVjb9ts62Pg WaNdn9hq4ZzRxPqypnLClI/t0ZqhEhl95r44GlbnAze5pJn/sruQneSLxYUW6Ozu 47wH52VfshBeWD27ARb26lhatcEoJZaqL+1yovppxAxlFe8z4lxIMHfAlo2QHSHj VCm1DJMP4lQjJgvOGx87E1OY/5BkZaTePPG/RnhcUOiOCY7nu9uKhqZBGveSwwAQ == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48bq611jx3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 10:15:45 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 577ABARI017258; Thu, 7 Aug 2025 10:15:45 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48bq611jx2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 10:15:45 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5779PSu7001558; Thu, 7 Aug 2025 10:15:44 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 48bpwr030x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 10:15:44 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 577AFgV425494032 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Aug 2025 10:15:42 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 42F5E58059; Thu, 7 Aug 2025 10:15:42 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7108658043; Thu, 7 Aug 2025 10:15:39 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 7 Aug 2025 10:15:39 +0000 (GMT) From: Niklas Schnelle Date: Thu, 07 Aug 2025 12:15:31 +0200 Subject: [PATCH v4 1/3] PCI/AER: Fix missing uevent on recovery when a reset is requested Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250807-add_err_uevents-v4-1-c624bfd8638d@linux.ibm.com> References: <20250807-add_err_uevents-v4-0-c624bfd8638d@linux.ibm.com> In-Reply-To: <20250807-add_err_uevents-v4-0-c624bfd8638d@linux.ibm.com> To: Bjorn Helgaas , Lukas Wunner , Mahesh J Salgaonkar Cc: Linas Vepstas , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Manivannan Sadhasivam , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Peter Oberparleiter , Matthew Rosato , "Oliver O'Halloran" , Sinan Kaya , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Niklas Schnelle , Keith Busch X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1239; i=schnelle@linux.ibm.com; h=from:subject:message-id; bh=/TDoLoAhctmjAWMVE7SheYXDr42tTImW0wlVGjr8Rgc=; b=owGbwMvMwCX2Wz534YHOJ2GMp9WSGDKm1BwTXHKN8ecilk1Ljgh0r9oj/C9OTKL9Vs2PgJ+qf Cs6pnXKd5SyMIhxMciKKbIs6nL2W1cwxXRPUH8HzBxWJpAhDFycAjCRnHMM/4N45e/UaS1N27uu RuXUfTtpg1n96ibm5xWU7M0r6xT47jEybNq79EhDkn39v/WdP59E3fHn11j7aUPS1sOf+C5eati 1iwkA X-Developer-Key: i=schnelle@linux.ibm.com; a=openpgp; fpr=9DB000B2D2752030A5F72DDCAFE43F15E8C26090 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: ScFbWCvdM5rrP4JAOcis4XB4nj0jFN9u X-Proofpoint-ORIG-GUID: WdfDEOVBYRCHPH1U3f1hOPZDJuD8MBE_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA3MDA3OCBTYWx0ZWRfX+HqjXSvEImnK Mi9YLhzkvf7N/95t36d5h42mhINOBYe6WjF4ygafF4pY1IbKLkqb+IRe4b+CnJbn6fJ+4+jYgQe voJAdpTdOmkGpTCWhWkNoKKs5BAy/VAsOnZP+0uO3EhhjoBvF2b2STNZMHL0TT5QhwmtKahVmGX E1+WzE72ErEYQoo9y9GfRv4oPbGgClPJU7WB9xYYj+XEyqOV8bhl/8Cuzk/9u8jIAN87EPK4+g6 972MnGOULJDzXeb+Wq1MRlHHqcMxv0V62Ow84no3ZpHBJ8VLcISkCzvHA5us87ebxwnjbYqB+fG 5yGcIWPix82QoQFAVSlnWBO8JOToGH+Hv8yKBDAFPcynkWj7N/PBncN0scqAkOsPr3gOV9XhT6K yxO60xFzPvhPZkJ2BSER0gqUleAOmVgucvu6HPatWXXqW6Crk37HAOoGThQtUjV+sxADrPwP X-Authority-Analysis: v=2.4 cv=TayWtQQh c=1 sm=1 tr=0 ts=68947cd1 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=Tbr2KL6GNvhcKcAIiBYA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-07_01,2025-08-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 phishscore=0 impostorscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508070078 Since commit 7b42d97e99d3 ("PCI/ERR: Always report current recovery status for udev") AER uses the result of error_detected() as parameter to pci_uevent_ers(). As pci_uevent_ers() however does not handle PCI_ERS_RESULT_NEED_RESET this results in a missing uevent for the beginning of recovery if drivers request a reset. Fix this by treating PCI_ERS_RESULT_NEED_RESET as beginning recovery. Cc: stable@vger.kernel.org Fixes: 7b42d97e99d3 ("PCI/ERR: Always report current recovery status for ud= ev") Reviewed-by: Lukas Wunner Signed-off-by: Niklas Schnelle --- drivers/pci/pci-driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index 67db34fd10ee7101baeeaae1bb9bec3b13e2fdeb..94ba6938b7c6271b557cc7f17ff= b89631d83827e 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -1592,6 +1592,7 @@ void pci_uevent_ers(struct pci_dev *pdev, enum pci_er= s_result err_type) switch (err_type) { case PCI_ERS_RESULT_NONE: case PCI_ERS_RESULT_CAN_RECOVER: + case PCI_ERS_RESULT_NEED_RESET: envp[idx++] =3D "ERROR_EVENT=3DBEGIN_RECOVERY"; envp[idx++] =3D "DEVICE_ONLINE=3D0"; break; --=20 2.48.1 From nobody Sun Oct 5 07:22:38 2025 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAF22263F36; Thu, 7 Aug 2025 10:15:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754561755; cv=none; b=PssiCsXdGpunIQzP6rEJ/2rfrFJ0OUUM+4qRBvLDFdfQbo7tXFarfR5YdOA1dvBVIfrvLJPBz6ACpWeOGMDtHyhcPwkfA3hGxdjar85ganil7Lg0b4qlEka/bFTHcjYEwcnT1yB2mrNsBUHac+h3J2uAFbaWz08DvyQP7ZgXvUs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754561755; c=relaxed/simple; bh=h+ehO7sHf6gk7yXI2DZUqbMMTOqnPJU0Ks5nnomA7LY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S3XaE/2+yyZT6IjdcfSxM+JwMV1L98XKidp0ueHKgjsV+VSLzJmtlxnWkVZQDqLn47DajOz6wbKkqbaGDUGaQeTkWcNjbY+TCjIAVH/JvIhtxTMJ9G/qVqc6XT6aprhrEvwfRz48KbaHQiLbObfQMo5ciIqf4LAg5EinanAczvE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=iaqV/8Np; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="iaqV/8Np" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5778t4Av021583; Thu, 7 Aug 2025 10:15:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=STgXJS QZlvL9W8pyTNY4ql5iGZFkKX6A7jVujHu1LSs=; b=iaqV/8NpjLe5ojCkH0/ZM1 zMJLPAWZXHf5PEqeejWcYQdz9N8rfBiBrg6z/cKjSohwMToaXaxOS9/UVgNpencz udJQOZBt7V3bbeRQmRWO/OLFa9W9GHEkE6Z1YPl204MwMZy4HPQBDin0l6LTlVGC ri9oLIcdvfc3iORWMylgdAO84qC2W7cmxtaRzsrCRTkRqSBgRqWfN3jgQhARpNvh Ev0zn7Z50pXoHqJg0fCrgZoPY0niuf5WzQaYa+ePkWLPxOZ2Prjm4MKmXI1ngTGy /AgHM1AlQ9UjikstpRyXyNIA+p8FC+qJnx/PwvrOEnW2fAtCJO7Kd2YFUyUMMyCA == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48bq621f8n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 10:15:48 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 577AFlEb000363; Thu, 7 Aug 2025 10:15:47 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48bq621f8m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 10:15:47 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5779rrh9001514; Thu, 7 Aug 2025 10:15:46 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 48bpwr0310-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 10:15:46 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 577AFjGF26149548 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Aug 2025 10:15:45 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4F13258055; Thu, 7 Aug 2025 10:15:45 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7D7035805D; Thu, 7 Aug 2025 10:15:42 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 7 Aug 2025 10:15:42 +0000 (GMT) From: Niklas Schnelle Date: Thu, 07 Aug 2025 12:15:32 +0200 Subject: [PATCH v4 2/3] powerpc/eeh: Use result of error_detected() in uevent Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250807-add_err_uevents-v4-2-c624bfd8638d@linux.ibm.com> References: <20250807-add_err_uevents-v4-0-c624bfd8638d@linux.ibm.com> In-Reply-To: <20250807-add_err_uevents-v4-0-c624bfd8638d@linux.ibm.com> To: Bjorn Helgaas , Lukas Wunner , Mahesh J Salgaonkar Cc: Linas Vepstas , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Manivannan Sadhasivam , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Peter Oberparleiter , Matthew Rosato , "Oliver O'Halloran" , Sinan Kaya , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Niklas Schnelle , Keith Busch X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1029; i=schnelle@linux.ibm.com; h=from:subject:message-id; bh=h+ehO7sHf6gk7yXI2DZUqbMMTOqnPJU0Ks5nnomA7LY=; b=owGbwMvMwCX2Wz534YHOJ2GMp9WSGDKm1BzznHG0OPLenQdzTpgvi2rjMp95+EPLD6mcPdPLe 7plH/6621HKwiDGxSArpsiyqMvZb13BFNM9Qf0dMHNYmUCGMHBxCsBEpDMZGXofsJtvutqcdGTd vVPT/ld+nBnWavh1n8X++ZuikoQ/TJVjZJjgYHd7d8yehZ7NExQfxjvrzci//+1qgUb7jyCNb7Y CD3gB X-Developer-Key: i=schnelle@linux.ibm.com; a=openpgp; fpr=9DB000B2D2752030A5F72DDCAFE43F15E8C26090 X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA3MDA3OCBTYWx0ZWRfXze0Jyb1EKTeu TosXHTnDa2F2gQwfjUH3RDhkQ3b1KwjyN39T/d3o8Z8nAsZpRaM3RsrkwcHHR3yCv6h9sjdqTDy 6IaIUDtiwrPoXfLQge6DN5959ypomW/8MuF4aiooorFxAD2XjKJPl19O1CjZyvTQeEz0PE7SUpb AWcHW3Tbp8q9urezeLnIm/e9SZ0xNMf8pvSo4y0hCopwh2IO5MSZbO2TCdpXGFdoLI0PPJz83po Zn1Wzv/UIOroKaPE7KVE5zy1ihEd9Pnrz/vf1aldLJwWoOpQs5xOj6WLYxn81/PURp4q1J5Dwip k7TyMZ3ngIQjoOzVnT7ij0AVdsjsBEmrrolet/f7FTakMAFp4elcIDb7NpTefBVEbIzkIxDZ8D4 ZDSC3ABX04+gwdYCd67VMyzv7lpCghcoXu478AqOA5gFegbc7ig+qNaVoelGcp0tghAPHvZ/ X-Proofpoint-GUID: wv-wTNnGwJw3sZ_4IVq31Zp0tPe5Y7R3 X-Authority-Analysis: v=2.4 cv=BIuzrEQG c=1 sm=1 tr=0 ts=68947cd4 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=NEBNNiDPVXfdxOcwRW8A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: X0gJ0lqHEGcyjreeQWvUNloxKwWRPS-D X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-07_01,2025-08-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 spamscore=0 mlxlogscore=961 adultscore=0 clxscore=1015 malwarescore=0 phishscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508070078 With pci_uevent_ers() handling PCI_ERS_RESULT_NEED_RESET the result of error_detected() can be used in pci_uevent_ers() even if drivers request a reset. This aligns EEH's behavior with both AER. Suggested-by: Lukas Wunner Link: https://lore.kernel.org/linux-pci/aIp6LiKJor9KLVpv@wunner.de/ Signed-off-by: Niklas Schnelle Reviewed-by: Lukas Wunner --- arch/powerpc/kernel/eeh_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_dri= ver.c index 7efe04c68f0fe3fb1c3c13d97d58e79e47cf103b..20ed9685da8b7e6d419a4b02f71= 5b52acfe715d3 100644 --- a/arch/powerpc/kernel/eeh_driver.c +++ b/arch/powerpc/kernel/eeh_driver.c @@ -334,7 +334,7 @@ static enum pci_ers_result eeh_report_error(struct eeh_= dev *edev, rc =3D driver->err_handler->error_detected(pdev, pci_channel_io_frozen); =20 edev->in_error =3D true; - pci_uevent_ers(pdev, PCI_ERS_RESULT_NONE); + pci_uevent_ers(pdev, rc); return rc; } =20 --=20 2.48.1 From nobody Sun Oct 5 07:22:38 2025 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFE2626B77A; Thu, 7 Aug 2025 10:15:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754561758; cv=none; b=aB8AN/+SKypLlroFswOjkSo+exo0TRygJ+fJbQQTssdzD//6zOSSSIbs/rkeM4ueSkAXgxD5DheFB1I0dIdjm+nvd2TNuGIDJbDU5ooxR4gfsyXTIzyAu5i6MxhJYmFupfgoz/x7BgZf04sV4hdZyuu3U1ifes6g0R9R2eVYDH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754561758; c=relaxed/simple; bh=052dvgQxomwEVj6h89TauZrrC59BaSmnJfbTE7aDz2E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sMZV5of+IQjoz/yxWjIqchL40uT6LallXi9y+0PsdOto7bEM4xIx4RPYJ11FFTo2Up69ytFnsPBuf/7HA9MAMyAZrZy+BmsPGe9ie7cCYpRyywvFFA40mqnuJ5xroz8ENqIlLokq6V1BazKhYXTxccWJaiBnbe+bbQbZjPaso04= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=mtJpoJko; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="mtJpoJko" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5774SKaX021814; Thu, 7 Aug 2025 10:15:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=dnzNl6 nzTzRC5x2v/gK2+9RF29p0evKhXuLll1Ad/j8=; b=mtJpoJkoz0pccBMwPLimVf vQrCWLoJx4eCCsW/ecKGzzdNAAMLTqILZy6/9Z2DDJL20AwFEQ8ZmuXwhMwtiLXo N0Ut7No8ZE9idni++zi7+aPtODvjkANx8ea7fsWLeCcG7VcvmRWHqzF7wliBW9qS AnKAUgxGhnzXN53tKSvki2XO0cErDfDy3Wn7sg8hHyMFSha4qG1TLQRyXeRYyXuM iDfjXdborSyKSXHRe8thfRoKBdhdWhkTzM2nSQ13Hw2sFZn4+XhF2eTBiTaachb7 WQ1HKP8uWQBRYgjwlKBbBqPsiHxsmurMCivhZart+NPukZHMw9rGJyhSjVAU6dLw == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48bq621f8x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 10:15:51 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 577A3975007797; Thu, 7 Aug 2025 10:15:51 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 48bq621f8u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 10:15:51 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5779NGFE001574; Thu, 7 Aug 2025 10:15:50 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 48bpwr0313-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Aug 2025 10:15:50 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 577AFmAc33816898 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Aug 2025 10:15:48 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 590E25805F; Thu, 7 Aug 2025 10:15:48 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8953C5805D; Thu, 7 Aug 2025 10:15:45 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 7 Aug 2025 10:15:45 +0000 (GMT) From: Niklas Schnelle Date: Thu, 07 Aug 2025 12:15:33 +0200 Subject: [PATCH v4 3/3] PCI/ERR: s390/pci: Use pci_uevent_ers() in PCI recovery Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250807-add_err_uevents-v4-3-c624bfd8638d@linux.ibm.com> References: <20250807-add_err_uevents-v4-0-c624bfd8638d@linux.ibm.com> In-Reply-To: <20250807-add_err_uevents-v4-0-c624bfd8638d@linux.ibm.com> To: Bjorn Helgaas , Lukas Wunner , Mahesh J Salgaonkar Cc: Linas Vepstas , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Manivannan Sadhasivam , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Peter Oberparleiter , Matthew Rosato , "Oliver O'Halloran" , Sinan Kaya , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Niklas Schnelle , Keith Busch X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3021; i=schnelle@linux.ibm.com; h=from:subject:message-id; bh=052dvgQxomwEVj6h89TauZrrC59BaSmnJfbTE7aDz2E=; b=owGbwMvMwCX2Wz534YHOJ2GMp9WSGDKm1By/cFtlmbN1TUPRJlepYFY2n1cLxBJyZQ5fd1Tm8 fx0KK+no5SFQYyLQVZMkWVRl7PfuoIppnuC+jtg5rAygQxh4OIUgIloXmNkmDbl/Z2ctoMbZ9wv 15BuOpP6RlP99k17Z6/gpLdntprslWdk+OjbLdTeHnxw9tUpzZfbqgNuq9sqNZlNmrFwwYy4La7 mjAA= X-Developer-Key: i=schnelle@linux.ibm.com; a=openpgp; fpr=9DB000B2D2752030A5F72DDCAFE43F15E8C26090 X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODA3MDA3OCBTYWx0ZWRfX+27U2wADsz1W YquXhSiYn/oBIcQlJbNlOGBUH0vtGym0pIgi5B9A5KKOmFJv7XlV5cQ5WJrjlrCDuI1PvQMvyKn N3GqrS+Li0iNmzitG6pVVVoZUparEOtzKUiMB15mksGSnLRS4x/3xIUWD9dep2IOoomGn/MPbaX sFwKKJOZ+fRAjM/E6F07tbYnaP4XWU/4g5Z8sqWvI2RXRoaGqeeagKU3SDKSKACSuU02pyrdXw+ 6GXCPRnRxyOmeOUuEUk80wj+ONMufCD2ezq8Y6G4KUlA3yckHUL4ak8AHzRD6KR9H/jixDHrqWp T1f3yBEKMa2zBaQTd6WD7tmgYPCJfurudyw/qESI74CoGnoffL+P8xb9F7YdlhuI5UbBnIa8zcG ZQ+00cC65S6MimsyviWyWlaVPkGBK9OitUc7uHJwZpO4TYTkFH0rozJ1Rl9Sf/fzHnZzTDfd X-Proofpoint-GUID: AMl1tp86nZ0KQEfb6P8pkRN6DWCF8U4d X-Authority-Analysis: v=2.4 cv=BIuzrEQG c=1 sm=1 tr=0 ts=68947cd7 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=VnNF1IyMAAAA:8 a=EcUHtpB8bGtrbQ9pWRIA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: 3teTrK-OTX_SCh1T-b9Gyk7MeZkxbvFM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-07_01,2025-08-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 spamscore=0 mlxlogscore=880 adultscore=0 clxscore=1015 malwarescore=0 phishscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508070078 Issue uevents during PCI recovery using pci_uevent_ers() as done by EEH and AER PCIe recovery routines. Reviewed-by: Lukas Wunner Signed-off-by: Niklas Schnelle --- arch/s390/pci/pci_event.c | 3 +++ drivers/pci/pci-driver.c | 2 +- include/linux/pci.h | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/s390/pci/pci_event.c b/arch/s390/pci/pci_event.c index d930416d4c903f709764b75fe45fb66e529fcc5b..b95376041501f479eee20705d45= fb8c68553da71 100644 --- a/arch/s390/pci/pci_event.c +++ b/arch/s390/pci/pci_event.c @@ -88,6 +88,7 @@ static pci_ers_result_t zpci_event_notify_error_detected(= struct pci_dev *pdev, pci_ers_result_t ers_res =3D PCI_ERS_RESULT_DISCONNECT; =20 ers_res =3D driver->err_handler->error_detected(pdev, pdev->error_state); + pci_uevent_ers(pdev, ers_res); if (ers_result_indicates_abort(ers_res)) pr_info("%s: Automatic recovery failed after initial reporting\n", pci_n= ame(pdev)); else if (ers_res =3D=3D PCI_ERS_RESULT_NEED_RESET) @@ -244,6 +245,7 @@ static pci_ers_result_t zpci_event_attempt_error_recove= ry(struct pci_dev *pdev) ers_res =3D PCI_ERS_RESULT_RECOVERED; =20 if (ers_res !=3D PCI_ERS_RESULT_RECOVERED) { + pci_uevent_ers(pdev, PCI_ERS_RESULT_DISCONNECT); pr_err("%s: Automatic recovery failed; operator intervention is required= \n", pci_name(pdev)); status_str =3D "failed (driver can't recover)"; @@ -253,6 +255,7 @@ static pci_ers_result_t zpci_event_attempt_error_recove= ry(struct pci_dev *pdev) pr_info("%s: The device is ready to resume operations\n", pci_name(pdev)); if (driver->err_handler->resume) driver->err_handler->resume(pdev); + pci_uevent_ers(pdev, PCI_ERS_RESULT_RECOVERED); out_unlock: pci_dev_unlock(pdev); zpci_report_status(zdev, "recovery", status_str); diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index 94ba6938b7c6271b557cc7f17ffb89631d83827e..2f3037050fd011108ef93e39d2d= 78a5c7e22fd05 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -1578,7 +1578,7 @@ static int pci_uevent(const struct device *dev, struc= t kobj_uevent_env *env) return 0; } =20 -#if defined(CONFIG_PCIEAER) || defined(CONFIG_EEH) +#if defined(CONFIG_PCIEAER) || defined(CONFIG_EEH) || defined(CONFIG_S390) /** * pci_uevent_ers - emit a uevent during recovery path of PCI device * @pdev: PCI device undergoing error recovery diff --git a/include/linux/pci.h b/include/linux/pci.h index 05e68f35f39238f8b9ce08df97b384d1c1e89bbe..bcc412a21d93a6dcc566f011258= ed39d80d896c2 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -2737,7 +2737,7 @@ static inline bool pci_is_thunderbolt_attached(struct= pci_dev *pdev) return false; } =20 -#if defined(CONFIG_PCIEPORTBUS) || defined(CONFIG_EEH) +#if defined(CONFIG_PCIEPORTBUS) || defined(CONFIG_EEH) || defined(CONFIG_S= 390) void pci_uevent_ers(struct pci_dev *pdev, enum pci_ers_result err_type); #endif =20 --=20 2.48.1