From nobody Sun Oct 5 07:26:08 2025 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 880B82BEC5C; Wed, 6 Aug 2025 20:10:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754511029; cv=none; b=SKGSQ1cyC0kyRTmb969yDTIFAwMTrA/alxUVNBLG4Epr2FL5+PzpZU3Y2z0VsdPerJJLXFKXYg0PmH5uLjUE8X1xkOqcAiYH4ReSiWIS7scXNevkXv8iWdT3Wyx067O7lOCBNcN/zH0DTDOAlZCcODDIMUUBURAAutw991yTjug= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754511029; c=relaxed/simple; bh=2ufBNWYs+35cWUzKeUrvzmdJhWrAueP76qfzYop9QD8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LolPOkpzOjgTDfmPuAnEXYAt80shT942W+78YsDfHtCE3Odp2BojB2eLFqCZk5vXsmiqYzZxiOYsKIIsGhzC263opXO/F01wY8J2lqmViq7pPUBl3UtNiQT3y59C1AqLpSikYXhaVqiFsNCKNrSC5xHyQpriaJh+gtffdiULH94= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lqRAv6Aa; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lqRAv6Aa" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-76bd6e84eddso433434b3a.0; Wed, 06 Aug 2025 13:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754511027; x=1755115827; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ydmjZ9RYLGtHRppDnONJgSJ5hx+juWz9zVI4g4InwYI=; b=lqRAv6Aa1r33fG+je8MwZig5jJuteScXMntzkmV0mi4eHdJK0B1zeWJ/4yuQf5Jama hWXlh7PWrihk0lV1FO4cg/KzqkYffL59LW+brDXNhjCw7eleXY0aBX5tZX6MYOcaOFPq vkE5vNN1jt7CFgG6CAFbLsGbO+dZ6Q7Itr/Q01ljXCRB+pKXnC43SMNHB9ihb/oAtsVp 1aGePah9V6ITsnTHxcseu5Uy3rcX6pE96MxKs4U1c09O6iyNw4fvHckinwnTITabPikx v+FqOCkxacvGZykUDHfttSnyCcOkD9Pg3DffbNEKM5+4klI/y38AVk+lZFE/2Om0y+db CHpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754511027; x=1755115827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ydmjZ9RYLGtHRppDnONJgSJ5hx+juWz9zVI4g4InwYI=; b=Ty3Y9S61FCorbUDhHLNKRSivqGe0Ue+x4h9tAFivNrZpW8ZenSjqn17fWvgtOLhEWF n6yJqgGstPUqumxduUIGBQ5dG9GtajNNu+Hgb6iqKeIavpD2jg7anSAHDRPWgJBiSFxJ 08gbdTnzX1ihhUMu+Z7LX+fheXvlpQwOFK4U8dK08K4kOEt+4AniFmfoiA3QulcLNFGm 5qtpdte5EAhul6AIQluOCiLDpGbbVd0JMzfg15XO++Ow/x9nD7rBtBSoapVyNQ0Tbfsd mCFbBt/DcxPsWdy0/wAD0+fyB90YW+SJiUy/x6QP6PDr++ho1bjAEkC8qFsk2o2peb4B AIwg== X-Forwarded-Encrypted: i=1; AJvYcCW36nU8lgi1YejmdAuakFJkuENPbZFxO6XixBoquTtxWHWfP0RXH4B4EEzRiWvqrq9ogATXKN1YYzRdzS+A@vger.kernel.org, AJvYcCWKZgerUo0vVDM7kH5x/3w25FmC6vCkur1kK7VEludZGfZcR5ZOglCl7WSNhhiwJHpKZm2o9dHqrz7hYYc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl/+tW1O+WrF2hYXHY6wB1zSIqjwiXJyh0tzyLMmmW1PM6d8rH fU30ir+/Ird4p6tqiTybG7NmJ73oWVqFNvOAEXV1d0YGoOSNJofA8DkS X-Gm-Gg: ASbGnculHiLRirnC5vgSFZbQoXBPB5afb2FtzusuW5PztmHRh332HNdG7aNMGEy+Ee/ mJOWh9KdNt+gYfqx36N5vpgaYroCMGBkef10wYksQZjL2vayXRw7Puts+n9TJKjRsgx8sc9yjxf hXC8ZAm03prgmfUrSRuQ9/Y+0g1SghjuynVYoU4QshqbgcZSC2bGDGr6YT5zz7jOgOgMowjThZ+ LQtyS0mydzveIct5QBkkX0hf8gCnO3VoHQqI7KPsNg+DqV18EBfqfXTQ9XnHpJXnQevq/zI+BJv 2DxL7TELoPRQxBAgGLn63d71YGhI4gC0FY+VrjyuGPnf7zU4p3ArJvF90Ubjt52Lsoe9y28Semj wUelp/wOjHS0OBsFdqGP9MLh7tjfvMsxx X-Google-Smtp-Source: AGHT+IFa+LT4nT8mGbefXIhRnJ0TvHsxP7minFFuDUw99xXbGKJ1oPCY8nNOYpFPwK2H1DyKzXPnoA== X-Received: by 2002:a05:6a20:42a3:b0:238:3f64:41a4 with SMTP id adf61e73a8af0-24031453fcamr6185329637.44.1754511026524; Wed, 06 Aug 2025 13:10:26 -0700 (PDT) Received: from avinash ([2406:8800:9014:d938:f647:9d6a:9509:bc41]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76c397b87d5sm38882b3a.96.2025.08.06.13.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Aug 2025 13:10:26 -0700 (PDT) From: Abinash Singh To: andriy.shevchenko@linux.intel.com Cc: abinashsinghlalotra@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, jirislaby@kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, sunilvl@ventanamicro.com, u.kleine-koenig@baylibre.com Subject: [PATCH v2 1/2] serial: 8250_platform: Reduce stack usage in serial8250_probe_acpi() Date: Thu, 7 Aug 2025 01:40:46 +0530 Message-ID: <20250806201047.754240-2-abinashsinghlalotra@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250806201047.754240-1-abinashsinghlalotra@gmail.com> References: <20250806201047.754240-1-abinashsinghlalotra@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The function serial8250_probe_acpi() in 8250_platform.c triggered a frame size warning: drivers/tty/serial/8250/8250_platform.c: In function =E2=80=98serial8250_pr= obe_acpi=E2=80=99: drivers/tty/serial/8250/8250_platform.c:152:1: warning: the frame size of 1= 160 bytes is larger than 1024 bytes [-Wframe-larger-than=3D] This patch reduces the stack usage by dynamically allocating the `uart` structure using kzalloc(), rather than placing it on the stack. This eliminates the overflow warning and improves kernel robustness. Signed-off-by: Abinash Singh --- drivers/tty/serial/8250/8250_platform.c | 26 ++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/tty/serial/8250/8250_platform.c b/drivers/tty/serial/8= 250/8250_platform.c index c0343bfb8064..50cec2413aeb 100644 --- a/drivers/tty/serial/8250/8250_platform.c +++ b/drivers/tty/serial/8250/8250_platform.c @@ -10,6 +10,7 @@ */ #include #include +#include #include #include #include @@ -110,9 +111,12 @@ void __init serial8250_isa_init_ports(void) static int serial8250_probe_acpi(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - struct uart_8250_port uart =3D { }; struct resource *regs; int ret, line; + struct uart_8250_port *uart __free(kfree) =3D kzalloc(sizeof(*uart), GFP_= KERNEL); + + if (!uart) + return -ENOMEM; =20 regs =3D platform_get_mem_or_io(pdev, 0); if (!regs) @@ -120,31 +124,31 @@ static int serial8250_probe_acpi(struct platform_devi= ce *pdev) =20 switch (resource_type(regs)) { case IORESOURCE_IO: - uart.port.iobase =3D regs->start; + uart->port.iobase =3D regs->start; break; case IORESOURCE_MEM: - uart.port.mapbase =3D regs->start; - uart.port.mapsize =3D resource_size(regs); - uart.port.flags =3D UPF_IOREMAP; + uart->port.mapbase =3D regs->start; + uart->port.mapsize =3D resource_size(regs); + uart->port.flags =3D UPF_IOREMAP; break; default: return -EINVAL; } =20 /* default clock frequency */ - uart.port.uartclk =3D 1843200; - uart.port.type =3D PORT_16550A; - uart.port.dev =3D &pdev->dev; - uart.port.flags |=3D UPF_SKIP_TEST | UPF_BOOT_AUTOCONF; + uart->port.uartclk =3D 1843200; + uart->port.type =3D PORT_16550A; + uart->port.dev =3D &pdev->dev; + uart->port.flags |=3D UPF_SKIP_TEST | UPF_BOOT_AUTOCONF; =20 - ret =3D uart_read_and_validate_port_properties(&uart.port); + ret =3D uart_read_and_validate_port_properties(&uart->port); /* no interrupt -> fall back to polling */ if (ret =3D=3D -ENXIO) ret =3D 0; if (ret) return ret; =20 - line =3D serial8250_register_8250_port(&uart); + line =3D serial8250_register_8250_port(uart); if (line < 0) return line; =20 --=20 2.50.1 From nobody Sun Oct 5 07:26:08 2025 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 123D32D0C60; Wed, 6 Aug 2025 20:10:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754511037; cv=none; b=kxeKogF7S4U3KKvztRZiZTlDXNvuZ13LFGxEthsrL24l2QNTOMYNBg3GxmQRQe/wyor7H8spcnCvDVj0uXFywhymuAuWBFMUHOdz9jqQdNsoZpl53RmThnpP1i2HkzDpl/puMhdyWKGgHjYYrTdyN7UjyQwqPFNvHSWYjhofnBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754511037; c=relaxed/simple; bh=CsiX3LpbUBnihaw/xRlWgknthecZaoYlBgQAkUpiN98=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kXuCGeFvFbHOQqIkXuwpdcha2CRq9oUnY71CvZRZABQ9NRMqxtswaw2xE7f5FLIlBJhss2rGOnvlWDWFgXa51UK4ZbywtnM0w7UnHz99TwXllmZdZO6uQlc6P+nCsECQnbGo2IiiOXhn8ODPFH+q7lhZDj7nqvPGjuSPArA2z+g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VpBPQYaB; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VpBPQYaB" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-76bc55f6612so315717b3a.0; Wed, 06 Aug 2025 13:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754511035; x=1755115835; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vucDMCt9anlq6y49qlrTW01EnOmxreRERlAc3t5nE5s=; b=VpBPQYaBSxtFjrPrSBPhgKUTsEgp3X9fYTKI7ypTRPsrPEAQuhjkWlf/LNFcjFY8T8 lUziqfyf31/AyzOJXjlcHD28EvY8qBTO+ZE3p4PFUEDqw8IK7p5udU6LPSdr0w7VPowi +69fz15pi62eLvgjHmMf/qHZBDLmXA/Fsf7QYY7nvyZqa1cAmCOH88OzOOvTg9SyEjhH PFxTpN6ShHwWIZNGeJAegY2nnH6DZvsu2EqB8kbrYzPc0HNv/lXSbqWVla+EzbAfGn5q F7KQqLzIPyZDTmXKEouKFibxfgBoigpK4w+z+3cVA0mf2LA+cajJjUeNXgRNfB6Bz017 STow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754511035; x=1755115835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vucDMCt9anlq6y49qlrTW01EnOmxreRERlAc3t5nE5s=; b=waJdEwDsLXb7vSWKNcqQqK9KmATttMs0CPcE4lhfwLbnt11F7nnDRN6PzVlVIprS/L h5vRomAAgMEcoCFjfEa0r//hW3JHSI2A2dSy7OSDgpnq2ApJN9kxzjnTd12dmeRB73Ga 76ItsUeTjF98txc/HZsoEFOTFG+gtiOe3AlsrBTffzFmvR1GZXlp4Kv0Qdg53uGuDT8k xuz9m2yU8KlM97TugkTU03Tig3MF3p/6EOSeJX9OSmsDPZ7lHgyaH6IPpwB05w+dXqHo wnGEIyQxiXCeETJ6baUva/yCa3Tr7ve1x+g5ucOEKep0kdEYdSxu5nwMab9ri0+sP9tK kjcw== X-Forwarded-Encrypted: i=1; AJvYcCUeA9VWu3OomZTW6Iu6TGzzLjTf+aaotLOhjZE404vyGPuMmbPuon/5pf94ejw+xdCAW0tWRW8i07gYF/z+@vger.kernel.org, AJvYcCV1g0sfsMa7iJhcCJc7q4tO58yUkmmsboY/c9n18P1bdY2sEMBOWBff3Evgm1+L56TpQZBMLFqHTuvn6PM=@vger.kernel.org X-Gm-Message-State: AOJu0YyO6+HsQk/hfCs8I1gHFG+ermdgRb4t0Pntqvrt7TAK/WKuNGPI SaBs7JLs50fFbe8BxBNjHUuEWez4wAV6TP4FLVMtS99wq/O271cB/Yid X-Gm-Gg: ASbGncsWkoKbg71o5QKzUup2i85X155jQrPDompKMsL7xhMyESN0Me08PAabjCyIrTp fwqPgVeVe1pvyAXjc2oqXstlgzYMqgDvwz9SRVh0S0fpxySRjlJOQ5PmMEMxMIMnboHbO4XdBxE 7gEl0G3eywA22kpG2PBLSHgyzUaX4p4NF7WDEJce3TL1QonJZJ1ONXlnqDaEtrm3uBdeQhmwClg XMw6aPjWoWSBjU9Se3fMtIHH8AhCBPfmAyUzMsGQdEXvO1+YVW0TccaPl7ElhVNsMa7kK0Ag3uT oDZOJ5QsiDo8LHD9aYR/dDMhe+UsyIxDusfWE0UEpfEWjoxahoAtzd2uE5EnG5evpUv2PPQV5fY H11/EvCfS/eqBbOoCTfv8bfUjN2NJIaCMDzWEAMjRFLk= X-Google-Smtp-Source: AGHT+IFbR83uHiKT31m9Kk4PEXh0UA57R0vzVHjqcNFGdj8vzgKpGIwLn4vsIZVbCuMILZ7cjMnFIw== X-Received: by 2002:a05:6a00:8590:b0:746:25d1:b712 with SMTP id d2e1a72fcca58-76c372e2c76mr1053974b3a.7.1754511035327; Wed, 06 Aug 2025 13:10:35 -0700 (PDT) Received: from avinash ([2406:8800:9014:d938:f647:9d6a:9509:bc41]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76c397b87d5sm38882b3a.96.2025.08.06.13.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Aug 2025 13:10:34 -0700 (PDT) From: Abinash Singh To: andriy.shevchenko@linux.intel.com Cc: abinashsinghlalotra@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org, jirislaby@kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, sunilvl@ventanamicro.com, u.kleine-koenig@baylibre.com Subject: [PATCH v2 2/2] serial: 8250_platform: Reduce stack usage in serial8250_probe_platform() Date: Thu, 7 Aug 2025 01:40:47 +0530 Message-ID: <20250806201047.754240-3-abinashsinghlalotra@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250806201047.754240-1-abinashsinghlalotra@gmail.com> References: <20250806201047.754240-1-abinashsinghlalotra@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The function serial8250_probe_platform() in 8250_platform.c triggered a frame size warning: drivers/tty/serial/8250/8250_platform.c: In function =E2=80=98serial8250_pr= obe_platform.isra=E2=80=99: drivers/tty/serial/8250/8250_platform.c:201:1: warning: the frame size of 1= 184 bytes is larger than 1024 bytes [-Wframe-larger-than=3D] This patch reduces the stack usage by dynamically allocating the `uart` structure using kzalloc(), rather than placing it on the stack. This eliminates the overflow warning and improves kernel robustness. Signed-off-by: Abinash Singh --- drivers/tty/serial/8250/8250_platform.c | 61 +++++++++++++------------ 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/drivers/tty/serial/8250/8250_platform.c b/drivers/tty/serial/8= 250/8250_platform.c index 50cec2413aeb..0baedc7ff6e9 100644 --- a/drivers/tty/serial/8250/8250_platform.c +++ b/drivers/tty/serial/8250/8250_platform.c @@ -157,43 +157,44 @@ static int serial8250_probe_acpi(struct platform_devi= ce *pdev) =20 static int serial8250_probe_platform(struct platform_device *dev, struct p= lat_serial8250_port *p) { - struct uart_8250_port uart; int ret, i, irqflag =3D 0; + struct uart_8250_port *uart =3D kzalloc(sizeof(*uart), GFP_KERNEL); =20 - memset(&uart, 0, sizeof(uart)); + if (!uart) + return -ENOMEM; =20 if (share_irqs) irqflag =3D IRQF_SHARED; =20 for (i =3D 0; p && p->flags !=3D 0; p++, i++) { - uart.port.iobase =3D p->iobase; - uart.port.membase =3D p->membase; - uart.port.irq =3D p->irq; - uart.port.irqflags =3D p->irqflags; - uart.port.uartclk =3D p->uartclk; - uart.port.regshift =3D p->regshift; - uart.port.iotype =3D p->iotype; - uart.port.flags =3D p->flags; - uart.port.mapbase =3D p->mapbase; - uart.port.mapsize =3D p->mapsize; - uart.port.hub6 =3D p->hub6; - uart.port.has_sysrq =3D p->has_sysrq; - uart.port.private_data =3D p->private_data; - uart.port.type =3D p->type; - uart.bugs =3D p->bugs; - uart.port.serial_in =3D p->serial_in; - uart.port.serial_out =3D p->serial_out; - uart.dl_read =3D p->dl_read; - uart.dl_write =3D p->dl_write; - uart.port.handle_irq =3D p->handle_irq; - uart.port.handle_break =3D p->handle_break; - uart.port.set_termios =3D p->set_termios; - uart.port.set_ldisc =3D p->set_ldisc; - uart.port.get_mctrl =3D p->get_mctrl; - uart.port.pm =3D p->pm; - uart.port.dev =3D &dev->dev; - uart.port.irqflags |=3D irqflag; - ret =3D serial8250_register_8250_port(&uart); + uart->port.iobase =3D p->iobase; + uart->port.membase =3D p->membase; + uart->port.irq =3D p->irq; + uart->port.irqflags =3D p->irqflags; + uart->port.uartclk =3D p->uartclk; + uart->port.regshift =3D p->regshift; + uart->port.iotype =3D p->iotype; + uart->port.flags =3D p->flags; + uart->port.mapbase =3D p->mapbase; + uart->port.mapsize =3D p->mapsize; + uart->port.hub6 =3D p->hub6; + uart->port.has_sysrq =3D p->has_sysrq; + uart->port.private_data =3D p->private_data; + uart->port.type =3D p->type; + uart->bugs =3D p->bugs; + uart->port.serial_in =3D p->serial_in; + uart->port.serial_out =3D p->serial_out; + uart->dl_read =3D p->dl_read; + uart->dl_write =3D p->dl_write; + uart->port.handle_irq =3D p->handle_irq; + uart->port.handle_break =3D p->handle_break; + uart->port.set_termios =3D p->set_termios; + uart->port.set_ldisc =3D p->set_ldisc; + uart->port.get_mctrl =3D p->get_mctrl; + uart->port.pm =3D p->pm; + uart->port.dev =3D &dev->dev; + uart->port.irqflags |=3D irqflag; + ret =3D serial8250_register_8250_port(uart); if (ret < 0) { dev_err(&dev->dev, "unable to register port at index %d " "(IO%lx MEM%llx IRQ%d): %d\n", i, --=20 2.50.1