From nobody Sun Oct 5 09:04:05 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B246329B8E1 for ; Wed, 6 Aug 2025 18:30:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754505061; cv=none; b=Uu+rqgFQVmg4I8FodvOijn00MRDOtU/eSbQJ+egAUqlAVZe9BRxA9ig3rnMmdnGWNktM5vc4Sdn6X2ym9GPBxrxyNsrAzfXvz8NWthISGZ1+Gg1D5S17HjLiTcPvSoHv6sWi0ss1gAhPoUMKs0BJUTNwryvDOqv8+RR0RjthR2A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754505061; c=relaxed/simple; bh=clnDQmsEY8lWrEJelqgi+xfG57VwXFythWYwGl2tIkU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OGBGAyTnT8UqOuxlbGj/dfB1hnbTsCgyP2upeA9VoSUmLWLFy2Zw83dlPmhn4Lddj4amozcAP7qd0+r7UZj5Gan5GW0oMsz7Z5ZqatsegCnwylA7u9z9lglukIRqwUJwhvpV3Da9uSjv/+qjq8i+m6DxQeOQyu4l1Gmb/oqarZw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g+Y1evul; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g+Y1evul" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3b7834f2e72so51709f8f.2 for ; Wed, 06 Aug 2025 11:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754505058; x=1755109858; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KMoxd/Dtadzsy2TCiR8kFe7kGYsf87uO6nSdEOT8I+M=; b=g+Y1evul7sZ8i0OiA1aBHn9uH/0VD/eBq18wMHERZmTXEUO8kFvlKaZeziRftvcMlp Y9Hp15L/2MPB2z5MSdWxsogIE0cp8yiOmggab3Az/vyDt7lB0mktuXohRdw4I2u+5hbW LYBu7/PwKW4wFHHbqBoJ4VEh55hrOQIeSTwR4/B84shopBWficwPikyaLBR73VrNMQgt 5GknP5bvsZa7XG1u3lnljFk4jl1TNcuK9gFnur41HGuS3xAGRZcmnzRPq3zao/71rTQG iFOPfRLR5/2gtqZKABNPjIcsPJj04+cn6BUmmISYjQRugkPOvG5+vuOmLzjS2ky9vzDg w8+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754505058; x=1755109858; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KMoxd/Dtadzsy2TCiR8kFe7kGYsf87uO6nSdEOT8I+M=; b=Nk/mLWis/0KMk3f4yaUt7ByA+Uo5AguntaQTUOB1GGeGEKb4+jcignPofWfztbvLEB xoRFvZB1uZRswZ7nE1kX+9vjXmCNuB+EHOGpSAHqJ/DhV962OX7sFYqOF9dsw9qF+vIN Jsq0KSJXhRz8hIJZKZLKe9iNovmlxjRQME6zEl4Ejhp2bvJ3eTMoGtOn5XNe2bum2Dfp Kcq59kkzb6qnCQNlX72M92tHdf8MqrtsopV3bcgLoKOxSlwSDLxh1eum9xiUpLX8dx+/ 0+bRcdbiqz1/e7xlJFG5vQEdj3W7cvvcGcRFgMfSLN8wrkKj9KCR5ieoWWlMw+gBjYFc 5aNA== X-Forwarded-Encrypted: i=1; AJvYcCXdOWu4qdgsECof91/mw3IowC/SMuHPQlZSz1CVbd8a4Nm2I+S6pMV3lffcFNcn+/nJZOqYDA/kCAHN3bI=@vger.kernel.org X-Gm-Message-State: AOJu0YzZ2IwSo14gqBQ2IfGXdl0T2F9B79DASbkKV4rZ7rhHix5KsDmU OjEXDacMLQHrGr97MUhwFFTG4+uV/p7hfEy1XjSP7KwJB4WtwrBv1taF X-Gm-Gg: ASbGncu7E2l9iMNxe5KytKOjon+p4GEZ/QTiA/t/N68KLFzrU2ETdFpNLeSnxvBaql6 6S6njE9ed7DTBLwESyxE/OjwUIoHboRkwWnXC2Ofd2UCXt7jGzveZY0m2QodhhJVmhUzfPFwSjH 5c49tOCX6OQdFsczY/0FEf07fg2T2K5gPk9gyqJbwYWDk7KYkIm2+knU+/3B21PmeC1RSN8xV8v iGcg2AXh+ZlWpLXnTnhzaFU6eq4Ai0cc8mnx4/d1J6UyJo+OiDSWnCxdxVRor1/zD4wWupCEnDB NjE1UnTCUDutEyIQrjDqBrjhw0/PPM9CntgRt/OePOEbf2kK61CkqWK1xKQ2ABxexyVcUVB0eMB vZpC3Nv3GQ/ZYq8iHjBeG9wm+x016lVhCEw/ABtYI/IPqmy6e8Ov6RqBCd59aA7jI4HD5MxG5bA 0= X-Google-Smtp-Source: AGHT+IFV6VxxjKWucmbCsDSr/60Mju0iKC0OAZ6zMp3uTJRxh8IJaaXS1z0E5eQ2EA47SgnGxXvy9w== X-Received: by 2002:a05:6000:2312:b0:3a6:c923:bc5f with SMTP id ffacd0b85a97d-3b8f4165fb2mr3101027f8f.17.1754505057803; Wed, 06 Aug 2025 11:30:57 -0700 (PDT) Received: from ekhafagy-ROG-Zephyrus-M16-GU603HR-GU603HR.. ([156.204.172.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-459c58ed07fsm156104065e9.22.2025.08.06.11.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Aug 2025 11:30:57 -0700 (PDT) From: Eslam Khafagy To: Cc: skhan@linuxfoundation.com, Eslam Khafagy , Manikandan Muralidharan , Dharma Balasubiramani , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/1] drm: atmel-hlcdc: replace dev_* print funtions with drm_* variants Date: Wed, 6 Aug 2025 21:30:41 +0300 Message-ID: <20250806183049.52112-2-eslam.medhat1993@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250806183049.52112-1-eslam.medhat1993@gmail.com> References: <20250806183049.52112-1-eslam.medhat1993@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" According to documentation[1] drm_* variants are preferred over dev_* print functions. [1] https://docs.kernel.org/gpu/todo.html#convert-logging-to-drm-functions-= with-drm-device-parameter v1->v2 replace dev_dbg with drm_dbg in atmel_hlcdc_plane.c Signed-off-by: Eslam Khafagy --- .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 20 +++++++++---------- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 14 ++++++------- .../gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 2 +- .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 6 +++--- 4 files changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/d= rm/atmel-hlcdc/atmel_hlcdc_crtc.c index 0f7ffb3ced20..da94ab0540bb 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c @@ -215,32 +215,32 @@ static void atmel_hlcdc_crtc_atomic_disable(struct dr= m_crtc *c, if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, !(status & ATMEL_XLCDC_CM), 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register CMSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register CMSTS timeout\n"); =20 regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_XLCDC_SD); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, status & ATMEL_XLCDC_SD, 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register SDSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register SDSTS timeout\n"); } =20 regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_DISP); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, !(status & ATMEL_HLCDC_DISP), 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register DISPSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register DISPSTS timeout\n"); =20 regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_SYNC); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, !(status & ATMEL_HLCDC_SYNC), 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register LCDSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register LCDSTS timeout\n"); =20 regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_PIXEL_CLK); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, !(status & ATMEL_HLCDC_PIXEL_CLK), 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register CLKSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register CLKSTS timeout\n"); =20 clk_disable_unprepare(crtc->dc->hlcdc->sys_clk); pinctrl_pm_select_sleep_state(dev->dev); @@ -269,32 +269,32 @@ static void atmel_hlcdc_crtc_atomic_enable(struct drm= _crtc *c, if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, status & ATMEL_HLCDC_PIXEL_CLK, 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register CLKSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register CLKSTS timeout\n"); =20 regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_HLCDC_SYNC); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, status & ATMEL_HLCDC_SYNC, 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register LCDSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register LCDSTS timeout\n"); =20 regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_HLCDC_DISP); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, status & ATMEL_HLCDC_DISP, 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register DISPSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register DISPSTS timeout\n"); =20 if (crtc->dc->desc->is_xlcdc) { regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_XLCDC_CM); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, status & ATMEL_XLCDC_CM, 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register CMSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register CMSTS timeout\n"); =20 regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_XLCDC_SD); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, !(status & ATMEL_XLCDC_SD), 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register SDSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register SDSTS timeout\n"); } =20 pm_runtime_put_sync(dev->dev); diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm= /atmel-hlcdc/atmel_hlcdc_dc.c index fa8ad94e431a..acb017a2486b 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c @@ -724,19 +724,19 @@ static int atmel_hlcdc_dc_modeset_init(struct drm_dev= ice *dev) =20 ret =3D atmel_hlcdc_create_outputs(dev); if (ret) { - dev_err(dev->dev, "failed to create HLCDC outputs: %d\n", ret); + drm_err(dev, "failed to create HLCDC outputs: %d\n", ret); return ret; } =20 ret =3D atmel_hlcdc_create_planes(dev); if (ret) { - dev_err(dev->dev, "failed to create planes: %d\n", ret); + drm_err(dev, "failed to create planes: %d\n", ret); return ret; } =20 ret =3D atmel_hlcdc_crtc_create(dev); if (ret) { - dev_err(dev->dev, "failed to create crtc\n"); + drm_err(dev, "failed to create crtc\n"); return ret; } =20 @@ -778,7 +778,7 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev) =20 ret =3D clk_prepare_enable(dc->hlcdc->periph_clk); if (ret) { - dev_err(dev->dev, "failed to enable periph_clk\n"); + drm_err(dev, "failed to enable periph_clk\n"); return ret; } =20 @@ -786,13 +786,13 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev) =20 ret =3D drm_vblank_init(dev, 1); if (ret < 0) { - dev_err(dev->dev, "failed to initialize vblank\n"); + drm_err(dev, "failed to initialize vblank\n"); goto err_periph_clk_disable; } =20 ret =3D atmel_hlcdc_dc_modeset_init(dev); if (ret < 0) { - dev_err(dev->dev, "failed to initialize mode setting\n"); + drm_err(dev, "failed to initialize mode setting\n"); goto err_periph_clk_disable; } =20 @@ -802,7 +802,7 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev) ret =3D atmel_hlcdc_dc_irq_install(dev, dc->hlcdc->irq); pm_runtime_put_sync(dev->dev); if (ret < 0) { - dev_err(dev->dev, "failed to install IRQ handler\n"); + drm_err(dev, "failed to install IRQ handler\n"); goto err_periph_clk_disable; } =20 diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu= /drm/atmel-hlcdc/atmel_hlcdc_output.c index 50fee6a93964..945a475c33ac 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c @@ -92,7 +92,7 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device = *dev, int endpoint) output->bus_fmt =3D atmel_hlcdc_of_bus_fmt(ep); of_node_put(ep); if (output->bus_fmt < 0) { - dev_err(dev->dev, "endpoint %d: invalid bus width\n", endpoint); + drm_err(dev, "endpoint %d: invalid bus width\n", endpoint); return -EINVAL; } =20 diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/= drm/atmel-hlcdc/atmel_hlcdc_plane.c index 4a7ba0918eca..817284509b57 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c @@ -1034,7 +1034,7 @@ static void atmel_hlcdc_irq_dbg(struct atmel_hlcdc_pl= ane *plane, if (isr & (ATMEL_HLCDC_LAYER_OVR_IRQ(0) | ATMEL_HLCDC_LAYER_OVR_IRQ(1) | ATMEL_HLCDC_LAYER_OVR_IRQ(2))) - dev_dbg(plane->base.dev->dev, "overrun on plane %s\n", + drm_dbg(plane->base.dev, "overrun on plane %s\n", desc->name); } =20 @@ -1051,7 +1051,7 @@ static void atmel_xlcdc_irq_dbg(struct atmel_hlcdc_pl= ane *plane, if (isr & (ATMEL_XLCDC_LAYER_OVR_IRQ(0) | ATMEL_XLCDC_LAYER_OVR_IRQ(1) | ATMEL_XLCDC_LAYER_OVR_IRQ(2))) - dev_dbg(plane->base.dev->dev, "overrun on plane %s\n", + drm_dbg(plane->base.dev, "overrun on plane %s\n", desc->name); } =20 @@ -1140,7 +1140,7 @@ static void atmel_hlcdc_plane_reset(struct drm_plane = *p) if (state) { if (atmel_hlcdc_plane_alloc_dscrs(p, state)) { kfree(state); - dev_err(p->dev->dev, + drm_err(p->dev, "Failed to allocate initial plane state\n"); return; } --=20 2.43.0