From nobody Sun Oct 5 10:47:08 2025 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADF28293C67 for ; Wed, 6 Aug 2025 15:59:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754495956; cv=none; b=sh02uLHZXKT/SJbljzK1LHVhaMW4Pnke1Q9N1hTOQVFg2LDkAkGfJtfShEu6HqbRRPQ5qBWXQsk/GxvDzq/red8/zWM1Wm/RyzJkS2nDQ7URWKFlP8UdKynXiy7LxuSSdGtWQb0sunRg2qrK0F7PkZ4SZ0r2yogwbDYqtiO0K8Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754495956; c=relaxed/simple; bh=l8GK7j81RR9TW2O59fnuL+/gB6hOmTs5V1eaXU6DdMY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=dnGV7CFEfy4Wmx3u2gwuVmN7fYr0gNMwnoEALhTU+Pkm6QmXtYLxXmN9Jio2KRRyOdtOxjwl7pTTnt3D/UfnFGpLWiC0sX4wAyoNjyw7Wi8czu+CFbSrlNI1mjy4116HpN8oTTaY1hE+d2n9H1u0jJta96SkzzaGvnUJ3IbIBzY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=YRXHm28G; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YRXHm28G" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-31f3cfdd3d3so92238a91.3 for ; Wed, 06 Aug 2025 08:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1754495952; x=1755100752; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=OmeTFm5IfPWrfl19FRLhdX2A+KKvy2/5Athl1bFbaAo=; b=YRXHm28GWFL1rkpM+UQ4o45qcIf2PyVrEqR+vuJfRK/wxT31RdWsfug/F8BYVOlm5o cONPVfpVjyeeg14iMDFqyjPxlB6Izlf+TgZXFzkVQvn6ejo1bqA/AtHseK4f0g/139Wc 3UhVi6A1ZOrzjff15TrgOqb/qYdQsJlobyeRMjd5c5s4f01EchFH3BbzDXCMlG+m9Eu3 3ojINJVbDcKziiD44aZGXnXyJrmvz29HFxydvtuNYhV/PkexpD2uEynRpBpy08Mv2D1g tMFsSwoKgpZ+SlnYf4XanZm1w+SdTpCl3i9HWPxW2Yme94h3Ib+/k8AqN4V8mb9VCP/y oI0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754495952; x=1755100752; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OmeTFm5IfPWrfl19FRLhdX2A+KKvy2/5Athl1bFbaAo=; b=Y7ThgJFodEFDpFHXHHXfm7wPyhMrnxtaeE/rg8rWQ1rPuDfaE89dqxwOnv7rLicERy waloDs3Bd7Z5mg6FIR5LJCjEhqLo+R+dxcT1EtMJ7IB7FVFjF+IghEwNEUajH28Q6krq Y21JF7a1KBuIdbBicxldEvVP1HeIh4H4J5oLyPr51WxGT2i7HL03UvIiShd57BYZBFJc PVZP7TdojmT9ps0ytWfU4n6AZtit2YEuD5Nk/euh8bVCEbdSLG0qlJ0mAYTQ7UFI9/8S MyPrujSb3WKkW9ZDuC7JgDSATbYubhlocgWQokWStnHhsZowzZbz/AaHHKRaD6VAIji4 fuxg== X-Forwarded-Encrypted: i=1; AJvYcCWxYC42rpemJfX9Sz5uClXoVpgtZ894heTH5rN6HxPVHDMdYyZMwf5jsFXdkNrx3pvCjr1VmIMghFTI72Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzeKL+FwOJZ94+M7aexHH8eNacHfbii01euwKlYwDkbmhFVO+11 xnFYCvjO5bi0JStR5SHrCOodAJHJU9eEL93+pxUJIxAXB0jO6Lp5teL01Kpy4uuDCib1G7XabDJ 1R0hj9A== X-Google-Smtp-Source: AGHT+IHypLIFS0bldz1JBYWo4PWfSWusTsYByh8vtqV4CTtvef/tfbbsrJZ7GVJlV0SCUzRbeil7HQOczFA= X-Received: from pjsj11.prod.google.com ([2002:a17:90a:734b:b0:31c:bdae:b22a]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2fc7:b0:321:2160:bf6e with SMTP id 98e67ed59e1d1-3216759164amr4291303a91.24.1754495952108; Wed, 06 Aug 2025 08:59:12 -0700 (PDT) Date: Wed, 6 Aug 2025 08:59:03 -0700 In-Reply-To: <20250806155905.824388-1-surenb@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250806155905.824388-1-surenb@google.com> X-Mailer: git-send-email 2.50.1.565.gc32cd1483b-goog Message-ID: <20250806155905.824388-3-surenb@google.com> Subject: [PATCH v3 2/3] fs/proc/task_mmu: factor out proc_maps_private fields used by PROCMAP_QUERY From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, david@redhat.com, vbabka@suse.cz, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, aha310510@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, surenb@google.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Refactor struct proc_maps_private so that the fields used by PROCMAP_QUERY ioctl are moved into a separate structure. In the next patch this allows ioctl to reuse some of the functions used for reading /proc/pid/maps without using file->private_data. This prevents concurrent modification of file->private_data members by ioctl and /proc/pid/maps readers. The change is pure code refactoring and has no functional changes. Signed-off-by: Suren Baghdasaryan Reviewed-by: Vlastimil Babka Acked-by: SeongJae Park --- fs/proc/internal.h | 15 ++++++---- fs/proc/task_mmu.c | 70 ++++++++++++++++++++++---------------------- fs/proc/task_nommu.c | 14 ++++----- 3 files changed, 52 insertions(+), 47 deletions(-) diff --git a/fs/proc/internal.h b/fs/proc/internal.h index e737401d7383..d1598576506c 100644 --- a/fs/proc/internal.h +++ b/fs/proc/internal.h @@ -378,16 +378,21 @@ extern void proc_self_init(void); * task_[no]mmu.c */ struct mem_size_stats; -struct proc_maps_private { - struct inode *inode; - struct task_struct *task; + +struct proc_maps_locking_ctx { struct mm_struct *mm; - struct vma_iterator iter; - loff_t last_pos; #ifdef CONFIG_PER_VMA_LOCK bool mmap_locked; struct vm_area_struct *locked_vma; #endif +}; + +struct proc_maps_private { + struct inode *inode; + struct task_struct *task; + struct vma_iterator iter; + loff_t last_pos; + struct proc_maps_locking_ctx lock_ctx; #ifdef CONFIG_NUMA struct mempolicy *task_mempolicy; #endif diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index ee1e4ccd33bd..45134335e086 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -132,11 +132,11 @@ static void release_task_mempolicy(struct proc_maps_p= rivate *priv) =20 #ifdef CONFIG_PER_VMA_LOCK =20 -static void unlock_vma(struct proc_maps_private *priv) +static void unlock_vma(struct proc_maps_locking_ctx *lock_ctx) { - if (priv->locked_vma) { - vma_end_read(priv->locked_vma); - priv->locked_vma =3D NULL; + if (lock_ctx->locked_vma) { + vma_end_read(lock_ctx->locked_vma); + lock_ctx->locked_vma =3D NULL; } } =20 @@ -151,14 +151,14 @@ static inline bool lock_vma_range(struct seq_file *m, * walking the vma tree under rcu read protection. */ if (m->op !=3D &proc_pid_maps_op) { - if (mmap_read_lock_killable(priv->mm)) + if (mmap_read_lock_killable(priv->lock_ctx.mm)) return false; =20 - priv->mmap_locked =3D true; + priv->lock_ctx.mmap_locked =3D true; } else { rcu_read_lock(); - priv->locked_vma =3D NULL; - priv->mmap_locked =3D false; + priv->lock_ctx.locked_vma =3D NULL; + priv->lock_ctx.mmap_locked =3D false; } =20 return true; @@ -166,10 +166,10 @@ static inline bool lock_vma_range(struct seq_file *m, =20 static inline void unlock_vma_range(struct proc_maps_private *priv) { - if (priv->mmap_locked) { - mmap_read_unlock(priv->mm); + if (priv->lock_ctx.mmap_locked) { + mmap_read_unlock(priv->lock_ctx.mm); } else { - unlock_vma(priv); + unlock_vma(&priv->lock_ctx); rcu_read_unlock(); } } @@ -179,13 +179,13 @@ static struct vm_area_struct *get_next_vma(struct pro= c_maps_private *priv, { struct vm_area_struct *vma; =20 - if (priv->mmap_locked) + if (priv->lock_ctx.mmap_locked) return vma_next(&priv->iter); =20 - unlock_vma(priv); - vma =3D lock_next_vma(priv->mm, &priv->iter, last_pos); + unlock_vma(&priv->lock_ctx); + vma =3D lock_next_vma(priv->lock_ctx.mm, &priv->iter, last_pos); if (!IS_ERR_OR_NULL(vma)) - priv->locked_vma =3D vma; + priv->lock_ctx.locked_vma =3D vma; =20 return vma; } @@ -193,14 +193,14 @@ static struct vm_area_struct *get_next_vma(struct pro= c_maps_private *priv, static inline bool fallback_to_mmap_lock(struct proc_maps_private *priv, loff_t pos) { - if (priv->mmap_locked) + if (priv->lock_ctx.mmap_locked) return false; =20 rcu_read_unlock(); - mmap_read_lock(priv->mm); + mmap_read_lock(priv->lock_ctx.mm); /* Reinitialize the iterator after taking mmap_lock */ vma_iter_set(&priv->iter, pos); - priv->mmap_locked =3D true; + priv->lock_ctx.mmap_locked =3D true; =20 return true; } @@ -210,12 +210,12 @@ static inline bool fallback_to_mmap_lock(struct proc_= maps_private *priv, static inline bool lock_vma_range(struct seq_file *m, struct proc_maps_private *priv) { - return mmap_read_lock_killable(priv->mm) =3D=3D 0; + return mmap_read_lock_killable(priv->lock_ctx.mm) =3D=3D 0; } =20 static inline void unlock_vma_range(struct proc_maps_private *priv) { - mmap_read_unlock(priv->mm); + mmap_read_unlock(priv->lock_ctx.mm); } =20 static struct vm_area_struct *get_next_vma(struct proc_maps_private *priv, @@ -258,7 +258,7 @@ static struct vm_area_struct *proc_get_vma(struct seq_f= ile *m, loff_t *ppos) *ppos =3D vma->vm_end; } else { *ppos =3D SENTINEL_VMA_GATE; - vma =3D get_gate_vma(priv->mm); + vma =3D get_gate_vma(priv->lock_ctx.mm); } =20 return vma; @@ -278,7 +278,7 @@ static void *m_start(struct seq_file *m, loff_t *ppos) if (!priv->task) return ERR_PTR(-ESRCH); =20 - mm =3D priv->mm; + mm =3D priv->lock_ctx.mm; if (!mm || !mmget_not_zero(mm)) { put_task_struct(priv->task); priv->task =3D NULL; @@ -318,7 +318,7 @@ static void *m_next(struct seq_file *m, void *v, loff_t= *ppos) static void m_stop(struct seq_file *m, void *v) { struct proc_maps_private *priv =3D m->private; - struct mm_struct *mm =3D priv->mm; + struct mm_struct *mm =3D priv->lock_ctx.mm; =20 if (!priv->task) return; @@ -339,9 +339,9 @@ static int proc_maps_open(struct inode *inode, struct f= ile *file, return -ENOMEM; =20 priv->inode =3D inode; - priv->mm =3D proc_mem_open(inode, PTRACE_MODE_READ); - if (IS_ERR_OR_NULL(priv->mm)) { - int err =3D priv->mm ? PTR_ERR(priv->mm) : -ESRCH; + priv->lock_ctx.mm =3D proc_mem_open(inode, PTRACE_MODE_READ); + if (IS_ERR_OR_NULL(priv->lock_ctx.mm)) { + int err =3D priv->lock_ctx.mm ? PTR_ERR(priv->lock_ctx.mm) : -ESRCH; =20 seq_release_private(inode, file); return err; @@ -355,8 +355,8 @@ static int proc_map_release(struct inode *inode, struct= file *file) struct seq_file *seq =3D file->private_data; struct proc_maps_private *priv =3D seq->private; =20 - if (priv->mm) - mmdrop(priv->mm); + if (priv->lock_ctx.mm) + mmdrop(priv->lock_ctx.mm); =20 return seq_release_private(inode, file); } @@ -610,7 +610,7 @@ static int do_procmap_query(struct proc_maps_private *p= riv, void __user *uarg) if (!!karg.build_id_size !=3D !!karg.build_id_addr) return -EINVAL; =20 - mm =3D priv->mm; + mm =3D priv->lock_ctx.mm; if (!mm || !mmget_not_zero(mm)) return -ESRCH; =20 @@ -1311,7 +1311,7 @@ static int show_smaps_rollup(struct seq_file *m, void= *v) { struct proc_maps_private *priv =3D m->private; struct mem_size_stats mss =3D {}; - struct mm_struct *mm =3D priv->mm; + struct mm_struct *mm =3D priv->lock_ctx.mm; struct vm_area_struct *vma; unsigned long vma_start =3D 0, last_vma_end =3D 0; int ret =3D 0; @@ -1456,9 +1456,9 @@ static int smaps_rollup_open(struct inode *inode, str= uct file *file) goto out_free; =20 priv->inode =3D inode; - priv->mm =3D proc_mem_open(inode, PTRACE_MODE_READ); - if (IS_ERR_OR_NULL(priv->mm)) { - ret =3D priv->mm ? PTR_ERR(priv->mm) : -ESRCH; + priv->lock_ctx.mm =3D proc_mem_open(inode, PTRACE_MODE_READ); + if (IS_ERR_OR_NULL(priv->lock_ctx.mm)) { + ret =3D priv->lock_ctx.mm ? PTR_ERR(priv->lock_ctx.mm) : -ESRCH; =20 single_release(inode, file); goto out_free; @@ -1476,8 +1476,8 @@ static int smaps_rollup_release(struct inode *inode, = struct file *file) struct seq_file *seq =3D file->private_data; struct proc_maps_private *priv =3D seq->private; =20 - if (priv->mm) - mmdrop(priv->mm); + if (priv->lock_ctx.mm) + mmdrop(priv->lock_ctx.mm); =20 kfree(priv); return single_release(inode, file); diff --git a/fs/proc/task_nommu.c b/fs/proc/task_nommu.c index 59bfd61d653a..d362919f4f68 100644 --- a/fs/proc/task_nommu.c +++ b/fs/proc/task_nommu.c @@ -204,7 +204,7 @@ static void *m_start(struct seq_file *m, loff_t *ppos) if (!priv->task) return ERR_PTR(-ESRCH); =20 - mm =3D priv->mm; + mm =3D priv->lock_ctx.mm; if (!mm || !mmget_not_zero(mm)) { put_task_struct(priv->task); priv->task =3D NULL; @@ -226,7 +226,7 @@ static void *m_start(struct seq_file *m, loff_t *ppos) static void m_stop(struct seq_file *m, void *v) { struct proc_maps_private *priv =3D m->private; - struct mm_struct *mm =3D priv->mm; + struct mm_struct *mm =3D priv->lock_ctx.mm; =20 if (!priv->task) return; @@ -259,9 +259,9 @@ static int maps_open(struct inode *inode, struct file *= file, return -ENOMEM; =20 priv->inode =3D inode; - priv->mm =3D proc_mem_open(inode, PTRACE_MODE_READ); - if (IS_ERR_OR_NULL(priv->mm)) { - int err =3D priv->mm ? PTR_ERR(priv->mm) : -ESRCH; + priv->lock_ctx.mm =3D proc_mem_open(inode, PTRACE_MODE_READ); + if (IS_ERR_OR_NULL(priv->lock_ctx.mm)) { + int err =3D priv->lock_ctx.mm ? PTR_ERR(priv->lock_ctx.mm) : -ESRCH; =20 seq_release_private(inode, file); return err; @@ -276,8 +276,8 @@ static int map_release(struct inode *inode, struct file= *file) struct seq_file *seq =3D file->private_data; struct proc_maps_private *priv =3D seq->private; =20 - if (priv->mm) - mmdrop(priv->mm); + if (priv->lock_ctx.mm) + mmdrop(priv->lock_ctx.mm); =20 return seq_release_private(inode, file); } --=20 2.50.1.565.gc32cd1483b-goog