From nobody Sun Oct 5 09:04:15 2025 Received: from mail-m158214.netease.com (mail-m158214.netease.com [47.251.158.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7AFD17A2F6; Wed, 6 Aug 2025 02:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=47.251.158.214 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754448963; cv=none; b=TmxaySAI5P4N9+rQUqzQaxy04/ipes/P1SEA6pIh0MAQauEDElFKVAJ0X0c7KJklCXaQ24ucdKP8sqQFaEYbMj9iQMZrMwv7ZYC7PL1pWEFbsdMEqncfEEB7BMNJIVoQztBWMkSGy+M/CDALLcLWIv8HCGDisb1G1jDn2e92EyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754448963; c=relaxed/simple; bh=z6X5D3erwN78KoY99M+XF9YsI9lWTL31yP3cCfFzeQY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PUtMH6JZJY9GYwEZ6aZE/ewoawDPlWqND1tuA0Ul7+S3TaAUl1daU+L/BkcPvTFjcCPEqWtk8vd4ul0cg1rBU+HXZaagRlhvGg+ekW33s1coeC1uDaV8PXTqBXvfJW5hiyNj1Ijrf3n+fUpWKRfY9mfHW8UU/9dc0YNm++oK4v4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=easystack.cn; spf=pass smtp.mailfrom=easystack.cn; arc=none smtp.client-ip=47.251.158.214 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=easystack.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=easystack.cn Received: from localhost.localdomain (unknown [218.94.118.90]) by smtp.qiye.163.com (Hmail) with ESMTP id e3561010; Wed, 6 Aug 2025 10:55:47 +0800 (GMT+08:00) From: Zhen Ni To: krzk@kernel.org, alim.akhtar@samsung.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Zhen Ni , stable@vger.kernel.org Subject: [PATCH v2] memory: samsung: exynos-srom: Fix of_iomap leak in exynos_srom_probe Date: Wed, 6 Aug 2025 10:55:38 +0800 Message-Id: <20250806025538.306593-1-zhen.ni@easystack.cn> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20250731083340.1057564-1-zhen.ni@easystack.cn> References: <20250731083340.1057564-1-zhen.ni@easystack.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a987d4e66f70229kunmafffe608625d3e X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJQjdXWS1ZQUlXWQ8JGhUIEh9ZQVlDTUJPVh8YGkNNHkwaSkhOGFYVFAkWGhdVGRETFh oSFyQUDg9ZV1kYEgtZQVlJSkNVQk9VSkpDVUJLWVdZFhoPEhUdFFlBWU9LSFVKS0hKTkxKVUpLS1 VKQktLWQY+ Content-Type: text/plain; charset="utf-8" The of_platform_populate() call at the end of the function has a possible failure path, causing a resource leak. Replace of_iomap() with devm_platform_ioremap_resource() to ensure automatic cleanup of srom->reg_base. This issue was detected by smatch static analysis: drivers/memory/samsung/exynos-srom.c:155 exynos_srom_probe()warn: 'srom->reg_base' from of_iomap() not released on lines: 155. Fixes: 8ac2266d8831 ("memory: samsung: exynos-srom: Add support for bank co= nfiguration") Cc: stable@vger.kernel.org Signed-off-by: Zhen Ni --- chanegs in v2: - Update commit msg --- drivers/memory/samsung/exynos-srom.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/memory/samsung/exynos-srom.c b/drivers/memory/samsung/= exynos-srom.c index e73dd330af47..d913fb901973 100644 --- a/drivers/memory/samsung/exynos-srom.c +++ b/drivers/memory/samsung/exynos-srom.c @@ -121,20 +121,18 @@ static int exynos_srom_probe(struct platform_device *= pdev) return -ENOMEM; =20 srom->dev =3D dev; - srom->reg_base =3D of_iomap(np, 0); - if (!srom->reg_base) { + srom->reg_base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(srom->reg_base)) { dev_err(&pdev->dev, "iomap of exynos srom controller failed\n"); - return -ENOMEM; + return PTR_ERR(srom->reg_base); } =20 platform_set_drvdata(pdev, srom); =20 srom->reg_offset =3D exynos_srom_alloc_reg_dump(exynos_srom_offsets, ARRAY_SIZE(exynos_srom_offsets)); - if (!srom->reg_offset) { - iounmap(srom->reg_base); + if (!srom->reg_offset) return -ENOMEM; - } =20 for_each_child_of_node(np, child) { if (exynos_srom_configure_bank(srom, child)) { --=20 2.20.1