From nobody Sun Oct 5 09:04:09 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A4162E36EC for ; Wed, 6 Aug 2025 00:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754438516; cv=none; b=Tko/6J0JeBD6UkfN9KzzrfT5ra/5z51/qUkLoRmx75QQ9tuk3p7K3Ye371ziIRE0vrSjhuBIDDDFsBajNm/JrnLUdssHK87jXa54a1/iEknUgzofdfE9nkdxju3YIKI0B/BCav6USG6Q63BgvaOlVHXyxHqxHcXb7zEeCDmevkQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754438516; c=relaxed/simple; bh=kvFqBSSLeZdNRB4sYvZw9ektf3AcQyyHR/A6X8hV1Bo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ChFnUylGln22ul9Vg2sgkW5bvosrFpXZc3lnoFKV1wCsvS/AmDLlARg7k4IyI22faQH/pclfyYp/RSWo76B5+mRCZkn3LpWXVyQu6l5JPPErNRmdrauwkPxYUcwBNIpz9a+6K0tuADOiHTHZ+YjoRkhfiALOsaX7RFvyVvpl8cI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EEWkM4+d; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EEWkM4+d" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-458ba079338so2678335e9.1 for ; Tue, 05 Aug 2025 17:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754438512; x=1755043312; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kWxTVsldVxx1WswkyHYD0GCVmGgL66ul9t+8EJPnmh8=; b=EEWkM4+dng05GKJj/2a0WvtRImj4PAd7J/RIAaI5Q122koSRc89c/3j8vvBkHyxR0Y PK6HfomaG+BoqS/ogNwco16bfFAeqvtq4aNWW2Re5yYdwca0Trx1UkkeAu62yLsZ+Br2 vWUfCqxUTeyqFTTigJKg8UQc6xSFsQimQykaIL0Y/45WlAC3dL/nj2Pd415VLtYHfSDC Bpsxo9SDRtdwfbY+tD0et9sTSP1z8+HKLEUU8Oaw8RxYqkX47kfWP35ggKewmCwPWDKi +HDL34vUFJyWSFGyJCVhbLQ0WP69tU/e5hYiPqI/xcN05jMFVIc3YOC+M+KgItmOE/o/ rSpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754438512; x=1755043312; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kWxTVsldVxx1WswkyHYD0GCVmGgL66ul9t+8EJPnmh8=; b=nUn17LvF+RNbJMJjds019bC0kxH5oeSfWQiZE3Lcd5raUkz87OOQ67IfE/Zp3AN/iM gIHUwMiFY/S69E5cBJn2mR4YCVRmse+tIOILMDgrjCpaL/h7eNA4iJnp9IVOibmecvOk kW6pKVhH2MyNp1e88eSYufxYd0mq7yLXLB23/TP8TijEdyb4blOhkvL1ShNjFGB7iVEP A934Ks4by3gYidb0mLHDL1aAYEkT2d26F0jhi13MB5Gbr+MTTtrXOv5TbwcdtOxEATca UD0FQW0Yjh1NXBSIgZOnCynveHEB/UIScr+2gw6ufvaqNFqvOWt1N8PEkTTplnNxUBwB 7BIQ== X-Forwarded-Encrypted: i=1; AJvYcCWDmPfGmmUwIbo8vsIdum6skA4zGmQQK9Q7T9fQjOX3j9EuDcLCjEperd3CSpsC24HDBJofWnH+eaKj5+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzdrzELTQrH3kuQzrxkpK5SB962HQby9nf9GvI3nF/PKUaBQya/ TqQqSVKqoPeE972ELtN8gadSbnhBxKMbkruX3B+oEBr2cNrHwLdt91r/ X-Gm-Gg: ASbGncuGjTFVqa0f/X/OwTmBFDjcY6A/qbQToQsCl5jdyeG/2CDCYRMp8AMDACF27iT Y0dDu71uCIP5V2oAEAICji7w4rzkko+tQbHvwKc3iBaNjgzujf3JhuzHjOuO9sB+a+Ze/OfCJgl KlKv/18MASAoP7+mQetkYuJxE/blAWmVGa+bAxeS71X9VVusqr4iNn+YBwCR4xcy9Ubzvxos6Kf rIESprLJ0YaXTY+yzaXsa4ROtldQCL0fp0DBWVhoP1EbqKWwWVmTDXwO0gcfPiffunjgIfe/3Mp RTLiyoqr3BGKz2SGFcV83v9juMIxdEO99D4msbPm+HUp++PddXx+L527Xg0SoF+zbEwocENRjH8 y4jYEBbc3LJTqC8lzUtuK+FIaiK0QHgvt+quEpP/IA+CHLhJHvODZVg63H3e99yR2cHPNMnhkd6 Q= X-Google-Smtp-Source: AGHT+IEDdNkX149qz3TCB/Qgkq29opwy3tW2MdUYG2GFjtBGUVl+T+HdF5Y7cY/QC3lCsm9WXVX1Sg== X-Received: by 2002:a05:600c:354c:b0:456:1157:59ac with SMTP id 5b1f17b1804b1-459e70898e6mr5767675e9.7.1754438512144; Tue, 05 Aug 2025 17:01:52 -0700 (PDT) Received: from ekhafagy-ROG-Zephyrus-M16-GU603HR-GU603HR.. ([156.204.172.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-458b55b4b4bsm89085205e9.1.2025.08.05.17.01.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Aug 2025 17:01:51 -0700 (PDT) From: Eslam Khafagy To: Cc: skhan@linuxfoundation.com, Eslam Khafagy , Manikandan Muralidharan , Dharma Balasubiramani , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/1] drm: atmel-hlcdc: replace dev_* print funtions with drm_* variants Date: Wed, 6 Aug 2025 03:01:25 +0300 Message-ID: <20250806000141.239753-2-eslam.medhat1993@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250805235928.236248-1-eslam.medhat1993@gmail.com> References: <20250805235928.236248-1-eslam.medhat1993@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" According to documentation[1] drm_* variants are preferred over dev_* print functions. [1] https://docs.kernel.org/gpu/todo.html#convert-logging-to-drm-functions-= with-drm-device-parameter Signed-off-by: Eslam Khafagy --- .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 20 +++++++++---------- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 14 ++++++------- .../gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 2 +- .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- 4 files changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/d= rm/atmel-hlcdc/atmel_hlcdc_crtc.c index 0f7ffb3ced20..da94ab0540bb 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c @@ -215,32 +215,32 @@ static void atmel_hlcdc_crtc_atomic_disable(struct dr= m_crtc *c, if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, !(status & ATMEL_XLCDC_CM), 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register CMSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register CMSTS timeout\n"); =20 regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_XLCDC_SD); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, status & ATMEL_XLCDC_SD, 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register SDSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register SDSTS timeout\n"); } =20 regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_DISP); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, !(status & ATMEL_HLCDC_DISP), 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register DISPSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register DISPSTS timeout\n"); =20 regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_SYNC); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, !(status & ATMEL_HLCDC_SYNC), 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register LCDSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register LCDSTS timeout\n"); =20 regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_PIXEL_CLK); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, !(status & ATMEL_HLCDC_PIXEL_CLK), 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register CLKSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register CLKSTS timeout\n"); =20 clk_disable_unprepare(crtc->dc->hlcdc->sys_clk); pinctrl_pm_select_sleep_state(dev->dev); @@ -269,32 +269,32 @@ static void atmel_hlcdc_crtc_atomic_enable(struct drm= _crtc *c, if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, status & ATMEL_HLCDC_PIXEL_CLK, 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register CLKSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register CLKSTS timeout\n"); =20 regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_HLCDC_SYNC); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, status & ATMEL_HLCDC_SYNC, 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register LCDSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register LCDSTS timeout\n"); =20 regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_HLCDC_DISP); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, status & ATMEL_HLCDC_DISP, 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register DISPSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register DISPSTS timeout\n"); =20 if (crtc->dc->desc->is_xlcdc) { regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_XLCDC_CM); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, status & ATMEL_XLCDC_CM, 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register CMSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register CMSTS timeout\n"); =20 regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_XLCDC_SD); if (regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status, !(status & ATMEL_XLCDC_SD), 10, 1000)) - dev_warn(dev->dev, "Atmel LCDC status register SDSTS timeout\n"); + drm_warn(dev, "Atmel LCDC status register SDSTS timeout\n"); } =20 pm_runtime_put_sync(dev->dev); diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm= /atmel-hlcdc/atmel_hlcdc_dc.c index fa8ad94e431a..acb017a2486b 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c @@ -724,19 +724,19 @@ static int atmel_hlcdc_dc_modeset_init(struct drm_dev= ice *dev) =20 ret =3D atmel_hlcdc_create_outputs(dev); if (ret) { - dev_err(dev->dev, "failed to create HLCDC outputs: %d\n", ret); + drm_err(dev, "failed to create HLCDC outputs: %d\n", ret); return ret; } =20 ret =3D atmel_hlcdc_create_planes(dev); if (ret) { - dev_err(dev->dev, "failed to create planes: %d\n", ret); + drm_err(dev, "failed to create planes: %d\n", ret); return ret; } =20 ret =3D atmel_hlcdc_crtc_create(dev); if (ret) { - dev_err(dev->dev, "failed to create crtc\n"); + drm_err(dev, "failed to create crtc\n"); return ret; } =20 @@ -778,7 +778,7 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev) =20 ret =3D clk_prepare_enable(dc->hlcdc->periph_clk); if (ret) { - dev_err(dev->dev, "failed to enable periph_clk\n"); + drm_err(dev, "failed to enable periph_clk\n"); return ret; } =20 @@ -786,13 +786,13 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev) =20 ret =3D drm_vblank_init(dev, 1); if (ret < 0) { - dev_err(dev->dev, "failed to initialize vblank\n"); + drm_err(dev, "failed to initialize vblank\n"); goto err_periph_clk_disable; } =20 ret =3D atmel_hlcdc_dc_modeset_init(dev); if (ret < 0) { - dev_err(dev->dev, "failed to initialize mode setting\n"); + drm_err(dev, "failed to initialize mode setting\n"); goto err_periph_clk_disable; } =20 @@ -802,7 +802,7 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev) ret =3D atmel_hlcdc_dc_irq_install(dev, dc->hlcdc->irq); pm_runtime_put_sync(dev->dev); if (ret < 0) { - dev_err(dev->dev, "failed to install IRQ handler\n"); + drm_err(dev, "failed to install IRQ handler\n"); goto err_periph_clk_disable; } =20 diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu= /drm/atmel-hlcdc/atmel_hlcdc_output.c index 50fee6a93964..945a475c33ac 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c @@ -92,7 +92,7 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device = *dev, int endpoint) output->bus_fmt =3D atmel_hlcdc_of_bus_fmt(ep); of_node_put(ep); if (output->bus_fmt < 0) { - dev_err(dev->dev, "endpoint %d: invalid bus width\n", endpoint); + drm_err(dev, "endpoint %d: invalid bus width\n", endpoint); return -EINVAL; } =20 diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/= drm/atmel-hlcdc/atmel_hlcdc_plane.c index 4a7ba0918eca..e55e54d52219 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c @@ -1140,7 +1140,7 @@ static void atmel_hlcdc_plane_reset(struct drm_plane = *p) if (state) { if (atmel_hlcdc_plane_alloc_dscrs(p, state)) { kfree(state); - dev_err(p->dev->dev, + drm_err(p->dev, "Failed to allocate initial plane state\n"); return; } --=20 2.43.0