From nobody Sun Oct 5 10:44:41 2025 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BDDC2727E9; Tue, 5 Aug 2025 12:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754398217; cv=none; b=QAuhVKYu5FFGTUHjWA2BLvVXx5XWbH/23VU55Qvdc7+zGQYlGJKY3N1QguIlEHgsLz6TXt8nTu0qpxPPPguFJ4mVG5FXkxBf6YIBxerD6OgttUbNZtl8fG/irvMzaWlR63ds71Z4oC2/ptrbvSqEZMul1BL9dIuF/SSNGWZHI2w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754398217; c=relaxed/simple; bh=HWKv7ENcWJ5P5qVVKyV90sLF4YTQf9daZ1hSHW1sMG8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VgpbxkdncIez44UX/OCKcCHRpejRYCUXV8dmHmmlL9eoztUZBNs9UJvPem6SVqyWV/rMj2GfLuu/17rDvmnGAq62gbdTzZnl+JIR9VCvN3Wc8Eq13CdzJdlX+wSgzYLu4cB4b6A79UfceWrDsvqcHIkYyEJyBvLrn3GV9L6+Ej0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iAYfSABa; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iAYfSABa" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-61568fbed16so6761710a12.3; Tue, 05 Aug 2025 05:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754398212; x=1755003012; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H3jwKXNI4rekJ3bC3lnRJQ6Yd8MMqu4YCCAHk1Ogkeo=; b=iAYfSABasNuONTpySIzrG51dXeoKmIVmgxUJzAHaSntz+24GTXPwUaxQyEAxj/TRMK ZbsYlG1q5Pfkixonrh82xIqtgIW4nGzgJwmJz3562Tl1HVquWUfolzaLCZ/ynwaexBGV pqCwD16AiURjio+v+LftALvgnTPb4Jb0TKGF2k8+wzSk9slzmFOZ2QZwWlWG71c44Dxr 5s0r0qWptokvZ/+br+gTePS/utVi5dQ5B82RPyEhkdZfP2KRQMpjvS47l04C3094zh45 gZBPegH30YCWlxnrq/yQf/zGbs9fSmpau5EZBmKJoVMofsl/X500gcbrDR2O30KlcDmm 9k7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754398212; x=1755003012; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H3jwKXNI4rekJ3bC3lnRJQ6Yd8MMqu4YCCAHk1Ogkeo=; b=Kndbb6mtCTveQSP1nH7iIVfKkoi97s597e7HXw5HDhpeybYAIdQsvkNEh+IAMIFg+g YeSY+nirZKWiQ4YIMnOTB+eXstJS5SLpgucl2+mpnbhqkwyyFTvpho+OYsrIKpurUja9 MWTbUeSbaLxSyloYfP3ugCH6HW5nlwepdZDBByRGwI97UmLTot8jU3D8CbMTqOuV/7Iq FvgURq6CEQHMEFFMFbgHQDR4v/N8VNiUYIKX0f0K54QWFZ7P4niPYSpkQJBom7vgsoKh g0bByikIT32H8AjkDtoODCK0BVS3pPCX4Jg/lCcgZVttvOK60RtxZFZFmnsegAdUH5Lh 0dsg== X-Forwarded-Encrypted: i=1; AJvYcCXB9NlPT5GrAsQDSu/Ln511Jd43svISuZdR8mdI0Pwnt0w4L0MJ8G2ULwe7lBKYVQvGjXt5dpsDdK2zoIc=@vger.kernel.org X-Gm-Message-State: AOJu0YxwBClOhF7dNQn6xg7KFFzvOXweqivhkOgU0yjVpf9aEvX7mnYg NS8+Kw/GkunT2wBUzhwt5Hn5tgBJigMsiR+mbCWIBDiMLdJT3jz8rxaK/ARXVGniM8j5uQ== X-Gm-Gg: ASbGnculXoflfgyWjok46Pf1nwLQLtj5BW+qp5/5mLl7GWj8xEzJHxug/R5f7IbuSFb sgayLfaK8EPYP4oWmhL6oKQgtqpM91h5YpLK9Mc0+IPgQrKTXNrGuTwrOE5OBj7gS0GxkjvM499 wys1PVOgWecWdhojK3ZwUzyHhsWB2s3TvNdvGWm/Cdv7nOfp3uauqgPOr4qGu0M69OAHntd0X3T UVPYxjlATmi/yBPEn7aR6YHv6ezv7ubczeLfbK57k7wOkSRcZSQWrO2M+X5FR9ZHB/rxcSTzsze J3xd+DhsK0xAF8Tm/LME8DR98wS1kpYzgUhOQVS3SdZN6HbGUU7O4iL8kFWaVr2UxIZBqEXsXu5 0vqn1iafDoxuNIeaYNnXycbRC X-Google-Smtp-Source: AGHT+IG1gZ23yNGA0lZGdf1VO4KsVb63ecOdSFUH2BYkNIrPe3jl65xa3ewdqV99d3pNNix944eXvg== X-Received: by 2002:a05:6402:27c6:b0:614:fead:3d56 with SMTP id 4fb4d7f45d1cf-615e7195ffcmr12335815a12.32.1754398212403; Tue, 05 Aug 2025 05:50:12 -0700 (PDT) Received: from artem-pc.. ([88.201.168.202]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-615cc38aeccsm6811176a12.2.2025.08.05.05.50.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Aug 2025 05:50:11 -0700 (PDT) From: "a.shimko" To: linux-hwmon@vger.kernel.org Cc: "a.shimko" , linux-kernel@vger.kernel.org, sudeep.holla@arm.com, cristian.marussi@arm.com, jdelvare@suse.com, guenter.roeck@linux.com Subject: [PATCH 1/3] hwmon: scmi: Add default case with debug output Date: Tue, 5 Aug 2025 15:43:57 +0300 Message-ID: <20250805125003.12573-2-artyom.shimko@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250805125003.12573-1-artyom.shimko@gmail.com> References: <20250805125003.12573-1-artyom.shimko@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Artem Shimko Improve handling of unsupported sensor types: - Add default case in sensor type switch statement - Log skipped sensors with debug information including: * Sensor ID * Sensor type * Sensor name (if available) - Use rate-limited dev_dbg for safety Debug output format: "Skipping unsupported sensor ID:%d Type:%d (%s)" Signed-off-by: Artem Shimko --- drivers/hwmon/scmi-hwmon.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c index 364199b332c0..a3b5b5c0ec25 100644 --- a/drivers/hwmon/scmi-hwmon.c +++ b/drivers/hwmon/scmi-hwmon.c @@ -275,6 +275,10 @@ static int scmi_hwmon_probe(struct scmi_device *sdev) nr_count[type]++; break; } + default: + dev_dbg(dev, "Skipping unsupported sensor ID:%d Type:%d (%s)\n", + i, sensor->type, sensor->name ? sensor->name : "unnamed"); + continue; } =20 if (nr_count[hwmon_temp]) @@ -323,6 +327,10 @@ static int scmi_hwmon_probe(struct scmi_device *sdev) idx =3D --nr_count[type]; *(scmi_sensors->info[type] + idx) =3D sensor; break; + default: + dev_dbg(dev, "Skipping unsupported sensor ID:%d Type:%d (%s)\n", + i, sensor->type, sensor->name ? sensor->name : "unnamed"); + continue; } } =20 --=20 2.43.0 From nobody Sun Oct 5 10:44:41 2025 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1F5D2737F8; Tue, 5 Aug 2025 12:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754398219; cv=none; b=VoBqPybXbRgODnnWzQJKOCs1YWZ+qsXL0qNzf91p0JU1gSwMIbtkGh2TZW2y33GfJ86rqEeoePSK3tXDeL7v4c+wGvjLtH1WQ15qF97kicfWN8n+V06047gdY86L4azilD09bN8/5lFPGNKn3hx+lLrWzzX69ted1tSafmatXRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754398219; c=relaxed/simple; bh=wryQdfxH6n20JyHtj7sthlA3Q+wGAChxADhvmVnFQws=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YDEqqophDgbUFTYEUl1gOn5nq8I3ESUPwfV9rk47Mw6gkioNHOKOAsvamHtG0o6Jzma0Gn556d43bKZD3LB+uYZ3ieDw6Hr9QHPHfNCRTQwL/ND5ZI7XkEM+paAz8A/+tkEKqHEBBbtoWCtDHd1D51RsvC9SZ1+y5Wk+AX1nvXc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RY1S1xYk; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RY1S1xYk" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-61521cd7be2so6239295a12.3; Tue, 05 Aug 2025 05:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754398215; x=1755003015; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pAyT/OJTRuY2JWhPWK5JkMm7Zn06/WfS2T6aNl4VFA0=; b=RY1S1xYkNFFob0dLpqMQdyGfcTnoS2MW/GHhQJywHMufRjgp8D3/1idXSBosq7Fifb AHkdUQMsGZBYqWt456B1clteLKsPL3kZ3azc24LS2s1YRjxIQMMAEPTcIC8Aax5/16BJ x/M4u1OJ7Ul0myXsd9UesZDzZHrxK22urbAvlNIWx013K3oqiRgNfV5aZdENlbykCsT2 MF+MnY3B0MoRZaITDD+dN3JUn8iY1a9PLK3HgcyKoM3Do/S8UASLaWEEbZuYNtHV0b9H 8EEg3mH1SVqyh/+GwktlVnJtvfEj9RVtRBtzs9Zm7i9XZpvlf1iME8vlhV0Wr/ip5yWj okTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754398215; x=1755003015; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pAyT/OJTRuY2JWhPWK5JkMm7Zn06/WfS2T6aNl4VFA0=; b=J/SI1J1ldFCICpOlWT+PpsRUsB9LB+mGIH+X3kWNmXk/wKOqhdeVyab4CuCrp4ubtq m6QCVC5hK0LQ5Ymbd6K7Jx7iIGyi49le7ZEzt890gctBQGGkJoqbadSl6cct0xJPX4/G veND+6zrKnNGNRGqm63e7BH59y/aN3UXfBs9Pg1zXI5BqHPjoLuwyhNe3rHbKMjgPAQF 2ERQAxcDZuKQJ0H0/uBF7Gb1K4krhdSCAc1rA+e48UNG4zm6vpl/9Rw+9IHcVhWH3Lza rr0sK+FtJsoXR+9DfM89ntrKoGIQ9pCObwB5IUEW+fUD87UhTJkDnUlhqEv+/Or908Ao 6WtQ== X-Forwarded-Encrypted: i=1; AJvYcCWT+RqZS2bfP4RibA3HncJfhysPV5umTAiP3s8Ngfz626bGdl1EM7fX/WKZHylaaREFA8/kmCM5jR+uTX4=@vger.kernel.org X-Gm-Message-State: AOJu0YxoTqgc3Aft1WZHAZx/8D092cY0K7vz2RnTVzIhq6Sop0KFQ/0/ NIxz6z8d+3IrkZ5dh7ZufcLQbQ8llWqrCpccUlFGRiMl25zabdm92+sADNZCK0tEqOfCAw== X-Gm-Gg: ASbGncuFRfXD8YI0QlODx8cySOX4nCATk0X9tQVjIoNjFxa144tzVxXjiiCM8SlFESr 7TKsijrjfQmaDNEbrhhpG1/SU/E0dzdcdXcPDSCY8i9Fo+z12ArMTvWlCcnjwYlYkmPC/08dwwZ ysL61jBj/lmcSNTxp5vnDA09wKU//Gx2HLR/MAGh+9kk2xhvaVi28UuBcc/6hVPwGlXZ5EvXl7l QtHr+BTiDy5H2By+T5vhd9cqF8pbizeQfyKmdFSyS6pg52NzsrujLikDceh2TSftwTVjtfdKDt7 T5kbZ4li8zhNefqEcramAPnXAZbtq7qqvew0oecGoOADj4g6cAUYOP8IBFdyTWaTfC9oQpEPkEO 2kZdcZQoIX2ogU7zhrMLJe4a1 X-Google-Smtp-Source: AGHT+IG2FyCDtJis4mmbEWHDAMO7TiG6+EtqlP7SIyeHCQ9gfM9BIBrArRpPg92wZ3ClNfwqaIp+4A== X-Received: by 2002:aa7:d88e:0:b0:604:e33f:e5c0 with SMTP id 4fb4d7f45d1cf-615e71789d5mr9827945a12.30.1754398214593; Tue, 05 Aug 2025 05:50:14 -0700 (PDT) Received: from artem-pc.. ([88.201.168.202]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-615cc38aeccsm6811176a12.2.2025.08.05.05.50.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Aug 2025 05:50:14 -0700 (PDT) From: "a.shimko" To: linux-hwmon@vger.kernel.org Cc: "a.shimko" , linux-kernel@vger.kernel.org, sudeep.holla@arm.com, cristian.marussi@arm.com, jdelvare@suse.com, guenter.roeck@linux.com Subject: [PATCH 2/3] hwmon: scmi: Remove redundant devm_kfree call Date: Tue, 5 Aug 2025 15:43:58 +0300 Message-ID: <20250805125003.12573-3-artyom.shimko@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250805125003.12573-1-artyom.shimko@gmail.com> References: <20250805125003.12573-1-artyom.shimko@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Artem Shimko Fix potential resource management issue by: - Removing unnecessary devm_kfree() call in error path - Relying on devres automatic cleanup - Preserving all error handling logic Rationale: - Memory was allocated with devm_kzalloc() - devm_ thermal registration manages its own resources - Double-free could occur during probe failure Signed-off-by: Artem Shimko --- drivers/hwmon/scmi-hwmon.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c index a3b5b5c0ec25..d03174922e65 100644 --- a/drivers/hwmon/scmi-hwmon.c +++ b/drivers/hwmon/scmi-hwmon.c @@ -211,8 +211,6 @@ static int scmi_thermal_sensor_register(struct device *= dev, tzd =3D devm_thermal_of_zone_register(dev, th_sensor->info->id, th_sensor, &scmi_hwmon_thermal_ops); if (IS_ERR(tzd)) { - devm_kfree(dev, th_sensor); - if (PTR_ERR(tzd) !=3D -ENODEV) return PTR_ERR(tzd); =20 --=20 2.43.0 From nobody Sun Oct 5 10:44:41 2025 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3650527381C; Tue, 5 Aug 2025 12:50:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754398220; cv=none; b=BubTIqm/+ml+4HClA6Z+bNwtEWcMdSIAm9utFNjTfjqC75lL79eWWVWj8iArZITNWslh9m+GnbylNInuRESraAwZFTYOD35Wb23L95HMs9RyniK4QI9M6XQmmcEwEGYCckyEpcKl5HwalmuxI6tv5n2+jOiEQeoYT91bE273nrQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754398220; c=relaxed/simple; bh=jGSh/LkL0X52CDO3zdkc5x7ncFnzPCmvG4RFuADPvdQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FHgKRX+dDP3u8W0QD4+0y5EtHUMF8lcPDmjl0e4NO+xOf5R4W3quAwZDSgLkNZ9Hnz4qpQzZnWbO+Eod6v6FGhe9UtI+tfxzOMMULThAiYo7b9mXnnrfy7Tw/g+NWZi9/oe8qdZKJx9DFFLuuZcecxS39+jHTw5+k60Mng+Ta/0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G0EDpt81; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G0EDpt81" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6155e75a9acso8101446a12.0; Tue, 05 Aug 2025 05:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754398217; x=1755003017; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8yCdqk783l2O4FNUDcUuzsOge6j9py4J7WwVbdxRdP8=; b=G0EDpt81e3ui4hADtRA+AxAlTPaVonzPKKnDiMWQHvGuO51iPY2EFyxM/z5k05IpGc fUln7roDRLTXEPkQs5v27OPnVcnzfD5snG2jX1d7Bb19Xwq3HOnqQ2npqVszzGIroIlA zx7u9uJ7SfMWz6q0kiotFjeker5iEN9XIjptfPkEnWjWh3tO99QzivLF9lgwvQrXdJkY MoluITrofmn6nhRhLE2xaDiwAvl2NmR1tCmOrdTtnVHBgNEPBEAQafEgCZHa7HrLfMp8 4RtjC+/Ks2FDC3SZHQJbS3KpkZ+95FonGAD9OIXZfGEXP//zS9vvr/OaV6AQJ5B5f2ph tT7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754398217; x=1755003017; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8yCdqk783l2O4FNUDcUuzsOge6j9py4J7WwVbdxRdP8=; b=UYAGV37kXoEnDdvI7ZhA1ezWt70DzkgCJSdV9Rl+WxRIDEu3FFdRP1UhdWCVHzef94 UTMD+Vy4U27gL0a+8JNq3O3YVQp5yZTT6fsPAJVkVKLLEdnMNc9nR8PHyyvUfwZErqgN fARy7C00YtRgfjgfbHTzOQOpAj9plQWJiLuSdz1JL+8QQmWVGAmhxn1qPNh4Dup0nnUg /uQDAw9pAu2UC2dkhcpinrvmYA5puAl9fVY3WkDXnuDZwFh3wY9jTN6F/t9Bn4Jva8S8 EUF9/bJB4lRvHSheLl1Eb44rdjQGjXyRUL+TZebV2S7xRwzxabZc5UsO5b7uIJVrAIJZ izVA== X-Forwarded-Encrypted: i=1; AJvYcCVex0BfCyvVFR21bQjXcA67QBE9Iz0D2REgKCG4tYs5PclBkIVTVzdu4fOV084aiV+gf1Sjfwp6rQKT2kI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzw31mRxmxhlvmNvjr1puADgGg0HWhWhQKH/2+GXiCjDb1/UXtc rRe1YgSjP2JtfntHliV9YwaWNt1O9B8CEWDmP3QQdDmiMPLqOLkiDVAhqYT3fUpnI6fDLw== X-Gm-Gg: ASbGncu1eMup7+eh8KbRxqhc3ja70ItmM3dmjzc10E74E8hgmBEqWzOdzyT/IWBRaC4 KQBp7mdXZrtFzYqRxK1X+aSHGlp9vLlxvM7KpVuilCZ6dqgjS1USJJ2PK8FYIW/35g5pGeK3rIk QMnH0lpxm0ICBZ+xejcQe8fHvrbe8t8buYazIzqEAl7mU2hWDFJOOtciuvkZvgw9uCBdKUANizC +uXwhl1KjYeBwQloy9hxeqUksjiqypePgvHEf7MIAJwjC780hCmKFP/H3lcCj3zZItYrLd1M3Ca OYOM3z/xuXgM6q8z/RtqoFG8gpkm1mFgBTK48V318K+GGOAQrCrGCLWDNtdp1ODpdThFJxIa5fZ uspyJyvMDpnIIODu2DDwQ0rIL X-Google-Smtp-Source: AGHT+IGgVVg8/lqy8zr7O3W94feKtEZYw9quK1epE4thGB2ryISlPd8xGSLMn3qy9LQ2M8exu/AGoQ== X-Received: by 2002:a05:6402:270a:b0:615:cc03:e6ae with SMTP id 4fb4d7f45d1cf-615e6eb6a33mr11559383a12.6.1754398217189; Tue, 05 Aug 2025 05:50:17 -0700 (PDT) Received: from artem-pc.. ([88.201.168.202]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-615cc38aeccsm6811176a12.2.2025.08.05.05.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Aug 2025 05:50:16 -0700 (PDT) From: "a.shimko" To: linux-hwmon@vger.kernel.org Cc: "a.shimko" , linux-kernel@vger.kernel.org, sudeep.holla@arm.com, cristian.marussi@arm.com, jdelvare@suse.com, guenter.roeck@linux.com Subject: [PATCH 3/3] hwmon: scmi: Enhance error reporting with dev_err_probe Date: Tue, 5 Aug 2025 15:43:59 +0300 Message-ID: <20250805125003.12573-4-artyom.shimko@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250805125003.12573-1-artyom.shimko@gmail.com> References: <20250805125003.12573-1-artyom.shimko@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Artem Shimko Replace error returns with dev_err_probe() throughout driver: - Add descriptive error messages for all failure cases - Include relevant context (sensor IDs, types etc) - Standardize error reporting format Improved messages include: - "No valid sensor info for index %d" - "Failed to allocate channel info array" - "SCMI protocol ops not initialized" Signed-off-by: Artem Shimko --- drivers/hwmon/scmi-hwmon.c | 35 ++++++++++++++++++++++++----------- 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c index d03174922e65..081502418dfa 100644 --- a/drivers/hwmon/scmi-hwmon.c +++ b/drivers/hwmon/scmi-hwmon.c @@ -240,26 +240,36 @@ static int scmi_hwmon_probe(struct scmi_device *sdev) struct scmi_protocol_handle *ph; =20 if (!handle) - return -ENODEV; + return dev_err_probe(dev, -ENODEV, "SCMI device handle is NULL\n"); =20 sensor_ops =3D handle->devm_protocol_get(sdev, SCMI_PROTOCOL_SENSOR, &ph); - if (IS_ERR(sensor_ops)) - return PTR_ERR(sensor_ops); + if (IS_ERR_OR_NULL(sensor_ops)) { + if (IS_ERR(sensor_ops)) + return dev_err_probe(dev, PTR_ERR(sensor_ops), + "SCMI sensor protocol acquisition failed\n"); + return dev_err_probe(dev, -EPROTO, + "SCMI sensor protocol ops structure unexpectedly NULL\n"); + } + + if (!sensor_ops->info_get || !sensor_ops->count_get) + return dev_err_probe(dev, -ENOENT, + "SCMI sensor protocol operations are not initialized\n"); =20 nr_sensors =3D sensor_ops->count_get(ph); if (!nr_sensors) - return -EIO; + return dev_err_probe(dev, -EIO, "No sensors found\n"); =20 scmi_sensors =3D devm_kzalloc(dev, sizeof(*scmi_sensors), GFP_KERNEL); if (!scmi_sensors) - return -ENOMEM; + return dev_err_probe(dev, -ENOMEM, "Failed to allocate scmi_sensors stru= cture\n"); =20 scmi_sensors->ph =3D ph; =20 for (i =3D 0; i < nr_sensors; i++) { sensor =3D sensor_ops->info_get(ph, i); if (!sensor) - return -EINVAL; + return dev_err_probe(dev, -EINVAL, + "Failed to get sensor info for sensor %d\n", i); =20 switch (sensor->type) { case TEMPERATURE_C: @@ -285,12 +295,12 @@ static int scmi_hwmon_probe(struct scmi_device *sdev) scmi_hwmon_chan =3D devm_kcalloc(dev, nr_types, sizeof(*scmi_hwmon_chan), GFP_KERNEL); if (!scmi_hwmon_chan) - return -ENOMEM; + return dev_err_probe(dev, -ENOMEM, "Failed to allocate channel info arra= y\n"); =20 ptr_scmi_ci =3D devm_kcalloc(dev, nr_types + 1, sizeof(*ptr_scmi_ci), GFP_KERNEL); if (!ptr_scmi_ci) - return -ENOMEM; + return dev_err_probe(dev, -ENOMEM, "Failed to allocate channel info poin= ters\n"); =20 scmi_chip_info.info =3D ptr_scmi_ci; chip_info =3D &scmi_chip_info; @@ -307,7 +317,8 @@ static int scmi_hwmon_probe(struct scmi_device *sdev) devm_kcalloc(dev, nr_count[type], sizeof(*scmi_sensors->info), GFP_KERNEL); if (!scmi_sensors->info[type]) - return -ENOMEM; + return dev_err_probe(dev, -ENOMEM, + "Failed to allocate sensor info for type %d\n", type); } =20 for (i =3D nr_sensors - 1; i >=3D 0 ; i--) { @@ -336,7 +347,7 @@ static int scmi_hwmon_probe(struct scmi_device *sdev) scmi_sensors, chip_info, NULL); if (IS_ERR(hwdev)) - return PTR_ERR(hwdev); + return dev_err_probe(dev, PTR_ERR(hwdev), "Failed to register hwmon devi= ce\n"); =20 for (i =3D 0; i < nr_count_temp; i++) { int ret; @@ -352,7 +363,9 @@ static int scmi_hwmon_probe(struct scmi_device *sdev) ret =3D scmi_thermal_sensor_register(dev, ph, sensor); if (ret) { if (ret =3D=3D -ENOMEM) - return ret; + return dev_err_probe(dev, ret, + "Failed to allocate memory for thermal zone\n"); + dev_warn(dev, "Thermal zone misconfigured for %s. err=3D%d\n", sensor->name, ret); --=20 2.43.0