From nobody Sun Oct 5 10:49:28 2025 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013041.outbound.protection.outlook.com [52.101.127.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B0E61448D5 for ; Tue, 5 Aug 2025 07:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754380035; cv=fail; b=GYzvKgxNBa0KvO7wlZdONksgsQ4Zz1q7+YcA/G2gcoroa+nQW0j/CQu+LaXbwpD8kruQ/ygruzZxuBqwtZIzXVkxjNv2tPrBKccg5OCA4rhRnb6gEvY9A/c6K59uZqb5O7cvnHQ61cVAizJtgYjWETvGHRFqZpncTOHUydPte4U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754380035; c=relaxed/simple; bh=UJ+G1OuDNdhnlClSt/aM1tvM14Unp4VM3jDxzoXUgsQ=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=UYkd9bvBNeM87Gh6KDvnrZF62jJFDwugkCAodYZmR5EdwMwQezLhihruZlqUKlSOu4fIL1CmbvyqzC+pHc31zprLNn1bQYYMXJ7DfZBhw2j/ED4o4Z141YxafLjMCdsbAWu9XVW87j7iPZJ9syhie4H1SnfizXAuEFA2U1eHaQ8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=Gpu0tUZv; arc=fail smtp.client-ip=52.101.127.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="Gpu0tUZv" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ompc+GSMyLMNxKpyPzeAA2bOEMn8kTY03/RfmgHdGodRmHT3RkVzox7xZLVT6gfWhGjnY778848CSFJXvcvACZR03idujbajdaZul1u+ZM0aYaqbHQT0P5NfKLi60L8Krm+ydlpNedo0k5LmTXZmWyG3k8E6WBBzupRyqsVygN/MRTIj1G0NV1KHV9Gn8qVGMpb2sbtUDmpNnn20vJABeskrYs6UUkszC/JTzpz/1ciMzy8sXPxUjn/gnDJ/vh7S1D2R+H2TaI7U1+cWxBMbEDhJEVMVYK6QqGvFkPIgWCEmxKN2pS1LD8CxSqLc5W8OBe6gcvpB/JJedGDKals7/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IDAjcnbMjD/heZ6y0Ct4cKCslg+z001Ib2s8+PvATIE=; b=fYjxYRG56alGatL9DLaQVPfgVtaDksX4uqqT/mid12FHSDjJlhU/w0EggJP/bLSn20q0Jf+QfGzEQVVNXKvQDkdVIwyOSnVG7NZXMdE1y7VhWltnJpzvcF0uRrjbTX0FO5xaTM3pGqB6zsBmuAu06t74ULUAZdeMdlhx8BXQlbpixOF+8/p9pMc6izdW7XUPrNDLG+giykeUX9C4jRi8CzSK6y0GozOma+YSMjZr/HiOg0rPfZF23VBfISJfVj3cPHMW6BoJw0NcEtS9sPmKiz4Spi3e4/GUsYN4SV3MveFoOQDDyS5pl86LLPlrZs/ZtAWMsQrxbnSHKR2iMiQqUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IDAjcnbMjD/heZ6y0Ct4cKCslg+z001Ib2s8+PvATIE=; b=Gpu0tUZv1nRgEsj2Nz8N8lSddk1YEDUNkIuHRqc4mxPtaEKFIFrip9Mx9ofyZXVu2cWtH8KZ8lV4RGwL/NlGCV1F2HLh9FDmfbS3tAQSx03cXvCXqQk/wKa6HxmcqAOOIevAo2JNpoIsmG2/kwGbi54kVcPsKWtpgnwgtajt70P/lRC5SmbWJpzlFObWZdMgzrxKlLcU3RU+3WnFHLEqea5E4qEH105zXqXuShJQ51dOAfd8OcMuxCtuXoMRHcNDSNhh1sL3r9wxK0aXJwV3MdKvN/+NfhLVHHKby/SMgxWVce7/3dwHDUr2+yrqAfUrH7Qqa+rr9HDjCYm0L4zn3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) by OSQPR06MB7278.apcprd06.prod.outlook.com (2603:1096:604:29c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.20; Tue, 5 Aug 2025 07:47:11 +0000 Received: from SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6]) by SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6%5]) with mapi id 15.20.8989.020; Tue, 5 Aug 2025 07:47:11 +0000 From: Liao Yuanhong To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Liao Yuanhong , Nitin Gote , Krzysztof Niemiec , dri-devel@lists.freedesktop.org (open list:DRM DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/4] drm/i915/gem: Remove goto label that are only used once Date: Tue, 5 Aug 2025 15:46:16 +0800 Message-Id: <20250805074645.625911-2-liaoyuanhong@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250805074645.625911-1-liaoyuanhong@vivo.com> References: <20250805074645.625911-1-liaoyuanhong@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR02CA0017.apcprd02.prod.outlook.com (2603:1096:4:194::17) To SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5576:EE_|OSQPR06MB7278:EE_ X-MS-Office365-Filtering-Correlation-Id: ade31dad-4825-49bf-16c3-08ddd3f44939 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DCoKqnyh9vEfV5a7k4Pa1m+CyXuhqMMyYDjuUoKjpatLs8hysi0IBBC24Rap?= =?us-ascii?Q?I7nob2dvo9cu/rnQR4sVOym1xRJSUUHdO1IW4roYduzQre2mKA4cc7oiUSUp?= =?us-ascii?Q?DaYREVWUuEcRCJfsxUrEQv5iAVM2QNx6Cxs/GEbXFrbWb1TRBERLVRWthJ+4?= =?us-ascii?Q?OitiFXTqrzevuXG1UjbEP/HUd9mvIN5H0aYAls3UKeAxDHv14wvtcFTgy3uq?= =?us-ascii?Q?t3/JP3yOLDC/zPGsCvlU0F7ycgmuNZ80jQRKJoO1Yn2Efo2VV6RvV6+QlR96?= =?us-ascii?Q?OKNHl8A+Tqwpcpacdmx5Zq8wO8/Ga1gUgDbA8G/voHzMWDb6wPaRgOLFfwUI?= =?us-ascii?Q?Y8GHwPVUwAUpAOMNAsPgHIaVftMclXh3biyu6Nq4VZ8yh0vSnVrtPLJWxmn8?= =?us-ascii?Q?uNhswIXK+BT1j+9mYt+5EF78ZocuRKOnmSfGsgyhXkGPxayakeOW6jVjOCMO?= =?us-ascii?Q?uNiumgRbx3fxiiIQzkKjBIzOY5jzwaeQ6Pu7dkRMCO6ilLddjPS0CdfGUUbc?= =?us-ascii?Q?qpk0jynywqEKj7ofdb9WI3VhrnW5RfceQG5+IaM2HgnV5FXBVBFt3twZMrr8?= =?us-ascii?Q?txA3EnCuPHmcN1zXTm0yu8FBdJJxUdrtCk26IAtIdIMAaJoWJm7DqA37em8/?= =?us-ascii?Q?Hg4IZqrpKnYnqBi8lMmfxQNRAhXttM7gCxO4QMOipYf4sU2js7+8zi+BcnXN?= =?us-ascii?Q?pFyT6NPb1Efb2Thv+4Un9M9VU4nGJNFER8zfVRLHp4H0FYBTfyNs3PfoDg0B?= =?us-ascii?Q?FCdoIykBjk/n4EQcYHF0feFgSqEnirOF2goMAMXtHaZt87ifO0hlL/588nEH?= =?us-ascii?Q?tzueyOCM2iLsA7A9MF1muOQFCxl+h8MYU3K7tg849yvdQkg+vq2qPacGLoFS?= =?us-ascii?Q?8SircoiLnzAb7b8cXRsdc2OWz49l0MfeL+FVWiPlGbtzZYUC82RdvzijZ7Zm?= =?us-ascii?Q?bHzxSuiq9+TPMLGyLkDtwGLMinyhFoLzWZjMJ/76kIvcjd5SYgwhxUiRWqhJ?= =?us-ascii?Q?SCUVoHP0lIWIZ/f/pEVwktRm+zwIffR18jhG1xr48T0EaxeLcUMgMq86VjnD?= =?us-ascii?Q?RHj5nFDnfkZnehzs2PDVP3E+qxaaY8wZvDUlZ/UyKSCr/6V9QUDBSyJ6k1tE?= =?us-ascii?Q?c0yjuoYLa9w3y4T702Sp3++KKwztk4V1iWqTJJkS1YhILoDGIAVQFy6V6/Uo?= =?us-ascii?Q?BeJfKDj6gL1CCfUFjDsGF2kDqZ1O8o/4yY3k2qrWv66hYijQAsTIw54lFuci?= =?us-ascii?Q?4zbwsKHpi2EEMdfT48TiBePosRnndqO6+hZLUhz3cWYxSsRDPWmkNUdbAb2+?= =?us-ascii?Q?+bCZ4JFs6Io2Nzs6DopYhFedgZdF3Fy7NqHZCDZtwGF/wFzUMk2shrmtshEM?= =?us-ascii?Q?a7XMi8Vk2ndg/iRgFULW4PO5DgMVwfE24E0qmLWf7T/Mq/7yayC8z5huMSvI?= =?us-ascii?Q?5WOiI4KxQpTVUWzczCOgNAZZRdg+dhhXRvz2S4pwcvoJjxoBGQ+x36pj3wci?= =?us-ascii?Q?h0rnmUU1CX8qV0Y=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5576.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3rQ6/YoUN+nj6yKX9obKT5pO0w19e7tpRbOmQ75ZlSP4ooIIsDs+pw2Q+BUw?= =?us-ascii?Q?3TFAoXOKan1KIUrD2HGmGm2TTQcssiNwwwXliHmxRDI4VL6rXuhuoq7heDLm?= =?us-ascii?Q?3TfuT1weYHGm2+YMRAn+rgmgJRPvfha1z/ygnu0wxGc47dytvf3/LeI1aIq/?= =?us-ascii?Q?wgMToAYFJ7sDyti5gM7qdubvdnq8DYU0Ah2ukWRooGelejqggmrYIxxJ0zAm?= =?us-ascii?Q?mADNkhqxc0On4LnFEOFqt0TbEbCzs5lH+AHPgKKA4dy/GB1NqURBtmfG3fDC?= =?us-ascii?Q?Wr7+3HL3m1d5H5GeIzmt57NtwPayRxCkrswM6AnV7Or7oFHJ9HBx9WR0VhMf?= =?us-ascii?Q?pG3La9ulwj1S+pK12fyXUAXswXsXKzi5lNzzHhzPgh6mZGyoUK6mIA7GMWGs?= =?us-ascii?Q?zARNkH0q0JVrTn8NS7qcLVZcXkTyoeomcPOmdzZQfaC/tldmOPu/EvUY70/N?= =?us-ascii?Q?XY782LoKxfDbbQY4Bjq5x/8mTm1LM5wfwfMYXdxZiVPDLD01brDDU/WMYlsC?= =?us-ascii?Q?qCPsygQufKJepF8C4znFTaErMR0NN75ArI9vWtxoUfDVV88Wg9CQWjekhqIp?= =?us-ascii?Q?YJPoi4zoKmGk8FfmFypEr1x4jDHwEIMfJJokfsSp+8JiTWWgxAN/DZFUFSGe?= =?us-ascii?Q?KcD8YWHe5j0TcVduVY8pgjL4Jb7shWm5LnIY1kkGDPOD4Qghsoo0im1hculo?= =?us-ascii?Q?zlF9LBhWEryLF0hXPrZ7152Rh96YwDc8ASDBn5PP7dscbPQuYJ0ly6U5ijdU?= =?us-ascii?Q?ZrVN48N/iK0fT9leiD2ojuFUPrpDcpxmtdQESyGB+OjLkb+U/sP9LPypyEpQ?= =?us-ascii?Q?WIQztgxQyw8qN9WuzaDlxUnQr9yZJ1XOi89D8f04DmtBbdqnMnwZT1tvc7pf?= =?us-ascii?Q?dlFlkZm2rDLMCdSM4lXfPgG+vPErVEyrte0XVZ9yxKrDC1JluQ8XpSREgb6m?= =?us-ascii?Q?g5i/pBYPkIWXz0lmpJPep5ecOqYUNrhMLtbY0RYVX0R26VYPbV9EOSHodWlT?= =?us-ascii?Q?1FqM24oPMwdmxUru2Yw2/XxcGugHSIqwqjFmNcDIzYCk3Z241AANgsa2luzx?= =?us-ascii?Q?ptnk7e7AkVwy+j3xJdNXrIGAsjoHlaYjzsISC9HM+jLSxsQW1lubU/ZbPw6H?= =?us-ascii?Q?lj3LrpWfHszW0YjBMs8ZqjW+4AcFCvcZsdTFPlZERJzTUESLcRLQ9RmjqvSB?= =?us-ascii?Q?YYYEsm95aXWaUfURh7eSQpwDgtj8KgIa/blfRwW96HFoB2TFGmFfssFYLyUX?= =?us-ascii?Q?QnjXUdptIqpShVQvk6G5O5OkapLW8vW5pxvq31vItcbZPDtiRI1PG7vjD271?= =?us-ascii?Q?xmnfKBjL9ynP2wooTy7zoO97TTdSKZaWAWDhesNFOlTMMLbGWiRsk8M7gual?= =?us-ascii?Q?xbhb2aESweHOeOy4D/xuwLXT6wERNJo8k7inX3v7IGMIF5s6oSHMxVvbvPqf?= =?us-ascii?Q?dEIdOd1oF4G0HYBxmqBJMyzkgBZ/bRfFGYBExn0NGEo4k0atH/UJbmNKAMf9?= =?us-ascii?Q?Ae1VxH68l4RHwv1lXBdYbpR9mU1TuYYjou03T6chcQlfMKZTa3LpPB0oQVVP?= =?us-ascii?Q?6CGrWAPsEYv7/pq4YIJu3etwRiXnU3HIxqwqbuBi?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: ade31dad-4825-49bf-16c3-08ddd3f44939 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5576.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2025 07:47:11.2924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MC44k6YF4Nsd/JMvCWNqnpWifk82c/9Fh52suTIuaiTk9CzzU7owiNUncAu9KAfhmWLlG/xLS5Igv0ZSnPGwjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSQPR06MB7278 Content-Type: text/plain; charset="utf-8" Remove unnecessary goto labels to improve code readability.=20 Signed-off-by: Liao Yuanhong --- drivers/gpu/drm/i915/gem/i915_gem_region.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_region.c b/drivers/gpu/drm/i= 915/gem/i915_gem_region.c index 636768d0f57e..539d1716d454 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_region.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_region.c @@ -92,15 +92,13 @@ __i915_gem_object_create_region(struct intel_memory_reg= ion *mem, flags |=3D I915_BO_ALLOC_PM_EARLY; =20 err =3D mem->ops->init_object(mem, obj, offset, size, page_size, flags); - if (err) - goto err_object_free; + if (err) { + i915_gem_object_free(obj); + return ERR_PTR(err); + } =20 trace_i915_gem_object_create(obj); return obj; - -err_object_free: - i915_gem_object_free(obj); - return ERR_PTR(err); } =20 struct drm_i915_gem_object * --=20 2.34.1 From nobody Sun Oct 5 10:49:28 2025 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012026.outbound.protection.outlook.com [52.101.126.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 432F21448D5 for ; Tue, 5 Aug 2025 07:47:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754380044; cv=fail; b=b+KindUcDywH2Xmo41V5N2wf4WeQGFNF4S58b3DjXBh8pSMdagC+ZdocePeQSkabuIHbNMDBRMJR2l5lJWdgvubZV4QMOqaPzSh1GCbUClyjq07ea/SjzjMf6VCWL1R8XTRpwBR0zyJCckO5WNQ3Vc9Oo/QJqAoqBJWWpLAGfY8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754380044; c=relaxed/simple; bh=HHQuO88GsL7xh5VkLhxTMbDnulew9zRP4wCpCf8Bwiw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=HyIOVQyqw35/qRBlz7of7rOa5Z6TqZQ4Q9ZJ1TBDc17sgw08b4kAPTYt16mtjGAJmBnb95sA2DC6Wzx7ox6uHreaO6RrZEqwqDkLvhig1ZV9iqQ7uwvgHxHtY52KDMr0YcuC1gz9TEFKf++90exUWd45OWr5S+fjMCNS3UmtqwA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=es8kjz9u; arc=fail smtp.client-ip=52.101.126.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="es8kjz9u" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tRX88L4XX/yHcFYEumSSMThLxZmOrzLIAJg+GN3jfY65UCNDvNLh+p0xEPFYdAflmt79/uJQyRrBID3D4Tgd5QLJQFHJ0yHAJDsMyCFu2tITKgnU4bPx866BMWXenO5RAhz2k9jzecFN0Rxag3IjsPitxf2Bh+JBY96oQ8gSD1Fzp5pBT65/Zk3W0bN7CGoCqM6D7MtH9EIYoUqWvkXXw/zqFepYN0pvV1IBbdznPKp8xCsQJKspKm4oqmxNYLwkJiRJ4omOYGSOGR5vo13GQjDrRyakjWk63ZU/7diVW1VkyCixaDgarpXUMEMt/t0UQX85gi3egbnryzWX5+5aJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jcZqAzlqgrzi3B/v9qwDniuUNoyXhfWi2Tp19P4ZKaU=; b=fWWF4BBP0M3TnvHjA6m1m4qCAADTxEQCNvd5Z1GCA1buQQYaRaO7DtC4sTjSpVttuj55yQsypRQtE7cVVomp2pjP/0ooiynAvLnPyqQLQqi8iDTA8r33mV7D3MiunGF3hd893gOqSa/eBLSw0G9npOvrpI2LZ3klUHHb8D/XTHAdHTjB5xjf1qpnv5mWzGQ3LoWnUNX9yopqO0nzfxsGxnWP6iMreLa5pTQubWKHCWmZlIHFiboLLg28R5/QfDSSNOreZ9CWp3FRxjknKX3cnX9frDse6FifTcq+uwXZ7/2vqReeZUGlSWYtIAbgaZgzhLuAn2fvzgYG7K4Iv9DlLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jcZqAzlqgrzi3B/v9qwDniuUNoyXhfWi2Tp19P4ZKaU=; b=es8kjz9ucp1rrBI7TaoKmMXcfYC8G4zUupwMmKgSitZ7Mp3KzhGZDib50EhZrjP9AiEo/Vx732+feEt4WmRD5hLFFRB3cJyc1OeItnMGVdZugsAN2QVW4s5lYC0aDwQpl7EvQGlJESP9uHzZLpkjTcGpzPt8aRy9UUEEHrAIuxVMzpxzxnChybmRm0tkm6O/bX+APFWjcJBHo2JeuYXQ0d5c7TDJzDidrZI85gfn+766eHWtCd3H/4AYJ4/WVx1BeTA7yWZNnNT9pfY+8f+vXFN90EcVh6IJdvKfBdfHyfHfzgwRkNOM2gJjrdnv67aX8rWL9iiSm1WuJk0jOFkRsw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) by KU2PPF022ABE738.apcprd06.prod.outlook.com (2603:1096:d18::484) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.21; Tue, 5 Aug 2025 07:47:18 +0000 Received: from SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6]) by SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6%5]) with mapi id 15.20.8989.020; Tue, 5 Aug 2025 07:47:17 +0000 From: Liao Yuanhong To: Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org (open list:DRM DRIVERS), linux-kernel@vger.kernel.org (open list) Cc: Liao Yuanhong Subject: [PATCH 2/4] drm/imagination: Remove goto label that are only used once Date: Tue, 5 Aug 2025 15:46:17 +0800 Message-Id: <20250805074645.625911-3-liaoyuanhong@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250805074645.625911-1-liaoyuanhong@vivo.com> References: <20250805074645.625911-1-liaoyuanhong@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR02CA0017.apcprd02.prod.outlook.com (2603:1096:4:194::17) To SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5576:EE_|KU2PPF022ABE738:EE_ X-MS-Office365-Filtering-Correlation-Id: 75f7541d-064e-4b7f-7aff-08ddd3f44d35 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Ni8rKELe4pR6lpb/wAphZzDqve7Q45uLirwfcLFGWv8qk27B5NfAp3vMO9UC?= =?us-ascii?Q?YZOujMmoo3JFjOEgpKeSI62qJs6fisn3vqpMSD1N/CTbY9sJOH0U9A2EULG5?= =?us-ascii?Q?wBDWP/U1MtiRKPSGvANB7wEL+LQusdyf90MkOGdS5mu5zgpesFi+UmueGmeI?= =?us-ascii?Q?CH4DbQDktrBiGd8Izv4MrQ8JCAJWdgrNK1wM+OrRwRupVEJuwcXpuk9kB3L0?= =?us-ascii?Q?EnT3TJDX+VqbLpOoK9b4CUVummytlwXKtTkypK66F/QH3p/hDTnuJyoxMRZN?= =?us-ascii?Q?CZezjNfcPfxXzS+q6r/dqFSEt2ZJhhIC636xqz3Azjhh9/5Zr8PRW3Un2cAL?= =?us-ascii?Q?UGe+4GjE8CD8TbYPM7Va0Sti9qrhdU9ZkateRtml4CzuXJLek+GjYZbyrP6Z?= =?us-ascii?Q?GzOmfZwUzBBvoYQ18AXKN9vpE4e9PuKADGeTM64jqAQdLtSCaAl15wPMkdBB?= =?us-ascii?Q?VGDKmvfoeiuCFasQBPkwqBrIn6x3swdEEPt73pdzxotoD0WpGa5g6jow5Y3m?= =?us-ascii?Q?xer/uPupgnsd5T1XJOttdtX3a/LGvVL6uewJaJvrx8/As1LNXnKPFXNxICEW?= =?us-ascii?Q?DS5cJNhwF8e+k0ObdzKoTyWbg8IUXWjXmXIUE41ldC7gJfFlNB6EXh4wH6xk?= =?us-ascii?Q?7QPyfXwaGXYfFO+5KjhB1GuN+LOL7ZqTTCwwipFM830BeMBSrPU5lJEGoYAJ?= =?us-ascii?Q?I5CJnBF7bWs6z97OewWnnlS+7W/rHat/Wi7t30jDa4tPYAAQWikl3D4kduT2?= =?us-ascii?Q?9BsVo62MCsSH180UZ0dbTQHiPllKAOPiJhyw+uRpyLPpJ0kSb88BpMhYgrQF?= =?us-ascii?Q?IAUmpaZUz3EFBdSMx+c1IUCUsrkEcpjLQ+7J2F3eM+WCO/dbdgmZT/Yx8co/?= =?us-ascii?Q?9RzEed183PKV7QGtHYx+ryrAnFbosCAtEWJd9EPQFNVZAhyOGhfB+uIGVx1+?= =?us-ascii?Q?QmwMbOPQm9P2j+bc/CHBj76EboDPat+flKzjderd/GgSyAMRxQddrpcIcuU8?= =?us-ascii?Q?j9CJOe6d77jRrOeFXX/kFfhu4CG0Pr2RE2L7A5crgKnrcDAWbwTBFbF2Aq9u?= =?us-ascii?Q?ZJTrTxtzkijI3zcXogvVSYb4CofQDcZZ+6B++4Tk8vyVNFAEub69DE6ipCUX?= =?us-ascii?Q?yZHDpRw8uv+zxbLXsTOlacm+r9Ojn02qLrwcDcIGItn56iIai/m0R8vTDOgn?= =?us-ascii?Q?ZTyCCM858YhIqo+p2YtTiadnC4b9kGtKEKAtp7A0vRPrgXYj2R8coZZzf2SW?= =?us-ascii?Q?O6JegJEWuyhpSEGVidBIpHPTc381KP6gPPzLSjx1ImkrxoqMuD1kcCrMZCMJ?= =?us-ascii?Q?cQdlJ+TgwE+aBWJjstoBj75VAP0N49ijVhhheFgM5mYunlrlDMkLEqXtVWIo?= =?us-ascii?Q?t6OSFl9de0fWQjLmUcdil7ZuZHwkxM6LAzUTJP6mpJRm1KR+mM9iVgJt+OhL?= =?us-ascii?Q?CZv5+pKWwnHjC7o9d0LYUnBsCt7KKLaE9gPocOE7QlGmwYP3TJ0iYQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5576.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XHMpiabMfwIkSIOw6deGSc50LBZ1eNQ/lXxGteLgSiIdD+a4WrjVj3fU03X6?= =?us-ascii?Q?x4OTi5dM+5JAQeqiXqwvMwuLt+adnj8NmGa/4xtzaY0VhJ6wghflzPY2FV+a?= =?us-ascii?Q?0OvjTC2rKBfGKe4HwORQeaeeCmTe7oMBTAqM/4CqckV9gGpaXO5zgqzI+r5b?= =?us-ascii?Q?QwEpe4iU+XRlybTUyDtrIxjaRqno7ZUgZAVanqdJhwSsLtiEu6vImzwj6R3s?= =?us-ascii?Q?4gIl6gBqJ4XBWSsBvp+ZgyHtqH83q4D8GmzzGhYekqAPXTwKVoUd9bNn/y9K?= =?us-ascii?Q?SSTsl0xdevjtY+adIF9c8JNvj/06/3MX+8JMvRKxFI32Aq8zkR7pKC6zkis2?= =?us-ascii?Q?nXuXTsyc5pOX8cZ13XiwCQhNgzn+jgdO8b1kQua6HtIwDRhdU0i+8JCwuNRS?= =?us-ascii?Q?aOlaodr3jTsokeA2qRVnfGLJ/geJHU8EBif1ocpVYUJWAQEkBfFzar7J7kXH?= =?us-ascii?Q?zQ2liIAFFf5xdHNx+b66YbYSnx1c+8HiDZvVKpY6UJKwW/lNn4f8cZjFp8+Q?= =?us-ascii?Q?4XVAhXKkANpdhD+cxPTmRPEJQNsEkfqGN7qtx5LojvXXdIacnEjPn6XSxHVr?= =?us-ascii?Q?C2uxfhbwaCojfLgy6AzN2OQFD6Nlftsq/D2KvMDoLmapLgtKj13gBhjUbQUv?= =?us-ascii?Q?Ni0cU7gR4ajpB3L+i2WZmhiJVIq/sg4R6HeUzKhSobD4EdKHgUZKAwSQK6fl?= =?us-ascii?Q?3teWOhMML5t4//cyNArZbzuKxygL2EwLPK5UCj0oPxNJsyagt4vS+xbttFB5?= =?us-ascii?Q?LVTdZSlYE/QMNdKghjV2gJZvqMnlVdEoikUnEidtGuBahq/oPMsq49cge3FG?= =?us-ascii?Q?2lKFjexVAQGt45jjxkFI+69umAb6jPH38fCItu7nqmmoxOJ3fSwA0hT4FF+R?= =?us-ascii?Q?YK0eaI60nQPwgz9k4/XMdhp1Hzure3qTTtQ0/9EJwB2+8panf8iyGGgLU1Di?= =?us-ascii?Q?O6OdfqdU0nJvAmPQacO9N11L1SV55RLMq4+/cVYzAYQ8gRncYWyIztfTO2+w?= =?us-ascii?Q?NjcegSRZ/AeTvaUe8huRb8XqP0jIMyE/AWKPef9sK9Df9YFEaKXNJ0/g+aZV?= =?us-ascii?Q?gygg5Xc0QOASa9jcM5n46dlR75JSRN3lEDQrwQZJLgaZrYyVs4saS7JoYIdT?= =?us-ascii?Q?f5Q0S0jsz608ReOBhMmXLfD/Q9ke5hHYPPzjbgStca8YgbuR0lJtk61ZDDL9?= =?us-ascii?Q?Va4+OU+T9Xmc+6XF/xj2FOwUsDIBwHkuzBBsPxTU1me3z04FWl8b4F5BwqjE?= =?us-ascii?Q?vNqX3Se1Zcl6qCAwEpeSj6dFmiEvQSy8SsA1qM2rOl67LD7upzw/2oum8h6v?= =?us-ascii?Q?1FYRXOm7GsPWmUBqAynP4xgru0qKPL2B+IWZdj1qwIzuHuqCHda2lxPkYIUl?= =?us-ascii?Q?iXm7mFI8pj4gVsftfAfyHIzQL1riwD5a9Z3mQBDP18r/E5zQxIIUllwKVih2?= =?us-ascii?Q?zhUrHMZzQCj5dYuxu1IvcJEnODsNA/S75ybz+er1j5fhxQlLlURpqnlZ+FFC?= =?us-ascii?Q?jD5/pKTRwe0yZhosCsiK3DSFm2GkdOGyOImpKjqQlW6LdoGaSjibXvYqyiv/?= =?us-ascii?Q?34EWAKSJTd21LmPKCjxwGNjFD2dmloX8S1ySDTTV?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75f7541d-064e-4b7f-7aff-08ddd3f44d35 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5576.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2025 07:47:17.9085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: effjlxQsvSkmmsFd2Rfgl3fIyWqmY3GADkPmcSEO6FAsciSXjdJkgk6woRg1/I751PLJSW69lj6ARefdLbM3RQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KU2PPF022ABE738 Content-Type: text/plain; charset="utf-8" Remove unnecessary goto labels to improve code readability.=20 Signed-off-by: Liao Yuanhong --- drivers/gpu/drm/imagination/pvr_cccb.c | 8 ++------ drivers/gpu/drm/imagination/pvr_fw_startstop.c | 13 +++++-------- 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/imagination/pvr_cccb.c b/drivers/gpu/drm/imagi= nation/pvr_cccb.c index 4fabab41bea7..ed7e1c8fb71b 100644 --- a/drivers/gpu/drm/imagination/pvr_cccb.c +++ b/drivers/gpu/drm/imagination/pvr_cccb.c @@ -69,18 +69,14 @@ pvr_cccb_init(struct pvr_device *pvr_dev, struct pvr_cc= cb *pvr_cccb, NULL, NULL, &pvr_cccb->cccb_obj); if (IS_ERR(pvr_cccb->cccb)) { err =3D PTR_ERR(pvr_cccb->cccb); - goto err_free_ctrl; + pvr_fw_object_unmap_and_destroy(pvr_cccb->ctrl_obj); + return err; } =20 pvr_fw_object_get_fw_addr(pvr_cccb->ctrl_obj, &pvr_cccb->ctrl_fw_addr); pvr_fw_object_get_fw_addr(pvr_cccb->cccb_obj, &pvr_cccb->cccb_fw_addr); =20 return 0; - -err_free_ctrl: - pvr_fw_object_unmap_and_destroy(pvr_cccb->ctrl_obj); - - return err; } =20 /** diff --git a/drivers/gpu/drm/imagination/pvr_fw_startstop.c b/drivers/gpu/d= rm/imagination/pvr_fw_startstop.c index dcbb9903e791..4921acd4e757 100644 --- a/drivers/gpu/drm/imagination/pvr_fw_startstop.c +++ b/drivers/gpu/drm/imagination/pvr_fw_startstop.c @@ -155,8 +155,11 @@ pvr_fw_start(struct pvr_device *pvr_dev) (void)pvr_cr_read64(pvr_dev, ROGUE_CR_SOFT_RESET2); =20 err =3D rogue_slc_init(pvr_dev); - if (err) - goto err_reset; + if (err) { + /* Put everything back into soft-reset. */ + pvr_cr_write64(pvr_dev, ROGUE_CR_SOFT_RESET, soft_reset_mask); + return err; + } =20 /* Initialise Firmware wrapper. */ pvr_dev->fw_dev.defs->wrapper_init(pvr_dev); @@ -185,12 +188,6 @@ pvr_fw_start(struct pvr_device *pvr_dev) } =20 return 0; - -err_reset: - /* Put everything back into soft-reset. */ - pvr_cr_write64(pvr_dev, ROGUE_CR_SOFT_RESET, soft_reset_mask); - - return err; } =20 /** --=20 2.34.1 From nobody Sun Oct 5 10:49:28 2025 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012026.outbound.protection.outlook.com [52.101.126.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51D90239E97 for ; Tue, 5 Aug 2025 07:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754380047; cv=fail; b=mk1qg8hLwPrgjRpJ5extGpUol2DJgy1VoQcG+laoROSdHS01ZtPw6r7Evvot9LsH2VHJtUlxsYei/HRodbonqI3UizFhLANLVvNOaMtIa1JuD84T3wfqSh72tmYQjKm5MpR2eMWvp3j1GAfXmBcrQ97lHv4c5AjYhC99MIYUJCo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754380047; c=relaxed/simple; bh=Wu8IXNw4HRGFGIsR98bgstojdIRjsNtRX8ovBdoLf28=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=lpOJDOGz6oGrhINEYqdjamfvxe4Nzj6QSDcQ3MYxSVoS3jQ5ILRVN2UnKsbv6QADokn116eAOU5Y0hwB3ifuEVW8x/JcHMeYz/oC5Qw2L7g4gvY31Fg9ohdlHNwwiwIjBzKobtiL0OFduHrogiYoOABeMKeHtuzMX2T1+JwtQag= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=KFugIkEH; arc=fail smtp.client-ip=52.101.126.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="KFugIkEH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XUP6t/cGf5PRtvLDeHnOCUe4gkKEcPl3IrwSV1Lnib+bFn3w4ebMoWdewRlCTjQgMF8yOmZsKZ0rVCzOp8Q4mjAH1rbpzQGML1uwIt2ZgL5+EGaGgfjIslnoXdsusHE+YD3r9fdmWJsWWwW4mZChywqy7jXHb4Hw/Fvgnq03rUSXE+4aPzEeY7h0wGJTT/gVkMPYNPUYfLibl2rE6cXpSbCCbOYiZg+XfmDq81l9eiW/WbyeVRmp+SP+CJPL7C8V4SuNg5ztxLz4HvrmcZcAS32PDpLf7C0Hn0h/gFRdbDbal8QNMNBLZ9ILWMalybhrRfVFw46Gzwz6VCVCiTqaFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cubuDjsic/p/WxTvs2JbonkfRAnjZVHQX/vvR5slJRk=; b=gPHuvW3Ut66p4fsVToE7VWZt0B7XI2Lcf9duBPnTuxjEn0x1UTVT6QlxeB69j4i+0Uz08A5XIGFLm/XX64QznfgR3lq9+wCqSsHgsTTYQfBxPkMESqkRMZhsUugZaBFfcRyhHqhp5U6Ye07pj2qWlQRroVijZgU18Ku6bnt19qjfANRSJvVv58mIC1T6woq8fck5DXEClzjrdDIoJkh0NULSj+DaoZSIxEkFLwVRvExX8Y9mGiMV0BslWUratBpIkP8POvb3q0Lv+c0kWlrXPePaulJi6qRkzgr7rfSPLYKE1EZHeiIJpDhv/VKfDDH4qVdwF5WwBqUt1FwXPFI3mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cubuDjsic/p/WxTvs2JbonkfRAnjZVHQX/vvR5slJRk=; b=KFugIkEH3BODi3880BjSVkfLaGZHOXJie/QgO7FLBNNNInBb1RaAYkWXmcsWDB3qQutdw9vqK3vcXGVcZC7oV5JCr5pmUgN7eBRbHCNmdmJtpn/Fx5kd1sFiCDOnhMMzxoly6FKraVvoOpg4QgC+Qp72nQb8mK4glBSqsPKphjUTcRxQ2BfLidn1emyh0/rEjv30xfD5B4hZJm/C8ZZvPWsW/T69fNSni94Up7sxByvhDipD/Ngz5KKcs1TZ687n4OX1wxduA70kcsNPoA9xxgoGZVAtFzvvad1yGsbg7aNCmpb7T6VEYpV1brUHOgPwLXNka1Bn0lsJOrqtXHLCHQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) by KU2PPF022ABE738.apcprd06.prod.outlook.com (2603:1096:d18::484) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.21; Tue, 5 Aug 2025 07:47:23 +0000 Received: from SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6]) by SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6%5]) with mapi id 15.20.8989.020; Tue, 5 Aug 2025 07:47:23 +0000 From: Liao Yuanhong To: Laurentiu Palcu , Lucas Stach , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dri-devel@lists.freedesktop.org (open list:NXP i.MX 8MQ DCSS DRIVER), imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Cc: Liao Yuanhong Subject: [PATCH 3/4] drm/imx: Remove goto label that are only used once Date: Tue, 5 Aug 2025 15:46:18 +0800 Message-Id: <20250805074645.625911-4-liaoyuanhong@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250805074645.625911-1-liaoyuanhong@vivo.com> References: <20250805074645.625911-1-liaoyuanhong@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR02CA0017.apcprd02.prod.outlook.com (2603:1096:4:194::17) To SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5576:EE_|KU2PPF022ABE738:EE_ X-MS-Office365-Filtering-Correlation-Id: b32027af-10e3-49e1-8da3-08ddd3f45038 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|52116014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FVRtc1Q2vgNYLIlXd+F6wdU+Qnab9W/fluFnxmjs5EdJWi5Pu9mT21cM3DRD?= =?us-ascii?Q?QotmbIYkrnpA1qQ7oET2ycJWfJJ6A/H57hHXDSt1Q/yXTssCbxMFJOgjL8po?= =?us-ascii?Q?TSRJHQn1XZ5oAPbB1YLaEB0spIubzXWt0mLfr47oCjXImS/SPWQuetPVk6fe?= =?us-ascii?Q?7IT/iCdMNxIuKv+raCsei5oPOS+koRMFbV0fN+2TO8wuMelpyJBN/kYasOCt?= =?us-ascii?Q?VyrHyy2NdrdUkeyKpIYRtdTYB4yUwwvJ5Fwq23rDxRQV4zk65SL/BR1wzdTa?= =?us-ascii?Q?dbe7Sjk0OeadIOvHMHSnjfJL8l6BBPN/d53JlUlbLqtSEdlJCB2KCtcSXifp?= =?us-ascii?Q?3/0AknKJ9uQgQDfnP9Kg6xx//wJlVRtpTu0BO3pjbP4fcAO3Ht6RMAA0zVaB?= =?us-ascii?Q?SJajMRXJuYKhwQlW2rKgX+/MX06wy+yPURbEj4XGc8j7fyINgsRcubwWeZ4D?= =?us-ascii?Q?z6SY/KTisAEGYNhWl0xvOKgk9HynoRVIW3yt/hdOoFoxw/nw9bpazrJfb5ep?= =?us-ascii?Q?QjIfJKhfx3ZK14fB8MBtZ7+hxQOMG1Zx621/TQ5KGgHDcz+GbuBxSYZrOT/v?= =?us-ascii?Q?B9GqaP/H0seXBbGY9GbNs2/4jsMTzP5z6FEjFau1A5bt9qh+3neFPwfe2DVw?= =?us-ascii?Q?DuSsKgCBXMvS1+NDyZ2mNldANxGoj/uD8Ptn2E2c2vDzZMRGGXA7nV98J5qZ?= =?us-ascii?Q?XbLqbtU8+38XS2urDw820/OdNgcTceF8lCjGw8rUPw/FlBCmomgZYhlgLlwZ?= =?us-ascii?Q?EfX+inS0c9JklZgzJeRXZabEImlzRG4sD4sXpXVQSGY9r6H1jvEnfqB25wKl?= =?us-ascii?Q?4sSAWvtUSlKUhYiZ6tNkuK8WAHopg6R7QgE5qMj/zPuYWU5V3FKitLFUHXsk?= =?us-ascii?Q?0Fc1WIUG3INEKgKEuQy5tVg5VIeHtflUOfMbtLCALjO6Y+5rM0Qds0086n/y?= =?us-ascii?Q?CCvyl/Uj/5WQr5n4F9ZN1ULqiCWsv8JUszuWD+efyslxlJtOj4/JZ5pQSLmB?= =?us-ascii?Q?aSdOJaSqTa3dEFBtTtzmDb+8e+UD0QBe5LHq2i+pnuG59J2+hsdD1K0bRmvh?= =?us-ascii?Q?qCCicni31Q2kc08pJfvBcYfRg7pWkaifr/f7jwAznHzxproJX1A8XJ3+P9FC?= =?us-ascii?Q?mYooX25ZjMQmcU6aP72ijqpKP/PSzQJbTNt8aHAnwUPeLMmcwyZrlITvb9+T?= =?us-ascii?Q?ZggZu2iFpow1kEEQeCY/Z6A+VNMt4P9LsSaM1BmKcPnLMCptQVtXDqxxLEWZ?= =?us-ascii?Q?0gxUWokuCP3c0iYF7urb9yjjOD2pu5j7nUD1Zkf276r4M9oqSWSXrc/iUnJA?= =?us-ascii?Q?5/DA65nOzqSvPJ2Mg3lKZbSS9MhXCkW6RrkTM/eumN2gLEhF1GQl4O6jsXCt?= =?us-ascii?Q?AZndSzQJbwdEabOD7AmotJVmun2DySqaCXCbxztGxliWH7u2K/ZKL8p+Bpkg?= =?us-ascii?Q?SaGYMQVid7FzYk5c4zamqfKICPu3UuYorXL5AaBGRhXCNEz4spTvJQBhaXGJ?= =?us-ascii?Q?ShUvlH/rDP77yyI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5576.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(52116014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uMWKmQ6JKOxcikCN4aZPWfQ8V9ei03wPnR47dsbGhTpYYxLg9hOeJeL1eKLs?= =?us-ascii?Q?VLg35XgbzXLuZi2gx4u3ZMVs4qk46lwAjn1lSx+Uy0YnSo10r8HyVIteQNRt?= =?us-ascii?Q?YQXQU+u6tXl22Bsb2sZL+xZD5HYv6sdUF6Dl1/nvHZRiPJ7gWpuH4dDRnyPi?= =?us-ascii?Q?ckDZUhOjwRtyb5Coxsc/0fRBtprEAdEOrvaX41OSN6657eD44f7ltUqt+PJG?= =?us-ascii?Q?mMMbkHpWFV7fMiAArJQHKaHT2LRln3lRgaJtZonIN0OkgqWhLwcY8TDlVg0b?= =?us-ascii?Q?dA/JqAYXQ69gXzyQb/vbwuQv4dMfNGEG6p1ufhOxgx2HyYDIbTxC+C2aAS4x?= =?us-ascii?Q?Pd236KdpuHEdzfer1srUFdtG1yS+ajCBMT+cg+IOal04H9Go6E2amp6qyKd6?= =?us-ascii?Q?ugQpss4niiOLd9kOHVkwr2Xk+lLzLYCgAqjo5DsIPBQCJaUCk3LGydoInuVO?= =?us-ascii?Q?qZDWBHqf9xHO9wsIeranP+VIfE6SneTY4FrV/JCj3fHpBu/AYgv3ByZR8j83?= =?us-ascii?Q?xYbNsc3darP7KbsavtUo9vM+AxA80/3bFERTwsje6UJif5t0Ga6wl0Yr3yyy?= =?us-ascii?Q?ru/BteYDAhSjFxZ0zrvH0GBj7chr12SU8Vmsw05FaKQsTF+uPJ0c4GsidPqS?= =?us-ascii?Q?wI0hmbUpg1hSnjSJ0PQb5XkslhG9c6BgUA9TxpitUZCm2dJ/9rkzlWGoCpLs?= =?us-ascii?Q?+vFAVWo+r5NSpiXQNNfotVUIzX3mb0JRh+FI89QIC0pp6BPOGQaQmQQUQC+O?= =?us-ascii?Q?I6Zoc+cvqJ3iOtSBxX7M+q6XTRBQqHha5vNoQJZjnNyRuMMXYkg5Pg/Il8CH?= =?us-ascii?Q?8zM/5/rzD1HHfd9qFN7dLB5mQ3+ROgL+oz0C9MLXXD4X8RxBkZ3sBkcN/106?= =?us-ascii?Q?p/WCnosg23qkMkzvPaW0QVdRRzP0bHU6T4dV/N6w8kQ+V1vBfLRUnJnXChPP?= =?us-ascii?Q?QpTAi/qY49C00o2LN4pFDcDAPtwcjC6fbGUCHbKHFlhqAikn29YzgFzHmhwA?= =?us-ascii?Q?JbQAzf8iMsAZL73zSqRhPnmWaWq83tvp3USCW5nuFg+c0k6WDY+3nCh8keBr?= =?us-ascii?Q?jIzwazQwAH0SqEGAJNIiMIZBcaUMugG2l4QZWg4Uxbc/OQw6viAIeY9Icqz3?= =?us-ascii?Q?l0O/V6HuM2IDUs8ebbF+NZAiqFYNsuaV2caBBXbmgZA2qfXdLsg1pmdgNeY0?= =?us-ascii?Q?dx8hIENfEQVnwTHQBNMsPKklOuNxZHlUGuyqcyb4+jTlyIMO6lP8zXk+6vOL?= =?us-ascii?Q?lPdHZ8LPBCMWH0C+DEHhAoS4zImWsjQqBSXV6MgMld/crR6ZEnRKtCw6z2wn?= =?us-ascii?Q?zB01VkDL8HH+ktCgaGMf6WkUV832nTpPgn+zyTqZ7O0/DLGmH0Zd54jN4pCr?= =?us-ascii?Q?tqYiXVQFq5Gmb0olyTg6QlNsDbDwJ3GQlFqUxbyQdoTMz6rC08ThsZpBORQK?= =?us-ascii?Q?I0OiacJNwIJ8LBdV1EedaEAC+c2oblO/afdqW+y8XAjuUSdKZ+f2ziwsRv7h?= =?us-ascii?Q?GWObmxV0N1xfaLClqBRVwicWEk5xFlAJHCvst9R/Y7ohXarR8s4SSKAGjT2+?= =?us-ascii?Q?lYXInjxU8c8yZXLIxoK6UKsvR5m/Sl4bPGQfx4Dk?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: b32027af-10e3-49e1-8da3-08ddd3f45038 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5576.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2025 07:47:23.0060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WWkQKMVU/lI2GBvNhWH/MwhP8loQjvTTuqFTu4XTCaABgEGmvglzXXbGt1JJd6Ow8WhDeW56aB8lKF1BgFtRhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KU2PPF022ABE738 Content-Type: text/plain; charset="utf-8" Remove unnecessary goto labels to improve code readability.=20 Signed-off-by: Liao Yuanhong --- drivers/gpu/drm/imx/dcss/dcss-drv.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/imx/dcss/dcss-drv.c b/drivers/gpu/drm/imx/dcss= /dcss-drv.c index 19b027cc1dc4..3df060a2f6bf 100644 --- a/drivers/gpu/drm/imx/dcss/dcss-drv.c +++ b/drivers/gpu/drm/imx/dcss/dcss-drv.c @@ -65,15 +65,11 @@ static int dcss_drv_platform_probe(struct platform_devi= ce *pdev) if (IS_ERR(mdrv->kms)) { err =3D PTR_ERR(mdrv->kms); dev_err_probe(dev, err, "Failed to initialize KMS\n"); - goto dcss_shutoff; + dcss_dev_destroy(mdrv->dcss); + return err; } =20 return 0; - -dcss_shutoff: - dcss_dev_destroy(mdrv->dcss); - - return err; } =20 static void dcss_drv_platform_remove(struct platform_device *pdev) --=20 2.34.1 From nobody Sun Oct 5 10:49:28 2025 Received: from TYPPR03CU001.outbound.protection.outlook.com (mail-japaneastazon11012022.outbound.protection.outlook.com [52.101.126.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09BFD223DDF for ; Tue, 5 Aug 2025 07:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.126.22 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754380054; cv=fail; b=tLWMGvm5B2eug+x9gFVXB21NUWBRjgib0Mr1/Ql/9Y3zn/3rP8wpAcu2ASiQn1Scmg39k5yM7n4VEgaL6V8KjaKLn8+3VqRkXzzOxdYz9P2zp26iEEjeAG7F6YmYPyb+bRDRreWdiRM+c8NHVM9V4jndpu6Liv5+H96L/ihiORo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754380054; c=relaxed/simple; bh=EFYCHQ5sqE8kMwipj3IqUp6CyJesh9uN6Al+Td/YCak=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=jaz8zhemLA2FexWDOg+ue5CctyPq5y5GDOqmcgrVgkKoBC8bED54VeT1B7MHuHVrJ0TVTW3UojAP1JTy+HMLeWRSWehfl8ePl7yS/+hfst4qRUlfS7ZScL9sUkNYot4I+uCz4mgobeKp5VDi2n+qOJ2m53jQKdmWQuVMaIO7bfw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=cJyDr0W8; arc=fail smtp.client-ip=52.101.126.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="cJyDr0W8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KRjnCn+cwmmH+jDeILHFBQPhe4JMWyZGAN+DeVyFnnbbosTyhSi787c1QvR8ZJ7/BCKl0oPKPcVehmx7lrE+z6Hm6dKTduyFixlsbcZxOxsDXPaAfOb5kBBv1tmkXqhs+MDNpP6ujvAtwXQaoE432gtTeyRFkKw2MQNhB+QOA5FxByRSCQ0WkM6L4a4KZFBQT+xuxE4qAtvcArEPlsWVDuhnECXruQcs+VpZvLoZcuc21Hz+BV4TiEWETosDgNOqgmbjArS52jlPA9dLORpyPprzEr8ir3VqDk3cYmfsm+dTzhOm/PhnRbC4GveeDSEz/pqF2Fp038cgyvoXyNCMlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VegefIvQ/6IBDYkgFdRmYX2o2N5zc+RWIowozX+0NRA=; b=Q4TZDljZE4+4OtES+XEbUJRZmU+/ZLPmxIq1sm4eYnp9mBcis/f9LKR9t0DIaWc+cQjPxqmb1k9NHxUVH4FAoGcyp+egZ0MUHGG1k6J3s6pZAKU9hdEXisDcShl2vE1Qtb/SFPiEp2cc0KaMS8bqtXijP9/ilkI68qrsVZ0P7I+PH2/GGfKU3EfdwZ1QMktdK6kvnO2F44rR0INBS93z7dN9WnHdQteEIGs/VGRAWhvbdhK28/7IZ+Q1Xq5MdYsQctr/iz6HRFD59+4YpfRf1jMrmQDx2Zaca5aMdp/PJqwqwFd/mhGMaJEPqqN06O6CfEjxL92Kldk9T2yrsbtYVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VegefIvQ/6IBDYkgFdRmYX2o2N5zc+RWIowozX+0NRA=; b=cJyDr0W8sAbqATRc4sMqkgLOXup5ttlOM2YP6MTbWJGBuKflpNz4wVnehOpLlqaYbVtQ1C/c+H5JVAA8bHcrUsRyX1pI6cN85i2tyUhSoByZbzAmRDE5KzZvq7NUhbkcPLOnLJukvkSp/GAVQrySMyExhTGWZJv2dExZcIaO4SJrevcm85lJ8XtHqYSmf+Wch1dCrNspw198SSN4/Wa0NrdOu1YYo7rnvtiS/XxFpiXa3xYbT+gqgPQ2YNsNj+GN2aDWr5sJetsjX0Y3NTgQeNL7pSZoqnmiAgRz246NIUW3H9DapXhfjxoVRTnMeueV3bR6E0S0l7q8wdTMu7PpFg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) by OSQPR06MB7278.apcprd06.prod.outlook.com (2603:1096:604:29c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.20; Tue, 5 Aug 2025 07:47:28 +0000 Received: from SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6]) by SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6%5]) with mapi id 15.20.8989.020; Tue, 5 Aug 2025 07:47:28 +0000 From: Liao Yuanhong To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org (open list:DRM PANEL DRIVERS), linux-kernel@vger.kernel.org (open list) Cc: Liao Yuanhong Subject: [PATCH 4/4] drm/panel: Remove goto label that are only used once Date: Tue, 5 Aug 2025 15:46:19 +0800 Message-Id: <20250805074645.625911-5-liaoyuanhong@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250805074645.625911-1-liaoyuanhong@vivo.com> References: <20250805074645.625911-1-liaoyuanhong@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR02CA0017.apcprd02.prod.outlook.com (2603:1096:4:194::17) To SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5576:EE_|OSQPR06MB7278:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e5ec22f-9f00-4b10-6795-08ddd3f453b1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?uaxp7whFQzXD+3DinsGng8ycopQMmKGjUt37pjLZJz40oRoKHrJPxk/bOo2x?= =?us-ascii?Q?OsR4pouf3Njwg36FuHuChgRDdFx54Y+del2mEZ62HpsjHvP/QHh4wTSikmHd?= =?us-ascii?Q?NYswgvFbKup6NbDLUvl3gP7ONvMjrPEk/Y6ajF36x/MNjLo7axj0ay3iVA6U?= =?us-ascii?Q?tI5UvdjBNxgx+a0b4mIzx19l8WvT+W+XbQpuGw/EkkL8JdS8S/XEqxbbi3T2?= =?us-ascii?Q?CItlxuwr/IwpHBdQ7eaSs+9GwMGo5u9JEKv3Ks471TpuqUkCFsFzgVK66ocN?= =?us-ascii?Q?eDt4MqrQqLLPoZ3au8JUEFi4hDGyTYLpwiqvomgum9ksyN0g0irUhm3wBqPw?= =?us-ascii?Q?i07e3nQN/sbdXNkyGcTebc/hf2vpUgBngQwfxck+uTYiQ6POytLeF/jhteMu?= =?us-ascii?Q?bulev2ikgCv4Qx0nWaIFyKRZHBV534R88l47Ae78NFfzXYQwkSTV0Ulmlydq?= =?us-ascii?Q?c0X7+eDtTPavLb34Hz5Ebenvc6wv255+Q3EoHi11ykYbFV7BDXzt1gXr0N/7?= =?us-ascii?Q?J+6oyqFR72GPtp4a2/l5fRpAQzzunMr3+cdx9JHRshRZ8wApukkrYmN6wlLI?= =?us-ascii?Q?EkP9j0Waw7ro5v504qaB+PRubBbn2PH3ieuoGVfry5V5LG4U8Jfl/aT/Wkqg?= =?us-ascii?Q?37xz36/0i1IfQyt9hlHIAe4eRh/F4AaQDbNIq34k6KQUmvCbedEzJHb/mLUv?= =?us-ascii?Q?Y+TiCyf6Ev/qKtO1ZE71CT+JEavwO29rwRG32qaeiJHobd+28LKGvtZG+n4I?= =?us-ascii?Q?++1i2OGVr5QPFeK4ph9R4nQiT3O1xyi0YxfF8RKvdVm0QBepWOAxly7f79TP?= =?us-ascii?Q?DBaedWQ0sfX1BdaF4vsLUcE19IfexT5HsvmZ66SE9n32oDTj4y1ieapq12oe?= =?us-ascii?Q?Fyfb9lwpgszIISlqmAx/6sdJVYUZByDPTd5We0lhDmQmBYqRm8i3a0j5Q9xx?= =?us-ascii?Q?tZLDnQztWBBCmgGss11zRZbbBMEKs9IV21OULZ7WVdnnTIMcx5QRmw4qaKfS?= =?us-ascii?Q?b9bai8dAMT25WY7CNeyMNXiga4FC+oiJtA3VtgDPWRcr7PZLsSt67MYW38K5?= =?us-ascii?Q?SOHR22bDNHoX9vsOYc4Ca6R2tP4ZxF0or1jO5kiSOpXQ/yga1Sip/EBUvCu9?= =?us-ascii?Q?8FzO2WDsAb6Uin0394snkcBN/59kwxQmUcegMsBEmKI/M6EsUi90csfr1pdk?= =?us-ascii?Q?Rja7S2ddYYt11tTRTa8o3NcDy/zGvUUPF23usk2w9TuA3TlFpH5Uo1QrLZHb?= =?us-ascii?Q?eRyEuc5cjo1nhm5Ital3vZpHraj7H7hb+WZCeoETTSkAuNeKj2L1ntykwYqG?= =?us-ascii?Q?WI1UI8WTTTckTud+n/zkH8bzc4Sp85kYSqFcvkiLgyKGbJ03kN9A8VEQ4qP2?= =?us-ascii?Q?MJIadsRXMpOWzVhkOKpZuVSmDg5n/J+4FLBvUNpJxr5XXwsrOSIm0XxFSfT0?= =?us-ascii?Q?REwFTY0DUwymF5VDTAJQXQ0O92nOL+2y1IbdAUff8yr6JRSyFXOUeQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5576.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oa0UKon2vHkVdkvuvnS7gj+aicAJVhcf52fsemor5mOtklQWt315MUbkpIdl?= =?us-ascii?Q?aVgr+Zc1aT8KxeE187gX72vf/qfekjYVZ6ntvbNUERv0xGnUGIjqAsrVcWrN?= =?us-ascii?Q?qjBdMoW6RyvVgEcmOwwqlj8ipt89zkwJQGulU1a75NoEoDQjsZhU4uqVR9Nr?= =?us-ascii?Q?mOkMoQMH+G/00HLYci8ejA2sDvr/TsZuwZ225QpoUshLj+AO1S653+VO8LRV?= =?us-ascii?Q?Vcyiplj44REKGqXrySbVyAc33HQHQ7UwZB8ryvTA+F2xsXtWWaOqhgzmJ90H?= =?us-ascii?Q?NHbiGhGbpxTF8U0/HtRi4I1gNpDkyXXAhVLM4psArSQxASgsZtvAg2Y521li?= =?us-ascii?Q?QCqa2RvH2VH6y+xVbRT+3+W9mPcNpztOsB3jJR0GNfwN9/H5isr4TT+togY3?= =?us-ascii?Q?YR8xCYblU4GZ5yiaSnRjgmtYtnUSyZYkSkhhAseYBWCO/jUQ65KjTAmP8aA5?= =?us-ascii?Q?VtnWfYYoILznI34w+Nt1Fo9UtqSr02wmcX+6mNyYr/d41l4SvnPXha6TiSWY?= =?us-ascii?Q?foJXmmEGsySt8pWzHxaqDt8RotNTmqqUFt8Pez+aUEObFEK5HvQfNYEG1Qf3?= =?us-ascii?Q?4IqspxdAP1XMX1md6740ZA1ydcPKeNyhlNINwk2pj9mulbyJNQ/9gGlnm1KD?= =?us-ascii?Q?RzagnH1dSrebk7QhGFmbXKjrmBuxZUWS/+qZ7I/ScM60X+h4HKCQuJr7pFL7?= =?us-ascii?Q?DEp/yWztIQm//yJVkaD8B64uo++g9pmko8q8GsNwBvxfKmeEWth75yugo/3F?= =?us-ascii?Q?LlQ/rwIPLbYm1C1v1MYzNHxHDJrRCUjjSiizzqD40Lklfm2xcFkvDhxui53Q?= =?us-ascii?Q?/b8VPHKQ8kP0DlTdCEjeAmCbm+QILjP5k1M/iVHAvKS6qCuyJJmrtn6HhDly?= =?us-ascii?Q?u5uHCLKxd89rp1BSsLs4cJjd38oL+Zuzl8jTs3Tx5MuwFDX+lhW4B1pOIUAq?= =?us-ascii?Q?TGjmQdl2MJ3XmuDn0bQUh3dSBP+oAf+D95SwQaExUpX+srE31mSKo2t2QRte?= =?us-ascii?Q?SsLrUeIVGPCPTetP9m+K41qUgiM2wXI1nyIi/O1plCODEuIUuqkfgDFeLd7f?= =?us-ascii?Q?sx/UB7UhHEQS0+n6oz4WKbRg4OFpWFSRJAwtPHAq+/VKm9FrDzMo7itJ5uod?= =?us-ascii?Q?soWwUt9yL8PHjKUPNDbsyhOCcZzTYfnASeiqbc3uujpzvAoOANF350P+t0mO?= =?us-ascii?Q?oT9RZFQ0zvPfv5TwwVAS8Q/hn2TNx6GgUAHO3OUht/aoB1CyLjxF3MC/Wo3g?= =?us-ascii?Q?2/ccrek1PGS9kbsR7vkjRXY+WAJ9E3iEmXWcCa6Q9jxRX0jGvtM1PdeQ7/9G?= =?us-ascii?Q?74LNjurCmhwMvI4KVagU82uFYXUxdn1kAa6M9R0GvDR0UyslVeP7eoR5T6k6?= =?us-ascii?Q?nHgkL/8Mw/0cZWdYAdJVS8OylOAKvhw78h1sD5CLC38f1lbw11xc5eIbvjs3?= =?us-ascii?Q?zZVr1ym6NI91Ke6wgOcfjkMwj/hv6jhdhHW1Hn0GXQJCBsn9sO7ouSgk/Lon?= =?us-ascii?Q?BEFo4DIaIGtwamtSThzcqwJxDjd+Hv+qODqA4QEhA/aJXea0WgfQzxxF6+7e?= =?us-ascii?Q?txxpAUNaHK2I/0mtysVDI4DoDiR/iUB+jycm+AoR?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e5ec22f-9f00-4b10-6795-08ddd3f453b1 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5576.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2025 07:47:28.7981 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XlV2xFojEtEeyt7xW1lh9WFciSqi2hRE6GDGkj3yHRcrHGNp+EWVN5NwzG+mXhjG6JzH/Qg9N3wWB72At95GJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSQPR06MB7278 Content-Type: text/plain; charset="utf-8" Remove unnecessary goto labels to improve code readability.=20 Signed-off-by: Liao Yuanhong --- drivers/gpu/drm/panel/panel-innolux-ej030na.c | 7 ++----- drivers/gpu/drm/panel/panel-orisetech-ota5601a.c | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-innolux-ej030na.c b/drivers/gpu/dr= m/panel/panel-innolux-ej030na.c index f85b7a4cbb42..6779a584bbd8 100644 --- a/drivers/gpu/drm/panel/panel-innolux-ej030na.c +++ b/drivers/gpu/drm/panel/panel-innolux-ej030na.c @@ -105,14 +105,11 @@ static int ej030na_prepare(struct drm_panel *panel) ARRAY_SIZE(ej030na_init_sequence)); if (err) { dev_err(dev, "Failed to init registers: %d\n", err); - goto err_disable_regulator; + regulator_disable(priv->supply); + return err; } =20 return 0; - -err_disable_regulator: - regulator_disable(priv->supply); - return err; } =20 static int ej030na_unprepare(struct drm_panel *panel) diff --git a/drivers/gpu/drm/panel/panel-orisetech-ota5601a.c b/drivers/gpu= /drm/panel/panel-orisetech-ota5601a.c index fc87f61d4400..95cf8f36dd09 100644 --- a/drivers/gpu/drm/panel/panel-orisetech-ota5601a.c +++ b/drivers/gpu/drm/panel/panel-orisetech-ota5601a.c @@ -130,16 +130,13 @@ static int ota5601a_prepare(struct drm_panel *drm_pan= el) ARRAY_SIZE(ota5601a_panel_regs)); if (err) { dev_err(drm_panel->dev, "Failed to init registers: %d\n", err); - goto err_disable_regulator; + regulator_disable(panel->supply); + return err; } =20 msleep(120); =20 return 0; - -err_disable_regulator: - regulator_disable(panel->supply); - return err; } =20 static int ota5601a_unprepare(struct drm_panel *drm_panel) --=20 2.34.1