From nobody Sun Oct 5 14:33:08 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CF4B28CF52 for ; Fri, 1 Aug 2025 18:00:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071220; cv=none; b=GvuN0MfmqqJWjl8QnrnUrF/aJZVPj1KHepdJO/e+WiG6tq6yiLvY9V8Q04qRCc+/cQo1RcUkrwM1pVNUvlaRRszo8kzvypBKgnziU3TOu5lW59mrKwqbrRbCc7vlusC+48dxn27EUCotp/Txj9mpLAn/D/h6vHQ45A2cbz3jDWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071220; c=relaxed/simple; bh=e6x/dDP5ia/NlQH+0MKdj/wLpx5h4B+ZdMfBV+aj6qw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d7qvNueOOQa/VXif2v78ZAhgO/C00OKYg2tUilibHLdGmZOk51vDjifKdW1N5HoS6lv/oaIJexFLwjFkTwJuDQpEEuamA+C9Fn11opcZvzo7NHI3wglFiIZ6QhIyQvHI4Z4yVc8uN9Ad4GDbqirl4C5yX90oE5iKCMPLVRBqLrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lqjb021A; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lqjb021A" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 571HfRHd028630 for ; Fri, 1 Aug 2025 18:00:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=0qBkf9JDSmf FwdkCS8a187SNR+0cTRqqV9Ya3fpJH68=; b=lqjb021AtTqCvnIJMJBuUKy1mw+ SKPUHSZlPGv/P89wjiX2SYFjrHJfsfOrmAeW50LSXHK3LPcaZpjRUMIMiGKVv9l+ fsz1dmWa9hHOHAGkgdauML9IhAYm3w2/cFdcuzXzn+uRAZj5ymAKCQ5jZtwCO/L6 jh8aity2LH5dT6DNbCvbF5/07qdwLikc99JXmBKHqcSh94zDrcv8gWs/MFTAqQFP wRvF/F+jZsQXtqU9XGaAKaZ+WqcIE9sHJfO+kdHzPdMET3MbR9UXycmCFmo5ME8w C4BFLfa7v6ANOSZmRCZbbDFei+f0bYxtgxzaZhuyh5DWKCz7dPHV+OFRj1Q== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484q86d59p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 18:00:17 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-31ea14cc097so1785157a91.3 for ; Fri, 01 Aug 2025 11:00:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754071216; x=1754676016; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0qBkf9JDSmfFwdkCS8a187SNR+0cTRqqV9Ya3fpJH68=; b=XJnCD4GcPAupRrNn12z4mmyf57sTP07p/FfAlUEnUuXAXDMFYtoyS2oUKCx8dWjg7v FU105f/2ex/5HF4nXkmnJZykQcOqzQXhuczSbg/1cEizzNLgXJspcxj7OPzyEqQwhTIQ dBSK1VLSbwBfRViubq6rexNCkyRsREijIdaceOnHPq73x7CwtZDpnqgjnTDOXXDvefuR S4PPsi3arLNWty1q7jCsHK7v2WPaE7pUKIiOqMndMuduDRPe206UmO0IiRnk0DP3Mpj2 XqK6wsSrONDnghXAfMx3ACZwL/Pgwsvzcv9A2rAirzPTp7OM+mxXBOeb8eCghWwwfWrc Yowg== X-Forwarded-Encrypted: i=1; AJvYcCXtRIXnSKXM4LnIWeKbGKTBEVOfeLuhJjCyQvN8M/6cQ9JWSUenszBpMZOS83Bi2XDZmF8n22/QalusldY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzd9bndMeaVrcrizODqg0e36pHukm6v4r1aoc44WI+owQsVVaO/ UqqZZbdrO5reoccefKi3bScy1FKpT+Jk20YnMBi8TP8HPBM1Ps/llClKEWZ+uM+q45J+pcCPIT1 tsULEnMbwysmZEtECq7c3dxTJSG+Zx7p81u4u9ClgkaZle79BfvQ7MQClsUPY3MpnA7o= X-Gm-Gg: ASbGncuB67BlZ2AckBZD5nAa1rv/Fh9tm/z+UuNYIrhRp8H8pxIWW/eZvJ0xgNbgZIa 49AXCbbguHWzC8Fjmcefej2LRP/id9V3Wm5qetWkkrgz+r9/7D9zsX9JVx5xs9a9DilFlE6VQ+I ar5k+yS30f08VagtPqURhRuLgHBLF+02qkBRVXVsFur5uu+Ir+x6HKAnt9eHGnn1aCS0Cv4OtOp 6HQV0SWFHII7aykzXHOxr513e+3ux7HKeHJbPvLS0K31R6cbMoSQu+TlARMBPLp28KmFz7qYfbR 9YbCFylij4T0rToNSQaZvFe1eFAWlWAWveGrOXtWuiSIQP2QAGo= X-Received: by 2002:a17:90b:3cc7:b0:311:ad7f:3281 with SMTP id 98e67ed59e1d1-321161f1e4amr1051148a91.12.1754071216075; Fri, 01 Aug 2025 11:00:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFCufiAuEtwIrk4MYNpS/nkKxgS/INszns4WCKtfrhQYzpgeLZK2wqU3sVv0g6l8Ck4AhkzDQ== X-Received: by 2002:a17:90b:3cc7:b0:311:ad7f:3281 with SMTP id 98e67ed59e1d1-321161f1e4amr1051082a91.12.1754071215565; Fri, 01 Aug 2025 11:00:15 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31f63dc1bb7sm7971555a91.10.2025.08.01.11.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 11:00:15 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Connor Abbott , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 1/7] drm/msm: Add missing "location"s to devcoredump Date: Fri, 1 Aug 2025 10:59:58 -0700 Message-ID: <20250801180009.345662-2-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> References: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDE0MSBTYWx0ZWRfX4XlIAuB+Yx6k dNIOx2LJHjPb91a3yxvPmkhUKT0XV+mf7pkJX3lJfRo96zVuRNfmoPY9dZSP2Q6FGOhooVcvMn7 i8avxfI0qZBwEk9q+rFy5eddr9+QFPY2QEgazNQ9YX6FLkaoYXWZL+dtHMlBG3vVKTAelTpNOYj 1+OhALDHpXQ6Aiw6O+OuKiU8xc4942JPW9lR0S97/lAIhSvzux6eVDUwDH3v3eio+Jc3M/psNLz g+1KCNX+2NUYCywNiu2xPpR93mpAWD+Ah45epjb2//UjXLSaTckkgYw5uCnFGrFTC4OsxY5nh+1 Bn9EpBgefHr6rpEsd+RDoCEEMQsCUpuxfk5g4YGr0nR4aiwxa/UYAwcqNlZd+OekyeYLnOFiNuY NYOXDbeJT/fOEDur7JAsKJl7mbyFz80wfFeiEaUrD7XqUclnu7Pie8cezVwURx7SKGkKyG/b X-Authority-Analysis: v=2.4 cv=TqLmhCXh c=1 sm=1 tr=0 ts=688d00b1 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=YFM8xwheDJGXjHaRWHsA:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: QaWFQTeOKyd2fBKqSCPCKP20HhsBx65_ X-Proofpoint-GUID: QaWFQTeOKyd2fBKqSCPCKP20HhsBx65_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_06,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010141 Content-Type: text/plain; charset="utf-8" This is needed to properly interpret some of the sections. v2: Fix missing \n Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/= msm/adreno/a6xx_gpu_state.c index fe38ea9328d4..a35cec606d59 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c @@ -1800,6 +1800,7 @@ static void a7xx_show_shader(struct a6xx_gpu_state_ob= j *obj, =20 print_name(p, " - type: ", a7xx_statetype_names[block->statetype]); print_name(p, " - pipe: ", a7xx_pipe_names[block->pipeid]); + drm_printf(p, " - location: %d\n", block->location); =20 for (i =3D 0; i < block->num_sps; i++) { drm_printf(p, " - sp: %d\n", i); @@ -1877,6 +1878,7 @@ static void a7xx_show_dbgahb_cluster(struct a6xx_gpu_= state_obj *obj, print_name(p, " - pipe: ", a7xx_pipe_names[dbgahb->pipe_id]); print_name(p, " - cluster-name: ", a7xx_cluster_names[dbgahb->cluster= _id]); drm_printf(p, " - context: %d\n", dbgahb->context_id); + drm_printf(p, " - location: %d\n", dbgahb->location_id); a7xx_show_registers_indented(dbgahb->regs, obj->data, p, 4); } } --=20 2.50.1 From nobody Sun Oct 5 14:33:08 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C66E328D821 for ; Fri, 1 Aug 2025 18:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071222; cv=none; b=FPOZ0eABTQqkn6ymo8Yex/Misi8mAETA7G6KNnnsn4V0LZMtNcej+o3bBaeHXyi50sdZ2k0fta6eI8h+AqBosxgR5GEqRRgBVXB3Y1YZz6V7xDcZV5MYcicRaKWf/Uj42Wp8Mm/mLT2a5IgbJz0GKwDHrfFxr5tg4iTFO82RILg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071222; c=relaxed/simple; bh=jGJl8iqJGqZPa7n22eBdmzp5OM9OlGjVdL1VtHXWqRo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IlReQ3uhHpy5lmOTDkoP0HdQcmPI1LZDGHjGVI37Wq5SCeEB+HN0n+ryPI6QtkmtA9gcujUw/8FDK7Y0FCZXq0li9OQcBWFMaQwAJZe5d4r1BFNUAZz4NrVON5mIBFQHSlZjSL9Efwuq3kGNTIGzDgICLOEiev2AGgYfLoilUGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EityKLKB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EityKLKB" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 571HfX1N028955 for ; Fri, 1 Aug 2025 18:00:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=h5aGQowTyQm WxLOKsfUuwBsP1jaMp4P0qKNGjmBwUOc=; b=EityKLKBe0tOwLIqqVCUBnKMlba SvOGiDP8bgLrdJhaPskGjV0GeTETC5O8a/3NyHPS/eL7+mq8T5v4Tx9ji5xVkp// Egl5fv/JqDN7Co0ZSfjUqI1HuxtyxfhRs/J22x4Or9XeFuHzHNirnqjKL13H0LWG QJ5d+9t21Tg+XjSsg8DEViap7Z93fR0Jj3P0Q6Xekjb095Cm/aRbWThmhUU5xEoX puMND0i3T8uO/9cZDs/4/9kvKhKbP3IUoOwwQfq7GYXML1FBwNlq79hnSjvzB39f EXnH0f+erB4aC5WQXjbYk51ZTt9IAl8XIJA0eiMM20z6+79LBARWaVXruiw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484q86d59v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 18:00:18 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2403e4c82ddso15736725ad.1 for ; Fri, 01 Aug 2025 11:00:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754071218; x=1754676018; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h5aGQowTyQmWxLOKsfUuwBsP1jaMp4P0qKNGjmBwUOc=; b=LZ+6qelLVbAriY6cep/hWRNQibwfWnoXR2Hej4uG51lIO/vvVPgog8WkM0Gkob8+8V eTItucq8nVGaESg8IOnLr8506dXEvEFsAMLPsc1UG2NAZKSV62IIuVml67YPY4d8UOUc 2V1uFQcdCRjNa1CzVa+4W7J0v7A+riuUEzvcy6Ag94/mtULlBWsgcTRIKe8/e5cssROp G8topVMurSP9URxuuKCqLuqOKsyaf6rkT8PSaA1XiIR7g2AJr35gBed6kfAd8NdG8+3l eHYEc0gEkvyULkPy9XPU1lT1Ojra8lTvL6JPJzYsimCWd7ZZHsd8taKSOvUTj45KHjAp 71Sg== X-Forwarded-Encrypted: i=1; AJvYcCUh1y/QHg5D93UPX6jX2TDC84bPbeaNXPDsSeoR45ZGCdYWZnL4nXScklviE7ZGTPRDBXU2YA0BMWIPtQ0=@vger.kernel.org X-Gm-Message-State: AOJu0YwS0MnZcJabyQbNToUp17iTaL9fsxQ7w6ADbQgsRXIz14ZELkfD kKes+pqc1h1zb8KeI1LWM2Q68kvReyAWa0gnqlCOiUyVi6m4Ne8Hv9MfqL7x7d6U5wJSWQjaB8e lSMa6iv6bEpjL4tixXCPdr6ICGC/bQTcEp2dv28U7CCoskqLJ9c34O8XcN89yf3i8OPQ= X-Gm-Gg: ASbGnct0DlfvB5vrkBRhqiGcx8d7Q7XCRkKC6SoeFukFP13yNEfJbTsV+nCaCSxLAqt X+pnrCJ3IJ6CYgwoSzesblRcdDY0lERC4Wm7wW+PAEqOcZ9AU+hWSaW6Gq292mtyEaDnM9xxdUd 7qFbJ89lfRPdLtdkwO3LAJrRmkmXUBPkLddKbzQc+ZZ5oQHRn0eBudByC73T8r4mWN7BDKwPCXD R5Ns78jEMSnv3bFPaLCvFVyzHlbyh7CSlxS+AmzKPCgNb6uTPIvYnwxPiLSImDUIeKHHgCNjOh3 gXOwAKf//tnWeH6cak6510KObQH7QM+6wu5CbPX3lmwqnNomk7U= X-Received: by 2002:a17:902:cec1:b0:240:86b2:aeb6 with SMTP id d9443c01a7336-24246ffbed1mr5044165ad.26.1754071217556; Fri, 01 Aug 2025 11:00:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHbq3awaD9xvkRSNN2z/DDkqNEBB7r9FVhqVsVElrsfxoCKJuaBepuSzCBszOff9RXFmHzwmQ== X-Received: by 2002:a17:902:cec1:b0:240:86b2:aeb6 with SMTP id d9443c01a7336-24246ffbed1mr5043565ad.26.1754071217014; Fri, 01 Aug 2025 11:00:17 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241e8977114sm48268935ad.102.2025.08.01.11.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 11:00:16 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Connor Abbott , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 2/7] drm/msm: Fix section names and sizes Date: Fri, 1 Aug 2025 10:59:59 -0700 Message-ID: <20250801180009.345662-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> References: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDE0MSBTYWx0ZWRfX9cwTRv5Naa4k D4p3EREt4lmyQc6byME0edN8rVsR37DRNOv6A6F/ZSnmr+jLTrtHj6zBgF/TfQMW4XRZHx74uFh SmwKrkIEgjDQCXBs4+ORUfPy9p21a0OZqedQYM29TDti3y9huM/x6b4k4wRwUCEILaH8KRbtAwl MVRDPqP/a8P7JnBz0p7oe9LKq6ZBWo33K9Zu2li9Tkm4u0lUHmZbTU0U+iB9YyJsXZgLnxyJTNt klcUDbSTwFKuf05kpHZZKUTmgCRPOLTt435CNbrMhO9HPTiHf9AZF2e4wcWziR8ftG+DK34/hSZ CmDYhWr+r0U+d0kjHj/Hz6Y7ON4ck0ShZc47o8kDUMGGicdwuWsUsolSYQlumpENhcQjDHT6D6F 9dH/npqQZjIvClTB5IA9vO4ZUJHcyGB/3Z2CPUpIDbmuOUCFKVVZA8Lbc2585nAL3PoSDmBe X-Authority-Analysis: v=2.4 cv=TqLmhCXh c=1 sm=1 tr=0 ts=688d00b2 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=BuD92i612R-MOt5tPB4A:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: AsPrMnqM51W8fAU4w4G4ImbINVUvthkW X-Proofpoint-GUID: AsPrMnqM51W8fAU4w4G4ImbINVUvthkW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_06,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010141 Content-Type: text/plain; charset="utf-8" The section names randomly appended _DATA or _ADDR in many cases, and/or didn't match the reg names. Fix them so crashdec can properly resolve the section names back to reg names. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 38 +++++++++---------- .../drm/msm/adreno/adreno_gen7_9_0_snapshot.h | 24 ++++++------ 2 files changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h b/drivers/gpu/drm/= msm/adreno/a6xx_gpu_state.h index 95d93ac6812a..1c18499b60bb 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h @@ -419,47 +419,47 @@ static const struct a6xx_indexed_registers a6xx_index= ed_reglist[] =3D { REG_A6XX_CP_SQE_STAT_DATA, 0x33, NULL }, { "CP_DRAW_STATE", REG_A6XX_CP_DRAW_STATE_ADDR, REG_A6XX_CP_DRAW_STATE_DATA, 0x100, NULL }, - { "CP_UCODE_DBG_DATA", REG_A6XX_CP_SQE_UCODE_DBG_ADDR, + { "CP_SQE_UCODE_DBG", REG_A6XX_CP_SQE_UCODE_DBG_ADDR, REG_A6XX_CP_SQE_UCODE_DBG_DATA, 0x8000, NULL }, - { "CP_ROQ", REG_A6XX_CP_ROQ_DBG_ADDR, + { "CP_ROQ_DBG", REG_A6XX_CP_ROQ_DBG_ADDR, REG_A6XX_CP_ROQ_DBG_DATA, 0, a6xx_get_cp_roq_size}, }; =20 static const struct a6xx_indexed_registers a7xx_indexed_reglist[] =3D { { "CP_SQE_STAT", REG_A6XX_CP_SQE_STAT_ADDR, - REG_A6XX_CP_SQE_STAT_DATA, 0x33, NULL }, + REG_A6XX_CP_SQE_STAT_DATA, 0x40, NULL }, { "CP_DRAW_STATE", REG_A6XX_CP_DRAW_STATE_ADDR, REG_A6XX_CP_DRAW_STATE_DATA, 0x100, NULL }, - { "CP_UCODE_DBG_DATA", REG_A6XX_CP_SQE_UCODE_DBG_ADDR, + { "CP_SQE_UCODE_DBG", REG_A6XX_CP_SQE_UCODE_DBG_ADDR, REG_A6XX_CP_SQE_UCODE_DBG_DATA, 0x8000, NULL }, - { "CP_BV_SQE_STAT_ADDR", REG_A7XX_CP_BV_SQE_STAT_ADDR, - REG_A7XX_CP_BV_SQE_STAT_DATA, 0x33, NULL }, - { "CP_BV_DRAW_STATE_ADDR", REG_A7XX_CP_BV_DRAW_STATE_ADDR, + { "CP_BV_SQE_STAT", REG_A7XX_CP_BV_SQE_STAT_ADDR, + REG_A7XX_CP_BV_SQE_STAT_DATA, 0x40, NULL }, + { "CP_BV_DRAW_STATE", REG_A7XX_CP_BV_DRAW_STATE_ADDR, REG_A7XX_CP_BV_DRAW_STATE_DATA, 0x100, NULL }, - { "CP_BV_SQE_UCODE_DBG_ADDR", REG_A7XX_CP_BV_SQE_UCODE_DBG_ADDR, + { "CP_BV_SQE_UCODE_DBG", REG_A7XX_CP_BV_SQE_UCODE_DBG_ADDR, REG_A7XX_CP_BV_SQE_UCODE_DBG_DATA, 0x8000, NULL }, - { "CP_SQE_AC_STAT_ADDR", REG_A7XX_CP_SQE_AC_STAT_ADDR, - REG_A7XX_CP_SQE_AC_STAT_DATA, 0x33, NULL }, - { "CP_LPAC_DRAW_STATE_ADDR", REG_A7XX_CP_LPAC_DRAW_STATE_ADDR, + { "CP_SQE_AC_STAT", REG_A7XX_CP_SQE_AC_STAT_ADDR, + REG_A7XX_CP_SQE_AC_STAT_DATA, 0x40, NULL }, + { "CP_LPAC_DRAW_STATE", REG_A7XX_CP_LPAC_DRAW_STATE_ADDR, REG_A7XX_CP_LPAC_DRAW_STATE_DATA, 0x100, NULL }, - { "CP_SQE_AC_UCODE_DBG_ADDR", REG_A7XX_CP_SQE_AC_UCODE_DBG_ADDR, + { "CP_SQE_AC_UCODE_DBG", REG_A7XX_CP_SQE_AC_UCODE_DBG_ADDR, REG_A7XX_CP_SQE_AC_UCODE_DBG_DATA, 0x8000, NULL }, - { "CP_LPAC_FIFO_DBG_ADDR", REG_A7XX_CP_LPAC_FIFO_DBG_ADDR, + { "CP_LPAC_FIFO_DBG", REG_A7XX_CP_LPAC_FIFO_DBG_ADDR, REG_A7XX_CP_LPAC_FIFO_DBG_DATA, 0x40, NULL }, - { "CP_ROQ", REG_A6XX_CP_ROQ_DBG_ADDR, + { "CP_ROQ_DBG", REG_A6XX_CP_ROQ_DBG_ADDR, REG_A6XX_CP_ROQ_DBG_DATA, 0, a7xx_get_cp_roq_size }, }; =20 static const struct a6xx_indexed_registers a6xx_cp_mempool_indexed =3D { - "CP_MEMPOOL", REG_A6XX_CP_MEM_POOL_DBG_ADDR, + "CP_MEM_POOL_DBG", REG_A6XX_CP_MEM_POOL_DBG_ADDR, REG_A6XX_CP_MEM_POOL_DBG_DATA, 0x2060, NULL, }; =20 static const struct a6xx_indexed_registers a7xx_cp_bv_mempool_indexed[] = =3D { - { "CP_MEMPOOL", REG_A6XX_CP_MEM_POOL_DBG_ADDR, - REG_A6XX_CP_MEM_POOL_DBG_DATA, 0x2100, NULL }, - { "CP_BV_MEMPOOL", REG_A7XX_CP_BV_MEM_POOL_DBG_ADDR, - REG_A7XX_CP_BV_MEM_POOL_DBG_DATA, 0x2100, NULL }, + { "CP_MEM_POOL_DBG", REG_A6XX_CP_MEM_POOL_DBG_ADDR, + REG_A6XX_CP_MEM_POOL_DBG_DATA, 0x2200, NULL }, + { "CP_BV_MEM_POOL_DBG", REG_A7XX_CP_BV_MEM_POOL_DBG_ADDR, + REG_A7XX_CP_BV_MEM_POOL_DBG_DATA, 0x2200, NULL }, }; =20 #define DEBUGBUS(_id, _count) { .id =3D _id, .name =3D #_id, .count =3D _c= ount } diff --git a/drivers/gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h b/driver= s/gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h index e02cabb39f19..b1f8bbf1d843 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h @@ -1299,29 +1299,29 @@ static struct a6xx_indexed_registers gen7_9_0_cp_in= dexed_reg_list[] =3D { REG_A6XX_CP_SQE_STAT_DATA, 0x00040}, { "CP_DRAW_STATE", REG_A6XX_CP_DRAW_STATE_ADDR, REG_A6XX_CP_DRAW_STATE_DATA, 0x00200}, - { "CP_ROQ", REG_A6XX_CP_ROQ_DBG_ADDR, + { "CP_ROQ_DBG", REG_A6XX_CP_ROQ_DBG_ADDR, REG_A6XX_CP_ROQ_DBG_DATA, 0x00800}, - { "CP_UCODE_DBG_DATA", REG_A6XX_CP_SQE_UCODE_DBG_ADDR, + { "CP_SQE_UCODE_DBG", REG_A6XX_CP_SQE_UCODE_DBG_ADDR, REG_A6XX_CP_SQE_UCODE_DBG_DATA, 0x08000}, - { "CP_BV_DRAW_STATE_ADDR", REG_A7XX_CP_BV_DRAW_STATE_ADDR, + { "CP_BV_DRAW_STATE", REG_A7XX_CP_BV_DRAW_STATE_ADDR, REG_A7XX_CP_BV_DRAW_STATE_DATA, 0x00200}, - { "CP_BV_ROQ_DBG_ADDR", REG_A7XX_CP_BV_ROQ_DBG_ADDR, + { "CP_BV_ROQ_DBG", REG_A7XX_CP_BV_ROQ_DBG_ADDR, REG_A7XX_CP_BV_ROQ_DBG_DATA, 0x00800}, - { "CP_BV_SQE_UCODE_DBG_ADDR", REG_A7XX_CP_BV_SQE_UCODE_DBG_ADDR, + { "CP_BV_SQE_UCODE_DBG", REG_A7XX_CP_BV_SQE_UCODE_DBG_ADDR, REG_A7XX_CP_BV_SQE_UCODE_DBG_DATA, 0x08000}, - { "CP_BV_SQE_STAT_ADDR", REG_A7XX_CP_BV_SQE_STAT_ADDR, + { "CP_BV_SQE_STAT", REG_A7XX_CP_BV_SQE_STAT_ADDR, REG_A7XX_CP_BV_SQE_STAT_DATA, 0x00040}, - { "CP_RESOURCE_TBL", REG_A7XX_CP_RESOURCE_TABLE_DBG_ADDR, + { "CP_RESOURCE_TABLE_DBG", REG_A7XX_CP_RESOURCE_TABLE_DBG_ADDR, REG_A7XX_CP_RESOURCE_TABLE_DBG_DATA, 0x04100}, - { "CP_LPAC_DRAW_STATE_ADDR", REG_A7XX_CP_LPAC_DRAW_STATE_ADDR, + { "CP_LPAC_DRAW_STATE", REG_A7XX_CP_LPAC_DRAW_STATE_ADDR, REG_A7XX_CP_LPAC_DRAW_STATE_DATA, 0x00200}, - { "CP_LPAC_ROQ", REG_A7XX_CP_LPAC_ROQ_DBG_ADDR, + { "CP_LPAC_ROQ_DBG", REG_A7XX_CP_LPAC_ROQ_DBG_ADDR, REG_A7XX_CP_LPAC_ROQ_DBG_DATA, 0x00200}, - { "CP_SQE_AC_UCODE_DBG_ADDR", REG_A7XX_CP_SQE_AC_UCODE_DBG_ADDR, + { "CP_SQE_AC_UCODE_DBG", REG_A7XX_CP_SQE_AC_UCODE_DBG_ADDR, REG_A7XX_CP_SQE_AC_UCODE_DBG_DATA, 0x08000}, - { "CP_SQE_AC_STAT_ADDR", REG_A7XX_CP_SQE_AC_STAT_ADDR, + { "CP_SQE_AC_STAT", REG_A7XX_CP_SQE_AC_STAT_ADDR, REG_A7XX_CP_SQE_AC_STAT_DATA, 0x00040}, - { "CP_LPAC_FIFO_DBG_ADDR", REG_A7XX_CP_LPAC_FIFO_DBG_ADDR, + { "CP_LPAC_FIFO_DBG", REG_A7XX_CP_LPAC_FIFO_DBG_ADDR, REG_A7XX_CP_LPAC_FIFO_DBG_DATA, 0x00040}, { "CP_AQE_ROQ_0", REG_A7XX_CP_AQE_ROQ_DBG_ADDR_0, REG_A7XX_CP_AQE_ROQ_DBG_DATA_0, 0x00100}, --=20 2.50.1 From nobody Sun Oct 5 14:33:08 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A73AA28D849 for ; Fri, 1 Aug 2025 18:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071223; cv=none; b=ozRPf8NXLoR1cfzWjhuSFNEwdDTNDo9g+NttbST9cxVjUEgwN3ekTIDaK+7yWmRJwymlb89F4wRKXybtVahutMmp5obyTad9lXFa3McNDXDc9DX3+0Xjndgnr2Uz+hPTsfsciN8jWPiZt6f/1sr3ovqgh+FgNWbPB+zz+7IdLfI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071223; c=relaxed/simple; bh=OjCcQPQrfynntfXQWE1QbRhM4jxC/iuvd0QhrBx8e+c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DR40Fh1zVlzEIiQKE23fdlDVXivYmmU2uzrjLdg9z6rF/AV9j5hEnfi++9+GFMFQ+4sagf8Hbw0d+g0htyLUNQ6UTCe2g0fk6/VCBr/4gjPwxu4hdSyjeqlENH2IL7HgkN5g2r6yYcd5lX8Lzv4JVehZ5KacJD+Q5oS/4E06BJU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dzLsOGhn; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dzLsOGhn" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 571HfMwI014281 for ; Fri, 1 Aug 2025 18:00:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=JAyYn1wklNQ c4y389Esg9VJ4y6TS3xXtsI3mzf8UH2Q=; b=dzLsOGhnul4nZ5I7+cQsdMKEAmV gy5K7ViT1KebwdmpHhsypAx1PONroiKyBavoudtKCdQNorSg+gMmGFdpq6cesjML fKvxyLVeGv+cA1HYQ9yuw2ssO5F9097RZP276dHkgy+ulIsuQGqP9L6AXqwTbhgx Y7ForzOSJnf6lfeY1aTzNP84TvmYbjGXEcfDstVT7uqja8L+fpK5l4xCq/la9GX+ axyTjm3WGDRuO4H3+ZC23Yh+ocAwpA4vJslTLl25v6TqYwDPuc/dS1zvtpPz2k28 lRgFBPeTnk1BVFNpEnJSWwnsds5omm1fcBaEeGgEmpkrPrzwjnWs2B/QtsA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484mcrmy8x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 18:00:20 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-23fe984fe57so15766315ad.0 for ; Fri, 01 Aug 2025 11:00:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754071219; x=1754676019; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JAyYn1wklNQc4y389Esg9VJ4y6TS3xXtsI3mzf8UH2Q=; b=S5XjVzxhvRq7e7IU9qlmi7+Hl97HcHizJ2ANCEokWTKUl2uM9yCHFWI5LPCxnwwcdA uz9C5yQlsKDQkEWC2QvhV97K0kywr4n/Dr8jmMrIHrwSFNdmoW0ALZgh6oi2e1GTJ3xP TvFz63V3DV+Nf3WFfTEKrmflEpwT9FI1bNDmymtXN/QHtnKU6ofkHtMcb+ejEgXQIUnl +rgNBYsxsywv2qHWacPgV23UYOvVCG2aaHGJA3LEqMypoY4NLR5zDprdbfLH4E1bThoS 1TOzyhMpSyKdCuBqloAA3mlcQfoHUU2dRkvvSdPKmXetIoAPY+r/BDPZArjNRoPzVzoK Q0yw== X-Forwarded-Encrypted: i=1; AJvYcCVZPCBI/+mk48QdTn02RwxNUhJu90e0I7oeZtmCGwc4Xe/I0mdwRes/Oguv/qazO+QSxctS05A4xEDVZEk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc2i682dq1tsm42zGMJo2AmlmxhcZDcAoMh51oaqEpmtK0p2Ih VmZquL+H2d93OCyZbczN4nUFuOWn6U2lUuekY02gJkD/0TiK3aE/zspkOy5fB4i6uYBp7vPqm4N 6Z2SFbULURI742Qkw+2Cn/Ku9N7IslODmnfqcezy26b1w2lrKXJDvPmNyL0iEqXFTq0o= X-Gm-Gg: ASbGncvy8DfkwgKkaOzRcuHJf8wXt5/0PbPN967dWHcY3hF8k272Y63Z1kaZRbGjw7o grVf9+l+0ebG6XfCUuWEvRKcCXAWsgM0Mpn9/9lsZxf3CrAymnsHV8it5TzoRRyBQkzi+R/V8io a0mKqJI80u74WmcjON2Mx2l1BuAWQ0e+EBIrW1+49OZSNX0svo9CAjkxwJB3fcxVqOaXhZI8xWO Y6yuj+cwaSQMvWTyMuz/f1Uyi8CalRybZpo4SPXdwHX8/CUDrkgrwblQihsHN8Ts5eW4ToZYaO+ VBjcUIkZ5gH59USV9OUkyOhLA6SussLYeSxnPF8NwcZi7cCX2+Q= X-Received: by 2002:a17:903:110c:b0:235:f078:4746 with SMTP id d9443c01a7336-24247030c77mr4913525ad.42.1754071218964; Fri, 01 Aug 2025 11:00:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFq88m/8XtM65tFOPvwPzp0RMN6Lo0LKYxRrxCCtaSzhjaCvj19hJqOoPXnJBjwX5k93B39mA== X-Received: by 2002:a17:903:110c:b0:235:f078:4746 with SMTP id d9443c01a7336-24247030c77mr4912905ad.42.1754071218424; Fri, 01 Aug 2025 11:00:18 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241e899b43dsm48563275ad.136.2025.08.01.11.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 11:00:17 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Connor Abbott , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 3/7] drm/msm: Fix order of selector programming in cluster snapshot Date: Fri, 1 Aug 2025 11:00:00 -0700 Message-ID: <20250801180009.345662-4-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> References: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEzOCBTYWx0ZWRfX6MM5Hh7AYiF4 81C8dWmLbjRI/OjvqxH3fk9/iTV65H6ZvBo4d5vdPEU+ONfk0yrCtkfVnlE69UZQBfe09fACPFS MAMSV8oPYJVUF99oM1E96WkSqkzdNfd6L6JsY/XcbrjEyE7k4FzAHy7S7HOPLP61eT832nwJR0P kG7yzsBSBdUAEwuVWxl0c+lDxSkg3zD+Osv3rseMeBLlul3o2SCSZpi78DI+xJwybIIESN6J1kC rngOEu3uJTx0Q9OwtfCQUKPSzubmO1VDhDgRfwTduRu1TvCqvM//JWArO7jGA8UZsSHIBY3HjII SvEcFQoOp5I1ZOTrlQZQBW2hrlMxo00vIGJHW+wtPAV2bcW7jjv8fXv4fBhDo7ouXZFPo4TpTvS axXp7dWnO9OTUytnUWIwOmzPvu1thHbdR7YAgChVjNXQJWkOdnphWXnV5/XVzCS4E4KKmIRo X-Authority-Analysis: v=2.4 cv=Hth2G1TS c=1 sm=1 tr=0 ts=688d00b4 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=5vtJ6i-I-lkEOiUwjbYA:9 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: ALMGQU-EgR5NP8gV-eZrNNJ_bj9m4EkJ X-Proofpoint-ORIG-GUID: ALMGQU-EgR5NP8gV-eZrNNJ_bj9m4EkJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_06,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 clxscore=1015 spamscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010138 Content-Type: text/plain; charset="utf-8" Program the selector _after_ selecting the aperture. This aligns with the downstream driver, and fixes a case where we were failing to capture ctx0 regs (and presumably what we thought were ctx1 regs were actually ctx0). Suggested-by: Akhil P Oommen Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/= msm/adreno/a6xx_gpu_state.c index a35cec606d59..5204b28fd7f9 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c @@ -759,15 +759,15 @@ static void a7xx_get_cluster(struct msm_gpu *gpu, size_t datasize; int i, regcount =3D 0; =20 - /* Some clusters need a selector register to be programmed too */ - if (cluster->sel) - in +=3D CRASHDUMP_WRITE(in, cluster->sel->cd_reg, cluster->sel->val); - in +=3D CRASHDUMP_WRITE(in, REG_A7XX_CP_APERTURE_CNTL_CD, A7XX_CP_APERTURE_CNTL_CD_PIPE(cluster->pipe_id) | A7XX_CP_APERTURE_CNTL_CD_CLUSTER(cluster->cluster_id) | A7XX_CP_APERTURE_CNTL_CD_CONTEXT(cluster->context_id)); =20 + /* Some clusters need a selector register to be programmed too */ + if (cluster->sel) + in +=3D CRASHDUMP_WRITE(in, cluster->sel->cd_reg, cluster->sel->val); + for (i =3D 0; cluster->regs[i] !=3D UINT_MAX; i +=3D 2) { int count =3D RANGE(cluster->regs, i); =20 --=20 2.50.1 From nobody Sun Oct 5 14:33:08 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DED628D8D0 for ; Fri, 1 Aug 2025 18:00:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071224; cv=none; b=A3vzm2Jji15Cqt/fv2j//N9pNfr4xpZOCakUpcEwbgNgm/lbJ7Z4ng/TOYQELc/ipfLtdkMQhK9gOm6wPJ/dT36vOj36+DGZVuKFzhhoVGg3j1BEgGwqWqfvZcjKL9NoPdUeUww3iuaVCy2F3aBrUohxzIeOAC6wz3Xt8QbS9Y4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071224; c=relaxed/simple; bh=ZlKkmrc5VgBg7YhDd9UGaHUUv0BCefJviYgw3wueiDI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PIIpRG8LjVhIpgYNCuJzGGzF8sVVYYIavvQILdUpTaaVdWVpKht0APicG7TzIJJtsrljGnEsXsahGmTZreG+S07tEx8GBlZRFmKIxPnJR3eDJcxCfXcBHHvkAKYXHoW2DGRJ5JrwZbko/hw8GFEuTnl0R6nYt94WFC1N7P3q/e8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d6czJdrb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d6czJdrb" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 571HfQZr030687 for ; Fri, 1 Aug 2025 18:00:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=hi1vgMO0Vv7 J21nNKfYLDG2T1ayUhJgydMOm04m2eGY=; b=d6czJdrbXACfHnZPn6JhECTGRA3 mTXLVnmT7RJABZleG2bEQfdlPuaRDGH9xFvd23aQ85qz26JZRjUUs/+DVD8+RuTB 99ovOLDtgKNVhmiTQCe2a8VWClrKwdwAfwbQ6Du0iwWKnrJJ5j1JxzGX69lt/PMx Q15/Y7/zPHnzaVeMh5vVvZeEuzK8jlAo9TRMJAC4lOIZYuUSRGzxOoX++LqVyJaz UBh3EWzgyRXPPZRadC/Nb0uYIzIb29MTguRlN10ecV145yDOlhVusKV0yjjC4SHr i7NGWY7k0PZM45NhUfvzAQolgeUdmr2epa23em2vtJQGtX67fERg62TCyLA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484nyudfmg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 18:00:21 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b0e0c573531so1896099a12.3 for ; Fri, 01 Aug 2025 11:00:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754071221; x=1754676021; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hi1vgMO0Vv7J21nNKfYLDG2T1ayUhJgydMOm04m2eGY=; b=DxYaAdA7sREVh+yvFFYmxLWIZlzVj9SbgKMg0uUA7LVyK/JramJgoaTj58oYkNf9mI koBrU1BRkwUwuzjf5gULC8jxCKHzikyqrkMBXQ6lY5PDtoaJ1A4ls268O/Ywr37DEhEn ZCe/LNf67nV09TZkCPPdUVzYbQ7CTOyU7XmaDhTiiVA56LNWecn3ySR/+nUoUc19LiAu UZelxh39UW8oFzfvlN5AmfyUms3gh/0cX4uORQ8Yrt3P5zSWjT98eRNLq+5QzVrbwnr+ gCy6tJAU3itq/PhWdxccjJJXHeLKi9ecP8YeNaoHmL7DmQgDkh4OvFdWbOG2KJIaUvnG 3nrg== X-Forwarded-Encrypted: i=1; AJvYcCX8I9F+1+Cf3wVIfz7Qhdt9Cr9kZvYEfNMv7BH537n1Ppv945eOX5dAkkSvcwy47hooX9KHdGfhQnMwtCk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1TpBBAPb49m4S2aNj+nQ0RpNbuUXl1bZDigh5fGZiBU8VO2jr ++kC+1ldEwItzcf93arC64sf2FjU2c2Yg9zYQ9or5hkuer2JI7Hdr/t32MouBfnRQuBD9Tq0TrT V63xUe5xMPUNF1CedXgQ9eG9G5nzg67NqoMrSyMww7flWfa1aK21WDujlzBYGwVnXJskGd0rAor g= X-Gm-Gg: ASbGncshsd8FknrI3E1aDy3B/F1P1K/rlSU/shQaQH+7IdwLWo4srxEcC38/U7+dZiJ jqHKHzVCuOBnVJ+pj9p+IWNcv/lIhkxG9zD/hPgD/lfjMGV9Eqqgn5dqJqmbVJDhqkVqZ3zvawy Wi5P5C4HejbqSdgZBMP2Zoqou4RjeNtlROn26z5QiUfzHjmtAHJ5gimdm+lkfvl5OTMp2tzXRdP GRzoxjigkdl170/d6FTtlnEraUPsetiiShREV6yQ+ariJNAzM3HFXROxeUZufcOz9pB7uEYMfDa 3UymdAYfSZeNSrmtAaer8Zum1m+n9fMZVVhoSfdOYYBObFUD+sg= X-Received: by 2002:a05:6a20:7486:b0:22d:fd6:95e0 with SMTP id adf61e73a8af0-23df8fa1de7mr868838637.11.1754071220367; Fri, 01 Aug 2025 11:00:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6mgJb3hkI3FjCFdZoHfiotilqYID1iNK88urHoLYa/fSW4RsyuIEp7AhFOrCT6Y4ZIAhoow== X-Received: by 2002:a05:6a20:7486:b0:22d:fd6:95e0 with SMTP id adf61e73a8af0-23df8fa1de7mr868773637.11.1754071219906; Fri, 01 Aug 2025 11:00:19 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b422baedf5csm4238296a12.47.2025.08.01.11.00.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 11:00:19 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Connor Abbott , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 4/7] drm/msm: Constify snapshot tables Date: Fri, 1 Aug 2025 11:00:01 -0700 Message-ID: <20250801180009.345662-5-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> References: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: OolGnUlQ20ntxg0qZE_B6Ygze-0QEGVU X-Proofpoint-ORIG-GUID: OolGnUlQ20ntxg0qZE_B6Ygze-0QEGVU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEzOCBTYWx0ZWRfXyEo+Xidzqqu6 gBM9vwIFOIOMvgI92aZlA/oA31PKQLO+6LPVOVKV4tlcgn6vKCidLNQOl2TRkdPQkqqz7D5vGl8 wmCi3dMXjt+Wo7jwscrPQcg7Niu0xyroLkiqXrQMvuPEmOLwmSUz8D23WYSIXTabgBsijUfenA5 Ub7pl6IVD9f8hSQMUkl8ejR2jg3wkSYlmkXI4+322/GBz8cskoWl3i+CKyXUBkfWFMc2FzDZ6ib Wg6/qFYR0mWjZC87NW7TRrbEPzhVsQ7IfHm740Hb/N0qKPuhLmXiKJkQPCZsBtZQPcnuvRF1Xbi niV63Wu6ig8FWfnAXukYtxexe9wLEhJXRNoNJpKopIQ07k3e2h7axZyXO0RJuMvpSudVRvnZRp3 +bD/9m0XXvGZaaisEs54RJkla6K2q0UuuFz4tFZHoWFXyX80OIb0zZM1mMh4VEvm1ynlHkYu X-Authority-Analysis: v=2.4 cv=CLoqXQrD c=1 sm=1 tr=0 ts=688d00b5 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=3YnKlkqyfxy5QV46dWoA:9 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_06,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 clxscore=1015 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010138 Content-Type: text/plain; charset="utf-8" A bit of divergence from the downstream driver from which these headers were imported. But no need for these tables not to be const. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_gen7_0_0_snapshot.h | 8 ++++---- drivers/gpu/drm/msm/adreno/adreno_gen7_2_0_snapshot.h | 8 ++++---- drivers/gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h | 10 +++++----- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/= msm/adreno/a6xx_gpu_state.c index 5204b28fd7f9..173c14f215a7 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c @@ -11,7 +11,7 @@ static const unsigned int *gen7_0_0_external_core_regs[] __always_unused; static const unsigned int *gen7_2_0_external_core_regs[] __always_unused; static const unsigned int *gen7_9_0_external_core_regs[] __always_unused; -static struct gen7_sptp_cluster_registers gen7_9_0_sptp_clusters[] __alway= s_unused; +static const struct gen7_sptp_cluster_registers gen7_9_0_sptp_clusters[] _= _always_unused; static const u32 gen7_9_0_cx_debugbus_blocks[] __always_unused; =20 #include "adreno_gen7_0_0_snapshot.h" diff --git a/drivers/gpu/drm/msm/adreno/adreno_gen7_0_0_snapshot.h b/driver= s/gpu/drm/msm/adreno/adreno_gen7_0_0_snapshot.h index cb66ece6606b..afcc7498983f 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gen7_0_0_snapshot.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gen7_0_0_snapshot.h @@ -81,7 +81,7 @@ static const u32 gen7_0_0_debugbus_blocks[] =3D { A7XX_DBGBUS_USPTP_7, }; =20 -static struct gen7_shader_block gen7_0_0_shader_blocks[] =3D { +static const struct gen7_shader_block gen7_0_0_shader_blocks[] =3D { {A7XX_TP0_TMO_DATA, 0x200, 4, 2, A7XX_PIPE_BR, A7XX_USPTP= }, {A7XX_TP0_SMO_DATA, 0x80, 4, 2, A7XX_PIPE_BR, A7XX_USPTP= }, {A7XX_TP0_MIPMAP_BASE_DATA, 0x3c0, 4, 2, A7XX_PIPE_BR, A7XX_USPTP= }, @@ -695,7 +695,7 @@ static const struct gen7_sel_reg gen7_0_0_rb_rbp_sel = =3D { .val =3D 0x9, }; =20 -static struct gen7_cluster_registers gen7_0_0_clusters[] =3D { +static const struct gen7_cluster_registers gen7_0_0_clusters[] =3D { { A7XX_CLUSTER_NONE, A7XX_PIPE_BR, STATE_NON_CONTEXT, gen7_0_0_noncontext_pipe_br_registers, }, { A7XX_CLUSTER_NONE, A7XX_PIPE_BV, STATE_NON_CONTEXT, @@ -764,7 +764,7 @@ static struct gen7_cluster_registers gen7_0_0_clusters[= ] =3D { gen7_0_0_vpc_cluster_vpc_ps_pipe_bv_registers, }, }; =20 -static struct gen7_sptp_cluster_registers gen7_0_0_sptp_clusters[] =3D { +static const struct gen7_sptp_cluster_registers gen7_0_0_sptp_clusters[] = =3D { { A7XX_CLUSTER_NONE, A7XX_SP_NCTX_REG, A7XX_PIPE_BR, 0, A7XX_HLSQ_STATE, gen7_0_0_sp_noncontext_pipe_br_hlsq_state_registers, 0xae00 }, { A7XX_CLUSTER_NONE, A7XX_SP_NCTX_REG, A7XX_PIPE_BR, 0, A7XX_SP_TOP, @@ -914,7 +914,7 @@ static const u32 gen7_0_0_dpm_registers[] =3D { }; static_assert(IS_ALIGNED(sizeof(gen7_0_0_dpm_registers), 8)); =20 -static struct gen7_reg_list gen7_0_0_reg_list[] =3D { +static const struct gen7_reg_list gen7_0_0_reg_list[] =3D { { gen7_0_0_gpu_registers, NULL }, { gen7_0_0_cx_misc_registers, NULL }, { gen7_0_0_dpm_registers, NULL }, diff --git a/drivers/gpu/drm/msm/adreno/adreno_gen7_2_0_snapshot.h b/driver= s/gpu/drm/msm/adreno/adreno_gen7_2_0_snapshot.h index 6f8ad50f32ce..6569f12bf12f 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gen7_2_0_snapshot.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gen7_2_0_snapshot.h @@ -95,7 +95,7 @@ static const u32 gen7_2_0_debugbus_blocks[] =3D { A7XX_DBGBUS_CCHE_2, }; =20 -static struct gen7_shader_block gen7_2_0_shader_blocks[] =3D { +static const struct gen7_shader_block gen7_2_0_shader_blocks[] =3D { {A7XX_TP0_TMO_DATA, 0x200, 6, 2, A7XX_PIPE_BR, A7XX_USPTP= }, {A7XX_TP0_SMO_DATA, 0x80, 6, 2, A7XX_PIPE_BR, A7XX_USPTP= }, {A7XX_TP0_MIPMAP_BASE_DATA, 0x3c0, 6, 2, A7XX_PIPE_BR, A7XX_USPTP= }, @@ -489,7 +489,7 @@ static const struct gen7_sel_reg gen7_2_0_rb_rbp_sel = =3D { .val =3D 0x9, }; =20 -static struct gen7_cluster_registers gen7_2_0_clusters[] =3D { +static const struct gen7_cluster_registers gen7_2_0_clusters[] =3D { { A7XX_CLUSTER_NONE, A7XX_PIPE_BR, STATE_NON_CONTEXT, gen7_2_0_noncontext_pipe_br_registers, }, { A7XX_CLUSTER_NONE, A7XX_PIPE_BV, STATE_NON_CONTEXT, @@ -558,7 +558,7 @@ static struct gen7_cluster_registers gen7_2_0_clusters[= ] =3D { gen7_0_0_vpc_cluster_vpc_ps_pipe_bv_registers, }, }; =20 -static struct gen7_sptp_cluster_registers gen7_2_0_sptp_clusters[] =3D { +static const struct gen7_sptp_cluster_registers gen7_2_0_sptp_clusters[] = =3D { { A7XX_CLUSTER_NONE, A7XX_SP_NCTX_REG, A7XX_PIPE_BR, 0, A7XX_HLSQ_STATE, gen7_0_0_sp_noncontext_pipe_br_hlsq_state_registers, 0xae00 }, { A7XX_CLUSTER_NONE, A7XX_SP_NCTX_REG, A7XX_PIPE_BR, 0, A7XX_SP_TOP, @@ -737,7 +737,7 @@ static const u32 gen7_2_0_dpm_registers[] =3D { }; static_assert(IS_ALIGNED(sizeof(gen7_2_0_dpm_registers), 8)); =20 -static struct gen7_reg_list gen7_2_0_reg_list[] =3D { +static const struct gen7_reg_list gen7_2_0_reg_list[] =3D { { gen7_2_0_gpu_registers, NULL }, { gen7_2_0_cx_misc_registers, NULL }, { gen7_2_0_dpm_registers, NULL }, diff --git a/drivers/gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h b/driver= s/gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h index b1f8bbf1d843..0956dfca1f05 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h @@ -117,7 +117,7 @@ static const u32 gen7_9_0_cx_debugbus_blocks[] =3D { A7XX_DBGBUS_GBIF_CX, }; =20 -static struct gen7_shader_block gen7_9_0_shader_blocks[] =3D { +static const struct gen7_shader_block gen7_9_0_shader_blocks[] =3D { { A7XX_TP0_TMO_DATA, 0x0200, 6, 2, A7XX_PIPE_BR, A7XX_USPTP }, { A7XX_TP0_SMO_DATA, 0x0080, 6, 2, A7XX_PIPE_BR, A7XX_USPTP }, { A7XX_TP0_MIPMAP_BASE_DATA, 0x03C0, 6, 2, A7XX_PIPE_BR, A7XX_USPTP }, @@ -1116,7 +1116,7 @@ static const struct gen7_sel_reg gen7_9_0_rb_rbp_sel = =3D { .val =3D 0x9, }; =20 -static struct gen7_cluster_registers gen7_9_0_clusters[] =3D { +static const struct gen7_cluster_registers gen7_9_0_clusters[] =3D { { A7XX_CLUSTER_NONE, A7XX_PIPE_BR, STATE_NON_CONTEXT, gen7_9_0_non_context_pipe_br_registers, }, { A7XX_CLUSTER_NONE, A7XX_PIPE_BV, STATE_NON_CONTEXT, @@ -1185,7 +1185,7 @@ static struct gen7_cluster_registers gen7_9_0_cluster= s[] =3D { gen7_9_0_vpc_pipe_bv_cluster_vpc_ps_registers, }, }; =20 -static struct gen7_sptp_cluster_registers gen7_9_0_sptp_clusters[] =3D { +static const struct gen7_sptp_cluster_registers gen7_9_0_sptp_clusters[] = =3D { { A7XX_CLUSTER_NONE, A7XX_SP_NCTX_REG, A7XX_PIPE_BR, 0, A7XX_HLSQ_STATE, gen7_9_0_non_context_sp_pipe_br_hlsq_state_registers, 0xae00}, { A7XX_CLUSTER_NONE, A7XX_SP_NCTX_REG, A7XX_PIPE_BR, 0, A7XX_SP_TOP, @@ -1294,7 +1294,7 @@ static struct gen7_sptp_cluster_registers gen7_9_0_sp= tp_clusters[] =3D { gen7_9_0_tpl1_pipe_br_cluster_sp_ps_usptp_registers, 0xb000}, }; =20 -static struct a6xx_indexed_registers gen7_9_0_cp_indexed_reg_list[] =3D { +static const struct a6xx_indexed_registers gen7_9_0_cp_indexed_reg_list[] = =3D { { "CP_SQE_STAT", REG_A6XX_CP_SQE_STAT_ADDR, REG_A6XX_CP_SQE_STAT_DATA, 0x00040}, { "CP_DRAW_STATE", REG_A6XX_CP_DRAW_STATE_ADDR, @@ -1337,7 +1337,7 @@ static struct a6xx_indexed_registers gen7_9_0_cp_inde= xed_reg_list[] =3D { REG_A7XX_CP_AQE_STAT_DATA_1, 0x00040}, }; =20 -static struct gen7_reg_list gen7_9_0_reg_list[] =3D { +static const struct gen7_reg_list gen7_9_0_reg_list[] =3D { { gen7_9_0_gpu_registers, NULL}, { gen7_9_0_cx_misc_registers, NULL}, { gen7_9_0_cx_dbgc_registers, NULL}, --=20 2.50.1 From nobody Sun Oct 5 14:33:08 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0599E1F3BBB for ; Fri, 1 Aug 2025 18:00:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071225; cv=none; b=L3lv1SNnoyaF0bU2yVdwEqEICNOojcaxa+XwPP2xZdLz90cMm1kdGA7E92BmZSmTFkkYiYC6OiJ8IWBcwkHt8S8EhKVWuuj4Urw/JILazsSqFuWYwpGpMODmaixa2iKPs+CZ7s7SH3Tm8aCfZ94JoZtPXiOiqhTKNv+oKWGNp8U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071225; c=relaxed/simple; bh=9fs+9v5YYJG2O8rReWV91gfGQBXOKP9cTCTwMY+QlIk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uk3jGQocUVt5HZQRd2ZkIgj7UKODs6/iHQmeEK55bfrCm91/YmYm7/cD1I6R9bwcp46o9awibUEnjPrqkEz2S6XIEJrEUfr0DcOx9sFbxsg6VrOEEF/tcUCpRD+mU1CJPvPcLlWz1SBVXXN9sXdAtq/OfNDn5tD16fJYy7Yyrio= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kKlD83Pp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kKlD83Pp" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 571Hg8E9008568 for ; Fri, 1 Aug 2025 18:00:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=c4KQRsxVztP sTBbcxsf/rU0NN9GCrtgWESCaGZHxR9Y=; b=kKlD83PpUsSxT+R9tgtLKssh7oa axtF6CJtuTg5VLR1lshYjT5/h82lbogM/aA8syWTCnGjh+JXEDBI9rsaZ0T1Iv6U JihWXcgAAaUxL5EV36kx/BSpbuyYFRxK6J0QiTt19S+87SbaeNNWOm7d0nXOr5p3 QWbz2beTVcQgppV+Ok7D4tlCyFHXAIFcNED1k9B0l+RvIoxFI4ZLxiVjVW1AUio9 haVhuAL4ZSQHHGvyWvv/oQ+/6GKE+qsfbeMFuTzgJep3tY0OknlZcBvcFzVRqlQo KZMKqEnEQIpeBtmWX+IGWLIwT6ayQiu3weljB1rfEHWIFqbBDKGuuOxOs+w== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 487jwghc5p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 18:00:23 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b3f76a5ba7fso864417a12.1 for ; Fri, 01 Aug 2025 11:00:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754071222; x=1754676022; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c4KQRsxVztPsTBbcxsf/rU0NN9GCrtgWESCaGZHxR9Y=; b=jFzMJog1humFp8V68gEwNjEe4Bq6Hb7+05R/CqogPFXO5mN6cpzlM3s+HWSInqv7PE OIBnga9hqyzxo0DjFS5x/P2C/bFjfv8JWN2Htyg9w/ZhIkpk6TTP79fP6KoYDZyvlWq3 Yppss90oPJby00MbXTxUDLrWuAhTvLiQVEL/CObx+Av8J+XpAmaaQhy064QfpNTirHaf i46RZ80fQj95mYNKlFsncgyd/qSfT/YojsS15+xw7nLsmmyPQHpMgqX5E1ilRHEVzrhu zYJlzA7HSCEpTxQqvypwaRjpsbPOx6nzzWe0OgTIKpX3LP1bzMtSt9d0mbAC3UWq8+Tw ppYw== X-Forwarded-Encrypted: i=1; AJvYcCUC92A9EH9HVekKgsK2BA0nFB/PLsUMEw1gz2rLJKguBoMUiimqojev9GiKSy5VrAhhduWiIidt1+xsCm8=@vger.kernel.org X-Gm-Message-State: AOJu0YyLakuadnUV6wCxXW9GD/JWtsmwogQwzYTCvOORDLoO57clw6Br h+lNTieslrUZvg8zj4b9wXiRWpDJ2ppg+TPqUa0NBp72AoHcxABq2SyUNAz7B1WcvceT8BJMnoR YO3aN6hGwlLrZtysPD1Mn+nPUPk8e61OcmQDwPbRwgB+ScQ9ur3mH5PuxKNJDS+yMxLo= X-Gm-Gg: ASbGncsNv0eiynnsIU2qvd8xhKFWpSNCgkJsgWqqE4e2Tc2OOd4mtW0kITFB/zwKDqu ciYUxjqAORVTGB08JSkDSKBOQqO4yZEFx4JUq0aRmMqrGmvuscU/16FDMCzoCUCs1fYeZoSvlRB FAHYHIlg0TKW6kspHS1m0iodaTbJ45fG8JbIjMohc+eI86/DzCEqipoZoS/hmhOiUS5qIfWX7DM 1oO7IdB1w/Q5Wji8aaGUBrxG8DvDXjZdOKgTrZdgGIPaEVVuWNUX9cOdcZbV43HD8NK5lTATcw1 9p00o3ZCczeFccUrg0ril3wvGrEomYl0y8wB3Oy9qA2kC2sshGs= X-Received: by 2002:a17:90b:1d4c:b0:312:959:dc42 with SMTP id 98e67ed59e1d1-321161f13afmr971394a91.11.1754071222043; Fri, 01 Aug 2025 11:00:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHuZ5/YHyU5W5/PGpq9mfkW8lN3EVfPrvr2fz5DIS9QKgNMf1X1fXg1DmF3I6ux4H1PpGawMA== X-Received: by 2002:a17:90b:1d4c:b0:312:959:dc42 with SMTP id 98e67ed59e1d1-321161f13afmr971344a91.11.1754071221443; Fri, 01 Aug 2025 11:00:21 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b422bb0be58sm3946576a12.57.2025.08.01.11.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 11:00:20 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Connor Abbott , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 5/7] drm/msm: Fix a7xx debugbus read Date: Fri, 1 Aug 2025 11:00:02 -0700 Message-ID: <20250801180009.345662-6-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> References: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=WvgrMcfv c=1 sm=1 tr=0 ts=688d00b7 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=aM-jV3debDdmslfU2skA:9 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-ORIG-GUID: Kek7M-kqQYwSWl46Niw6FqssVqUb9lBa X-Proofpoint-GUID: Kek7M-kqQYwSWl46Niw6FqssVqUb9lBa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEzOCBTYWx0ZWRfX0NBedZLkvrTB vIfQvgYHSaXW6On/wNwhFhGrH9pA1bO5808R7af+oSINjCH/HWq8Gk23qaL1QtnA/bxb71Cs+ob lAizX7QrAeacPfNsRWkXLPZfmV1A4rYMf4XNICoCoK5BYnizW8F/xdkO18KCoAt4Y2uNn0vF+xv Q66/ks5a47nCiT02/7lkIcXjAWqpAawsZj4b2H1zfOA65UKD92q8BiUaGzlBTaLcoSFQyYZQajP YgZ3jLksl/t/laUgKbB0lCPunHyGTSxngtgUY9oxwRzC+DB7UaHu48J+ZlCz8omRVYz1ji9mXTl b96u/woykL/YoB4p2Ja0nA2J4EEFqAPHwPRVHPnLVTabcYNz1/3/bzxqmtOg7BEvx/bAC4bFj0l ai/4prULSDTmRqWZwFYuw7eKE10OnF4LXS0sJfGDaaE1ejXXQ4XOUTw71mneKNtdQeI/46TK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_06,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 impostorscore=0 adultscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010138 Content-Type: text/plain; charset="utf-8" The bitfield positions changed in a7xx. v2: Don't open-code the bitfield building v3: Also fix cx_debugbus Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 32 ++++++++++++++----- drivers/gpu/drm/msm/registers/adreno/a6xx.xml | 14 +++++++- 2 files changed, 37 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/= msm/adreno/a6xx_gpu_state.c index 173c14f215a7..2c7a52fb0b9b 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c @@ -174,8 +174,15 @@ static int a6xx_crashdumper_run(struct msm_gpu *gpu, static int debugbus_read(struct msm_gpu *gpu, u32 block, u32 offset, u32 *data) { - u32 reg =3D A6XX_DBGC_CFG_DBGBUS_SEL_D_PING_INDEX(offset) | - A6XX_DBGC_CFG_DBGBUS_SEL_D_PING_BLK_SEL(block); + u32 reg; + + if (to_adreno_gpu(gpu)->info->family >=3D ADRENO_7XX_GEN1) { + reg =3D A7XX_DBGC_CFG_DBGBUS_SEL_D_PING_INDEX(offset) | + A7XX_DBGC_CFG_DBGBUS_SEL_D_PING_BLK_SEL(block); + } else { + reg =3D A6XX_DBGC_CFG_DBGBUS_SEL_D_PING_INDEX(offset) | + A6XX_DBGC_CFG_DBGBUS_SEL_D_PING_BLK_SEL(block); + } =20 gpu_write(gpu, REG_A6XX_DBGC_CFG_DBGBUS_SEL_A, reg); gpu_write(gpu, REG_A6XX_DBGC_CFG_DBGBUS_SEL_B, reg); @@ -198,11 +205,18 @@ static int debugbus_read(struct msm_gpu *gpu, u32 blo= ck, u32 offset, readl((ptr) + ((offset) << 2)) =20 /* read a value from the CX debug bus */ -static int cx_debugbus_read(void __iomem *cxdbg, u32 block, u32 offset, +static int cx_debugbus_read(struct msm_gpu *gpu, void __iomem *cxdbg, u32 = block, u32 offset, u32 *data) { - u32 reg =3D A6XX_CX_DBGC_CFG_DBGBUS_SEL_A_PING_INDEX(offset) | - A6XX_CX_DBGC_CFG_DBGBUS_SEL_A_PING_BLK_SEL(block); + u32 reg; + + if (to_adreno_gpu(gpu)->info->family >=3D ADRENO_7XX_GEN1) { + reg =3D A7XX_CX_DBGC_CFG_DBGBUS_SEL_A_PING_INDEX(offset) | + A7XX_CX_DBGC_CFG_DBGBUS_SEL_A_PING_BLK_SEL(block); + } else { + reg =3D A6XX_CX_DBGC_CFG_DBGBUS_SEL_A_PING_INDEX(offset) | + A6XX_CX_DBGC_CFG_DBGBUS_SEL_A_PING_BLK_SEL(block); + } =20 cxdbg_write(cxdbg, REG_A6XX_CX_DBGC_CFG_DBGBUS_SEL_A, reg); cxdbg_write(cxdbg, REG_A6XX_CX_DBGC_CFG_DBGBUS_SEL_B, reg); @@ -315,7 +329,8 @@ static void a6xx_get_debugbus_block(struct msm_gpu *gpu, ptr +=3D debugbus_read(gpu, block->id, i, ptr); } =20 -static void a6xx_get_cx_debugbus_block(void __iomem *cxdbg, +static void a6xx_get_cx_debugbus_block(struct msm_gpu *gpu, + void __iomem *cxdbg, struct a6xx_gpu_state *a6xx_state, const struct a6xx_debugbus_block *block, struct a6xx_gpu_state_obj *obj) @@ -330,7 +345,7 @@ static void a6xx_get_cx_debugbus_block(void __iomem *cx= dbg, obj->handle =3D block; =20 for (ptr =3D obj->data, i =3D 0; i < block->count; i++) - ptr +=3D cx_debugbus_read(cxdbg, block->id, i, ptr); + ptr +=3D cx_debugbus_read(gpu, cxdbg, block->id, i, ptr); } =20 static void a6xx_get_debugbus_blocks(struct msm_gpu *gpu, @@ -526,7 +541,8 @@ static void a6xx_get_debugbus(struct msm_gpu *gpu, int i; =20 for (i =3D 0; i < nr_cx_debugbus_blocks; i++) - a6xx_get_cx_debugbus_block(cxdbg, + a6xx_get_cx_debugbus_block(gpu, + cxdbg, a6xx_state, &cx_debugbus_blocks[i], &a6xx_state->cx_debugbus[i]); diff --git a/drivers/gpu/drm/msm/registers/adreno/a6xx.xml b/drivers/gpu/dr= m/msm/registers/adreno/a6xx.xml index d860fd94feae..86fab2750ba7 100644 --- a/drivers/gpu/drm/msm/registers/adreno/a6xx.xml +++ b/drivers/gpu/drm/msm/registers/adreno/a6xx.xml @@ -594,10 +594,14 @@ by a particular renderpass/blit. - + + + + + @@ -3796,6 +3800,14 @@ by a particular renderpass/blit. =20 + + + + + + + + --=20 2.50.1 From nobody Sun Oct 5 14:33:08 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2CCF28ECD1 for ; Fri, 1 Aug 2025 18:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071228; cv=none; b=pGB1Uf3Vr2CAGWwET8njWRXF0Oysq0O4n6gzcCOuGCeQ001vUwR6u8HurtHoK7TlKWh2TzxWEgh9Bqe3Ji3wWnfXb+eC4kxN6K9GgpGlIIyb0Lj2hMMx9kcKEkZumnpdvIuZCh4wN28Z+CnPdOKzt3JquAG1lYJwcCQdlM5kGfY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071228; c=relaxed/simple; bh=L/zCN5DqVWoqFJzonuWzb53I2szPlr/4Jcv/Fb8vfd0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QH+czqQVm5wv2GXBVuqYSxSqvjSEiM1v3zwaubAs2+yG/oTSaOeKK1MVv/m2MacIHJlfVBqyK+/kAu5xoxtWHqmF0W4uQ32ARK4uRCHwZZ4SejO0PTEiW9zE8t8mFvSHyM4n0iBlJxkwQG9cIzS7i8Cdn6nRv9x8sRudfdJy37I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GmOizVTF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GmOizVTF" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 571Hg9iS008585 for ; Fri, 1 Aug 2025 18:00:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=3TY7JajUGvg SQAFX3ZoHDjZ0l2tg+rnsIJNFhfiXB5I=; b=GmOizVTFpFkXh8LhaF8YLtKApVo 4TfIABwqGfxA73oKsdDx699Dvb1VgoTq9XgleS0+7GOMI88g7klEjKW8R6oBwWDT 55jd3WJDZZusaPyam3JgmK3W31YzkcVQgUwk/SIF2moOs3CGyMlLWioiMpWK23EU 7WveXX9E6ihf+CijRH9+Lm6F4c6ox9piNFH+QY37X5XcVLNjpfRaNGmel4+JLlaO pD66DNl5cMAFZCqmWGexPnyG8v4MFfYKuyclH1U1lazq002YjO7neXWwmrCufRN0 kuAkunvG9fZjnRVa8SR/dxub3UFl9blVg97QGG/eDd4RPFgjKakAesguVVw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 487jwghc60-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 18:00:25 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-31edd69d754so1175530a91.1 for ; Fri, 01 Aug 2025 11:00:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754071225; x=1754676025; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3TY7JajUGvgSQAFX3ZoHDjZ0l2tg+rnsIJNFhfiXB5I=; b=TYeKp8+/YxpwIDjO+dLQuNld+9ROsDIlkAhHfY7JrP6GMv/DFyOWbxYkUk+rU2XFM1 MOmdWtgs+2fLNG32/Rt22XfJN9YJn6ac21/9XbLxzFtv9n5Vtsy4Trj/5apbTEOYdAQv bRxY8SGrhAs/K5Ss95OMEIplviB9zTLh62HUKYXt9AETE/tDbZ9ey5lVOCxT5YJYrBm9 vcPJZbecwAkPckf+qg8D+25d2U+/HdQoAy8cDVZaczHMOTFGrX3MlBs+dKgSHebJQo6A dnJ7//OWS7H2YV8rJrHi7eVTF5kIoQB0rs0xcWlTikWI3u+iuzDmJcx/fqZjyf7po2s1 QqGQ== X-Forwarded-Encrypted: i=1; AJvYcCWXCqpUX/NSoFPbl3snTgPHsb3idqsQEvyLJbckvR8T0udoYOEY34XNfgS5A3TuyDbaS2EoGhtYVjHKlnY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7hu1gR/efnuTL5VdhaCGAMhUJXDFM3nskQ5JSd1bODWiJRLNi 11O/G80TB7duIdv4O7Q4voIxdQsONmy46rw0HaBo1YFTKrS2ta11POpoHeJLXBUf8Fc5fxID6uP s1Hk366pU3tFCHPNZnKuegPK9lILc8ZwvOFyFOXIfqluloQJSWAINgjNu99g/mtP8LeU= X-Gm-Gg: ASbGncuvnhkDpK75ETW0yQRuFgt+UX/fqUz+uH6ddZCmzp9lAG2VCSmyc3VLzDL2ybS r+NescHnvO2eQBVnAHa+/w8FWr+9vMW6ebMf9C/XeIS0oqOZ72Vaw77FpSSbWdEqHmvtN4sUCQn QBcLHZGJCCFSEcbtFRlwKsP2BiR54+Q4v55As6gpWFfaadt3ZA2z297Nbe/Ry+pkInE4Ydx7a2i mw3/w/o1hhQBc2jlCffYWhtyNWmFxsFs2hhIoCNaIjZs5HJriLDrYoe30aH6GeCBCeJDvoGf3NC cCvgJPJdggEDRVleXDjCWEP9coKSe0LB10NAXhxA0RYDITkFflA= X-Received: by 2002:a17:90b:2246:b0:320:fe6d:860a with SMTP id 98e67ed59e1d1-3211629d087mr935851a91.18.1754071224714; Fri, 01 Aug 2025 11:00:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEX5MtZHVrDtRtNwnDqwNS5CiFJn1C83bZxhXU0qOaY2Ye0o4TdoGfd9YmU32DzzAJKMfk9aQ== X-Received: by 2002:a17:90b:2246:b0:320:fe6d:860a with SMTP id 98e67ed59e1d1-3211629d087mr935769a91.18.1754071224045; Fri, 01 Aug 2025 11:00:24 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31f63c25f0dsm8105815a91.0.2025.08.01.11.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 11:00:23 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Connor Abbott , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 6/7] drm/msm: Fix debugbus snapshot Date: Fri, 1 Aug 2025 11:00:03 -0700 Message-ID: <20250801180009.345662-7-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> References: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=WvgrMcfv c=1 sm=1 tr=0 ts=688d00b9 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=Q8ed3UK4sgpFGPsrdooA:9 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: qqeJA-Jw7gojhLaiJZc9-n8s21wzYUU1 X-Proofpoint-GUID: qqeJA-Jw7gojhLaiJZc9-n8s21wzYUU1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEzOCBTYWx0ZWRfX+gXjuXj+yFXA dU108HOSe8n1tMx0CBWSQD2S4v8xIrzbREhmYSl0lEucYGWItmffjvkR4FLptRPa4AG2Iuj2KD0 ttX6fqTAYt3YydPkocmwd89VHGPkUGCMtz6hzBhyzkc+tdchkIc1iAAlTiYbnB6goOdfdchQA6o Ah7IOceeL3hIPDO8oNx3LkoSd+A47p8PmiPcT8vB/nxt6auWv+HsxCxVHWZUgTKjIazbXEEWFHH gTprFuSK/mppsFVE2ym4lTvF5bFa7WyfJ3vDMwTjgEi4M7eJdfbIL3ul238BedU37+aWp1MPehT zd8Ukm+HE5dzT8vUu2GUtpOGx6ZQa5StUIHNHAJzxRm59ND/PO0kAMDRclwu02qn9oq6hLNJV1n SXDkTIoNpMy900oME+euFm+WbYEGLm5cCj8HUPJGz/OzxEK/pGwSZa9yZt9WRNtWv1YiTANJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_06,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 impostorscore=0 adultscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010138 Content-Type: text/plain; charset="utf-8" We weren't setting the # of captured debugbus blocks. Reported-by: Connor Abbott Suggested-by: Connor Abbott Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/= msm/adreno/a6xx_gpu_state.c index 2c7a52fb0b9b..4c7f3c642f6a 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c @@ -438,8 +438,9 @@ static void a7xx_get_debugbus_blocks(struct msm_gpu *gp= u, a6xx_state, &a7xx_debugbus_blocks[gbif_debugbus_blocks[i]], &a6xx_state->debugbus[i + debugbus_blocks_count]); } - } =20 + a6xx_state->nr_debugbus =3D total_debugbus_blocks; + } } =20 static void a6xx_get_debugbus(struct msm_gpu *gpu, --=20 2.50.1 From nobody Sun Oct 5 14:33:08 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C4C728FA91 for ; Fri, 1 Aug 2025 18:00:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071231; cv=none; b=Fko6P9Qjk+7MMADi5bIleKJg/z5bDuvcrR7EqkZfoseTAKKk+ewdewPA8sjXEpWN20V3ewtXvcs6nXBF/u5mERBlLQkwXeGDLMIVeQ59M4/acVXyqocaE8McU7DeHxh+IiiqprJN1+qWzBH/9rXEQtuc4KrjMxpqHBW3GldRYrk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754071231; c=relaxed/simple; bh=a1xn1H8/fa/A9qraVB8eAftc2nCQicSPOhezcVcH5EQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YyERpszomfg15BZiH+u6e01Uga34RsLlpP6zsZgXcoKtRtZRbmp/R5mfjIvkIoQil7EWJPAUzxEUmIyoXk4IgKms/Pc7CDAP2w18vq9sN0ohi8hdxZjM+38Y1vdzUW/TMOLwk1cdAO/XU15+JvrQuoWyauBLZcDYLQz7NLmbwmk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aaNmEuGK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aaNmEuGK" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 571HfOWV001851 for ; Fri, 1 Aug 2025 18:00:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=V9+fcbz7W94 r3G/u7UQJHN/TfdQW561mZf8p47PIeZU=; b=aaNmEuGKHrB1W4wwaq9fNwiKsFi GSNG2TX3N1hxhlRe2h2eeq+HWvw3CR55m6E0ZY+j+KoEH6u5mRGiYX5iuRxcDScb ooi8+X8R0l7PXPVBUGiZofF5JLWuLapA2S8GoR3qYYNlZ38Hzlthr8R8hF8tcCBF CyeTClbDv5gfq17XjYHCvGuB+6YYtQz3XjLeeNIkflsEOX/Ra1hxy/KOWC7x5N6t p+3qJpeIWwj3jmNkl+vcI9lTiB310XNujd+irtH/K732OXq8MkkRB3CwBwYLYRGY EHoKiMMEa5wiANXuNszOBoEXAzrjQJEZenrhoSHVAqHSVxdDsrq7hPBCICw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 488q7xtcnb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 18:00:28 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3138e65efe2so2193092a91.1 for ; Fri, 01 Aug 2025 11:00:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754071228; x=1754676028; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V9+fcbz7W94r3G/u7UQJHN/TfdQW561mZf8p47PIeZU=; b=MWDp2fCMwPlrqBsd0jIQoUNqQc0atSO1fnXVhlBXLmUkHTXSRgbWuFcxwucwb+vAoi 01bUWm28k5Fm3I9l3NdAHH+nuq5zLakxGn+GND4VzARXjXMxKnOrEvI4IjA3WHI6pJNc BS1IU5V0Xd6DfuCRZ8e1LFX83JO18y+8KqR7I1guElfI4fD1OSknRopp2bwmRp3m4+L/ knJbKgr6b1qAYqe7yn1Bz5+3oYSUvc210Lk2CU6GL2xh6GuY/iqqDHQ2SSF58/CKKpub a9Ei8O0aE8AsDcuWLsF/Y5/R3/8RyYP3WqRgTU+c+ZxgMCORgpYTP+58Ih/3lJeri3Oe FKjw== X-Forwarded-Encrypted: i=1; AJvYcCUv+I3X7UV6er+CIe7vAOnBOjDLw3cVkxaOQjVjV3ax8tEJcaMJOu4J8fZeqVMBT4IAtxXiAD/FXKxPWwU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8yxHj5ixOOeKUe0AQCP+RAQu2etINiHY5qX/zudgJ2oeftr+C ZipNTVvm4/RE1yKNM75/iVL/sXwoeZgcwX+v9w9CjR+WEIRtubCikAOcg8qK4IO+L4yk1iQcK/O JYl1KgOI02bINmue4EjxLP2l3d3OpU5I23G6DTDtKj/+sAq10dMJTtOAVSFiCuQSaMuM= X-Gm-Gg: ASbGncurWKP8FR1d2ODTVRMv975FeuqT7qdiNIR6962F1MkQmXdMWVZDNQFfFfXjr3y wgMvaCZMP6AyDzBt1aHMJ4a+l/naBbZh2J4Ql7qbWyIu4bqpyrg6FM6aBR/URcd3mssPdR/Ay6e +zvmy/8+pcSUSM97fbaNWvff3RjdydNQJ/eMSsjL0aU+4jL24QOMBhUrrxJY72gsJmEYhEEXPqr +ans+5wDteEwDLvgk0WY/BJSSPo1GGh0lpprv5ZzAEYyGaQbU6AF8rWV7mrLbRDHmUNQrYB1iM9 cxNfjwgdZfvbilYe6Kea+2yV+PHob5gO3S9qVMxAbd96Z/w6vOc= X-Received: by 2002:a17:90b:498d:b0:312:1dc9:9f67 with SMTP id 98e67ed59e1d1-321161d9bd4mr1027085a91.2.1754071227821; Fri, 01 Aug 2025 11:00:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFH0dkuAC+cmmCazD4s9F12bafJvjQsxaVASh+WEL94pt/xIt0kpv25mM+WKaVod2hnX2+8ww== X-Received: by 2002:a17:90b:498d:b0:312:1dc9:9f67 with SMTP id 98e67ed59e1d1-321161d9bd4mr1026863a91.2.1754071225861; Fri, 01 Aug 2025 11:00:25 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:5b3e:de60:4fda:e7b1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-32102ae8b5dsm1260245a91.3.2025.08.01.11.00.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 11:00:25 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Connor Abbott , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 7/7] drm/msm: Fix a7xx TPL1 cluster snapshot Date: Fri, 1 Aug 2025 11:00:04 -0700 Message-ID: <20250801180009.345662-8-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> References: <20250801180009.345662-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=EqPSrTcA c=1 sm=1 tr=0 ts=688d00bc cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=xqWC_Br6kY4A:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=zhZQclFZcvAaLIcfx54A:9 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: VyJqw1r9w4kNO09uKbsOGok_ZOg4CtuR X-Proofpoint-GUID: VyJqw1r9w4kNO09uKbsOGok_ZOg4CtuR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEzOCBTYWx0ZWRfX5k6aBfWz7nCg QHoEHdOYoUp4OKT0B/5XfKbwTGoBuz5l6F98SlyWlbW0rNwcxQrg3zhRDXem3SbL9b3/Cri+Vqg bbupXZs0Rvea5d6uFuhYXwstyWTUKZR29M0Mhdmr2Q86Amho2jtrGQqujU5tgsd+iTLozFFpnJ5 FpFhVkY3LJrMl5WIYUy7pV5+6VSAyJM9YUgw0+9SKYfWUFGCtT38ePg89CiBJhi9Agr14Xx2M0I W5kFwvY1yCKKyFPl3eBGfPU8f1gn0mk++k3hQbtUKBWI5xhSd0lz5Vdjy5pYM8IU3D2rMlKOdQY qQ7lSbM/+qd1h3aGNkBwdAEwSt+yzPL1f0+hPk9Ii7ltVFo07oOLMNAyRDkGZ4UJQ5Xd/ZgX4UE 93GgPEPCazhHIhPcT6hJFB3FxT2ry8Hp1iW2sSXoFNvV6znOLD5jQ2NRInlzfABf7MKB4VBx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_06,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010138 Content-Type: text/plain; charset="utf-8" Later gens have both a PIPE_BR and PIPE_NONE section. The snapshot tool seems to expect this for x1-85 as well. I guess this was just a bug in downstream kgsl, which went unnoticed? Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_gen7_0_0_snapshot.h | 11 +++++++++-- drivers/gpu/drm/msm/adreno/adreno_gen7_2_0_snapshot.h | 2 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gen7_0_0_snapshot.h b/driver= s/gpu/drm/msm/adreno/adreno_gen7_0_0_snapshot.h index afcc7498983f..04b49d385f9d 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gen7_0_0_snapshot.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gen7_0_0_snapshot.h @@ -668,12 +668,19 @@ static const u32 gen7_0_0_sp_noncontext_pipe_lpac_usp= tp_registers[] =3D { }; static_assert(IS_ALIGNED(sizeof(gen7_0_0_sp_noncontext_pipe_lpac_usptp_reg= isters), 8)); =20 -/* Block: TPl1 Cluster: noncontext Pipeline: A7XX_PIPE_BR */ -static const u32 gen7_0_0_tpl1_noncontext_pipe_br_registers[] =3D { +/* Block: TPl1 Cluster: noncontext Pipeline: A7XX_PIPE_NONE */ +static const u32 gen7_0_0_tpl1_noncontext_pipe_none_registers[] =3D { 0x0b600, 0x0b600, 0x0b602, 0x0b602, 0x0b604, 0x0b604, 0x0b608, 0x0b60c, 0x0b60f, 0x0b621, 0x0b630, 0x0b633, UINT_MAX, UINT_MAX, }; +static_assert(IS_ALIGNED(sizeof(gen7_0_0_tpl1_noncontext_pipe_none_registe= rs), 8)); + +/* Block: TPl1 Cluster: noncontext Pipeline: A7XX_PIPE_BR */ +static const u32 gen7_0_0_tpl1_noncontext_pipe_br_registers[] =3D { + 0x0b600, 0x0b600, + UINT_MAX, UINT_MAX, +}; static_assert(IS_ALIGNED(sizeof(gen7_0_0_tpl1_noncontext_pipe_br_registers= ), 8)); =20 /* Block: TPl1 Cluster: noncontext Pipeline: A7XX_PIPE_LPAC */ diff --git a/drivers/gpu/drm/msm/adreno/adreno_gen7_2_0_snapshot.h b/driver= s/gpu/drm/msm/adreno/adreno_gen7_2_0_snapshot.h index 6569f12bf12f..772652eb61f3 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gen7_2_0_snapshot.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gen7_2_0_snapshot.h @@ -573,6 +573,8 @@ static const struct gen7_sptp_cluster_registers gen7_2_= 0_sptp_clusters[] =3D { gen7_0_0_sp_noncontext_pipe_lpac_usptp_registers, 0xaf80 }, { A7XX_CLUSTER_NONE, A7XX_TP0_NCTX_REG, A7XX_PIPE_BR, 0, A7XX_USPTP, gen7_0_0_tpl1_noncontext_pipe_br_registers, 0xb600 }, + { A7XX_CLUSTER_NONE, A7XX_TP0_NCTX_REG, A7XX_PIPE_NONE, 0, A7XX_USPTP, + gen7_0_0_tpl1_noncontext_pipe_none_registers, 0xb600 }, { A7XX_CLUSTER_NONE, A7XX_TP0_NCTX_REG, A7XX_PIPE_LPAC, 0, A7XX_USPTP, gen7_0_0_tpl1_noncontext_pipe_lpac_registers, 0xb780 }, { A7XX_CLUSTER_SP_PS, A7XX_SP_CTX0_3D_CPS_REG, A7XX_PIPE_BR, 0, A7XX_HLSQ= _STATE, --=20 2.50.1