From nobody Sun Oct 5 14:30:48 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54B29269B1C for ; Fri, 1 Aug 2025 13:51:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056284; cv=none; b=ZZvBOay6xnmFh7Mf/mHrNwB1BMWdmOo7cR5JHPNLIpsZMKBW81poSroHnRXGBYHj/sScrXJxxEHm3leBnBF2/ttug1cuI/qqzTCnLwu5jLHSNMKALoRL6uCXE4oQpZ5kFxjV04q25fxlNYLUgoc/jY7XWZCt4YNnOB0DthKcG9U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056284; c=relaxed/simple; bh=Npu11OGBlNLZEIA4iffNoHuzYf6/Fg1CUI3VmwQheFU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rXO87fO1FmVRrhsafbOvQUbwqWHMb3JRMsrTt1Rv1TA5xE9KrycxbCd1NbOvSQ12lwFPcnFXufYrc2hXLr+l1tKd4XS64vjIdhenHeAU9axx2rq4JTZusFz+l573gWTkG4V/TP/RhgvImJbmWAfZe80uCq3+6auEbFICpDeYGYs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZixZKNRc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZixZKNRc" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 571CLn2W002420 for ; Fri, 1 Aug 2025 13:51:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V6zL/GI63V6YYKeGM1mEryAObeKPOCarM9uKEFJtsyk=; b=ZixZKNRcrQRvodJd apim1u6KzeyYaY//ocAWtkLz/m17cHyGdmVUAPav/oemBLjXWM8v5jOvdHVocNyI rvLr5FVYTG15cc0OaOsqlihXATZGE9p9a0nu/gA7i7Y7zySFoyb9RqfM+39/kq0c htiK2coTBIDxuR0EvVp/uYXqFjE30OEiAdkmtfDLs07DkBNbumDI9dasN5TB0CSJ 2d5r6trf5sCoWrC6aDCOov17JxzpbWd3mKWqpVLJ0oHEYu0bMDsIMgIK4yRQxBc/ KO6Vtw47yO6PTczVwalcNZcB1iTGnDVrhZOnTknXWFNdnJWnjDsD8VfMLNWAUU6C +MEndA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 488wgrr7cu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 13:51:21 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ab657b88c7so19114811cf.0 for ; Fri, 01 Aug 2025 06:51:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754056280; x=1754661080; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V6zL/GI63V6YYKeGM1mEryAObeKPOCarM9uKEFJtsyk=; b=GZ6T14gRacxf7p0J5C1OdCykHXoLZzNj7p+MCaBRmuOiPQTN7dX0RVHGv8QZSwVbbw 4WZedgwqPuM8jhKIS3Jm/ffgmtRuT2RHKvYl2StWgvVxUg9qBSB9ycfymn8pXy+Oeu6M K+vAOmmmdPQ1nPtC9RRwZ05DcRy0DePyNz0WjEkCJEKlXvkWm9+Zn/87N/qKuEBLUxZM DiTlmFASlZHkZh9y9hkPmW3XiQzq/rViFEvUMmAsr5ZPLBx5temTSyfV0emuTwf7/gYA NzD3wmrMrK1svZNWJKhnZ9oK0g45CmyVCE8wgt2Y7fvV0swn1yOk9liZDMY1B0xsLlN6 p8vA== X-Forwarded-Encrypted: i=1; AJvYcCVNQMAKYDQSSrX8if45DkfBRIi6l8JoABDQcHUdEExN5Y4GC9ZA+ZYwqdMcDPZUP0ly59GkMehYyod0A/E=@vger.kernel.org X-Gm-Message-State: AOJu0YzIRxVf+lHIIPRgy3UFoHOaFNQgXNT08UPm9UQ5J1Mec540Mtpt V2FomV3qDUOhjI6us+uliwJvnVip8Sbhnv6yqocwbn70AsRN6a4pEFcpOipmNFV4Z3E+i+SJgEr qVNnU0XEbzZsmfEcSaHiIlacKND8Egp2re0dcdh20lYBXptKue7CqCmLDd/2ySR8atgM= X-Gm-Gg: ASbGnct9F6VIA4reyxxMkjX0t3DyX6Nit5MtGMIwK/F4H5caCnGaNDfiqXXufIYOepQ D7zUr0xs61SvK7sOOf8Hwo1yQ4+hc3j1mU8Rr+3SqF4afNzwhvahU4HdEtjrR/7EtStarokaTxy tj1G/R3S7HoL0vdRvFxq0MiiGKPjuETbWtQD8U9K6j7ZvYC/rR9pPiBHaM5S9fIhL8X/eQExMbB p6LZ8e1/v1IWBKjgm77HbBoQd+h42L2T0EWWz7yr3d8eP5v7Z+R+yBU6/YjyGTF1so3nPtzzZ3o Vo/jVE3gtVTTScnXTVM3FSX719sqGQVYJtB+dyaXS/MsZ1o7HzHiIpAbzIs642X/QaPeEAv0Gwo pafbL3griXLiCdz1x6166dIJHPyVdjXJ1wUaSGCl6YSbnSRnW2pOd X-Received: by 2002:ac8:5813:0:b0:4af:219:b8e9 with SMTP id d75a77b69052e-4af0219bd62mr28441291cf.6.1754056280013; Fri, 01 Aug 2025 06:51:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFR0G/8/mp3NoMeNSdNh5xGLdgi/uAIOcZPk20PI9XWjmBIPiXjC/zontxCRxjb7k+mVn1ffA== X-Received: by 2002:ac8:5813:0:b0:4af:219:b8e9 with SMTP id d75a77b69052e-4af0219bd62mr28440731cf.6.1754056279485; Fri, 01 Aug 2025 06:51:19 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-33238273006sm5917801fa.9.2025.08.01.06.51.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 06:51:18 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 01 Aug 2025 16:51:09 +0300 Subject: [PATCH 1/8] drm/amd/display: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250801-wb-drop-encoder-v1-1-824646042f7d@oss.qualcomm.com> References: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> In-Reply-To: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2980; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Npu11OGBlNLZEIA4iffNoHuzYf6/Fg1CUI3VmwQheFU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBojMZSZXL0kc9QaXkC+l3w6n53625xXoOoWi1Rf w1dSHbBA4+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaIzGUgAKCRCLPIo+Aiko 1bpSB/94A2+Addr9RNnuGBvk1NYZ/RWjJSnSxboR9iOfirpPVgua99XOaoDsSnhD3nuxJDmBBgF 98NqAbJF6AFI97xmYBM/6ZHsdItWame0lELe7Aw/j7btMsZu4+ROQl6Y0xZAX084XeDcL/jBaJP xamILenkg4IgIBeN9bJeA5pyCqsvRXSezPiBgNrZsYGeaqPvNmK9Mn0W0Y8TFvSvDNOvYTcOYSP iArGGeNBhFZpGcWJn4cJDKYMfOSQLAW9ZQg0/3fe0/pp9MfDoYSyOjWvZsX73WeP5lIM0vOShqs 9ONfy5Np+vHNO0rlKWiXD7XgdKfRRU203q22p1TS+tHpzFKa X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=fs7cZE4f c=1 sm=1 tr=0 ts=688cc659 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=8cP71iSYcfV9S7Y4u-4A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: vlvAAo0DpGjCC6NIafXQLlMcrLW8KouO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEwMyBTYWx0ZWRfXzmUr97HA48Eo 2jNzpLqGwdNCHNvDPFZhngkaXMzprkIIZr7zZE9pzbZK6txiNuz+zpCDWb3Hpczp6bwkEukRbA+ iVTH3VYvJ5GaBNK4nG17lAJ6qbBKh25PCVxFb2n1jV7o9mJxYu7IALvq6y605DtN+3GCmfNd4VW MdU6AyLPrK7s8MsspDbxF6rqgN8gTTCV/WA9Eg8jUucjqt1TfJ12f0db334cJLP7zJDm+2aYX9x MAsfjkvq9DXGZgSJVnsi88M+gbsCiVcxLNAA1Q81JLNAf8crOnScav31Lk56O2KPLNA1+d9Ov9z xmX/qyqcmhMiH7yP6UGmkh+xfWUCzEdsu/jdCa3zR6N8WMdNZ40Pvg22S/AnnRmQGlhLiBQ06kw zvizkhP+NSIGLWxOVj/2MoTVuStFehrcSHZ1eRagggVKZZTl2OhFDUHVIILbuhCiTQBU29qy X-Proofpoint-ORIG-GUID: vlvAAo0DpGjCC6NIafXQLlMcrLW8KouO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_04,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 suspectscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 phishscore=0 mlxlogscore=939 impostorscore=0 bulkscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010103 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Signed-off-by: Dmitry Baryshkov Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c | 18 +++++++++++++---= -- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 096b23ad4845d365dad707deed4e3e84b1f9945d..a9948e8d67a6e9556d21090b5cd= d101258d62480 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -10003,7 +10003,7 @@ static void dm_set_writeback(struct amdgpu_display_= manager *dm, return; } =20 - acrtc =3D to_amdgpu_crtc(wb_conn->encoder.crtc); + acrtc =3D to_amdgpu_crtc(crtc_state->base.crtc); if (!acrtc) { drm_err(adev_to_drm(adev), "no amdgpu_crtc found\n"); kfree(wb_info); diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c b/drivers= /gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c index d9527c05fc878ef6916782ff9fde847813938461..80c37487ca77c0494eaf769c5b9= a3c53486aa52d 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c @@ -171,7 +171,6 @@ static const struct drm_encoder_helper_funcs amdgpu_dm_= wb_encoder_helper_funcs =3D =20 static const struct drm_connector_funcs amdgpu_dm_wb_connector_funcs =3D { .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .reset =3D amdgpu_dm_connector_funcs_reset, .atomic_duplicate_state =3D amdgpu_dm_connector_atomic_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, @@ -190,17 +189,26 @@ int amdgpu_dm_wb_connector_init(struct amdgpu_display= _manager *dm, struct dc *dc =3D dm->dc; struct dc_link *link =3D dc_get_link_at_index(dc, link_index); int res =3D 0; + struct drm_encoder *encoder; + + encoder =3D drmm_plain_encoder_alloc(&dm->adev->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &amdgpu_dm_wb_encoder_helper_funcs); + + encoder->possible_crtcs =3D amdgpu_dm_get_encoder_crtc_mask(dm->adev); =20 wbcon->link =3D link; =20 drm_connector_helper_add(&wbcon->base.base, &amdgpu_dm_wb_conn_helper_fun= cs); =20 - res =3D drm_writeback_connector_init(&dm->adev->ddev, &wbcon->base, + res =3D drmm_writeback_connector_init(&dm->adev->ddev, &wbcon->base, &amdgpu_dm_wb_connector_funcs, - &amdgpu_dm_wb_encoder_helper_funcs, + encoder, amdgpu_dm_wb_formats, - ARRAY_SIZE(amdgpu_dm_wb_formats), - amdgpu_dm_get_encoder_crtc_mask(dm->adev)); + ARRAY_SIZE(amdgpu_dm_wb_formats)); =20 if (res) return res; --=20 2.39.5 From nobody Sun Oct 5 14:30:48 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4CB9221FBE for ; Fri, 1 Aug 2025 13:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056285; cv=none; b=OGbAnI1tqTxK6FAYQiJHkFphOKBrH2fGX3hdsX7alHmXVB9zv2PnFgBf+N60VTis0HKonLvMb0sgfoLS1pBXA6WAreR2oX3GIWiLczQtpnB/bjT52+UWNeTtlNjeHKund0zQ8ZyDoE59Z4Em8+sCNMxdruZJry194veHu3WTY0s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056285; c=relaxed/simple; bh=goFFEhtD/Im3N1nsgGMsKddMGY0uKGtsCO6KqUCkWNY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aYCnsg0uy4S4NRNgJwCnC3tcTZ05UYKEWqrJBwlhGzY5vnLcsFQlyJpzDOXaZegRHU1wVzSBUI3bB7McdtkUnHOoLljyxAN4VOtE0HOtajWbLBxx8RyMhHsx6ejd2zvkVlV2fXllkD15qPHOF5JRE0Ck/7c/aCqu1FlW9qUGtXY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A1K+SC7z; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A1K+SC7z" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 571D0PEx007116 for ; Fri, 1 Aug 2025 13:51:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oABhVeMhuZm6PTbnI/8btR4aN+7HYVmKHbDE5K4ACek=; b=A1K+SC7zD6GligY/ GPqmET/omO6fzaL/xEUI482+gFAiZJThvM9z5pH9qdUiTFXjW5Rs4k3pjBcuyHLu N6CzocO6EDUiGpSlSdxWNTDbxPOo8AjShY6chKLTa5bfHzhCW7mgID5CgaX6KCCT VuYAUC23I706bpUbkvAexLDnKaFwsA6xbDLOo8eOK0U9H7yUAY4k0cexzk/1rcdc idAA8UDogPmeEEHbYVgnE0njWXQi4DbjNXxrzpyPrOPazxYrweuMlI0PJuFiwtL3 +LA+xfwJkBx/aLuYLww/sTwK2LCTX6gc6fljBzA0V/t1xzv9EbbfSA17DEv7S2id w1CFdw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484pbmbtjy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 13:51:22 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ab44642abeso16223241cf.1 for ; Fri, 01 Aug 2025 06:51:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754056281; x=1754661081; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oABhVeMhuZm6PTbnI/8btR4aN+7HYVmKHbDE5K4ACek=; b=pfKymEcitGBIxKkKdr2/P+V3zQXR5qcICUvNBxhPWqK0EyAS1jj2lCFL+yl2HEwpFp GwgE1PbWWduVWjsNYWH68VEH9Wk0DT7WyXWxKZmGGZLeFMueFDwj0JT1VnevZlbn4FOt /hlaUCwRmELpHMWKgaZ+K4D93+Y4Sw1ZMoK6Elejbfcf7oKiDAdHxZdX/IwoyExBDMYR U1HTGWGabAaexwR4+fYUUEARpQLCfJVD4CoZpAvti1geqcXsarExVZkiaYCKLhIOyMCC 5hkkWUHes2wyQTjzN4KTfhRORX1UTge3Z9MgPQPJt0l8L+c7jSWOJV7PWBo4Ik5dztgS pxpA== X-Forwarded-Encrypted: i=1; AJvYcCXqLGOsJZVCY4/+8pAwvOBTwkRjQWB5h52FA3L+JKZMYGSw49HKIKEQtRyba9XtVJewLxwUdZI3xTRw+y0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywpxb8PrwvCrS26o08ST6t81RQfP8UrtJPrnci36dPR7BFUCrvs UD3oOgpOD8BCUCrxSsgf7jfnxMhK4F4G2BhiwqrnECFETbCVAFvfFWWZrBWA+ZL5HWbsSioiAFE sIdo0aVfN1WipAXeXMNpbIJWtCTB5HnaTS3wpalZwyRV2bQSP7jVtLfpC3VCWCoBAztA= X-Gm-Gg: ASbGncvGoTBPbm13k5HN38E7HJfjFJCh5+zwiFqYkmdJk06WswP6wj1vlCQoT2/0Elj J5/WmAWriOO3pYSCQgPYcMW4IzjpN6w7Q5CUJosCs7hgTwqul41aj80reZjMMxE5zmIWDRr3uxO Qjt1VEei6mbKDUfyCqaICiPvfWKFTo+nfm1yXZC5ATIovAvCr1JX+eMGK2rnoiKo3IwqhbLx5Zv T+J4LlhBd+yMO3ZYKq6N37fFZRwDGrbos+nyJ1L5s2h80CBOzj8ZHbvHlS97eyVZsPSngJC3C/+ lQip+OTrW9wG8hi0dhZ/4weVWYKXrtAxKNnR3j63s1Ux5WNi/eSnejtxr+JEV8gEizmatURbmgi GvCP6+Lj0QNkBpv7xbBogbW5jq1UvzUics6oI3KiZc8/NG/QRt7Rt X-Received: by 2002:a05:622a:6090:b0:4af:a3d:9f94 with SMTP id d75a77b69052e-4af0a3da105mr12354411cf.50.1754056281363; Fri, 01 Aug 2025 06:51:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG52DSwGwk7HNvgjkCq+ht7oyq6LU2s445ag3X2y//8N4s5HAyIOUu28Pz6VZOfWywVilLC9Q== X-Received: by 2002:a05:622a:6090:b0:4af:a3d:9f94 with SMTP id d75a77b69052e-4af0a3da105mr12353661cf.50.1754056280680; Fri, 01 Aug 2025 06:51:20 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-33238273006sm5917801fa.9.2025.08.01.06.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 06:51:19 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 01 Aug 2025 16:51:10 +0300 Subject: [PATCH 2/8] drm/komeda: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250801-wb-drop-encoder-v1-2-824646042f7d@oss.qualcomm.com> References: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> In-Reply-To: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2909; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=goFFEhtD/Im3N1nsgGMsKddMGY0uKGtsCO6KqUCkWNY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBojMZS1/Pfoit12OsSUjCvlkC+n29kedgBSwC22 eCp4uNngN6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaIzGUgAKCRCLPIo+Aiko 1VxsB/4+wGaVMLsVmpV+09A3+p8+foUBQSgFcdvA/I4/t5sBLeSCn+vn1JqBTR0JDVzGYK1vbkk BTWUu6ath0wbCVud8VRfTvlyySY1vUcez+mErbsBg45cP+wX3u5TLNpED0RVfbzxupTDV73iK0H seidFyUwfyX/E/LVPD6/ADYUNls6a9V+LUE8vk3HZ4mj77kQTZC6po3gv39kemSn2tFATpftS4e m0UN5xQ6ot7oxvZK6X6c4Zg1bwX7jnrbXPWb1OBC+2+Nd5Y5psNhY49pZgmW2815O6Zz5gB0iHI 7WHR3RawPjs3QOkKKEt3YoK99Z3wcIgiSjmAGenNpj8/MdDB X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=LsaSymdc c=1 sm=1 tr=0 ts=688cc65a cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=EE5oNXVUeA2ILyHCr4wA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEwNSBTYWx0ZWRfX/AA1jAJQF2dM i66mYIPrqSi7Gz0CM2XQ6HCIcFn5YOMCD4vJRTsvCyRtqWNuth2I/NZrAAYyZXVMUmdWTMD0roB bn1lQg4NQ3yvo0tGB4uyP0GOlMFsn/vGzzOn/2A9bzluz3IBTNovX9/mUkDd6UjUDUwA7YGm97o Wj6L/zJIFRWUm9lS4yvLc64C7Fwemt6Yi7NxVIBYEuGhWfiPRNOnMXwIs5EDwBEixDORH/3+vCm /tjqOG/THfw7Lnpt+AaXKtPm6HR1P7Fklhug76NvowkOF+QuVmIE8kQOv2zWFEtriVhSxJvaumu ywBw8PPfw2EjwiqZCTYwrBNIQ/qfuumlXydCh56skDiYrp2zXvsQeg3YU5EFCeTjeAAV5/VHY2A woL/Xavc12zecJVNYajNjB7egDqijTd+tGpzbhSIc6Op5Y7zz+BTz33cc7sEf43UB83ytKM+ X-Proofpoint-ORIG-GUID: YwHRD6ElzuvMOEzoMuaN_vW2YN_n8r24 X-Proofpoint-GUID: YwHRD6ElzuvMOEzoMuaN_vW2YN_n8r24 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_04,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=825 spamscore=0 phishscore=0 suspectscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 mlxscore=0 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010105 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Signed-off-by: Dmitry Baryshkov Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal --- .../drm/arm/display/komeda/komeda_wb_connector.c | 30 ++++++++++++------= ---- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/dri= vers/gpu/drm/arm/display/komeda/komeda_wb_connector.c index 875cdbff18c9dc97e736049feaa8a1fe1bcc82ff..210841b4453abfe60cecc1cfc79= a84298be3e684 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c @@ -5,6 +5,7 @@ * */ #include +#include #include "komeda_dev.h" #include "komeda_kms.h" =20 @@ -121,17 +122,10 @@ komeda_wb_connector_fill_modes(struct drm_connector *= connector, return 0; } =20 -static void komeda_wb_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); - kfree(to_kconn(to_wb_conn(connector))); -} - static const struct drm_connector_funcs komeda_wb_connector_funcs =3D { .reset =3D drm_atomic_helper_connector_reset, .detect =3D komeda_wb_connector_detect, .fill_modes =3D komeda_wb_connector_fill_modes, - .destroy =3D komeda_wb_connector_destroy, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -143,13 +137,15 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, struct komeda_wb_connector *kwb_conn; struct drm_writeback_connector *wb_conn; struct drm_display_info *info; + struct drm_encoder *encoder; + u32 *formats, n_formats =3D 0; int err; =20 if (!kcrtc->master->wb_layer) return 0; =20 - kwb_conn =3D kzalloc(sizeof(*kwb_conn), GFP_KERNEL); + kwb_conn =3D drmm_kzalloc(&kms->base, sizeof(*kwb_conn), GFP_KERNEL); if (!kwb_conn) return -ENOMEM; =20 @@ -165,11 +161,19 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, return -ENOMEM; } =20 - err =3D drm_writeback_connector_init(&kms->base, wb_conn, - &komeda_wb_connector_funcs, - &komeda_wb_encoder_helper_funcs, - formats, n_formats, - BIT(drm_crtc_index(&kcrtc->base))); + encoder =3D drmm_plain_encoder_alloc(&kms->base, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &komeda_wb_encoder_helper_funcs); + + encoder->possible_crtcs =3D BIT(drm_crtc_index(&kcrtc->base)); + + err =3D drmm_writeback_connector_init(&kms->base, wb_conn, + &komeda_wb_connector_funcs, + encoder, + formats, n_formats); komeda_put_fourcc_list(formats); if (err) { kfree(kwb_conn); --=20 2.39.5 From nobody Sun Oct 5 14:30:48 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C831926CE13 for ; Fri, 1 Aug 2025 13:51:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056287; cv=none; b=JhgTWqGZrpoLjAhj2/I56g4txd8h4uUkyOjgEWlIWfDHYy1d/KzWDCjvqqfiTrSRSbfM3tqGOGMpfYTRg9tWhceU1tV/tE8SxUG1sIETNReF1wuIeCFCcJQf7Tg7dq7q756EngK4ToqkMxVWR+PLlI990ZJZv11Pu15vuKQu/Ug= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056287; c=relaxed/simple; bh=P1Z0Gdm80qNJHt3MSy/BfGrhTCWZS7Xn/sS5jUPkuZY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=msAXH8fmJB6xouGoaBpsz1eWCYJsldjCzAp43ReYepB7B9DhsAqGtGM58VqUOyVSxybJd1w30d1+MLOhu9rkrJz3FXJmPM+OQO8g6V1QIe3VXgp3/bIs1DLO42ZCtTCkigh8+LDrjUZzHcttyJ/l5az/q/vKMu1/HfmiClX1D7M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B5XaPGSC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B5XaPGSC" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5718YpDl004997 for ; Fri, 1 Aug 2025 13:51:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tVawR6mCQAAJds4EZ/RayxaIa/tzB6nlBY+m3oTR/UI=; b=B5XaPGSCzoY8/OEL nKR5SEJSQqDyUZCNVdUUJx5GkkDzxCIQUiR84wJQY/a2C82x0AGoGUkvBbCDJdyg 9jC7I7Ppe5ZxSl41lmDWQiYGA+pK0uQbETAcfyB/oJZ2ckfzE9BjzXbLHUki/Opw lbFK9gXG7eN10zogPdA4kysRBnZyIZArwfdoUwDeWzusSXIWJLJ44+3OBfQ/Dbj4 AfPPrIBn4GmZai08pEL/cCb6vvK4cj1cKsTIkCqxi9/f5KfkxdQP/Ps7tzMos5km cur9oiL6PuZWEZKuN/NWQqsETFA/iPtLc2KwtXGgLZR2CL7Ks+iMColNLasS37U9 L1zpuA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484q86cbbr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 13:51:23 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ab684d3b55so46875471cf.0 for ; Fri, 01 Aug 2025 06:51:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754056282; x=1754661082; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tVawR6mCQAAJds4EZ/RayxaIa/tzB6nlBY+m3oTR/UI=; b=mryu3o8xNusDyt7dAI31C0Bb+8fAbl2GSsBz3GS0JTrNKX6Eh8Iu3NkzHxxZhhLZv7 N+EFKdkLzxYgh1p7MTuKFJ4AGgEg36+I3qqK/Ce3A71FKqTK2IxhoivvO/4GxiS+8XoS uA2rQRHy+WU3N30Nig6zLaMflQQsqOSrtov1p55FR/d4KOfBzSmXMWhrZLlnJLFltmxS zSx45c4fMOFGJK4VIjlF9TvzogXt2HtIvpquwl+g0ogsCfEtTCbjHW387hrAqZSy4V2T XS1a/4cm3UmRxNCqWQJzQUCLdRT82/8wnEp+dqY+aTVAZ5t8WBCaa0oFdZzjJvsvR39b qEGA== X-Forwarded-Encrypted: i=1; AJvYcCUxMr2FxTufDBvf+V+VNLVbD3kDDjQYfnbatyLS1YpAWjXA1U0UbDDWJUrblkraCqHop0fTVvXEmsGLiu0=@vger.kernel.org X-Gm-Message-State: AOJu0YyawdY+FZcMIZDoQI456qsrZQHYGgfM/OlYdP7IIwXA/rH54pRt 340Pl9IXXjHVdjxwEWWimUo1CGA2J5QjHrFcuDv4YHfzwOT1Zs/ZDVdIcSY5TFph8PDxHHFyg52 ILcXxP33hd3o5l1yAvR3N+81LGbei1m/9XqVFNlQqDyb9+sBJiZbeNeUUEVoWxoO4Zd4= X-Gm-Gg: ASbGncvnbG6t/LNZlqLeVY1sUzxwQdHb9PPGfwxbUm/1xWcKFmFyiwyfuI5esetfR0Q UQ8UdUAl/McnVUwa0szvHUD62DCzM09oTbJosserckHWnRgE4ImjLo/TdAPy6Hqb6MA6Kz6CbXW vxG+wTCAT0EAh2UdwNxoqt8/Vcvh1tYv1pxzBBK+fodN4MZRSNXY2g6cFPCWgdRdWKN66VDo5/W wK65iLshlcUo0XNsuIjwlJz4w2fePduaKChZt90SMTqrBsmvAz21zVO5wornWlRbUByddDSeGLG E7nWaONQLWg9pPuNufhcwKhH/mgz267QXc2EJ9aubBc/AMTfjjO+OJrcb3Cn/Xs244ESi/uPTPQ ImQrJzlUqB+anbHmULDDpS8xPcX4QugM++7thW8QL0aWUc24RPzHr X-Received: by 2002:ac8:59c9:0:b0:4ab:722c:ff15 with SMTP id d75a77b69052e-4aef16d926emr76618491cf.8.1754056282331; Fri, 01 Aug 2025 06:51:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHinZAK6zgz67gxcBa5Qc+o9XL/d6M0vzQBd+as2iX1dHhTo8v0oERF1BzFlbp7qnq1jXNRzQ== X-Received: by 2002:ac8:59c9:0:b0:4ab:722c:ff15 with SMTP id d75a77b69052e-4aef16d926emr76617941cf.8.1754056281863; Fri, 01 Aug 2025 06:51:21 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-33238273006sm5917801fa.9.2025.08.01.06.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 06:51:21 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 01 Aug 2025 16:51:11 +0300 Subject: [PATCH 3/8] drm/mali: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250801-wb-drop-encoder-v1-3-824646042f7d@oss.qualcomm.com> References: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> In-Reply-To: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2517; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=P1Z0Gdm80qNJHt3MSy/BfGrhTCWZS7Xn/sS5jUPkuZY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBojMZTgNmCXsFmzp+S17Kx+aqN4yS4VmhyhMxrP aqLrBUR/VWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaIzGUwAKCRCLPIo+Aiko 1Tt8B/416/YgM3zYyZ0WB5DeZyBJzXBjPQXXAaToCtg+qCkd5fJZPLQ3Vr5YUNhMTw/2trGwgAn fJVDfQrkMZQOKG2PrGGMHGUx5GIEUMqir/XjCmlH23+lEtuIWOzNBJHF22ojkfLtYI8VvBHTeIN vq4mYfMW7gxKtXuUdM5N7VFzD5teZBSYI86b7FMVT2/Xyk57ul4HjqmR2QyPSrWBPKiX9TcQLTe h9+6W2wC/ey3qnTTaz9jqTEWseyUjwxc0/MvAkor8AplA/Ef/FrUP70IG5LHH00Mq8S/Y00DaLH RGajsMZxfRPOEJpeRd2dJiyB7BHKG9eahphZY27/p3NrY5dt X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEwMyBTYWx0ZWRfX0Kgj+NNbd8F/ EbQlT1ga/N9ZQup9MmUDNrnKyLLzVIGa6qaAx1tOfqqO9vZ478TKzKznpKvnkmBBOkx0sX8WUEh SdCkf/c062ryQ7y9L75RZER5miMYOXWdUPGKJrS/vaEDZCS+h7hBdif6GYO9QvFNvawzNssPDj+ TnhsWyyyJzlqrAbv35U4AHzl5O1aw/l37SbUM+VQtVKn1k1Hw8l7+biRHr2PQEssbhOVfvJXmVU 5maM3EHEumb3YoOGYmxFvQm/Z1gdgUVYPA/mfn8Hk51/PYUwc/tTsHHSS/oqrIPHnqc239K1yDm rfHpzqlob5Zwa3WiDvCkBdMbhvt+r+XY3B4JAKywFvBcJZbVWzwKd4vjecp9MmIPrDfwPawBhqq ph89oNK3S9oWftymVwAXiGycAiLdAOJqc6dxAaBabYBmxRvBCP79LCJZ8FtdxcCr8XL1R51a X-Authority-Analysis: v=2.4 cv=TqLmhCXh c=1 sm=1 tr=0 ts=688cc65b cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=mhD89yN676IZukTL2GQA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: yvv5fF_5-_UNCiDCU_P_urk-LkHD0Bfj X-Proofpoint-GUID: yvv5fF_5-_UNCiDCU_P_urk-LkHD0Bfj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_04,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 mlxlogscore=770 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010103 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/arm/malidp_mw.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_m= w.c index 600af5ad81b15d0c30f9f79588f40cca07437ed8..182275c0c29cd8527c85dfb3e73= 17561da392c46 100644 --- a/drivers/gpu/drm/arm/malidp_mw.c +++ b/drivers/gpu/drm/arm/malidp_mw.c @@ -84,11 +84,6 @@ malidp_mw_connector_detect(struct drm_connector *connect= or, bool force) return connector_status_connected; } =20 -static void malidp_mw_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); -} - static struct drm_connector_state * malidp_mw_connector_duplicate_state(struct drm_connector *connector) { @@ -114,7 +109,6 @@ static const struct drm_connector_funcs malidp_mw_conne= ctor_funcs =3D { .reset =3D malidp_mw_connector_reset, .detect =3D malidp_mw_connector_detect, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D malidp_mw_connector_destroy, .atomic_duplicate_state =3D malidp_mw_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -211,6 +205,7 @@ static u32 *get_writeback_formats(struct malidp_drm *ma= lidp, int *n_formats) int malidp_mw_connector_init(struct drm_device *drm) { struct malidp_drm *malidp =3D drm_to_malidp(drm); + struct drm_encoder *encoder; u32 *formats; int ret, n_formats; =20 @@ -224,11 +219,19 @@ int malidp_mw_connector_init(struct drm_device *drm) if (!formats) return -ENOMEM; =20 - ret =3D drm_writeback_connector_init(drm, &malidp->mw_connector, - &malidp_mw_connector_funcs, - &malidp_mw_encoder_helper_funcs, - formats, n_formats, - 1 << drm_crtc_index(&malidp->crtc)); + encoder =3D drmm_plain_encoder_alloc(drm, NULL, DRM_MODE_ENCODER_VIRTUAL, + NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &malidp_mw_encoder_helper_funcs); + + encoder->possible_crtcs =3D 1 << drm_crtc_index(&malidp->crtc); + + ret =3D drmm_writeback_connector_init(drm, &malidp->mw_connector, + &malidp_mw_connector_funcs, + encoder, + formats, n_formats); kfree(formats); if (ret) return ret; --=20 2.39.5 From nobody Sun Oct 5 14:30:48 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1066326E140 for ; Fri, 1 Aug 2025 13:51:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056287; cv=none; b=By68/X7J5QYVFENwk+bkOVQm09+Sdu/f9P5pNOwTzaHpfb11FJN0sqk95sGwS0RR3YEThYsmvXVdOFZXtqy8UMig3T8PYhx0ZnNuBiCgdJHp8Mc/ePw0syIuE7ROv4HzL9IDPRBiUXIP0NQV08elRWzzniGdaXL9dJ7Hl9spXdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056287; c=relaxed/simple; bh=4v/UkWVUd2usRk11ttudKMK/GFE7oPMYIMlz0jnkFl4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ye7oSVaJkC5DJDtW2lkCocipRygvCtuDsWB4DMKf5wRo4ZhuytKq2OoG3mpW4tqJ5RD3MfScuZ4bjcRxPE4i2CM9beOfTCYt2pquFnteJPvEMxIdykatWMFYjo2Bb6MpAvQGkJvBwOuF56RKFNiBuKclOMjp+e++O03f/DZBq74= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ot71yDba; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ot71yDba" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 571911Au018764 for ; Fri, 1 Aug 2025 13:51:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 278QZ0lFfDm835VGauRYZsYszXs7O8BAZXSyOh2pTg4=; b=ot71yDba/AH2AD6I Mj2dOXKQojk6IRbIcHcc2poCjsJKGX4bm8HdAdEldXhvifVAQe7sLwhUihEUpDxi Pl1EpZu8O1We7/iLGosinar8YzZVZdqFxpd4LK2SyUoHWVYQJ4ci6M0px+NDMHhX TWDrEjYRBeN3bW4rjWFBYqF04YLNWilWVI6WjXUBHVAGo6EpOUOyOG0lPHvjUaS7 FWyYNsJtUvWoilTT6LAhGtrPZp+uzfxD+fG908le2MPVxQLPA52G8WkI+6uoF7zS t8Zf4KA8nqADiu5GRVoxg5//Jm3JaqPRCbGsBD7mSZj5Lxk/IQv1Bv9DHg9xF+nj 4FoyrQ== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 487jwggj7g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 13:51:25 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6fab979413fso31778346d6.2 for ; Fri, 01 Aug 2025 06:51:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754056284; x=1754661084; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=278QZ0lFfDm835VGauRYZsYszXs7O8BAZXSyOh2pTg4=; b=fv6SfE7Sgs5aXH6VeYhiT5ba7wzSm79T/1PuduNrZfWwu9nND200w7iAgojAT38ySA 2OGxK6+3wKgb6hdcl9AKxftwHkYDnY3JA4S5Z8i4ZeYkbbljPse/m5zr1aGEEeI4dac7 fMGx2yqG5U1INNYMFdMcBGK87bgmCNgsUcBZ5Oo6fjK6QZ+uS6iwnbNLVlSTwwRfJ9TC oXsXT3ffF0GEaLXNbBueKJoTrIsx+8vd04s0BthP5L5d9ehvGVTZIaRBWciWnL8RvvrQ ouC3YvXDjGrNT1H7GXEmvd3H1Ybli4h37xNBk68lOBd3A+0MIoTMdV5hnc51cWRKkCtP kHZA== X-Forwarded-Encrypted: i=1; AJvYcCUj3b9V6zi0xthdtH4TII3AwLY7HsR4rXV1JEmr1wRbja5f8wtaAGJZKvn3VU7vTTCsK86vne+fEFroaKU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6ye1eOdj7DHdmiwObdzBKA4nnEHZ8Sovar7qnavcHiBeQ0QK+ KzEusXkv2Xs3yvC8uyLYwoSjid53t2kY/OfudWE+xzTbTvIMZNYjdT1YlUxcenxBVjBaCHbV8rA orFM7fZn/c08RbupJPtOiX91W3CmWQdD5h0agM3o2HIy2od6H6oKGPnsG8Evm0EB3FXY= X-Gm-Gg: ASbGnctsC6FZL85wK7O4mXOUqag/YBvGllm7NtPd/b9wvB6ndIzK8JPwyjh+H0pYmvn PIsw55Y5GEVNnm3wHOTNkWjIaj5v9Vt2bgK6iKDH6hNExTp9zXHc+wK/JufMtr15OWh3RzX+byu n76fQFDHzQ+570AdxhVMB4xfRTdg5eKRAfaNLHVnhM4l2FYO+EPbU5RiU91HyPnBoFO1gsg6tyW +S5GN3NIzKBDKl4Nh+6O5FWyzU4J59iI6jthYn1vKQ5bWPoRRLYeBdql5ywQBoLBvsUJpeQegI+ ReMGMjotRtgP2t+iIKRrEsyyFkl9EbhhHIze8YiCXGWDkIzoub2Ib0j/K32z0Q+9MWBOA8K2TkK FiuQLSXBWBenex5Y2G2OZ4yynuynDnw8+pe46CCBTrsQeIgsD9aTE X-Received: by 2002:a05:6214:226f:b0:707:4fec:c0ca with SMTP id 6a1803df08f44-70926508ddcmr38892246d6.4.1754056283774; Fri, 01 Aug 2025 06:51:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGJom3kFAnf8JFuU2DiA4RfLsiaMRDn6FA+aJ51nDsVnUTvIGfyBP8DkrKWMMjE38R3E76PPQ== X-Received: by 2002:a05:6214:226f:b0:707:4fec:c0ca with SMTP id 6a1803df08f44-70926508ddcmr38891606d6.4.1754056283051; Fri, 01 Aug 2025 06:51:23 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-33238273006sm5917801fa.9.2025.08.01.06.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 06:51:22 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 01 Aug 2025 16:51:12 +0300 Subject: [PATCH 4/8] drm/msm/dpu: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250801-wb-drop-encoder-v1-4-824646042f7d@oss.qualcomm.com> References: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> In-Reply-To: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1817; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=4v/UkWVUd2usRk11ttudKMK/GFE7oPMYIMlz0jnkFl4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBojMZTDNkPGITvncNEDx/CNCeglk1Jp+f/ChpC0 AXAHrPUnAeJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaIzGUwAKCRCLPIo+Aiko 1f8aCACjBXtlBxXcmFySHdDryhXuuyHrGFTLWoQAJYFbFPslFIRoxZSJT6mHErULJ228fcTw8Ww risQU9WSdjD7jV8ENl54qLAQNALPedsvbKGwten2/zVwwHND1/tHm62gE/zJVsv0AAxskybYyqX XgnflK5pL7cHdNq8kEqSnM8NrkQfgWCwS+NE00GVjlUOwvIM+Db4IxyZpw8ysGkKcOooYn0XV1j 4zVzcS/pLcAgTkHK6SEWIusjCrJuUX2qaE0MHEDMfL/vyb+buazqF8TLWkgP4XM94aJOKBQFcAC qr7avC1KLtKnUu4777zLxpSwk41rREYYp97VOlRBxnyQ5KCS X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=WvgrMcfv c=1 sm=1 tr=0 ts=688cc65d cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=UqIHtJT1QCIVCAY24KsA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-ORIG-GUID: iGVT1Y-oTc5XtvL59mL667SC7pclzGPK X-Proofpoint-GUID: iGVT1Y-oTc5XtvL59mL667SC7pclzGPK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEwMyBTYWx0ZWRfX7m35t8lDbL34 IjKxOapQ20ORHKuEjyVVQVXltayYj7x060dMID3aC/5FRoYUjpACByQyE4xuH7vKxj6sMaCyrrd tBY1whd+po0bzj/X4TpjIv/v/j2pZvtPdpeyu8rmD6EcKTOemyz2LBusRtGptOZHpYRiAImliO4 2wJ9L4cI9raoHunsIqM7MkGqCnYN2WEk3ME2zWJOcNyAxyKu9jqCjc5MzVPyTrge3fZkMkkZp3z r3swPEJBEC4ptSKtNrH3JZDhuwNyeM+SHU2q1Gv+18AKvQ8OtH5USsohhLmoRJ4GQolvQs+1XNA D1NG+k4Da38rWvif07bR34fPKLSi30z+Myi2XHSHWwLPBLglIedviQONy87O3S3TX0tjKCh2nmo RCP4QkVVJG3rqyFHpPG2M+y9yjUmA1z+QG+oyLJUOtOLFesVnHVYGlMKMi0mXe7+FwJYbRYX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_04,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 impostorscore=0 adultscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=937 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010103 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/dr= m/msm/disp/dpu1/dpu_writeback.c index 8ff496082902b1ee713e806140f39b4730ed256a..cd73468e369a93c50303db2a7d4= 499bcb17be5d1 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c @@ -80,7 +80,6 @@ static int dpu_wb_conn_atomic_check(struct drm_connector = *connector, static const struct drm_connector_funcs dpu_wb_conn_funcs =3D { .reset =3D drm_atomic_helper_connector_reset, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -131,12 +130,9 @@ int dpu_writeback_init(struct drm_device *dev, struct = drm_encoder *enc, =20 drm_connector_helper_add(&dpu_wb_conn->base.base, &dpu_wb_conn_helper_fun= cs); =20 - /* DPU initializes the encoder and sets it up completely for writeback - * cases and hence should use the new API drm_writeback_connector_init_wi= th_encoder - * to initialize the writeback connector - */ - rc =3D drm_writeback_connector_init_with_encoder(dev, &dpu_wb_conn->base,= enc, - &dpu_wb_conn_funcs, format_list, num_formats); + rc =3D drmm_writeback_connector_init(dev, &dpu_wb_conn->base, + &dpu_wb_conn_funcs, enc, + format_list, num_formats); =20 if (!rc) dpu_wb_conn->wb_enc =3D enc; --=20 2.39.5 From nobody Sun Oct 5 14:30:48 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32F4926FA53 for ; Fri, 1 Aug 2025 13:51:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056289; cv=none; b=q1NI6xsvUQc1GYlbsmhgsnCyZw6IcoYPyCvv5hNM1oFc3pYuWf8XV8fCrBG9t9wBVdq6nDh/Wt06NSSV7FCWYxRt/wlyxzW5/BQCfliS0lvJxtr/F5QK0AERvJNOm+d/kYtgDNnFGMyS49cKkN5m+sj5vYOMiSLCduiWn5DFgY0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056289; c=relaxed/simple; bh=p1vIn/pLBbJ5zOAwN/G9XdaGKb83FPkfI1f2HSftzDk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=So6nbLJgSi6Iml3FAp4/8AxfYR4gt4brz7NELuHY1hGqbhQCFbskv6cKuxUUaQNKfnlGukhDKAUrYrhsjb5LEJittDTOXCOxKrdV1E9dXD/aZk09zFsEkoJBmpKDfP/7CblmVc9S2UW7UlBxDlLmdMVZGEmlE2kC9VMtXy55W6k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VjJ+wtta; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VjJ+wtta" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5718mk5c021714 for ; Fri, 1 Aug 2025 13:51:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= W2UCi+malvB0ar8bb6DW9kSFC86prf8rvHe8q8tIWaw=; b=VjJ+wttaMaAyvo/w Jp5kH6NjJ4kszVYIFnbCxOw0/E9yoW10FgZrcO5RLvi/Kbfr/mAtYEMhvVQumaXH nQTyvuYeFYE+0nKGN5x35T1Nb4xPytiW8wf3Lu2PeYUrv4HItVqM69zKgjh33L9F EhpSEqU6KVVLjpnCG1hPIWwE+uLMC/ZsecUYpYeCqOz+c1bwDjU/xJbFsFllXdIG 0ejkdZE7GPXkgWopZyMVGb9SKvOBA/zITP2odOuNECJ2nzvXfnCQBP9Cw4yUMUDx C0VDjmMMHajjU7xu4hcazhSMOkazuUh/7L5TVGL52BG3mKjFngQ1sLrW2ff2r1GL cTNtEg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484mcrm7q3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 13:51:27 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4aeb8b6acd1so17008381cf.2 for ; Fri, 01 Aug 2025 06:51:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754056286; x=1754661086; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W2UCi+malvB0ar8bb6DW9kSFC86prf8rvHe8q8tIWaw=; b=RkOLpj44EYlYYHQY0Ks8l6qMjJ2BO9dzj8HrcYEvT3XJ+ANglZpIVlcsu53/BKIwvG UulPZd+Fun8ZAzccK3mB3j07YD8+CdpRhtH4g8WTZnZyA90OnPmzF7rRC4gyKuHZtY2L IYHcs/9tt23lkWXRK5duYOW2A68nceVprBreo3YrOe7wLWGYayiILMuXFacMDFcwyQS5 PlAeu2njgssRupttzT8O3o9qhWpOjJA5b8QNPOfRRB01Zllf1W5RklgpZ+jQCW5ud7dD epM+2ZOez86StfaUrP34JIHiKGaz6f7hG2VGcKgTjwVDvl9aV7vw75TLZc7fMSK2Jf84 zdXw== X-Forwarded-Encrypted: i=1; AJvYcCWeIoRS3L3GsVKPzULw4DZ3gM5yAX2VW5RhSzxsN8unZqAK4UODKS9McUGjyyhbApt8LS3YGqa5BijvuGk=@vger.kernel.org X-Gm-Message-State: AOJu0YxuCpXKQmgE7brVqYZx3notLDAAoN5Gdf5FrQufs5K3hBz1vWZh BLAyum2rQ2J4kCwbsrBYNRaKSW/yaAfewuP4/bZU6v2f/L0gcy4seFhGPAc4ynDmBO9mBtzt/Nz JjKwDSfMiOEHqVSJLPaxlROWIsJF8KHKXMysxWCxzHRDkahzgfiFIYubZjtoKDoXc4Wo= X-Gm-Gg: ASbGncuUk0+1oYiIAZ4E53XRNb8EYzlcJpioBY9hcogmVeK7PDF25v34BkEGUStxRVW hAqAluD3f5hSaRmf+7e4D5IYVG8yRQHmwuUEA7QcP2fKxWv63RuyeOuzctP0/t1e20jLxlLPjLo 5+sFWhE9JFb56fURg+ywnSmHKIZirQ1jmUpQBbTPYEpUDe/uIJkRPqPZ08qNiEP5BZDd/frFxmL Ex3szJrZwpPmz0asMcCGmRQu449McRtOK2zIz9lVJRMdH3OCzRpyLALvDmVK9X7P/Ub+HXMujjm mRxIHdJVgeKowoqq80tUkdJoFVz086d2oV2PNG9vdhl3iGd23vQUqGxNPMKpKMIut87xa2gWpFu G9hIEdz4qhTpcbWXoqzHq7b9QaZUdZnHzLMuWKZ5EeCLqTPeG0rCw X-Received: by 2002:a05:622a:4fcd:b0:4ae:f1c4:98fe with SMTP id d75a77b69052e-4aef1c49b02mr76647831cf.34.1754056285909; Fri, 01 Aug 2025 06:51:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFAwqWqcrYsHbU0F2gj2xmMxu0CXmwPTRpB2ryFYEdGwGRHG1UFGg9MBUQvZBikakoqd/cRgw== X-Received: by 2002:a05:622a:4fcd:b0:4ae:f1c4:98fe with SMTP id d75a77b69052e-4aef1c49b02mr76647531cf.34.1754056285484; Fri, 01 Aug 2025 06:51:25 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-33238273006sm5917801fa.9.2025.08.01.06.51.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 06:51:23 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 01 Aug 2025 16:51:13 +0300 Subject: [PATCH 5/8] drm/msm/dpu: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250801-wb-drop-encoder-v1-5-824646042f7d@oss.qualcomm.com> References: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> In-Reply-To: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2200; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=p1vIn/pLBbJ5zOAwN/G9XdaGKb83FPkfI1f2HSftzDk=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ0bPsWCx0yvsNgYcls5I+plW1j3Fjjm+X0px0rzqd0vs0 k3EioQ7GY1ZGBi5GGTFFFl8ClqmxmxKDvuwY2o9zCBWJpApDFycAjCRty0cDE2u3dqvkrq7bmfF GxbJfBK+ZLJFuKaj26z4TYAFw/fJBZ2aYT3Gdf9/PWAxvbefn01Pz+WJmX4Nh7rCawmJhRy1706 af0ncqHWyLqckPz6+/8blWQf0tQ+x+89a5TX7S45x/TNzlh3qyeFRl37Ezzy08rXZJ8bL6ooyoV EfHX5Ebo1krQ1gmbFK0crxnYXlZhXrdSGia/STswu9wpY82y07y9lQNGfJ8xOBFYyxVkrZOx+qb Vw16+qNB63ze6WmWzmfX/E88/ZurZg1MdG+O4LnBeR9/WLr+eX0wq2SAr+u6EnEO5o6eYV8PfnA vv3RupYU979rBV5UGpx5cvFAoH1d+/sSiX/KJit4UycDAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEwMyBTYWx0ZWRfX9JVGrXX660FK ou468oWqvCMKFmoZOwKNLMkAUBDepJurCqAGin4umxLc/68n7AIEEkOcMyHB6TRT5+XN1VKXvPv stHnP4ODJAongTt9Z6b68FRqLBHGKS5ifYkPHnPX2LH7cYGNN3CeBYl5T1cWkQs77YMjMNy3M+c KrDHzx1xTmrAB7AWyogzI1fhKD1fWkqPXbSuWkA39P78EPzgrHcblNZ4YVBg3N7NtJwMZiq8jA8 HsY/cjLwYvd5xN/ZkxM5LtF/eOCVpePelLJa8/389oCzhSDQFE7mbdrLhAU2n4P2/dzCRgLlSK8 dFJesoR852Wjerp0oSlY4mRGvDRS96TEoOohqHAO3bW1OoqVFRafB/n5N+NcBtlk4CL+TyvMgBL jxW3gK8ShFgwK5yo9y7z31Gtrjypn982rqSmdx5ZhEb0sQZ+MqleCLBMHNAmjSHKNul9431S X-Authority-Analysis: v=2.4 cv=Hth2G1TS c=1 sm=1 tr=0 ts=688cc65f cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=mhD89yN676IZukTL2GQA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: 7DXPv9Oa0MpiyxukPk1W53YoKnTtOAAo X-Proofpoint-ORIG-GUID: 7DXPv9Oa0MpiyxukPk1W53YoKnTtOAAo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_04,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 mlxlogscore=912 clxscore=1015 spamscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010103 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 23 +++++++++++++++---= ---- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c b/drivers/= gpu/drm/renesas/rcar-du/rcar_du_writeback.c index 8cd37d7b8ae281cbc1fd8cbb243c621174517e23..9986a10e8114680e9da48986f4c= a3ce6ec66b8cb 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c @@ -134,7 +134,6 @@ static void rcar_du_wb_conn_reset(struct drm_connector = *connector) static const struct drm_connector_funcs rcar_du_wb_conn_funcs =3D { .reset =3D rcar_du_wb_conn_reset, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .atomic_duplicate_state =3D rcar_du_wb_conn_duplicate_state, .atomic_destroy_state =3D rcar_du_wb_conn_destroy_state, }; @@ -202,15 +201,25 @@ int rcar_du_writeback_init(struct rcar_du_device *rcd= u, { struct drm_writeback_connector *wb_conn =3D &rcrtc->writeback; =20 + struct drm_encoder *encoder; + + encoder =3D drmm_plain_encoder_alloc(&rcdu->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &rcar_du_wb_enc_helper_funcs); + + encoder->possible_crtcs =3D 1 << drm_crtc_index(&rcrtc->crtc); + drm_connector_helper_add(&wb_conn->base, &rcar_du_wb_conn_helper_funcs); =20 - return drm_writeback_connector_init(&rcdu->ddev, wb_conn, - &rcar_du_wb_conn_funcs, - &rcar_du_wb_enc_helper_funcs, - writeback_formats, - ARRAY_SIZE(writeback_formats), - 1 << drm_crtc_index(&rcrtc->crtc)); + return drmm_writeback_connector_init(&rcdu->ddev, wb_conn, + &rcar_du_wb_conn_funcs, + encoder, + writeback_formats, + ARRAY_SIZE(writeback_formats)); } =20 void rcar_du_writeback_setup(struct rcar_du_crtc *rcrtc, --=20 2.39.5 From nobody Sun Oct 5 14:30:48 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F6164D599 for ; Fri, 1 Aug 2025 13:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056291; cv=none; b=s0ua8ylJKppky4usQMSMJKh455KML+8ujbjT0Y2GsMxPErTQ+pqiR22yfCvuPb70GIBQoX55YmKC+E3RIhQqhGHldFeIXoxyl2YcoVgrA3+uiNeCBOQ4Uk5K7Pz8DkjAdngn62i9S0or2PHZ1mzabw3s3s/n+D4gw3HZR24vxc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056291; c=relaxed/simple; bh=NBwFx/yH904VfCprkWLv97gvBydY/VJ1MCw22/7DCtU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Yw3R8dFk0zWOj3H6kALzhbx3EfPDe6LW4hVON0yxWIkqgw4VqCJA96Wz+2QswaMZo7H6GxB9mlh3PvIJxe6x9tfy9xA5WF3W1dDFIcE2avToWqCqTuK1GFm33APSmfgyC8QcBEHWwpl7nsY+qqIfUToOaK8PV8SadVEs6C/zXVI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bj6cMkpQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bj6cMkpQ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5719g68k006293 for ; Fri, 1 Aug 2025 13:51:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mLmvIm7aiVxs6oMFsxxhFeeRx+tZKZlR89XtVnuV08M=; b=bj6cMkpQ1CVvcSbF fWDc1EgzCf9Uy42mi859BDmHxMGZLuGWKQ0511T+iMZFf3FBw34+kmvRM9ZwZ2T+ hqSiWO0SElelynghmVxziCRovCRsIoOp0DPCMhhygCXadGqFTBMY31fmCzil56hn TwN1uWP4dvOa9eW9/rLfqx5Hxzi1t9g/fc+EQhci4F7kHScRoMm18OgCxPA/IMJJ Sn+1TZEAkO1SA4NpsS9qT97FYO17Vd89PNXRC1ZFsXpnqbmMpUiqBr4iute12eU/ HjisHaG7kQRnXCTRalQhsczTLaXyaZfligHAJKqA1HEeCralZm5qQxCRbtItymku 3B47hw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 488u650pmr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 13:51:28 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ab44642abeso16224171cf.1 for ; Fri, 01 Aug 2025 06:51:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754056287; x=1754661087; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mLmvIm7aiVxs6oMFsxxhFeeRx+tZKZlR89XtVnuV08M=; b=qvC12KR06t8KvM4j410tRvglAFvEs5NKLZDleURgTDnl4YKdC48Q/x21eK9R7QoizI C4VK0GyrS+plHV9I5HT3WeptOxsORHjsk89q/e/1bWeZj7GumSyECDgrMbYk9mphQr4j uxSX5iLjhKoeGSm9LHbXZMp+zwVOSrWQRUFwTIOkigF530rPHJ9NbK4iws9bJpl2AL5o d4Izq4qeL/6GkXCXVNgXS1AlXrVYgHtZvadPcXRcWgiRhMe+3EfUqj5BmGTnC0afI6Es mPEX9SAL8jzKAgZsHCMnfr25DidLzXk+K1BvO9FmjA/HI3wMHatz3uB8JlEwK4AjTvfy HslQ== X-Forwarded-Encrypted: i=1; AJvYcCXE/hCcDOlUSway1YiKJ/dpNlERlS9PKmtRtPKitANsLzZfsxsRM5O0StsdmfLwvZA3WjkazjwxrzDJhuE=@vger.kernel.org X-Gm-Message-State: AOJu0YwAL2Na5p9mUTbTvDRBiu+Vh8gyqin9YtmAHejcr9TveEcs6Clr Fee+DwI0UH949Zc5xaCK7QsZrnRJK6xWs8ifD70PXJr6GsHDioO8RldcrVu6DrwtHR8yrfo0e0v WSBLdjOlnXWmgVdogce9ifS9d9AR8qxWoCi46rgR22XURCqnZun29yk1QL6K09AfcHl8= X-Gm-Gg: ASbGncuJbpT5dcvLInfXk/kokaxTxs9jCX2eXb65bWvQbxHOO5FJVJ9+czaNIJq5ZQj GQi0s/y/VtQSEsOEtFN3VKOPKS0dEFgiMLqHZ76AhBA2i9XJYr8I1V0anISZN1bS2PGHxY27IB3 FOeiXkJrfL6UEz1z7v2u78wVz66gM6Qn+fvk13cw0TporoXrv/Nn+Tv+CXcVNFdSE6ucx3LAWzS EOwZ/BkacLUM27BJvpKFVQcoTOPo1/DL9JG/PT2qgtT3M1HDVwKDuoCK2wLpwWPB4cM7rJZ2wnK LXvMtiy4+YZVGR7H0LdfjAjx8Le8ztUh9Mt6RklcBv2vMTwSseerVIy+6u7bGN3vXdFE/5iJPGC lISLvIT3quVENvc4Mr18dFbqMAZtrN5UAZM8623+0o3uHtsxUHaC+ X-Received: by 2002:ac8:7f0d:0:b0:4ae:cc29:829b with SMTP id d75a77b69052e-4aefc3aa90amr71546811cf.60.1754056287124; Fri, 01 Aug 2025 06:51:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF2viD7HCKu6xS/QJRV2/S6eN0H8AL2SA3fKo1xo5upDmFhtIUjZt51hysctMnmpx05ndtrSQ== X-Received: by 2002:ac8:7f0d:0:b0:4ae:cc29:829b with SMTP id d75a77b69052e-4aefc3aa90amr71546121cf.60.1754056286612; Fri, 01 Aug 2025 06:51:26 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-33238273006sm5917801fa.9.2025.08.01.06.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 06:51:25 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 01 Aug 2025 16:51:14 +0300 Subject: [PATCH 6/8] drm/vc4: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250801-wb-drop-encoder-v1-6-824646042f7d@oss.qualcomm.com> References: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> In-Reply-To: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1629; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=NBwFx/yH904VfCprkWLv97gvBydY/VJ1MCw22/7DCtU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBojMZTWODg7Z0I052lkDGy5sp+gbJXRPPW3+xXz I8SasIVGkCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaIzGUwAKCRCLPIo+Aiko 1WY8B/42eKCXBjQZniwEwDivu+L77h8KSZkeqYYq+el8I39V5l9aHEmdvGRms2n+efNwV1ck0rj Jy1a9Cv67p7eEXrs8o1zTP+BGa3sKhKTs4lvZWHx3d6YjAcJr2Zg3df9INQWC7IsATuDKgfbA2E JhHLnz8c+tuCb07y0uqnRTHGpLB3UcVli5DjTVGH5gGQPYpegIYqh/FVxuacRujIWIvOW4qRCT8 +FnwXJAsYkPA9arYZIm2kX8awv2FHs2ZTSNfz1ht3uGAjMo4BD1uCkmrqpvMEoLyEzE8gjHsSP8 5aOgtKUcrk2v0+9aBgHAKiILYunQCCOJCo28SHY+jdKL58YA X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: GXFa-easrmm-EpWLjO0dHIshOjMp02Rx X-Proofpoint-GUID: GXFa-easrmm-EpWLjO0dHIshOjMp02Rx X-Authority-Analysis: v=2.4 cv=f+RIBPyM c=1 sm=1 tr=0 ts=688cc660 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=hRdDZflY9wZGYtDLNskA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEwMyBTYWx0ZWRfX2Jpxd1bSGmia lSQSaVRyzYcKFqnBZOUETDWm5rcNxH514ll36UleE41ZjTdZkhPhogikiX0Fj9lIS2Y+6MoI4k9 GgFZb74okiKr9vmHPQ4OLCnwGF8uv4GJGjby6rDDdcoEXgmA2yA7Ctvd1KxmteeahLTNvF2hCs5 7sQ3sJ1PpVgiqamcGDmtc3KJkPWMRvuwEYr4Ys1lP2JghBWVHyOglcuk8hvrg1P30w+R67tqxIv 45bIKHZ4ABrMWeNf2EeJk18eMDAELotzbSn2rSclL2Wp9373sPlCgnKSvRERNEfTChxi41m1fKi GwTsQvLY+lwduIaFIJZB5eT5XFWI2X5ZgijVfQlz3E4LY5WEonxBhVkF+gOVoBMPj4mbUEqZYga vibcW42glbX4qyCceyQhBujgE33PDOE1RN2o0Ov+K0eAduyWvMXBlqXW+r+kDOx7VDdyTWtY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_04,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 malwarescore=0 mlxlogscore=883 mlxscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010103 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/vc4/vc4_txp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c index 42acac05fe47861ced226a4f64661f545e21ddb5..fef4e4ee47cf41d40de47c5201f= 0349dc36c56bd 100644 --- a/drivers/gpu/drm/vc4/vc4_txp.c +++ b/drivers/gpu/drm/vc4/vc4_txp.c @@ -377,7 +377,6 @@ vc4_txp_connector_detect(struct drm_connector *connecto= r, bool force) static const struct drm_connector_funcs vc4_txp_connector_funcs =3D { .detect =3D vc4_txp_connector_detect, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .reset =3D drm_atomic_helper_connector_reset, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, @@ -601,10 +600,10 @@ static int vc4_txp_bind(struct device *dev, struct de= vice *master, void *data) =20 drm_connector_helper_add(&txp->connector.base, &vc4_txp_connector_helper_funcs); - ret =3D drm_writeback_connector_init_with_encoder(drm, &txp->connector, - encoder, - &vc4_txp_connector_funcs, - drm_fmts, ARRAY_SIZE(drm_fmts)); + ret =3D drmm_writeback_connector_init(drm, &txp->connector, + &vc4_txp_connector_funcs, + encoder, + drm_fmts, ARRAY_SIZE(drm_fmts)); if (ret) return ret; =20 --=20 2.39.5 From nobody Sun Oct 5 14:30:48 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA140271447 for ; Fri, 1 Aug 2025 13:51:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056292; cv=none; b=nAkG4euKvg+hF9iMHUbSbTzHTBvzGLN0it/RlmmWD6NW95lArEfZoUkQwqqrrqIwlqstN8vblP/osYnGoHy49PchZIkFSl3uo39wI93XeALzPymYR9RLd3l6qWHAQB2a/R6WStzheGCQoeU2wynRTYe6D8snZO16EcdjWTr9BxU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056292; c=relaxed/simple; bh=gZgct+R3pIg8eXO3IJV5mPFQorUlTRSoPS4dZG7+aRg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fKboIzGMuVMszSVsokywU8UoIYV/zls3RU1J+NusxWWwh7Yjeg4sR9oZbUO20ZQATxL7M0iscEbpVqYgxCbyQeGA51z0x9pOvDldrYp89UXIMBuyQrfJpalAeR9VLEvvk+Co82a9+ex8zVUxo/lzyz6PiEU2sb/E6/D3vEkFR+c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XRpZth5d; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XRpZth5d" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5719CKka020313 for ; Fri, 1 Aug 2025 13:51:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kBx5bn66d6vut0znzeSHUeN3eqzlVEi7rifsJB3EV/E=; b=XRpZth5d5B+ArEFp qt2j+OEM5CBM1SM0Rgw8MPgYk1p7Gp7Cr3IBPVawEsN6bS/LQyBfA+KyK8zQyKhh 0Jz9lcDtN752a4bDJjvFiaW1NVgh8Akyro/bvduCAMu5FvQJ4UeRHJw8/DTtxAX+ lQV9goHAX3AmRDdNZxT6KMWWZoClrU6rpVxGgASMZvat6MCGCoGgoTmoAs/lT2Oh sCaDkNA+GqByye4emPzarqvh+ADlVJd771iYZNeZQGLFFgq18ydQcUL8AtQv1tR4 pu6ig8WH3QAPcfRM3ERR1wgo0cGuU8D/ElAYl5UQ+nrrZKmDLj/fVdltfVEAxkd0 QKhPvw== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484p1auw41-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 13:51:29 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-7074bad051fso28980916d6.1 for ; Fri, 01 Aug 2025 06:51:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754056289; x=1754661089; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kBx5bn66d6vut0znzeSHUeN3eqzlVEi7rifsJB3EV/E=; b=CksOT9DDJ8pBZ4fTjM6+hbKxTXCwfiQYA8L9a/vWkN97aKOPzh7VjyFHbAzfCVys5I mutiKnETvelEjYvisMpYc/fwj4w75PdqcpFycCQYHBzwh4k/DrOk+pZCVp5rl5nmLcMO YZp6xJrj+QkfUuiG9sTKdQXN8K8RExeSKW830fKbqmevd6NI1SpxIUvKh8aIWMM+HwqU 0+N41mGDp32ToelA0IOuJXZeic0js9OqejtRVyScy6QbrMDVgwurUrxpn2PhIW7GKlsZ ePXvIlOPreF+WGcOtXsoLL5YL1xZRDq+RZ7/krp21991GGSYTcC9LfRofYRJ/u4qX5P9 9DJA== X-Forwarded-Encrypted: i=1; AJvYcCVDu4i9OPtTdf7TjYdXxYCNIszpc0lHuUXASOVaEL2OpLHfj0rsjIbCDrRgtiICvsOPDwCPwMdgtCU/Rqw=@vger.kernel.org X-Gm-Message-State: AOJu0YzeVJEX5rmScjHGY9weWzGI5mOLUNj0eStrq7dmwXB4Y17dIEQ1 VfV5UGnOI/CPQVCfsWsW6TGENVJCC76htwoFSV6YtcdGr8NKyzAGif8+/V/MHN5YBWqFUGBA6I9 C9rdZwAh9DlejT5Rh3J6uZK7mGIcacwNyAEWSspooaZR3XUojxL87lVUIpg+Mu62KrtQ= X-Gm-Gg: ASbGncsie3NY84L85CGcsDCiFZGRecPNBTJsC5HyQki9x9MuWd+XvQz8Eq2gz4YYul1 EWm4w1AMlMgddacQFmJlfiGnwjK4sCMBh2zUT7jkcrfxe9+sO2Q+BoIoekmVYKliHFNyUvpO7NX Y2qOQdh9Kg1Oiz6jAvPteU6AYPjYZMPYBw89DUyCLk333qum2kBwaikM6ajh1Zt4Cy8w157qOG0 3o9aPme/AveWOr9JJjkn6mpI5UeYh9SIFOJI1Wph5jqfMk+NBg3bh5+Mpin30ypdapOkzBy0Okp tQKsA4ceroQrO1qktiA0WlT/yYwdKX8ZqS09C/X6KAs0Lp8y6xhUArS1m1HDa55Qa+EGVE2gLVS aiDBhkn7gaLn+oGv91Zfm4/IbXC5tztxPgdklpkhDxB4ecHgfK8yq X-Received: by 2002:ad4:5c6b:0:b0:707:642b:cdf4 with SMTP id 6a1803df08f44-709266e5b39mr33801716d6.44.1754056288520; Fri, 01 Aug 2025 06:51:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGllYuESTRqftyHKDNb4inezLURrR+fzmRpNK5DetH32nfbPqtCnDKyebMVY5gAjPzgta1wgg== X-Received: by 2002:ad4:5c6b:0:b0:707:642b:cdf4 with SMTP id 6a1803df08f44-709266e5b39mr33801266d6.44.1754056287837; Fri, 01 Aug 2025 06:51:27 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-33238273006sm5917801fa.9.2025.08.01.06.51.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 06:51:27 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 01 Aug 2025 16:51:15 +0300 Subject: [PATCH 7/8] drm: writeback: drop excess connector initialization functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250801-wb-drop-encoder-v1-7-824646042f7d@oss.qualcomm.com> References: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> In-Reply-To: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4482; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=gZgct+R3pIg8eXO3IJV5mPFQorUlTRSoPS4dZG7+aRg=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBojMZUui4aeAWjDE1KcnUWDiWpmo7D1w9CnyLW1 NS+7irQsJCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaIzGVAAKCRCLPIo+Aiko 1VnvB/wN1Uyqu8Gb7rElaqvtKoq8ctBCnyPLrCinS1CSpFKhE6DmjVLZ93duHSs8PhT2XLUl+Gk FHlskZNC8PV0yqTDNDF8ljaQxml44/wm5h6idVdLatujDJKa4yVGpox41E2mkKxMFg8cJEQdUHo mDOKWaFTl9tTkseYzULna9+MamFoDNn7K2bAAkU2sqZHh242r0i//UoAcoZD6jvcJOxYtjpoOVT Mi8lHRiCI7shQ+XZfD6Lt1eS35mbm7RQbHnUF5ivVS6Ytsxx8DInpU4WT+Vwf9Q8Dfv7UF4vMzV h9maCrN7tS9BsiflO86XVabEVhHS1tEOnD2ABbu+CMWr4Bsn X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: yDGqAVWWEmkM1JR5xsKpi6231KN0y10r X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEwNSBTYWx0ZWRfX2c54ltxbhfV1 kKVFluHlJheAM/6iv/SARmdilyFg/TrvPIXI+YjXCg6svxjEmIDSsk9n4J3bjB3KUzKCC7r9f2/ HEVH+oYqKie05nuw8xuEJs0cCbuRVq4jZ4DUGVTGIjCdriJpuj3LNxy5SDbvvWtEelxPZ3IGE8c TfgizKJFvm6jj1fFvrlt96uQCVvWJlqYiOZcxGdH6JVODfhf9K2N7jmlCb5n0UnTAB38SPmdRRW Wbf8ZdrVWJ728X+3TnWy3Itx6aK32LwA4bFqA31JJObl9T9IA8W9lLf9aWSNBEW9T0LF/+q5nAd 0lh7sU2xeX4wirmdluxRJVIryp+9NSibeet24b1gWPlSBMKB5GBlkVMoAd0M5gJAvnrABHWeByJ gJrZptVy7GGqlULVCAQJOaVIptdE63l5SaO7QyyGJFBXjyQhu+WQiurhPwsM1Cf4rnhwcLJV X-Proofpoint-GUID: yDGqAVWWEmkM1JR5xsKpi6231KN0y10r X-Authority-Analysis: v=2.4 cv=KtNN2XWN c=1 sm=1 tr=0 ts=688cc661 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=3owybDqXPaZAjLikVYcA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_04,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 adultscore=0 mlxlogscore=904 bulkscore=0 spamscore=0 impostorscore=0 mlxscore=0 malwarescore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010105 Now as all drivers have been converted to drmm_writeback_connector_init(), drop drm_writeback_connector_init() and drm_writeback_connector::encoder field, they are unused now. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_writeback.c | 55 -------------------------------------= ---- include/drm/drm_writeback.h | 18 -------------- 2 files changed, 73 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 95b8a2e4bda69230591b50be15d14d0b3692373b..1a01df91b2c5868e158d489b782= f4c57c61a272c 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -142,61 +142,6 @@ static int create_writeback_properties(struct drm_devi= ce *dev) return 0; } =20 -static const struct drm_encoder_funcs drm_writeback_encoder_funcs =3D { - .destroy =3D drm_encoder_cleanup, -}; - -/** - * drm_writeback_connector_init - Initialize a writeback connector and its= properties - * @dev: DRM device - * @wb_connector: Writeback connector to initialize - * @con_funcs: Connector funcs vtable - * @enc_helper_funcs: Encoder helper funcs vtable to be used by the intern= al encoder - * @formats: Array of supported pixel formats for the writeback engine - * @n_formats: Length of the formats array - * @possible_crtcs: possible crtcs for the internal writeback encoder - * - * This function creates the writeback-connector-specific properties if th= ey - * have not been already created, initializes the connector as - * type DRM_MODE_CONNECTOR_WRITEBACK, and correctly initializes the proper= ty - * values. It will also create an internal encoder associated with the - * drm_writeback_connector and set it to use the @enc_helper_funcs vtable = for - * the encoder helper. - * - * Drivers should always use this function instead of drm_connector_init()= to - * set up writeback connectors. - * - * Returns: 0 on success, or a negative error code - */ -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs) -{ - int ret =3D 0; - - drm_encoder_helper_add(&wb_connector->encoder, enc_helper_funcs); - - wb_connector->encoder.possible_crtcs =3D possible_crtcs; - - ret =3D drm_encoder_init(dev, &wb_connector->encoder, - &drm_writeback_encoder_funcs, - DRM_MODE_ENCODER_VIRTUAL, NULL); - if (ret) - return ret; - - ret =3D drm_writeback_connector_init_with_encoder(dev, wb_connector, &wb_= connector->encoder, - con_funcs, formats, n_formats); - - if (ret) - drm_encoder_cleanup(&wb_connector->encoder); - - return ret; -} -EXPORT_SYMBOL(drm_writeback_connector_init); - static void delete_writeback_properties(struct drm_device *dev) { if (dev->mode_config.writeback_pixel_formats_property) { diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index c380a7b8f55a3616fa070c037d5cc653b0061fe6..879ca103320cc225ffb36874190= 88361315535fc 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -24,17 +24,6 @@ struct drm_writeback_connector { */ struct drm_connector base; =20 - /** - * @encoder: Internal encoder used by the connector to fulfill - * the DRM framework requirements. The users of the - * @drm_writeback_connector control the behaviour of the @encoder - * by passing the @enc_funcs parameter to drm_writeback_connector_init() - * function. - * For users of drm_writeback_connector_init_with_encoder(), this field - * is not valid as the encoder is managed within their drivers. - */ - struct drm_encoder encoder; - /** * @pixel_formats_blob_ptr: * @@ -148,13 +137,6 @@ drm_connector_to_writeback(struct drm_connector *conne= ctor) return container_of(connector, struct drm_writeback_connector, base); } =20 -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs); - int drm_writeback_connector_init_with_encoder(struct drm_device *dev, struct drm_writeback_connector *wb_connector, struct drm_encoder *enc, --=20 2.39.5 From nobody Sun Oct 5 14:30:48 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26D4A272E42 for ; Fri, 1 Aug 2025 13:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056293; cv=none; b=Hc0Afy+rLMtrzAq7sOYYk3B3uS1NtsYPhNhTDQYQbioEUGx98iHWHzUDkFSQPUdguLk2nshHqeWyE8okd7l/ZQJMTesROFOZSBzDKCcwU+pLHEE93aACj0gxYpm6xqbPOm0DzYy/KOek+EzR3xZuDt+cWxaiDPtI1DQM5O+fVZw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056293; c=relaxed/simple; bh=pqburrqLe4QINUtvUHnD5bh/z2B1X5GNCfeW27TyBDU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tOzLkm0G8Et+jv/bMThDt4gNp4FLSWucLlmX6bb9uVQhu10lN5GU7EgZJMgt2bIVqS3r8s2JKW41jzScEjjRX3ZW5ZhuYoP4UlK8Fw8tZz5ozGPKCZWsoYMRGTZFVYV7wd9HNSiS31COm+18/notzltfbA0Dszcq0OzuFg0+hrY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eXVQ9LVF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eXVQ9LVF" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57197hjS001415 for ; Fri, 1 Aug 2025 13:51:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /+B92RCJ6sUHTgOKCSTnvICSpksHijR6GnMpjqqV4BE=; b=eXVQ9LVFhvEmF8lP p9sioUtRWNt9qlqVfwKTdPd1dZALSuCSCvuZW72ZEejYAPH5sWUFPxZdU4BkUHY6 R/8s63SNsGc607WfI7Cd2xNxJYTgezciEz7y1mc6Ne+7LgSYkC59/ssXEcgOShbc kRZKCH/4jd4WbuTIdT4Gy0mFisGvULyws82hWZ2gWBevfGFN7msYcdVI1ZS9EMUU /Z/L70BgzcNyrTIsgpte9+9Do3S/Xvewaot3JKueUJjFszQxfsCwoUHbQ468TZB1 dvk90tLfShZfp5ruHToipUTTXme5/zz/XdnyGXhwvVVj3A7Pwxwp3YC34lf0pdVm 4/xV/g== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484nyucg67-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 13:51:31 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ab844acca0so15501031cf.1 for ; Fri, 01 Aug 2025 06:51:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754056290; x=1754661090; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/+B92RCJ6sUHTgOKCSTnvICSpksHijR6GnMpjqqV4BE=; b=pjXFAnfVhLJFyg+m4tcpn+b0oMETyeN8zs3dy2hi80CaFHHsqhhgisZJkhAYtsL0z6 vudfcW9e4qBEYpXFb9q15fB/vs5YPUpGp+gXCoPvv3QVy224nNonYMsfWj1dXCrDhceS SYraZAuOZ9vpTjmzm8JoYImMHgNeHC/UqbyNR65BbbVZNXXdXtlUZnEwRs4BFkVbRkXK /S98bCK12247ca3S26zh6MrlvsRLhTQcnhPtyk5Ajvm49YfdKj3k56BURAB6qlNTcczT utM6qAXMNfbp9zT5UJek1Bl6rylFeCc8GoX+1Q1bdxd1IUR37pO3LLfgt8pXkPvrJ6iI HsLA== X-Forwarded-Encrypted: i=1; AJvYcCVVj51TGO+9kn03xOpW1qt0TXK560QsgM2gu0wry7H87GzH0KlYm5drjix6TreQnq4YQphNgHb+kghDgGs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8oPMJGE1EfPV2K20+HDwKTtNm+w2+lUcWJnMCT97PnNe59JD/ bUIL+tEzG1eyxxhjJj8L4Zo0QaG78oiaSU/vsB8sDgDqVOXDVuC6s3NTlXx0spMliiehY+yODc4 CbLIrHz+XhWsk84pY28gWV4IsbUkdCzo3Um6sn+RuPE2fI9ARk9MCLx1lf8g5xkicSgI= X-Gm-Gg: ASbGnctG5r//el0XWOmrlaepM20cS2+vnqzczdVidv4wS38MLRWb0Mq+4W9KjjwSAFk f96+bRKVVwsfsRKiENnBnY0ABX8c19L2TpD8xtXI7KI5w1n3KCZtcuSEKv/e443rzwB44dHKA6J PLrda2cTnQBhyysxwmwOp5rtWag3NvOhGpX2dif93zh0d+wJPb5EsEeFuNjgoUGTqtduyf0dMWV IYcSArEJVqXvOB4Q+vDLpWT3rn9ibPpYWBNtuLiclXozDexwRWtFGBbljNV0BwLhTI+P3Zz90mo yjmut2sJU6igD2pCUeoYsF2gEuaIKVW0Xb4F3gDEAXKVPxJE5/yC/xUYmRFVTUnFIRd5enCNLQe F9c3scO/ZhLFzPrl6z/Llow4w5BuoTQXEbxU3p0Oxaoy/3rVJkWoA X-Received: by 2002:a05:622a:a20a:b0:4af:c21:41b1 with SMTP id d75a77b69052e-4af0c214570mr6065351cf.55.1754056289660; Fri, 01 Aug 2025 06:51:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbygvQYA6zDq+LhVmG3CR/4GN/47/XqDWnOK52WBf4RbtBM6/jIq15Eol7L7jNRSofKyA/8A== X-Received: by 2002:a05:622a:a20a:b0:4af:c21:41b1 with SMTP id d75a77b69052e-4af0c214570mr6064831cf.55.1754056289082; Fri, 01 Aug 2025 06:51:29 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-33238273006sm5917801fa.9.2025.08.01.06.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 06:51:28 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 01 Aug 2025 16:51:16 +0300 Subject: [PATCH 8/8] drm: writeback: rename drm_writeback_connector_init_with_encoder() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250801-wb-drop-encoder-v1-8-824646042f7d@oss.qualcomm.com> References: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> In-Reply-To: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3016; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=pqburrqLe4QINUtvUHnD5bh/z2B1X5GNCfeW27TyBDU=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ0bPsZDobW4vfKRTTQ7I9IreLqleOCt7nltN8yGzxgf5O 5s8egU6GY1ZGBi5GGTFFFl8ClqmxmxKDvuwY2o9zCBWJpApDFycAjCRC/rs/4z+eBz0TL8iMp9x 23dr/dQ1Qe+samT3Pm8yl4y0nTyTneN5y1e1HP+LUzWNVyv+fP3yw47Ygqk7Ou8KBvubXv/Z+ml v6wkr1itul793iittLc1Tu/GGfXu7OrvKnYlPZldYVMr+u7XGR1zk4Kdk5R3r3i04My1iUb1tpe al6ZesUs2YWnZ913bV2Ht0+8fsj2yFrhqx1Yq7uRgU6hb8DGpoC7ygm9C57ENL87bC+itts3SfT V7+Qe5sIteVwprDjHtjy//v3cXwTWnjW530O8VerTGKwX8P9fW/3xkWmH/WUDaWM25a/fba0ozp +QyFjHOYhBljH9fvkjvlXJ7d6jF3q9kRH6/lpiqmoY+4AA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: iFvyRGyXujtUQb78stkSZasw-9CgQGto X-Proofpoint-ORIG-GUID: iFvyRGyXujtUQb78stkSZasw-9CgQGto X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEwNSBTYWx0ZWRfX6gUhpo+OxBLv 1riUSVqwvKu0uYl8v08aqKY7atQ/7m8hcseG/jrlGIz99evJoormw0nq5DpqgrmFnVkjwHGEcOI BwvtRXr0UsHH3WZtUSUP+nSPfUeNsFrSbYVHSm77LjilGBfUz/mDkVJDKQQsdFXCSJgV+YHQgXF n/Dy3UP5+ceWbH+V9LLfjv9MccCncOiLtieFw6didRKvG4Ev+sjJgFJOGDmwEW6Y+OZ6VKxn+m4 u9uoIfrKHlPfsJdER1xPMp7McJdPY4Txka6Ph65H3zU/6JQ0JSSf4EwLQlflHLPk5WbySJXgoZr dnhPljDCOLlqh4XMJhHLxfXYus/WuLwQhr/5Egkior8MHvTa1HsFzguf5/u7zKpTLLAg5oBygJJ cpx+yKZFbzwm7mPVyRGQSAbU/94HWW4OFT4K5mD9BnqjPhe9mAzONUIjBbnVsyWVHUnv2OMw X-Authority-Analysis: v=2.4 cv=CLoqXQrD c=1 sm=1 tr=0 ts=688cc663 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=By2WwYRBACVvdXAjiroA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_04,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 clxscore=1015 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010105 Rename drm_writeback_connector_init_with_encoder() to drm_writeback_connector_init() and adapt its interface to follow drmm_writeback_connector_init(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_writeback.c | 14 +++++++------- include/drm/drm_writeback.h | 10 +++++----- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 1a01df91b2c5868e158d489b782f4c57c61a272c..ec2575c4c21b7449707b0595322= e2202a0cf9865 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -235,7 +235,7 @@ static int __drm_writeback_connector_init(struct drm_de= vice *dev, } =20 /** - * drm_writeback_connector_init_with_encoder - Initialize a writeback conn= ector with + * drm_writeback_connector_init - Initialize a writeback connector with * a custom encoder * * @dev: DRM device @@ -263,11 +263,11 @@ static int __drm_writeback_connector_init(struct drm_= device *dev, * * Returns: 0 on success, or a negative error code */ -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - struct drm_encoder *enc, - const struct drm_connector_funcs *con_funcs, - const u32 *formats, int n_formats) +int drm_writeback_connector_init(struct drm_device *dev, + struct drm_writeback_connector *wb_connector, + const struct drm_connector_funcs *con_funcs, + struct drm_encoder *enc, + const u32 *formats, int n_formats) { struct drm_connector *connector =3D &wb_connector->base; int ret; @@ -284,7 +284,7 @@ int drm_writeback_connector_init_with_encoder(struct dr= m_device *dev, =20 return ret; } -EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder); +EXPORT_SYMBOL(drm_writeback_connector_init); =20 /** * drm_writeback_connector_cleanup - Cleanup the writeback connector diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index 879ca103320cc225ffb3687419088361315535fc..958466a05e604b387722610fc11= f9e841316d21b 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -137,11 +137,11 @@ drm_connector_to_writeback(struct drm_connector *conn= ector) return container_of(connector, struct drm_writeback_connector, base); } =20 -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - struct drm_encoder *enc, - const struct drm_connector_funcs *con_funcs, const u32 *formats, - int n_formats); +int drm_writeback_connector_init(struct drm_device *dev, + struct drm_writeback_connector *wb_connector, + const struct drm_connector_funcs *con_funcs, + struct drm_encoder *enc, + const u32 *formats, int n_formats); =20 int drmm_writeback_connector_init(struct drm_device *dev, struct drm_writeback_connector *wb_connector, --=20 2.39.5