From nobody Sun Oct 5 18:16:43 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C480F263F5F; Fri, 1 Aug 2025 11:18:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754047100; cv=none; b=qXELisj7ZyGNJJUcPDA/+4aXigym50g1uj3SYjKjuNuCg3l/HLCA+iYG9EZWdxbeEvgEIWnPbijWIfWDGROjwbbtuLLooF3HOvf5p8iyev0XFvyT/RbGqKvTi106iDm797PBX3uNyOJjGC94n89pslEI+HLUcmxrG7P/1Qh7scs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754047100; c=relaxed/simple; bh=1E5qWJ532EaXeuFQ5rmK4d9Nv2RoVjlXwP4/9o5x3c4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mrG0y06CQWX0mzgED/tfna//XyvxyyISIjOybwAPUebmJEcs3kIlYjNA3OyWdG7MlHp9fvoSfgtP7Q1AwuiE3bYaMAjPeC6QoddBbejysR2UjoDqxrtUxUjxz0rYvsZRsxCAEDZvDow02uYcQJm3/7CILREF9jMNqX9dCShfCEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=YM21j3ie; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="YM21j3ie" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1754047097; bh=1E5qWJ532EaXeuFQ5rmK4d9Nv2RoVjlXwP4/9o5x3c4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=YM21j3ie9AsDcLq0kEisIM0xFmGFEs/XFDgSPJIrVNEAmC0ABjM8k5jDDRw4lL9zI 5ll84Kz0y8GbQfylA9Fqj2d7hwkPC2rdXRuuvhtBR+eUfjHx+QDpD3dq1804voJdCY +eJg6KF1rt+ESaj4dbfp8N91Vbb94XsRpc1Es6hYCxmAW10uFOoai8II4/nllzoQks Yc/K/dgwZsvUrRvgiFdDJ1ldD4+LefbJBVakW9OTaYqX/D501IIe2/p6j3yVEiqh9J IHDn96uwytBt5pxg8kjSLyCD5shjthi50/iJ7GJEr4xp39B3vT40X35uvMRHkGM8YI 4OWirEq74DZlg== Received: from 2a01cb0892f2d600c8f85cf092d4af51.ipv6.abo.wanadoo.fr (2a01cb0892f2d600c8f85cF092d4af51.ipv6.abo.wanadoo.fr [IPv6:2a01:cb08:92f2:d600:c8f8:5cf0:92d4:af51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: jmassot) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3E45717E0F3C; Fri, 1 Aug 2025 13:18:16 +0200 (CEST) From: Julien Massot Date: Fri, 01 Aug 2025 13:18:11 +0200 Subject: [PATCH 9/9] arm64: dts: mediatek: mt8183-pumkin: Fix pull-down/up-adv values Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250801-mtk-dtb-warnings-v1-9-6ba4e432427b@collabora.com> References: <20250801-mtk-dtb-warnings-v1-0-6ba4e432427b@collabora.com> In-Reply-To: <20250801-mtk-dtb-warnings-v1-0-6ba4e432427b@collabora.com> To: kernel@collabora.com, Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Ikjoon Jang , Enric Balletbo i Serra , Chen-Yu Tsai , Weiyi Lu , Eugen Hristev , Liam Girdwood , Mark Brown , Julien Massot , Sean Wang , Linus Walleij Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, Julien Massot X-Mailer: b4 0.14.2 The properties `mediatek,pull-up-adv` and `mediatek,pull-down-adv` were using incorrect values like `<10>` and `<01>`. These values are parsed as decimal (10 and 1 respectively), not binary. However, the driver interprets these as bitfields: - BIT(0): R0 - BIT(1): R1 So valid values are: - 0 =3D> no pull - 1 =3D> enable R0 - 2 =3D> enable R1 - 3 =3D> enable R0 + R1 Using `<10>` is invalid as it exceeds the accepted range. It was likely intended as binary `0b10` (i.e., `2`), to enable R1 only. This patch replaces incorrect values with the correct ones and removes the leading zero from `<01>` to avoid confusion with bitfield notation. Signed-off-by: Julien Massot --- arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts b/arch/arm64/b= oot/dts/mediatek/mt8183-pumpkin.dts index dbdee604edab4318c1ba87b9594ce52282b0c405..bbed369db986f3f24aea470a9ad= 63a7c1e2cb3c9 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts @@ -318,19 +318,19 @@ pins_cmd_dat { ; input-enable; drive-strength =3D ; - mediatek,pull-up-adv =3D <01>; + mediatek,pull-up-adv =3D <1>; }; =20 pins_clk { pinmux =3D ; drive-strength =3D ; - mediatek,pull-down-adv =3D <10>; + mediatek,pull-down-adv =3D <2>; }; =20 pins_rst { pinmux =3D ; drive-strength =3D ; - mediatek,pull-down-adv =3D <01>; + mediatek,pull-down-adv =3D <1>; }; }; =20 @@ -347,25 +347,25 @@ pins_cmd_dat { ; input-enable; drive-strength =3D ; - mediatek,pull-up-adv =3D <01>; + mediatek,pull-up-adv =3D <1>; }; =20 pins_clk { pinmux =3D ; drive-strength =3D ; - mediatek,pull-down-adv =3D <10>; + mediatek,pull-down-adv =3D <2>; }; =20 pins_ds { pinmux =3D ; drive-strength =3D ; - mediatek,pull-down-adv =3D <10>; + mediatek,pull-down-adv =3D <2>; }; =20 pins_rst { pinmux =3D ; drive-strength =3D ; - mediatek,pull-up-adv =3D <01>; + mediatek,pull-up-adv =3D <1>; }; }; =20 @@ -377,13 +377,13 @@ pins_cmd_dat { , ; input-enable; - mediatek,pull-up-adv =3D <10>; + mediatek,pull-up-adv =3D <2>; }; =20 pins_clk { pinmux =3D ; input-enable; - mediatek,pull-down-adv =3D <10>; + mediatek,pull-down-adv =3D <2>; }; =20 pins_pmu { @@ -401,13 +401,13 @@ pins_cmd_dat { ; drive-strength =3D <6>; input-enable; - mediatek,pull-up-adv =3D <10>; + mediatek,pull-up-adv =3D <2>; }; =20 pins_clk { pinmux =3D ; drive-strength =3D <8>; - mediatek,pull-down-adv =3D <10>; + mediatek,pull-down-adv =3D <2>; input-enable; }; }; --=20 2.50.1