From nobody Sun Oct 5 16:16:39 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B6BA20D50B for ; Fri, 1 Aug 2025 07:58:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754035123; cv=none; b=tBk77M5M9sy3TP15jj1Bn2avTOA2v4u7Fjf4jFURibhvv0Sx/+cjZXJCOavySMsBmk9y32WIOSCK4rN7DLAOJIvYjyQy78uDnNZvY3m6wxY9GTmaOU032nc8GNrlQoCqkESj+8G4/xk7n+VHmJD2AKrN9tpKC6g1en+xHx6CF5U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754035123; c=relaxed/simple; bh=wj4wIimu8my3nvS/NdBRWWVLNhEdyKlGDNwK361o5cI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GkzcnBhqM/UxVd/tHLVo9PPZYOlEn/kktGaIA5sRdIuvDKWdBMyvhz/VfidIBmm72o12XtRykZgPpfYoBE49YRQPwWB3Ar3okAZ8f66UliyyWPAjJSoim9KA60b+ild66Xcr+84x3/+TPFhN7KxWQZkDNUIsFWsfCLE1RDlM/9w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rESSvXDG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rESSvXDG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F932C4CEF4; Fri, 1 Aug 2025 07:58:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754035123; bh=wj4wIimu8my3nvS/NdBRWWVLNhEdyKlGDNwK361o5cI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=rESSvXDGfupNL+DW0eP5kfOtG5I5dvZBKkkS0ZxgE8E2z9NjLzetZJAid455k/4m+ wa8lenlMc85aRH662p2KgkrBZimlXuyXwiJYm5fz1uQBWMbDXqjqC98gNFrl/ElXrf 3f2JuM3YguBiNBMt4KzzNDcnkMmzSNhIeMHdbaC1lnFGxBTSLcEFYLT2E3EUaPjvMR 8QI/l/ARbYBbJ072Z3iLdhA9T375krp24E2DjjZOJKcUi+4tY/OP+D7Q0l2FhCWn+F yyVjmW5lq/DOITE57M5HiD7DIfmvhe8yKbJuXCJLAPOSY/t7I8Ve2zG4vUxELIge/P AiyWDVZwJouCQ== From: Lorenzo Pieralisi Date: Fri, 01 Aug 2025 09:58:18 +0200 Subject: [PATCH 1/3] irqchip/gic-v5: iwb: Fix iounmap probe failure path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250801-gic-v5-fixes-6-17-v1-1-4fcedaccf9e6@kernel.org> References: <20250801-gic-v5-fixes-6-17-v1-0-4fcedaccf9e6@kernel.org> In-Reply-To: <20250801-gic-v5-fixes-6-17-v1-0-4fcedaccf9e6@kernel.org> To: Marc Zyngier , Thomas Gleixner , Sascha Bischoff , Timothy Hayes Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi , kernel test robot X-Mailer: b4 0.15-dev-6f78e Kbot reported that on the failure path the driver iounmap() IWB resources that are managed through devm_ioremap(), which is clearly wrong because the driver would end up unmapping the MMIO resource twice on probing failure. Fix this by removing the error path altogether and by letting devres manage the iounmapping on clean-up. Fixes: 695949d8b16f ("irqchip/gic-v5: Add GICv5 IWB support") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202508010038.N3r4ZmII-lkp@int= el.com Signed-off-by: Lorenzo Pieralisi Cc: Thomas Gleixner Cc: Marc Zyngier Reviewed-by: Marc Zyngier --- drivers/irqchip/irq-gic-v5-iwb.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/irqchip/irq-gic-v5-iwb.c b/drivers/irqchip/irq-gic-v5-= iwb.c index ed72fbdd4900..ad9fdc14d1c6 100644 --- a/drivers/irqchip/irq-gic-v5-iwb.c +++ b/drivers/irqchip/irq-gic-v5-iwb.c @@ -241,7 +241,6 @@ static int gicv5_iwb_device_probe(struct platform_devic= e *pdev) struct gicv5_iwb_chip_data *iwb_node; void __iomem *iwb_base; struct resource *res; - int ret; =20 res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) @@ -254,16 +253,10 @@ static int gicv5_iwb_device_probe(struct platform_dev= ice *pdev) } =20 iwb_node =3D gicv5_iwb_init_bases(iwb_base, pdev); - if (IS_ERR(iwb_node)) { - ret =3D PTR_ERR(iwb_node); - goto out_unmap; - } + if (IS_ERR(iwb_node)) + return PTR_ERR(iwb_node); =20 return 0; - -out_unmap: - iounmap(iwb_base); - return ret; } =20 static const struct of_device_id gicv5_iwb_of_match[] =3D { --=20 2.48.0 From nobody Sun Oct 5 16:16:39 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 298F721638A for ; Fri, 1 Aug 2025 07:58:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754035126; cv=none; b=ilsKmHMyqnMyTaK0+GJjoM+MbvqobfWGN83i5mEZgabwkm73AAiir8NXhV3HbUh5mSis0pHy817B7bpon4tMVScpGj84MAL2FcDEbugiM2XrgJWvmm/elAD0mrGoL8lI4ZzVCpsFm/xJOWpKiD53779a0iFs7A9fxo0JvbgFA1g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754035126; c=relaxed/simple; bh=rd8uhK267CHyby4vwT8kjROd6FNXsXkTCVPHV119wCM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sFCyYTUUOHPvSzTvL71DBA+WpkSCg+V/pjcUjUZhQzuPDj03sXylreETnArUm6Wp0m2W3Ti+YHATCNI4oxCjoUC4vW+drB/z8bSIPxM/QyAJ60uwnK+ftRjRFdkKwo5nvdSPX0NpI0jnlxEvgXlbjik7iYeYEJtasR8pjoWt2Bw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DDtDou3G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DDtDou3G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFFF0C4CEF4; Fri, 1 Aug 2025 07:58:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754035125; bh=rd8uhK267CHyby4vwT8kjROd6FNXsXkTCVPHV119wCM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=DDtDou3GSdHKVOn/Grs8mhyGSRXzuCP77/pv03mbdFjHBGVXFH3IE/JbZHboP+p3R 57tsHF+osST0uJyFMsx3seXYvGsMBpD5zCZalpsZF2roy81w83t7b1YoVqngUB5OvE bjiVcrL2gFGS6KEKoGfvsPOqe/wwM9trV9GxofKJSvs5agCa789fyiMp6I6+/6RqkX vEH+m12EAbFU8bZpJ6kx0Q6L8AceQnBLDo0X+5JcTcI8oTObMGamdoARmcZeM56Xdr CyJp43/RG4tf5Z9ahaivXcXpA6wU6Pxvf3HrXHScHZvm7exJoXohLaSJDJNOl0U+Wx OwfkAh1lB7g1g== From: Lorenzo Pieralisi Date: Fri, 01 Aug 2025 09:58:19 +0200 Subject: [PATCH 2/3] irqchip/gic-v5: iwb: Remove module boilerplate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250801-gic-v5-fixes-6-17-v1-2-4fcedaccf9e6@kernel.org> References: <20250801-gic-v5-fixes-6-17-v1-0-4fcedaccf9e6@kernel.org> In-Reply-To: <20250801-gic-v5-fixes-6-17-v1-0-4fcedaccf9e6@kernel.org> To: Marc Zyngier , Thomas Gleixner , Sascha Bischoff , Timothy Hayes Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi X-Mailer: b4 0.15-dev-6f78e The IWB driver cannot be compiled as a module and is as matter of fact a builtin driver at present. Make it explicitly so by removing useless boilerplate and by using the builtin_platform_driver() helper to initialize its registration functions. Signed-off-by: Lorenzo Pieralisi Cc: Thomas Gleixner Cc: Marc Zyngier --- drivers/irqchip/irq-gic-v5-iwb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-gic-v5-iwb.c b/drivers/irqchip/irq-gic-v5-= iwb.c index ad9fdc14d1c6..c3a3b30e9f4e 100644 --- a/drivers/irqchip/irq-gic-v5-iwb.c +++ b/drivers/irqchip/irq-gic-v5-iwb.c @@ -263,7 +263,6 @@ static const struct of_device_id gicv5_iwb_of_match[] = =3D { { .compatible =3D "arm,gic-v5-iwb" }, { /* END */ } }; -MODULE_DEVICE_TABLE(of, gicv5_iwb_of_match); =20 static struct platform_driver gicv5_iwb_platform_driver =3D { .driver =3D { @@ -274,4 +273,4 @@ static struct platform_driver gicv5_iwb_platform_driver= =3D { .probe =3D gicv5_iwb_device_probe, }; =20 -module_platform_driver(gicv5_iwb_platform_driver); +builtin_platform_driver(gicv5_iwb_platform_driver); --=20 2.48.0 From nobody Sun Oct 5 16:16:39 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59A3421A43D for ; Fri, 1 Aug 2025 07:58:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754035128; cv=none; b=SNYk4aelK/i/XK8V6qmVDVeArCAuXao8w2WUekosisoLyQatUgf+B896eiWNM6n+24bzt0OcmO7+71lyrtblRu0TzuE3tQVGV1MsXy/ySJhxuqmbLzBErZMReoW1tC2oG9V8qxtx3CA6uahbQgFh4OpWnnWx+UfY4INiuoYJ5c8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754035128; c=relaxed/simple; bh=hTPka0+81M201oPI7GZI6XuIue8ZoP/MzhVc+eZGACg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q+qjXqkTWNrVWlt5NCCZAA1AA6ALDCLhtjzXt2jYB1x55mQl3u+6c9rZr0Awm2yyAL9N8xwFEDkJZhMw/LDILd5uwe7G8DhD5d5XI3f5Fqu69vTowOuGAQ+onwYoH8B8smjAgxe4KBa3J9x2eTTD5qO2O59mZZ2twuppttyl/q8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gVNXkKfP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gVNXkKfP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B706C4CEF8; Fri, 1 Aug 2025 07:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754035127; bh=hTPka0+81M201oPI7GZI6XuIue8ZoP/MzhVc+eZGACg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=gVNXkKfPSVCJTbgWig5KIlQBcYWtKG/dz0HXi8RJz3eZKzie1Cstp/+pt/XVoLtws vpecW5OF2dlDv5JxPC1DwggmQBLQXdD5OY5QsFVSdhdWk+G/nMPkA/6/51Whg4NviA zQPNAAuePCRlplcnTiSMVqaqBL8xnEaUDU/rEp9Vg4lbKoFvlg28ma3n5p7FKBWmKg UlLh5YR0SBz+1rClqyKaA3tLQ33h5EngqH72ZQ1d+Ek/b40pHG6cxPMGp4VnL5udIY PHOz+akB45uPdJXNm4bGUO8V/2C+LJeV1oe4ZYpGlXmZUahumR0BlB5ZQgC8ch2lGM JekxPyAUVloPA== From: Lorenzo Pieralisi Date: Fri, 01 Aug 2025 09:58:20 +0200 Subject: [PATCH 3/3] irqchip/gic-v5: Remove IRQD_RESEND_WHEN_IN_PROGRESS for ITS IRQs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250801-gic-v5-fixes-6-17-v1-3-4fcedaccf9e6@kernel.org> References: <20250801-gic-v5-fixes-6-17-v1-0-4fcedaccf9e6@kernel.org> In-Reply-To: <20250801-gic-v5-fixes-6-17-v1-0-4fcedaccf9e6@kernel.org> To: Marc Zyngier , Thomas Gleixner , Sascha Bischoff , Timothy Hayes Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi X-Mailer: b4 0.15-dev-6f78e GICv5 LPI interrupts have an active state hence they cannot retrigger while the IRQ is being handled. Therefore setting IRQD_RESEND_WHEN_IN_PROGRESS for GICv5 ITS interrupts provides no benefit and it is useless (and confusing), it solves an issue that cannot happen. Remove it. Signed-off-by: Lorenzo Pieralisi Cc: Thomas Gleixner Cc: Marc Zyngier --- drivers/irqchip/irq-gic-v5-its.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-= its.c index 340640fdbdf6..9290ac741949 100644 --- a/drivers/irqchip/irq-gic-v5-its.c +++ b/drivers/irqchip/irq-gic-v5-its.c @@ -973,7 +973,6 @@ static int gicv5_its_irq_domain_alloc(struct irq_domain= *domain, unsigned int vi irqd =3D irq_get_irq_data(virq + i); irqd_set_single_target(irqd); irqd_set_affinity_on_activate(irqd); - irqd_set_resend_when_in_progress(irqd); } =20 return 0; --=20 2.48.0