From nobody Sun Oct 5 16:18:53 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C2EE1F7569; Thu, 31 Jul 2025 16:03:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977788; cv=pass; b=Mw6abGQq4UqigHb8lmMVX1cg27/dSeR41qnyXMQdm7vtvfXZacGBuTo7avIz1jdEpjtjT+IEgEznulpfBwnbrAmFlpIaS9r6NXOu2lyp2pCeADBsAJ0IXibd16ads/Q9Npo3kxO2v690x4UvYjCJeGCbGf8DbSPiSIu4rhFnuvw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977788; c=relaxed/simple; bh=No24s4T5i2jffXqMefP6oST480RjYux7jXeoFxtjyu8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=glWa02uPx/xdMxjs0W5DuZlZi8NwAWqA4aYcxThCe6N3AoYAXfSjQ5sK8ywuPC3siOLwLt8/vXHlYgBTODHL9wYQkhAol0OEePg+MQlXlnvsXZG905S15+KQi828q5Fa6oGolhZusmy05Od176rgvTn6LNA8FggLljc0kZPqdSI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b=XrTVbySq; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b="XrTVbySq" ARC-Seal: i=1; a=rsa-sha256; t=1753977741; cv=none; d=zohomail.com; s=zohoarc; b=kZrcr8lGjCQ/uaYK88EneYfN9ao5iMrIBdWosfJasMphAJ+cPsUae+MsXRWpNTJQ2tuMMoGDsQJGfRUlk6ZZ31RYSYDRaPmFnRO97x1qjXvufx2sdQPsUXSfy7CS8HV2xD0sJcH4tywWNZM8rogeXywoqIdoG/S/1TiSGyyRNwI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753977741; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=0rIUsTPjbY2X209n7mDn3VwLafDt4aFcMM5+u+5YCmk=; b=F5IMe+DOqWDoDKoKKGDgGGaQmw31nvnJ+KztuVci0qh25Ojm+uUW8vJm66LWSJjuAE1wrn2whXV2iEjB42gYvFVPfIVvQ4YIKKdGl5NxztAboLrRE8LDmwf48uhBxhsvEoTLC3CATq3OPWcb/7T4aGdDCgzEtc54jz4WwPOPbQc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1753977741; s=zohomail; d=collabora.com; i=usama.anjum@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=0rIUsTPjbY2X209n7mDn3VwLafDt4aFcMM5+u+5YCmk=; b=XrTVbySq+/g7c2Lj1WWTvNchEk/DPefYFSW+l/DPiM3RTR1jK97eeN6kQWi/uqCn 4TbpNczuDUhU3hmlpg/ORIfQKY88frscvRFeoHjMi0OKR26mWrB5qGFMGKNajkvOkba y3oqaKPZCEbduEF/ife2TlXQ0ee2aLNB2MrSDlsA= Received: by mx.zohomail.com with SMTPS id 1753977738812600.6316331219836; Thu, 31 Jul 2025 09:02:18 -0700 (PDT) From: Muhammad Usama Anjum To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, Shuah Khan Cc: Muhammad Usama Anjum , kernel@collabora.com Subject: [PATCH v2 1/8] selftests/mm: Add -Wunreachable-code and fix warnings Date: Thu, 31 Jul 2025 21:01:25 +0500 Message-Id: <20250731160132.1795351-2-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250731160132.1795351-1-usama.anjum@collabora.com> References: <20250731160132.1795351-1-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Content-Type: text/plain; charset="utf-8" Enable -Wunreachable-code flag to catch dead code and fix them. 1. Remove the dead code and write a comment instead: hmm-tests.c:2033:3: warning: code will never be executed [-Wunreachable-code] perror("Should not reach this\n"); ^~~~~~ 2. ksft_exit_fail_msg() calls exit(). Remove the dead code. split_huge_page_test.c:301:3: warning: code will never be executed [-Wunreachable-code] goto cleanup; ^~~~~~~~~~~~ 3. Remove duplicate inline. pkey_sighandler_tests.c:44:15: warning: duplicate 'inline' declaration specifier [-Wduplicate-decl-specifier] static inline __always_inline Signed-off-by: Muhammad Usama Anjum Reviewed-by: Sidhartha Kumar --- tools/testing/selftests/mm/Makefile | 1 + tools/testing/selftests/mm/hmm-tests.c | 5 ++--- tools/testing/selftests/mm/pkey_sighandler_tests.c | 2 +- tools/testing/selftests/mm/split_huge_page_test.c | 4 +--- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/= mm/Makefile index d13b3cef2a2b2..23d4bf6215465 100644 --- a/tools/testing/selftests/mm/Makefile +++ b/tools/testing/selftests/mm/Makefile @@ -34,6 +34,7 @@ endif MAKEFLAGS +=3D --no-builtin-rules =20 CFLAGS =3D -Wall -O2 -I $(top_srcdir) $(EXTRA_CFLAGS) $(KHDR_INCLUDES) $(T= OOLS_INCLUDES) +CFLAGS +=3D -Wunreachable-code LDLIBS =3D -lrt -lpthread -lm =20 # Some distributions (such as Ubuntu) configure GCC so that _FORTIFY_SOURC= E is diff --git a/tools/testing/selftests/mm/hmm-tests.c b/tools/testing/selftes= ts/mm/hmm-tests.c index 141bf63cbe05e..15aadaf24a667 100644 --- a/tools/testing/selftests/mm/hmm-tests.c +++ b/tools/testing/selftests/mm/hmm-tests.c @@ -2027,11 +2027,10 @@ TEST_F(hmm, hmm_cow_in_device) if (pid =3D=3D -1) ASSERT_EQ(pid, 0); if (!pid) { - /* Child process waitd for SIGTERM from the parent. */ + /* Child process waits for SIGTERM from the parent. */ while (1) { } - perror("Should not reach this\n"); - exit(0); + /* Should not reach this */ } /* Parent process writes to COW pages(s) and gets a * new copy in system. In case of device private pages, diff --git a/tools/testing/selftests/mm/pkey_sighandler_tests.c b/tools/tes= ting/selftests/mm/pkey_sighandler_tests.c index b5e076a564c95..302fef54049c8 100644 --- a/tools/testing/selftests/mm/pkey_sighandler_tests.c +++ b/tools/testing/selftests/mm/pkey_sighandler_tests.c @@ -41,7 +41,7 @@ static siginfo_t siginfo =3D {0}; * syscall will attempt to access the PLT in order to call a library funct= ion * which is protected by MPK 0 which we don't have access to. */ -static inline __always_inline +static __always_inline long syscall_raw(long n, long a1, long a2, long a3, long a4, long a5, long= a6) { unsigned long ret; diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/test= ing/selftests/mm/split_huge_page_test.c index 05de1fc0005b7..a85b2e393e4e8 100644 --- a/tools/testing/selftests/mm/split_huge_page_test.c +++ b/tools/testing/selftests/mm/split_huge_page_test.c @@ -296,10 +296,8 @@ void split_file_backed_thp(int order) ksft_exit_fail_msg("Unable to create a tmpfs for testing\n"); =20 status =3D snprintf(testfile, INPUT_MAX, "%s/thp_file", tmpfs_loc); - if (status >=3D INPUT_MAX) { + if (status >=3D INPUT_MAX) ksft_exit_fail_msg("Fail to create file-backed THP split testing file\n"= ); - goto cleanup; - } =20 fd =3D open(testfile, O_CREAT|O_RDWR, 0664); if (fd =3D=3D -1) { --=20 2.39.5 From nobody Sun Oct 5 16:18:53 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE29323F403; Thu, 31 Jul 2025 16:03:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977840; cv=pass; b=bAXpntElUsHCGgTVEvbjzkciHWHG5dnwugh7Lf48LXgkz03WBv8pPg97PX+HGIkJukYfnPhqh8PJmfhRoD7aNI5i3PK+u/kXtBVVnaHP9MlubfbIa+qSW0nrC/JS3whO1Ad6lGCWklTBzq4wET4/3m7IY7Kk9qtSsoesSGUat8w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977840; c=relaxed/simple; bh=eDKzkMDZF/mxj5E5sFDQz9q7rcAf5JyA7EJM+AuDcIo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fRLOrV2vWE8fng2IyVAYyW8fApZh3d+0PSsqJWvtZ8gUkGQrx/c1pxfoeJR/4zWATbqYY+4+xeMan9Z32fKZHTMNhvELYtOyc/uDT6k0NPx5bNY2BQo/6ZJeBNNT3aeK0jqTfozw1rQ4WNwtkkxMQlX//m/f0oY0E4d787zNxFI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b=bcQ9Gw+j; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b="bcQ9Gw+j" ARC-Seal: i=1; a=rsa-sha256; t=1753977750; cv=none; d=zohomail.com; s=zohoarc; b=DGVGICaTwhhJr59gs+cfZIQtxM2SepPnYLR/ivuLXW+6ONYxfFOmF/m90Avpb5zRkiM1CFHFsumMTL5pQP5LO1apBSZ7JW974L42i0iGtZSOqi4uwI3I8+yLa6jQUhNFDDrbLhA4XVB9LBEQb0FMYKWiQMPUu36H2bUQlgA1vE8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753977750; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=jsundmjk432Nmx+yxivH/Xk7ers/4Sj7qV5Y59avV5g=; b=jXJ5PIT9OftLeQJq9Mgv/O2RwZNvlA+Z3/MdnDE2IeJIf3jCRszZlUXaespC1q5Mk6PBc2z0B9VvyXApz7fOQZoih+KbUnPvx40pLpTlBGtYPffCH1x2waK7hFVc/SGJtRiNLorQwf95kuIHn8kXKMqQbLcC73lXCUFlrR1blZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1753977749; s=zohomail; d=collabora.com; i=usama.anjum@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=jsundmjk432Nmx+yxivH/Xk7ers/4Sj7qV5Y59avV5g=; b=bcQ9Gw+jfHYzvDinaxptTQseABCW6dyLRb4HAE/vHF5+bg6OQXjqZtEp9b2szz6N kw6Iy4yI6w830plPR6802G9dUD4zErzqq7DnRMDJwv+r/eeEeorIPNi2MJYsXxMd65y 3aSpCymxEyWj7fLqY8U5Q2VgOHl1NstMwA1xXyMc= Received: by mx.zohomail.com with SMTPS id 17539777482221004.5959311406996; Thu, 31 Jul 2025 09:02:28 -0700 (PDT) From: Muhammad Usama Anjum To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, Shuah Khan Cc: Muhammad Usama Anjum , kernel@collabora.com Subject: [PATCH v2 2/8] selftests/mm: protection_keys: Fix dead code Date: Thu, 31 Jul 2025 21:01:26 +0500 Message-Id: <20250731160132.1795351-3-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250731160132.1795351-1-usama.anjum@collabora.com> References: <20250731160132.1795351-1-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Content-Type: text/plain; charset="utf-8" The while loop doesn't execute and following warning gets generated: protection_keys.c:561:15: warning: code will never be executed [-Wunreachable-code] int rpkey =3D alloc_random_pkey(); Let's enable the while loop such that it gets executed nr_iterations times. Simplify the code a bit as well. Signed-off-by: Muhammad Usama Anjum Reviewed-by: Sidhartha Kumar --- tools/testing/selftests/mm/protection_keys.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/testing/selftests/mm/protection_keys.c b/tools/testing/s= elftests/mm/protection_keys.c index 23ebec367015f..6281d4c61b50e 100644 --- a/tools/testing/selftests/mm/protection_keys.c +++ b/tools/testing/selftests/mm/protection_keys.c @@ -557,13 +557,11 @@ int mprotect_pkey(void *ptr, size_t size, unsigned lo= ng orig_prot, int nr_iterations =3D random() % 100; int ret; =20 - while (0) { + while (nr_iterations-- >=3D 0) { int rpkey =3D alloc_random_pkey(); ret =3D sys_mprotect_pkey(ptr, size, orig_prot, pkey); dprintf1("sys_mprotect_pkey(%p, %zx, prot=3D0x%lx, pkey=3D%ld) ret: %d\n= ", ptr, size, orig_prot, pkey, ret); - if (nr_iterations-- < 0) - break; =20 dprintf1("%s()::%d, ret: %d pkey_reg: 0x%016llx" " shadow: 0x%016llx\n", --=20 2.39.5 From nobody Sun Oct 5 16:18:53 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E740239E94; Thu, 31 Jul 2025 16:03:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977833; cv=pass; b=FTtSOj6NQFJjTzZQne+clctaIwgKT/3+pX9dk+fc2tBjtUl7JuNn1lA7aKlIllGB5AEsb/37vxqwtBWRwHwTIEvYqiq1ejpjUEztT/GIJsob/VAovGOm8atpiUOhEexCDTv+r9n3IYTr7P033RmS/BF3aVz7bfVrax1w8ZI41oE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977833; c=relaxed/simple; bh=VXTNkqzTkDqV8GcHSpjtiQgoPkdEsP7OLKlAE7g0p4U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kvcms1Kmq256fpN+XHoEfyisrrJR+Z+kMfB8Qr1gGMGtL3MkYxDlkygdKJSLx1+PWaIl6vgKfoLJj4jzpEt1aoQTOLtAqb7T0G2Qi6CGyUqCv/nbEzmt12Vvgn/fgZGzEGvQscJZ4huLQZGwl2hXPZ3HGHxKD1RlkFoML/ZYMr4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b=S1rC1MQy; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b="S1rC1MQy" ARC-Seal: i=1; a=rsa-sha256; t=1753977760; cv=none; d=zohomail.com; s=zohoarc; b=kNoE6JDxCi1zslQy1xpg+mF1/vsqY1D3IqpBnpStBmj+OXDL0sRiK9X/8RP0WJWhQV9EKf6arQbng8mdB1tISDmG3vzzJlBS5uQb92J4ctr3c0tK6Divd0PQ7nSxl5QW/LjfuA7kV1cn+p7frVI8nWvHO6p15RpIQAnQ81pLKM0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753977760; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=CXpQvoH9jL/54pJyNmcqlS3Y6t709TK/3sP/jYyYCZU=; b=NZyZzrXp0QdTzwxwKsCxIjIaiVVOA+no4R91yXoWdSxF0z/gyHj5/Gpjidw12oRfYSrdld3Yzur+XoJDWV9ZfNDjTkCXXsjngucvUvvrykcXVyW/yAXYwv+80v8ozhEpkkaUKJGM7OqeS8arsYYbWWHWniiSLhs950yL99WZQRg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1753977760; s=zohomail; d=collabora.com; i=usama.anjum@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=CXpQvoH9jL/54pJyNmcqlS3Y6t709TK/3sP/jYyYCZU=; b=S1rC1MQyyVxUh5al7QzD/wEtVu0CmD2bLe+i9LKJ+7ptHaYzR0G48z6r+BrAVQW7 jYiG5zrcVD4s2Lfc/fxvmu6Yth9ziyoLW5uiVmJVlmwAKFvZM2WY+t0wU4jbYoDkg5t 7ThNDHHQcLZAZz6U2Oa5pA93JU1WwkDUolq7NmkI= Received: by mx.zohomail.com with SMTPS id 1753977758262407.9841044700861; Thu, 31 Jul 2025 09:02:38 -0700 (PDT) From: Muhammad Usama Anjum To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, Shuah Khan Cc: Muhammad Usama Anjum , kernel@collabora.com Subject: [PATCH v2 3/8] selftests: kselftest.h: Add __unused macro Date: Thu, 31 Jul 2025 21:01:27 +0500 Message-Id: <20250731160132.1795351-4-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250731160132.1795351-1-usama.anjum@collabora.com> References: <20250731160132.1795351-1-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Content-Type: text/plain; charset="utf-8" Add __unused macro instead of using the complete verbose unused compiler attribute. The raw __attribute__((__unused__)) is quite long and makes code too much verbose to the kernel developer's taste. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/kselftest.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/= kselftest.h index c3b6d2604b1e4..8d17036d88396 100644 --- a/tools/testing/selftests/kselftest.h +++ b/tools/testing/selftests/kselftest.h @@ -92,6 +92,10 @@ #endif #define __printf(a, b) __attribute__((format(printf, a, b))) =20 +#ifndef __unused +#define __unused __attribute__((__unused__)) +#endif + /* counters */ struct ksft_count { unsigned int ksft_pass; --=20 2.39.5 From nobody Sun Oct 5 16:18:53 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7408521516E; Thu, 31 Jul 2025 16:04:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977864; cv=pass; b=eXs10kmbOwBBSTZbAp15n4wIUUkZujddIrhYoRdDuyEa8yynGuuHq3q2BH1xsn8tEhk/Wp5/pAKCrpewg1kL44Cv7elox/dt0bh4ou66sJPbcKjuIrF2hLm/iVlCA/1UhtB5DQf+Ytpw5wWxSfdHq41wFSyzlHnjrjq6nhw5pV0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977864; c=relaxed/simple; bh=NmKXAR9V2R/Bgu+X3UJFhRy6mA5UWrDyKsRFLDZrpEg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cg8HwVdg5f0tVjjA6GrIiu53ILk+LgWLmpghuOLqHgkqh07ABFWUAWAYgx0IqmJEEHMT+2EemLcaDDqvu3wqKqOmSyZe/BTcEbP+IH5VxobN10tpvS4uAdcMf/RNDHMiOfBUNp7P+Eq7v13KBpPJl84FbIRQz6r+ng/2F9+GwK4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b=ico7FzEo; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b="ico7FzEo" ARC-Seal: i=1; a=rsa-sha256; t=1753977774; cv=none; d=zohomail.com; s=zohoarc; b=Ld0isy669SiUPlxBjYL00zV68jo3jmBbmKOi9wWCjDCArTT+yBfeiRQ3Rc3fPYDVDAOf/MclMBROVGpHOXmiugTAp6AiQ+3x7cRxjbKvioWxXczqQMAfX5W2dVNRxp/SOpgmKmhuXBj1iwRvRCEWjinPavrFuC2nyniy9o0JGkI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753977774; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=EMrVRz1c7lWgAJev1ywCCQZY315K/Pj6btdYQU662ps=; b=iAqhu+P9PjbMky9GooYr9CSLU4qeb/h/KH2U3UG3PGvge6cGJXVG79KrGCdcQqpDKk7K2FiuMlZ+Q8pfPe37inlrkPtsy4KOcDpKa+AwKKifGr3WZLtLLoaOUv+A3aPgGog64rw+nx6mEn+GDRElYpa9l76KdyCaimt3P3bOYd4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1753977774; s=zohomail; d=collabora.com; i=usama.anjum@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=EMrVRz1c7lWgAJev1ywCCQZY315K/Pj6btdYQU662ps=; b=ico7FzEouaeu+Zh7BNO0zMc2PILb9ftQ7nECHu7NbMpX1jmKCFyl0WVfFJF1VsVA wCsuXfExvYMvyeb6l2A451QfYmlzNYRV/TPLZRfcJR6CQFPrQPTI8slyKRr8eaooP2v MhGJmHP26R3GX7Q7OJvIHl6WsiS/qH4u0MmknFYQ= Received: by mx.zohomail.com with SMTPS id 175397777225950.334810900997695; Thu, 31 Jul 2025 09:02:52 -0700 (PDT) From: Muhammad Usama Anjum To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, Shuah Khan Cc: Muhammad Usama Anjum , kernel@collabora.com Subject: [PATCH v2 4/8] selftests/mm: Add -Wunused family of flags Date: Thu, 31 Jul 2025 21:01:28 +0500 Message-Id: <20250731160132.1795351-5-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250731160132.1795351-1-usama.anjum@collabora.com> References: <20250731160132.1795351-1-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Content-Type: text/plain; charset="utf-8" Add -Wunused family of flags and fix all the warnings coming because of argc and argv. Remove them if they aren't being used entirely. Use __unused compiler attribute with argc where argv is being used. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/Makefile | 2 +- tools/testing/selftests/mm/compaction_test.c | 2 +- tools/testing/selftests/mm/cow.c | 2 +- tools/testing/selftests/mm/droppable.c | 2 +- tools/testing/selftests/mm/gup_longterm.c | 2 +- tools/testing/selftests/mm/hugepage-vmemmap.c | 2 +- tools/testing/selftests/mm/hugetlb-madvise.c | 2 +- tools/testing/selftests/mm/hugetlb-soft-offline.c | 2 +- tools/testing/selftests/mm/madv_populate.c | 2 +- tools/testing/selftests/mm/map_populate.c | 2 +- tools/testing/selftests/mm/memfd_secret.c | 2 +- tools/testing/selftests/mm/mlock-random-test.c | 2 +- tools/testing/selftests/mm/mlock2-tests.c | 2 +- tools/testing/selftests/mm/on-fault-limit.c | 2 +- tools/testing/selftests/mm/pkey_sighandler_tests.c | 2 +- tools/testing/selftests/mm/soft-dirty.c | 2 +- tools/testing/selftests/mm/uffd-wp-mremap.c | 2 +- tools/testing/selftests/mm/virtual_address_range.c | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/= mm/Makefile index 23d4bf6215465..d75f1effcb791 100644 --- a/tools/testing/selftests/mm/Makefile +++ b/tools/testing/selftests/mm/Makefile @@ -20,7 +20,6 @@ endif # thus tricking Make (and you!) into believing that All Is Well, in subseq= uent # make invocations: .DELETE_ON_ERROR: - # Avoid accidental wrong builds, due to built-in rules working just a litt= le # bit too well--but not quite as well as required for our situation here. # @@ -35,6 +34,7 @@ MAKEFLAGS +=3D --no-builtin-rules =20 CFLAGS =3D -Wall -O2 -I $(top_srcdir) $(EXTRA_CFLAGS) $(KHDR_INCLUDES) $(T= OOLS_INCLUDES) CFLAGS +=3D -Wunreachable-code +CFLAGS +=3D -Wunused -Wunused-parameter -Wunused-function -Wunused-label = -Wunused-variable -Wunused-value LDLIBS =3D -lrt -lpthread -lm =20 # Some distributions (such as Ubuntu) configure GCC so that _FORTIFY_SOURC= E is diff --git a/tools/testing/selftests/mm/compaction_test.c b/tools/testing/s= elftests/mm/compaction_test.c index 9bc4591c7b169..4fa03679e9b07 100644 --- a/tools/testing/selftests/mm/compaction_test.c +++ b/tools/testing/selftests/mm/compaction_test.c @@ -203,7 +203,7 @@ int set_zero_hugepages(unsigned long *initial_nr_hugepa= ges) return ret; } =20 -int main(int argc, char **argv) +int main(void) { struct rlimit lim; struct map_list *list =3D NULL, *entry; diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/= cow.c index d30625c18259b..eb1ccf067b633 100644 --- a/tools/testing/selftests/mm/cow.c +++ b/tools/testing/selftests/mm/cow.c @@ -1857,7 +1857,7 @@ static int tests_per_non_anon_test_case(void) return tests; } =20 -int main(int argc, char **argv) +int main(void) { struct thp_settings default_settings; =20 diff --git a/tools/testing/selftests/mm/droppable.c b/tools/testing/selftes= ts/mm/droppable.c index f3d9ecf96890a..90ea6377810c5 100644 --- a/tools/testing/selftests/mm/droppable.c +++ b/tools/testing/selftests/mm/droppable.c @@ -15,7 +15,7 @@ =20 #include "../kselftest.h" =20 -int main(int argc, char *argv[]) +int main(void) { size_t alloc_size =3D 134217728; size_t page_size =3D getpagesize(); diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/self= tests/mm/gup_longterm.c index 268dadb8ce438..7fe4f94400cb6 100644 --- a/tools/testing/selftests/mm/gup_longterm.c +++ b/tools/testing/selftests/mm/gup_longterm.c @@ -504,7 +504,7 @@ static int tests_per_test_case(void) return 3 + nr_hugetlbsizes; } =20 -int main(int argc, char **argv) +int main(void) { int i; =20 diff --git a/tools/testing/selftests/mm/hugepage-vmemmap.c b/tools/testing/= selftests/mm/hugepage-vmemmap.c index df366a4d1b92d..23e97e552057d 100644 --- a/tools/testing/selftests/mm/hugepage-vmemmap.c +++ b/tools/testing/selftests/mm/hugepage-vmemmap.c @@ -87,7 +87,7 @@ static int check_page_flags(unsigned long pfn) return 0; } =20 -int main(int argc, char **argv) +int main(void) { void *addr; unsigned long pfn; diff --git a/tools/testing/selftests/mm/hugetlb-madvise.c b/tools/testing/s= elftests/mm/hugetlb-madvise.c index 1afe14b9dc0c3..27c8e46ae9b7d 100644 --- a/tools/testing/selftests/mm/hugetlb-madvise.c +++ b/tools/testing/selftests/mm/hugetlb-madvise.c @@ -55,7 +55,7 @@ void read_fault_pages(void *addr, unsigned long nr_pages) } } =20 -int main(int argc, char **argv) +int main(int __unused argc, char **argv) { unsigned long free_hugepages; void *addr, *addr2; diff --git a/tools/testing/selftests/mm/hugetlb-soft-offline.c b/tools/test= ing/selftests/mm/hugetlb-soft-offline.c index f086f0e04756f..cb087303f5ed3 100644 --- a/tools/testing/selftests/mm/hugetlb-soft-offline.c +++ b/tools/testing/selftests/mm/hugetlb-soft-offline.c @@ -216,7 +216,7 @@ static void test_soft_offline_common(int enable_soft_of= fline) enable_soft_offline); } =20 -int main(int argc, char **argv) +int main(void) { ksft_print_header(); ksft_set_plan(2); diff --git a/tools/testing/selftests/mm/madv_populate.c b/tools/testing/sel= ftests/mm/madv_populate.c index b6fabd5c27ed6..178e0ae0cd4a1 100644 --- a/tools/testing/selftests/mm/madv_populate.c +++ b/tools/testing/selftests/mm/madv_populate.c @@ -281,7 +281,7 @@ static int system_has_softdirty(void) #endif } =20 -int main(int argc, char **argv) +int main(void) { int nr_tests =3D 16; int err; diff --git a/tools/testing/selftests/mm/map_populate.c b/tools/testing/self= tests/mm/map_populate.c index 9df2636c829bf..2b240499f15c9 100644 --- a/tools/testing/selftests/mm/map_populate.c +++ b/tools/testing/selftests/mm/map_populate.c @@ -76,7 +76,7 @@ static int child_f(int sock, unsigned long *smap, int fd) return ksft_cnt.ksft_pass; } =20 -int main(int argc, char **argv) +int main(void) { int sock[2], child, ret; FILE *ftmp; diff --git a/tools/testing/selftests/mm/memfd_secret.c b/tools/testing/self= tests/mm/memfd_secret.c index 9a0597310a765..836383f63b630 100644 --- a/tools/testing/selftests/mm/memfd_secret.c +++ b/tools/testing/selftests/mm/memfd_secret.c @@ -299,7 +299,7 @@ static void prepare(void) =20 #define NUM_TESTS 6 =20 -int main(int argc, char *argv[]) +int main(void) { int fd; =20 diff --git a/tools/testing/selftests/mm/mlock-random-test.c b/tools/testing= /selftests/mm/mlock-random-test.c index b8d7e966f44c6..4ff7a4cfc7331 100644 --- a/tools/testing/selftests/mm/mlock-random-test.c +++ b/tools/testing/selftests/mm/mlock-random-test.c @@ -236,7 +236,7 @@ static void test_mlock_outof_limit(char *p, int alloc_s= ize) ksft_test_result_pass("%s\n", __func__); } =20 -int main(int argc, char **argv) +int main(void) { char *p =3D NULL; =20 diff --git a/tools/testing/selftests/mm/mlock2-tests.c b/tools/testing/self= tests/mm/mlock2-tests.c index 3e90ff37e336a..ce5fd5ce1f51f 100644 --- a/tools/testing/selftests/mm/mlock2-tests.c +++ b/tools/testing/selftests/mm/mlock2-tests.c @@ -425,7 +425,7 @@ static void test_mlockall(void) munlockall(); } =20 -int main(int argc, char **argv) +int main(void) { int ret, size =3D 3 * getpagesize(); void *map; diff --git a/tools/testing/selftests/mm/on-fault-limit.c b/tools/testing/se= lftests/mm/on-fault-limit.c index 431c1277d83a1..ade160966c926 100644 --- a/tools/testing/selftests/mm/on-fault-limit.c +++ b/tools/testing/selftests/mm/on-fault-limit.c @@ -28,7 +28,7 @@ static void test_limit(void) munlockall(); } =20 -int main(int argc, char **argv) +int main(void) { ksft_print_header(); ksft_set_plan(1); diff --git a/tools/testing/selftests/mm/pkey_sighandler_tests.c b/tools/tes= ting/selftests/mm/pkey_sighandler_tests.c index 302fef54049c8..eb4ef8532c0bf 100644 --- a/tools/testing/selftests/mm/pkey_sighandler_tests.c +++ b/tools/testing/selftests/mm/pkey_sighandler_tests.c @@ -528,7 +528,7 @@ static void (*pkey_tests[])(void) =3D { test_pkru_sigreturn }; =20 -int main(int argc, char *argv[]) +int main(void) { int i; =20 diff --git a/tools/testing/selftests/mm/soft-dirty.c b/tools/testing/selfte= sts/mm/soft-dirty.c index 8a3f2b4b21869..e62be4136f69e 100644 --- a/tools/testing/selftests/mm/soft-dirty.c +++ b/tools/testing/selftests/mm/soft-dirty.c @@ -194,7 +194,7 @@ static void test_mprotect_file(int pagemap_fd, int page= size) test_mprotect(pagemap_fd, pagesize, false); } =20 -int main(int argc, char **argv) +int main(void) { int pagemap_fd; int pagesize; diff --git a/tools/testing/selftests/mm/uffd-wp-mremap.c b/tools/testing/se= lftests/mm/uffd-wp-mremap.c index c2ba7d46c7b45..13ceb56289701 100644 --- a/tools/testing/selftests/mm/uffd-wp-mremap.c +++ b/tools/testing/selftests/mm/uffd-wp-mremap.c @@ -334,7 +334,7 @@ static const struct testcase testcases[] =3D { }, }; =20 -int main(int argc, char **argv) +int main(void) { struct thp_settings settings; int i, j, plan =3D 0; diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/tes= ting/selftests/mm/virtual_address_range.c index 169dbd692bf5f..3c21d136962cb 100644 --- a/tools/testing/selftests/mm/virtual_address_range.c +++ b/tools/testing/selftests/mm/virtual_address_range.c @@ -189,7 +189,7 @@ static int validate_complete_va_space(void) return 0; } =20 -int main(int argc, char *argv[]) +int main(void) { char *ptr[NR_CHUNKS_LOW]; char **hptr; --=20 2.39.5 From nobody Sun Oct 5 16:18:53 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78ADE2D0C73; Thu, 31 Jul 2025 16:04:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977846; cv=pass; b=Wd9nISVeSzXQVkqPhigBvFLa6lMwZh2oL4XvWuH4/Cm1Gc6Y5WYxQZWncUaGnNFsovlsfSR6G++NNRsakV8QYNgC2RZsctxUM3pHromoTduztBS5dQ4IPVqAE9uwR21sWd9EsXZk9o1nzCjlewY22HhPgUKnn1p3cNCc1oYjxZw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977846; c=relaxed/simple; bh=QsmWgAETqDpilPyzEhQmB2l84MDFnX4vYJHAE1MDUT8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NeqLwzEhPiz8bImLMs3gPf/VpYienp9jSFkGhgRGCSJ4cgzbr1b92GX7M48OAjXl2tXBms1YNy7YF9qP63fV/aknCfmG17RrbRY0YF5ZJVCRMlCQ5SDwppiPqN0YnV+9urz7QrCLm/Wnoko7yE8JmRe8ObboNEZ0ZX5hG9vnMm0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b=E6VahAaG; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b="E6VahAaG" ARC-Seal: i=1; a=rsa-sha256; t=1753977784; cv=none; d=zohomail.com; s=zohoarc; b=XFbIrRynXJTqh255w+Bcv63YcecInwcY/a8pr6RlBQOHb6UO3Zt7PspmhL/1dQePPhLiKW7fMIEpfklxYBt6U6g9/dj2T8u9PEW3/4ihGDit/eIwyAzOZlf9B+44EUbLr9LPVw/FYz8XZIXct/EFMpumfaF15wfGzOqaf2AppsQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753977784; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=IEdSZK7BVhWiUkrksFPbARcRG5+aotsZi9NQHzMPA1I=; b=i2s0Kv/1hGZC2uDof4YyK9x3ZHxOVOxNAXyg9SwCxXrUV9dVN6mYMPkcnCGEmIWSRR0vYHHoIyTlBwsOHp+O12kEdioIU5/+sfvyRIg8Px1Fn5qRSJ6kLFHoaYqWZ/MV4GzWYSWDs3NvitdXcj19OVxlZvkllDguzkjK6z+Zk34= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1753977784; s=zohomail; d=collabora.com; i=usama.anjum@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=IEdSZK7BVhWiUkrksFPbARcRG5+aotsZi9NQHzMPA1I=; b=E6VahAaGRGN23zw7DQhMgvi51C2eLOgNj/v1QFz/TsaA3iKZIhbPVBTjHL7Chews Mzef51zH9u8p8oKRuAqQ58ut1RqTMcpuO43eTZPKWtSBLcFK1enDkUpBu/nMYLiQUfK vZeV8oswMxQuPsYu1wtYpnckldEvWWN+lS1RbiT0= Received: by mx.zohomail.com with SMTPS id 1753977781741413.5702658287519; Thu, 31 Jul 2025 09:03:01 -0700 (PDT) From: Muhammad Usama Anjum To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, Shuah Khan Cc: Muhammad Usama Anjum , kernel@collabora.com Subject: [PATCH v2 5/8] selftests/mm: Remove unused parameters Date: Thu, 31 Jul 2025 21:01:29 +0500 Message-Id: <20250731160132.1795351-6-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250731160132.1795351-1-usama.anjum@collabora.com> References: <20250731160132.1795351-1-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Content-Type: text/plain; charset="utf-8" Cleanup code and remove the unused arguments Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/ksm_tests.c | 17 +++++++---------- tools/testing/selftests/mm/soft-dirty.c | 4 ++-- .../testing/selftests/mm/split_huge_page_test.c | 4 ++-- tools/testing/selftests/mm/uffd-common.c | 4 ++-- tools/testing/selftests/mm/uffd-common.h | 2 +- tools/testing/selftests/mm/uffd-stress.c | 2 +- tools/testing/selftests/mm/uffd-unit-tests.c | 8 ++++---- 7 files changed, 19 insertions(+), 22 deletions(-) diff --git a/tools/testing/selftests/mm/ksm_tests.c b/tools/testing/selftes= ts/mm/ksm_tests.c index b77462b5c240b..f5dabb513ed7f 100644 --- a/tools/testing/selftests/mm/ksm_tests.c +++ b/tools/testing/selftests/mm/ksm_tests.c @@ -238,8 +238,7 @@ static int ksm_merge_pages(int merge_type, void *addr, = size_t size, return 0; } =20 -static int ksm_unmerge_pages(void *addr, size_t size, - struct timespec start_time, int timeout) +static int ksm_unmerge_pages(void *addr, size_t size) { if (madvise(addr, size, MADV_UNMERGEABLE)) { perror("madvise"); @@ -456,7 +455,7 @@ static int get_first_mem_node(void) return get_next_mem_node(numa_max_node()); } =20 -static int check_ksm_numa_merge(int merge_type, int mapping, int prot, int= timeout, +static int check_ksm_numa_merge(int merge_type, int timeout, bool merge_across_nodes, size_t page_size) { void *numa1_map_ptr, *numa2_map_ptr; @@ -520,8 +519,7 @@ static int check_ksm_numa_merge(int merge_type, int map= ping, int prot, int timeo return KSFT_FAIL; } =20 -static int ksm_merge_hugepages_time(int merge_type, int mapping, int prot, - int timeout, size_t map_size) +static int ksm_merge_hugepages_time(int merge_type, int timeout, size_t ma= p_size) { void *map_ptr, *map_ptr_orig; struct timespec start_time, end_time; @@ -656,7 +654,7 @@ static int ksm_unmerge_time(int merge_type, int mapping= , int prot, int timeout, perror("clock_gettime"); goto err_out; } - if (ksm_unmerge_pages(map_ptr, map_size, start_time, timeout)) + if (ksm_unmerge_pages(map_ptr, map_size)) goto err_out; if (clock_gettime(CLOCK_MONOTONIC_RAW, &end_time)) { perror("clock_gettime"); @@ -884,8 +882,8 @@ int main(int argc, char *argv[]) page_size); break; case CHECK_KSM_NUMA_MERGE: - ret =3D check_ksm_numa_merge(merge_type, MAP_PRIVATE | MAP_ANONYMOUS, pr= ot, - ksm_scan_limit_sec, merge_across_nodes, page_size); + ret =3D check_ksm_numa_merge(merge_type, ksm_scan_limit_sec, merge_acros= s_nodes, + page_size); break; case KSM_MERGE_TIME: if (size_MB =3D=3D 0) { @@ -900,8 +898,7 @@ int main(int argc, char *argv[]) printf("Option '-s' is required.\n"); return KSFT_FAIL; } - ret =3D ksm_merge_hugepages_time(merge_type, MAP_PRIVATE | MAP_ANONYMOUS= , prot, - ksm_scan_limit_sec, size_MB); + ret =3D ksm_merge_hugepages_time(merge_type, ksm_scan_limit_sec, size_MB= ); break; case KSM_UNMERGE_TIME: if (size_MB =3D=3D 0) { diff --git a/tools/testing/selftests/mm/soft-dirty.c b/tools/testing/selfte= sts/mm/soft-dirty.c index e62be4136f69e..751fbc52857ea 100644 --- a/tools/testing/selftests/mm/soft-dirty.c +++ b/tools/testing/selftests/mm/soft-dirty.c @@ -76,7 +76,7 @@ static void test_vma_reuse(int pagemap_fd, int pagesize) munmap(map2, pagesize); } =20 -static void test_hugepage(int pagemap_fd, int pagesize) +static void test_hugepage(int pagemap_fd) { char *map; int i, ret; @@ -210,7 +210,7 @@ int main(void) =20 test_simple(pagemap_fd, pagesize); test_vma_reuse(pagemap_fd, pagesize); - test_hugepage(pagemap_fd, pagesize); + test_hugepage(pagemap_fd); test_mprotect_anon(pagemap_fd, pagesize); test_mprotect_file(pagemap_fd, pagesize); =20 diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/test= ing/selftests/mm/split_huge_page_test.c index a85b2e393e4e8..2c56ab2d220f7 100644 --- a/tools/testing/selftests/mm/split_huge_page_test.c +++ b/tools/testing/selftests/mm/split_huge_page_test.c @@ -106,7 +106,7 @@ static char *allocate_zero_filled_hugepage(size_t len) return result; } =20 -static void verify_rss_anon_split_huge_page_all_zeroes(char *one_page, int= nr_hpages, size_t len) +static void verify_rss_anon_split_huge_page_all_zeroes(char *one_page, siz= e_t len) { unsigned long rss_anon_before, rss_anon_after; size_t i; @@ -142,7 +142,7 @@ void split_pmd_zero_pages(void) size_t len =3D nr_hpages * pmd_pagesize; =20 one_page =3D allocate_zero_filled_hugepage(len); - verify_rss_anon_split_huge_page_all_zeroes(one_page, nr_hpages, len); + verify_rss_anon_split_huge_page_all_zeroes(one_page, len); ksft_test_result_pass("Split zero filled huge pages successful\n"); free(one_page); } diff --git a/tools/testing/selftests/mm/uffd-common.c b/tools/testing/selft= ests/mm/uffd-common.c index a37088a23ffef..815c22114b57e 100644 --- a/tools/testing/selftests/mm/uffd-common.c +++ b/tools/testing/selftests/mm/uffd-common.c @@ -416,7 +416,7 @@ static void continue_range(int ufd, __u64 start, __u64 = len, bool wp) ret, (int64_t) req.mapped); } =20 -int uffd_read_msg(int ufd, struct uffd_msg *msg) +int uffd_read_msg(struct uffd_msg *msg) { int ret =3D read(uffd, msg, sizeof(*msg)); =20 @@ -537,7 +537,7 @@ void *uffd_poll_thread(void *arg) } if (!(pollfd[0].revents & POLLIN)) err("pollfd[0].revents %d", pollfd[0].revents); - if (uffd_read_msg(uffd, &msg)) + if (uffd_read_msg(&msg)) continue; switch (msg.event) { default: diff --git a/tools/testing/selftests/mm/uffd-common.h b/tools/testing/selft= ests/mm/uffd-common.h index 7700cbfa39756..2e7066d69103d 100644 --- a/tools/testing/selftests/mm/uffd-common.h +++ b/tools/testing/selftests/mm/uffd-common.h @@ -117,7 +117,7 @@ void uffd_stats_report(struct uffd_args *args, int n_cp= us); int uffd_test_ctx_init(uint64_t features, const char **errmsg); void uffd_test_ctx_clear(void); int userfaultfd_open(uint64_t *features); -int uffd_read_msg(int ufd, struct uffd_msg *msg); +int uffd_read_msg(struct uffd_msg *msg); void wp_range(int ufd, __u64 start, __u64 len, bool wp); void uffd_handle_page_fault(struct uffd_msg *msg, struct uffd_args *args); int __copy_page(int ufd, unsigned long offset, bool retry, bool wp); diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selft= ests/mm/uffd-stress.c index 40af7f67c4074..4a615ab0c0506 100644 --- a/tools/testing/selftests/mm/uffd-stress.c +++ b/tools/testing/selftests/mm/uffd-stress.c @@ -137,7 +137,7 @@ static void *uffd_read_thread(void *arg) /* from here cancellation is ok */ =20 for (;;) { - if (uffd_read_msg(uffd, &msg)) + if (uffd_read_msg(&msg)) continue; uffd_handle_page_fault(&msg, args); } diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/s= elftests/mm/uffd-unit-tests.c index 50501b38e34e7..df7b82bbebaad 100644 --- a/tools/testing/selftests/mm/uffd-unit-tests.c +++ b/tools/testing/selftests/mm/uffd-unit-tests.c @@ -248,7 +248,7 @@ static void *fork_event_consumer(void *data) ready_for_fork =3D true; =20 /* Read until a full msg received */ - while (uffd_read_msg(args->parent_uffd, &msg)); + while (uffd_read_msg(&msg)); =20 if (msg.event !=3D UFFD_EVENT_FORK) err("wrong message: %u\n", msg.event); @@ -1352,11 +1352,11 @@ static void *uffd_mmap_changing_thread(void *opaque) return NULL; } =20 -static void uffd_consume_message(int fd) +static void uffd_consume_message(void) { struct uffd_msg msg =3D { 0 }; =20 - while (uffd_read_msg(fd, &msg)); + while (uffd_read_msg(&msg)); } =20 static void uffd_mmap_changing_test(uffd_test_args_t *targs) @@ -1407,7 +1407,7 @@ static void uffd_mmap_changing_test(uffd_test_args_t = *targs) * All succeeded above! Recycle everything. Start by reading the * event so as to kick the thread roll again.. */ - uffd_consume_message(uffd); + uffd_consume_message(); =20 ret =3D pthread_join(tid, NULL); assert(ret =3D=3D 0); --=20 2.39.5 From nobody Sun Oct 5 16:18:53 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC79923E32D; Thu, 31 Jul 2025 16:03:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977839; cv=pass; b=EE0DgAsH5clCdd5+o4Mkuj/wGwpaT4G8uWF2v/H+8LvgyaQCyRro07QOVoFenWCOSMYZID45mK/5RNFnnKGjBPZZjGVoOGuNVgOUhT1z3U9iki5RHEXY30rWrj3835/tdQBdf1As9JWFqUS0F7ugXQKSNm08uzzpNnJzH1AL0+w= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977839; c=relaxed/simple; bh=NSmhUbRXEzv8wHvUHxDjDs2GaeGlKxdpWVaIwtS0TaU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gbdqmGpdezyPQW6j6wdGK5PNgAP87O2plKPhergqnNQmCOjE8kmzPLCehL0mk/ZmmADVinyy3dx61vMReh5EdSK7wggTZUETGCULSvtG0BDATw1+yncZIU84+vjYMdiw3XCjT1bWKrGKI9yrQkPk91V3SuStHqpYKsasWI+ajsA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b=V1k0vjni; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b="V1k0vjni" ARC-Seal: i=1; a=rsa-sha256; t=1753977794; cv=none; d=zohomail.com; s=zohoarc; b=Ujx1sK3b6FE3Nv5iXi/XMjJN0rJKpEI2qZhFgCzaPXeZaOEBjr0scNP5O7REcClbw7JIWr6jxxS14GCWnRpdWhBExi2yeNBxOyPDyOpeuuHtBhBtgEqMRrMm40xXXiO4t4k91hTnyq8RaCJRgA8+6nRHlt33XTFtXXTPcSb0NaA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753977794; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=KX4em/GE5ltQsdxfmeYM80ZyMjqjVqVuT5GM9bbxR8w=; b=ASUPeMhliOTGc6KBnq2r+VopbrALlz2QbDdk/36fE/s8XXtnuXktb6zUsiKqvPTr+zbPC0qszS7zd3Qdn0dEVBbzo0DOtmtNPO1RiVg1z/GyfjgJNyZy9CprC42KDbroRzN2EMJIcLqc2n2+S6Mhss7DkezJfckTX9v4nmoh3vQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1753977794; s=zohomail; d=collabora.com; i=usama.anjum@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=KX4em/GE5ltQsdxfmeYM80ZyMjqjVqVuT5GM9bbxR8w=; b=V1k0vjnih4FE/4EHG7hKwlzRHwUZHhD0ya3pC+Fb1V1vSXc37HlH2zp4x4jq5ypf j6dnv8jctjcMjyUk6rVwkfaP3+KY6+fz1TZtRUEmX4Va2o7RqiB3MVOQDesN5RaI9GM n/Vzk90/ibwDMYmnr3XyqEGzqtg8UZOVaJMZVb4Q= Received: by mx.zohomail.com with SMTPS id 1753977792702357.38842988413626; Thu, 31 Jul 2025 09:03:12 -0700 (PDT) From: Muhammad Usama Anjum To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, Shuah Khan Cc: Muhammad Usama Anjum , kernel@collabora.com Subject: [PATCH v2 6/8] selftests/mm: Mark unused arguments with __unused Date: Thu, 31 Jul 2025 21:01:30 +0500 Message-Id: <20250731160132.1795351-7-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250731160132.1795351-1-usama.anjum@collabora.com> References: <20250731160132.1795351-1-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Content-Type: text/plain; charset="utf-8" Mark the arguments which cannot be removed with __unused attribute. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/cow.c | 20 ++++++------- tools/testing/selftests/mm/memfd_secret.c | 4 +-- tools/testing/selftests/mm/pfnmap.c | 2 +- tools/testing/selftests/mm/uffd-common.c | 11 +++---- tools/testing/selftests/mm/uffd-unit-tests.c | 30 ++++++++++---------- 5 files changed, 34 insertions(+), 33 deletions(-) diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/= cow.c index eb1ccf067b633..6f6c4e85240c7 100644 --- a/tools/testing/selftests/mm/cow.c +++ b/tools/testing/selftests/mm/cow.c @@ -253,12 +253,12 @@ static void do_test_cow_in_parent(char *mem, size_t s= ize, bool do_mprotect, close_comm_pipes(&comm_pipes); } =20 -static void test_cow_in_parent(char *mem, size_t size, bool is_hugetlb) +static void test_cow_in_parent(char *mem, size_t size, bool __unused is_hu= getlb) { do_test_cow_in_parent(mem, size, false, child_memcmp_fn, false); } =20 -static void test_cow_in_parent_mprotect(char *mem, size_t size, bool is_hu= getlb) +static void test_cow_in_parent_mprotect(char *mem, size_t size, bool __unu= sed is_hugetlb) { do_test_cow_in_parent(mem, size, true, child_memcmp_fn, false); } @@ -734,36 +734,36 @@ static void do_test_ro_pin(char *mem, size_t size, en= um ro_pin_test test, free(tmp); } =20 -static void test_ro_pin_on_shared(char *mem, size_t size, bool is_hugetlb) +static void test_ro_pin_on_shared(char *mem, size_t size, bool __unused is= _hugetlb) { do_test_ro_pin(mem, size, RO_PIN_TEST_SHARED, false); } =20 -static void test_ro_fast_pin_on_shared(char *mem, size_t size, bool is_hug= etlb) +static void test_ro_fast_pin_on_shared(char *mem, size_t size, bool __unus= ed is_hugetlb) { do_test_ro_pin(mem, size, RO_PIN_TEST_SHARED, true); } =20 static void test_ro_pin_on_ro_previously_shared(char *mem, size_t size, - bool is_hugetlb) + bool __unused is_hugetlb) { do_test_ro_pin(mem, size, RO_PIN_TEST_PREVIOUSLY_SHARED, false); } =20 static void test_ro_fast_pin_on_ro_previously_shared(char *mem, size_t siz= e, - bool is_hugetlb) + bool __unused is_hugetlb) { do_test_ro_pin(mem, size, RO_PIN_TEST_PREVIOUSLY_SHARED, true); } =20 static void test_ro_pin_on_ro_exclusive(char *mem, size_t size, - bool is_hugetlb) + bool __unused is_hugetlb) { do_test_ro_pin(mem, size, RO_PIN_TEST_RO_EXCLUSIVE, false); } =20 static void test_ro_fast_pin_on_ro_exclusive(char *mem, size_t size, - bool is_hugetlb) + bool __unused is_hugetlb) { do_test_ro_pin(mem, size, RO_PIN_TEST_RO_EXCLUSIVE, true); } @@ -1522,12 +1522,12 @@ static void test_cow(char *mem, const char *smem, s= ize_t size) free(old); } =20 -static void test_ro_pin(char *mem, const char *smem, size_t size) +static void test_ro_pin(char *mem, const char __unused *smem, size_t size) { do_test_ro_pin(mem, size, RO_PIN_TEST, false); } =20 -static void test_ro_fast_pin(char *mem, const char *smem, size_t size) +static void test_ro_fast_pin(char *mem, const char __unused *smem, size_t = size) { do_test_ro_pin(mem, size, RO_PIN_TEST, true); } diff --git a/tools/testing/selftests/mm/memfd_secret.c b/tools/testing/self= tests/mm/memfd_secret.c index 836383f63b630..7117cc0f56dbb 100644 --- a/tools/testing/selftests/mm/memfd_secret.c +++ b/tools/testing/selftests/mm/memfd_secret.c @@ -123,7 +123,7 @@ static void test_vmsplice(int fd, const char *desc) close(pipefd[1]); } =20 -static void try_process_vm_read(int fd, int pipefd[2]) +static void try_process_vm_read(int __unused fd, int pipefd[2]) { struct iovec liov, riov; char buf[64]; @@ -147,7 +147,7 @@ static void try_process_vm_read(int fd, int pipefd[2]) exit(KSFT_FAIL); } =20 -static void try_ptrace(int fd, int pipefd[2]) +static void try_ptrace(int __unused fd, int pipefd[2]) { pid_t ppid =3D getppid(); int status; diff --git a/tools/testing/selftests/mm/pfnmap.c b/tools/testing/selftests/= mm/pfnmap.c index 866ac023baf5c..54c9af20d312e 100644 --- a/tools/testing/selftests/mm/pfnmap.c +++ b/tools/testing/selftests/mm/pfnmap.c @@ -26,7 +26,7 @@ =20 static sigjmp_buf sigjmp_buf_env; =20 -static void signal_handler(int sig) +static void signal_handler(int __unused sig) { siglongjmp(sigjmp_buf_env, -EFAULT); } diff --git a/tools/testing/selftests/mm/uffd-common.c b/tools/testing/selft= ests/mm/uffd-common.c index 815c22114b57e..e309ec886fa72 100644 --- a/tools/testing/selftests/mm/uffd-common.c +++ b/tools/testing/selftests/mm/uffd-common.c @@ -46,7 +46,7 @@ static void anon_release_pages(char *rel_area) err("madvise(MADV_DONTNEED) failed"); } =20 -static int anon_allocate_area(void **alloc_area, bool is_src) +static int anon_allocate_area(void **alloc_area, bool __unused is_src) { *alloc_area =3D mmap(NULL, nr_pages * page_size, PROT_READ | PROT_WRITE, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0); @@ -57,7 +57,8 @@ static int anon_allocate_area(void **alloc_area, bool is_= src) return 0; } =20 -static void noop_alias_mapping(__u64 *start, size_t len, unsigned long off= set) +static void noop_alias_mapping(__u64 __unused *start, size_t __unused len, + unsigned long __unused offset) { } =20 @@ -108,7 +109,7 @@ static int hugetlb_allocate_area(void **alloc_area, boo= l is_src) return 0; } =20 -static void hugetlb_alias_mapping(__u64 *start, size_t len, unsigned long = offset) +static void hugetlb_alias_mapping(__u64 *start, size_t __unused len, unsig= ned long offset) { if (!map_shared) return; @@ -167,12 +168,12 @@ static int shmem_allocate_area(void **alloc_area, boo= l is_src) return 0; } =20 -static void shmem_alias_mapping(__u64 *start, size_t len, unsigned long of= fset) +static void shmem_alias_mapping(__u64 *start, size_t __unused len, unsigne= d long offset) { *start =3D (unsigned long)area_dst_alias + offset; } =20 -static void shmem_check_pmd_mapping(void *p, int expect_nr_hpages) +static void shmem_check_pmd_mapping(void __unused *p, int expect_nr_hpages) { if (!check_huge_shmem(area_dst_alias, expect_nr_hpages, read_pmd_pagesize())) diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/s= elftests/mm/uffd-unit-tests.c index df7b82bbebaad..ee9b407e893e1 100644 --- a/tools/testing/selftests/mm/uffd-unit-tests.c +++ b/tools/testing/selftests/mm/uffd-unit-tests.c @@ -361,7 +361,7 @@ static int pagemap_test_fork(int uffd, bool with_event,= bool test_pin) return result; } =20 -static void uffd_wp_unpopulated_test(uffd_test_args_t *args) +static void uffd_wp_unpopulated_test(uffd_test_args_t __unused *args) { uint64_t value; int pagemap_fd; @@ -487,7 +487,7 @@ static void uffd_wp_fork_with_event_test(uffd_test_args= _t *args) uffd_wp_fork_test_common(args, true); } =20 -static void uffd_wp_fork_pin_test_common(uffd_test_args_t *args, +static void uffd_wp_fork_pin_test_common(uffd_test_args_t __unused *args, bool with_event) { int pagemap_fd; @@ -631,24 +631,24 @@ static void uffd_minor_test_common(bool test_collapse= , bool test_wp) uffd_test_pass(); } =20 -void uffd_minor_test(uffd_test_args_t *args) +void uffd_minor_test(uffd_test_args_t __unused *args) { uffd_minor_test_common(false, false); } =20 -void uffd_minor_wp_test(uffd_test_args_t *args) +void uffd_minor_wp_test(uffd_test_args_t __unused *args) { uffd_minor_test_common(false, true); } =20 -void uffd_minor_collapse_test(uffd_test_args_t *args) +void uffd_minor_collapse_test(uffd_test_args_t __unused *args) { uffd_minor_test_common(true, false); } =20 static sigjmp_buf jbuf, *sigbuf; =20 -static void sighndl(int sig, siginfo_t *siginfo, void *ptr) +static void sighndl(int sig, siginfo_t __unused *siginfo, void __unused *p= tr) { if (sig =3D=3D SIGBUS) { if (sigbuf) @@ -824,12 +824,12 @@ static void uffd_sigbus_test_common(bool wp) uffd_test_pass(); } =20 -static void uffd_sigbus_test(uffd_test_args_t *args) +static void uffd_sigbus_test(uffd_test_args_t __unused *args) { uffd_sigbus_test_common(false); } =20 -static void uffd_sigbus_wp_test(uffd_test_args_t *args) +static void uffd_sigbus_wp_test(uffd_test_args_t __unused *args) { uffd_sigbus_test_common(true); } @@ -877,12 +877,12 @@ static void uffd_events_test_common(bool wp) uffd_test_pass(); } =20 -static void uffd_events_test(uffd_test_args_t *args) +static void uffd_events_test(uffd_test_args_t __unused *args) { uffd_events_test_common(false); } =20 -static void uffd_events_wp_test(uffd_test_args_t *args) +static void uffd_events_wp_test(uffd_test_args_t __unused *args) { uffd_events_test_common(true); } @@ -950,7 +950,7 @@ uffd_register_detect_zeropage(int uffd, void *addr, uin= t64_t len) } =20 /* exercise UFFDIO_ZEROPAGE */ -static void uffd_zeropage_test(uffd_test_args_t *args) +static void uffd_zeropage_test(uffd_test_args_t __unused *args) { bool has_zeropage; int i; @@ -1006,7 +1006,7 @@ static void do_uffdio_poison(int uffd, unsigned long = offset) } =20 static void uffd_poison_handle_fault( - struct uffd_msg *msg, struct uffd_args *args) + struct uffd_msg *msg, struct uffd_args __unused *args) { unsigned long offset; =20 @@ -1030,7 +1030,7 @@ static void uffd_poison_handle_fault( /* Make sure to cover odd/even, and minimum duplications */ #define UFFD_POISON_TEST_NPAGES 4 =20 -static void uffd_poison_test(uffd_test_args_t *targs) +static void uffd_poison_test(uffd_test_args_t __unused *targs) { pthread_t uffd_mon; char c; @@ -1126,7 +1126,7 @@ static void uffd_move_pmd_handle_fault(struct uffd_ms= g *msg, } =20 static void -uffd_move_test_common(uffd_test_args_t *targs, unsigned long chunk_size, +uffd_move_test_common(uffd_test_args_t __unused *targs, unsigned long chun= k_size, void (*handle_fault)(struct uffd_msg *msg, struct uffd_args *args)) { unsigned long nr; @@ -1359,7 +1359,7 @@ static void uffd_consume_message(void) while (uffd_read_msg(&msg)); } =20 -static void uffd_mmap_changing_test(uffd_test_args_t *targs) +static void uffd_mmap_changing_test(uffd_test_args_t __unused *targs) { /* * This stores the real PID (which can be different from how tid is --=20 2.39.5 From nobody Sun Oct 5 16:18:53 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A6AB21A433; Thu, 31 Jul 2025 16:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977875; cv=pass; b=nSch5w5GTIGOCaFeKTU3tWb2O8LF0+8BiFQMqqEyvB4OBD6b972Zbqwq291ioW08TXayU0phbSCUqkCw1TmSR8+x8HsHw/4PVVg8N9hWnj6NvQUR5xfGFqjYnOc3Qi1LsqEcJl/GisrPDpdl7GooyRTzMSE1Y1tSlT16bQh+Y28= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977875; c=relaxed/simple; bh=rDE35WD/p2ISgW7zmnXIHagSrBoe1ctbfV1udH+1lk4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X7iwnPhS9VyZO/zzVlqgZ/ujO7Qco/2iwqH8K/Ko28498ZjUe8bWZbDoYKhK1AS2Q8KwJCv2ULuNeBB4WWl8JTCS9EaBHDMuds7dUXZv6BqtLTXCdUp0Y7x+wsTWyByQNuQQof8XbioMTQf7yg46D0qgrjbsA+WJiETz0AtU9vM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b=XTlO2Afh; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b="XTlO2Afh" ARC-Seal: i=1; a=rsa-sha256; t=1753977804; cv=none; d=zohomail.com; s=zohoarc; b=iEVfjkrhIlNGAugbgFyCabDELVet8GzqTY2X6nWM90rubx0LHgFlnh6/IohJGrywKzD8VKMl/eXABP/+cUP1q3imNAwURRm6jAD3NkwpZn53TWIuO7b1+dh23V2P+K3nxYE1rXOrIBQD9DK/V2jsbTX5J7b6wFebmCZBrz+bYxE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753977804; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=nNsfnv5oOEoHrVu8M1Ul0UCXOUQx26YVPJa+Wwgspps=; b=cz37pqdSHlICiZWOPkv6Gy+lqmKdFmOvcy3i7ESUm4jWnfebkMT9ajcGt8HxnvpXbnnlfxzgrQyls0vYbT4cujWpiZLa0zEk1bK07/blkK++6WN3TgxftRDAKQNvcZfpqKJbdQYSGmLSob1tm3mw46U9WAQc3BkxFtA1M6sVDSg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1753977804; s=zohomail; d=collabora.com; i=usama.anjum@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=nNsfnv5oOEoHrVu8M1Ul0UCXOUQx26YVPJa+Wwgspps=; b=XTlO2AfhdGBuUf01q109R44FA2Ye3p1dZraw5yjGh/xsp6aWi43kSFycH9CpGIw8 SKuV5dyfAL9vvs1ffJHq4uPgaNxrj8OG1G2lZ3c3kn1rmchCIHjQcC9QOWsFcoiDUhP eO3qd+etbhxquw7LjvNK+rJ3TXTN21JvijGgJO24= Received: by mx.zohomail.com with SMTPS id 1753977802350358.12218677283863; Thu, 31 Jul 2025 09:03:22 -0700 (PDT) From: Muhammad Usama Anjum To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, Shuah Khan Cc: Muhammad Usama Anjum , kernel@collabora.com Subject: [PATCH v2 7/8] selftests/mm: Mark unused arguments with __unused Date: Thu, 31 Jul 2025 21:01:31 +0500 Message-Id: <20250731160132.1795351-8-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250731160132.1795351-1-usama.anjum@collabora.com> References: <20250731160132.1795351-1-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Content-Type: text/plain; charset="utf-8" Mark the arguments which cannot be removed with __unused attribute. Signed-off-by: Muhammad Usama Anjum --- .../selftests/mm/hugetlb_fault_after_madv.c | 4 ++-- .../testing/selftests/mm/hugetlb_madv_vs_map.c | 6 +++--- tools/testing/selftests/mm/pkey-arm64.h | 5 +++-- tools/testing/selftests/mm/pkey-powerpc.h | 2 +- tools/testing/selftests/mm/pkey-x86.h | 3 ++- .../selftests/mm/pkey_sighandler_tests.c | 10 +++++----- tools/testing/selftests/mm/protection_keys.c | 18 +++++++++--------- 7 files changed, 25 insertions(+), 23 deletions(-) diff --git a/tools/testing/selftests/mm/hugetlb_fault_after_madv.c b/tools/= testing/selftests/mm/hugetlb_fault_after_madv.c index e2640529dbb29..72706c64fe57c 100644 --- a/tools/testing/selftests/mm/hugetlb_fault_after_madv.c +++ b/tools/testing/selftests/mm/hugetlb_fault_after_madv.c @@ -28,7 +28,7 @@ static void signal_handler(int signal) } =20 /* Touch the memory while it is being madvised() */ -void *touch(void *unused) +void *touch(void __unused *unused) { char *ptr =3D (char *)huge_ptr; =20 @@ -41,7 +41,7 @@ void *touch(void *unused) return NULL; } =20 -void *madv(void *unused) +void *madv(void __unused *unused) { usleep(rand() % 10); =20 diff --git a/tools/testing/selftests/mm/hugetlb_madv_vs_map.c b/tools/testi= ng/selftests/mm/hugetlb_madv_vs_map.c index 8f122a0f08281..64a1455940394 100644 --- a/tools/testing/selftests/mm/hugetlb_madv_vs_map.c +++ b/tools/testing/selftests/mm/hugetlb_madv_vs_map.c @@ -33,7 +33,7 @@ size_t mmap_size; char *huge_ptr; =20 /* Touch the memory while it is being madvised() */ -void *touch(void *unused) +void *touch(void __unused *unused) { for (int i =3D 0; i < INLOOP_ITER; i++) huge_ptr[0] =3D '.'; @@ -41,7 +41,7 @@ void *touch(void *unused) return NULL; } =20 -void *madv(void *unused) +void *madv(void __unused *unused) { for (int i =3D 0; i < INLOOP_ITER; i++) madvise(huge_ptr, mmap_size, MADV_DONTNEED); @@ -54,7 +54,7 @@ void *madv(void *unused) * The other hugepage should be flipping from used <-> reserved, because * of madvise(DONTNEED). */ -void *map_extra(void *unused) +void *map_extra(void __unused *unused) { void *ptr; =20 diff --git a/tools/testing/selftests/mm/pkey-arm64.h b/tools/testing/selfte= sts/mm/pkey-arm64.h index 8e9685e03c441..a9cacf3732f60 100644 --- a/tools/testing/selftests/mm/pkey-arm64.h +++ b/tools/testing/selftests/mm/pkey-arm64.h @@ -81,11 +81,12 @@ static inline int get_arch_reserved_keys(void) return NR_RESERVED_PKEYS; } =20 -static inline void expect_fault_on_read_execonly_key(void *p1, int pkey) +static inline void expect_fault_on_read_execonly_key(void __unused *p1, in= t __unused pkey) { } =20 -static inline void *malloc_pkey_with_mprotect_subpage(long size, int prot,= u16 pkey) +static inline void *malloc_pkey_with_mprotect_subpage(long __unused size, = int __unused prot, + u16 __unused pkey) { return PTR_ERR_ENOTSUP; } diff --git a/tools/testing/selftests/mm/pkey-powerpc.h b/tools/testing/self= tests/mm/pkey-powerpc.h index 17bf2d1b0192e..8a367c32a9dd6 100644 --- a/tools/testing/selftests/mm/pkey-powerpc.h +++ b/tools/testing/selftests/mm/pkey-powerpc.h @@ -93,7 +93,7 @@ static inline int get_arch_reserved_keys(void) return NR_RESERVED_PKEYS_64K_3KEYS; } =20 -static inline void expect_fault_on_read_execonly_key(void *p1, int pkey) +static inline void expect_fault_on_read_execonly_key(void __unused *p1, in= t __unused pkey) { /* * powerpc does not allow userspace to change permissions of exec-only diff --git a/tools/testing/selftests/mm/pkey-x86.h b/tools/testing/selftest= s/mm/pkey-x86.h index f7ecd335df1e6..27688c04abd35 100644 --- a/tools/testing/selftests/mm/pkey-x86.h +++ b/tools/testing/selftests/mm/pkey-x86.h @@ -157,7 +157,8 @@ static inline void expect_fault_on_read_execonly_key(vo= id *p1, int pkey) expected_pkey_fault(pkey); } =20 -static inline void *malloc_pkey_with_mprotect_subpage(long size, int prot,= u16 pkey) +static inline void *malloc_pkey_with_mprotect_subpage(long __unused size, = int __unused prot, + u16 __unused pkey) { return PTR_ERR_ENOTSUP; } diff --git a/tools/testing/selftests/mm/pkey_sighandler_tests.c b/tools/tes= ting/selftests/mm/pkey_sighandler_tests.c index eb4ef8532c0bf..638477494ff3a 100644 --- a/tools/testing/selftests/mm/pkey_sighandler_tests.c +++ b/tools/testing/selftests/mm/pkey_sighandler_tests.c @@ -110,7 +110,7 @@ static inline u64 pkey_reg_restrictive_default(void) return set_pkey_bits(PKEY_REG_ALLOW_NONE, 0, PKEY_DISABLE_ACCESS); } =20 -static void sigsegv_handler(int signo, siginfo_t *info, void *ucontext) +static void sigsegv_handler(int __unused signo, siginfo_t *info, void __un= used *ucontext) { pthread_mutex_lock(&mutex); =20 @@ -122,7 +122,7 @@ static void sigsegv_handler(int signo, siginfo_t *info,= void *ucontext) syscall_raw(SYS_exit, 0, 0, 0, 0, 0, 0); } =20 -static void sigusr1_handler(int signo, siginfo_t *info, void *ucontext) +static void sigusr1_handler(int __unused signo, siginfo_t *info, void __un= used *ucontext) { pthread_mutex_lock(&mutex); =20 @@ -132,7 +132,7 @@ static void sigusr1_handler(int signo, siginfo_t *info,= void *ucontext) pthread_mutex_unlock(&mutex); } =20 -static void sigusr2_handler(int signo, siginfo_t *info, void *ucontext) +static void sigusr2_handler(int __unused signo, siginfo_t __unused *info, = void __unused *ucontext) { /* * pkru should be the init_pkru value which enabled MPK 0 so @@ -155,7 +155,7 @@ static void raise_sigusr2(void) */ } =20 -static void *thread_segv_with_pkey0_disabled(void *ptr) +static void *thread_segv_with_pkey0_disabled(void __unused *ptr) { /* Disable MPK 0 (and all others too) */ __write_pkey_reg(pkey_reg_restrictive_default()); @@ -165,7 +165,7 @@ static void *thread_segv_with_pkey0_disabled(void *ptr) return NULL; } =20 -static void *thread_segv_pkuerr_stack(void *ptr) +static void *thread_segv_pkuerr_stack(void __unused *ptr) { /* Disable MPK 0 (and all others too) */ __write_pkey_reg(pkey_reg_restrictive_default()); diff --git a/tools/testing/selftests/mm/protection_keys.c b/tools/testing/s= elftests/mm/protection_keys.c index 6281d4c61b50e..65bc9ba59f72b 100644 --- a/tools/testing/selftests/mm/protection_keys.c +++ b/tools/testing/selftests/mm/protection_keys.c @@ -309,7 +309,7 @@ static char *si_code_str(int si_code) =20 static int pkey_faults; static int last_si_pkey =3D -1; -static void signal_handler(int signum, siginfo_t *si, void *vucontext) +static void signal_handler(int __unused signum, siginfo_t *si, void *vucon= text) { ucontext_t *uctxt =3D vucontext; int trapno; @@ -889,7 +889,7 @@ static void close_test_fds(void) nr_test_fds =3D 0; } =20 -static void test_pkey_alloc_free_attach_pkey0(int *ptr, u16 pkey) +static void test_pkey_alloc_free_attach_pkey0(int *ptr, u16 __unused pkey) { int i, err; int max_nr_pkey_allocs; @@ -1106,7 +1106,7 @@ static void test_pkey_syscalls_on_non_allocated_pkey(= int *ptr, u16 pkey) } =20 /* Assumes that all pkeys other than 'pkey' are unallocated */ -static void test_pkey_syscalls_bad_args(int *ptr, u16 pkey) +static void test_pkey_syscalls_bad_args(int *ptr, u16 __unused pkey) { int err; int bad_pkey =3D NR_PKEYS+99; @@ -1132,7 +1132,7 @@ static void become_child(void) } =20 /* Assumes that all pkeys other than 'pkey' are unallocated */ -static void test_pkey_alloc_exhaust(int *ptr, u16 pkey) +static void test_pkey_alloc_exhaust(int __unused *ptr, u16 __unused pkey) { int err; int allocated_pkeys[NR_PKEYS] =3D {0}; @@ -1238,7 +1238,7 @@ static void arch_force_pkey_reg_init(void) * a long-running test that continually checks the pkey * register. */ -static void test_pkey_init_state(int *ptr, u16 pkey) +static void test_pkey_init_state(int __unused *ptr, u16 __unused pkey) { int err; int allocated_pkeys[NR_PKEYS] =3D {0}; @@ -1397,7 +1397,7 @@ static void *get_pointer_to_instructions(void) return p1; } =20 -static void test_executing_on_unreadable_memory(int *ptr, u16 pkey) +static void test_executing_on_unreadable_memory(int __unused *ptr, u16 pke= y) { void *p1; int scratch; @@ -1429,7 +1429,7 @@ static void test_executing_on_unreadable_memory(int *= ptr, u16 pkey) pkey_assert(!ret); } =20 -static void test_implicit_mprotect_exec_only_memory(int *ptr, u16 pkey) +static void test_implicit_mprotect_exec_only_memory(int __unused *ptr, u16= __unused pkey) { void *p1; int scratch; @@ -1478,7 +1478,7 @@ static void test_implicit_mprotect_exec_only_memory(i= nt *ptr, u16 pkey) } =20 #if defined(__i386__) || defined(__x86_64__) -static void test_ptrace_modifies_pkru(int *ptr, u16 pkey) +static void test_ptrace_modifies_pkru(int __unused *ptr, u16 __unused pkey) { u32 new_pkru; pid_t child; @@ -1601,7 +1601,7 @@ static void test_ptrace_modifies_pkru(int *ptr, u16 p= key) #endif =20 #if defined(__aarch64__) -static void test_ptrace_modifies_pkru(int *ptr, u16 pkey) +static void test_ptrace_modifies_pkru(int __unused *ptr, u16 __unused pkey) { pid_t child; int status, ret; --=20 2.39.5 From nobody Sun Oct 5 16:18:53 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A709225A31; Thu, 31 Jul 2025 16:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977874; cv=pass; b=aR/QaMstSrC0H/UF1443aYUs6fR7Pz6YY3gcz4Ky4WUcAQitptkuecVUotdvrwuMEXmiGSpXEXEn9fXF7UyannYK0wmIvuFqIL51S6lFCmsO8OOZqACYC9gtEkc/5xhl8KNnKPdSxkufUWmJ1xTVGVaT0L5Ua2er/vmeOuVAsRk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753977874; c=relaxed/simple; bh=kjyVBPPWZXNPZboO3U/NQv0/5EXCIDDQsIa51EhFW/8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oIbvMdBda/Bc2Ept5Z4L0LDxQ4X3//3Xkkm8keqZNB+br0dPSd3J2S5ysFJ1rDm+LWmVDH3/7Ji1Bvv3nGVd3uwl3BO718Kw6bX386BejaPcetFXr3zdxXdE1Nusc3Z263YMxt4FCBybSsC4I9KsyHbC0qcBkNOv3I+IJrToIzg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b=ZsmT9zUa; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=usama.anjum@collabora.com header.b="ZsmT9zUa" ARC-Seal: i=1; a=rsa-sha256; t=1753977814; cv=none; d=zohomail.com; s=zohoarc; b=C8v46k7DZVPWHrtdnDxx+B1H9e3oTQQKoEUlihOcuoykiizMGZ2DuqpH3we2WhGi7B06TVkV+KxBAn0Bf8Fj+ir6MoKr2VVwLoP0nh4MQoHE+4wSRmwlYaf0FZdGEAkWIks+x82voM8CpPcilzent9OSDf09xaBaOLXtx8D/AaE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753977814; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=tFRUod1LETsg74Qkt/8QptMDoryWw/7mPsDdQJpyJMA=; b=MSsRQc1CLGXH5lgzPf8W7exC2qpS0QWtdYvRRMzl9SAI2NYNP7n03MbgtFNyauldv7AD4ZhneCPEuAmAvo3lzb/I1Ffxzwq0uT+wJ5a8oWEPLS//I6jfg4xDJ8NndXxRJZMWZNjzy1uUcAzKeTW/2BeUuoVk97WBXCZBImcLqk8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1753977814; s=zohomail; d=collabora.com; i=usama.anjum@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=tFRUod1LETsg74Qkt/8QptMDoryWw/7mPsDdQJpyJMA=; b=ZsmT9zUa5eWfbbvDyMVVzPqiFsPJdSkNGak9DUUGi7MDW7luOQuACxcj91V2ZB10 mcRtFG1ppOtRtNPjOd2+lfUbSqHSBT6vuXujVItCwKkDrSEy3NuoVgBpcfSL8v/ncVG HfPcQj2c8TIlbrD+kWPj1ezLf3vtU13lfwmTy0hg= Received: by mx.zohomail.com with SMTPS id 1753977811994182.64658106567913; Thu, 31 Jul 2025 09:03:31 -0700 (PDT) From: Muhammad Usama Anjum To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jason Gunthorpe , John Hubbard , Peter Xu , Leon Romanovsky , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, Shuah Khan Cc: Muhammad Usama Anjum , kernel@collabora.com Subject: [PATCH v2 8/8] selftests/mm: Fix unused parameter warnings for different architectures Date: Thu, 31 Jul 2025 21:01:32 +0500 Message-Id: <20250731160132.1795351-9-usama.anjum@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250731160132.1795351-1-usama.anjum@collabora.com> References: <20250731160132.1795351-1-usama.anjum@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Content-Type: text/plain; charset="utf-8" There are functions which have unused arguments for different architectures. Separate the code for each architecture and move #ifdef arch outside these functions. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/mseal_test.c | 8 +++++-- .../selftests/mm/pkey_sighandler_tests.c | 21 ++++++++++++++++--- 2 files changed, 24 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selfte= sts/mm/mseal_test.c index 34c042da4de27..af49f72e1f465 100644 --- a/tools/testing/selftests/mm/mseal_test.c +++ b/tools/testing/selftests/mm/mseal_test.c @@ -131,17 +131,21 @@ static unsigned int __read_pkey_reg(void) return pkey_reg; } =20 +#if defined(__i386__) || defined(__x86_64__) /* arch */ static void __write_pkey_reg(u64 pkey_reg) { -#if defined(__i386__) || defined(__x86_64__) /* arch */ unsigned int eax =3D pkey_reg; unsigned int ecx =3D 0; unsigned int edx =3D 0; =20 asm volatile(".byte 0x0f,0x01,0xef\n\t" : : "a" (eax), "c" (ecx), "d" (edx)); -#endif } +#else +static void __write_pkey_reg(u64 __unused pkey_reg) +{ +} +#endif =20 static unsigned long pkey_bit_position(int pkey) { diff --git a/tools/testing/selftests/mm/pkey_sighandler_tests.c b/tools/tes= ting/selftests/mm/pkey_sighandler_tests.c index 638477494ff3a..68f106d0876a7 100644 --- a/tools/testing/selftests/mm/pkey_sighandler_tests.c +++ b/tools/testing/selftests/mm/pkey_sighandler_tests.c @@ -41,11 +41,12 @@ static siginfo_t siginfo =3D {0}; * syscall will attempt to access the PLT in order to call a library funct= ion * which is protected by MPK 0 which we don't have access to. */ +#ifdef __x86_64__ static __always_inline long syscall_raw(long n, long a1, long a2, long a3, long a4, long a5, long= a6) { unsigned long ret; -#ifdef __x86_64__ + register long r10 asm("r10") =3D a4; register long r8 asm("r8") =3D a5; register long r9 asm("r9") =3D a6; @@ -53,12 +54,26 @@ long syscall_raw(long n, long a1, long a2, long a3, lon= g a4, long a5, long a6) : "=3Da"(ret) : "a"(n), "D"(a1), "S"(a2), "d"(a3), "r"(r10), "r"(r8), "r"(r9) : "rcx", "r11", "memory"); + return ret; +} #elif defined __i386__ +static __always_inline +long syscall_raw(long n, long a1, long a2, long a3, long a4, long a5, long= __unused a6) +{ + unsigned long ret; + asm volatile ("int $0x80" : "=3Da"(ret) : "a"(n), "b"(a1), "c"(a2), "d"(a3), "S"(a4), "D"(a5) : "memory"); + return ret; +} #elif defined __aarch64__ +static __always_inline +long syscall_raw(long n, long a1, long a2, long a3, long a4, long a5, long= a6) +{ + unsigned long ret; + register long x0 asm("x0") =3D a1; register long x1 asm("x1") =3D a2; register long x2 asm("x2") =3D a3; @@ -71,11 +86,11 @@ long syscall_raw(long n, long a1, long a2, long a3, lon= g a4, long a5, long a6) : "r"(x0), "r"(x1), "r"(x2), "r"(x3), "r"(x4), "r"(x5), "r"(x8) : "memory"); ret =3D x0; + return ret; +} #else # error syscall_raw() not implemented #endif - return ret; -} =20 static inline long clone_raw(unsigned long flags, void *stack, int *parent_tid, int *child_tid) --=20 2.39.5