From nobody Sun Oct 5 18:20:51 2025 Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazon11020133.outbound.protection.outlook.com [52.101.227.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F59F23B61F; Thu, 31 Jul 2025 06:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.227.133 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753942251; cv=fail; b=CZ9ER4u7bbQ8vxId8fEbDNGGORit21tyWDBRocYFHGoI4LFDQFoEGoKANLwjcA+gryHL30Ybe/zeitJ9xCI5eBGLY4c8a+/x7kIwZMs5J9jGvlGorY0/m7b0Sym6X262UpBkN7va+CHyWBEAHs4Ze1TAG3MG/zmLmnYxz8oEMDQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753942251; c=relaxed/simple; bh=pb0BYMVWADbL0Ba4XK3jHn2A1OgRmXXuvVzcgK/HkqI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=eECzt5IzEWBrD7lhNDwcRg265kMxoEF6b5KsdL7kEXNpEBRwrxzXz5gD5Cwyq9/qLlOnIyw8hQbb4fbTYZ6df5k+Uzp+rZ0CXk3S+aBX8cxM3cSlW9W3KbnMVliu6V3OZAn1JimMDR+Ofv03gOfgIxMYEwEoLGvkVEjJTKVckko= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io; spf=fail smtp.mailfrom=siliconsignals.io; arc=fail smtp.client-ip=52.101.227.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=siliconsignals.io ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=K4vWsvdpX1Wpd8Agvvw6jBeiSLmZsxMDQOG9qRKGXD0nZcFA3yb2h+5kzOCOBd/Zf5RBcleptmjzWnhd+5rbwjOIPD9TJCQGH9GZcOn4SRyDJqvJpH/ka5DBQ0uryzFVQdnY5NqgDKetb5rKlNpK6+AVIUwZbG/Hvs3Fcqs52MgPtQYSPlCDsID/QuwA1w//wvYuprrdp4/RUId/AhYGnElcnC5HBNr1ALhZ46EMIi+RKcuodhe1hkmA7/hPgB16zsE/rW24HSf6Pr28HQDHwmDvhXIRaj3GO+pbFRC0y7KsLzye5yMuJaSsA0by4c3Ov5ynBgbP7nU6MpQkv6b0qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4IZu/fbd5OQx/ecIHRbqukOUZ0tTpHxR4cwBoSRSN3Q=; b=yRn1noSPMwNwdfIiA1mpmB3A5LlV4GlbZOQ4FGGbG5/y6IiFs/gHkKBwWGZYz4nQqxLZ/kTMIwqeihd3lltx90vRqUUO+mDhzTDcdIp+Mp9a/NgKSOmQgwmUaPHdj7EGximNQsa09lEwjdUzDvDQp5RTW2TH7HXzh+5ndo8hxBMnEKNdnCmVCNgIzjR6QWE+6HQJeOlh/VbSb/5Rx0CEdSdftbbcfHDoZ5OtM0sKyMiaOeE1pPy/FO9pyntfZ+qO5iyk10F6bRy3E1wFcgdKvmiJd5sRDnBdzSit15niYDe30pB0PHGfGCTZYqMw3hmECVTx3lDxEhfnBCjPZjcJyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) by MAYP287MB3886.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:14d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.14; Thu, 31 Jul 2025 06:10:46 +0000 Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418]) by PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418%6]) with mapi id 15.20.8989.013; Thu, 31 Jul 2025 06:10:46 +0000 From: Hardevsinh Palaniya To: sakari.ailus@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, Himanshu Bhavani , Hardevsinh Palaniya , Krzysztof Kozlowski , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , Ricardo Ribalda , "Bryan O'Donoghue" , Hans de Goede , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Matthias Fend , Tarang Raval , Heimir Thor Sverrisson , Jingjing Xiong , Dongcheng Yan , Benjamin Mugnier , Sylvain Petinot , Arnd Bergmann , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 1/2] dt-bindings: media: i2c: Add ov2735 sensor Date: Thu, 31 Jul 2025 11:39:57 +0530 Message-Id: <20250731061004.5447-2-hardevsinh.palaniya@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250731061004.5447-1-hardevsinh.palaniya@siliconsignals.io> References: <20250731061004.5447-1-hardevsinh.palaniya@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN2PR01CA0235.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:eb::13) To PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB3519:EE_|MAYP287MB3886:EE_ X-MS-Office365-Filtering-Correlation-Id: c637a7b3-8e23-4f78-8c77-08ddcff8fce5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ucL0a1lbFNLTm8IazDQA6IRwA2QObNoM3X+yGC9E+Xe642MKaYUQBfsW+uO/?= =?us-ascii?Q?pJcXtiQnCU9NgYjl12m5pwo+yG8ECDsxZ5azVOLK+quZLBqKF+6Jtqh/jdH3?= =?us-ascii?Q?B3NQ9BQ+qTlUpxyrp14PcruC0ONrXxvD1NcbOQ9MU/BLuKms5dzLE/r/hYBT?= =?us-ascii?Q?A9W4ZAWFHX3jAOQhBbbPMTuJF0DDUlqSqjwFtOcnou9FbUJTVjuNVRoOh4om?= =?us-ascii?Q?bNbbOOP5BLrZkh2vWifyvcDgg+beMEdfxEc5KN3Mqj/BnnFPMr1+6bgUmPC4?= =?us-ascii?Q?4cNDdSw1NTi3dJ/WyW5a94rh/5nDv2miBAh9w+1ZWDFF6aOt0/lb4Mq9cEt1?= =?us-ascii?Q?da1EA8dR+VAxFSsPOiG6+e9WKvi9S9h6PeYximr+YucCPNMQO+9vdsU4RcPL?= =?us-ascii?Q?sCROUy6oEPXDwm8AlQtXs/eNESfIyg3+El9drdPhaiMOHzCEwzxnLRSZG65j?= =?us-ascii?Q?qQzGQVxnQekja1oG26Uk8UpAaw4HJihSFwok+E+/xHWlRQtHqFIzU6Wsqhhk?= =?us-ascii?Q?HRnPTIoaFDxo+tqfOBoTT+2XR6BbM5nwTKesVXOTCtW/dfUMxepy9iqfVYCo?= =?us-ascii?Q?CYfS2JEw19llvsou8kujNWFYS8IPbXuHoe4HuAh5vGTMwERpF2USfDeB+h0w?= =?us-ascii?Q?uSLTiiVuR092gohW80Vg+vyOgIeAd7YEpuMVoilcoT8HCNTX4aIrQclMpa9O?= =?us-ascii?Q?9GyVrOU60ZFU9uXGeIrbLjuK2DPhiL+fF40GJAIhUMpcJIV1nw4pClQXrRjZ?= =?us-ascii?Q?ymw/3i1MGuUJA6lcOJtqb6rtWpVX9U1NCsJMe2i8lB85qPe4bSjHWHpQ5iBa?= =?us-ascii?Q?ClGBjpcdsCVXDH+33uxplJcXBUTc6TrBJoYZx6KYrgkGq7VHKIdjZomNZCcf?= =?us-ascii?Q?V0jIkWr04fdsc4hEiyyZfXRkzwLA8lp784MTfTMRWwQ+HKZz37nMgavpjcUb?= =?us-ascii?Q?jC5NnEB+ap/0JUHr2VV9IDyXHtqhqPpM38FJNT+jHvSTh0FageUM5+rLb1ND?= =?us-ascii?Q?24Nn1tKiMBnvg1/fUVl7Cyks0USdTT/H3hf1re5Y7VmaSWOBww1yWByq2Spg?= =?us-ascii?Q?GOduC0tXo3IjdC5CmaHu1UD2nlhJeY8XYp/L6eepRQ88aLc2PaXfc7JCLfrT?= =?us-ascii?Q?joprdxab38zylQTTDFbp3rMacLM+EszFuK2Raz3u3n3jsJNOogAX4V+3jdH9?= =?us-ascii?Q?yHZsqo+7hnHhFB37x8g5Z5FvHCa4Id9QYZocIkTPkv11yu6pryVCmJKe3RTJ?= =?us-ascii?Q?SEGt9TA7mLRgJzBoDD8XU5vuk8omthW0uc0hirI/iTpI8tw23sv8RQbjBj9A?= =?us-ascii?Q?GxZfXFBkgT5TIT+JUHzLMMgWbfmGjKdQTokm1w5Axv9vgc0autI/WmzeSsPv?= =?us-ascii?Q?qB0EuqnpLxMfqZGzrcq5f1Tyw2Je28uZ/4bQ1HfMpgAz+3FK3TPlMAI8AH0b?= =?us-ascii?Q?PNXqRHbU4kT9MWJ7cvdw4/AiBcmuFE4o?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB3519.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PyK/M714F4USaed72WVt7+Ls/qTQGf1dPFhlTOtS/eIcAkJrIQ9wXUbmfq7x?= =?us-ascii?Q?qtA7FYCvOAApFd6ePlrjJ2ibEh8gHtzfkfUFezpea7Y6qp0izlU+kHcQj8uz?= =?us-ascii?Q?4RQPy7Nnr6cFtGOr2NQrviH4LkIO52gy64Hfos264pcaBnZMdEk0HTzYIjLw?= =?us-ascii?Q?OiJcKw2JRF8shqsKgD6UrKk620LEvpN+kqBnwXH2ZPx6mM6dQ+7O6+F0MWQa?= =?us-ascii?Q?bPJHr45qOwYppW7TUKRrXUeEM7wlUEi8+CiZCORx0eBD4fC6w4WQi+brrcZ0?= =?us-ascii?Q?dJgaKV/0uRA4sSBgwLBYRC3099wxXseppsYcJHsVDR/DD/fhDY/ASjYyjw8i?= =?us-ascii?Q?H1DYeOohM5u1dbviHvts8Kc1gH/oTc/1XwCoXmOOoNbZziXs/0VupsH2WEnd?= =?us-ascii?Q?hBalkX03+lnyqojFs6h7S5ZsPE6nS0Xx/hAMPnmBebc9EefdIWvPPLPsRQ1n?= =?us-ascii?Q?JysJRhxUK1zxyeP0iSNryoxYUDVSJwfDtkWX6dlKiq+SJ92Ia7O+h1c54707?= =?us-ascii?Q?pCoHdY8peRcWwmX7A95ixNCT2Y/yMozmtW9LS1u3eEjFrOFaLipHPBib4LMl?= =?us-ascii?Q?uR0gsPGGHHvEm5HwOJztxnNenEZYY+10KGBMgmHQD7J+80dEoh5Vq8tmyjdY?= =?us-ascii?Q?IcsoKZxO0LkFHP6Q7bmCKS0wdN+ctYmrw60nQLpMogky8+fVL4Qp74ozkbhu?= =?us-ascii?Q?XVy6quuR2nLTfHLNC7kWnuxasJc9FNLBRka7yu9GHcKIk1tBcfNmZWLp01H/?= =?us-ascii?Q?rFYIyrernmdpf0q+r0K/L0FQT//0jC9oBDERYsPfGjpw+4MoOs81HGLWCtaE?= =?us-ascii?Q?QGxRqlJgGYd+9q5zChmHwRi2JKtNhMHuVKGrJjdkeTlOEGEsIi3MOsv74IUB?= =?us-ascii?Q?XA1c0yY5wrmbbZPDUJxg3XplLcyXy8cTvWWW7a2dzKPIpPfgWAwyRwbjAwNs?= =?us-ascii?Q?29AZVwY/wcaWHMzKk3yAsK3OSh2Rt7FNO+cpJTRj0Szo6OAE68BYaQpgyVKG?= =?us-ascii?Q?t12kvfcBBY+S7noNCSQAX7yDNuwDqP+9TWZXfiL613aAEZJaqGnkoCjlMG3E?= =?us-ascii?Q?la2xmS6F7L91XARwPpHrCJhO+BFV7DDeUT5zObkOZ45l4r7eSTsml45fTWMG?= =?us-ascii?Q?WiZNF0idc2D+DzIx6d+LGTxPU9mBI9GDcTWNfHsaTj/vBFgY1csefZMPECG2?= =?us-ascii?Q?hCmNb+p0WhymcC4vn8ZEEjqN3FGocQHLpVhHpSz19P+sXCEwz8G5hUnllf8S?= =?us-ascii?Q?sGesO1HFZ/ajTlD0ZjSDsTDcc9938PaknCQnX140fhRVjHEdM26D9GJjr9T5?= =?us-ascii?Q?s/oZB82Nc3c59DrlDNOialwRZwVVEvoUKv8Nx65oaY0ryRKcd0TIIUsf3MWo?= =?us-ascii?Q?ByiPtEhj4dBIJ7F6QP+nyHSFInYEmvCpskocdpPQf2uO2LjH1npDhsWTKkYr?= =?us-ascii?Q?9VLaaLoKG8O2U+7wAo3BpLMa2vBvPuZtmp6pARazM1IV0TOZelU4Nq4BnOnB?= =?us-ascii?Q?zJ7JRoOHFjz1wWSBA74fvPB208AHjhK5RArNS6XL1RNDw+m717XZcm0xwW1l?= =?us-ascii?Q?9zOpAvJsI+zf0wUzRD9t31zrw1LNDzSm5Y4auooUb4oHMP9KrwbSgMngzWJ/?= =?us-ascii?Q?4UwC+39IrIrtXcLNbbIhzGU=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: c637a7b3-8e23-4f78-8c77-08ddcff8fce5 X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB3519.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2025 06:10:46.0487 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +e/LTPQMe9WLQxdFo4XgpF9U6On8nwZR2BHgUG1hPwQQutRIn5RqEuzpaS/owrzjTEiyp+em3OYyUObPMuUPFelCK/8M1IZn1oOezrb2QT1VOoS3LoNY8DoGP8Z4yrjg X-MS-Exchange-Transport-CrossTenantHeadersStamped: MAYP287MB3886 Content-Type: text/plain; charset="utf-8" From: Himanshu Bhavani Add bindings for Omnivision OV2735 sensor. Add MAINTAINERS entry for Omnivision OV2735 binding documentation Signed-off-by: Himanshu Bhavani Signed-off-by: Hardevsinh Palaniya Reviewed-by: Krzysztof Kozlowski --- .../bindings/media/i2c/ovti,ov2735.yaml | 109 ++++++++++++++++++ MAINTAINERS | 8 ++ 2 files changed, 117 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov2735= .yaml diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml b= /Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml new file mode 100644 index 000000000000..9236829cc00d --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml @@ -0,0 +1,109 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ovti,ov2735.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: OmniVision OV2735 Image Sensor + +maintainers: + - Himanshu Bhavani + +description: + The OmniVision OV2735 is a 2MP (1920x1080) color CMOS image sensor contr= olled + through an I2C-compatible SCCB bus. it outputs RAW10 format and uses a 1= /2.7" + optical format. + +properties: + compatible: + const: ovti,ov2735 + + reg: + maxItems: 1 + + clocks: + items: + - description: XVCLK clock + + avdd-supply: + description: Analog Domain Power Supply + + dovdd-supply: + description: I/O Domain Power Supply + + dvdd-supply: + description: Digital Domain Power Supply + + reset-gpios: + maxItems: 1 + description: Reset Pin GPIO Control (active low) + + enable-gpios: + maxItems: 1 + description: + Active-low enable pin. Labeled as 'PWDN' in the datasheet, but acts = as + an enable signal. During power rail ramp-up, the device remains powe= red + down. Once power rails are stable, pulling this pin low powers on the + device. + + port: + description: MIPI CSI-2 transmitter port + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + items: + - const: 1 + - const: 2 + link-frequencies: true + + required: + - data-lanes + - link-frequencies + +required: + - compatible + - reg + - clocks + - avdd-supply + - dovdd-supply + - dvdd-supply + - port + +additionalProperties: false + +examples: + - | + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + camera-sensor@3c { + compatible =3D "ovti,ov2735"; + reg =3D <0x3c>; + clocks =3D <&ov2735_clk>; + + avdd-supply =3D <&ov2735_avdd>; + dovdd-supply =3D <&ov2735_dovdd>; + dvdd-supply =3D <&ov2735_dvdd>; + + reset-gpios =3D <&gpio1 6 GPIO_ACTIVE_LOW>; + enable-gpios =3D <&gpio2 11 GPIO_ACTIVE_LOW>; + + port { + cam_out: endpoint { + remote-endpoint =3D <&mipi_in_cam>; + data-lanes =3D <1 2>; + link-frequencies =3D /bits/ 64 <420000000>; + }; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 92e9d8c7708f..474eefbd1363 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18471,6 +18471,14 @@ T: git git://linuxtv.org/media.git F: Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml F: drivers/media/i2c/ov2685.c =20 +OMNIVISION OV2735 SENSOR DRIVER +M: Hardevsinh Palaniya +M: Himanshu Bhavani +L: linux-media@vger.kernel.org +S: Maintained +T: git git://linuxtv.org/media.git +F: Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml + OMNIVISION OV2740 SENSOR DRIVER M: Tianshu Qiu R: Sakari Ailus --=20 2.34.1 From nobody Sun Oct 5 18:20:51 2025 Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11020099.outbound.protection.outlook.com [52.101.225.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A915244695; Thu, 31 Jul 2025 06:11:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.225.99 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753942268; cv=fail; b=my9NwgAFnaQiD65RKkBOdleSQEztbu34o3xJg7tLYwwFFNCvJQx/jOhWox4/lV68XBxyjBs74qMl1GvLf7DXiYseSoKgWJWM6uzLZ+5pT5+PT66o9LptNo5IMZBlLCJcwX//IAG9jxcdWIl9kkoAnIcW1FQx8GKr5RRvoCQ2y9E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753942268; c=relaxed/simple; bh=FRmwLWdYC6zAx2GSdRm5QMZY6HBaJcPEySJIcd/223c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=m8KMyqk8eSxZlr1iPGwsg8F2l7dqVA9Hx1rTdQSXc54MjtSb7tuL0RIdyKKF+KAsPBers3F70v6VX9AgnAWcKCjPzILirBQKoBgpTU5QqwlwZxHitFU6ZFh1wbe0KgMFpqw3hZsXJe0pSzarxYFGVmjbLTqBRGmto1Jmta4vK9Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io; spf=fail smtp.mailfrom=siliconsignals.io; arc=fail smtp.client-ip=52.101.225.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=siliconsignals.io ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iP+TXjOWBHSE6nh1Ma4kYfGUlO0s5ncedcfl2c8LLNiHtBo1B1EByaBEm+TXAlQ3vaJPgukIYzQEnF92fIJUFKEYJTpWLQCVUG/gHl01Bf8n3eD+7kCrXYSZkQVSodR5oJ6Hz9QQC6SyGB/e5G7l9tNVSoB57i2O5IQj8aJ76faA1+jUrZLwFciJxumeRNpw/ZIXFBY2tZQhNm/fr9WHes5GFlsZPh7LYVTl/O5Osn/UJ/HauyZOic/3dz+rlfXibKwpRaWnPsgxOjDSAnTjtgwZJGGKBfayOP3nBgTVBxNEqEj23gcqEvK0206K9Z3F3Or4DcUsWUuOo7dA5VwBBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7KJKaZLYz2vgSznHYaIfioLVt1jUN6yHIZNg5TP0ozI=; b=DhyaJQoT62F69kj8YUzokDk6Alr0ngDoex/mfc8K9Sbytc77jzshR8DdJcjCpftydDEt2pEOu7pvbz4FInpFW5iA6qBvIIksyIsSaKT9ga0ht5wDqsOOS/WrsEV0XiXT8HmJ4b4twZOLgYvwMiwertlNb/JU1KHdcAgW+INcofxFO9Rfny5I4sQLIunnlwCbij8ScamWhE8YG8ce5xKkjF9vsfruYKPwND3m1/mSV1UoP+6VBYkpiVUjmbuG0X1A1aP7JhjqQlJyOb67mIsN3Kw8+mbU1pg1PcQ90QrCvRE7olYkZFd7LA+V6+t4CgKrrwsw/4scTTUXnPvZg/uG+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) by PNXP287MB0029.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:c7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.14; Thu, 31 Jul 2025 06:10:59 +0000 Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418]) by PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418%6]) with mapi id 15.20.8989.013; Thu, 31 Jul 2025 06:10:59 +0000 From: Hardevsinh Palaniya To: sakari.ailus@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, Hardevsinh Palaniya , Himanshu Bhavani , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , Ricardo Ribalda , Hans de Goede , "Bryan O'Donoghue" , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Arnd Bergmann , Sylvain Petinot , Dongcheng Yan , Benjamin Mugnier , Jingjing Xiong , Matthias Fend , Heimir Thor Sverrisson , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 2/2] media: i2c: add ov2735 image sensor driver Date: Thu, 31 Jul 2025 11:39:58 +0530 Message-Id: <20250731061004.5447-3-hardevsinh.palaniya@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250731061004.5447-1-hardevsinh.palaniya@siliconsignals.io> References: <20250731061004.5447-1-hardevsinh.palaniya@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN2PR01CA0235.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:eb::13) To PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB3519:EE_|PNXP287MB0029:EE_ X-MS-Office365-Filtering-Correlation-Id: 65c41bee-9431-49fc-e03c-08ddcff904fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FMCDGYxI9HLDF5xEKHYmoSh48Um3SEOyBqZwYXWg8oqWh7xuhTmehFe+6KPJ?= =?us-ascii?Q?W45ILeTWH4f9opapX/M4lCWU7mQ04SN+BDvN5faizVkOsNsePC3DYfGbzV7k?= =?us-ascii?Q?qKnu8XpQNBa7MxQzV+Bs5OJtyvEQ1oYOPuvP5Y1GZbWpff/8t+MiNVybkAXM?= =?us-ascii?Q?g8gmtq7aOgPY3Ab4pQynPD2kgHAFfO8Nrj/FJ/2VXfvaPm0TGTHQivOlKqyc?= =?us-ascii?Q?4JOiW2OPCwuEFXmIvp06CfmnJxoDtSSsjhTI1jd88sqcI3aCs8F1JpcN57nk?= =?us-ascii?Q?DuvYOikyopPtbfGlNkzWIKxYn2rHH3Zq2uuBkSCWlNhyrZawP6pCtBOi2IKp?= =?us-ascii?Q?11Zi/3s3IDWocq/qDKfpiugWYlAzzqVMpJ1imYD4Mn0gfbHaQSLREuDyKk0k?= =?us-ascii?Q?gSEShlHZImb8gM4+rSpD6CdpbvpmfEO/ULua+z/wE0hnAA61VoKqJH25rztk?= =?us-ascii?Q?n/3WJWliowzVrF3ANh/1m8PsZs1GQyVM6RmayEBFz1pp5j6ciGxV9ZQaK9os?= =?us-ascii?Q?UMuqaCl0XNgTbYIW4pr6vhWNLe0C8Q3u37RzvyYzg/Hx/Z+/4nQkNe+RqdUV?= =?us-ascii?Q?mxch8yA4+4xqC1cuQ2EwD/wjmX0Z3HSb+ZXn+RD+sLdxcurwabAOf2xib04c?= =?us-ascii?Q?tNHO2OvK2+sZSwDw5Ur+pu77rBzd85sVcuqmaEhkPIH9GXBZtyBcKQpcc/tr?= =?us-ascii?Q?D9FpjjQcpHIhPwyOGx+jXuaLwggsZBZug9lHcZVMFvzECjY03eKPHUisn1SH?= =?us-ascii?Q?ikRuO+oz6yfYDuZFhDHY2BKN18ymfrfiny5jX0kgVwPkDfx2kyQ9e2AhVm+P?= =?us-ascii?Q?hZ+MNHNQVrSEgFNJxLi8CmtIMYanogdNxLzm301W9xFjGCuI3imJmwpSLF58?= =?us-ascii?Q?H60dzXkBLWgp9km46WiplIUaKU/j0MvAiRN+Vm+oVYum+aBgbVGE1HjL5foo?= =?us-ascii?Q?JQEWKXCTtkPRx91GIxl74FJ7HVA87SusMyLlwiKvoKtvYy6fhxL+qO+YHTTx?= =?us-ascii?Q?b9VlbiqE+YBih/nfsLCAVLjxrKc9LSZxhWYBrQtV+oKDd2liChEfO3vCPXwX?= =?us-ascii?Q?jd8fgUDIQDwdJA/7GAbvnSaaSGQ7uGCzuHIV1bs0NQnCfl0zDx20g7h2QWEa?= =?us-ascii?Q?BGjuFOf7m1bJvp4SS3YPLFazBYyxSqLAap1wRXHlVSywc+WTMHQ6tRUkYRy+?= =?us-ascii?Q?fnXrHnmNnRY1frb09RKpwF3DhFFVgzfV5ggvj0qEBA70GikoxJ5G43ICsOHW?= =?us-ascii?Q?WkPed3Vx/96ohU240dyydJ936is1i1214hScLGmhs+mhZ5thFF/QC2IGG07X?= =?us-ascii?Q?7m9lQnEnKum/7Poc+yOwCHjXIo0iwxxa3aEfZHhAvLs1QlUO4lbT8y6+xiS6?= =?us-ascii?Q?ilnONBUfh+bkaOIev2ooOQ8Cf3JPTZ5F0cp4trrhIDujl3Dh2R+gPdqXXkIe?= =?us-ascii?Q?32AtzTi9ztMXqvz4VzKIw8Mx+AiSDnJvZHdtAp0OjyyIl6GUF6xP2Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB3519.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jOpm+WEymvIldcqXpe9usuPF0gCk1NDP4XGlrBOlP+nXAE/F2mYYke8fFCTw?= =?us-ascii?Q?0jKPWgrjMSW2nJZ/gjg8vetAC7vQgycNUgs2h5Hai7MBETQfyMHYShJvHnWs?= =?us-ascii?Q?yQUVkOKEVWd0iiK03UmD5IiiV/axLHX+MXa26/PFKJdYmgsJ1JeIwbu4DqLv?= =?us-ascii?Q?EARknL442j6+kdwvTMSxoqiadoP3eIrzOilwSKy5CcN8+254FcswUzNVSt0v?= =?us-ascii?Q?+vLHc7VwPo7W9x2ki1Fn0AFiqfxJIYvQkGjU+0gRryKVPS5eUJGBUrK3/Skn?= =?us-ascii?Q?/SF+mCMdU76+WWGqFIB28oNZiTs/0J+tBxSyquo4qfKDONOTtVxrXGrjQYhR?= =?us-ascii?Q?EQXeSwXSkGfvHJ3uYqvpoGTGpoN95zyNTyKvmsJXv2HXi/IQEW2iutO4ceYG?= =?us-ascii?Q?KVjYCVtcHR9Kv6avDR2HEemRl81xNEJkVCuWdEEt3uQhKOhEF3YIGeV7Ydco?= =?us-ascii?Q?zIRbAfC8bwysSQNM5mCeptzjM47mof3ERelMomq4rml4nusx5yvJINMTTuvU?= =?us-ascii?Q?nqfP1EQ3VPHj86BRsaAvqfCLA7AQSdTBfkiqFJdhZGDBhCd9RIJBq7wqc+nE?= =?us-ascii?Q?nlRBmc1vsx3dJFInnG83zR1saEp/z1WxhCohG/WCUg5z87kZrq0lqlweV9kZ?= =?us-ascii?Q?vlLV6eZ+6j+Z+HhxNqNk8uMTggCtZUaD6wwchFWOND+5zxmsemcXMsatQJAZ?= =?us-ascii?Q?OhS4s3FYP65mkXvBYY0GWVzsp66QvP/eCTL8ML3s2DxUnLXLeYPgXj6fJtUO?= =?us-ascii?Q?9TPH91u4vYFSL7++yqxY6KnGn30jmXa4zcuxecL0Gsw3BGAv1rbuMxXv/cu0?= =?us-ascii?Q?tD4skQwiHakV6oqJ68ewspFb9W6T3YxMyFFJlBIv38ZcxbyxYweIGB89rXco?= =?us-ascii?Q?pUpnJsSoWG5mGBISJtMGqzfzc2/DBQjFlGPtQncK7IdEPzv2qQgNjrz2NvId?= =?us-ascii?Q?1uAgo/Eb7WFozN+ysY+1XKQla/AF1uCgwObZ46IV4gVx3vQwR2oFoMrSbMmE?= =?us-ascii?Q?5sa8zz09QRfg57ChdDn6bvDMvF4R0iMNdxQoKCJLTvOnaqf3wt9AZJB4vhIr?= =?us-ascii?Q?lHx2X9521IoRTptx1B7662eD/wALhvC4YTGDcRfGpuoqt2jIeCskskijg0aW?= =?us-ascii?Q?00/ZOQ81exA+HSMVpqJdyNmroiKOBBuYZLX2dXXfsVDbbZofH97rFAFaucA0?= =?us-ascii?Q?NSMC5RaHhqVVdFlvOFme1eT1JI5P0YCMzn4WVJSoRW0VdpEf/p49GFonbeGL?= =?us-ascii?Q?r1uFPmZDJ7ps35vet7dLMLYzwfWO0+n49D0N2ygEgYtGG5drxxu6ZVGjbmRi?= =?us-ascii?Q?rH2TI8yB5jVjCV5F+6KJmZaeOUqZ/oIfaP5GUkdC0C96jKXD1plU+DmB82Kx?= =?us-ascii?Q?Z4wzz/y1KDmgEyOiaDaV46J3CKmx6lfvfUTDSWN+s363G0YpMWCgQM8qHVwz?= =?us-ascii?Q?NcjmgTKUEHeQnVl4bZrHsrIaT5cO0R+SsyyLosuj0Fdk0oQ2kw4w5T/ASZP+?= =?us-ascii?Q?Sfzr/oVDdUXOwf4xMw08qNiSk76dvTSM5WfhLZw0CGl1SRmJaxOzYohGeB9Q?= =?us-ascii?Q?HBBYg7GB1hlWvQCrHjTQTqsONh4Kg4jToKV0Y3EDi01Hw3LYaY2UPGj5IusZ?= =?us-ascii?Q?ggGbPFbLO2lxIcShjK12d28=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 65c41bee-9431-49fc-e03c-08ddcff904fc X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB3519.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2025 06:10:59.7949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fyzdarDD8qhBKIOu6Hk2S/kHiRaVgxudhbQBl8sXj+/117xv7IEml6Z+D09ddVbFd6GUbWuP/6++jxmBfkAJ7+75pmzhqd5GcJynoY23XBbh9wXMolsQRJJK5L3ulO4o X-MS-Exchange-Transport-CrossTenantHeadersStamped: PNXP287MB0029 Content-Type: text/plain; charset="utf-8" Add a v4l2 subdevice driver for the Omnivision OV2735 sensor. The Omnivision OV2735 is a 1/2.7-Inch CMOS image sensor with an active array size of 1920 x 1080. The following features are supported: - Manual exposure an gain control support - vblank/hblank control support - Test pattern support control - Supported resolution: 1920 x 1080 @ 30fps (SGRBG10) Co-developed-by: Himanshu Bhavani Signed-off-by: Himanshu Bhavani Signed-off-by: Hardevsinh Palaniya --- MAINTAINERS | 1 + drivers/media/i2c/Kconfig | 10 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/ov2735.c | 1071 ++++++++++++++++++++++++++++++++++++ 4 files changed, 1083 insertions(+) create mode 100644 drivers/media/i2c/ov2735.c diff --git a/MAINTAINERS b/MAINTAINERS index 474eefbd1363..058bbfd9523b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18478,6 +18478,7 @@ L: linux-media@vger.kernel.org S: Maintained T: git git://linuxtv.org/media.git F: Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml +F: drivers/media/i2c/ov2735.c =20 OMNIVISION OV2740 SENSOR DRIVER M: Tianshu Qiu diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 4b4c199da6ea..9646eab1b177 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -446,6 +446,16 @@ config VIDEO_OV2685 To compile this driver as a module, choose M here: the module will be called ov2685. =20 +config VIDEO_OV2735 + tristate "OmniVision OV2735 sensor support" + select V4L2_CCI_I2C + help + This is a Video4Linux2 sensor driver for the Sony + OV2735 camera. + + To compile this driver as a module, choose M here: the + module will be called ov2735. + config VIDEO_OV2740 tristate "OmniVision OV2740 sensor support" depends on ACPI || COMPILE_TEST diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile index 5873d29433ee..1adb27743fa1 100644 --- a/drivers/media/i2c/Makefile +++ b/drivers/media/i2c/Makefile @@ -93,6 +93,7 @@ obj-$(CONFIG_VIDEO_OV2640) +=3D ov2640.o obj-$(CONFIG_VIDEO_OV2659) +=3D ov2659.o obj-$(CONFIG_VIDEO_OV2680) +=3D ov2680.o obj-$(CONFIG_VIDEO_OV2685) +=3D ov2685.o +obj-$(CONFIG_VIDEO_OV2735) +=3D ov2735.o obj-$(CONFIG_VIDEO_OV2740) +=3D ov2740.o obj-$(CONFIG_VIDEO_OV4689) +=3D ov4689.o obj-$(CONFIG_VIDEO_OV5640) +=3D ov5640.o diff --git a/drivers/media/i2c/ov2735.c b/drivers/media/i2c/ov2735.c new file mode 100644 index 000000000000..350afa10b7f0 --- /dev/null +++ b/drivers/media/i2c/ov2735.c @@ -0,0 +1,1071 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * V4L2 Support for the OV2735 + * + * Copyright (C) 2025 Silicon Signals Pvt. Ltd. + * + * Based on Rockchip ov2735 Camera Driver + * Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd. + * + * Inspired from ov8858, imx219, imx283 camera drivers. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#define OV2735_XCLK_FREQ (24 * HZ_PER_MHZ) + +/* Add page number in CCI private bits [31:28] of the register address */ +#define OV2735_PAGE_REG8(p, x) (((p) << CCI_REG_PRIVATE_SHIFT) | CCI_REG= 8(x)) +#define OV2735_PAGE_REG16(p, x) (((p) << CCI_REG_PRIVATE_SHIFT) | CCI_RE= G16(x)) + +#define OV2735_REG_PAGE_SELECT CCI_REG8(0xfd) + +/* Page 0 */ +#define OV2735_REG_CHIPID OV2735_PAGE_REG16(0x00, 0x02) +#define OV2735_CHIPID 0x2735 + +#define OV2735_REG_SOFT_REST OV2735_PAGE_REG8(0x00, 0x20) + +/* Clock Settings */ +#define OV2735_REG_PLL_CTRL OV2735_PAGE_REG8(0x00, 0x2f) +#define OV2735_REG_PLL_ENABLE 0x7f +#define OV2735_REG_PLL_OUTDIV OV2735_PAGE_REG8(0x00, 0x34) +#define OV2735_REG_CLK_MODE OV2735_PAGE_REG8(0x00, 0x30) +#define OV2735_REG_CLOCK_REG1 OV2735_PAGE_REG8(0x00, 0x33) +#define OV2735_REG_CLOCK_REG2 OV2735_PAGE_REG8(0x00, 0x35) + +/* Page 1 */ +#define OV2735_REG_STREAM_CTRL OV2735_PAGE_REG8(0x01, 0xa0) +#define OV2735_STREAM_ON 0x01 +#define OV2735_STREAM_OFF 0x00 + +#define OV2735_REG_UPDOWN_MIRROR OV2735_PAGE_REG8(0x01, 0x3f) +#define OV2735_REG_BINNING_DAC_CODE_MODE OV2735_PAGE_REG8(0x01, 0x30) +#define OV2735_REG_FRAME_LENGTH OV2735_PAGE_REG16(0x01, 0x0e) +#define OV2735_VTS_MAX 0x0fff +#define OV2735_REG_FRAME_EXP_SEPERATE_EN OV2735_PAGE_REG8(0x01, 0x0d) +#define OV2735_FRAME_EXP_SEPERATE_EN 0x10 +#define OV2735_REG_FRAME_SYNC OV2735_PAGE_REG8(0x01, 0x01) + +#define OV2735_REG_HBLANK OV2735_PAGE_REG16(0x01, 0x09) + +#define OV2735_REG_HS_MIPI OV2735_PAGE_REG8(0x01, 0xb1) +#define OV2735_REG_MIPI_CTRL1 OV2735_PAGE_REG8(0x01, 0x92) +#define OV2735_REG_MIPI_CTRL2 OV2735_PAGE_REG8(0x01, 0x94) +#define OV2735_REG_MIPI_CTRL3 OV2735_PAGE_REG8(0x01, 0xa1) +#define OV2735_REG_MIPI_CTRL4 OV2735_PAGE_REG8(0x01, 0xb2) +#define OV2735_REG_MIPI_CTRL5 OV2735_PAGE_REG8(0x01, 0xb3) +#define OV2735_REG_MIPI_CTRL6 OV2735_PAGE_REG8(0x01, 0xb4) +#define OV2735_REG_MIPI_CTRL7 OV2735_PAGE_REG8(0x01, 0xb5) +#define OV2735_REG_PREPARE OV2735_PAGE_REG8(0x01, 0x95) +#define OV2735_REG_R_HS_ZERO OV2735_PAGE_REG8(0x01, 0x96) +#define OV2735_REG_TRAIL OV2735_PAGE_REG8(0x01, 0x98) +#define OV2735_REG_R_CLK_ZERO OV2735_PAGE_REG8(0x01, 0x9c) +#define OV2735_REG_MIPI_COLOMN_NUMBER OV2735_PAGE_REG16(0x01, 0x8e) +#define OV2735_REG_MIPI_LINE_NUMBER OV2735_PAGE_REG16(0x01, 0x90) + +#define OV2735_REG_ANALOG_CTRL3 OV2735_PAGE_REG8(0x01, 0x25) +#define OV2735_REG_VNCP OV2735_PAGE_REG8(0x01, 0x20) + +/* BLC registers */ +#define OV2735_REG_BLC_GAIN_BLUE OV2735_PAGE_REG8(0x01, 0x86) +#define OV2735_REG_BLC_GAIN_RED OV2735_PAGE_REG8(0x01, 0x87) +#define OV2735_REG_BLC_GAIN_GR OV2735_PAGE_REG8(0x01, 0x88) +#define OV2735_REG_BLC_GAIN_GB OV2735_PAGE_REG8(0x01, 0x89) +#define OV2735_REG_GB_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf0) +#define OV2735_REG_BLUE_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf1) +#define OV2735_REG_RED_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf2) +#define OV2735_REG_GR_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf3) +#define OV2735_REG_BLC_BPC_TH_P OV2735_PAGE_REG8(0x01, 0xfc) +#define OV2735_REG_BLC_BPC_TH_N OV2735_PAGE_REG8(0x01, 0xfe) + +#define OV2735_REG_TEST_PATTERN OV2735_PAGE_REG8(0x01, 0xb2) +#define OV2735_TEST_PATTERN_ENABLE 0x01 +#define OV2735_TEST_PATTERN_DISABLE 0xfe + +#define OV2735_REG_LONG_EXPOSURE OV2735_PAGE_REG16(0x01, 0x03) +#define OV2735_EXPOSURE_MIN 4 +#define OV2735_EXPOSURE_STEP 1 + +#define OV2735_REG_ANALOG_GAIN OV2735_PAGE_REG8(0x01, 0x2= 4) +#define OV2735_ANALOG_GAIN_MIN 0x10 +#define OV2735_ANALOG_GAIN_MAX 0xff +#define OV2735_ANALOG_GAIN_STEP 1 +#define OV2735_ANALOG_GAIN_DEFAULT 0x10 + +/* Page 2 */ +#define OV2735_REG_V_START OV2735_PAGE_REG16(0x02, 0xa0) +#define OV2735_REG_V_SIZE OV2735_PAGE_REG16(0x02, 0xa2) +#define OV2735_REG_H_START OV2735_PAGE_REG16(0x02, 0xa4) +#define OV2735_REG_H_SIZE OV2735_PAGE_REG16(0x02, 0xa6) + +#define OV2735_LINK_FREQ_420MHZ (420 * HZ_PER_MHZ) +#define OV2735_PIXEL_RATE (168 * HZ_PER_MHZ) + +/* OV2735 native and active pixel array size */ +static const struct v4l2_rect ov2735_native_area =3D { + .top =3D 0, + .left =3D 0, + .width =3D 1936, + .height =3D 1096, +}; + +static const struct v4l2_rect ov2735_active_area =3D { + .top =3D 8, + .left =3D 8, + .width =3D 1920, + .height =3D 1080, +}; + +static const char * const ov2735_supply_name[] =3D { + "avdd", /* Analog power */ + "dovdd", /* Digital I/O power */ + "dvdd", /* Digital core power */ +}; + +/* PLL_OUT =3D [PLL_IN * (pll_nc +3)] / [(pll_mc + 1) * (pll_outdiv + 1)] = */ +struct ov2735_pll_parameters { + u8 pll_nc; + u8 pll_mc; + u8 pll_outdiv; +}; + +struct ov2735 { + struct device *dev; + struct regmap *cci; + struct v4l2_subdev sd; + struct media_pad pad; + struct clk *xclk; + struct gpio_desc *reset_gpio; + struct gpio_desc *enable_gpio; + struct regulator_bulk_data supplies[ARRAY_SIZE(ov2735_supply_name)]; + + /* V4L2 Controls */ + struct v4l2_ctrl_handler handler; + struct v4l2_ctrl *link_freq; + struct v4l2_ctrl *pixel_rate; + struct v4l2_ctrl *hblank; + struct v4l2_ctrl *vblank; + struct v4l2_ctrl *gain; + struct v4l2_ctrl *exposure; + struct v4l2_ctrl *test_pattern; + + u32 link_freq_index; + + u8 current_page; + struct mutex page_lock; +}; + +struct ov2735_mode { + u32 width; + u32 height; + u32 hts_def; + u32 vts_def; + u32 exp_def; + struct v4l2_rect crop; +}; + +static struct cci_reg_sequence ov2735_common_regs[] =3D { + { OV2735_REG_CLK_MODE, 0x15 }, + { OV2735_REG_CLOCK_REG1, 0x01 }, + { OV2735_REG_CLOCK_REG2, 0x20 }, + { OV2735_REG_BINNING_DAC_CODE_MODE, 0x00 }, + { OV2735_PAGE_REG8(0x01, 0xfb), 0x73 }, + { OV2735_REG_FRAME_SYNC, 0x01 }, + + /* Timing ctrl */ + { OV2735_PAGE_REG8(0x01, 0x1a), 0x6b }, + { OV2735_PAGE_REG8(0x01, 0x1c), 0xea }, + { OV2735_PAGE_REG8(0x01, 0x16), 0x0c }, + { OV2735_PAGE_REG8(0x01, 0x21), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x11), 0x63 }, + { OV2735_PAGE_REG8(0x01, 0x19), 0xc3 }, + + /* Analog ctrl */ + { OV2735_PAGE_REG8(0x01, 0x26), 0x5a }, + { OV2735_PAGE_REG8(0x01, 0x29), 0x01 }, + { OV2735_PAGE_REG8(0x01, 0x33), 0x6f }, + { OV2735_PAGE_REG8(0x01, 0x2a), 0xd2 }, + { OV2735_PAGE_REG8(0x01, 0x2c), 0x40 }, + { OV2735_PAGE_REG8(0x01, 0xd0), 0x02 }, + { OV2735_PAGE_REG8(0x01, 0xd1), 0x01 }, + { OV2735_PAGE_REG8(0x01, 0xd2), 0x20 }, + { OV2735_PAGE_REG8(0x01, 0xd3), 0x04 }, + { OV2735_PAGE_REG8(0x01, 0xd4), 0x2a }, + { OV2735_PAGE_REG8(0x01, 0x50), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x51), 0x2c }, + { OV2735_PAGE_REG8(0x01, 0x52), 0x29 }, + { OV2735_PAGE_REG8(0x01, 0x53), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x55), 0x44 }, + { OV2735_PAGE_REG8(0x01, 0x58), 0x29 }, + { OV2735_PAGE_REG8(0x01, 0x5a), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x5b), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x5d), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x64), 0x2f }, + { OV2735_PAGE_REG8(0x01, 0x66), 0x62 }, + { OV2735_PAGE_REG8(0x01, 0x68), 0x5b }, + { OV2735_PAGE_REG8(0x01, 0x75), 0x46 }, + { OV2735_PAGE_REG8(0x01, 0x76), 0x36 }, + { OV2735_PAGE_REG8(0x01, 0x77), 0x4f }, + { OV2735_PAGE_REG8(0x01, 0x78), 0xef }, + { OV2735_PAGE_REG8(0x01, 0x72), 0xcf }, + { OV2735_PAGE_REG8(0x01, 0x73), 0x36 }, + { OV2735_PAGE_REG8(0x01, 0x7d), 0x0d }, + { OV2735_PAGE_REG8(0x01, 0x7e), 0x0d }, + { OV2735_PAGE_REG8(0x01, 0x8a), 0x77 }, + { OV2735_PAGE_REG8(0x01, 0x8b), 0x77 }, + + { OV2735_REG_HS_MIPI, 0x83 }, + { OV2735_REG_MIPI_CTRL5, 0x0b }, + { OV2735_REG_MIPI_CTRL6, 0x14 }, + { OV2735_PAGE_REG8(0x01, 0x9d), 0x40 }, + { OV2735_REG_MIPI_CTRL3, 0x05 }, + { OV2735_REG_MIPI_CTRL2, 0x44 }, + { OV2735_REG_PREPARE, 0x33 }, + { OV2735_REG_R_HS_ZERO, 0x1f }, + { OV2735_REG_TRAIL, 0x45 }, + { OV2735_REG_R_CLK_ZERO, 0x10 }, + { OV2735_REG_MIPI_CTRL7, 0x70 }, + { OV2735_REG_ANALOG_CTRL3, 0xe0 }, + { OV2735_REG_VNCP, 0x7b }, + + /* BLC */ + { OV2735_REG_BLC_GAIN_BLUE, 0x77 }, + { OV2735_REG_BLC_GAIN_GB, 0x77 }, + { OV2735_REG_BLC_GAIN_RED, 0x74 }, + { OV2735_REG_BLC_GAIN_GR, 0x74 }, + { OV2735_REG_BLC_BPC_TH_P, 0xe0 }, + { OV2735_REG_BLC_BPC_TH_N, 0xe0 }, + { OV2735_REG_GB_SUBOFFSET, 0x40 }, + { OV2735_REG_BLUE_SUBOFFSET, 0x40 }, + { OV2735_REG_RED_SUBOFFSET, 0x40 }, + { OV2735_REG_GR_SUBOFFSET, 0x40 }, +}; + +static const struct ov2735_mode supported_modes[] =3D { + { + .width =3D 1920, + .height =3D 1080, + .exp_def =3D 399, + .hts_def =3D 2200, + .vts_def =3D 2545, + .crop =3D { + .top =3D 8, + .left =3D 8, + .width =3D 1920, + .height =3D 1080, + }, + }, +}; + +static const s64 link_freq_menu_items[] =3D { + OV2735_LINK_FREQ_420MHZ, +}; + +struct ov2735_pll_parameters pll_configs[] =3D { + /* For 420MHz pll_configs */ + { + .pll_nc =3D 4, + .pll_mc =3D 0, + .pll_outdiv =3D 1, + }, +}; + +static const char * const ov2735_test_pattern_menu[] =3D { + "Disabled", + "Vertical Color", +}; + +static int ov2735_page_access(struct ov2735 *ov2735, u32 reg, int *err) +{ + u8 page =3D reg >> CCI_REG_PRIVATE_SHIFT; + int ret =3D 0; + + if (err && *err) + return *err; + + mutex_lock(&ov2735->page_lock); + + /* Perform page access before read/write */ + if (ov2735->current_page !=3D page) { + ret =3D cci_write(ov2735->cci, OV2735_REG_PAGE_SELECT, page, err); + if (ret) + goto err_mutex_unlock; + ov2735->current_page =3D page; + } + +err_mutex_unlock: + mutex_unlock(&ov2735->page_lock); + return ret; +} + +static int ov2735_read(struct ov2735 *ov2735, u32 reg, u64 *val, int *err) +{ + u32 addr =3D reg & ~CCI_REG_PRIVATE_MASK; + int ret; + + ret =3D ov2735_page_access(ov2735, reg, err); + if (ret) + return ret; + + return cci_read(ov2735->cci, addr, val, err); +} + +static int ov2735_write(struct ov2735 *ov2735, u32 reg, u64 val, int *err) +{ + u32 addr =3D reg & ~CCI_REG_PRIVATE_MASK; + int ret; + + ret =3D ov2735_page_access(ov2735, reg, err); + if (ret) + return ret; + + return cci_write(ov2735->cci, addr, val, err); +} + +static int ov2735_multi_reg_write(struct ov2735 *ov2735, + const struct cci_reg_sequence *regs, + unsigned int num_regs, int *err) +{ + unsigned int i; + int ret; + + for (i =3D 0; i < num_regs; i++) { + ret =3D ov2735_write(ov2735, regs[i].reg, regs[i].val, err); + if (ret) + return ret; + } + + return 0; +} + +static inline struct ov2735 *to_ov2735(struct v4l2_subdev *_sd) +{ + return container_of(_sd, struct ov2735, sd); +} + +static int ov2735_enable_test_pattern(struct ov2735 *ov2735, u32 pattern) +{ + int ret; + u64 val; + + ret =3D ov2735_read(ov2735, OV2735_REG_TEST_PATTERN, &val, NULL); + if (ret) + return ret; + + switch (pattern) { + case 0: + val &=3D ~OV2735_TEST_PATTERN_ENABLE; + break; + case 1: + val |=3D OV2735_TEST_PATTERN_ENABLE; + break; + } + + return ov2735_write(ov2735, OV2735_REG_TEST_PATTERN, val, NULL); +} + +static int ov2735_set_ctrl(struct v4l2_ctrl *ctrl) +{ + struct ov2735 *ov2735 =3D container_of(ctrl->handler, struct ov2735, + handler); + struct v4l2_mbus_framefmt *fmt; + struct v4l2_subdev_state *state; + u64 vts; + int ret =3D 0; + + state =3D v4l2_subdev_get_locked_active_state(&ov2735->sd); + fmt =3D v4l2_subdev_state_get_format(state, 0); + + if (ctrl->id =3D=3D V4L2_CID_VBLANK) { + /* Honour the VBLANK limits when setting exposure */ + s64 max =3D fmt->height + ctrl->val - 4; + + ret =3D __v4l2_ctrl_modify_range(ov2735->exposure, + ov2735->exposure->minimum, max, + ov2735->exposure->step, + ov2735->exposure->default_value); + if (ret) + return ret; + } + + /* + * Applying V4L2 control value only happens + * when power is up for streaming. + */ + if (pm_runtime_get_if_in_use(ov2735->dev) =3D=3D 0) + return 0; + + switch (ctrl->id) { + case V4L2_CID_EXPOSURE: + ov2735_write(ov2735, OV2735_REG_LONG_EXPOSURE, ctrl->val, &ret); + break; + case V4L2_CID_ANALOGUE_GAIN: + ov2735_write(ov2735, OV2735_REG_ANALOG_GAIN, ctrl->val, &ret); + break; + case V4L2_CID_HBLANK: + ov2735_write(ov2735, OV2735_REG_HBLANK, ctrl->val, &ret); + break; + case V4L2_CID_VBLANK: + vts =3D ctrl->val + fmt->height; + ov2735_write(ov2735, OV2735_REG_FRAME_EXP_SEPERATE_EN, + OV2735_FRAME_EXP_SEPERATE_EN, &ret); + ov2735_write(ov2735, OV2735_REG_FRAME_LENGTH, vts, &ret); + break; + case V4L2_CID_TEST_PATTERN: + ret =3D ov2735_enable_test_pattern(ov2735, ctrl->val); + break; + default: + dev_err(ov2735->dev, "ctrl(id:0x%x, val:0x%x) is not handled\n", + ctrl->id, ctrl->val); + break; + } + ov2735_write(ov2735, OV2735_REG_FRAME_SYNC, 0x01, &ret); + + pm_runtime_put(ov2735->dev); + + return ret; +} + +static const struct v4l2_ctrl_ops ov2735_ctrl_ops =3D { + .s_ctrl =3D ov2735_set_ctrl, +}; + +static int ov2735_init_controls(struct ov2735 *ov2735) +{ + struct v4l2_ctrl_handler *ctrl_hdlr; + struct v4l2_fwnode_device_properties props; + const struct ov2735_mode *mode =3D &supported_modes[0]; + u64 hblank_def, vblank_def, exp_max; + int ret; + + ctrl_hdlr =3D &ov2735->handler; + ret =3D v4l2_ctrl_handler_init(ctrl_hdlr, 9); + if (ret) + return ret; + + ov2735->pixel_rate =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_PIXEL_RATE, 0, OV2735_PIXEL_RATE, + 1, OV2735_PIXEL_RATE); + + ov2735->link_freq =3D v4l2_ctrl_new_int_menu(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_LINK_FREQ, + ov2735->link_freq_index, + 0, link_freq_menu_items); + if (ov2735->link_freq) + ov2735->link_freq->flags |=3D V4L2_CTRL_FLAG_READ_ONLY; + + hblank_def =3D mode->hts_def - mode->width; + ov2735->hblank =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, V4L2_CI= D_HBLANK, + hblank_def, hblank_def, 1, hblank_def); + + vblank_def =3D mode->vts_def - mode->height; + ov2735->vblank =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_VBLANK, vblank_def, + OV2735_VTS_MAX - mode->height, + 1, vblank_def); + + exp_max =3D mode->vts_def - 4; + ov2735->exposure =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_EXPOSURE, OV2735_EXPOSURE_MIN, + exp_max, OV2735_EXPOSURE_STEP, mode->exp_def); + + ov2735->gain =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_ANALOGUE_GAIN, OV2735_ANALOG_GAIN_MIN, + OV2735_ANALOG_GAIN_MAX, OV2735_ANALOG_GAIN_STEP, + OV2735_ANALOG_GAIN_DEFAULT); + + ov2735->test_pattern =3D v4l2_ctrl_new_std_menu_items(ctrl_hdlr, + &ov2735_ctrl_ops, V4L2_CID_TEST_PATTERN, + ARRAY_SIZE(ov2735_test_pattern_menu) - 1, + 0, 0, ov2735_test_pattern_menu); + if (ctrl_hdlr->error) { + ret =3D ctrl_hdlr->error; + dev_err(ov2735->dev, "control init failed (%d)\n", ret); + goto err_handler_free; + } + + ret =3D v4l2_fwnode_device_parse(ov2735->dev, &props); + if (ret) + goto err_handler_free; + + ret =3D v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, + &ov2735_ctrl_ops, &props); + if (ret) + goto err_handler_free; + + ov2735->sd.ctrl_handler =3D ctrl_hdlr; + + return 0; + +err_handler_free: + v4l2_ctrl_handler_free(ctrl_hdlr); + + return ret; +} + +static int ov2735_set_pll_ctrl(struct ov2735 *ov2735) +{ + struct ov2735_pll_parameters *pll_parameters; + u8 pll_ctrl; + u8 pll_outdiv; + int ret =3D 0; + + pll_parameters =3D &pll_configs[ov2735->link_freq_index]; + + /* BIT[7]: pll_clk_sel, BIT[6:2]: pll_nc, BIT[1:0]: pll_mc */ + pll_ctrl =3D ((pll_parameters->pll_nc << 2) | (pll_parameters->pll_mc << = 0)) & + OV2735_REG_PLL_ENABLE; + + pll_outdiv =3D pll_parameters->pll_outdiv; + + ov2735_write(ov2735, OV2735_REG_PLL_CTRL, pll_ctrl, &ret); + ov2735_write(ov2735, OV2735_REG_PLL_OUTDIV, pll_outdiv, &ret); + + return ret; +} + +static int ov2735_set_framefmt(struct ov2735 *ov2735, + struct v4l2_subdev_state *state) +{ + const struct v4l2_mbus_framefmt *format; + const struct v4l2_rect *crop; + int ret =3D 0; + + format =3D v4l2_subdev_state_get_format(state, 0); + crop =3D v4l2_subdev_state_get_crop(state, 0); + + ov2735_write(ov2735, OV2735_REG_V_START, crop->top, &ret); + ov2735_write(ov2735, OV2735_REG_V_SIZE, format->height, &ret); + ov2735_write(ov2735, OV2735_REG_MIPI_LINE_NUMBER, format->height, &ret); + ov2735_write(ov2735, OV2735_REG_H_START, crop->left, &ret); + /* OV2735_REG_H_SIZE: Image half horizontal size */ + ov2735_write(ov2735, OV2735_REG_H_SIZE, (format->width / 2), &ret); + ov2735_write(ov2735, OV2735_REG_MIPI_COLOMN_NUMBER, format->width, &ret); + + return ret; +} + +static int ov2735_enable_streams(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state, u32 pad, + u64 streams_mask) +{ + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret; + + ret =3D pm_runtime_resume_and_get(ov2735->dev); + if (ret < 0) + return ret; + + /* Apply pll settings */ + ret =3D ov2735_set_pll_ctrl(ov2735); + if (ret) { + dev_err(ov2735->dev, "failed to set frame format: %d\n", ret); + goto err_rpm_put; + } + + ret =3D ov2735_multi_reg_write(ov2735, ov2735_common_regs, + ARRAY_SIZE(ov2735_common_regs), NULL); + if (ret) { + dev_err(ov2735->dev, "%s failed to send mfg header\n", __func__); + goto err_rpm_put; + } + + /* Apply format settings */ + ret =3D ov2735_set_framefmt(ov2735, state); + if (ret) { + dev_err(ov2735->dev, "failed to set frame format: %d\n", ret); + goto err_rpm_put; + } + + /* Apply customized values from user */ + ret =3D __v4l2_ctrl_handler_setup(ov2735->sd.ctrl_handler); + if (ret) + goto err_rpm_put; + + /* set stream on register */ + ret =3D ov2735_write(ov2735, OV2735_REG_STREAM_CTRL, OV2735_STREAM_ON, NU= LL); + if (ret) + goto err_rpm_put; + + return 0; + +err_rpm_put: + pm_runtime_put(ov2735->dev); + return ret; +} + +static int ov2735_disable_streams(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state, u32 pad, + u64 streams_mask) +{ + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret; + + /* set stream off register */ + ret =3D ov2735_write(ov2735, OV2735_REG_STREAM_CTRL, OV2735_STREAM_OFF, N= ULL); + if (ret) + dev_err(ov2735->dev, "%s failed to set stream\n", __func__); + + pm_runtime_put(ov2735->dev); + + return ret; +} + +static int ov2735_get_selection(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_selection *sel) +{ + switch (sel->target) { + case V4L2_SEL_TGT_CROP: + sel->r =3D *v4l2_subdev_state_get_crop(sd_state, 0); + return 0; + case V4L2_SEL_TGT_NATIVE_SIZE: + sel->r =3D ov2735_native_area; + return 0; + case V4L2_SEL_TGT_CROP_DEFAULT: + case V4L2_SEL_TGT_CROP_BOUNDS: + sel->r =3D ov2735_active_area; + return 0; + default: + return -EINVAL; + } +} + +static int ov2735_enum_mbus_code(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_mbus_code_enum *code) +{ + if (code->index >=3D 0) + return -EINVAL; + + code->code =3D MEDIA_BUS_FMT_SGRBG10_1X10; + + return 0; +} + +static int ov2735_enum_frame_size(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_frame_size_enum *fse) +{ + u32 code; + + if (fse->index >=3D ARRAY_SIZE(supported_modes)) + return -EINVAL; + + code =3D MEDIA_BUS_FMT_SGRBG10_1X10; + if (fse->code !=3D code) + return -EINVAL; + + fse->min_width =3D supported_modes[fse->index].width; + fse->max_width =3D fse->min_width; + fse->min_height =3D supported_modes[fse->index].height; + fse->max_height =3D fse->min_height; + + return 0; +} + +static void ov2735_set_framing_limits(struct ov2735 *ov2735, + const struct ov2735_mode *mode) +{ + u32 hblank, vblank_def; + + hblank =3D mode->hts_def - mode->width; + __v4l2_ctrl_modify_range(ov2735->hblank, hblank, hblank, 1, hblank); + + vblank_def =3D mode->vts_def - mode->height; + __v4l2_ctrl_modify_range(ov2735->vblank, vblank_def, + OV2735_VTS_MAX - mode->height, 1, vblank_def); +} + +static int ov2735_set_pad_format(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_format *fmt) +{ + struct v4l2_mbus_framefmt *format; + const struct ov2735_mode *mode; + struct v4l2_rect *crop; + struct ov2735 *ov2735 =3D to_ov2735(sd); + + format =3D v4l2_subdev_state_get_format(sd_state, 0); + + mode =3D v4l2_find_nearest_size(supported_modes, + ARRAY_SIZE(supported_modes), + width, height, + fmt->format.width, fmt->format.height); + + fmt->format.width =3D mode->width; + fmt->format.height =3D mode->height; + fmt->format.field =3D V4L2_FIELD_NONE; + fmt->format.colorspace =3D V4L2_COLORSPACE_RAW; + fmt->format.quantization =3D V4L2_QUANTIZATION_FULL_RANGE; + fmt->format.xfer_func =3D V4L2_XFER_FUNC_NONE; + + if (fmt->which =3D=3D V4L2_SUBDEV_FORMAT_ACTIVE) + ov2735_set_framing_limits(ov2735, mode); + + *format =3D fmt->format; + + /* Initialize crop rectangle */ + crop =3D v4l2_subdev_state_get_crop(sd_state, 0); + *crop =3D mode->crop; + + return 0; +} + +static int ov2735_init_state(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state) +{ + struct v4l2_subdev_format fmt =3D { + .which =3D V4L2_SUBDEV_FORMAT_TRY, + .format =3D { + .code =3D MEDIA_BUS_FMT_SGRBG10_1X10, + .width =3D supported_modes[0].width, + .height =3D supported_modes[0].height, + }, + }; + + ov2735_set_pad_format(sd, state, &fmt); + + return 0; +} + +static const struct v4l2_subdev_video_ops ov2735_video_ops =3D { + .s_stream =3D v4l2_subdev_s_stream_helper, +}; + +static const struct v4l2_subdev_pad_ops ov2735_pad_ops =3D { + .enum_mbus_code =3D ov2735_enum_mbus_code, + .get_fmt =3D v4l2_subdev_get_fmt, + .set_fmt =3D ov2735_set_pad_format, + .get_selection =3D ov2735_get_selection, + .enum_frame_size =3D ov2735_enum_frame_size, + .enable_streams =3D ov2735_enable_streams, + .disable_streams =3D ov2735_disable_streams, +}; + +static const struct v4l2_subdev_ops ov2735_subdev_ops =3D { + .video =3D &ov2735_video_ops, + .pad =3D &ov2735_pad_ops, +}; + +static const struct v4l2_subdev_internal_ops ov2735_internal_ops =3D { + .init_state =3D ov2735_init_state, +}; + +static int ov2735_power_on(struct device *dev) +{ + struct v4l2_subdev *sd =3D dev_get_drvdata(dev); + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret; + + gpiod_set_value_cansleep(ov2735->enable_gpio, 0); + /* + * Ensure device is inactive (PWDN high) before enabling power rails. + * As per datasheet, the PWDN pin (named 'enable_gpio' here) should be + * pulled low only after all power rails are stable. + */ + fsleep(3 * USEC_PER_MSEC); + + ret =3D regulator_bulk_enable(ARRAY_SIZE(ov2735_supply_name), + ov2735->supplies); + if (ret) { + dev_err(ov2735->dev, "failed to enable regulators\n"); + return ret; + } + + gpiod_set_value_cansleep(ov2735->enable_gpio, 1); + /* T4: delay from PWDN pulling low to RSTB pulling high */ + fsleep(4 * USEC_PER_MSEC); + + ret =3D clk_prepare_enable(ov2735->xclk); + if (ret) { + dev_err(ov2735->dev, "failed to enable clock\n"); + goto err_regulator_off; + } + + gpiod_set_value_cansleep(ov2735->reset_gpio, 0); + /* T5: delay from RSTB pulling high to first I2C command */ + fsleep(5 * USEC_PER_MSEC); + + return 0; + +err_regulator_off: + regulator_bulk_disable(ARRAY_SIZE(ov2735_supply_name), ov2735->supplies); + return ret; +} + +static int ov2735_power_off(struct device *dev) +{ + struct v4l2_subdev *sd =3D dev_get_drvdata(dev); + struct ov2735 *ov2735 =3D to_ov2735(sd); + + gpiod_set_value_cansleep(ov2735->enable_gpio, 0); + clk_disable_unprepare(ov2735->xclk); + gpiod_set_value_cansleep(ov2735->reset_gpio, 1); + regulator_bulk_disable(ARRAY_SIZE(ov2735_supply_name), ov2735->supplies); + + return 0; +} + +static int ov2735_get_regulators(struct ov2735 *ov2735) +{ + unsigned int i; + + for (i =3D 0; i < ARRAY_SIZE(ov2735_supply_name); i++) + ov2735->supplies[i].supply =3D ov2735_supply_name[i]; + + return devm_regulator_bulk_get(ov2735->dev, + ARRAY_SIZE(ov2735_supply_name), + ov2735->supplies); +} + +static int ov2735_identify_module(struct ov2735 *ov2735) +{ + u64 chip_id; + int ret; + + ret =3D ov2735_read(ov2735, OV2735_REG_CHIPID, &chip_id, NULL); + if (ret) + return dev_err_probe(ov2735->dev, ret, "failed to read chip id %x\n", + OV2735_CHIPID); + + if (chip_id !=3D OV2735_CHIPID) + return dev_err_probe(ov2735->dev, -EIO, "chip id mismatch: %x!=3D%llx\n", + OV2735_CHIPID, chip_id); + + return 0; +} + +static int ov2735_parse_endpoint(struct ov2735 *ov2735) +{ + struct fwnode_handle *fwnode =3D dev_fwnode(ov2735->dev); + struct v4l2_fwnode_endpoint bus_cfg =3D { + .bus_type =3D V4L2_MBUS_CSI2_DPHY, + }; + struct fwnode_handle *ep; + unsigned long link_freq_bitmap; + int ret; + + ep =3D fwnode_graph_get_next_endpoint(fwnode, NULL); + if (!ep) + return dev_err_probe(ov2735->dev, -ENXIO, + "Failed to get next endpoint\n"); + + ret =3D v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg); + fwnode_handle_put(ep); + if (ret) + return ret; + + if (bus_cfg.bus.mipi_csi2.num_data_lanes !=3D 2) { + ret =3D dev_err_probe(ov2735->dev, -EINVAL, + "only 2 data lanes are supported\n"); + goto error_out; + } + + ret =3D v4l2_link_freq_to_bitmap(ov2735->dev, bus_cfg.link_frequencies, + bus_cfg.nr_of_link_frequencies, + link_freq_menu_items, + ARRAY_SIZE(link_freq_menu_items), + &link_freq_bitmap); + if (ret) { + ret =3D dev_err_probe(ov2735->dev, -EINVAL, + "only 420MHz frequency is available\n"); + goto error_out; + } + + ov2735->link_freq_index =3D __ffs(link_freq_bitmap); + +error_out: + v4l2_fwnode_endpoint_free(&bus_cfg); + + return ret; +}; + +static int ov2735_probe(struct i2c_client *client) +{ + struct ov2735 *ov2735; + unsigned int xclk_freq; + int ret; + + ov2735 =3D devm_kzalloc(&client->dev, sizeof(*ov2735), GFP_KERNEL); + if (!ov2735) + return -ENOMEM; + + ov2735->dev =3D &client->dev; + + v4l2_i2c_subdev_init(&ov2735->sd, client, &ov2735_subdev_ops); + ov2735->sd.internal_ops =3D &ov2735_internal_ops; + + ov2735->cci =3D devm_cci_regmap_init_i2c(client, 8); + if (IS_ERR(ov2735->cci)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->cci), + "failed to initialize CCI\n"); + + /* Set Current page to 0 */ + ov2735->current_page =3D 0; + + ret =3D devm_mutex_init(ov2735->dev, &ov2735->page_lock); + if (ret) + return dev_err_probe(ov2735->dev, ret, + "Failed to initialize lock\n"); + + /* Get system clock (xvclk) */ + ov2735->xclk =3D devm_v4l2_sensor_clk_get(ov2735->dev, NULL); + if (IS_ERR(ov2735->xclk)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->xclk), + "failed to get xclk\n"); + + xclk_freq =3D clk_get_rate(ov2735->xclk); + if (xclk_freq !=3D OV2735_XCLK_FREQ) + return dev_err_probe(ov2735->dev, -EINVAL, + "xclk frequency not supported: %u Hz\n", + xclk_freq); + + ret =3D ov2735_get_regulators(ov2735); + if (ret) + return dev_err_probe(ov2735->dev, ret, "failed to get regulators\n"); + + ret =3D ov2735_parse_endpoint(ov2735); + if (ret) + return dev_err_probe(ov2735->dev, ret, + "failed to parse endpoint configuration\n"); + + ov2735->reset_gpio =3D devm_gpiod_get_optional(ov2735->dev, + "reset", GPIOD_OUT_LOW); + if (IS_ERR(ov2735->reset_gpio)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->reset_gpio), + "failed to get reset GPIO\n"); + + ov2735->enable_gpio =3D devm_gpiod_get_optional(ov2735->dev, + "enable", GPIOD_OUT_LOW); + if (IS_ERR(ov2735->enable_gpio)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->enable_gpio), + "failed to get enable GPIO\n"); + + ret =3D ov2735_power_on(ov2735->dev); + if (ret) + return ret; + + ret =3D ov2735_identify_module(ov2735); + if (ret) + goto error_power_off; + + ret =3D ov2735_init_controls(ov2735); + if (ret) + goto error_power_off; + + /* Initialize subdev */ + ov2735->sd.flags |=3D V4L2_SUBDEV_FL_HAS_DEVNODE; + ov2735->sd.entity.function =3D MEDIA_ENT_F_CAM_SENSOR; + ov2735->pad.flags =3D MEDIA_PAD_FL_SOURCE; + + ret =3D media_entity_pads_init(&ov2735->sd.entity, 1, &ov2735->pad); + if (ret) { + dev_err_probe(ov2735->dev, ret, "failed to init entity pads\n"); + goto error_handler_free; + } + + ov2735->sd.state_lock =3D ov2735->handler.lock; + ret =3D v4l2_subdev_init_finalize(&ov2735->sd); + if (ret) { + dev_err_probe(ov2735->dev, ret, "subdev init error\n"); + goto error_media_entity; + } + + ret =3D devm_pm_runtime_get_noresume(ov2735->dev); + if (ret) { + dev_err_probe(ov2735->dev, ret, + "failed to get runtime PM noresume\n"); + goto error_subdev_cleanup; + } + + ret =3D devm_pm_runtime_set_active_enabled(ov2735->dev); + if (ret) { + dev_err_probe(ov2735->dev, ret, + "failed to set runtime PM active+enabled\n"); + goto error_subdev_cleanup; + } + + ret =3D v4l2_async_register_subdev_sensor(&ov2735->sd); + if (ret) { + dev_err_probe(ov2735->dev, ret, + "failed to register ov2735 sub-device\n"); + goto error_subdev_cleanup; + } + + return 0; + +error_subdev_cleanup: + v4l2_subdev_cleanup(&ov2735->sd); + +error_media_entity: + media_entity_cleanup(&ov2735->sd.entity); + +error_handler_free: + v4l2_ctrl_handler_free(ov2735->sd.ctrl_handler); + +error_power_off: + ov2735_power_off(ov2735->dev); + + return ret; +} + +static void ov2735_remove(struct i2c_client *client) +{ + struct v4l2_subdev *sd =3D i2c_get_clientdata(client); + struct ov2735 *ov2735 =3D to_ov2735(sd); + + v4l2_async_unregister_subdev(sd); + v4l2_subdev_cleanup(&ov2735->sd); + media_entity_cleanup(&sd->entity); + v4l2_ctrl_handler_free(ov2735->sd.ctrl_handler); +} + +static DEFINE_RUNTIME_DEV_PM_OPS(ov2735_pm_ops, + ov2735_power_off, ov2735_power_on, NULL); + +static const struct of_device_id ov2735_id[] =3D { + { .compatible =3D "ovti,ov2735" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, ov2735_id); + +static struct i2c_driver ov2735_driver =3D { + .driver =3D { + .name =3D "ov2735", + .pm =3D pm_ptr(&ov2735_pm_ops), + .of_match_table =3D ov2735_id, + }, + .probe =3D ov2735_probe, + .remove =3D ov2735_remove, +}; +module_i2c_driver(ov2735_driver); + +MODULE_DESCRIPTION("OV2735 Camera Sensor Driver"); +MODULE_AUTHOR("Hardevsinh Palaniya = "); +MODULE_AUTHOR("Himanshu Bhavani "); +MODULE_LICENSE("GPL"); --=20 2.34.1