From nobody Fri Dec 19 16:08:15 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A54CD1AF0C8; Wed, 30 Jul 2025 15:22:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888951; cv=none; b=Fw9B+/TAR0CLaQuB4gqcA4dr65qLw5XLzU7nCGvTq6rVdXyGex9ntMeKxDY2ugkpS/VFpr9mWVstsLkC3WOh0mM7jsrtX7t3mpk1r9yxtHChu2jXWl+yM9/LC0LJBWRyOJWJ02uTWC0VG5G8S/vQltPaz+sC/j6zeTCnw0RbIJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888951; c=relaxed/simple; bh=cPTYsX4JtWbb6aA+SrahhA+I0oaokRqbu1BNrJ3xzRk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QaQf8+BqRdgqn0mpPNK+003i7siytW7VeW8Sj+iGUMSfxRNNS1VWq5Vj88rB+QTZHGcaVKZhlumS0QbIXr3kaO6gIM2XyQgil0EUm5o5+0NE096vknIqMzZA0N3RTPnD03by/npBQBkG0iPJ5psd3QFFfSYPklk8r3DMnsXqsn4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=ivjxfbL3; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="ivjxfbL3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1753888947; bh=cPTYsX4JtWbb6aA+SrahhA+I0oaokRqbu1BNrJ3xzRk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ivjxfbL3IgjNp42OxmD6oE5KnRv/CBWH/eOuA71P0MUfPvnWIB4VuWJssWkRHdidK Ygb/XMCAlZJ2Pnnm6Y3Q1+U64V8JbDWM7GyiFpF+ZqbFpsmKxXSgTjhE/DDsknpgFg KY0vyZIxdW/dQPTzJ8sVmUXb7QkgDPPoxlVBap6ekOWGFyzNY3NTTaQNHCTP0bNWPc 7yPv7T4s7sy+T+JACLRIOo13cd/5qSWwiTjriNswIAch+DEAq8Mp7t2Vlh3md9cvv/ FFwJxO0If3QNurjnZLamNeukOZpMRtD0RqZjbXg2xYGERUPGg250jvNll8Ka7TGKrF ++YHwDHTJ2iNg== Received: from laura.lan (unknown [IPv6:2001:b07:646b:e2:41d5:bfd6:7c6f:85ff]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laura.nao) by bali.collaboradmins.com (Postfix) with ESMTPSA id 7E72417E130E; Wed, 30 Jul 2025 17:22:26 +0200 (CEST) From: Laura Nao To: srini@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: wenst@chromium.org, nfraprado@collabora.com, arnd@arndb.de, colin.i.king@gmail.com, u.kleine-koenig@baylibre.com, andrew-ct.chen@mediatek.com, lala.lin@mediatek.com, bchihi@baylibre.com, frank-w@public-files.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, Laura Nao , Krzysztof Kozlowski Subject: [PATCH v2 1/9] dt-bindings: thermal: mediatek: Add LVTS thermal controller support for MT8196 Date: Wed, 30 Jul 2025 17:21:20 +0200 Message-Id: <20250730152128.311109-2-laura.nao@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250730152128.311109-1-laura.nao@collabora.com> References: <20250730152128.311109-1-laura.nao@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add LVTS thermal controller binding for MediaTek MT8196. Acked-by: Krzysztof Kozlowski Signed-off-by: Laura Nao Reviewed-by: AngeloGioacchino Del Regno --- .../thermal/mediatek,lvts-thermal.yaml | 2 ++ .../thermal/mediatek,lvts-thermal.h | 26 +++++++++++++++++++ 2 files changed, 28 insertions(+) diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-therma= l.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.ya= ml index 0259cd3ce9c5..beccdabe110b 100644 --- a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml @@ -26,6 +26,8 @@ properties: - mediatek,mt8192-lvts-mcu - mediatek,mt8195-lvts-ap - mediatek,mt8195-lvts-mcu + - mediatek,mt8196-lvts-ap + - mediatek,mt8196-lvts-mcu =20 reg: maxItems: 1 diff --git a/include/dt-bindings/thermal/mediatek,lvts-thermal.h b/include/= dt-bindings/thermal/mediatek,lvts-thermal.h index ddc7302a510a..0ec8ad184d47 100644 --- a/include/dt-bindings/thermal/mediatek,lvts-thermal.h +++ b/include/dt-bindings/thermal/mediatek,lvts-thermal.h @@ -80,4 +80,30 @@ #define MT8192_AP_MD1 15 #define MT8192_AP_MD2 16 =20 +#define MT8196_MCU_MEDIUM_CPU6_0 0 +#define MT8196_MCU_MEDIUM_CPU6_1 1 +#define MT8196_MCU_DSU2 2 +#define MT8196_MCU_DSU3 3 +#define MT8196_MCU_LITTLE_CPU3 4 +#define MT8196_MCU_LITTLE_CPU0 5 +#define MT8196_MCU_LITTLE_CPU1 6 +#define MT8196_MCU_LITTLE_CPU2 7 +#define MT8196_MCU_MEDIUM_CPU4_0 8 +#define MT8196_MCU_MEDIUM_CPU4_1 9 +#define MT8196_MCU_MEDIUM_CPU5_0 10 +#define MT8196_MCU_MEDIUM_CPU5_1 11 +#define MT8196_MCU_DSU0 12 +#define MT8196_MCU_DSU1 13 +#define MT8196_MCU_BIG_CPU7_0 14 +#define MT8196_MCU_BIG_CPU7_1 15 + +#define MT8196_AP_TOP0 0 +#define MT8196_AP_TOP1 1 +#define MT8196_AP_TOP2 2 +#define MT8196_AP_TOP3 3 +#define MT8196_AP_BOT0 4 +#define MT8196_AP_BOT1 5 +#define MT8196_AP_BOT2 6 +#define MT8196_AP_BOT3 7 + #endif /* __MEDIATEK_LVTS_DT_H */ --=20 2.39.5 From nobody Fri Dec 19 16:08:15 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 390542DCC13; Wed, 30 Jul 2025 15:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888953; cv=none; b=uMKrCYDP38yF+P/hAOhGYrYGJs+12xP+cRt1KP/PbWGeCIYG6cmN4M2cRcW/rOwlm1leCcCCJvs8/OJ3mG+Bvx2RKHtT3U2iTz/8IlaGVGpzWqmF6IS2MotHu9sk4dp+orXPLRdJ9IlKOZG1V++vXOQo/1qKowfv3nfYRdzIwpE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888953; c=relaxed/simple; bh=6yZ3TjDwGcaMED/emvt1bnTeL/8aEu0VXnrMFQ6bTHw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=q6Pk/TCZv6JkQ2iftJ7wJdhcK+jervIkOEU5grNO8+8YXICqSa6/nKW6QSYSu/+wmVJ7iAlIG8sRq3/1u1RN3JuBr2qDI8iKf7bUjQkwp849VRLUcVU/P9/wpJnwRPXrUUuAd+8O9D/wzVIXu2x1S3sqONdUkHkulbshrknnzKk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=FiStfqBj; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="FiStfqBj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1753888949; bh=6yZ3TjDwGcaMED/emvt1bnTeL/8aEu0VXnrMFQ6bTHw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FiStfqBjQKdzp2FvtSeXLBzr6YbBVOSaUzKw+9CLubrL3TnIQetLie1+XPLW7conN LgCYHr7ASveSbaljlXmpWrVJF/TxogEaPYVpu0BzmjsTjEQ9elJRGKeTk4xAuNdVj6 lhXdnUkNin5qsK+mIFcxV/DwNKIzLIUv8uXBTJCSekNphy15WBcEF+lJ71z7DoOcs1 cPMrKOfU71S9pDDVmHB/Da4wjejdN4CsyEi9UjQBpWexGCTY6d4CMfnNULWTyMLOc7 dPgwaBs/x5Q51qDpMTq6+ERPljwb9f3Y3siUB9E0torhUnIH7a2wsludqBWt4FeORD B+71eDmBRO7cw== Received: from laura.lan (unknown [IPv6:2001:b07:646b:e2:41d5:bfd6:7c6f:85ff]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laura.nao) by bali.collaboradmins.com (Postfix) with ESMTPSA id 27CA717E1321; Wed, 30 Jul 2025 17:22:28 +0200 (CEST) From: Laura Nao To: srini@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: wenst@chromium.org, nfraprado@collabora.com, arnd@arndb.de, colin.i.king@gmail.com, u.kleine-koenig@baylibre.com, andrew-ct.chen@mediatek.com, lala.lin@mediatek.com, bchihi@baylibre.com, frank-w@public-files.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, Laura Nao Subject: [PATCH v2 2/9] thermal/drivers/mediatek/lvts: Make number of calibration offsets configurable Date: Wed, 30 Jul 2025 17:21:21 +0200 Message-Id: <20250730152128.311109-3-laura.nao@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250730152128.311109-1-laura.nao@collabora.com> References: <20250730152128.311109-1-laura.nao@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" MT8196/MT6991 use 2-byte eFuse calibration data, whereas other SoCs supported by the driver rely on 3 bytes. Make the number of calibration bytes per sensor configurable, enabling support for SoCs with varying calibration formats. Signed-off-by: Laura Nao Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Fei Shao --- drivers/thermal/mediatek/lvts_thermal.c | 32 +++++++++++++++++-------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/medi= atek/lvts_thermal.c index f4d1e66d7db9..05aa8895ccce 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -96,12 +96,14 @@ =20 #define LVTS_MINIMUM_THRESHOLD 20000 =20 +#define LVTS_MAX_CAL_OFFSETS 3 + static int golden_temp =3D LVTS_GOLDEN_TEMP_DEFAULT; static int golden_temp_offset; =20 struct lvts_sensor_data { int dt_id; - u8 cal_offsets[3]; + u8 cal_offsets[LVTS_MAX_CAL_OFFSETS]; }; =20 struct lvts_ctrl_data { @@ -127,6 +129,7 @@ struct lvts_data { const struct lvts_ctrl_data *lvts_ctrl; const u32 *conn_cmd; const u32 *init_cmd; + int num_cal_offsets; int num_lvts_ctrl; int num_conn_cmd; int num_init_cmd; @@ -711,7 +714,7 @@ static int lvts_calibration_init(struct device *dev, st= ruct lvts_ctrl *lvts_ctrl u8 *efuse_calibration, size_t calib_len) { - int i; + int i, j; u32 gt; =20 /* A zero value for gt means that device has invalid efuse data */ @@ -720,17 +723,18 @@ static int lvts_calibration_init(struct device *dev, = struct lvts_ctrl *lvts_ctrl lvts_for_each_valid_sensor(i, lvts_ctrl_data) { const struct lvts_sensor_data *sensor =3D &lvts_ctrl_data->lvts_sensor[i]; + u32 calib =3D 0; =20 - if (sensor->cal_offsets[0] >=3D calib_len || - sensor->cal_offsets[1] >=3D calib_len || - sensor->cal_offsets[2] >=3D calib_len) - return -EINVAL; + for (j =3D 0; j < lvts_ctrl->lvts_data->num_cal_offsets; j++) { + u8 offset =3D sensor->cal_offsets[j]; + + if (offset >=3D calib_len) + return -EINVAL; + calib |=3D efuse_calibration[offset] << (8 * j); + } =20 if (gt) { - lvts_ctrl->calibration[i] =3D - (efuse_calibration[sensor->cal_offsets[0]] << 0) + - (efuse_calibration[sensor->cal_offsets[1]] << 8) + - (efuse_calibration[sensor->cal_offsets[2]] << 16); + lvts_ctrl->calibration[i] =3D calib; } else if (lvts_ctrl->lvts_data->def_calibration) { lvts_ctrl->calibration[i] =3D lvts_ctrl->lvts_data->def_calibration; } else { @@ -1763,6 +1767,7 @@ static const struct lvts_data mt7988_lvts_ap_data =3D= { .temp_factor =3D LVTS_COEFF_A_MT7988, .temp_offset =3D LVTS_COEFF_B_MT7988, .gt_calib_bit_offset =3D 24, + .num_cal_offsets =3D 3, }; =20 static const struct lvts_data mt8186_lvts_data =3D { @@ -1776,6 +1781,7 @@ static const struct lvts_data mt8186_lvts_data =3D { .temp_offset =3D LVTS_COEFF_B_MT7988, .gt_calib_bit_offset =3D 24, .def_calibration =3D 19000, + .num_cal_offsets =3D 3, }; =20 static const struct lvts_data mt8188_lvts_mcu_data =3D { @@ -1789,6 +1795,7 @@ static const struct lvts_data mt8188_lvts_mcu_data = =3D { .temp_offset =3D LVTS_COEFF_B_MT8195, .gt_calib_bit_offset =3D 20, .def_calibration =3D 35000, + .num_cal_offsets =3D 3, }; =20 static const struct lvts_data mt8188_lvts_ap_data =3D { @@ -1802,6 +1809,7 @@ static const struct lvts_data mt8188_lvts_ap_data =3D= { .temp_offset =3D LVTS_COEFF_B_MT8195, .gt_calib_bit_offset =3D 20, .def_calibration =3D 35000, + .num_cal_offsets =3D 3, }; =20 static const struct lvts_data mt8192_lvts_mcu_data =3D { @@ -1815,6 +1823,7 @@ static const struct lvts_data mt8192_lvts_mcu_data = =3D { .temp_offset =3D LVTS_COEFF_B_MT8195, .gt_calib_bit_offset =3D 24, .def_calibration =3D 35000, + .num_cal_offsets =3D 3, }; =20 static const struct lvts_data mt8192_lvts_ap_data =3D { @@ -1828,6 +1837,7 @@ static const struct lvts_data mt8192_lvts_ap_data =3D= { .temp_offset =3D LVTS_COEFF_B_MT8195, .gt_calib_bit_offset =3D 24, .def_calibration =3D 35000, + .num_cal_offsets =3D 3, }; =20 static const struct lvts_data mt8195_lvts_mcu_data =3D { @@ -1841,6 +1851,7 @@ static const struct lvts_data mt8195_lvts_mcu_data = =3D { .temp_offset =3D LVTS_COEFF_B_MT8195, .gt_calib_bit_offset =3D 24, .def_calibration =3D 35000, + .num_cal_offsets =3D 3, }; =20 static const struct lvts_data mt8195_lvts_ap_data =3D { @@ -1854,6 +1865,7 @@ static const struct lvts_data mt8195_lvts_ap_data =3D= { .temp_offset =3D LVTS_COEFF_B_MT8195, .gt_calib_bit_offset =3D 24, .def_calibration =3D 35000, + .num_cal_offsets =3D 3, }; =20 static const struct of_device_id lvts_of_match[] =3D { --=20 2.39.5 From nobody Fri Dec 19 16:08:15 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B56EA2DE1E3; Wed, 30 Jul 2025 15:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888954; cv=none; b=RdN9jKkTHF97lueNIG0FxNLpf3su+6jWRb1g83KRfrgL5cxXHSTisd3Tlt/xP1EXKS72QCMqbkILVgq4Bat1eCI+wRtSLxsSk53r3T0dXKleWAlFMmg04V7qYyhw7MnLvxfQ03fnMXphxmbG/ujqxpEFOObh135qFsx2AvVtzUg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888954; c=relaxed/simple; bh=GW/BPiYjncxQwEBduf0J/LKc1ZtAsAwkTe1rH5ofBvE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JeDh799p3W95HMmmw3OD+zuwHYr5Li+LlRZC0y3PRPNAs3b2BQppLJ5sZ1YzEJc5RyRYjTLQXOJ2nQwpbAswiQMQqtz2zbTd0PIA6/U36xLJptXwhirwmryXR0WI+GyxTjrlSLs7P7WuLAyARkVlSNmrqiWln2hCNQ9Xb+Aa41Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=eKjOP4Ze; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="eKjOP4Ze" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1753888951; bh=GW/BPiYjncxQwEBduf0J/LKc1ZtAsAwkTe1rH5ofBvE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eKjOP4Zeo1MxPIQU/3t4rWGt9Y3D6+fasAxX5RlFQwM5a1HjbAqRGZEdTCAhLjq1w 4BdpRGgWIz5WppsiLjEv4JGNf0a5ly0RqZQX5H2tq4PoQnbbveuzUNAeHwuqY9vsX5 OIq09nVa90ENFM6JiCXTTYXyMQ+xo8T84KYrhOasyBbt+yNmzJJALvr3ZFxX/yHybL AuVgKFFcdgTR5XM9H95LJr9tdI7OXFPXnAHn9O7Z6ra3xuh9w7AbzP14ZUNeK+dh4u 3AoPq0lAMf3zGLwRXGODadFxMTlSTia8mGUzHzM/AGNoxU06Rp8gIgwdX/rrD0Dz5l jr2/M9FvdLNcw== Received: from laura.lan (unknown [IPv6:2001:b07:646b:e2:41d5:bfd6:7c6f:85ff]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laura.nao) by bali.collaboradmins.com (Postfix) with ESMTPSA id B5F5E17E1511; Wed, 30 Jul 2025 17:22:29 +0200 (CEST) From: Laura Nao To: srini@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: wenst@chromium.org, nfraprado@collabora.com, arnd@arndb.de, colin.i.king@gmail.com, u.kleine-koenig@baylibre.com, andrew-ct.chen@mediatek.com, lala.lin@mediatek.com, bchihi@baylibre.com, frank-w@public-files.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, Laura Nao Subject: [PATCH v2 3/9] thermal/drivers/mediatek/lvts: Guard against zero temp_factor in lvts_raw_to_temp Date: Wed, 30 Jul 2025 17:21:22 +0200 Message-Id: <20250730152128.311109-4-laura.nao@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250730152128.311109-1-laura.nao@collabora.com> References: <20250730152128.311109-1-laura.nao@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a guard against zero temp_factor in lvts_raw_to_temp() to prevent division by zero and ensure safe conversion. Fixes: 6725a29321e4 ("thermal/drivers/mediatek/lvts_thermal: Make coeff con= figurable") Reviewed-by: Chen-Yu Tsai Signed-off-by: Laura Nao Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Fei Shao --- drivers/thermal/mediatek/lvts_thermal.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/medi= atek/lvts_thermal.c index 05aa8895ccce..8398af657ba2 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -284,11 +284,14 @@ static int lvts_raw_to_temp(u32 raw_temp, int temp_fa= ctor) =20 static u32 lvts_temp_to_raw(int temperature, int temp_factor) { - u32 raw_temp =3D ((s64)(golden_temp_offset - temperature)) << 14; + u32 raw_temp; =20 - raw_temp =3D div_s64(raw_temp, -temp_factor); + if (temp_factor =3D=3D 0) + return temperature; =20 - return raw_temp; + raw_temp =3D ((s64)(golden_temp_offset - temperature)) << 14; + + return div_s64(raw_temp, -temp_factor); } =20 static int lvts_get_temp(struct thermal_zone_device *tz, int *temp) @@ -1346,6 +1349,9 @@ static int lvts_probe(struct platform_device *pdev) if (irq < 0) return irq; =20 + if (!lvts_data->temp_factor) + dev_warn(dev, "temp_factor should never be zero; check platform data.\n"= ); + golden_temp_offset =3D lvts_data->temp_offset; =20 ret =3D lvts_domain_init(dev, lvts_td, lvts_data); --=20 2.39.5 From nobody Fri Dec 19 16:08:15 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68AD52DEA6B; Wed, 30 Jul 2025 15:22:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888956; cv=none; b=lmSWuw3LmU0tD4lTYN87xkb6E/WY4dwPWRFwuY4PWRjM0t9CI/hAbyxrwPi2BRD1mw79QoE5Rot+92sOiTJEFn5Q2b/9drJacByByxf8/QYzCKYnUZw+A0B0cB9D7ntxBQExoNGdKsGjroa0wrfRY339a0X2z4PEc8LqRWUycHw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888956; c=relaxed/simple; bh=Q3cA3pX+1WE7CaAypi/uX/17iUDzaFYwPBaN7mhKPzQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pZXV5xvDIbovD8NbwjIRtBv3XYGJhZLJlJIDLlLk8bkg4ZP4QK10Pi09yQkC1dUemeO5U/6SoEzvlPlmJJ/62aJLR0/iMJ/tBS64zwLfRXnAXT5/JSssMaydOeQ9NnTAxD6m2QcEfsn9r46VAoIstaZx1AWqWCYd+LYFUqLaS2k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=BFGf2TEk; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="BFGf2TEk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1753888952; bh=Q3cA3pX+1WE7CaAypi/uX/17iUDzaFYwPBaN7mhKPzQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BFGf2TEkexEMHZ3if4oUDW+fgJ1ItuvC85Rc/VRT+UoW1JcVJCnuJwjdEyiXbb84P bU8MT7aD0YGOrFRSPzb2uG7/n/D8zF1sYjHAvOmwoSAXjWVwRU9Ms3DMhlQmhO1mhP +wp1VGJMXUTqgzdbRQDFIj3I6VfsG9UTl0ZpblAqF0ik3dz8xS/lZjAlw2pkCqg8Nt l0Ki+aeCs1yc03ChHh91RyGjOB5ebXxeV5XV7BO/luVON3H9Nrf/6SXUQm0UxXGC7E Q3x460J3IydAJYT9nNUld6YW15y1/7vAiR0agLKzF+fqvIpoo7bKjfaKHpvmEzd4RS K9GZNXAn3U8Lw== Received: from laura.lan (unknown [IPv6:2001:b07:646b:e2:41d5:bfd6:7c6f:85ff]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laura.nao) by bali.collaboradmins.com (Postfix) with ESMTPSA id 4C38817E15A8; Wed, 30 Jul 2025 17:22:31 +0200 (CEST) From: Laura Nao To: srini@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: wenst@chromium.org, nfraprado@collabora.com, arnd@arndb.de, colin.i.king@gmail.com, u.kleine-koenig@baylibre.com, andrew-ct.chen@mediatek.com, lala.lin@mediatek.com, bchihi@baylibre.com, frank-w@public-files.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, Laura Nao Subject: [PATCH v2 4/9] thermal: mediatek: lvts: Add platform ops to support alternative conversion logic Date: Wed, 30 Jul 2025 17:21:23 +0200 Message-Id: <20250730152128.311109-5-laura.nao@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250730152128.311109-1-laura.nao@collabora.com> References: <20250730152128.311109-1-laura.nao@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Introduce lvts_platform_ops struct to support SoC-specific versions of lvts_raw_to_temp() and lvts_temp_to_raw() conversion functions. This is in preparation for supporting SoCs like MT8196/MT6991, which require a different lvts_temp_to_raw() implementation. Signed-off-by: Laura Nao Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Fei Shao --- drivers/thermal/mediatek/lvts_thermal.c | 46 +++++++++++++++++++++++-- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/medi= atek/lvts_thermal.c index 8398af657ba2..6e4a35ecaf34 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -125,8 +125,14 @@ struct lvts_ctrl_data { continue; \ else =20 +struct lvts_platform_ops { + int (*lvts_raw_to_temp)(u32 raw_temp, int temp_factor); + u32 (*lvts_temp_to_raw)(int temperature, int temp_factor); +}; + struct lvts_data { const struct lvts_ctrl_data *lvts_ctrl; + struct lvts_platform_ops ops; const u32 *conn_cmd; const u32 *init_cmd; int num_cal_offsets; @@ -300,6 +306,7 @@ static int lvts_get_temp(struct thermal_zone_device *tz= , int *temp) struct lvts_ctrl *lvts_ctrl =3D container_of(lvts_sensor, struct lvts_ctr= l, sensors[lvts_sensor->id]); const struct lvts_data *lvts_data =3D lvts_ctrl->lvts_data; + const struct lvts_platform_ops *ops =3D &lvts_data->ops; void __iomem *msr =3D lvts_sensor->msr; u32 value; int rc; @@ -332,7 +339,7 @@ static int lvts_get_temp(struct thermal_zone_device *tz= , int *temp) if (rc) return -EAGAIN; =20 - *temp =3D lvts_raw_to_temp(value & 0xFFFF, lvts_data->temp_factor); + *temp =3D ops->lvts_raw_to_temp(value & 0xFFFF, lvts_data->temp_factor); =20 return 0; } @@ -400,10 +407,11 @@ static int lvts_set_trips(struct thermal_zone_device = *tz, int low, int high) struct lvts_ctrl *lvts_ctrl =3D container_of(lvts_sensor, struct lvts_ctr= l, sensors[lvts_sensor->id]); const struct lvts_data *lvts_data =3D lvts_ctrl->lvts_data; + const struct lvts_platform_ops *ops =3D &lvts_data->ops; void __iomem *base =3D lvts_sensor->base; - u32 raw_low =3D lvts_temp_to_raw(low !=3D -INT_MAX ? low : LVTS_MINIMUM_T= HRESHOLD, + u32 raw_low =3D ops->lvts_temp_to_raw(low !=3D -INT_MAX ? low : LVTS_MINI= MUM_THRESHOLD, lvts_data->temp_factor); - u32 raw_high =3D lvts_temp_to_raw(high, lvts_data->temp_factor); + u32 raw_high =3D ops->lvts_temp_to_raw(high, lvts_data->temp_factor); bool should_update_thresh; =20 lvts_sensor->low_thresh =3D low; @@ -1774,6 +1782,10 @@ static const struct lvts_data mt7988_lvts_ap_data = =3D { .temp_offset =3D LVTS_COEFF_B_MT7988, .gt_calib_bit_offset =3D 24, .num_cal_offsets =3D 3, + .ops =3D { + .lvts_raw_to_temp =3D lvts_raw_to_temp, + .lvts_temp_to_raw =3D lvts_temp_to_raw, + } }; =20 static const struct lvts_data mt8186_lvts_data =3D { @@ -1788,6 +1800,10 @@ static const struct lvts_data mt8186_lvts_data =3D { .gt_calib_bit_offset =3D 24, .def_calibration =3D 19000, .num_cal_offsets =3D 3, + .ops =3D { + .lvts_raw_to_temp =3D lvts_raw_to_temp, + .lvts_temp_to_raw =3D lvts_temp_to_raw, + } }; =20 static const struct lvts_data mt8188_lvts_mcu_data =3D { @@ -1802,6 +1818,10 @@ static const struct lvts_data mt8188_lvts_mcu_data = =3D { .gt_calib_bit_offset =3D 20, .def_calibration =3D 35000, .num_cal_offsets =3D 3, + .ops =3D { + .lvts_raw_to_temp =3D lvts_raw_to_temp, + .lvts_temp_to_raw =3D lvts_temp_to_raw, + } }; =20 static const struct lvts_data mt8188_lvts_ap_data =3D { @@ -1816,6 +1836,10 @@ static const struct lvts_data mt8188_lvts_ap_data = =3D { .gt_calib_bit_offset =3D 20, .def_calibration =3D 35000, .num_cal_offsets =3D 3, + .ops =3D { + .lvts_raw_to_temp =3D lvts_raw_to_temp, + .lvts_temp_to_raw =3D lvts_temp_to_raw, + } }; =20 static const struct lvts_data mt8192_lvts_mcu_data =3D { @@ -1830,6 +1854,10 @@ static const struct lvts_data mt8192_lvts_mcu_data = =3D { .gt_calib_bit_offset =3D 24, .def_calibration =3D 35000, .num_cal_offsets =3D 3, + .ops =3D { + .lvts_raw_to_temp =3D lvts_raw_to_temp, + .lvts_temp_to_raw =3D lvts_temp_to_raw, + } }; =20 static const struct lvts_data mt8192_lvts_ap_data =3D { @@ -1844,6 +1872,10 @@ static const struct lvts_data mt8192_lvts_ap_data = =3D { .gt_calib_bit_offset =3D 24, .def_calibration =3D 35000, .num_cal_offsets =3D 3, + .ops =3D { + .lvts_raw_to_temp =3D lvts_raw_to_temp, + .lvts_temp_to_raw =3D lvts_temp_to_raw, + } }; =20 static const struct lvts_data mt8195_lvts_mcu_data =3D { @@ -1858,6 +1890,10 @@ static const struct lvts_data mt8195_lvts_mcu_data = =3D { .gt_calib_bit_offset =3D 24, .def_calibration =3D 35000, .num_cal_offsets =3D 3, + .ops =3D { + .lvts_raw_to_temp =3D lvts_raw_to_temp, + .lvts_temp_to_raw =3D lvts_temp_to_raw, + } }; =20 static const struct lvts_data mt8195_lvts_ap_data =3D { @@ -1872,6 +1908,10 @@ static const struct lvts_data mt8195_lvts_ap_data = =3D { .gt_calib_bit_offset =3D 24, .def_calibration =3D 35000, .num_cal_offsets =3D 3, + .ops =3D { + .lvts_raw_to_temp =3D lvts_raw_to_temp, + .lvts_temp_to_raw =3D lvts_temp_to_raw, + } }; =20 static const struct of_device_id lvts_of_match[] =3D { --=20 2.39.5 From nobody Fri Dec 19 16:08:15 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3E472DECBD; Wed, 30 Jul 2025 15:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888957; cv=none; b=tyW8bjOj1oNs+G8ypaDkmge0mgr3zlvxKEKKoK9ZwnGigl70zemWaDRRyr/JwRYgIvMEEkI2XcQKEsgOGHJjiUUYvi3INVTVypTRVfvn+EgbFmsfD9SM9uTwAHrd5nOmbzdyYpW4epjhsYdwnqWCE5UGvL4jx8jE2ZH70HEAM/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888957; c=relaxed/simple; bh=nP1axPdaA35vSvt1B38Z0AIa64RQJzj9NXJaUphLIvE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=MmTA3pTvqXf4xgHGgVEck3YygNG+K+iu9od2yoagfqf+UlPxtmiOGjBHQQfvFiLhzhf3aR6VmPuwSN16YAYr9+TxHws/XJeFB2wJkHi9hxeHW6EBDydAX5aySYlxgPVA2ES44D/46wPEWEvo1SQ8n0RS6RHeQJTFdB9M6venATw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=bVk3+Irw; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="bVk3+Irw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1753888954; bh=nP1axPdaA35vSvt1B38Z0AIa64RQJzj9NXJaUphLIvE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bVk3+IrwCjpypp/ItF8K/65hnCBurtXPGXIEfNlEVRoGrzR/OOWNQWMbvw16W0VJF H5B6zG0J6np7C4u8X/Rex2mOL3DpS04e9Rns79GsnH0nSCM8i4YtMXPavjl7tsoXA+ TdQ0/6odoHFsrBkCZWCiyT2gcduaZ2gT0AVK0W6p5ybgyReGtNBsAvf3r5DKEDbLTB 2sFfRgAjVqdK5No4Olk5+SAxUwUPNZNcaWHVFESeA5VZ6Cp5XUlC40oV3njVDhs0YD qXWepfb/JH+607wZFvDNBi65Tim/oSLQUctp/O68KB3c5zqX1/qxBKmfsta2aP4JEB Vm3VhscvFJyGw== Received: from laura.lan (unknown [IPv6:2001:b07:646b:e2:41d5:bfd6:7c6f:85ff]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laura.nao) by bali.collaboradmins.com (Postfix) with ESMTPSA id EE5A417E130E; Wed, 30 Jul 2025 17:22:32 +0200 (CEST) From: Laura Nao To: srini@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: wenst@chromium.org, nfraprado@collabora.com, arnd@arndb.de, colin.i.king@gmail.com, u.kleine-koenig@baylibre.com, andrew-ct.chen@mediatek.com, lala.lin@mediatek.com, bchihi@baylibre.com, frank-w@public-files.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, Laura Nao Subject: [PATCH v2 5/9] thermal/drivers/mediatek/lvts: Add lvts_temp_to_raw variant Date: Wed, 30 Jul 2025 17:21:24 +0200 Message-Id: <20250730152128.311109-6-laura.nao@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250730152128.311109-1-laura.nao@collabora.com> References: <20250730152128.311109-1-laura.nao@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" MT8196/MT6991 require a different version of lvts_temp_to_raw(), specifically the multiplicative inverse of the existing implementation. Introduce a variant of the function with inverted calculation logic to match this requirement. This ensures accurate raw value generation for temperature thresholds, avoiding spurious thermal interrupts or unintended hardware resets on MT8196/MT6991. Signed-off-by: Laura Nao Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Chen-Yu Tsai Reviewed-by: Fei Shao --- drivers/thermal/mediatek/lvts_thermal.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/medi= atek/lvts_thermal.c index 6e4a35ecaf34..750345465f00 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -300,6 +300,18 @@ static u32 lvts_temp_to_raw(int temperature, int temp_= factor) return div_s64(raw_temp, -temp_factor); } =20 +static u32 lvts_temp_to_raw_v2(int temperature, int temp_factor) +{ + u32 raw_temp; + + if (temp_factor =3D=3D 0) + return temperature; + + raw_temp =3D temperature - golden_temp_offset; + + return div_s64((s64)temp_factor << 14, raw_temp); +} + static int lvts_get_temp(struct thermal_zone_device *tz, int *temp) { struct lvts_sensor *lvts_sensor =3D thermal_zone_device_priv(tz); --=20 2.39.5 From nobody Fri Dec 19 16:08:15 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A7C62DAFB7; Wed, 30 Jul 2025 15:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888959; cv=none; b=nijWCLAnSGm9TGoq6A8EO74gJVdwPC8zwj3vQA3epcxQ7jz1IHZIO2h4WQyJmqY96+0ybhKFB7dkFQmFpI4PYFA5wmfxy3HI8a2KeiwNQmZl0qD7wP/85v3tXIiojooLMWMNQ9fZBUqTLejrybnRz6tfo/RiV99+jyNj8Iy+DAA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888959; c=relaxed/simple; bh=6oSrWE7nDKS9ds+QujMt4KJb/Qw7JldrgF69gNyz5KY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DFfxzbQPg9kixPxXHSKI5MBoGeeG8Py9KAI66/CKQOksboqNizUypzBPw4mhaBHnQx/APw6xUkM1Mu34rlKOA0n5NmMycfnt6ocWtXgAamV5GgFXExVRsbzuWJZsyjpGFJE7o2r0K49+XqKLVsFbBltS4ktK3RchIj1WxxJoR3w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=jpJdEhXG; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="jpJdEhXG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1753888955; bh=6oSrWE7nDKS9ds+QujMt4KJb/Qw7JldrgF69gNyz5KY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jpJdEhXGRuIrL69fTsc4htLZucyBZ93eqmUBlok459owKo7F7FhIV7R0SGi45/knG 0wS/7jB1GSqjk4baQleowf+h/bW4CrEuVQVcM6f1C+GjiqAP8zduJ8pL/WjrxU+Ie0 4HBUC0lUBopVVN7sHvyyMP9sJqAvcnDJ4fIQdxeBkZL4DxVZb2YDh1VqrGRZQa1f52 5nNyojdIy/VHkGFkDrKSXWKHrYsIJrh6v7iw9vxtVYs0sNiT2oENAP1GOM/ATYSf8Y XAb2ZAb3yfwX/di0hrv9o9kq6b8pT9QVliAExxNEIuhWsspDjqUPLaCmvEkrb5VAEu 3APHRpGEoUmNw== Received: from laura.lan (unknown [IPv6:2001:b07:646b:e2:41d5:bfd6:7c6f:85ff]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laura.nao) by bali.collaboradmins.com (Postfix) with ESMTPSA id 886F917E1321; Wed, 30 Jul 2025 17:22:34 +0200 (CEST) From: Laura Nao To: srini@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: wenst@chromium.org, nfraprado@collabora.com, arnd@arndb.de, colin.i.king@gmail.com, u.kleine-koenig@baylibre.com, andrew-ct.chen@mediatek.com, lala.lin@mediatek.com, bchihi@baylibre.com, frank-w@public-files.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, Laura Nao Subject: [PATCH v2 6/9] thermal/drivers/mediatek/lvts: Add support for ATP mode Date: Wed, 30 Jul 2025 17:21:25 +0200 Message-Id: <20250730152128.311109-7-laura.nao@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250730152128.311109-1-laura.nao@collabora.com> References: <20250730152128.311109-1-laura.nao@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" MT8196/MT6991 uses ATP (Abnormal Temperature Prevention) mode to detect abnormal temperature conditions, which involves reading temperature data from a dedicated set of registers separate from the ones used for immediate and filtered modes. Add support for ATP mode and its relative registers to ensure accurate temperature readings and proper thermal management on MT8196/MT6991 devices. While at it, convert mode defines to enum. Reviewed-by: Chen-Yu Tsai Signed-off-by: Laura Nao Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Fei Shao --- drivers/thermal/mediatek/lvts_thermal.c | 44 +++++++++++++++++++++---- 1 file changed, 37 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/medi= atek/lvts_thermal.c index 750345465f00..fbe735e4fd77 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -44,6 +44,10 @@ #define LVTS_EDATA01(__base) (__base + 0x0058) #define LVTS_EDATA02(__base) (__base + 0x005C) #define LVTS_EDATA03(__base) (__base + 0x0060) +#define LVTS_ATP0(__base) (__base + 0x0070) +#define LVTS_ATP1(__base) (__base + 0x0074) +#define LVTS_ATP2(__base) (__base + 0x0078) +#define LVTS_ATP3(__base) (__base + 0x007C) #define LVTS_MSR0(__base) (__base + 0x0090) #define LVTS_MSR1(__base) (__base + 0x0094) #define LVTS_MSR2(__base) (__base + 0x0098) @@ -88,9 +92,6 @@ #define LVTS_COEFF_A_MT7988 -204650 #define LVTS_COEFF_B_MT7988 204650 =20 -#define LVTS_MSR_IMMEDIATE_MODE 0 -#define LVTS_MSR_FILTERED_MODE 1 - #define LVTS_MSR_READ_TIMEOUT_US 400 #define LVTS_MSR_READ_WAIT_US (LVTS_MSR_READ_TIMEOUT_US / 2) =20 @@ -101,6 +102,12 @@ static int golden_temp =3D LVTS_GOLDEN_TEMP_DEFAULT; static int golden_temp_offset; =20 +enum lvts_msr_mode { + LVTS_MSR_IMMEDIATE_MODE, + LVTS_MSR_FILTERED_MODE, + LVTS_MSR_ATP_MODE, +}; + struct lvts_sensor_data { int dt_id; u8 cal_offsets[LVTS_MAX_CAL_OFFSETS]; @@ -110,7 +117,7 @@ struct lvts_ctrl_data { struct lvts_sensor_data lvts_sensor[LVTS_SENSOR_MAX]; u8 valid_sensor_mask; int offset; - int mode; + enum lvts_msr_mode mode; }; =20 #define VALID_SENSOR_MAP(s0, s1, s2, s3) \ @@ -211,6 +218,10 @@ static const struct debugfs_reg32 lvts_regs[] =3D { LVTS_DEBUG_FS_REGS(LVTS_EDATA01), LVTS_DEBUG_FS_REGS(LVTS_EDATA02), LVTS_DEBUG_FS_REGS(LVTS_EDATA03), + LVTS_DEBUG_FS_REGS(LVTS_ATP0), + LVTS_DEBUG_FS_REGS(LVTS_ATP1), + LVTS_DEBUG_FS_REGS(LVTS_ATP2), + LVTS_DEBUG_FS_REGS(LVTS_ATP3), LVTS_DEBUG_FS_REGS(LVTS_MSR0), LVTS_DEBUG_FS_REGS(LVTS_MSR1), LVTS_DEBUG_FS_REGS(LVTS_MSR2), @@ -625,6 +636,13 @@ static int lvts_sensor_init(struct device *dev, struct= lvts_ctrl *lvts_ctrl, LVTS_IMMD3(lvts_ctrl->base) }; =20 + void __iomem *atp_regs[] =3D { + LVTS_ATP0(lvts_ctrl->base), + LVTS_ATP1(lvts_ctrl->base), + LVTS_ATP2(lvts_ctrl->base), + LVTS_ATP3(lvts_ctrl->base) + }; + int i; =20 lvts_for_each_valid_sensor(i, lvts_ctrl_data) { @@ -660,8 +678,20 @@ static int lvts_sensor_init(struct device *dev, struct= lvts_ctrl *lvts_ctrl, /* * Each sensor has its own register address to read from. */ - lvts_sensor[i].msr =3D lvts_ctrl_data->mode =3D=3D LVTS_MSR_IMMEDIATE_MO= DE ? - imm_regs[i] : msr_regs[i]; + switch (lvts_ctrl_data->mode) { + case LVTS_MSR_IMMEDIATE_MODE: + lvts_sensor[i].msr =3D imm_regs[i]; + break; + case LVTS_MSR_FILTERED_MODE: + lvts_sensor[i].msr =3D msr_regs[i]; + break; + case LVTS_MSR_ATP_MODE: + lvts_sensor[i].msr =3D atp_regs[i]; + break; + default: + lvts_sensor[i].msr =3D imm_regs[i]; + break; + } =20 lvts_sensor[i].low_thresh =3D INT_MIN; lvts_sensor[i].high_thresh =3D INT_MIN; @@ -911,7 +941,7 @@ static void lvts_ctrl_monitor_enable(struct device *dev= , struct lvts_ctrl *lvts_ u32 sensor_map =3D 0; int i; =20 - if (lvts_ctrl->mode !=3D LVTS_MSR_FILTERED_MODE) + if (lvts_ctrl->mode =3D=3D LVTS_MSR_IMMEDIATE_MODE) return; =20 if (enable) { --=20 2.39.5 From nobody Fri Dec 19 16:08:15 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1018F2E03EF; Wed, 30 Jul 2025 15:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888960; cv=none; b=T6/HnfmmU3iZHlupu6QzQgEITydwrIxCP9FPHBPmXiKaOPhvDT8aqtj2mHyydElRnro6j0OB/NCheChdN/V/ZMCKc3pYGosjlDdNjzB+dzhFrTrtczwZDKTYN0yX0tGKgR9FiKvrEMaQx8Q1WDu8RxCK4vjC53IdwF1LgxI4etc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888960; c=relaxed/simple; bh=SbTOQ2lEB8QIZMUiX91hFJ98ODaTQ+EtuSSw5D5zFFU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AvVHE2FTh5Is8mrLSPpWpwjLhr7ygP2KFClsELNlOSnJq6zroQ4ioff9DdNiEOdGCoASS4Cq+l6GF8qTpuhq/v4vf02ioJU2VzMUuyLsxeNqNCWih85e/kmPUDXHKiDnEazCG0quwbuGqaIsbufWSXDrMRXio3aPHKiE6HO9WN0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=pDU/CzXp; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="pDU/CzXp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1753888957; bh=SbTOQ2lEB8QIZMUiX91hFJ98ODaTQ+EtuSSw5D5zFFU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pDU/CzXp9HMSSQdMTQd1/uZMT0xzlHqCI/2FmovyCTozo32uqDAiRNQyHhTnKPqDE Baf8h2eXqDoYhsPuLzaNPZvr6n7Xh37sPbmePS1zcETFvli5E7WLk7IoJVCMb8VuWh GYMzD4/RSfA5sJ47YADBmQxcPgECsWAfTOA1kgCHLlHsJVSx6stIFOMDDcY9ofSaHW iz87Q7zOW/jUuww2TAt6RB9odh1+dtP3qH/n3iKxVXazNx8+WrcbJHxpBJwy8gWKRr 5ixkV3BhzOYna9BCgnVwT5q+jhvjnu+RRUPVJDQHb6qMa9lIL5xztTfyb1hyrmXifz wqWf63mGQkTBQ== Received: from laura.lan (unknown [IPv6:2001:b07:646b:e2:41d5:bfd6:7c6f:85ff]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laura.nao) by bali.collaboradmins.com (Postfix) with ESMTPSA id 2032017E129D; Wed, 30 Jul 2025 17:22:36 +0200 (CEST) From: Laura Nao To: srini@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: wenst@chromium.org, nfraprado@collabora.com, arnd@arndb.de, colin.i.king@gmail.com, u.kleine-koenig@baylibre.com, andrew-ct.chen@mediatek.com, lala.lin@mediatek.com, bchihi@baylibre.com, frank-w@public-files.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, Laura Nao Subject: [PATCH v2 7/9] thermal/drivers/mediatek/lvts: Support MSR offset for 16-bit calibration data Date: Wed, 30 Jul 2025 17:21:26 +0200 Message-Id: <20250730152128.311109-8-laura.nao@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250730152128.311109-1-laura.nao@collabora.com> References: <20250730152128.311109-1-laura.nao@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On MT8196/MT6991, per-sensor calibration data read from eFuses is 16-bit. When the LVTS controller operates in 16-bit mode, a fixed offset must be added to MSR values during post-processing to obtain correct temperature readings. Introduce a new msr_offset field in lvts_data, program the respective register and apply the offset to the calibration data read from eFuses. Signed-off-by: Laura Nao Reviewed-by: AngeloGioacchino Del Regno --- drivers/thermal/mediatek/lvts_thermal.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/medi= atek/lvts_thermal.c index fbe735e4fd77..a45f18ce85eb 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -44,6 +44,7 @@ #define LVTS_EDATA01(__base) (__base + 0x0058) #define LVTS_EDATA02(__base) (__base + 0x005C) #define LVTS_EDATA03(__base) (__base + 0x0060) +#define LVTS_MSROFT(__base) (__base + 0x006C) #define LVTS_ATP0(__base) (__base + 0x0070) #define LVTS_ATP1(__base) (__base + 0x0074) #define LVTS_ATP2(__base) (__base + 0x0078) @@ -150,6 +151,7 @@ struct lvts_data { int temp_offset; int gt_calib_bit_offset; unsigned int def_calibration; + u16 msr_offset; }; =20 struct lvts_sensor { @@ -218,6 +220,7 @@ static const struct debugfs_reg32 lvts_regs[] =3D { LVTS_DEBUG_FS_REGS(LVTS_EDATA01), LVTS_DEBUG_FS_REGS(LVTS_EDATA02), LVTS_DEBUG_FS_REGS(LVTS_EDATA03), + LVTS_DEBUG_FS_REGS(LVTS_MSROFT), LVTS_DEBUG_FS_REGS(LVTS_ATP0), LVTS_DEBUG_FS_REGS(LVTS_ATP1), LVTS_DEBUG_FS_REGS(LVTS_ATP2), @@ -788,6 +791,8 @@ static int lvts_calibration_init(struct device *dev, st= ruct lvts_ctrl *lvts_ctrl =20 if (gt) { lvts_ctrl->calibration[i] =3D calib; + if (lvts_ctrl->lvts_data->msr_offset) + lvts_ctrl->calibration[i] +=3D lvts_ctrl->lvts_data->msr_offset; } else if (lvts_ctrl->lvts_data->def_calibration) { lvts_ctrl->calibration[i] =3D lvts_ctrl->lvts_data->def_calibration; } else { @@ -1095,6 +1100,17 @@ static int lvts_ctrl_calibrate(struct device *dev, s= truct lvts_ctrl *lvts_ctrl) for (i =3D 0; i < LVTS_SENSOR_MAX; i++) writel(lvts_ctrl->calibration[i], lvts_edata[i]); =20 + /* LVTS_MSROFT : Constant offset applied to MSR values + * for post-processing + * + * Bits: + * + * 20-0 : Constant data added to MSR values + */ + if (lvts_ctrl->lvts_data->msr_offset) + writel(lvts_ctrl->lvts_data->msr_offset, + LVTS_MSROFT(lvts_ctrl->base)); + return 0; } =20 --=20 2.39.5 From nobody Fri Dec 19 16:08:15 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7FDA2DECBD; Wed, 30 Jul 2025 15:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888962; cv=none; b=cMX5ws8DoaNABjCA3Xsz2FOBQuqFsaRLKOrUEKUi4/sR6kbWN25dwayaPCGwdCRcWedpd7dq+m5I/WRlwvhHRRlex+hUD2bwHmD2q+tWwu6cOy93xE319YMYlKJTO7QHtDuqVWFwXSbNvjE6Pqh6edKglEdhGd8QmlUFrIdzURE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888962; c=relaxed/simple; bh=bG3Zd77lA8rW8aZGZDSgujlWfx/S3qWkQS7LOkZRz5s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=R9bla/08gs55xi5KLo0HfR6b12MEcEPTTaZLa6jXkGpoT7zTmK6cQC7NDsDIAo86nu5YfMePDqfPN3/1zCyTI4lJDnx6i7RiYNYpBxfMkSqDW9IrBBGpcPJmr9PWIgMLw+4M9VM8t9vRLlhpkVeWwMuKBAI0FYKwZX08376QFMI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Hjnzs4yT; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Hjnzs4yT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1753888959; bh=bG3Zd77lA8rW8aZGZDSgujlWfx/S3qWkQS7LOkZRz5s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hjnzs4yTsjYdbIKCAswNgH3Dns2ZdVGC3KgevNSxTJ2/SKl4MWpqtMvEaKdo7lDQg oDmZ6ccuh8tEKAB5i3GBYVh32H/Gun3kXWZ/y5m7EhnEy6E9PXuypz8cTgNGjxJtCj z2utndTsUs7ppt5GAjcG3uS74DomnitB679DbZiaE5gao6mJGuOB7jfMG6zwshHStZ 7Aoik5hmAi3xZl47EU/KfnpcFnygowLEXXAd0BAmFXJXX3UvEjE5ieTCpDBE2Ut7oG MIcXDAlY01/nqxxoY9upV98ysSIUorxNuDzBbkojVt96/8HLsUmurhHJWLVslaNVdY ES+H3h29awJug== Received: from laura.lan (unknown [IPv6:2001:b07:646b:e2:41d5:bfd6:7c6f:85ff]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laura.nao) by bali.collaboradmins.com (Postfix) with ESMTPSA id AD6B017E1511; Wed, 30 Jul 2025 17:22:37 +0200 (CEST) From: Laura Nao To: srini@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: wenst@chromium.org, nfraprado@collabora.com, arnd@arndb.de, colin.i.king@gmail.com, u.kleine-koenig@baylibre.com, andrew-ct.chen@mediatek.com, lala.lin@mediatek.com, bchihi@baylibre.com, frank-w@public-files.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, Laura Nao Subject: [PATCH v2 8/9] thermal/drivers/mediatek/lvts_thermal: Add MT8196 support Date: Wed, 30 Jul 2025 17:21:27 +0200 Message-Id: <20250730152128.311109-9-laura.nao@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250730152128.311109-1-laura.nao@collabora.com> References: <20250730152128.311109-1-laura.nao@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add LVTS driver support for MT8196. Signed-off-by: Laura Nao Reviewed-by: AngeloGioacchino Del Regno --- drivers/thermal/mediatek/lvts_thermal.c | 166 ++++++++++++++++++++++++ 1 file changed, 166 insertions(+) diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/medi= atek/lvts_thermal.c index a45f18ce85eb..4e0c0b04fb1e 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -92,6 +92,10 @@ #define LVTS_COEFF_B_MT8195 250460 #define LVTS_COEFF_A_MT7988 -204650 #define LVTS_COEFF_B_MT7988 204650 +#define LVTS_COEFF_A_MT8196 391460 +#define LVTS_COEFF_B_MT8196 -391460 + +#define LVTS_MSR_OFFSET_MT8196 -984 =20 #define LVTS_MSR_READ_TIMEOUT_US 400 #define LVTS_MSR_READ_WAIT_US (LVTS_MSR_READ_TIMEOUT_US / 2) @@ -761,6 +765,39 @@ static int lvts_sensor_init(struct device *dev, struct= lvts_ctrl *lvts_ctrl, * <-----ap--tc#3-----> <-----sensor#7-----> <-----sensor#8-----> * 0x40 | 0x41 | 0x42 | 0x43 | 0x44 | 0x45 | 0x46 | 0x47 | 0x48 * + * MT8196 : + * Stream index map for MCU Domain mt8196 : + * + * <-sensor#1--> <-sensor#0--> <-sensor#3--> <-sensor#2--> + * 0x04 | 0x05 | 0x06 | 0x07 | 0x08 | 0x09 | 0x0A | 0x0B + * + * <-sensor#5--> <-sensor#4--> <-sensor#7--> <-sensor#6--> + * 0x0C | 0x0D | 0x0E | 0x0F | 0x10 | 0x11 | 0x12 | 0x13 + * + * <-sensor#9--> <-sensor#8--> <-sensor#11-> <-sensor#10-> + * 0x14 | 0x15 | 0x16 | 0x17 | 0x18 | 0x19 | 0x1A | 0X1B + * + * <-sensor#13-> <-sensor#12-> <-sensor#15-> <-sensor#14-> + * 0x1C | 0x1D | 0x1E | 0x1F | 0x20 | 0x21 | 0x22 | 0x23 + * + * Stream index map for APU Domain mt8196 : + * + * <-sensor#1--> <-sensor#0--> <-sensor#3--> <-sensor#2--> + * 0x24 | 0x25 | 0x26 | 0x27 | 0x28 | 0x29 | 0x2A | 0x2B + * + * Stream index map for GPU Domain mt8196 : + * + * <-sensor#1--> <-sensor#0--> + * 0x2C | 0x2D | 0x2E | 0x2F + * + * Stream index map for AP Domain mt8196 : + * + * <-sensor#1--> <-sensor#0--> <-sensor#3--> <-sensor#2--> + * 0x30 | 0x31 | 0x32 | 0x33 | 0x34 | 0x35 | 0x36 | 0x37 + * + * <-sensor#5--> <-sensor#4--> <-sensor#6--> <-sensor#7--> + * 0x38 | 0x39 | 0x3A | 0x3B | 0x3C | 0x3D | 0x3E | 0x3F + * * Note: In some cases, values don't strictly follow a little endian order= ing. * The data description gives byte offsets constituting each calibration v= alue * for each sensor. @@ -1829,6 +1866,103 @@ static const struct lvts_ctrl_data mt8195_lvts_ap_d= ata_ctrl[] =3D { } }; =20 +static const struct lvts_ctrl_data mt8196_lvts_mcu_data_ctrl[] =3D { + { + .lvts_sensor =3D { + { .dt_id =3D MT8196_MCU_MEDIUM_CPU6_0, + .cal_offsets =3D { 0x06, 0x07 } }, + { .dt_id =3D MT8196_MCU_MEDIUM_CPU6_1, + .cal_offsets =3D { 0x04, 0x05 } }, + { .dt_id =3D MT8196_MCU_DSU2, + .cal_offsets =3D { 0x0A, 0x0B } }, + { .dt_id =3D MT8196_MCU_DSU3, + .cal_offsets =3D { 0x08, 0x09 } } + }, + VALID_SENSOR_MAP(1, 1, 1, 1), + .offset =3D 0x0, + .mode =3D LVTS_MSR_ATP_MODE, + }, + { + .lvts_sensor =3D { + { .dt_id =3D MT8196_MCU_LITTLE_CPU3, + .cal_offsets =3D { 0x0E, 0x0F } }, + { .dt_id =3D MT8196_MCU_LITTLE_CPU0, + .cal_offsets =3D { 0x0C, 0x0D } }, + { .dt_id =3D MT8196_MCU_LITTLE_CPU1, + .cal_offsets =3D { 0x12, 0x13 } }, + { .dt_id =3D MT8196_MCU_LITTLE_CPU2, + .cal_offsets =3D { 0x10, 0x11 } } + }, + VALID_SENSOR_MAP(1, 1, 1, 1), + .offset =3D 0x100, + .mode =3D LVTS_MSR_ATP_MODE, + }, + { + .lvts_sensor =3D { + { .dt_id =3D MT8196_MCU_MEDIUM_CPU4_0, + .cal_offsets =3D { 0x16, 0x17 } }, + { .dt_id =3D MT8196_MCU_MEDIUM_CPU4_1, + .cal_offsets =3D { 0x14, 0x15 } }, + { .dt_id =3D MT8196_MCU_MEDIUM_CPU5_0, + .cal_offsets =3D { 0x1A, 0x1B } }, + { .dt_id =3D MT8196_MCU_MEDIUM_CPU5_1, + .cal_offsets =3D { 0x18, 0x19 } } + }, + VALID_SENSOR_MAP(1, 1, 1, 1), + .offset =3D 0x200, + .mode =3D LVTS_MSR_ATP_MODE, + }, + { + .lvts_sensor =3D { + { .dt_id =3D MT8196_MCU_DSU0, + .cal_offsets =3D { 0x1E, 0x1F } }, + { .dt_id =3D MT8196_MCU_DSU1, + .cal_offsets =3D { 0x1C, 0x1D } }, + { .dt_id =3D MT8196_MCU_BIG_CPU7_0, + .cal_offsets =3D { 0x22, 0x23 } }, + { .dt_id =3D MT8196_MCU_BIG_CPU7_1, + .cal_offsets =3D { 0x20, 0x21 } } + }, + VALID_SENSOR_MAP(1, 1, 1, 1), + .offset =3D 0x300, + .mode =3D LVTS_MSR_ATP_MODE, + } +}; + +static const struct lvts_ctrl_data mt8196_lvts_ap_data_ctrl[] =3D { + { + .lvts_sensor =3D { + { .dt_id =3D MT8196_AP_TOP0, + .cal_offsets =3D { 0x32, 0x33 } }, + { .dt_id =3D MT8196_AP_TOP1, + .cal_offsets =3D { 0x30, 0x31 } }, + { .dt_id =3D MT8196_AP_TOP2, + .cal_offsets =3D { 0x36, 0x37 } }, + { .dt_id =3D MT8196_AP_TOP3, + .cal_offsets =3D { 0x34, 0x35 } } + }, + VALID_SENSOR_MAP(1, 1, 1, 1), + .offset =3D 0x0, + .mode =3D LVTS_MSR_ATP_MODE, + }, + { + .lvts_sensor =3D { + { .dt_id =3D MT8196_AP_BOT0, + .cal_offsets =3D { 0x3A, 0x3B } }, + { .dt_id =3D MT8196_AP_BOT1, + .cal_offsets =3D { 0x38, 0x39 } }, + { .dt_id =3D MT8196_AP_BOT2, + .cal_offsets =3D { 0x3E, 0x3F } }, + { .dt_id =3D MT8196_AP_BOT3, + .cal_offsets =3D { 0x3C, 0x3D } } + }, + VALID_SENSOR_MAP(1, 1, 1, 1), + .offset =3D 0x100, + .mode =3D LVTS_MSR_ATP_MODE, + } +}; + + static const struct lvts_data mt7988_lvts_ap_data =3D { .lvts_ctrl =3D mt7988_lvts_ap_data_ctrl, .conn_cmd =3D mt7988_conn_cmds, @@ -1972,6 +2106,36 @@ static const struct lvts_data mt8195_lvts_ap_data = =3D { } }; =20 +static const struct lvts_data mt8196_lvts_mcu_data =3D { + .lvts_ctrl =3D mt8196_lvts_mcu_data_ctrl, + .num_lvts_ctrl =3D ARRAY_SIZE(mt8196_lvts_mcu_data_ctrl), + .temp_factor =3D LVTS_COEFF_A_MT8196, + .temp_offset =3D LVTS_COEFF_B_MT8196, + .gt_calib_bit_offset =3D 0, + .def_calibration =3D 14437, + .num_cal_offsets =3D 2, + .msr_offset =3D LVTS_MSR_OFFSET_MT8196, + .ops =3D { + .lvts_raw_to_temp =3D lvts_raw_to_temp, + .lvts_temp_to_raw =3D lvts_temp_to_raw_v2, + } +}; + +static const struct lvts_data mt8196_lvts_ap_data =3D { + .lvts_ctrl =3D mt8196_lvts_ap_data_ctrl, + .num_lvts_ctrl =3D ARRAY_SIZE(mt8196_lvts_ap_data_ctrl), + .temp_factor =3D LVTS_COEFF_A_MT8196, + .temp_offset =3D LVTS_COEFF_B_MT8196, + .gt_calib_bit_offset =3D 0, + .def_calibration =3D 14437, + .num_cal_offsets =3D 2, + .msr_offset =3D LVTS_MSR_OFFSET_MT8196, + .ops =3D { + .lvts_raw_to_temp =3D lvts_raw_to_temp, + .lvts_temp_to_raw =3D lvts_temp_to_raw_v2, + } +}; + static const struct of_device_id lvts_of_match[] =3D { { .compatible =3D "mediatek,mt7988-lvts-ap", .data =3D &mt7988_lvts_ap_da= ta }, { .compatible =3D "mediatek,mt8186-lvts", .data =3D &mt8186_lvts_data }, @@ -1981,6 +2145,8 @@ static const struct of_device_id lvts_of_match[] =3D { { .compatible =3D "mediatek,mt8192-lvts-ap", .data =3D &mt8192_lvts_ap_da= ta }, { .compatible =3D "mediatek,mt8195-lvts-mcu", .data =3D &mt8195_lvts_mcu_= data }, { .compatible =3D "mediatek,mt8195-lvts-ap", .data =3D &mt8195_lvts_ap_da= ta }, + { .compatible =3D "mediatek,mt8196-lvts-mcu", .data =3D &mt8196_lvts_mcu_= data }, + { .compatible =3D "mediatek,mt8196-lvts-ap", .data =3D &mt8196_lvts_ap_da= ta }, {}, }; MODULE_DEVICE_TABLE(of, lvts_of_match); --=20 2.39.5 From nobody Fri Dec 19 16:08:15 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19C682E0B42; Wed, 30 Jul 2025 15:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888963; cv=none; b=CESlktoDR5H6hkg6hrS4ErQfTYLN7Ir8jGgis9E3VqtBUlheeKSML3P0oxR7LCnIEnSP6GNivA2j9J2hUSman5O+tTqjPJEZeWhCkDJ/1yJAS+LAuO7d0fWZb71nn+3yPiTpDuiLlT+hPs213Adx0QeXed9f5AYsZeI+CUExZLY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753888963; c=relaxed/simple; bh=Hn1macxBsiwE8zIVXtjtrzSVv+kL8zbKJT5C2OuAsOM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AbQRX9lWHuMKwbSNXnaC4l7UaEJivWfExPjMB0VD0zerw4HCo9cEN7vqau7Wgj76efMsGQKmnoJOEMXVD0ESAm9XEzxBeAm5r6NtIoHanOGGizBFJqQ6XlY77kj1tSjJ5J4d+Ez3jRZg5bNC7Z0fn4QfdfC5Mifsoi0hMMvm1mg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=d8595H4/; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="d8595H4/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1753888960; bh=Hn1macxBsiwE8zIVXtjtrzSVv+kL8zbKJT5C2OuAsOM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d8595H4/FxuZuk/QCIb+PXEPxoFNt6QxfKgDuQUz6v+RDVaefb8DuTmutdarVe5m3 TSzeC7uLRfMHEBc5jVOhv5RsQVzqCKFWMBG0KogqiIB+29t5n6+AAkYe9T4fci3O2F IrYY8XB61nbZI7Cruy4xymeabhnTudTpybiWQvzpzbFEe14IeSugacbfhJh74TWLas 3j5dIx2G1zenqrO0oDhLQbdZmOqMrTGzScP5N/LrpIPgNTuyKr+hrSbMJL3nXW2B12 kVk3UTX87NubKeMhGNn+YUKMrJa8l0iaTwzcH3X5Y0iOf6aMnE57vPl9flx00hyFSR 65O8mmbhSD5sQ== Received: from laura.lan (unknown [IPv6:2001:b07:646b:e2:41d5:bfd6:7c6f:85ff]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: laura.nao) by bali.collaboradmins.com (Postfix) with ESMTPSA id 4F1F817E1315; Wed, 30 Jul 2025 17:22:39 +0200 (CEST) From: Laura Nao To: srini@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: wenst@chromium.org, nfraprado@collabora.com, arnd@arndb.de, colin.i.king@gmail.com, u.kleine-koenig@baylibre.com, andrew-ct.chen@mediatek.com, lala.lin@mediatek.com, bchihi@baylibre.com, frank-w@public-files.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, Laura Nao Subject: [PATCH v2 9/9] dt-bindings: nvmem: mediatek: efuse: Add support for MT8196 Date: Wed, 30 Jul 2025 17:21:28 +0200 Message-Id: <20250730152128.311109-10-laura.nao@collabora.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250730152128.311109-1-laura.nao@collabora.com> References: <20250730152128.311109-1-laura.nao@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The MT8196 eFuse layout is compatible with MT8186 and shares the same decoding scheme for the gpu-speedbin cell. Signed-off-by: Laura Nao Reviewed-by: AngeloGioacchino Del Regno --- Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/= Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml index 4dc0d42df3e6..455b96c1e1f4 100644 --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml @@ -25,6 +25,7 @@ properties: compatible: oneOf: - items: + - const: mediatek,mt8196-efuse - const: mediatek,mt8188-efuse - const: mediatek,mt8186-efuse - const: mediatek,mt8186-efuse --=20 2.39.5