From nobody Sun Oct 5 20:10:33 2025 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013022.outbound.protection.outlook.com [40.107.162.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE39D298CC4; Wed, 30 Jul 2025 12:59:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.22 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753880385; cv=fail; b=DKJaPnP98adxwjLBW5aEDK2FRyKOVOSTYUwQAvJsq08k4rh88ukD93Jpz47gnsxI+CEViOdik9ld50MWE3rgZaHBMt5pHGTyEuH+tghMygGcPF+BFGBU3/jZKIJ0wK8S17nc/od0CZYobVp9nGKVsrZ0YgO8MPBkQjFo+0Vyppk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753880385; c=relaxed/simple; bh=Y7ixz1sZ+tpPzQ1j5icmuw8oEl2uDHQrbCe69elpUhg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Cdo+szDoF+INtg0hJg++Ci7upJhEr1GIaBKlXKNp9zlcMTz3CGNbbFrXTQCbr1hiL6vMmBROOHUvzy2KzzFq9gKJfgr0Poek4/i6oPD+rkubnQ61Odb7fONvNRGQBJgXHpAw+t27OG5bJX4pDqDF/wU8gBb0kjinBe9IyjO/VMY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=YcylIyN9; arc=fail smtp.client-ip=40.107.162.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="YcylIyN9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tDLVJB1MnKY1XWohDUJE5BqH0FszUtXt8o9JozGIOV1glcrZ5BtzeYjGDPiJEaNY9RYsceyeg8cp+fAycdbpJixeA9mDUgqfsy19i0b4NO0pIWYeyfJpTnopDgrIDrUQDwhWrKsUQMUXR+V+UWrjMTA594Ngy7RxyiHUw3LoPG9kXMzIv2viMfuDDuNfACc4arXawR6b333i6Ynwuprla8QUfi6W9xiehxH6p7Tl1cxrYY5wvHqLnG9FNBIwLSQfPUYIP7qocf7SZpQ/FXR+JHuQA7UQhrhRrdkp+bB7DgRNZAaimwcioTRC08t+8dV0gl4T3RENIkCaxF7hJUQzqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3EcuaBfQB7dyV6rR19GJbMxkDUyxHyRwjKX86ZGQUNY=; b=RyGqLUyhzGXHwtKgkZf1aRdNMYyjSTSESV7i/j59lXO1DAKa8TxiSPoBPysxXn8MKFYZ0N357ge6qVaJ3a/Hb3tghNlU4mQp0Mphv6JyY5/1y3pul1D25TLvMTv4P2bqlj7RcX6VI6jxCw6jHTKDk8BWja8arfTPplbgmgBSuDFlFnTsoibbe8xCSVOa3IRGemI33QPNjSU3HxJIxLoiJM2uMGabjsHgEYMMb+LejvP5e9kJZBkJmWdFmyTQfUHfP0+Jo7fwNOwXXv0z9scfLF70f75F0/G+ipB5Zs4BF/dMNS17Qztk/nA7y/Q/Exr1v1Ins3/MuYusq7/RIelR5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3EcuaBfQB7dyV6rR19GJbMxkDUyxHyRwjKX86ZGQUNY=; b=YcylIyN9wop3d0Ydc3rElpfP40NtJG0wO3PE0Y7kEqHZMslzAHJHEkPmTBVUssr3OPxyuHj34rVRCaEjBuqcKj5eMEs9MLlKhHsDDeI3uLlg20M89pW/v+Va4Zvk3SUkOJ/tZEUPsvD7cf4heJLw2miXGmWTCDoTZCmVXiaPgViCawh5MLxY/1eQ9apBMF4rSeSB0g07gby+FPjiLsCDiUKpjt4oxQxmY6jG2aucbxLRNk580QXnQFJXm4o56sI6jQJ26MNWN156slW2Lj7IqE76hVfMjUCV61CPjpIQFENYMWM1kpCwxkfWGOpbBR0Xfui0dKyfT+GEzXWkwv41yw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV1PR04MB9135.eurprd04.prod.outlook.com (2603:10a6:150:26::19) by AM9PR04MB8763.eurprd04.prod.outlook.com (2603:10a6:20b:40a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.12; Wed, 30 Jul 2025 12:59:39 +0000 Received: from GV1PR04MB9135.eurprd04.prod.outlook.com ([fe80::b1f6:475e:de5d:8442]) by GV1PR04MB9135.eurprd04.prod.outlook.com ([fe80::b1f6:475e:de5d:8442%5]) with mapi id 15.20.8989.011; Wed, 30 Jul 2025 12:59:39 +0000 From: Laurentiu Palcu To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: Laurentiu Palcu , linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] clk: imx95-blk-ctl: Save platform data in imx95_blk_ctl structure Date: Wed, 30 Jul 2025 15:59:30 +0300 Message-Id: <20250730125932.357379-2-laurentiu.palcu@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730125932.357379-1-laurentiu.palcu@oss.nxp.com> References: <20250730125932.357379-1-laurentiu.palcu@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM9P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:21d::15) To GV1PR04MB9135.eurprd04.prod.outlook.com (2603:10a6:150:26::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1PR04MB9135:EE_|AM9PR04MB8763:EE_ X-MS-Office365-Filtering-Correlation-Id: a87c9c24-a537-45d4-4652-08ddcf68f16a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|19092799006|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?i7qiCpXyhXq4gRso6InEVi1og3njASJByFQvzFnde1iusXUr61i4va5uWFOU?= =?us-ascii?Q?Ubv8YWKiubhjOcOfM0/Rmdz9ZoqIRCAB1hK8fAz0nkwM1y6yKQPtOwOIf7Mu?= =?us-ascii?Q?9acJYiDhBh4h9rQ/CLhB2tv6KXXmD2FXxyeT1Vr2olc5JhkoAKOybnecrbFN?= =?us-ascii?Q?qQaeXjlAVSGE5KI+uXTLCpCZINz6ocUVjC7NXSL11bGtGX+2b2CkLzS6wDsj?= =?us-ascii?Q?UEZ8L2kOtTdfOiwiyqWz5I7NgSGeeTb6rbZ+BM9/yw5jPdQ/lxKxiPhvHSqb?= =?us-ascii?Q?egzME1oI0JTRTJRNtk/EeeLG4eAbCmpzEPmijj3XiiVd1X3LXtIjdjZj3VJ4?= =?us-ascii?Q?v+sY7opEXbmhLzEXh4rQmsKzO6yRG9p59QvNNEJjEUHD1MnJ/8mt6BxjwrC7?= =?us-ascii?Q?qtd6xSKhSRKokyIhN8/IaCkZp48fNjeFKukqTfoCczw1Nekad/YNIbpPBR09?= =?us-ascii?Q?KxW3L2X0VmezoFpJkMc6+O4kWtcNY/icO6pi/3c16T4yacs6KN2WbQrLyF8Q?= =?us-ascii?Q?JkMoJqiUK7YvkqARAHsl77wZWqOsVtASk2q+6rZ6d9Jf6g0UASmKpfW8sHPC?= =?us-ascii?Q?5DIvj7Z2WC9wc4M46eDJL+GEkaFyR0ScM9OilAV8tN0UazHZk6xzuyPpEWsH?= =?us-ascii?Q?uqRW5bd5zLNt9fxSHZd0bLQmBGQCLc1x8W2N0Ak5SbSc9MUw9kITcJNpILF5?= =?us-ascii?Q?53/hOzT4is2XqpMpr5gxM5auEKKbe0+KpEW2Ae3QO/dUMFEvqA1Su8QXxSpI?= =?us-ascii?Q?PoYX7J5KSxxvRNx3BY+wvsU3Gr9BqmDgpkR7YX0U8VtADX5D5aq+W3R/bM+5?= =?us-ascii?Q?Ih7jsAJzEpBzyXppNBNwoukFO6DLjiU5a1e5vhPGkv2oWlyi7VHhZ6FcI18u?= =?us-ascii?Q?m1uMAjsHT33+YSO92tbEcEKoX0KLPENCvkaw4jQyhr/LF1u+EjR02yiKDZ+f?= =?us-ascii?Q?JWq3BDO0t7fLoxyfXWEaxZeSwhOZq291NfPEdADxEjNNJUt3xBvSJfIzGvVv?= =?us-ascii?Q?6hSql+S95DJvyZy5Gu/qOwVLEBpRk21zS93VcQ197ViRpVTj+TyxDxeaEBXA?= =?us-ascii?Q?I1O/5T15sc577gWexLS78LtyTeBzQPJ0sAHENQAQwYi7tGv58qfLN36LbXz8?= =?us-ascii?Q?3tV4DnXa3tyDqSODOJxnRyWMZy1h5tAby84T8rB+fj2TNY2Tt1jd2IBdq5bV?= =?us-ascii?Q?T2CWNG56hEg5BygkFbbpy5dQ+D9Q1NUOKA7jjD+KdvNXiB0nbjMk/qsYTZ4S?= =?us-ascii?Q?t9ns18+1CKYdVVXO2L72CbRDJYXzQnPi2wEmIYOwTYdn4O7Ph2EgOEYXGFJs?= =?us-ascii?Q?rSd6Y27QiH8w1n6vMZ/JnK4UDFHaR5WsKB8fVSkDtNdzYXmatdPgFYVs8eda?= =?us-ascii?Q?67RmibBn18kPBYkgMVwm7KAi/J0Tms9W3cIRJmVRHN00EREfcYPqtaEVnTtH?= =?us-ascii?Q?nBWbbhRjiyc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV1PR04MB9135.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(19092799006)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q+AsWoliDh3cggDGk4NgluNZwqZoeRiFJLFe4vbJhtJ/la1cyUuicUU5izqI?= =?us-ascii?Q?VcNJZ6v+2z29U9lgRxfibYJG8uojZDs/woYWbWwRjoCDPeMudd2tPvMhXBKW?= =?us-ascii?Q?12iFdNhdGeI8nRkDHRfWQ8dmEzqUTKLrSMRRk3ZTAh9jdYE6J55PsvSkxpKO?= =?us-ascii?Q?MJ5rZEpygzzItQShnaKJfRvTDSdNO8PtD46JJ6gYQVlYPiNBuF8/E8ERBh5l?= =?us-ascii?Q?KLxuS1GIOQZtq6XRc/Ltm5/6nh5juBGDWiiWDqPefBpP8gQKBywJyfqQbLai?= =?us-ascii?Q?Im4aes+Z8g+xsncwnf5svM465u60K0INetAXpxPsVJ3xee8FMiotG/vss/rr?= =?us-ascii?Q?mrExlNH0/GEJE4RrMC3ZyY7c7o7a6OqlOOaSzF8hoYAvDFbjvh0VWCYwUzNd?= =?us-ascii?Q?Q/fmdf1aCJ4wxuv+WKU1Jqmkul2ydmsayjCUFfwbbvIsVzMwrqPDEycR2bCa?= =?us-ascii?Q?WCop2ulJTN9iuEpPzxTrg5vKpUjz0y7VmwPP7sEyjyFnCYduZjq1/LCHMoZz?= =?us-ascii?Q?okBNTIhMNRJPZL+wojZQ/E2jR7v6Fw5eFA4Sbd+oESMBV/X3kk1RQKYP9xpL?= =?us-ascii?Q?UF2X1EokXiOkoPJyoJ8wpG1aZV1LwDyHn/mAHMYSohfht0kE5hIE5I67/pO9?= =?us-ascii?Q?coHjkMJwdKxAPQUFNqunO+zozL2kUdy9kYs8vt8fI1Q1MazMW3vnS4+bONeI?= =?us-ascii?Q?kCk3wjC0ZAoEl3mxm++DDzHvccIhijtTqYcvu7VYyBHnNSoFpwWXR3ZmsrPt?= =?us-ascii?Q?5L6UFpIpf1GztXxksS8blJMVZzLJeazPaV2uQasJWNWUjoFiGKlx3oC8Z4Id?= =?us-ascii?Q?Zv/I2ZdO7A2iupmy4DEATERLvQTJWQRun13BUIhWKcYSxZ8QLAlcPKB2IHN6?= =?us-ascii?Q?itJWYNk2Mkohc0DEmlTL54hETj6vHQo1CVoziir2QHVoPIs0vpwU2nJ77Hvb?= =?us-ascii?Q?mSZLxE6rDPfMwyc497xpr63BAaDdX6dD/tkSowS+jm6+LGQm7WVPcWWWQOiM?= =?us-ascii?Q?SmgGM6W1vu9N8ZpQWxPOKWv40+tqVHenr5iK+x8GkGx7B9vFfqwYt8Xd8xFp?= =?us-ascii?Q?0CZknwwm8uL8POqhdfpKDSFOnMrq9TJm98V/Xqdjc2PNsTwF8siouwspt1Av?= =?us-ascii?Q?r+M5AE9ydcsw7/cCUPVzmbKV2lxdZ9IOdXGa8RDTSOg8GwaR815jvFL1Fz9R?= =?us-ascii?Q?8G/ZUzE19LLNKToqXqP+FEVJUs0gYhRHdw/54LA/Bc8O2By+2m0t5pyV60WA?= =?us-ascii?Q?DacG8KM6QMlX2EMOJEhWgjSVmYluRn+nS3PLA/4rZr1/mjMuHgL4i4EI2g/R?= =?us-ascii?Q?5T3p0C5GtyxlY5WqgjN4IExOneF8OV5wbwsAeFByQQ7M2dchQ3tfXI5J7T5P?= =?us-ascii?Q?veWMyoaBsJzdCzu0ffeZlgpe+SOBmS8AMzWxUxp5YdTYOj5u0whSObM9c5mn?= =?us-ascii?Q?86lE9LxiDtDCnQ7LOK0+xMjaeuypZqvc3wEJUs1ezwecnql5Kam0OUgSObvs?= =?us-ascii?Q?FO2vxEYpYSTbcTFtrt3FvzGoZkiV9gIjQDviT6PTdTClfiLPqY4+rSgDDB5y?= =?us-ascii?Q?Df1FY0076P5Hswir4RrVGksmJHLSCcNL0Umw9JLUmdqy40MXG42NeQiv3Y5Q?= =?us-ascii?Q?WA=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a87c9c24-a537-45d4-4652-08ddcf68f16a X-MS-Exchange-CrossTenant-AuthSource: GV1PR04MB9135.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 12:59:39.2496 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LFo85hOpr+ayq1JYGS3c7BNI1BFa4qUGaV6DWoeNfwtX3lve1E3FP3tpr/eRx9UQMpjpRexDwukGkPEJhFv1Dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8763 Content-Type: text/plain; charset="utf-8" Add a platform data (pdata) member to struct imx95_blk_ctl to store the result of of_device_get_match_data() during probe to avoid redundant calls in suspend and resume functions. Signed-off-by: Laurentiu Palcu Reviewed-by: Daniel Baluta Reviewed-by: Frank Li --- drivers/clk/imx/clk-imx95-blk-ctl.c | 36 +++++++++++------------------ 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a/drivers/clk/imx/clk-imx95-blk-ctl.c b/drivers/clk/imx/clk-imx9= 5-blk-ctl.c index 7e88877a62451..c72debaf3a60b 100644 --- a/drivers/clk/imx/clk-imx95-blk-ctl.c +++ b/drivers/clk/imx/clk-imx95-blk-ctl.c @@ -36,6 +36,7 @@ struct imx95_blk_ctl { void __iomem *base; /* clock gate register */ u32 clk_reg_restore; + const struct imx95_blk_ctl_dev_data *pdata; }; =20 struct imx95_blk_ctl_clk_dev_data { @@ -349,7 +350,6 @@ static const struct imx95_blk_ctl_dev_data imx94_dispmi= x_csr_dev_data =3D { static int imx95_bc_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - const struct imx95_blk_ctl_dev_data *bc_data; struct imx95_blk_ctl *bc; struct clk_hw_onecell_data *clk_hw_data; struct clk_hw **hws; @@ -379,25 +379,25 @@ static int imx95_bc_probe(struct platform_device *pde= v) return ret; } =20 - bc_data =3D of_device_get_match_data(dev); - if (!bc_data) + bc->pdata =3D of_device_get_match_data(dev); + if (!bc->pdata) return devm_of_platform_populate(dev); =20 - clk_hw_data =3D devm_kzalloc(dev, struct_size(clk_hw_data, hws, bc_data->= num_clks), + clk_hw_data =3D devm_kzalloc(dev, struct_size(clk_hw_data, hws, bc->pdata= ->num_clks), GFP_KERNEL); if (!clk_hw_data) return -ENOMEM; =20 - if (bc_data->rpm_enabled) { + if (bc->pdata->rpm_enabled) { devm_pm_runtime_enable(&pdev->dev); pm_runtime_resume_and_get(&pdev->dev); } =20 - clk_hw_data->num =3D bc_data->num_clks; + clk_hw_data->num =3D bc->pdata->num_clks; hws =3D clk_hw_data->hws; =20 - for (i =3D 0; i < bc_data->num_clks; i++) { - const struct imx95_blk_ctl_clk_dev_data *data =3D &bc_data->clk_dev_data= [i]; + for (i =3D 0; i < bc->pdata->num_clks; i++) { + const struct imx95_blk_ctl_clk_dev_data *data =3D &bc->pdata->clk_dev_da= ta[i]; void __iomem *reg =3D base + data->reg; =20 if (data->type =3D=3D CLK_MUX) { @@ -439,7 +439,7 @@ static int imx95_bc_probe(struct platform_device *pdev) return 0; =20 cleanup: - for (i =3D 0; i < bc_data->num_clks; i++) { + for (i =3D 0; i < bc->pdata->num_clks; i++) { if (IS_ERR_OR_NULL(hws[i])) continue; clk_hw_unregister(hws[i]); @@ -469,14 +469,9 @@ static int imx95_bc_runtime_resume(struct device *dev) static int imx95_bc_suspend(struct device *dev) { struct imx95_blk_ctl *bc =3D dev_get_drvdata(dev); - const struct imx95_blk_ctl_dev_data *bc_data; int ret; =20 - bc_data =3D of_device_get_match_data(dev); - if (!bc_data) - return 0; - - if (bc_data->rpm_enabled) { + if (bc->pdata->rpm_enabled) { ret =3D pm_runtime_get_sync(bc->dev); if (ret < 0) { pm_runtime_put_noidle(bc->dev); @@ -484,7 +479,7 @@ static int imx95_bc_suspend(struct device *dev) } } =20 - bc->clk_reg_restore =3D readl(bc->base + bc_data->clk_reg_offset); + bc->clk_reg_restore =3D readl(bc->base + bc->pdata->clk_reg_offset); =20 return 0; } @@ -492,15 +487,10 @@ static int imx95_bc_suspend(struct device *dev) static int imx95_bc_resume(struct device *dev) { struct imx95_blk_ctl *bc =3D dev_get_drvdata(dev); - const struct imx95_blk_ctl_dev_data *bc_data; - - bc_data =3D of_device_get_match_data(dev); - if (!bc_data) - return 0; =20 - writel(bc->clk_reg_restore, bc->base + bc_data->clk_reg_offset); + writel(bc->clk_reg_restore, bc->base + bc->pdata->clk_reg_offset); =20 - if (bc_data->rpm_enabled) + if (bc->pdata->rpm_enabled) pm_runtime_put(bc->dev); =20 return 0; --=20 2.46.1 From nobody Sun Oct 5 20:10:33 2025 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013046.outbound.protection.outlook.com [40.107.162.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42852299948; Wed, 30 Jul 2025 12:59:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753880388; cv=fail; b=KrRoNwEa7FSxZJqFIieQLLAq982HeV8l2gI78VRl5eHdcnBhIRrB3+o4Wtn4wQE5PcdnpdrpFUXPu+AdnQl97RfK3zi6NBoJrpJQ9+Ek1RRc32nMTb2jBv2a1vm3N/lDxCHQqyaMVC7cfXWMG4pWTfn1+/NARvkHrK8uuysow8E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753880388; c=relaxed/simple; bh=e4nkD0femXnn3zSacotiOYscl6lcz8VxGWvdJtwEmes=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=pgfdukIOXnVbuzd9806EcZwd7+dWFckl2ujizb2VrtyovGUppRS0XQWVNROY/nmYvu0s8uRZa3FrvKoqTveJS80HPXMoL3x5J5qrb9D0a0unzSJFuITyquMkDlTNUrG0HmqjPH7AiwCXmPj3g/fwvBZoQ/3wKiCF1XSs8Fz1Cd4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=AwQCTLz3; arc=fail smtp.client-ip=40.107.162.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="AwQCTLz3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jwIyV4h29Vt8PTjmApxk2ttaph/bl5h/RBCRTB46bzNsl/wcPv/Tt4IZr1XSTyHJV9orqhHNUmo/BuaorVFgNwrV3KUwyqGfltBHRg9jCEeKux8Mtca4bIdLlIYPB+llTtIVxq7qzZ2yQVNIX9oTHxtFKhNWajNTMyfXBOYXL06AhEW+FcK1mEW+GCmHulcGzPG/1rHkQlCr5/2prNp7QfmNrRYagTRp713JnU7MUeGSYWdZEp+pvs0ldHLLcHJEZ1aNoTcVQtuASF8dLA27NKoIx1EgapXhmiutzVTX2bQiz1JXdw/ywWTNwQb+p7Kqwl3FHT2vFKCa5ogF8vo0qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FJ5UZyfPvPThg6jjY6AtLJY4H/CjZX4mK34M8x2TYCQ=; b=Cp3eUgre4r5K2zFIDrHxsKbQ9zcbQLn2c/v4ebo/N3hxhlEeGYUt1SOHS4G5oRnPIGrjsk0yu20+OQniKCtFbmeAiRNKkg4XCi6Lh1Z/MXtQyyecXTMFXFaEjtj2T3Gpo7JsuHhpdWMKv4vdbhrrQm/UH5FpAEEEjovH1/OhpJldVfCE2XURVTvwpmf00vb8UcV1m/easy2iCoSIgny9batMXJGHDTxyr80Ands1ZR1uIpN3IF97wZMV3qNiAzjMwe8Jn++cp9eb6juOXb0QFkh+7cPY0KGcJl3YJfLPlOXeSKgz6/Z2L6zu4qDe2I+mp7Pzla+PdFRwnpmd17aDtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FJ5UZyfPvPThg6jjY6AtLJY4H/CjZX4mK34M8x2TYCQ=; b=AwQCTLz3U0uqVmBbITfsRGb4sph2r8GeiLlcCPtaGb0LrnCAPMHT+y4isGkI7JvuNrxUlsEv1zAIbv3cOxb1zuN6JsJTRoiSvSnG2in45IL+81qFp9tinmj3hLjer7hmSUQh2zHbK2+/KjOHpUjPkQnPamEAgIrf7I/Sz92DbmDiWhfqT3yQu6ianl7VFNX2kiT/fHLp+oq1b7egG01kYMQpRcjPKFLWn8vMudPZMKySQ+EWbEDxEMG6k0xdAaeVsf6DMzxgo0CK/ZQjL8Pk3+aH5X9K9KyVDbPGuO+dxBc50vyaPlCG3WMV6kcYkhIQ9q36yq4ytfAYdt+kPu/dBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from GV1PR04MB9135.eurprd04.prod.outlook.com (2603:10a6:150:26::19) by GV1PR04MB10126.eurprd04.prod.outlook.com (2603:10a6:150:1a5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.27; Wed, 30 Jul 2025 12:59:42 +0000 Received: from GV1PR04MB9135.eurprd04.prod.outlook.com ([fe80::b1f6:475e:de5d:8442]) by GV1PR04MB9135.eurprd04.prod.outlook.com ([fe80::b1f6:475e:de5d:8442%5]) with mapi id 15.20.8989.011; Wed, 30 Jul 2025 12:59:42 +0000 From: Laurentiu Palcu To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: Laurentiu Palcu , linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] clk: imx95-blk-ctl: Save/restore registers when RPM routines are called Date: Wed, 30 Jul 2025 15:59:31 +0300 Message-Id: <20250730125932.357379-3-laurentiu.palcu@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250730125932.357379-1-laurentiu.palcu@oss.nxp.com> References: <20250730125932.357379-1-laurentiu.palcu@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM9P192CA0020.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:21d::25) To GV1PR04MB9135.eurprd04.prod.outlook.com (2603:10a6:150:26::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV1PR04MB9135:EE_|GV1PR04MB10126:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f36c310-97bc-450f-a610-08ddcf68f2fe X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|366016|376014|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6PQdG1VRyc7s1WgFuJpWlp8C+JDF+XFIIvn4FH5N2UZJNqvoebAtgGruRR0T?= =?us-ascii?Q?gzFPBoDEN9hmrXL+QTi0fztcSMbbHvZLy+qijM1VcfqDxHn0Wewbzvr2mwRf?= =?us-ascii?Q?xPsjMz5GIuQsF3lWDm1sSw3KjkMHe0jQwPL72QK80seTpzzlsTvELC0tVn5y?= =?us-ascii?Q?hVqJ/Tgl0xQMtEoa67ffyn30O7YHatTYqQZ/BAE7qC1n/6VFaSQpHYaWWqPZ?= =?us-ascii?Q?nmupocvAvhYQgW3tZZEeKQ99mG1WOwpZhvaKfZgksLoWZwX/h907mKC/73DK?= =?us-ascii?Q?JpGv2GRcsfrr9NAtwC4j+ACSKHjZCZTajH4n6SEHkGBIkSch3agkHEQIQ5tb?= =?us-ascii?Q?fwQqoZ8dVj+LsnJxhv65eDCrJZIoYOqw3DUzLpZhDYfsSLLH9HGZJVBIcmxf?= =?us-ascii?Q?ePagm9RpvYtifvhps8741tGk/p6ubtddmScI+lb9IFziYQ0nDRydmNSempWY?= =?us-ascii?Q?IQZX2Hcj/msrtB09JarrJK/qprDu6HLYaUv5gag/vzmgEryeVZVzUmHBXFGY?= =?us-ascii?Q?DG9twjDN9XfzZQpknSB9gzHTBEhrrto7bBeHRIgjzHs1HKEMWfqMhJDArLoa?= =?us-ascii?Q?3HW0W4GfIWMqJ9y/656FZUqZXH5JfxNqwjNA0UcbjBGZRqaxs9A/frYu160D?= =?us-ascii?Q?P4D6+YqfIovlf3xPlUWhjntPOj81kDxmnypbAB2iqfP9drCqeS+i+Wq4DXJK?= =?us-ascii?Q?UidI66W8Ya7pW6N9NNfdYKkkflbRNQUXwz/tdk5fwN22uYkLRMJ9QDBQE0Aa?= =?us-ascii?Q?flbEJ9VFLp2SeTERcJvMIm6y5ocL3BIB1xieUMaLpC8L4LtP454GO+bKh0JS?= =?us-ascii?Q?KFtMz04DuuI0khTdzMfWOGvInoJufe5+WrigQwlzgDgQKpf1n7X+yfI1WIgM?= =?us-ascii?Q?khnxjedSo9PQPoG8eXBL53V03xbmVLz/E7vVVHWrdAaQEOIF3HoquCjHJDnx?= =?us-ascii?Q?EeXW8gf1C7eDTfPqpnsv3MtXCTP8aQYdvxhBv5qRe6Mi8PTuDXYOpv9d9Ygf?= =?us-ascii?Q?4gRmV2dLeu8fzzQyxHMPDBNSkDn1nZdrPoekeqYb7x2YujLaX9rhAt6NEU/o?= =?us-ascii?Q?LQA43aPJRNtFagY+oA7hk1H014LVVRhk95S0hsRyhDHw0EIbPgSo0i+OvOQ7?= =?us-ascii?Q?xgRXHvdfGmf+EVRqNMVnbbKVO7t1LgxxrCMIY72Hv5JP4VqqYGGz09/2c8dm?= =?us-ascii?Q?2r7p7bJ2jTrJsR6uIGpx9cuuhLZrgR/x1gx4Gu3Ced++ndbpBMAVFxlPE/CN?= =?us-ascii?Q?msD6FJVJA1RlB+2dfND37qUfFcLWp6NDAryMO3zlkhvg5tQNakIFtLVKVfEs?= =?us-ascii?Q?eF/8NSs6a73sKa7gKO31xMiTICkaXBEmFzopO0JZZ2nCqNbCWdSlFRn3JnMO?= =?us-ascii?Q?hrnFgijlLSl0xDEzmTgKGC4RuwqzYYJxXNk0eRKnLEluCe+V8RBEgeDpTH8M?= =?us-ascii?Q?oCBI9hRVw0I=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV1PR04MB9135.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(366016)(376014)(7416014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KluOZeLtS96o2g/GkvUP4fk6/CrFGjaZyOr3I11d1sMpyKB3ljB+IST8MXs+?= =?us-ascii?Q?CV698m/yrBUb0JtSU+SsZopZVxChQEAlaq7Tsa7x7+7H/m53BgyrhEJtCVI6?= =?us-ascii?Q?4hInhBkIOrsAFbwa9jMc9+OyFvSHN6WyHiPJjcq6pEEuuO5ThEFYdr4w3f37?= =?us-ascii?Q?QIkDRoxMDfI14qhtHbYD6UPWj/SUPzkd2YdnScvN8Y7kGzQan+dwt08Y3ZFZ?= =?us-ascii?Q?wno38U2o0cCsVGvszdbs764+wz+dS/P0QigsnF6hNYRWZL45EiDbipDfPgWM?= =?us-ascii?Q?sKBhbhulylk0gUdr+/B1XbjZxLNnNReh/fBlgmXwJxU0UwWoEXnBdYmV2WHv?= =?us-ascii?Q?lLmvvbZHsQXfj8RXMEm0YzDu4EWjYNoqQBU2op9kBqW+KvDIHbhGLeKDj2qZ?= =?us-ascii?Q?QkB/TeES/OGQVc+r4wtPcTO37I2RIt3YFY4jrf2zjQMduE2oqoywKOsTQmde?= =?us-ascii?Q?B7I++AAxzqHKcojzzZ7ybC1b3nFOFsWdeQ2ZgNFdAuU0u1n0Wo431mzrP0pH?= =?us-ascii?Q?RsFJ6OIM/Ufua9i94h61lELWfj8I+hOwqJMgvVVEAE+vHtxEOVU1w+8LeoC3?= =?us-ascii?Q?9y/FWeU8aaOeVKJlm8ipUSXTSh951gYfpyzUJUrvuOTbhKUsQUbVa5K+LnS1?= =?us-ascii?Q?IC0wrLU8OlNHh+0paBunpB+uxkqbK+udlUXHE32Lw1hYTVHQu+g+SO+RGvUZ?= =?us-ascii?Q?RlMepCLdhpwDqGKjmIsLNgkvkfiZkCQ99zfs8JkEo1CZ4j3XS6djc6mLDd0Y?= =?us-ascii?Q?mrYOETix5AmChym/+rdhOBvfOVmb9bES/1r+J1BNofARH2pOhJbC3apJs/bd?= =?us-ascii?Q?QCX8wasHnho6Ee3TnDfdqr31uvD4Dp2ymXy2Wnvaw1wz6wkNxEH/zDWozzpJ?= =?us-ascii?Q?mNPKf0rj+AzJE9TTs8IvrG3QMxI3WFnuiafu9e4aYFtB8pBc7lZZ0I84V4R3?= =?us-ascii?Q?jNHV9c4n7xprI4dXFXIvhqRI4uXrqjdj+q475IrH7mmCQjT2tMqhBw4F2PNR?= =?us-ascii?Q?VP/e3E4/9RFSO9kMjyEqfnO/Zgxu5L8hOqri5NQCiFN9wLWIOyg2a1OLod7g?= =?us-ascii?Q?UqFf63P94DdQx7NYdYrZRohx37wVkTtVf6n30cKPbHZFcTCLXgUzDQy4hIl8?= =?us-ascii?Q?ZOjzdHaNLmK07rgKFxg1E+SB3OOJi1xD0xTVhxOD3uHAsZx9qQUt+yVM53S9?= =?us-ascii?Q?ZnxtDKdRSFsqoLLOXa3awLQe4lQbYR4EWbzp8ppOddgg4DBdtPkxieQ1iEGK?= =?us-ascii?Q?PRwFyxpl2DDq/W+2JF5c+disObEWfDn4JRt/Un2J0uHdp7qXua8aSvtoxcBt?= =?us-ascii?Q?R0TMN96WKWi6eStAfVUbJYaEQG/DyqWA0mmDVZu43FFY30xNS0p6WPW/yeHu?= =?us-ascii?Q?jXGM/QyDv9xQphRuu93J+YAjZyp6z2YB5eStoQS9qJibbC6628u8sFDpSYfv?= =?us-ascii?Q?dtEVNw0PiGpogIKuT/obWbTYYT9fhRkUUD5ESsZ1PZgmSIjKxTjF99Jgf5wM?= =?us-ascii?Q?JpKYSeNE3T4kmXjDr+Onde2ZQ12o+8Muqu9AO9A2pBcUPmXqiQIT2i2td/H0?= =?us-ascii?Q?/kf3QZhtmJGoYCWhpJ3ICBi7bLmzaFv6/rxY72P8vfuMMWPDYPnPMw3orncU?= =?us-ascii?Q?+Q=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f36c310-97bc-450f-a610-08ddcf68f2fe X-MS-Exchange-CrossTenant-AuthSource: GV1PR04MB9135.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2025 12:59:41.9399 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qO6W3Gbz1Vz5eprW8HyV196A6FXipaPEPzHZwW44zwr7Q0jI6zarlO3DHuKuDSf0GPnFNgqDl7ymv9QzYIFe7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB10126 Content-Type: text/plain; charset="utf-8" If runtime PM is used for the clock providers and they're part of a power domain, then the power domain supply will be cut off when runtime suspended. That means all BLK CTL registers belonging to that power domain will be reset. Save the registers, then, before entering suspend and restore them in resume. Also, fix the suspend/resume routines and make sure we disable/enable the clock correctly. Signed-off-by: Laurentiu Palcu --- drivers/clk/imx/clk-imx95-blk-ctl.c | 33 ++++++++++++++++++----------- 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/drivers/clk/imx/clk-imx95-blk-ctl.c b/drivers/clk/imx/clk-imx9= 5-blk-ctl.c index c72debaf3a60b..56bed44719954 100644 --- a/drivers/clk/imx/clk-imx95-blk-ctl.c +++ b/drivers/clk/imx/clk-imx95-blk-ctl.c @@ -453,15 +453,24 @@ static int imx95_bc_runtime_suspend(struct device *de= v) { struct imx95_blk_ctl *bc =3D dev_get_drvdata(dev); =20 + bc->clk_reg_restore =3D readl(bc->base + bc->pdata->clk_reg_offset); clk_disable_unprepare(bc->clk_apb); + return 0; } =20 static int imx95_bc_runtime_resume(struct device *dev) { struct imx95_blk_ctl *bc =3D dev_get_drvdata(dev); + int ret; =20 - return clk_prepare_enable(bc->clk_apb); + ret =3D clk_prepare_enable(bc->clk_apb); + if (ret) + return ret; + + writel(bc->clk_reg_restore, bc->base + bc->pdata->clk_reg_offset); + + return 0; } #endif =20 @@ -469,17 +478,12 @@ static int imx95_bc_runtime_resume(struct device *dev) static int imx95_bc_suspend(struct device *dev) { struct imx95_blk_ctl *bc =3D dev_get_drvdata(dev); - int ret; =20 - if (bc->pdata->rpm_enabled) { - ret =3D pm_runtime_get_sync(bc->dev); - if (ret < 0) { - pm_runtime_put_noidle(bc->dev); - return ret; - } - } + if (pm_runtime_suspended(dev)) + return 0; =20 bc->clk_reg_restore =3D readl(bc->base + bc->pdata->clk_reg_offset); + clk_disable_unprepare(bc->clk_apb); =20 return 0; } @@ -487,11 +491,16 @@ static int imx95_bc_suspend(struct device *dev) static int imx95_bc_resume(struct device *dev) { struct imx95_blk_ctl *bc =3D dev_get_drvdata(dev); + int ret; =20 - writel(bc->clk_reg_restore, bc->base + bc->pdata->clk_reg_offset); + if (pm_runtime_suspended(dev)) + return 0; =20 - if (bc->pdata->rpm_enabled) - pm_runtime_put(bc->dev); + ret =3D clk_prepare_enable(bc->clk_apb); + if (ret) + return ret; + + writel(bc->clk_reg_restore, bc->base + bc->pdata->clk_reg_offset); =20 return 0; } --=20 2.46.1