From nobody Sun Oct 5 20:11:54 2025 Received: from sender6.mail.selcloud.ru (sender6.mail.selcloud.ru [5.8.75.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C3C646447; Tue, 29 Jul 2025 19:06:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=5.8.75.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753815992; cv=none; b=h94Yg1GLhlKOb8UKNBycszXmiYrj0dEW4/6V5XlkFfT91bnkMwP8ul2ETLetqCwb1u3ZumnmB1qMXsx4boSE1Xoeh2N9VL/fbfK5IooIu+i8mHvLEu33PBEQeoZ1POZjJBquM6k/ciq4Dvlo1bTZuZFYKcMT+zSnqmH+lZqqCvE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753815992; c=relaxed/simple; bh=+GaupTqSCjbeFEvw5Jk6GGk1W1IENNrlN8kSLyAKUTo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fgD5qw8Ajqqlaf9pO6z8sSQi0fNKB2FzAFXgUfVyjxYCeNsXz14KmCKnATw2nzH/s4AJgu7GvhNMUe2I8NVpZmd8yf85oyUxsgAyhJAyz9J6G+dQNWZ0XxN4oO1P3SpETXnKeMPvN8l+PG4/dowIyY2cpGxzUdLLFtJp4AkuIU8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foxido.dev; spf=pass smtp.mailfrom=mail.selcloud.ru; dkim=pass (1024-bit key) header.d=mail.selcloud.ru header.i=@mail.selcloud.ru header.b=cWaLt6IH; dkim=pass (1024-bit key) header.d=foxido.dev header.i=@foxido.dev header.b=NJMjP+m2; dkim=fail (2048-bit key) header.d=foxido.dev header.i=@foxido.dev header.b=xNdfUu/J reason="signature verification failed"; arc=none smtp.client-ip=5.8.75.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foxido.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mail.selcloud.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mail.selcloud.ru header.i=@mail.selcloud.ru header.b="cWaLt6IH"; dkim=pass (1024-bit key) header.d=foxido.dev header.i=@foxido.dev header.b="NJMjP+m2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=foxido.dev header.i=@foxido.dev header.b="xNdfUu/J" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.selcloud.ru; s=selcloud; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:Cc:To:From:List-id:List-Unsubscribe:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Help:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fZLtxJxccotz6SHSOldtB6ck/NMsEGIi3fSCgwF03tY=; t=1753815988; x=1753988788; b=cWaLt6IHoaeTul5OXw0cv798u8I8B+psUnRw9T1ED+lS2IGQuFXRLdVqqFqvtq2r7vyuM7KuYL vSXvp+0AUtXnP46oua651IPPM+wXWA1vRlC/2Z7JYAN6fpIogGfJRHDwggjzMpslAMYLaduGdMQIT Aise0j0eVAMdUZkwpDPs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=foxido.dev; s=selcloud; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject :Cc:To:From:List-id:List-Unsubscribe:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=fZLtxJxccotz6SHSOldtB6ck/NMsEGIi3fSCgwF03tY=; t=1753815988; x=1753988788; b=NJMjP+m2qWJtMPB5gDvOXanp2pSZasFJJ2a2+6YRZnCCWR5 EEze6pP47/FHXAxH7MyRWJ4Xz8tMbR0LUgeFYqTDhfrNlY+OctEwFHMHwBAPG8NPKTq6J9Kj+zfEL NMlbXPqD7BrUa/VMSG9X1qT+iXgFy9lBt74rKOGG36AKYnc=; Precedence: bulk X-Issuen: 1118611 X-User: 280060488 X-Postmaster-Msgtype: 3849 Feedback-ID: 1118611:15965:3849:samotpravil X-From: foxido.dev X-from-id: 15965 X-MSG-TYPE: bulk List-Unsubscribe-Post: List-Unsubscribe=One-Click X-blist-id: 3849 X-Gungo: 20250728.224157 X-SMTPUID: mlgnr60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxido.dev; s=dkim; t=1753815973; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding; bh=ry9b4jvpXnBWI4/HJV5u1m2bDrfUO+pkxJci9GRZHCw=; b=xNdfUu/Jf3bQFn6+GmMI1Z9Btt/+FwRyHrySPhqqbVE0DjRJEUWc5a2659YXp0ba/luIP8 MqljvPwrO/Mc+kqmgWgE7XBEOPEZYSHYwIdbo5nIhqRbsiAU3R2q0PZ7rr8vM9FLIA01Mo Z0iOrrZhfgEXfupv4FzVBu0n6segBEn9SUAK+NJYq9NxrWpOMOIYhYDPlfhN2cV4lAbGBj f5yawsmAtPhhZkzIxs1F2Cpok15yH3iBw/mk1dLlY/nFR+nCwvJ9pPesqN1kuwPa9kEyl4 xi3eBJxex1IIlWHL6O9ZJSfAUT5sQMqOF/RgmboWRzqXApLwlBQ7v69cy0i/lw== From: Gladyshev Ilya To: foxido@foxido.dev Cc: w_armin@gmx.de, linux-input@vger.kernel.org, nikita.nikita.krasnov@gmail.com, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v2] platform/x86: Add WMI driver for Redmibook keyboard. Date: Tue, 29 Jul 2025 22:05:21 +0300 Message-ID: <20250729190528.8446-1-foxido@foxido.dev> X-Mailer: git-send-email 2.50.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This driver implements support for various Fn keys (like Cut) and Xiaomi specific AI button. Signed-off-by: Gladyshev Ilya --- Changes from v1: - Use sparse-keymap instead of manual matching - Fix GUID case so it actually autoloads - Other fixes from v1 review Link to v1: https://lore.kernel.org/platform-driver-x86/20250727223516.2924= 4-1-foxido@foxido.dev/ --- MAINTAINERS | 6 ++ drivers/platform/x86/Kconfig | 11 +++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/redmi-wmi.c | 129 +++++++++++++++++++++++++++++++ 4 files changed, 147 insertions(+) create mode 100644 drivers/platform/x86/redmi-wmi.c diff --git a/MAINTAINERS b/MAINTAINERS index c0b444e5fd5a..eb25fb10e751 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20965,6 +20965,12 @@ S: Maintained T: git https://github.com/pkshih/rtw.git F: drivers/net/wireless/realtek/rtw89/ =20 +REDMIBOOK WMI DRIVERS +M: Gladyshev Ilya +L: platform-driver-x86@vger.kernel.org +S: Maintained +F: drivers/platform/x86/redmi-wmi.c + REDPINE WIRELESS DRIVER L: linux-wireless@vger.kernel.org S: Orphan diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index e5cbd58a99f3..3c570cb398d3 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -109,6 +109,17 @@ config XIAOMI_WMI To compile this driver as a module, choose M here: the module will be called xiaomi-wmi. =20 +config REDMI_WMI + tristate "Redmibook WMI key driver" + depends on ACPI_WMI + depends on INPUT + help + Say Y here if you want support for WMI-based hotkey events on + Xiaomi Redmibook devices. + + To compile this driver as a module, choose M here: the module will + be called redmi-wmi. + config GIGABYTE_WMI tristate "Gigabyte WMI temperature driver" depends on ACPI_WMI diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile index bea87a85ae75..406dd0807ba7 100644 --- a/drivers/platform/x86/Makefile +++ b/drivers/platform/x86/Makefile @@ -13,6 +13,7 @@ obj-$(CONFIG_HUAWEI_WMI) +=3D huawei-wmi.o obj-$(CONFIG_MXM_WMI) +=3D mxm-wmi.o obj-$(CONFIG_NVIDIA_WMI_EC_BACKLIGHT) +=3D nvidia-wmi-ec-backlight.o obj-$(CONFIG_XIAOMI_WMI) +=3D xiaomi-wmi.o +obj-$(CONFIG_REDMI_WMI) +=3D redmi-wmi.o obj-$(CONFIG_GIGABYTE_WMI) +=3D gigabyte-wmi.o =20 # Acer diff --git a/drivers/platform/x86/redmi-wmi.c b/drivers/platform/x86/redmi-= wmi.c new file mode 100644 index 000000000000..732688fb94e0 --- /dev/null +++ b/drivers/platform/x86/redmi-wmi.c @@ -0,0 +1,129 @@ +// SPDX-License-Identifier: GPL-2.0 +/* WMI driver for Xiaomi Redmibooks */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#define WMI_REDMIBOOK_KEYBOARD_EVENT_GUID "46C93E13-EE9B-4262-8488-563BCA7= 57FEF" + +#define AI_KEY_VALUE_MASK 0x00000100 + +static const struct key_entry redmi_wmi_keymap[] =3D { + {KE_KEY, 0x00000201, {KEY_SELECTIVE_SCREENSHOT}}, + {KE_KEY, 0x00000301, {KEY_ALL_APPLICATIONS}}, + {KE_KEY, 0x00001b01, {KEY_SETUP}}, + + /* AI button has code for each position */ + {KE_KEY, 0x00011801, {KEY_ASSISTANT}}, + {KE_KEY, 0x00011901, {KEY_ASSISTANT}}, + + /* Keyboard backlight */ + {KE_IGNORE, 0x00000501, {}}, + {KE_IGNORE, 0x00800501, {}}, + {KE_IGNORE, 0x00050501, {}}, + {KE_IGNORE, 0x000a0501, {}}, + + {KE_END} +}; + +struct redmi_wmi { + struct input_dev *input_dev; + /* Protects the key event sequence */ + struct mutex key_lock; +}; + +static int redmi_wmi_probe(struct wmi_device *wdev, const void *context) +{ + struct redmi_wmi *data; + int err; + + /* Init dev */ + data =3D devm_kzalloc(&wdev->dev, sizeof(*data), GFP_KERNEL); + if (!data) + return -ENOMEM; + + dev_set_drvdata(&wdev->dev, data); + + err =3D devm_mutex_init(&wdev->dev, &data->key_lock); + if (err) + return err; + + /* Setup input device */ + data->input_dev =3D devm_input_allocate_device(&wdev->dev); + if (!data->input_dev) + return -ENOMEM; + data->input_dev->name =3D "Redmibook WMI keys"; + data->input_dev->phys =3D "wmi/input0"; + + err =3D sparse_keymap_setup(data->input_dev, redmi_wmi_keymap, NULL); + if (err) + return err; + + return input_register_device(data->input_dev); +} + +static void redmi_wmi_notify(struct wmi_device *wdev, union acpi_object *o= bj) +{ + struct redmi_wmi *data =3D dev_get_drvdata(&wdev->dev); + int value =3D 1; + bool autorelease =3D true; + + if (obj->type !=3D ACPI_TYPE_BUFFER) { + dev_err(&wdev->dev, "Bad response type %u\n", obj->type); + return; + } + + if (obj->buffer.length !=3D 32) { + dev_err(&wdev->dev, "Invalid buffer length %u\n", obj->buffer.length); + return; + } + + /* For linearizability */ + guard(mutex)(&data->key_lock); + + u32 payload =3D get_unaligned_le32(obj->buffer.pointer); + struct key_entry *entry =3D sparse_keymap_entry_from_scancode(data->input= _dev, payload); + + if (!entry) { + dev_dbg(&wdev->dev, "Unknown WMI event with payload %u", payload); + return; + } + + /* AI key quirk */ + if (entry->keycode =3D=3D KEY_ASSISTANT) { + value =3D !(payload & AI_KEY_VALUE_MASK); + autorelease =3D false; + } + + sparse_keymap_report_entry(data->input_dev, entry, value, autorelease); +} + +static const struct wmi_device_id redmi_wmi_id_table[] =3D { + { .guid_string =3D WMI_REDMIBOOK_KEYBOARD_EVENT_GUID }, + { } +}; + +static struct wmi_driver redmi_wmi_driver =3D { + .driver =3D { + .name =3D "redmi-wmi", + .probe_type =3D PROBE_PREFER_ASYNCHRONOUS + }, + .id_table =3D redmi_wmi_id_table, + .probe =3D redmi_wmi_probe, + .notify =3D redmi_wmi_notify, + .no_singleton =3D true, +}; +module_wmi_driver(redmi_wmi_driver); + +MODULE_DEVICE_TABLE(wmi, redmi_wmi_id_table); +MODULE_AUTHOR("Gladyshev Ilya "); +MODULE_DESCRIPTION("Redmibook WMI driver"); +MODULE_LICENSE("GPL"); --=20 2.50.0