From nobody Mon Oct 6 01:21:06 2025 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C8C220ADF8 for ; Mon, 28 Jul 2025 16:34:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753720463; cv=none; b=GSHrqgVCirrRJG8onTp573bNDlNxN1uWNNY0VVDrUCntr6e2tYIxULgUC/bBc4OCRqxJIJr3U3t64aTHXvi2/vv2l+vN7dVHmalpZ6W8S7ELX1aYCaCFYI42+U+pblpgv2ycSSXu4maFSSSScwULtfdDTWvU/Nq5KsoUPe6UIco= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753720463; c=relaxed/simple; bh=MchF5UPx0mNSiHl2aR2yJe+gbfg+oi9Voc70x1yyFyE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RK+a1a4B4L0D2G61AzgtxjScfQuLHbk64xuGL7NlwR8NEGiWH4Vc61vaTUyy/QIlskrdLkS3V/2QvzwwS0RwV9tS+D8cNhe1Id5pU0GHtTd+GFkzjDulrIK1IJzqO2YNQQ4d29Ih7/S1SLiADlwJixoG80FOlnRWVb43OqtzDto= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=BW0su7UK; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="BW0su7UK" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1753720459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eH2fsvxmviFtEU5C9aDjmTeC8T8d65Crddr7C4wlj1U=; b=BW0su7UK+ZFonSb+IrLIBNhBbtO5zWin2h1Z3n3Er4edGuQIR4YbmwMFwMilePhwkFT4+G aczlLiQB6QPn838yUDGO9X7L8umMc1AauZcS+PQxWiILRQc2TE/ygORVXaxIcB1FMZtAmV K1cdDGLM5Otf6tO5nT4AX2VuJ9fzwkU= From: Ze Huang Date: Tue, 29 Jul 2025 00:33:56 +0800 Subject: [PATCH v7 2/2] usb: dwc3: add generic driver to support flattened Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250729-dwc3_generic-v7-2-5c791bba826f@linux.dev> References: <20250729-dwc3_generic-v7-0-5c791bba826f@linux.dev> In-Reply-To: <20250729-dwc3_generic-v7-0-5c791bba826f@linux.dev> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Thinh Nguyen , Philipp Zabel Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Ze Huang X-Developer-Signature: v=1; a=ed25519-sha256; t=1753720444; l=6402; i=huang.ze@linux.dev; s=20250705; h=from:subject:message-id; bh=MchF5UPx0mNSiHl2aR2yJe+gbfg+oi9Voc70x1yyFyE=; b=bdBiSp4lensXpWUJE5yMitkGncXQ4e8HK0MKgTPhsVg37K680if5snpggRhdhzKhh3m+vdQmz sT4O5d1namxDH8/lpCZe/GuMKEK+m+LAsfhphOurxvegPxgCpcbaMb4 X-Developer-Key: i=huang.ze@linux.dev; a=ed25519; pk=Kzc4PMu5PTo8eZZQ5xmTNL9jeXcQ9Wml0cs+vlQpBkg= X-Migadu-Flow: FLOW_OUT To support flattened dwc3 dt model and drop the glue layer, introduce the `dwc3-generic` driver. This enables direct binding of the DWC3 core driver and offers an alternative to the existing glue driver `dwc3-of-simple`. Signed-off-by: Ze Huang Acked-by: Thinh Nguyen --- drivers/usb/dwc3/Kconfig | 11 +++ drivers/usb/dwc3/Makefile | 1 + drivers/usb/dwc3/dwc3-generic-plat.c | 167 +++++++++++++++++++++++++++++++= ++++ 3 files changed, 179 insertions(+) diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 310d182e10b50b253d7e5a51674806e6ec442a2a..4925d15084f816d3ff92059b476= ebcc799b56b51 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -189,4 +189,15 @@ config USB_DWC3_RTK or dual-role mode. Say 'Y' or 'M' if you have such device. =20 +config USB_DWC3_GENERIC_PLAT + tristate "DWC3 Generic Platform Driver" + depends on OF && COMMON_CLK + default USB_DWC3 + help + Support USB3 functionality in simple SoC integrations. + Currently supports SpacemiT DWC USB3. Platforms using + dwc3-of-simple can easily switch to dwc3-generic by flattening + the dwc3 child node in the device tree. + Say 'Y' or 'M' here if your platform integrates DWC3 in a similar way. + endif diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile index 830e6c9e5fe073c1f662ce34b6a4a2da34c407a2..96469e48ff9d189cc8d0b65e654= 24eae2158bcfe 100644 --- a/drivers/usb/dwc3/Makefile +++ b/drivers/usb/dwc3/Makefile @@ -57,3 +57,4 @@ obj-$(CONFIG_USB_DWC3_IMX8MP) +=3D dwc3-imx8mp.o obj-$(CONFIG_USB_DWC3_XILINX) +=3D dwc3-xilinx.o obj-$(CONFIG_USB_DWC3_OCTEON) +=3D dwc3-octeon.o obj-$(CONFIG_USB_DWC3_RTK) +=3D dwc3-rtk.o +obj-$(CONFIG_USB_DWC3_GENERIC_PLAT) +=3D dwc3-generic-plat.o diff --git a/drivers/usb/dwc3/dwc3-generic-plat.c b/drivers/usb/dwc3/dwc3-g= eneric-plat.c new file mode 100644 index 0000000000000000000000000000000000000000..abb144867bf5f678223483c9485= 21ceb44d05190 --- /dev/null +++ b/drivers/usb/dwc3/dwc3-generic-plat.c @@ -0,0 +1,167 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * dwc3-generic-plat.c - DesignWare USB3 generic platform driver + * + * Copyright (C) 2025 Ze Huang + * + * Inspired by dwc3-qcom.c and dwc3-of-simple.c + */ + +#include +#include +#include +#include "glue.h" + +struct dwc3_generic { + struct device *dev; + struct dwc3 dwc; + struct clk_bulk_data *clks; + int num_clocks; + struct reset_control *resets; +}; + +static void dwc3_generic_reset_control_assert(void *data) +{ + reset_control_assert(data); +} + +static int dwc3_generic_probe(struct platform_device *pdev) +{ + struct dwc3_probe_data probe_data =3D {}; + struct device *dev =3D &pdev->dev; + struct dwc3_generic *dwc3; + struct resource *res; + int ret; + + dwc3 =3D devm_kzalloc(dev, sizeof(*dwc3), GFP_KERNEL); + if (!dwc3) + return -ENOMEM; + + dwc3->dev =3D dev; + + platform_set_drvdata(pdev, dwc3); + + res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + dev_err(&pdev->dev, "missing memory resource\n"); + return -ENODEV; + } + + dwc3->resets =3D devm_reset_control_array_get_optional_exclusive(dev); + if (IS_ERR(dwc3->resets)) + return dev_err_probe(dev, PTR_ERR(dwc3->resets), "failed to get resets\n= "); + + ret =3D reset_control_assert(dwc3->resets); + if (ret) + return dev_err_probe(dev, ret, "failed to assert resets\n"); + + /* Not strict timing, just for safety */ + udelay(2); + + ret =3D reset_control_deassert(dwc3->resets); + if (ret) + return dev_err_probe(dev, ret, "failed to deassert resets\n"); + + ret =3D devm_add_action_or_reset(dev, dwc3_generic_reset_control_assert, = dwc3->resets); + if (ret) + return ret; + + ret =3D devm_clk_bulk_get_all_enabled(dwc3->dev, &dwc3->clks); + if (ret < 0) + return dev_err_probe(dev, ret, "failed to get clocks\n"); + + dwc3->num_clocks =3D ret; + dwc3->dwc.dev =3D dev; + probe_data.dwc =3D &dwc3->dwc; + probe_data.res =3D res; + probe_data.ignore_clocks_and_resets =3D true; + ret =3D dwc3_core_probe(&probe_data); + if (ret) + return dev_err_probe(dev, ret, "failed to register DWC3 Core\n"); + + return 0; +} + +static void dwc3_generic_remove(struct platform_device *pdev) +{ + struct dwc3_generic *dwc3 =3D platform_get_drvdata(pdev); + + dwc3_core_remove(&dwc3->dwc); +} + +static int dwc3_generic_suspend(struct device *dev) +{ + struct dwc3_generic *dwc3 =3D dev_get_drvdata(dev); + int ret; + + ret =3D dwc3_pm_suspend(&dwc3->dwc); + if (ret) + return ret; + + clk_bulk_disable_unprepare(dwc3->num_clocks, dwc3->clks); + + return 0; +} + +static int dwc3_generic_resume(struct device *dev) +{ + struct dwc3_generic *dwc3 =3D dev_get_drvdata(dev); + int ret; + + ret =3D clk_bulk_prepare_enable(dwc3->num_clocks, dwc3->clks); + if (ret) + return ret; + + ret =3D dwc3_pm_resume(&dwc3->dwc); + if (ret) + return ret; + + return 0; +} + +static int dwc3_generic_runtime_suspend(struct device *dev) +{ + struct dwc3_generic *dwc3 =3D dev_get_drvdata(dev); + + return dwc3_runtime_suspend(&dwc3->dwc); +} + +static int dwc3_generic_runtime_resume(struct device *dev) +{ + struct dwc3_generic *dwc3 =3D dev_get_drvdata(dev); + + return dwc3_runtime_resume(&dwc3->dwc); +} + +static int dwc3_generic_runtime_idle(struct device *dev) +{ + struct dwc3_generic *dwc3 =3D dev_get_drvdata(dev); + + return dwc3_runtime_idle(&dwc3->dwc); +} + +static const struct dev_pm_ops dwc3_generic_dev_pm_ops =3D { + SYSTEM_SLEEP_PM_OPS(dwc3_generic_suspend, dwc3_generic_resume) + RUNTIME_PM_OPS(dwc3_generic_runtime_suspend, dwc3_generic_runtime_resume, + dwc3_generic_runtime_idle) +}; + +static const struct of_device_id dwc3_generic_of_match[] =3D { + { .compatible =3D "spacemit,k1-dwc3", }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, dwc3_generic_of_match); + +static struct platform_driver dwc3_generic_driver =3D { + .probe =3D dwc3_generic_probe, + .remove =3D dwc3_generic_remove, + .driver =3D { + .name =3D "dwc3-generic-plat", + .of_match_table =3D dwc3_generic_of_match, + .pm =3D pm_ptr(&dwc3_generic_dev_pm_ops), + }, +}; +module_platform_driver(dwc3_generic_driver); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("DesignWare USB3 generic platform driver"); --=20 2.50.1