From nobody Mon Oct 6 03:17:17 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 006E4220F5A for ; Sun, 27 Jul 2025 16:25:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753633515; cv=none; b=OhJAZOQ774vQOT7k0wu3sDjV8I4u1jDzxr5H+RCHgnCmmkZF2lR7rZCF2+4jKimrc4tggYk53TA8/kEvOZzC5cv8+hx2GFeRWfAtcW+LSPPKzWJbHcAjTS2kPLJo1mSJYNy70wm/SC+rh8ro4xKNC6MTsVWk8Ozknk4h3RnwMro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753633515; c=relaxed/simple; bh=FC7RrRfjKXNVyHBQzF6uwLhcss5N7idT7lbjBm/hwDg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fRiIGuaBAr3LWjS1U23rmNQd+WBvIcYABvIxRy84GQLf9LVwcN396P+eJebHbd4ds/pf1VfC39ph1qVPrn2+4WFHI3w0ve3wNLX09YWIfC3hE/aQlbWIcnkyFqneeai2exvjVnpI0MI+NdHn3zc/9wDA8GiqWB7UoWJLgg2A3zw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pc3A8fbH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pc3A8fbH" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56REOHNj019954 for ; Sun, 27 Jul 2025 16:25:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= v4YCBWmY0mp9H7MQ3j2gakQJBYTosZxb2APt1bK5h/Q=; b=Pc3A8fbHKs3Uzph6 DOtrmF5OwSYALF4PY5i7D4F9VXczqAzOrGND4qpa31lWhSlECsdAM/Rv4UFEdQ0i PItIVzMOGcrEIvfVFmOaH6NMP1HobYfzXXQ1ND/NB3IBKJhSIlUqY6TA9APIg+Tt e1sTVP0biTCkzmhm7UJZ3sNscRVQP0mN9u4tZburAFKw1BFE7BUi7xcbw6c5A1VA RX8LUHXTMNCktcb+mBTF5LuLW/dF9nwiio3oRhv7tX98JxczkchN69iHw3NzOnQY ZN4w5vyjeIdcPP26WobDOofu4PNgdsS2iG+5STLfwXKwGW+iUlu86bPbW6Ca8HDK LnMiEQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484p1aach7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 27 Jul 2025 16:25:12 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-23fe984fe57so12533115ad.0 for ; Sun, 27 Jul 2025 09:25:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753633511; x=1754238311; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v4YCBWmY0mp9H7MQ3j2gakQJBYTosZxb2APt1bK5h/Q=; b=ITwkYNCSj514BhyevN8I6/mJw2gxId1Y3dq1l7l4S1IYvtkg7A+UXdO09iUzoPh4nN rB4GwG6QNkersyjMGYKfmVQLA8qDdRJTpUZU5iUhvxumbzZC3UUAi4kAGxEaCIMJ9NXf hrE9SuM0O58jAu5Xcb1Y+FSLD78MusxhoE7ZyUXA0evZ+JtGAkZA0SMyfORlwNCS2GxI jMjaKZfUmh/nestoMInQUiQvcVUw7MykPPw3lOC6AIzlqTK7OmWwJvKenak1+gAV8OAB /KA/Zct5c/6O2yMSVPxvEaWSPG9Blul/gg8uQW1OkJeIrvffwBwcFXF7AZMnwZ0Zjx2h 5vlg== X-Forwarded-Encrypted: i=1; AJvYcCWZuhgDgczR1oNcLK9iTcHbQfHuhsmPNdKPpUXq8nE+UAQ4nih6SKV9HAKVxSFQQNyRTo0fd6Jn6kfMJno=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8/M/ZGG5yAK7svHDJL3ed8LL1spb3qSzbbV631aGHRiMvqjSk kc+Lw2ZenjU3QdCr15Nw5hAzgumHyYZOK0dDo25w6SfgMY5q5bCGApAdTh8Mq6T4eq8REEjcXVb 2UZDeOq7StXvzet6pImWuCp5MjctSgrVR+NrocQNf5TwpRNOGVp+zzxMRvFpb3Zk80Cg= X-Gm-Gg: ASbGncuxW2kdfRWsDIDGK8lzUO2sIUNI2CP9IqubuHJ8QsVfw4qf89qd5obXMUNW8Jh ETu2Mg2JX0vY3w2kv7PGfRn+r9lxv6vJzXkxNe7afkVbx8x2JN2K3Qoars9bART1EYl6HVBxhK8 tADw244v9R6EnUDaKqTwaEcBotvZcCt8inwNTlCXtQQAHRTA16OymqyNvZqqh3KWBsOhlIzwEy0 L6lclnZ/qYVtgptxoKOqGtRHD7ycldFhp29uOHR7yraw+53Gh+hg7m5DRRruE1dybOxeIHFfs46 gh796LdkH/OrrWyICK0ApbRlbOLOLm4ci/VhvhLCr3bPq/0HqGw0oENqMmh2KuEYRnvOm+e7dOO A X-Received: by 2002:a17:902:ccc9:b0:240:2eb6:d5cc with SMTP id d9443c01a7336-2402eb6d9e9mr9977065ad.17.1753633511476; Sun, 27 Jul 2025 09:25:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEVQHJRnmueFVtjE5Xgx+LUDsaynix8FLVjXOCUqpUqvT52MAlWGQMEYT0tAC2uOxsMT2zpuQ== X-Received: by 2002:a17:902:ccc9:b0:240:2eb6:d5cc with SMTP id d9443c01a7336-2402eb6d9e9mr9976695ad.17.1753633511036; Sun, 27 Jul 2025 09:25:11 -0700 (PDT) Received: from hu-spratap-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23fd9397ebbsm29110325ad.210.2025.07.27.09.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Jul 2025 09:25:10 -0700 (PDT) From: Shivendra Pratap Date: Sun, 27 Jul 2025 21:54:44 +0530 Subject: [PATCH v13 01/10] power: reset: reboot-mode: Synchronize list traversal Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250727-arm-psci-system_reset2-vendor-reboots-v13-1-6b8d23315898@oss.qualcomm.com> References: <20250727-arm-psci-system_reset2-vendor-reboots-v13-0-6b8d23315898@oss.qualcomm.com> In-Reply-To: <20250727-arm-psci-system_reset2-vendor-reboots-v13-0-6b8d23315898@oss.qualcomm.com> To: Bartosz Golaszewski , Bjorn Andersson , Sebastian Reichel , Rob Herring , Sudeep Holla , Souvik Chakravarty , Krzysztof Kozlowski , Conor Dooley , Andy Yan , Mark Rutland , Lorenzo Pieralisi , Arnd Bergmann , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Vinod Koul , Catalin Marinas , Will Deacon , Florian Fainelli Cc: Dmitry Baryshkov , Mukesh Ojha , Stephen Boyd , Andre Draszik , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Elliot Berman , Shivendra Pratap , Srinivas Kandagatla X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1753633495; l=3679; i=shivendra.pratap@oss.qualcomm.com; s=20250710; h=from:subject:message-id; bh=FC7RrRfjKXNVyHBQzF6uwLhcss5N7idT7lbjBm/hwDg=; b=wuM7Ud9mvdBgYMygF1JESinqXl7pH9Sn1j9nV94LYy4tSZEq96eslDnylVV4vStbiMeqYy+l1 Cs6ZBdqK3AwBOUismrxPOsG47QSiHQe0Arf9SH5ULtsQcLsU7g18Y+3 X-Developer-Key: i=shivendra.pratap@oss.qualcomm.com; a=ed25519; pk=CpsuL7yZ8NReDPhGgq6Xn/SRoa59mAvzWOW0QZoo4gw= X-Proofpoint-ORIG-GUID: ndZvi3G0sJqxshyNBD0vJk-PMXHc_Vuf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI3MDE0NiBTYWx0ZWRfXyPtXv0D4dpQ6 heMaid6sxtWPp0R7MgWbx3eA6/PIYwbmK8mnr00RjTfOfK+SndSqqxjKH7pomVZ/QNPaNDs1AL8 HwpuhvvF3S4HHYnjkrT/XGvJs85DB3sO2dWLeac0g6Zg3NR3PGqKdKnR6yNwPVF+/MS20FlsMd+ oZaqUsgiKrOxOu1Y5j5XEs4Gg1KMQoJkEKPeYJCLOJja0pbvlLAQBA6AZ18dlxgOoYGiYAARaQA nYa84/TI0I1RBKo66LV4AQyjIfKa8XicT6Sje3Tw4omFm90lPcX/dsdpT8FImaTgTVNW6Lo3f5V WBrKAECTIBeB/87a3sOYWHXvBqBww9hbsbrXkHHgcpXErVX8V004ZPIa9pdB1EmXySGbhf16U2q 1kQQk2NLDjUNBpGnpk8zhh0NiJhXjDDhILIvhOVks9cOWxi7IHUFNe2L46gxjwJ33POjsieF X-Proofpoint-GUID: ndZvi3G0sJqxshyNBD0vJk-PMXHc_Vuf X-Authority-Analysis: v=2.4 cv=KtNN2XWN c=1 sm=1 tr=0 ts=688652e8 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=iWTyA_h5fkyOTIp6uasA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-27_05,2025-07-24_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 impostorscore=0 mlxscore=0 malwarescore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507270146 List traversals must be synchronized to prevent race conditions and data corruption. The reboot-mode list is not protected by a lock currently, which can lead to concurrent access and race. Introduce a mutex lock to guard all operations on the reboot-mode list and ensure thread-safe access. The change prevents unsafe concurrent access on reboot-mode list. Signed-off-by: Shivendra Pratap --- drivers/power/reset/reboot-mode.c | 24 ++++++++++++++++++++---- include/linux/reboot-mode.h | 4 ++++ 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/drivers/power/reset/reboot-mode.c b/drivers/power/reset/reboot= -mode.c index fba53f638da04655e756b5f8b7d2d666d1379535..42bb99128ed3846d4bff62416dc= 31135ddeaeb90 100644 --- a/drivers/power/reset/reboot-mode.c +++ b/drivers/power/reset/reboot-mode.c @@ -29,9 +29,14 @@ static unsigned int get_reboot_mode_magic(struct reboot_= mode_driver *reboot, if (!cmd) cmd =3D normal; =20 - list_for_each_entry(info, &reboot->head, list) - if (!strcmp(info->mode, cmd)) + mutex_lock(&reboot->rb_lock); + list_for_each_entry(info, &reboot->head, list) { + if (!strcmp(info->mode, cmd)) { + mutex_unlock(&reboot->rb_lock); return info->magic; + } + } + mutex_unlock(&reboot->rb_lock); =20 /* try to match again, replacing characters impossible in DT */ if (strscpy(cmd_, cmd, sizeof(cmd_)) =3D=3D -E2BIG) @@ -41,9 +46,14 @@ static unsigned int get_reboot_mode_magic(struct reboot_= mode_driver *reboot, strreplace(cmd_, ',', '-'); strreplace(cmd_, '/', '-'); =20 - list_for_each_entry(info, &reboot->head, list) - if (!strcmp(info->mode, cmd_)) + mutex_lock(&reboot->rb_lock); + list_for_each_entry(info, &reboot->head, list) { + if (!strcmp(info->mode, cmd_)) { + mutex_unlock(&reboot->rb_lock); return info->magic; + } + } + mutex_unlock(&reboot->rb_lock); =20 return 0; } @@ -77,7 +87,9 @@ int reboot_mode_register(struct reboot_mode_driver *reboo= t) int ret; =20 INIT_LIST_HEAD(&reboot->head); + mutex_init(&reboot->rb_lock); =20 + mutex_lock(&reboot->rb_lock); for_each_property_of_node(np, prop) { if (strncmp(prop->name, PREFIX, len)) continue; @@ -113,12 +125,14 @@ int reboot_mode_register(struct reboot_mode_driver *r= eboot) reboot->reboot_notifier.notifier_call =3D reboot_mode_notify; register_reboot_notifier(&reboot->reboot_notifier); =20 + mutex_unlock(&reboot->rb_lock); return 0; =20 error: list_for_each_entry(info, &reboot->head, list) kfree_const(info->mode); =20 + mutex_unlock(&reboot->rb_lock); return ret; } EXPORT_SYMBOL_GPL(reboot_mode_register); @@ -133,8 +147,10 @@ int reboot_mode_unregister(struct reboot_mode_driver *= reboot) =20 unregister_reboot_notifier(&reboot->reboot_notifier); =20 + mutex_lock(&reboot->rb_lock); list_for_each_entry(info, &reboot->head, list) kfree_const(info->mode); + mutex_unlock(&reboot->rb_lock); =20 return 0; } diff --git a/include/linux/reboot-mode.h b/include/linux/reboot-mode.h index 4a2abb38d1d612ec0fdf05eb18c98b210f631b7f..b73f80708197677db8dc2e43aff= c519782b7146e 100644 --- a/include/linux/reboot-mode.h +++ b/include/linux/reboot-mode.h @@ -2,11 +2,15 @@ #ifndef __REBOOT_MODE_H__ #define __REBOOT_MODE_H__ =20 +#include + struct reboot_mode_driver { struct device *dev; struct list_head head; int (*write)(struct reboot_mode_driver *reboot, unsigned int magic); struct notifier_block reboot_notifier; + /*Protects access to reboot mode list*/ + struct mutex rb_lock; }; =20 int reboot_mode_register(struct reboot_mode_driver *reboot); --=20 2.34.1