From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D048B8488 for ; Sat, 26 Jul 2025 04:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504403; cv=none; b=a44Z/iLtQVbi27T+pJvfZ+4HFhzVlNCGFLwB/VALqhpYwoqMktJsp1eAB+rOuk89z9Py9UJKW5BVV0NA1GwlsDOw1ILgKIXqS8L4KpWAFWXx/C2vABgwSRnO7KEiTM/AVcwiJFNMLGTT1WB8PGDtI08GBIUt4QRQOsAprNFGRlw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504403; c=relaxed/simple; bh=aGrJcQ1guL6WjuU05ZF+eyGXhxPTzs0xtdZ+Pl5RiqI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AYn30ZaQJO8LRlXcmex5kwroo7ww0xEcCjuCkwVnBqh9D80QhhKEoHm++e3NkxKm9tD6QrHuvO+evK2qfUIhPBkulKKHES06CjTwBcVs2Ingq1/iV9r3W9PJZN4kcUk3K4fUF5sF0M5/4hRSUdk2joNectjikylMjru959WnDwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CitUvFa/; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CitUvFa/" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7e623a12701so431024185a.2 for ; Fri, 25 Jul 2025 21:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504401; x=1754109201; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8qnYWP5uxktCzJJeTbiSoBQ7UpZzwA2RvsbCjUbPPeI=; b=CitUvFa/CQUEdgBaxvDrNA/+2NNpBJYxT5WwdhWBNuVC4jHxKBBEmxlP3xtSfrgBhg ejk5AEXr+kvC6QRsqBggCVc9i7VG3FPpTYiSaEZC73l5L8Ws6ybcJgLFEd+zt6TIvEgk +gGaXFSLiwz2ehQ/uh8sn2yqVlSe+XSat3W8ZPQzDyfm1lztSrctGebfjUxs8x7ZI5kM gBEn/77AFioRZNAqlTfBHWt43Z9gwb8TgKgt4hJAh0/NDDnfa2TTo9sxLJQKLUJnMBXH YTcvcmXVcI74ISZaVtlQqxeNPMe9aolikZmL80N4yruU2CqtWY4nZF19OrEEl+5AsiKO mhEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504401; x=1754109201; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8qnYWP5uxktCzJJeTbiSoBQ7UpZzwA2RvsbCjUbPPeI=; b=OVJNOv5HV2UQBgUw8hzPkkZRtpIesmi+qBzY/TUbBdLdcGww4J8xI+wO+9R8T4H0GR jYEkjpl28mEHH3LqkZ0rB1aaswvFYkE31xjVBSiiw4ByJaoGAKvWrt8M/3rT/1NblT7E XKwu9w36pRIYNs7iHRfsnkypLRv8PteQlsF6yto7LqVWnJBdOfCnRuqQlHPBfICKLwcf p2Fl1/RJjvZUt7przRPdhzIFPvm9lYTCZmu2Fr14eJ2FBQFO8WhYWCjBkn/REG8qFusS QnIUL+6NC/OeUT6wg0ZXlHeIi3+ah3jHU0iF/A9KF5+FVczDU9CR5KdLdAjfJdWmR15Z 4IsQ== X-Forwarded-Encrypted: i=1; AJvYcCUAKQvmoQdLtOUv2djpP+O/n779Kf/jYPRobmQlraOGcTfiBogFEwimI4dcijMjEfEyCw6hIGQv7tt77Q0=@vger.kernel.org X-Gm-Message-State: AOJu0YyX+WqCTSGCXXfjEur1mjzz5/BSllXe+qqjq4G9m+E71yEY3lB4 bjkXKR9lnwkFDoOJcZA1JTNZA+nNh1ws8yTD4RZnwZIO155BtJxHwhVaoYme+Q== X-Gm-Gg: ASbGncu3BvdSRD0kVqIZvS5qaFHliCkq6Nh3d3fi9QBGPk5N1N7/3/td6cZNQyv/uJu t4CzXKzbRoO81zp+BRmR40m1Y+nzpxRmndv+YSqBumhDCoHTZzHAo/gU1a7RzDz8OigsHj3Lw4k zmp15BDcvoH+AVbKj8wvCmDZ2tRA1Dfu+TluzfeNrPkFE2qjAK/JTK4bmRsi9Q1QgVGquF1eDkr uOgmpoD0MFVvv5XJR+fDsg8BjwBZDa3CM5/ULkW9a+W38NPhK47mQERD7rSJSrm0133Cvr1WHRg 18Y/2TAVhWhddPL2K20LTEgeMIrgf30QK8WJYUiebWqgHOodqshFJaJr8QfJpQ9lX3Jkq8aan2D ODSBFQ0cMtpmheXYpzysgFmroUzL+liJDQdr52IX6TLcSLzOXSxQ= X-Google-Smtp-Source: AGHT+IHscYgHll4ESn96HKmYhGJ92hcYbxJkf1pCvKGDNzYZt+yqgNp2YDOhlGxpIWU/OK3f6UsVgg== X-Received: by 2002:a05:620a:aa09:b0:7e1:d0fb:3454 with SMTP id af79cd13be357-7e63c1b7d9cmr601564485a.53.1753504400659; Fri, 25 Jul 2025 21:33:20 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:19 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 01/20] staging: rtl8723bs: fix spacing around operators Date: Sat, 26 Jul 2025 04:31:59 +0000 Message-Id: <20250726043218.386738-2-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver contained multiple instances of inconsistent or incorrect spacing around binary operators such as `+`, `&&`, `>>`, `/`, `|`, `&`, `<<`, and others. These violations reduce code readability and do not conform to the Linux kernel coding style guidelines. This commit standardizes spacing around all such operators, improving code readability and maintainability. No functional changes have been made. Identified using checkpatch.pl. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 72 +++++++++++------------ 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 692d0c2b766d..da64d5714237 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -256,8 +256,8 @@ void rtw_generate_random_ibss(u8 *pibss) pibss[1] =3D 0x11; pibss[2] =3D 0x87; pibss[3] =3D (u8)(curtime & 0xff) ;/* p[0]; */ - pibss[4] =3D (u8)((curtime>>8) & 0xff) ;/* p[1]; */ - pibss[5] =3D (u8)((curtime>>16) & 0xff) ;/* p[2]; */ + pibss[4] =3D (u8)((curtime >> 8) & 0xff) ;/* p[1]; */ + pibss[5] =3D (u8)((curtime >> 16) & 0xff) ;/* p[2]; */ } =20 u8 *rtw_get_capability_from_ie(u8 *ie) @@ -410,14 +410,14 @@ void update_network(struct wlan_bssid_ex *dst, struct= wlan_bssid_ex *src, sq_final =3D padapter->recvpriv.signal_qual; /* the rssi value here is undecorated, and will be used for antenna dive= rsity */ if (sq_smp !=3D 101) /* from the right channel */ - rssi_final =3D (src->rssi+dst->rssi*4)/5; + rssi_final =3D (src->rssi + dst->rssi * 4) / 5; else rssi_final =3D rssi_ori; } else { if (sq_smp !=3D 101) { /* from the right channel */ - ss_final =3D ((u32)(src->phy_info.signal_strength)+(u32)(dst->phy_info.= signal_strength)*4)/5; - sq_final =3D ((u32)(src->phy_info.signal_quality)+(u32)(dst->phy_info.s= ignal_quality)*4)/5; - rssi_final =3D (src->rssi+dst->rssi*4)/5; + ss_final =3D ((u32)(src->phy_info.signal_strength) + (u32)(dst->phy_inf= o.signal_strength) * 4) / 5; + sq_final =3D ((u32)(src->phy_info.signal_quality) + (u32)(dst->phy_info= .signal_quality) * 4) / 5; + rssi_final =3D (src->rssi + dst->rssi * 4) / 5; } else { /* bss info not receiving from the right channel, use the original RX s= ignal infos */ ss_final =3D dst->phy_info.signal_strength; @@ -587,7 +587,7 @@ int rtw_is_desired_network(struct adapter *adapter, str= uct wlan_network *pnetwor privacy =3D pnetwork->network.privacy; =20 if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS)) { - if (rtw_get_wps_ie(pnetwork->network.ies+_FIXED_IE_LENGTH_, pnetwork->ne= twork.ie_length-_FIXED_IE_LENGTH_, NULL, &wps_ielen)) + if (rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, pnetwork->= network.ie_length - _FIXED_IE_LENGTH_, NULL, &wps_ielen)) return true; else return false; @@ -832,14 +832,14 @@ void rtw_free_assoc_resources(struct adapter *adapter= , int lock_scanned_queue) struct dvobj_priv *psdpriv =3D adapter->dvobj; struct debug_priv *pdbgpriv =3D &psdpriv->drv_dbg; =20 - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE|WIFI_AP_STATE)) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE | WIFI_AP_STATE)) { struct sta_info *psta; =20 psta =3D rtw_get_stainfo(&adapter->stapriv, tgt_network->network.mac_add= ress); rtw_free_stainfo(adapter, psta); } =20 - if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE|WIFI_ADHOC_MASTER_STATE|WIF= I_AP_STATE)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE | WIFI_ADHOC_MASTER_STATE |= WIFI_AP_STATE)) { struct sta_info *psta; =20 rtw_free_all_stainfo(adapter); @@ -886,7 +886,7 @@ void rtw_indicate_disconnect(struct adapter *padapter) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 - _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING|WIFI_UNDER_WPS); + _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING | WIFI_UNDER_WPS); =20 if (rtw_to_roam(padapter) > 0) _clr_fwstate_(pmlmepriv, _FW_LINKED); @@ -913,7 +913,7 @@ inline void rtw_indicate_scan_done(struct adapter *pada= pter, bool aborted) =20 if ((!adapter_to_pwrctl(padapter)->bInSuspend) && (!check_fwstate(&padapter->mlmepriv, - WIFI_ASOC_STATE|WIFI_UNDER_LINKING))) { + WIFI_ASOC_STATE | WIFI_UNDER_LINKING))) { rtw_set_ips_deny(padapter, 0); _set_timer(&padapter->mlmepriv.dynamic_chk_timer, 1); } @@ -1053,8 +1053,8 @@ static void rtw_joinbss_update_network(struct adapter= *padapter, struct wlan_net switch (pnetwork->network.infrastructure_mode) { case Ndis802_11Infrastructure: =20 - if (pmlmepriv->fw_state&WIFI_UNDER_WPS) - pmlmepriv->fw_state =3D WIFI_STATION_STATE|WIFI_UNDER_WPS; + if (pmlmepriv->fw_state & WIFI_UNDER_WPS) + pmlmepriv->fw_state =3D WIFI_STATION_STATE | WIFI_UNDER_WPS; else pmlmepriv->fw_state =3D WIFI_STATION_STATE; =20 @@ -1224,7 +1224,7 @@ void rtw_sta_media_status_rpt(struct adapter *adapter= , struct sta_info *psta, u3 if (!psta) return; =20 - media_status_rpt =3D (u16)((psta->mac_id<<8)|mstatus); /* MACID|OPMODE:= 1 connect */ + media_status_rpt =3D (u16)((psta->mac_id << 8) | mstatus); /* MACID|OPM= ODE:1 connect */ rtw_hal_set_hwreg(adapter, HW_VAR_H2C_MEDIA_STATUS_RPT, (u8 *)&media_stat= us_rpt); } =20 @@ -1342,13 +1342,13 @@ void rtw_stadel_event_callback(struct adapter *adap= ter, u8 *pbuf) if (mac_id >=3D 0) { u16 media_status; =20 - media_status =3D (mac_id<<8)|0; /* MACID|OPMODE:0 means disconnect */ + media_status =3D (mac_id << 8) | 0; /* MACID|OPMODE:0 means disconnect= */ /* for STA, AP, ADHOC mode, report disconnect stauts to FW */ rtw_hal_set_hwreg(adapter, HW_VAR_H2C_MEDIA_STATUS_RPT, (u8 *)&media_sta= tus); } =20 /* if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) */ - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) return; =20 mlmeext_sta_del_event_callback(adapter); @@ -1524,7 +1524,7 @@ void rtw_mlme_reset_auto_scan_int(struct adapter *ada= pter) if (pmlmeinfo->VHT_enable) /* disable auto scan when connect to 11AC AP */ mlme->auto_scan_int_ms =3D 0; else if (adapter->registrypriv.wifi_spec && is_client_associated_to_ap(ad= apter) =3D=3D true) - mlme->auto_scan_int_ms =3D 60*1000; + mlme->auto_scan_int_ms =3D 60 * 1000; else if (rtw_chk_roam_flags(adapter, RTW_ROAM_ACTIVE)) { if (check_fwstate(mlme, WIFI_STATION_STATE) && check_fwstate(mlme, _FW_L= INKED)) mlme->auto_scan_int_ms =3D mlme->roam_scan_int_ms; @@ -1923,7 +1923,7 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength =3D initial_out_len; =20 - if (in_ie[i] =3D=3D 0xDD && in_ie[i+2] =3D=3D 0x00 && in_ie[i+3] =3D=3D = 0x50 && in_ie[i+4] =3D=3D 0xF2 && in_ie[i+5] =3D=3D 0x02 && i+5 < in_len) = { /* WMM element ID and OUI */ + if (in_ie[i] =3D=3D 0xDD && in_ie[i + 2] =3D=3D 0x00 && in_ie[i + 3] =3D= =3D 0x50 && in_ie[i + 4] =3D=3D 0xF2 && in_ie[i + 5] =3D=3D 0x02 && i + 5 = < in_len) { /* WMM element ID and OUI */ for (j =3D i; j < i + 9; j++) { out_ie[ielength] =3D in_ie[j]; ielength++; @@ -1935,7 +1935,7 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ break; } =20 - i +=3D (in_ie[i+1]+2); /* to the next IE element */ + i +=3D (in_ie[i + 1] + 2); /* to the next IE element */ } =20 return ielength; @@ -2009,13 +2009,13 @@ signed int rtw_restruct_sec_ie(struct adapter *adap= ter, u8 *in_ie, u8 *out_ie, u authmode =3D WLAN_EID_RSN; =20 if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS)) { - memcpy(out_ie+ielength, psecuritypriv->wps_ie, psecuritypriv->wps_ie_len= ); + memcpy(out_ie + ielength, psecuritypriv->wps_ie, psecuritypriv->wps_ie_l= en); =20 ielength +=3D psecuritypriv->wps_ie_len; } else if ((authmode =3D=3D WLAN_EID_VENDOR_SPECIFIC) || (authmode =3D=3D= WLAN_EID_RSN)) { /* copy RSN or SSN */ - memcpy(&out_ie[ielength], &psecuritypriv->supplicant_ie[0], psecuritypri= v->supplicant_ie[1]+2); - ielength +=3D psecuritypriv->supplicant_ie[1]+2; + memcpy(&out_ie[ielength], &psecuritypriv->supplicant_ie[0], psecuritypri= v->supplicant_ie[1] + 2); + ielength +=3D psecuritypriv->supplicant_ie[1] + 2; rtw_report_sec_ie(adapter, authmode, psecuritypriv->supplicant_ie); } =20 @@ -2183,7 +2183,7 @@ void rtw_build_wmm_ie_ht(struct adapter *padapter, u8= *out_ie, uint *pout_len) =20 if (padapter->mlmepriv.qospriv.qos_option =3D=3D 0) { out_len =3D *pout_len; - rtw_set_ie(out_ie+out_len, WLAN_EID_VENDOR_SPECIFIC, + rtw_set_ie(out_ie + out_len, WLAN_EID_VENDOR_SPECIFIC, _WMM_IE_Length_, WMM_IE, pout_len); =20 padapter->mlmepriv.qospriv.qos_option =3D 1; @@ -2227,7 +2227,7 @@ unsigned int rtw_restructure_ht_ie(struct adapter *pa= dapter, u8 *in_ie, u8 *out_ } else { p =3D rtw_get_ie(in_ie, WLAN_EID_HT_OPERATION, &ielen, in_len); if (p && (ielen =3D=3D sizeof(struct ieee80211_ht_addt_info))) { - struct HT_info_element *pht_info =3D (struct HT_info_element *)(p+2); + struct HT_info_element *pht_info =3D (struct HT_info_element *)(p + 2); =20 if (pht_info->infos[0] & BIT(2)) { switch (pht_info->infos[0] & 0x3) { @@ -2290,14 +2290,14 @@ unsigned int rtw_restructure_ht_ie(struct adapter *= padapter, u8 *in_ie, u8 *out_ rtw_hal_get_def_var(padapter, HW_VAR_MAX_RX_AMPDU_FACTOR, &max_rx_ampdu_factor); =20 - ht_capie.ampdu_params_info =3D (max_rx_ampdu_factor&0x03); + ht_capie.ampdu_params_info =3D (max_rx_ampdu_factor & 0x03); =20 if (padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_) - ht_capie.ampdu_params_info |=3D (IEEE80211_HT_CAP_AMPDU_DENSITY&(0x07<<2= )); + ht_capie.ampdu_params_info |=3D (IEEE80211_HT_CAP_AMPDU_DENSITY & (0x07 = << 2)); else - ht_capie.ampdu_params_info |=3D (IEEE80211_HT_CAP_AMPDU_DENSITY&0x00); + ht_capie.ampdu_params_info |=3D (IEEE80211_HT_CAP_AMPDU_DENSITY & 0x00); =20 - rtw_set_ie(out_ie+out_len, WLAN_EID_HT_CAPABILITY, + rtw_set_ie(out_ie + out_len, WLAN_EID_HT_CAPABILITY, sizeof(struct ieee80211_ht_cap), (unsigned char *)&ht_capie, pout_len= ); =20 phtpriv->ht_option =3D true; @@ -2306,7 +2306,7 @@ unsigned int rtw_restructure_ht_ie(struct adapter *pa= dapter, u8 *in_ie, u8 *out_ p =3D rtw_get_ie(in_ie, WLAN_EID_HT_OPERATION, &ielen, in_len); if (p && (ielen =3D=3D sizeof(struct ieee80211_ht_addt_info))) { out_len =3D *pout_len; - rtw_set_ie(out_ie+out_len, WLAN_EID_HT_OPERATION, ielen, p+2, pout_len); + rtw_set_ie(out_ie + out_len, WLAN_EID_HT_OPERATION, ielen, p + 2, pout_= len); } } =20 @@ -2339,18 +2339,18 @@ void rtw_update_ht_cap(struct adapter *padapter, u8= *pie, uint ie_len, u8 channe =20 /* check Max Rx A-MPDU Size */ len =3D 0; - p =3D rtw_get_ie(pie+sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_CAPAB= ILITY, &len, ie_len-sizeof(struct ndis_802_11_fix_ie)); + p =3D rtw_get_ie(pie + sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_CAP= ABILITY, &len, ie_len - sizeof(struct ndis_802_11_fix_ie)); if (p && len > 0) { - pht_capie =3D (struct ieee80211_ht_cap *)(p+2); + pht_capie =3D (struct ieee80211_ht_cap *)(p + 2); max_ampdu_sz =3D (pht_capie->ampdu_params_info & IEEE80211_HT_CAP_AMPDU_= FACTOR); - max_ampdu_sz =3D 1 << (max_ampdu_sz+3); /* max_ampdu_sz (kbytes); */ + max_ampdu_sz =3D 1 << (max_ampdu_sz + 3); /* max_ampdu_sz (kbytes); */ =20 phtpriv->rx_ampdu_maxlen =3D max_ampdu_sz; =20 } =20 len =3D 0; - p =3D rtw_get_ie(pie+sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_OPERA= TION, &len, ie_len-sizeof(struct ndis_802_11_fix_ie)); + p =3D rtw_get_ie(pie + sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_OPE= RATION, &len, ie_len - sizeof(struct ndis_802_11_fix_ie)); if (p && len > 0) { /* todo: */ } @@ -2429,8 +2429,8 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr phtpriv =3D &psta->htpriv; =20 if (phtpriv->ht_option && phtpriv->ampdu_enable) { - issued =3D (phtpriv->agg_enable_bitmap>>priority)&0x1; - issued |=3D (phtpriv->candidate_tid_bitmap>>priority)&0x1; + issued =3D (phtpriv->agg_enable_bitmap >> priority) & 0x1; + issued |=3D (phtpriv->candidate_tid_bitmap >> priority) & 0x1; =20 if (issued =3D=3D 0) { psta->htpriv.candidate_tid_bitmap |=3D BIT((u8)priority); @@ -2501,7 +2501,7 @@ void _rtw_roaming(struct adapter *padapter, struct wl= an_network *tgt_network) signed int rtw_linked_check(struct adapter *padapter) { if ((check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) =3D=3D true) || - (check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE|WIFI_ADHOC_MASTER_= STATE) =3D=3D true)) { + (check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE | WIFI_ADHOC_MASTE= R_STATE) =3D=3D true)) { if (padapter->stapriv.asoc_sta_count > 2) return true; } else { /* Station mode */ --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 288D21FECB1 for ; Sat, 26 Jul 2025 04:33:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504409; cv=none; b=EnxtC5LKAmCpyPDLEUpLcYY2uREc33jm2VS0x6U1jC9x9ZTcVlIijeOR8zaKZ5+pJKFJUoFZfYIhD8lkGDfdNCF7+VL8Id2NCDjRdpkmupdDK+8MFnT0pSZyGsz6h9M19Fi8qUYAy6T27EEY1Sf9fmBaxDryIEHbpl9kYiUbVlI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504409; c=relaxed/simple; bh=QR+87MBsf4OgmCpwKkmvsTI1JdBPdhj46JPSf6Yk5t0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=je0bCQK/46KBZcSkHVBMxIGJe16CbJPJqo7KikPp+WMlO4PCIy7wjG6r7JzY7EinY5U2STnD/h4YDwSkoCAgxFJHJH/ZGWYIJ6Ptd2ALMKxzvo4kgDHrysL9u3RmBP9rGIARB65+iqOCPYM7pw7FLoEQRsgYgj454DKRUqcE7vE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SsjqXTc7; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SsjqXTc7" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7dfd667e539so297720685a.2 for ; Fri, 25 Jul 2025 21:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504407; x=1754109207; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W6hYRrHT08oHtqOMqL9kRQfmrIHgkckvZt+rGGA91Bo=; b=SsjqXTc7Qmy8dmDku5XCFT8HCoLG92wgERA640RQyldzRDIowuCeM1N2w/PpvxQpRM 1fvTf4SprH6c8Vbj7qYE0j8SSVtDrqYHBHRXIwoN6JGq0qhYW0XcNy84cLRPr+g+CXYY jLweTS6z1mAee4t+QrHQK09PafajZ3Xxy6p6a0543Oz6yGFh5NlmFgtxTzLNRZ6Bqs96 Rk+UKIPfJ5ChiK9S/x6asJ+4WQHVD31TkUWVQciSPNjgjPt0lUORaLfsA7UTBwwc0geV AMGKnlj6wteTOypKNRwu+WyxyEdcNsOEDSWLs/NheSEvE/gjQTLygU2A9xaWD8ysXr0Y 610A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504407; x=1754109207; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W6hYRrHT08oHtqOMqL9kRQfmrIHgkckvZt+rGGA91Bo=; b=G0QNEDKwtqaZrz8D7V01wyqUzUsob8sczNUMMsyHNPOcx4kCFXJDe4kYwsEMZnn4Nk Dqf46uf3p1e3r7cAD0WGar07b1iB81GHFUXJSqRITPqGEpu+JaRsEeAbvrwsd6A9MQN6 Nr4Xc8SXy0CxylYykYcR1Wp2EDl1y6k6WXG303Zx9mGTVzGjPSfB54y/op60oVQuhne1 Yot4Np16hKZjDg/w0GzwLwMlv0HlsV6rrKLbU+yzp3uiVXktL9x3/ieQclymnu8PU47Y uizX06+bAXMCXvNHIlkc9sknLfHTbNq4GlkCdyoGVHH96TmIwbnaUFuY/pY5UnzLYRT7 rvYw== X-Forwarded-Encrypted: i=1; AJvYcCUiT/DUno9qF/36WYwSMPXQ1piW2ztH+wQnCiLlY2Z4Ia1iyYu2A6W2/b3c4I57CxHkZivoQ3FaJt2L/tg=@vger.kernel.org X-Gm-Message-State: AOJu0YwpaALHF4zBNvqg3xik59S1f5p4Y1LyFmdg+YKHEMZOd6tItQc7 +mjQyn2WdFfsmSP1Wilnl4uZktIRdPzJyQg/FRB3xhszbVGZTrqyA2M/ X-Gm-Gg: ASbGncsKVA4bgUeY7adjom8cmeh9HtW3u7Ksu53mDPAy51ioBrTeZ5VbdCdv768zBO8 0Q6ybOIzmN/klpoDVsYGR9+JlwfPbg0QHQzhDilvGn9jFQVMi6OOwqcnCahAGT1IpUqC/lwB/CF yV6GDjLKbZte/Oiem6Hytfu/RTIXSeddzgVKKZQh/ii2tEwdiPYB2jL3UrORobptH6wG8Lu1zx9 NDNVH/jrrx37nmNyaeMW92hXWkjpXg+mu1CI6ix+aeXdk30aayN2PH/yQiydSQrU5YG9lHJRaVd Q68FOImLkQ3zNEgZou2zHTaM/U3uBqcZDECiWIDQPKsWstfwjp9Eh+JRRzLgzsvdnCicCgmpyPX L7is5RH/d/fAiTN/uDqN9CrTvL4jA+szcOOqpDb2xpo+QPbjCG5I= X-Google-Smtp-Source: AGHT+IEvB5myWSkGQX6iGwDteC2wCyMcHleORlGWo9rIqgfFN+b9ih+3L+ScgvxVYpyZvv0tbfjIqQ== X-Received: by 2002:a05:620a:2892:b0:7e6:21cb:c331 with SMTP id af79cd13be357-7e63be53012mr611666385a.5.1753504406978; Fri, 25 Jul 2025 21:33:26 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:26 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 02/20] staging: rtl8723bs: remove unnecessary blank lines around braces Date: Sat, 26 Jul 2025 04:32:00 +0000 Message-Id: <20250726043218.386738-3-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver contained several unnecessary blank lines immediately before or after opening and closing braces in function definitions and control blocks. These blank lines break the visual flow of the code and violate the Linux kernel coding style, which discourages superfluous vertical spacing. This commit removes the extra blank lines to improve code consistency and readability. No functional changes are introduced. Identified using checkpatch.pl. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 29 ----------------------- 1 file changed, 29 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index da64d5714237..24e505111f1f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -170,7 +170,6 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, str= uct wlan_network *pnetwor =20 void _rtw_free_network_nolock(struct mlme_priv *pmlmepriv, struct wlan_net= work *pnetwork) { - struct __queue *free_queue =3D &pmlmepriv->free_bss_pool; =20 if (!pnetwork) @@ -225,11 +224,9 @@ void rtw_free_network_queue(struct adapter *padapter, = u8 isfreeall) =20 phead =3D get_list_head(scanned_queue); list_for_each_safe(plist, tmp, phead) { - pnetwork =3D list_entry(plist, struct wlan_network, list); =20 _rtw_free_network(pmlmepriv, pnetwork, isfreeall); - } =20 spin_unlock_bh(&scanned_queue->lock); @@ -318,7 +315,6 @@ int rtw_is_same_ibss(struct adapter *adapter, struct wl= an_network *pnetwork) ret =3D true; =20 return ret; - } =20 inline int is_same_ess(struct wlan_bssid_ex *a, struct wlan_bssid_ex *b) @@ -348,7 +344,6 @@ int is_same_network(struct wlan_bssid_ex *src, struct w= lan_bssid_ex *dst, u8 fea (d_cap & WLAN_CAPABILITY_IBSS)) && ((s_cap & WLAN_CAPABILITY_ESS) =3D=3D (d_cap & WLAN_CAPABILITY_ESS)); - } =20 struct wlan_network *_rtw_find_same_network(struct __queue *scanned_queue,= struct wlan_network *network) @@ -380,7 +375,6 @@ struct wlan_network *rtw_get_oldest_wlan_network(struct= __queue *scanned_queue) phead =3D get_list_head(scanned_queue); =20 list_for_each(plist, phead) { - pwlan =3D list_entry(plist, struct wlan_network, list); =20 if (!pwlan->fixed) { @@ -389,7 +383,6 @@ struct wlan_network *rtw_get_oldest_wlan_network(struct= __queue *scanned_queue) } } return oldest; - } =20 void update_network(struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src, @@ -424,7 +417,6 @@ void update_network(struct wlan_bssid_ex *dst, struct w= lan_bssid_ex *src, sq_final =3D dst->phy_info.signal_quality; rssi_final =3D dst->rssi; } - } =20 if (update_ie) { @@ -486,7 +478,6 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t =20 if (!oldest || time_after(oldest->last_scanned, pnetwork->last_scanned)) oldest =3D pnetwork; - } =20 /* If we didn't find a match, then get a new network slot to initialize @@ -530,7 +521,6 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t pnetwork->network.phy_info.signal_quality =3D 0; =20 list_add_tail(&pnetwork->list, &queue->queue); - } } else { /* we have an entry and we are going to update it. But this entry may @@ -591,7 +581,6 @@ int rtw_is_desired_network(struct adapter *adapter, str= uct wlan_network *pnetwor return true; else return false; - } if (adapter->registrypriv.wifi_spec =3D=3D 1) { /* for correct flow of 8= 021X to do.... */ u8 *p =3D NULL; @@ -868,7 +857,6 @@ void rtw_indicate_connect(struct adapter *padapter) pmlmepriv->to_join =3D false; =20 if (!check_fwstate(&padapter->mlmepriv, _FW_LINKED)) { - set_fwstate(pmlmepriv, _FW_LINKED); =20 rtw_os_indicate_connect(padapter); @@ -876,7 +864,6 @@ void rtw_indicate_connect(struct adapter *padapter) =20 rtw_set_to_roam(padapter, 0); rtw_set_scan_deny(padapter, 3000); - } =20 /* @@ -929,7 +916,6 @@ void rtw_scan_abort(struct adapter *adapter) pmlmeext->scan_abort =3D true; while (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) && jiffies_to_msecs(start) <=3D 200) { - if (adapter->bDriverStopped || adapter->bSurpriseRemoved) break; =20 @@ -1022,7 +1008,6 @@ static struct sta_info *rtw_joinbss_update_stainfo(st= ruct adapter *padapter, str } =20 return psta; - } =20 /* pnetwork : returns from rtw_joinbss_event_callback */ @@ -1397,7 +1382,6 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) =20 if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { - rtw_free_stainfo(adapter, psta); =20 if (adapter->stapriv.asoc_sta_count =3D=3D 1) {/* a sta + bc/mc_stainfo = (not Ibss_stainfo) */ @@ -1431,7 +1415,6 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) if (ret !=3D _SUCCESS) goto unlock; } - } =20 unlock: @@ -1490,7 +1473,6 @@ void _rtw_join_timeout_handler(struct timer_list *t) =20 /* indicate disconnect for the case that join_timeout and check_fwstate = !=3D FW_LINKED */ rtw_cfg80211_indicate_disconnect(adapter); - } =20 spin_unlock_bh(&pmlmepriv->lock); @@ -1540,7 +1522,6 @@ static void rtw_auto_scan_handler(struct adapter *pad= apter) =20 if (pmlmepriv->auto_scan_int_ms !=3D 0 && jiffies_to_msecs(jiffies - pmlmepriv->scan_start_time) > pmlmepriv->a= uto_scan_int_ms) { - if (!padapter->registrypriv.wifi_spec) { if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING) =3D= =3D true) goto exit; @@ -1673,12 +1654,10 @@ int rtw_select_roaming_candidate(struct mlme_priv *= mlme) phead =3D get_list_head(queue); =20 list_for_each(mlme->pscanned, phead) { - pnetwork =3D list_entry(mlme->pscanned, struct wlan_network, list); =20 rtw_check_roaming_candidate(mlme, &candidate, pnetwork); - } =20 if (!candidate) { @@ -1770,14 +1749,11 @@ int rtw_select_and_join_from_scanned_queue(struct m= lme_priv *pmlmepriv) =20 phead =3D get_list_head(queue); list_for_each(pmlmepriv->pscanned, phead) { - pnetwork =3D list_entry(pmlmepriv->pscanned, struct wlan_network, list); =20 rtw_check_join_candidate(pmlmepriv, &candidate, pnetwork); - } - if (!candidate) { ret =3D _FAIL; goto exit; @@ -1863,7 +1839,6 @@ signed int rtw_set_key(struct adapter *adapter, struc= t security_priv *psecurityp adapter->securitypriv.key_mask |=3D BIT(psetkeyparm->keyid); =20 switch (psetkeyparm->algorithm) { - case _WEP40_: keylen =3D 5; memcpy(&psetkeyparm->key[0], &psecuritypriv->dot11DefKey[keyid].skey[0],= keylen); @@ -1939,7 +1914,6 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ } =20 return ielength; - } =20 /* */ @@ -2311,7 +2285,6 @@ unsigned int rtw_restructure_ht_ie(struct adapter *pa= dapter, u8 *in_ie, u8 *out_ } =20 return phtpriv->ht_option; - } =20 /* the function is > passive_level (in critical_section) */ @@ -2346,7 +2319,6 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *= pie, uint ie_len, u8 channe max_ampdu_sz =3D 1 << (max_ampdu_sz + 3); /* max_ampdu_sz (kbytes); */ =20 phtpriv->rx_ampdu_maxlen =3D max_ampdu_sz; - } =20 len =3D 0; @@ -2437,7 +2409,6 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr rtw_addbareq_cmd(padapter, (u8) priority, pattrib->ra); } } - } =20 void rtw_append_exented_cap(struct adapter *padapter, u8 *out_ie, uint *po= ut_len) --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8869A1FFC48 for ; Sat, 26 Jul 2025 04:33:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504413; cv=none; b=pwYswem/hs/hhKQ3r2Xw36DQOk93zPYVOkLjnG8RN5qHClfrGmU4j4aV/SleKc/KyB94cpyknvVuPdYK4qs7cCzHS0mr3UDLXIrosQ0RB7H93+zV0fHs7c1mnEjSRx1hUoZoqwyZQkNk9g2V0ZwE+NQUfvB/wuGOJe94e0c9gn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504413; c=relaxed/simple; bh=tYsaqE+HPjL5E1qdQhJfbmYvOalIUtt08sYSjG5aD+U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OcMBx9RLkyB3CKzFvbAOqxzkxQ2q1kGMflhCHateS4KvjB2U8aoPSV6ieA3I6gLVRvfVmbTvGkzTqzOzk9RPocPfUsmBAshX0vS0wIVWMItOthzM2fozRX3lNLlmPn2iG0F9Hr15Ajpx121MjeCpxXSmXCkxLo59NxRKi8/75gs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T6AqMclb; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T6AqMclb" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7e278d8345aso264999885a.0 for ; Fri, 25 Jul 2025 21:33:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504410; x=1754109210; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/k2cDsMk2oCpoOkSVurQZenmcKjISWvt97q0c4W0lmM=; b=T6AqMclbbIUusAjKZXCw2V/OgtIdulhHWQsUNueGOhnDlmCrjAOWYrnMGAwOAyvmS2 6xc0juG/z0CCWK+04JUpPUH0UlbgzJylRuiMbD0PQr3WfjhBlAkx4Srpdo0QBbg//ZzG axjMIkVTMParQ348AvJiDmp/Dv3EYMtCHd+/PZw+Vf2mCVWBQxA+59uopa4lncCgO7Gn y2iicXtF/iaXcJOeTsjHINCuN8CTj08djyTmlptySfyw0pmUuygEMqIRkFE1wLi/I9rv nONlWdL5JZU30c7F9jwvQ9rW4/o2TyEdPw7PRMYYxvNGY7DP9ATw7sleuqRtzLZ0ODdN zBJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504410; x=1754109210; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/k2cDsMk2oCpoOkSVurQZenmcKjISWvt97q0c4W0lmM=; b=VswBI/BpWtbRe0XQIXdBFzbfhJ0A8+/aNSEoovUOgBmTNYrej5zRLENXXBa1Xxm7DL c3finEF4rkUe09lw8wSnz2Tm3SYC6X7XApisy3DhrHZ8lCWcp6gPnA05sqNaPyuo/V4W W0pJZiYEeAhSL1lLdssEbn8ng9Jj+wEOULyduwrOnyWQEMasmFiZ3yCLduC97G9K13r/ SzC6QkYQVAwIH63xLBqAQIdc2Mm7ywrYPTNRE7+DOLAxpD9vowbXVPS4T6Zb6Gqr7tD4 fXoYxksn4Pj9tEpwfpBTOVsf57mcuUN+VZC6dDyA3mMDZfpYMB+J/IG5TmDBgXJ3+hhU t5Zw== X-Forwarded-Encrypted: i=1; AJvYcCXBrMTBx581NQjVFuT7ksyUnsPcJBn4mArJ2twztffTBJSbBnTwzuNJpUovRJqwNZs8WruqpcmFGNSi4zQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyUQex78GDTpGX/rlOEPzHNuWqDmzbY7hMKp7cnIBwmJ44HNsVb DIijWPB8h2jsJCptt0q6uvv9tvTWcPjFhkHlwZ8msdg4A9R9Nzko+bE5 X-Gm-Gg: ASbGncuLT5IbMzagPBW/Vmsu3/PdYo0NoZWY4T7S9J9n4srXdNw5dubQM/ioM8gZ9an een8tF1ampiIlgacELT/lgBY487hwi8XAzhY2iRdPP4piBifH8pY96DkW+rh9ch9nIjJRLIT0q2 8qFfaO09+S0XTsy0i+ISDFxI952+9n7QqSPMsZaL/woC3XhTpIIE/lIpUMxBvmohuiLFIBm9gSc yAgBkh1nxY+8mp1i0K5cngUFUH+Tz5NbaZH5xHDvh0TMKwZaQoiEqf3XFltJ///p7ZChuaArlfQ oi+hZD2n+EGirjLIS8wnSUefascFb+hLbN4z2hPZdbDhm+wHXdHAzRL+Om+biSqfHR1n9pqsAuU 0aiWELR1Z5JBQZfX3MF4Z5QlbKIwzljnuccjBcm00k5+PR/Y3NT8= X-Google-Smtp-Source: AGHT+IFYfEYgKakbQHiU8jBMRd6ycnt6dd42lkFWDBLnfbudTYbPCAPqxcuWnXkvHgBv69Mub6dI+g== X-Received: by 2002:a05:620a:462b:b0:7e2:769a:c857 with SMTP id af79cd13be357-7e63be3871cmr599030385a.1.1753504410423; Fri, 25 Jul 2025 21:33:30 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:30 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 03/20] staging: rtl8723bs: add blank line after function declaration Date: Sat, 26 Jul 2025 04:32:01 +0000 Message-Id: <20250726043218.386738-4-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Added a blank line after the definition of rtw_roaming() to improve code readability and conform with Linux kernel coding style. No functional changes made. Identified using checkpatch.pl. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 24e505111f1f..b1a427a655ef 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2449,6 +2449,7 @@ void rtw_roaming(struct adapter *padapter, struct wla= n_network *tgt_network) _rtw_roaming(padapter, tgt_network); spin_unlock_bh(&pmlmepriv->lock); } + void _rtw_roaming(struct adapter *padapter, struct wlan_network *tgt_netwo= rk) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66FFC1F8755 for ; Sat, 26 Jul 2025 04:33:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504415; cv=none; b=RTYJIBhl/+Nm/NsemcTtYy8Tub/IV37rmJK7BIye+sMILSK8qYgof4voR0gxs7UZbUreUu+JjkE4mRg4EaED6QvM1SYNzIOhihoTVPRfw/fWhREPwOmjhE6MUWO60FXfPcCBESz7C867Uf3iGIms4JSF0axBjvhP5mEjilQ9H6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504415; c=relaxed/simple; bh=Hln+RE0XFXcl6Q+ZxGFN8IgMNryMqgMXLI5PboDwAkI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Q7fx3y1572gOLhNqd3OY8KtDCk4bLtmxMOkFruCv2herEtsW9ZOOWZW6pjz8kpqM31x56Ibqd4njFc5dvGZ7iIdTcoUapwqrNx5JqqBc70d1yhBtPxWb/aDQFI7YGnAfAdUXJOkegi1tQyHVMK9vwLDPalcFhNKBWK48ClXDo4g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m8JrFBiX; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m8JrFBiX" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7e6399d0654so88212085a.0 for ; Fri, 25 Jul 2025 21:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504413; x=1754109213; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YjkPbkLKXrC1x69MnZUinhNSbgEsQTgvN0JCPdlTAvQ=; b=m8JrFBiXa3604iUUknyGOG1+DpkDV4Bzci4WM+mHaCLXPq5uCPbdyqrytjFbCzKdB0 HflmkN1Qo8560GeUQRTKdjpRT2VHmJ01BrBVg8MahQDI3tA7dCOio2jtTDBZP+QPg25O xC+HV0ws96v6Dk8VW6Y5+LZZYhGH2p+C7V4gNKKP7jA/PtkExR01SoH4bhEu9xWm1ByI JsYRhsWJi5Ukv+T70Oy+fuLwglhjBRdcmTIU8msHkcdGTK7SfmfyItDf70br0sijtF/y Np/eATaqVDKINcbcH3HjKRCia2oZwdLx0ffT4X/BXomzAveFESz7QpJ+Ftd8jI92om+u lG0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504413; x=1754109213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YjkPbkLKXrC1x69MnZUinhNSbgEsQTgvN0JCPdlTAvQ=; b=CNCt8uiUYZ/4VU7oKHBpms5raOaZToxMN6uZCW6FiSQ4pL1VBW4QD5+GbeTr0STeJY oCRRQBAqgrRA7WRLT8oA++XalNFZxOwhto3gbnDJ+S7jfOmhMb5j6zXjZfC5oYdZBfBp yQovirdYTWyQLagZ/5UKqRqKe+H7mdinSNMxS5pKvXlbGkz4EDnO5JRcgZZe4IclRUmW pBx5Eu0K68M6N7vSM6Yhsd9mwu9ZjXRVB/BSVByfvUwC3mNcX1ydhgvcaudnALhHDR2J yPAnH7BbTuYQYowJu8mxEO0FLe9Lm2PuYLvtmwEBmqbvkStrLGt11/YaT2fcIMw5XpJh kbzw== X-Forwarded-Encrypted: i=1; AJvYcCWHfPfPhI4d2Y0FBFpxLUFKruOjWY4NmHBcNy1EcBopM+2SjNQiYloQH+o7uZGGKI2b1qBdZuLZDkxdjps=@vger.kernel.org X-Gm-Message-State: AOJu0YzBLzNa6e8oEO6SPD39bt8kWQ/3ZrU34+w+RPMvR/9AEgGjSSM2 4wkYyao8JzM+6B8RVrFQeB6p4sBVUR6d5KBMN5Ji96EdeDh+KSmJWRa4 X-Gm-Gg: ASbGncuh7xU4GnApzkgL2/mEeg9tRIWyKtz5x3rtPJKNNsuIGsD/vK3ZW9zCekiW5zS rQI5pp7gRFlDJt1RU2Eieb9VKpyNcsr9mUIBRsPg2vWepPLZvpZjD/426BibNSVWHn/qzpcohcc EFW8/x0zxhrwmWBh1b/2Cvhfj+9lg7LN153Ss8srkRbV83/J6F1tpkeEf7NZgKdUc4OA+j8rEQ4 BLC7tmnF6peCLKVdWM+lKjBBtZrMrFWEYgcsPYCYxexCGa3j5POT0iW9V7kjPa6RnYkslEmFZwq jCy3WW97W1vxKRHjfBCTugO87D7Nx/ZSnCrvp9DIJoBbVXHcZw9gA6eV/XiX1cEUK5TON/i1sXz XAyrWSJCQa47JPvW8/3pYdlL+azcjuAB7vKu9p4dJ0Tt6m6pdBnU= X-Google-Smtp-Source: AGHT+IHADvqH6vA5wfk2ynhAPEHhDZbOKKGLISpDsIW3emLm5YPAfEmoxlfJG0uV7s1fKXA03oR/sg== X-Received: by 2002:a05:620a:4046:b0:7d7:79ff:a1e5 with SMTP id af79cd13be357-7e63bfb09c4mr486653285a.29.1753504413258; Fri, 25 Jul 2025 21:33:33 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:32 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 04/20] staging: rtl8723bs: remove unnecessary space after type cast Date: Sat, 26 Jul 2025 04:32:02 +0000 Message-Id: <20250726043218.386738-5-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Removed unnecessary space between the cast and the variable in two instances of type casting. This change improves code consistency and aligns with Linux kernel coding style guidelines. No functional changes made. Identified using checkpatch.pl. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index b1a427a655ef..536b6d036e88 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -1055,7 +1055,7 @@ static void rtw_joinbss_update_network(struct adapter= *padapter, struct wlan_net rtw_update_protection(padapter, (cur_network->network.ies) + sizeof(struc= t ndis_802_11_fix_ie), (cur_network->network.ie_length)); =20 - rtw_update_ht_cap(padapter, cur_network->network.ies, cur_network->networ= k.ie_length, (u8) cur_network->network.configuration.ds_config); + rtw_update_ht_cap(padapter, cur_network->network.ies, cur_network->networ= k.ie_length, (u8)cur_network->network.configuration.ds_config); } =20 /* Notes: the function could be > passive_level (the same context as Rx ta= sklet) */ @@ -2406,7 +2406,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr =20 if (issued =3D=3D 0) { psta->htpriv.candidate_tid_bitmap |=3D BIT((u8)priority); - rtw_addbareq_cmd(padapter, (u8) priority, pattrib->ra); + rtw_addbareq_cmd(padapter, (u8)priority, pattrib->ra); } } } --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2E44205E25 for ; Sat, 26 Jul 2025 04:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504419; cv=none; b=d6ETBiNrtz1xB563WxOwgq8QbeRqyHg+DNE4Dy++mt8JoOKldoBdTxOo0DbWrUO0NWjDhPjXCXPNLkJcI/CwiBPgIZL/s5Q4W4hiPqsMKSfI9MAfebXMKuXYT2aGZRGyxHCWl3EyV9sMgv5+fz0xEcPCGWSOGGjl70qkwSxLqac= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504419; c=relaxed/simple; bh=xmYYMyOZJwjwp2JTaH48jAKSP1kH73X0D1fbu/mH484=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Zp4OebVlKupCBDS7ciDmlxR1vYCJZg27HsOoF7S49iGWiElXAHoE7AzWZtWP5xzWVZOLi8F0rPvPeQunZy9sEbwF0PeoD/JSLzRgqXlNQCOa7J09RBIkbjLq/ZeWS2SKLMpYy3I0pBNRe+cvOxjwGnGBv0hkT0U23Vu1sgYEpFY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VVfvPZDH; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VVfvPZDH" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7e33d36491dso383512785a.3 for ; Fri, 25 Jul 2025 21:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504416; x=1754109216; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nah+LM+soUeFmNwfK2IEfdnCoc7CZm0auXL4WL3rki8=; b=VVfvPZDHJQj7C2humbjh/3XD6T5EubxwvZis3mq2MTmLA+wEMOgyGRoUnNK+dZ4Vde WeY6fpm5KLP4QyQMUo3wLrdWKIMNQckXiEkXBqcwMr0DvKqQaxqpZJ/b0gvmupkx5HJK dT3tjIUt3j/7tyqLRsaEzs1xRlbD4EbccLWaAa8zSYxLlHEcEl7ESybhzAM1b0Mkfbxi fIYAqhmCBDREa+CJU9CsL3vqa5Z7mIAYiwp1jJy1mR6KF+Ss6O4TAfA0GvP9Uj0N2hQq BNvzcCdj5KgPMwU0oZA7Qx4eZ2QmDdnOPtJiqV+1VkzVDCM6lhgWGjgvKAXVqHntkgJj /+kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504416; x=1754109216; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nah+LM+soUeFmNwfK2IEfdnCoc7CZm0auXL4WL3rki8=; b=J4yXiWvPD1RaWkhX4u7XmV2v7+ojZYBD+Pi1rZRlDyMlPif8Vp9siFxYKaLgjo3U0H n0keqgmM4hbSVfM7waGh7wJUX1AOK5naSM4IgaxDidIV+l3e9PtS3wCJ+fOqseFKfOYc nkFbw3X8EuM8pu4cK98i71mpfU6P2dqQbw8GL4ISXsaOfhU2V9YGvcwaYQIELMf0p0GN 8N1kE+afiHhmLgQ2zQDCiUjlX8oJxOjuG387MPirZ5cUhF23Ptex5tn/rz4xQbOK0mol wd3F08iipNtR9FXAizptDe+/UcaAuhgFZqpetHKe7cEgWxIdw1OXEWXAr3pQcM4CjtCt kwvg== X-Forwarded-Encrypted: i=1; AJvYcCXZLnx1tpMomfPSnvVllUfvzzW18eRUVug46nYLOys1RcNPLiRJ2r6hs2XbwJCYvbB2aUrBGcZeAHBl0+4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyel9Q5SBBF8R26q6onOasHHbSUBgRxmkS5Uznd/FbVx9A6J1N5 /hiwkHv+J/mPw60meylicYQC71+YLVraqK0AVjWLSkdXJkliHBhSMJCsagCHpg== X-Gm-Gg: ASbGnctFeX/LP6wv2BXzqh0uKIWPbbh6NDE66MW2htHwiavgbne0KAF0XekQBuCnnfS O/c9Zy0g3gnE2+25u/RKo1KRQX63V5mBurIdH9LGEPDXn3SMV7WGEhluz1oLP/qYnhw2pj0r5X1 sSKBL5a/vYVMaGLs/L/LXGMDm15Glj8SAjRmdkgDpQ2zJHQZOoXiMVVFfNn44ez9FsZvVzRIjff /mc/CgQ9TSa1F+qTjcb4XWYZOi+zVGDlo5HCisa5HOTugWSGr7T7wcsaD4A8j0snof5v1tRqGZu byeBUJ4O1CFVvbXt6QGDMHkoBUHyK92qvGNlMsng4oU0rEwTwG2IadU35iFf4Fr0C6IyiEifpOZ 7O7Rlxx0F9OppRel4S7Kf8lcJyZXOYPu4DxFj9NeczljV/1pQiQI= X-Google-Smtp-Source: AGHT+IHqImVx161CnR8opFPNvrqp44DGum14iIX4WljcQ4qQP0d3IMEZTB3jJOmQ2Y80Ec/Sak268A== X-Received: by 2002:a05:620a:4591:b0:7e3:463a:5189 with SMTP id af79cd13be357-7e63bf53d4bmr614021485a.1.1753504416552; Fri, 25 Jul 2025 21:33:36 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:36 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 05/20] staging: rtl8723bs: remove space before tabs Date: Sat, 26 Jul 2025 04:32:03 +0000 Message-Id: <20250726043218.386738-6-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Removed occurrences of space characters preceding tab characters in the codebase. Spaces before tabs cause inconsistent indentation and are flagged by checkpatch.pl as style violations. This change improves code formatting consistency and adheres to the Linux kernel coding style. No functional changes made. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 26 +++++++++++------------ 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 536b6d036e88..f8680124ce24 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -559,10 +559,10 @@ void rtw_add_network(struct adapter *adapter, struct = wlan_bssid_ex *pnetwork) =20 /* select the desired network based on the capability of the (i)bss. */ /* check items: (1) security */ -/* (2) network_type */ -/* (3) WMM */ -/* (4) HT */ -/* (5) others */ +/* (2) network_type */ +/* (3) WMM */ +/* (4) HT */ +/* (5) others */ int rtw_is_desired_network(struct adapter *adapter, struct wlan_network *p= network); int rtw_is_desired_network(struct adapter *adapter, struct wlan_network *p= network) { @@ -1819,7 +1819,7 @@ signed int rtw_set_key(struct adapter *adapter, struc= t security_priv *psecurityp u8 keylen; struct cmd_obj *pcmd; struct setkey_parm *psetkeyparm; - struct cmd_priv *pcmdpriv =3D &adapter->cmdpriv; + struct cmd_priv *pcmdpriv =3D &adapter->cmdpriv; signed int res =3D _SUCCESS; =20 psetkeyparm =3D rtw_zmalloc(sizeof(struct setkey_parm)); @@ -1922,8 +1922,8 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ /* */ /* Search by BSSID, */ /* Return Value: */ -/* -1 :if there is no pre-auth key in the table */ -/* >=3D 0 :if there is pre-auth key, and return the entry id */ +/* -1 :if there is no pre-auth key in the table */ +/* >=3D 0 :if there is pre-auth key, and return the entry id */ /* */ /* */ =20 @@ -2073,7 +2073,7 @@ void rtw_joinbss_reset(struct adapter *padapter) u8 threshold; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 - struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; + struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; =20 /* todo: if you want to do something io/reg/hw setting before join_bss, p= lease add code here */ =20 @@ -2099,8 +2099,8 @@ void rtw_joinbss_reset(struct adapter *padapter) =20 void rtw_ht_use_default_setting(struct adapter *padapter) { - struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; + struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; struct registry_priv *pregistrypriv =3D &padapter->registrypriv; bool bHwLDPCSupport =3D false, bHwSTBCSupport =3D false; bool bHwSupportBeamformer =3D false, bHwSupportBeamformee =3D false; @@ -2174,7 +2174,7 @@ unsigned int rtw_restructure_ht_ie(struct adapter *pa= dapter, u8 *in_ie, u8 *out_ u8 cbw40_enable =3D 0, stbc_rx_enable =3D 0, operation_bw =3D 0; struct registry_priv *pregistrypriv =3D &padapter->registrypriv; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; + struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; =20 phtpriv->ht_option =3D false; @@ -2294,7 +2294,7 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *= pie, uint ie_len, u8 channe int len; struct ieee80211_ht_cap *pht_capie; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; + struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; struct registry_priv *pregistrypriv =3D &padapter->registrypriv; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; @@ -2414,7 +2414,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr void rtw_append_exented_cap(struct adapter *padapter, u8 *out_ie, uint *po= ut_len) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; - struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; + struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; u8 cap_content[8] =3D {0}; =20 if (phtpriv->bss_coexist) --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ECF420A5EA for ; Sat, 26 Jul 2025 04:33:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504422; cv=none; b=Oa1hp3X/ay9YpW/VrGTdLbclKkGDw51MFDEtceavprrcF9QRYA3Ws1fyHLtOk+FQDGcGq5GXc8wifXLTEGhg4eseUHqOvuotnKSNC0LuWl1JVcBBTBAjiHCvOUmTOGGmDMyW5FwLT8wCsRuV0CmaYFT7wbJJEetea4XDX7fbrBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504422; c=relaxed/simple; bh=SRxtK0JH89F8hBmSzbGvdaaHXorHThTNvv+kEsGvH8U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KF8CMV8J8stS6bZ+xH6ThWjawa1pkMOuqxa5pxeclnVgD+dYKJ6YqqHc0nvd8EU1ttM0RPQSf79QJ+LbBBYFmsZc8b61VYcpPJsNatdFt8kUUHuzXp+oKdqq6vpYX8P/kexIoBM13BzMjaIQ4zGQnlfXAeOQqeY+kZ6M6XIGGOc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ct8iFYAZ; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ct8iFYAZ" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-7e32c95778aso138627485a.3 for ; Fri, 25 Jul 2025 21:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504419; x=1754109219; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N+DVbx1MrURkCA8xTzQLnT2mXdd8wFgAshN4l3PzqwA=; b=ct8iFYAZ8rFoHzyKsTqF4v+vM4oxGrtOXnHpjKr4lcl5OSy7Zh8qC68ggfdWft8Gcm nmEGFGHexjeu5KFggR+AaM+im65dP0IGAPNlKkiWXklak+7Hre3Zj0CU0lPW8/qvbJo9 dkpGcNGnBUNIuWolGDT75ft3j0jCD0yOqDhnycQDIF0YgaNy/+ymBD4kV+BSfgIchccs cKO++EPJqHm+VplzOGpIZVAEGrnCbxrJuawMFWHiEvKvqpXDJxUyHbIt71LTfYU0OySf NdrTemxm0SvCSYiPxV4JPGGvPVpxBQ1z0IerIbUO/4DK4hqmz9ycM4UExHGt29S1rIUQ iDng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504419; x=1754109219; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N+DVbx1MrURkCA8xTzQLnT2mXdd8wFgAshN4l3PzqwA=; b=bZQxk1yzAek3MTf7qKwW3lZSJ0CysEmhA9nTAwvDHxz449JYYxtfKvi4mevbmRXSxv 18KsxAeHRpMbHQTyZSG9fVqLyiRJB/Sqg5mlhnDriJjmkIW2b/g+fkzv4qRKQCZJ8neX 2LdVkzaJINGP9xyXfduhERucJrxwpk5uGdNL/KOUQ3bEA9ZCORmgAZqugcU8xorexZHq 8Hgu3m882pZLa0EPSGwKzNjgwvav4ybEsi9npknu3wwQ2JCG1faKv8sq7cGUR4XmQUAa UtbKUJhvG7bqz7kRKC21FvLe+9pFYXqL+KCUEw+OJjaIFbaRGLrJXjSAv+yoccQpJGZL 7YXQ== X-Forwarded-Encrypted: i=1; AJvYcCVxrNRQZMq6dunQ2DVfWEAZsd2C7hGDstnwIWWyGrtdsgEqbl4VJzxowHH2PnskmV+4I6d1Oiyesq6dWJ0=@vger.kernel.org X-Gm-Message-State: AOJu0YzcekKSnU2bgVQ9fh2zpagL2e/EGISSYVeCeEPvexyF/ARqd2gG CBMSEimrjI3USP4ji8D+aS0voY6P/q7izntldr4Z6O73lOAIq74tt/J/ X-Gm-Gg: ASbGncunmbZb8kcrA7FjeZFX7j+j3F0qAhdqqCg5Xs3CiDT1EJOhw/2cEFUaC2ZV1gV y+XSI2kcow4TEIjdICmMhPCeq80RxLUrlT1/v/PEmq/TYQ6AAinS6RYuKu/zPme+NVJR3+tFZvE DZSRzrLLO+8Zh59ZnaDdB5ACa964YGH6jfYi1/hznoaSkboG7LdfTP07bOaqQ60Gfc6y9gCz7jp xgmUlzR0xMEE5tKq3ZRLpEmo+Rh+4OUxFRtbOPTMmk7r8EANYQhu4CPQkNpvu4O17jq2DXCtkVW VmmLRYgf6LghNO5s6rNJ82gzs/rQNcAof5UWi/8huklUqVsF26k6Y9JBxa9EJFpzqXtLakN71Uo MEfqbOX+Xh2qkMmm5kRkhFvDkevqA4LFE6bhETy6zK3WBt0+MRA0= X-Google-Smtp-Source: AGHT+IHwvk+B9W8uYCycFDMT6p8Vu2V1fah6Knu6y7JULxBVIj9mj+jlK7uEwha8Km1Kn1alAtfMjg== X-Received: by 2002:a05:620a:31a5:b0:7e0:e7b0:967e with SMTP id af79cd13be357-7e63bf5b671mr568167685a.7.1753504418915; Fri, 25 Jul 2025 21:33:38 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:38 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 06/20] staging: rtl8723bs: fix overlong lines and clarify lengthy comments Date: Sat, 26 Jul 2025 04:32:04 +0000 Message-Id: <20250726043218.386738-7-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This commit addresses two main issues: 1. Fixed multiple instances of overlong lines in the code to conform with Linux kernel style guidelines, which recommend lines not exceed 80 characters for better readability in various editors and tools. 2. Clarified a lengthy comment block by reformatting it into a more readabl= e, multi-line style with proper indentation and phrasing. The updated comme= nt now clearly explains the function's context, parameters, and behavior in a concise and structured manner, improving maintainability. No functional changes were made; this is purely a code style and documentat= ion improvement. Identified using checkpatch.pl. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 242 +++++++++++++++------- 1 file changed, 166 insertions(+), 76 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index f8680124ce24..fb1768284c2e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -22,7 +22,10 @@ int rtw_init_mlme_priv(struct adapter *padapter) pmlmepriv->pscanned =3D NULL; pmlmepriv->fw_state =3D WIFI_STATION_STATE; /* Must sync with rtw_wdev_a= lloc() */ pmlmepriv->cur_network.network.infrastructure_mode =3D Ndis802_11AutoUnkn= own; - pmlmepriv->scan_mode =3D SCAN_ACTIVE;/* 1: active, 0: passive. Maybe som= eday we should rename this varable to "active_mode" (Jeff) */ + /* 1: active, 0: passive. Maybe someday we should rename + * this varable to "active_mode" (Jeff) + */ + pmlmepriv->scan_mode =3D SCAN_ACTIVE; =20 spin_lock_init(&pmlmepriv->lock); INIT_LIST_HEAD(&pmlmepriv->free_bss_pool.queue); @@ -95,7 +98,8 @@ void rtw_free_mlme_priv_ie_data(struct mlme_priv *pmlmepr= iv) rtw_free_mlme_ie_data(&pmlmepriv->p2p_beacon_ie, &pmlmepriv->p2p_beacon_i= e_len); rtw_free_mlme_ie_data(&pmlmepriv->p2p_probe_req_ie, &pmlmepriv->p2p_probe= _req_ie_len); rtw_free_mlme_ie_data(&pmlmepriv->p2p_probe_resp_ie, &pmlmepriv->p2p_prob= e_resp_ie_len); - rtw_free_mlme_ie_data(&pmlmepriv->p2p_go_probe_resp_ie, &pmlmepriv->p2p_g= o_probe_resp_ie_len); + rtw_free_mlme_ie_data(&pmlmepriv->p2p_go_probe_resp_ie, + &pmlmepriv->p2p_go_probe_resp_ie_len); rtw_free_mlme_ie_data(&pmlmepriv->p2p_assoc_req_ie, &pmlmepriv->p2p_assoc= _req_ie_len); } =20 @@ -346,7 +350,8 @@ int is_same_network(struct wlan_bssid_ex *src, struct w= lan_bssid_ex *dst, u8 fea (d_cap & WLAN_CAPABILITY_ESS)); } =20 -struct wlan_network *_rtw_find_same_network(struct __queue *scanned_queue,= struct wlan_network *network) +struct wlan_network *_rtw_find_same_network(struct __queue *scanned_queue, + struct wlan_network *network) { struct list_head *phead, *plist; struct wlan_network *found =3D NULL; @@ -396,8 +401,11 @@ void update_network(struct wlan_bssid_ex *dst, struct = wlan_bssid_ex *src, u8 sq_final; long rssi_final; =20 - /* The rule below is 1/5 for sample value, 4/5 for history value */ - if (check_fwstate(&padapter->mlmepriv, _FW_LINKED) && is_same_network(&pa= dapter->mlmepriv.cur_network.network, src, 0)) { + /* The rule below is 1/5 for sample value, + * 4/5 for history value + */ + if (check_fwstate(&padapter->mlmepriv, _FW_LINKED) && + is_same_network(&padapter->mlmepriv.cur_network.network, src, 0)) { /* Take the recvpriv's value for the connected AP*/ ss_final =3D padapter->recvpriv.signal_strength; sq_final =3D padapter->recvpriv.signal_qual; @@ -408,11 +416,15 @@ void update_network(struct wlan_bssid_ex *dst, struct= wlan_bssid_ex *src, rssi_final =3D rssi_ori; } else { if (sq_smp !=3D 101) { /* from the right channel */ - ss_final =3D ((u32)(src->phy_info.signal_strength) + (u32)(dst->phy_inf= o.signal_strength) * 4) / 5; - sq_final =3D ((u32)(src->phy_info.signal_quality) + (u32)(dst->phy_info= .signal_quality) * 4) / 5; + ss_final =3D ((u32)(src->phy_info.signal_strength) + + (u32)(dst->phy_info.signal_strength) * 4) / 5; + sq_final =3D ((u32)(src->phy_info.signal_quality) + + (u32)(dst->phy_info.signal_quality) * 4) / 5; rssi_final =3D (src->rssi + dst->rssi * 4) / 5; } else { - /* bss info not receiving from the right channel, use the original RX s= ignal infos */ + /* bss info not receiving from the right channel, + * use the original RX signal infos + */ ss_final =3D dst->phy_info.signal_strength; sq_final =3D dst->phy_info.signal_quality; rssi_final =3D dst->rssi; @@ -439,10 +451,13 @@ static void update_current_network(struct adapter *ad= apter, struct wlan_bssid_ex &pmlmepriv->cur_network.network, &pmlmepriv->cur_network.network); =20 - if ((check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) && (is_same_networ= k(&pmlmepriv->cur_network.network, pnetwork, 0))) { + if ((check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) && + (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); - rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + si= zeof(struct ndis_802_11_fix_ie), - pmlmepriv->cur_network.network.ie_length); + rtw_update_protection(adapter, + (pmlmepriv->cur_network.network.ies) + + sizeof(struct ndis_802_11_fix_ie), + pmlmepriv->cur_network.network.ie_length); } } =20 @@ -577,7 +592,9 @@ int rtw_is_desired_network(struct adapter *adapter, str= uct wlan_network *pnetwor privacy =3D pnetwork->network.privacy; =20 if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS)) { - if (rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, pnetwork->= network.ie_length - _FIXED_IE_LENGTH_, NULL, &wps_ielen)) + if (rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, + pnetwork->network.ie_length - _FIXED_IE_LENGTH_, + NULL, &wps_ielen)) return true; else return false; @@ -590,7 +607,8 @@ int rtw_is_desired_network(struct adapter *adapter, str= uct wlan_network *pnetwor bselected =3D false; =20 if (psecuritypriv->ndisauthtype =3D=3D Ndis802_11AuthModeWPA2PSK) { - p =3D rtw_get_ie(pnetwork->network.ies + _BEACON_IE_OFFSET_, WLAN_EID_R= SN, &ie_len, (pnetwork->network.ie_length - _BEACON_IE_OFFSET_)); + p =3D rtw_get_ie(pnetwork->network.ies + _BEACON_IE_OFFSET_, WLAN_EID_R= SN, + &ie_len, (pnetwork->network.ie_length - _BEACON_IE_OFFSET_)); if (p && ie_len > 0) bselected =3D true; else @@ -602,7 +620,8 @@ int rtw_is_desired_network(struct adapter *adapter, str= uct wlan_network *pnetwor bselected =3D false; =20 if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) { - if (pnetwork->network.infrastructure_mode !=3D pmlmepriv->cur_network.ne= twork.infrastructure_mode) + if (pnetwork->network.infrastructure_mode !=3D + pmlmepriv->cur_network.network.infrastructure_mode) bselected =3D false; } =20 @@ -630,12 +649,14 @@ void rtw_survey_event_callback(struct adapter *adapte= r, u8 *pbuf) =20 /* update IBSS_network 's timestamp */ if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) =3D=3D true) { - if (!memcmp(&pmlmepriv->cur_network.network.mac_address, pnetwork->mac_a= ddress, ETH_ALEN)) { + if (!memcmp(&pmlmepriv->cur_network.network.mac_address, + pnetwork->mac_address, ETH_ALEN)) { struct wlan_network *ibss_wlan =3D NULL; =20 memcpy(pmlmepriv->cur_network.network.ies, pnetwork->ies, 8); spin_lock_bh(&pmlmepriv->scanned_queue.lock); - ibss_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, pnetwork->ma= c_address); + ibss_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, + pnetwork->mac_address); if (ibss_wlan) { memcpy(ibss_wlan->network.ies, pnetwork->ies, 8); spin_unlock_bh(&pmlmepriv->scanned_queue.lock); @@ -686,13 +707,18 @@ void rtw_surveydone_event_callback(struct adapter *ad= apter, u8 *pbuf) _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else { u8 ret =3D _SUCCESS; - struct wlan_bssid_ex *pdev_network =3D &adapter->registrypriv.dev_= network; + struct wlan_bssid_ex *pdev_network =3D + &adapter->registrypriv.dev_network; u8 *pibss =3D adapter->registrypriv.dev_network.mac_address; =20 - /* pmlmepriv->fw_state ^=3D _FW_UNDER_SURVEY;because don't set assoc_= timer */ + /* + * pmlmepriv->fw_state ^=3D _FW_UNDER_SURVEY; + * because don't set assoc_timer. + */ _clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY); =20 - memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndi= s_802_11_ssid)); + memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid, + sizeof(struct ndis_802_11_ssid)); =20 rtw_update_registrypriv_dev_network(adapter); rtw_generate_random_ibss(pibss); @@ -719,8 +745,11 @@ void rtw_surveydone_event_callback(struct adapter *ada= pter, u8 *pbuf) rtw_indicate_connect(adapter); } else { if (rtw_to_roam(adapter) !=3D 0) { - if (rtw_dec_to_roam(adapter) =3D=3D 0 - || _SUCCESS !=3D rtw_sitesurvey_cmd(adapter, &pmlmepriv->assoc_ssid,= 1, NULL, 0) + if (rtw_dec_to_roam(adapter) =3D=3D 0 || + _SUCCESS !=3D rtw_sitesurvey_cmd(adapter, + &pmlmepriv->assoc_ssid, + 1, + NULL, 0) ) { rtw_set_to_roam(adapter, 0); rtw_free_assoc_resources(adapter, 1); @@ -739,8 +768,9 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) && check_fwstate(pmlmepriv, _FW_LINKED)) { if (rtw_select_roaming_candidate(pmlmepriv) =3D=3D _SUCCESS) { - receive_disconnect(adapter, pmlmepriv->cur_network.network.mac_address - , WLAN_REASON_ACTIVE_ROAM); + receive_disconnect(adapter, + pmlmepriv->cur_network.network.mac_address, + WLAN_REASON_ACTIVE_ROAM); } } } @@ -928,7 +958,8 @@ void rtw_scan_abort(struct adapter *adapter) pmlmeext->scan_abort =3D false; } =20 -static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapte= r, struct wlan_network *pnetwork) +static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapte= r, + struct wlan_network *pnetwork) { int i; struct sta_info *bmc_sta, *psta =3D NULL; @@ -984,9 +1015,12 @@ static struct sta_info *rtw_joinbss_update_stainfo(st= ruct adapter *padapter, str padapter->securitypriv.wps_ie_len =3D 0; } =20 - /* for A-MPDU Rx reordering buffer control for bmc_sta & sta_info */ - /* if A-MPDU Rx is enabled, resetting rx_ordering_ctrl wstart_b(indicat= e_seq) to default value =3D 0xffff */ - /* todo: check if AP can send A-MPDU packets */ + /* + * for A-MPDU Rx reordering buffer control for bmc_sta & sta_info. + * if A-MPDU Rx is enabled, resetting rx_ordering_ctrl wstart_b(indicate= _seq) + * to default value =3D 0xffff. + * todo: check if AP can send A-MPDU packets. + */ for (i =3D 0; i < 16 ; i++) { preorder_ctrl =3D &psta->recvreorder_ctrl[i]; preorder_ctrl->enable =3D false; @@ -1002,7 +1036,8 @@ static struct sta_info *rtw_joinbss_update_stainfo(st= ruct adapter *padapter, str preorder_ctrl->enable =3D false; preorder_ctrl->indicate_seq =3D 0xffff; preorder_ctrl->wend_b =3D 0xffff; - preorder_ctrl->wsize_b =3D 64;/* max_ampdu_sz;ex. 32(kbytes) -> wsize_= b =3D32 */ + /* max_ampdu_sz;ex. 32(kbytes) -> wsize_b =3D32 */ + preorder_ctrl->wsize_b =3D 64; } } } @@ -1012,7 +1047,9 @@ static struct sta_info *rtw_joinbss_update_stainfo(st= ruct adapter *padapter, str =20 /* pnetwork : returns from rtw_joinbss_event_callback */ /* ptarget_wlan: found from scanned_queue */ -static void rtw_joinbss_update_network(struct adapter *padapter, struct wl= an_network *ptarget_wlan, struct wlan_network *pnetwork) +static void rtw_joinbss_update_network(struct adapter *padapter, + struct wlan_network *ptarget_wlan, + struct wlan_network *pnetwork) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct wlan_network *cur_network =3D &pmlmepriv->cur_network; @@ -1029,8 +1066,12 @@ static void rtw_joinbss_update_network(struct adapte= r *padapter, struct wlan_net =20 padapter->recvpriv.signal_strength =3D ptarget_wlan->network.phy_info.sig= nal_strength; padapter->recvpriv.signal_qual =3D ptarget_wlan->network.phy_info.signal_= quality; - /* the ptarget_wlan->network.rssi is raw data, we use ptarget_wlan->netwo= rk.phy_info.signal_strength instead (has scaled) */ - padapter->recvpriv.rssi =3D translate_percentage_to_dbm(ptarget_wlan->net= work.phy_info.signal_strength); + /* the ptarget_wlan->network.rssi is raw data, + * we use ptarget_wlan->network.phy_info.signal_strength instead (has sca= led) + */ + padapter->recvpriv.rssi =3D + translate_percentage_to_dbm( + ptarget_wlan->network.phy_info.signal_strength); =20 rtw_set_signal_stat_timer(&padapter->recvpriv); =20 @@ -1052,20 +1093,30 @@ static void rtw_joinbss_update_network(struct adapt= er *padapter, struct wlan_net break; } =20 - rtw_update_protection(padapter, (cur_network->network.ies) + sizeof(struc= t ndis_802_11_fix_ie), - (cur_network->network.ie_length)); + rtw_update_protection(padapter, + (cur_network->network.ies) + sizeof(struct ndis_802_11_fix_ie), + (cur_network->network.ie_length)); =20 - rtw_update_ht_cap(padapter, cur_network->network.ies, cur_network->networ= k.ie_length, (u8)cur_network->network.configuration.ds_config); + rtw_update_ht_cap(padapter, cur_network->network.ies, cur_network->networ= k.ie_length, + (u8)cur_network->network.configuration.ds_config); } =20 -/* Notes: the function could be > passive_level (the same context as Rx ta= sklet) */ -/* pnetwork : returns from rtw_joinbss_event_callback */ -/* ptarget_wlan: found from scanned_queue */ -/* if join_res > 0, for (fw_state =3D=3DWIFI_STATION_STATE), we check if = "ptarget_sta" & "ptarget_wlan" exist. */ -/* if join_res > 0, for (fw_state =3D=3DWIFI_ADHOC_STATE), we only check i= f "ptarget_wlan" exist. */ -/* if join_res > 0, update "cur_network->network" from "pnetwork->network"= if (ptarget_wlan !=3D NULL). */ -/* */ -/* define REJOIN */ +/* + * The function can be called at > PASSIVE_LEVEL (same context as Rx taskl= et). + * 'pnetwork' is returned from rtw_joinbss_event_callback. + * 'ptarget_wlan' is found from scanned_queue. + * + * If join_res > 0 and fw_state =3D=3D WIFI_STATION_STATE, we check whether + * 'ptarget_sta' and 'ptarget_wlan' exist. + * + * If join_res > 0 and fw_state =3D=3D WIFI_ADHOC_STATE, we only check whe= ther + * 'ptarget_wlan' exists. + * + * If join_res > 0 and 'ptarget_wlan' is not NULL, update + * cur_network->network from pnetwork->network. + * + * Define REJOIN. + */ void rtw_joinbss_event_prehandle(struct adapter *adapter, u8 *pbuf) { static u8 __maybe_unused retry; @@ -1077,7 +1128,8 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) struct wlan_network *pcur_wlan =3D NULL, *ptarget_wlan =3D NULL; unsigned int the_same_macaddr =3D false; =20 - the_same_macaddr =3D !memcmp(pnetwork->network.mac_address, cur_network->= network.mac_address, ETH_ALEN); + the_same_macaddr =3D !memcmp(pnetwork->network.mac_address, + cur_network->network.mac_address, ETH_ALEN); =20 pnetwork->network.length =3D get_wlan_bssid_ex_sz(&pnetwork->network); if (pnetwork->network.length > sizeof(struct wlan_bssid_ex)) @@ -1130,7 +1182,9 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) goto ignore_joinbss_callback; } =20 - /* s3. find ptarget_sta & update ptarget_sta after update cur_network o= nly for station mode */ + /* s3. find ptarget_sta & update ptarget_sta after update + * cur_network only for station mode + */ if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { ptarget_sta =3D rtw_joinbss_update_stainfo(adapter, pnetwork); if (!ptarget_sta) { @@ -1262,8 +1316,10 @@ void rtw_stassoc_event_callback(struct adapter *adap= ter, u8 *pbuf) psta =3D rtw_get_stainfo(&adapter->stapriv, pstassoc->macaddr); if (psta) { /* the sta have been in sta_info_queue =3D> do nothing */ - - return; /* between drv has received this event before and fw have not y= et to set key to CAM_ENTRY) */ + /* between drv has received this event before and fw + * have not yet to set key to CAM_ENTRY) + */ + return; } =20 psta =3D rtw_alloc_stainfo(&adapter->stapriv, pstassoc->macaddr); @@ -1290,7 +1346,8 @@ void rtw_stassoc_event_callback(struct adapter *adapt= er, u8 *pbuf) (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true)) { if (adapter->stapriv.asoc_sta_count =3D=3D 2) { spin_lock_bh(&pmlmepriv->scanned_queue.lock); - ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, cur_networ= k->network.mac_address); + ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, + cur_network->network.mac_address); pmlmepriv->cur_network_scanned =3D ptarget_wlan; if (ptarget_wlan) ptarget_wlan->fixed =3D true; @@ -1347,16 +1404,19 @@ void rtw_stadel_event_callback(struct adapter *adap= ter, u8 *pbuf) =20 if (adapter->registrypriv.wifi_spec =3D=3D 1) { roam =3D false; - } else if (reason =3D=3D WLAN_REASON_EXPIRATION_CHK && rtw_chk_roam_flag= s(adapter, RTW_ROAM_ON_EXPIRED)) { + } else if (reason =3D=3D WLAN_REASON_EXPIRATION_CHK && + rtw_chk_roam_flags(adapter, RTW_ROAM_ON_EXPIRED)) { roam =3D true; - } else if (reason =3D=3D WLAN_REASON_ACTIVE_ROAM && rtw_chk_roam_flags(a= dapter, RTW_ROAM_ACTIVE)) { + } else if (reason =3D=3D WLAN_REASON_ACTIVE_ROAM && + rtw_chk_roam_flags(adapter, RTW_ROAM_ACTIVE)) { roam =3D true; roam_target =3D pmlmepriv->roam_network; } =20 if (roam) { if (rtw_to_roam(adapter) > 0) - rtw_dec_to_roam(adapter); /* this stadel_event is caused by roaming, d= ecrease to_roam */ + /* this stadel_event is caused by roaming, decrease to_roam */ + rtw_dec_to_roam(adapter); else if (rtw_to_roam(adapter) =3D=3D 0) rtw_set_to_roam(adapter, adapter->registrypriv.max_roaming_times); } else { @@ -1370,7 +1430,8 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) =20 spin_lock_bh(&pmlmepriv->scanned_queue.lock); /* remove the network entry in scanned_queue */ - pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, tgt_network->netwo= rk.mac_address); + pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, + tgt_network->network.mac_address); if (pwlan) { pwlan->fixed =3D false; rtw_free_network_nolock(adapter, pwlan); @@ -1384,11 +1445,13 @@ void rtw_stadel_event_callback(struct adapter *adap= ter, u8 *pbuf) check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { rtw_free_stainfo(adapter, psta); =20 - if (adapter->stapriv.asoc_sta_count =3D=3D 1) {/* a sta + bc/mc_stainfo = (not Ibss_stainfo) */ + if (adapter->stapriv.asoc_sta_count =3D=3D 1) { + /* a sta + bc/mc_stainfo (not Ibss_stainfo) */ u8 ret =3D _SUCCESS; spin_lock_bh(&pmlmepriv->scanned_queue.lock); /* free old ibss network */ - pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, tgt_network->netw= ork.mac_address); + pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, + tgt_network->network.mac_address); if (pwlan) { pwlan->fixed =3D false; rtw_free_network_nolock(adapter, pwlan); @@ -1398,9 +1461,11 @@ void rtw_stadel_event_callback(struct adapter *adapt= er, u8 *pbuf) pdev_network =3D &adapter->registrypriv.dev_network; pibss =3D adapter->registrypriv.dev_network.mac_address; =20 - memcpy(pdev_network, &tgt_network->network, get_wlan_bssid_ex_sz(&tgt_n= etwork->network)); + memcpy(pdev_network, &tgt_network->network, + get_wlan_bssid_ex_sz(&tgt_network->network)); =20 - memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_= 802_11_ssid)); + memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid, + sizeof(struct ndis_802_11_ssid)); =20 rtw_update_registrypriv_dev_network(adapter); =20 @@ -1471,7 +1536,9 @@ void _rtw_join_timeout_handler(struct timer_list *t) rtw_indicate_disconnect(adapter); free_scanqueue(pmlmepriv);/* */ =20 - /* indicate disconnect for the case that join_timeout and check_fwstate = !=3D FW_LINKED */ + /* indicate disconnect for the case that + * join_timeout and check_fwstate !=3D FW_LINKED + */ rtw_cfg80211_indicate_disconnect(adapter); } =20 @@ -1520,8 +1587,8 @@ static void rtw_auto_scan_handler(struct adapter *pad= apter) =20 rtw_mlme_reset_auto_scan_int(padapter); =20 - if (pmlmepriv->auto_scan_int_ms !=3D 0 - && jiffies_to_msecs(jiffies - pmlmepriv->scan_start_time) > pmlmepriv->a= uto_scan_int_ms) { + if (pmlmepriv->auto_scan_int_ms !=3D 0 && + jiffies_to_msecs(jiffies - pmlmepriv->scan_start_time) > pmlmepriv->a= uto_scan_int_ms) { if (!padapter->registrypriv.wifi_spec) { if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING) =3D= =3D true) goto exit; @@ -1563,7 +1630,9 @@ void rtw_dynamic_check_timer_handler(struct adapter *= adapter) /* rtw_lps_ctrl_wk_cmd(adapter, LPS_CTRL_ENTER, 1); */ rtw_hal_dm_watchdog_in_lps(adapter); } else { - /* call rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_LEAVE, 1) in traffic_sta= tus_watchdog() */ + /* call rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_LEAVE, 1) + * in traffic_status_watchdog() + */ } =20 } else { @@ -1623,7 +1692,8 @@ static int rtw_check_roaming_candidate(struct mlme_pr= iv *mlme if (jiffies_to_msecs(jiffies - competitor->last_scanned) >=3D mlme->roam_= scanr_exp_ms) goto exit; =20 - if (competitor->network.rssi - mlme->cur_network_scanned->network.rssi < = mlme->roam_rssi_diff_th) + if (competitor->network.rssi - mlme->cur_network_scanned->network.rssi < + mlme->roam_rssi_diff_th) goto exit; =20 if (*candidate && (*candidate)->network.rssi >=3D competitor->network.rss= i) @@ -1697,7 +1767,8 @@ static int rtw_check_join_candidate(struct mlme_priv = *mlme /* check ssid, if needed */ if (mlme->assoc_ssid.ssid[0] && mlme->assoc_ssid.ssid_length) { if (competitor->network.ssid.ssid_length !=3D mlme->assoc_ssid.ssid_leng= th - || memcmp(competitor->network.ssid.ssid, mlme->assoc_ssid.ssid, mlme->a= ssoc_ssid.ssid_length) + || memcmp(competitor->network.ssid.ssid, mlme->assoc_ssid.ssid, + mlme->assoc_ssid.ssid_length) ) goto exit; } @@ -1814,7 +1885,8 @@ signed int rtw_set_auth(struct adapter *adapter, stru= ct security_priv *psecurity return res; } =20 -signed int rtw_set_key(struct adapter *adapter, struct security_priv *psec= uritypriv, signed int keyid, u8 set_tx, bool enqueue) +signed int rtw_set_key(struct adapter *adapter, struct security_priv *psec= uritypriv, + signed int keyid, u8 set_tx, bool enqueue) { u8 keylen; struct cmd_obj *pcmd; @@ -1889,7 +1961,8 @@ signed int rtw_set_key(struct adapter *adapter, struc= t security_priv *psecurityp } =20 /* adjust ies for rtw_joinbss_cmd in WMM */ -int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, ui= nt in_len, uint initial_out_len) +int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, + uint in_len, uint initial_out_len) { unsigned int ielength =3D 0; unsigned int i, j; @@ -1898,7 +1971,9 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ while (i < in_len) { ielength =3D initial_out_len; =20 - if (in_ie[i] =3D=3D 0xDD && in_ie[i + 2] =3D=3D 0x00 && in_ie[i + 3] =3D= =3D 0x50 && in_ie[i + 4] =3D=3D 0xF2 && in_ie[i + 5] =3D=3D 0x02 && i + 5 = < in_len) { /* WMM element ID and OUI */ + if (in_ie[i] =3D=3D 0xDD && in_ie[i + 2] =3D=3D 0x00 && in_ie[i + 3] =3D= =3D 0x50 && + in_ie[i + 4] =3D=3D 0xF2 && in_ie[i + 5] =3D=3D 0x02 && i + 5 < in_l= en) { + /* WMM element ID and OUI */ for (j =3D i; j < i + 9; j++) { out_ie[ielength] =3D in_ie[j]; ielength++; @@ -1988,7 +2063,8 @@ signed int rtw_restruct_sec_ie(struct adapter *adapte= r, u8 *in_ie, u8 *out_ie, u ielength +=3D psecuritypriv->wps_ie_len; } else if ((authmode =3D=3D WLAN_EID_VENDOR_SPECIFIC) || (authmode =3D=3D= WLAN_EID_RSN)) { /* copy RSN or SSN */ - memcpy(&out_ie[ielength], &psecuritypriv->supplicant_ie[0], psecuritypri= v->supplicant_ie[1] + 2); + memcpy(&out_ie[ielength], &psecuritypriv->supplicant_ie[0], + psecuritypriv->supplicant_ie[1] + 2); ielength +=3D psecuritypriv->supplicant_ie[1] + 2; rtw_report_sec_ie(adapter, authmode, psecuritypriv->supplicant_ie); } @@ -2026,7 +2102,8 @@ void rtw_update_registrypriv_dev_network(struct adapt= er *adapter) struct security_priv *psecuritypriv =3D &adapter->securitypriv; struct wlan_network *cur_network =3D &adapter->mlmepriv.cur_network; =20 - pdev_network->privacy =3D (psecuritypriv->dot11PrivacyAlgrthm > 0 ? 1 : 0= ) ; /* adhoc no 802.1x */ + /* adhoc no 802.1x */ + pdev_network->privacy =3D (psecuritypriv->dot11PrivacyAlgrthm > 0 ? 1 : 0= ) ; =20 pdev_network->rssi =3D 0; =20 @@ -2056,14 +2133,18 @@ void rtw_update_registrypriv_dev_network(struct ada= pter *adapter) /* 1. Supported rates */ /* 2. IE */ =20 - /* rtw_set_supported_rate(pdev_network->supported_rates, pregistrypriv->w= ireless_mode) ; will be called in rtw_generate_ie */ + /* rtw_set_supported_rate(pdev_network->supported_rates, pregistrypriv->w= ireless_mode); + * will be called in rtw_generate_ie + */ sz =3D rtw_generate_ie(pregistrypriv); =20 pdev_network->ie_length =3D sz; =20 pdev_network->length =3D get_wlan_bssid_ex_sz((struct wlan_bssid_ex *)pd= ev_network); =20 - /* notes: translate ie_length & length after assign the length to cmdsz i= n createbss_cmd(); */ + /* notes: translate ie_length & length after assign + * the length to cmdsz in createbss_cmd(); + */ /* pdev_network->ie_length =3D cpu_to_le32(sz); */ } =20 @@ -2075,7 +2156,9 @@ void rtw_joinbss_reset(struct adapter *padapter) =20 struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; =20 - /* todo: if you want to do something io/reg/hw setting before join_bss, p= lease add code here */ + /* todo: if you want to do something io/reg/hw setting before + * join_bss, please add code here + */ =20 pmlmepriv->num_FortyMHzIntolerant =3D 0; =20 @@ -2165,7 +2248,8 @@ void rtw_build_wmm_ie_ht(struct adapter *padapter, u8= *out_ie, uint *pout_len) } =20 /* the function is >=3D passive_level */ -unsigned int rtw_restructure_ht_ie(struct adapter *padapter, u8 *in_ie, u8= *out_ie, uint in_len, uint *pout_len, u8 channel) +unsigned int rtw_restructure_ht_ie(struct adapter *padapter, u8 *in_ie, + u8 *out_ie, uint in_len, uint *pout_len, u8 channel) { u32 ielen, out_len; enum ieee80211_max_ampdu_length_exp max_rx_ampdu_factor; @@ -2246,7 +2330,8 @@ unsigned int rtw_restructure_ht_ie(struct adapter *pa= dapter, u8 *in_ie, u8 *out_ =20 /* update default supported_mcs_set */ if (stbc_rx_enable) - ht_capie.cap_info |=3D cpu_to_le16(IEEE80211_HT_CAP_RX_STBC_1R);/* RX ST= BC One spatial stream */ + /* RX STBC One spatial stream */ + ht_capie.cap_info |=3D cpu_to_le16(IEEE80211_HT_CAP_RX_STBC_1R); =20 set_mcs_rate_by_mask(ht_capie.mcs.rx_mask, MCS_RATE_1R); =20 @@ -2312,7 +2397,8 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *= pie, uint ie_len, u8 channe =20 /* check Max Rx A-MPDU Size */ len =3D 0; - p =3D rtw_get_ie(pie + sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_CAP= ABILITY, &len, ie_len - sizeof(struct ndis_802_11_fix_ie)); + p =3D rtw_get_ie(pie + sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_CAP= ABILITY, &len, + ie_len - sizeof(struct ndis_802_11_fix_ie)); if (p && len > 0) { pht_capie =3D (struct ieee80211_ht_cap *)(p + 2); max_ampdu_sz =3D (pht_capie->ampdu_params_info & IEEE80211_HT_CAP_AMPDU_= FACTOR); @@ -2322,7 +2408,8 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *= pie, uint ie_len, u8 channe } =20 len =3D 0; - p =3D rtw_get_ie(pie + sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_OPE= RATION, &len, ie_len - sizeof(struct ndis_802_11_fix_ie)); + p =3D rtw_get_ie(pie + sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_OPE= RATION, &len, + ie_len - sizeof(struct ndis_802_11_fix_ie)); if (p && len > 0) { /* todo: */ } @@ -2338,7 +2425,8 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *= pie, uint ie_len, u8 channe =20 /* update the MCS set */ for (i =3D 0; i < 16; i++) - pmlmeinfo->HT_caps.u.HT_cap_element.MCS_rate[i] &=3D pmlmeext->default_= supported_mcs_set[i]; + pmlmeinfo->HT_caps.u.HT_cap_element.MCS_rate[i] &=3D + pmlmeext->default_supported_mcs_set[i]; =20 /* update the MCS rates */ set_mcs_rate_by_mask(pmlmeinfo->HT_caps.u.HT_cap_element.MCS_rate, MCS_R= ATE_1R); @@ -2456,7 +2544,8 @@ void _rtw_roaming(struct adapter *padapter, struct wl= an_network *tgt_network) struct wlan_network *cur_network =3D &pmlmepriv->cur_network; =20 if (rtw_to_roam(padapter) > 0) { - memcpy(&pmlmepriv->assoc_ssid, &cur_network->network.ssid, sizeof(struct= ndis_802_11_ssid)); + memcpy(&pmlmepriv->assoc_ssid, &cur_network->network.ssid, + sizeof(struct ndis_802_11_ssid)); =20 pmlmepriv->assoc_by_bssid =3D false; =20 @@ -2473,7 +2562,8 @@ void _rtw_roaming(struct adapter *padapter, struct wl= an_network *tgt_network) signed int rtw_linked_check(struct adapter *padapter) { if ((check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) =3D=3D true) || - (check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE | WIFI_ADHOC_MASTE= R_STATE) =3D=3D true)) { + (check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE | + WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { if (padapter->stapriv.asoc_sta_count > 2) return true; } else { /* Station mode */ --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8705C1FF7C8 for ; Sat, 26 Jul 2025 04:33:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504424; cv=none; b=TnQBRRPzAzd5ZIEXxN2NQqkWIM364ZlLWF4XQBwljHkAI0O0P2vwnL91G/K0DPbpihT8VFUaqe7N+NWjKPah36BEK/rAU8A5DqDiHfV7hzChzCSTxJXHyvNCDrVwo98Cn9lvsn8tlPfU+YRkoqdYX26BYZ1ybv7o8s4004waMYo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504424; c=relaxed/simple; bh=1YE2UOp6wXhpwFE/MVztUoGBMbU36yVaKY1t9lc7KrY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Gf9JkGb6TJgJJmh76cRBWrQaD/bOHKhTqbDeTsNS0yOYbq1vb0FsNVoj3GGYkG9nm1YtHrXu66ovoI4wOuVsLjBGa7m8oQPBetZMXjdMeAMxpmFrV9T2PgrCeJPUpVBKk5BzfnQaiLq+oaOnIdgiZ4fgsTFwvCJfPuwxVK3Ievs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d9JSg6Xs; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d9JSg6Xs" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7e32cf22fdfso258961885a.0 for ; Fri, 25 Jul 2025 21:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504421; x=1754109221; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ranevgSJeBzK24ZwK0Y6Bfek06oJTvOetUee3n/vCQE=; b=d9JSg6Xsud05KZG32QUITO6G8O9InjnDcdfkJB+A71SMnkQ84RunLl9FiVlbf6Dmf0 NOceYBvndkcIUShtF9oUsGXU7aKkrky/SEC5MOJu5nZB3Jsc5vHq72t8t5ICkVzTPO04 BcDOdE98MjeVU8RGplItzAadhqgFPBzJetVB7cS77PvHYTs7LMKr5oVC0qd6KLnmyOyy KfsPWWnPiR581fhAeqBZjRj1M2fy7lRTtksjgjgvqXmQiDpoUyNUl2Px7rrtkQJ7iKBv smSFErCkJ84g31gMSbLjnjLfteXobOSV14PDqpKMCir8GX3igcDSazHk7EY3U3Wk4A7/ fL/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504421; x=1754109221; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ranevgSJeBzK24ZwK0Y6Bfek06oJTvOetUee3n/vCQE=; b=H1miREc1HEM8f/r5vyJo8oo1GbrtsTAU+i3Fo41BZkRyYSHtriWv3E0PL1BnMWyrqv BYHgCTUDxv8ferkxwjaH51G2SRZVXXR3zcz66wlUJUJHz6Ns6NAnDaZcugigcsLZvB38 4BDJyheIGsGPKafBMaNRdLkymK0wHsL5Swuodc3EmtSvYQkJZPZByW6ZvC8ROwBR+UZh oTvZcc6PY2cIO8n5TeFEZAo+70uyD427nzsyhtru/nDKzNPDboabt/lC4GbuRJ7T/pu6 b+er1I06Jqcd4JZiLBJzaSOnwGDl7TGR1IAa0C+Iiloe7ICoww30xg/SEP7t9uaWAlgR nuOg== X-Forwarded-Encrypted: i=1; AJvYcCW7MXAbE4AgfeW0X5U39HmuuNV7uO5yHJ8qRufX7/BjXWYN8GeO8tfhDPpFPytPi7FJ5h8tsE93XU5v6Nw=@vger.kernel.org X-Gm-Message-State: AOJu0YyrZaZIchnzrIDFoepxyV55aM2keKnU/rJ9LNzdAhpHZycjuOsk WhLvRUnFX1alH1ExISWeb3Utg2Y7vB/iCqL9LjKcy+dTbNDoxZ+LNLQFqSf4kQ== X-Gm-Gg: ASbGncsWfHLvOJa+jSpyO7omwWGM2+d80I7zpMdUlfgjiaoJELXAZmyJop9uA/MRbaZ bNMI702oLdg4u2z5p0n62Z3zs2hE8ETnMXssOLgrBb2VEXaAMMdKhSCYdxsK7J7t5xBwUjd4eZd +/fA0m7rMNDqmVjtYrmfz52SEIrOv089p4MF4vh0ya8UjOw5aFc2CK6F6528oZU+amYICLsG3FH wc3GRW6Cpg09SVjrge7SnUdkUIGLUbqpXgnSg5NBr2wW7g5dmaMjlVqPiB4syyLBmA6beEF4+r6 8V2gODy5gt+VIa6FhcAY/ciFrmGH2AX2Y7lliNm+Sp0Hulrm5CCZuC3lG7w8p9DkzyJR2OndIWN 4RR6nG28+e6/jY3VTK5Wdz22HaUYmvoJj/TSFI0PeYnkuOa9LcpI= X-Google-Smtp-Source: AGHT+IEQhpxP5sR16IKQwYkgzpXNVxpWWrQ4zHrWQnWyvrEu0FMk2B/Vn0y3xpS6mdSBtlKmmVHKCw== X-Received: by 2002:a05:620a:2915:b0:7d4:653a:e9a8 with SMTP id af79cd13be357-7e63bfa2698mr606426285a.48.1753504421425; Fri, 25 Jul 2025 21:33:41 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:41 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 07/20] staging: rtl8723bs: align asterisk in block comment to fix formatting Date: Sat, 26 Jul 2025 04:32:05 +0000 Message-Id: <20250726043218.386738-8-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Aligned the leading asterisks in a multi-line block comment to maintain consistent formatting and improve readability. This aligns with kernel coding style guidelines for comment formatting. No functional changes. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 40 +++++++++++------------ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index fb1768284c2e..0c985593ff0c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -842,8 +842,8 @@ static void find_network(struct adapter *adapter) } =20 /* -*rtw_free_assoc_resources: the caller has to lock pmlmepriv->lock -*/ + *rtw_free_assoc_resources: the caller has to lock pmlmepriv->lock + */ void rtw_free_assoc_resources(struct adapter *adapter, int lock_scanned_qu= eue) { struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; @@ -878,8 +878,8 @@ void rtw_free_assoc_resources(struct adapter *adapter, = int lock_scanned_queue) } =20 /* -*rtw_indicate_connect: the caller has to lock pmlmepriv->lock -*/ + *rtw_indicate_connect: the caller has to lock pmlmepriv->lock + */ void rtw_indicate_connect(struct adapter *padapter) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -897,8 +897,8 @@ void rtw_indicate_connect(struct adapter *padapter) } =20 /* -*rtw_indicate_disconnect: the caller has to lock pmlmepriv->lock -*/ + *rtw_indicate_disconnect: the caller has to lock pmlmepriv->lock + */ void rtw_indicate_disconnect(struct adapter *padapter) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -1501,9 +1501,9 @@ void rtw_wmm_event_callback(struct adapter *padapter,= u8 *pbuf) } =20 /* -* _rtw_join_timeout_handler - Timeout/failure handler for CMD JoinBss -* @adapter: pointer to struct adapter structure -*/ + * _rtw_join_timeout_handler - Timeout/failure handler for CMD JoinBss + * @adapter: pointer to struct adapter structure + */ void _rtw_join_timeout_handler(struct timer_list *t) { struct adapter *adapter =3D timer_container_of(adapter, t, @@ -1546,9 +1546,9 @@ void _rtw_join_timeout_handler(struct timer_list *t) } =20 /* -* rtw_scan_timeout_handler - Timeout/Failure handler for CMD SiteSurvey -* @adapter: pointer to struct adapter structure -*/ + * rtw_scan_timeout_handler - Timeout/Failure handler for CMD SiteSurvey + * @adapter: pointer to struct adapter structure + */ void rtw_scan_timeout_handler(struct timer_list *t) { struct adapter *adapter =3D timer_container_of(adapter, t, @@ -1666,10 +1666,10 @@ void rtw_set_scan_deny(struct adapter *adapter, u32= ms) } =20 /* -* Select a new roaming candidate from the original @param candidate and @p= aram competitor -* @return true: candidate is updated -* @return false: candidate is not updated -*/ + * Select a new roaming candidate from the original @param candidate and @= param competitor + * @return true: candidate is updated + * @return false: candidate is not updated + */ static int rtw_check_roaming_candidate(struct mlme_priv *mlme , struct wlan_network **candidate, struct wlan_network *competitor) { @@ -1748,10 +1748,10 @@ int rtw_select_roaming_candidate(struct mlme_priv *= mlme) } =20 /* -* Select a new join candidate from the original @param candidate and @para= m competitor -* @return true: candidate is updated -* @return false: candidate is not updated -*/ + * Select a new join candidate from the original @param candidate and @par= am competitor + * @return true: candidate is updated + * @return false: candidate is not updated + */ static int rtw_check_join_candidate(struct mlme_priv *mlme , struct wlan_network **candidate, struct wlan_network *competitor) { --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB09243159 for ; Sat, 26 Jul 2025 04:33:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504426; cv=none; b=NOXBdBWIzlgeKTEWs3slxuHnX424EQPKmCK+MAEnIUS7WJ/ROyDyXy7PFcimguVT1o+4BT80qGrMKWojdeFBbAP72JjsIa21kMFzDBg+obgmpjcfECqKbn6tr4Ee+vGFAuQ1g8OGvCgQXpCf9ixwHCp4Uy8LsnKf6rkfnPpAI88= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504426; c=relaxed/simple; bh=P8blFKCskYmLJJ7VIQpCA1udM8xXbyCUuJ3KFZmm5I8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HYZSE2HbXOPZUmvQXIGsCaDb7WYp7UhMGILsLbDr/G7e8msKt+pAlR1yfCDqe8/AzBTCReww6SiKElNxtLWzRLxL2hzU+FERk39k8zmHmYW1hKuHQ5HCJvfLSBkOP4bT5cJnK0sDYHpEVgRaNREWWaKZ1p/NxPQTea69WeKZmcI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UaupvIy2; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UaupvIy2" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7e6399d0656so142652585a.3 for ; Fri, 25 Jul 2025 21:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504424; x=1754109224; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DiqQs9UeyD9dBqrMAhpgHRDznjYgytkYfxAEJHc3WqM=; b=UaupvIy24dK03VqjEN+70OHN++62zjOYkti1Ay+FlIdtDHPJIc9iIQZssBmT1aCQ3p hobAmAAtvThZVg4YOQ3qhyO2lPs7zVph4QfyIuWCGHTozyp0Qq35nRyfIm9pTxR7uZVB T/NmG0JMFL3tG4B6seZfA8H6NTt5mX+AJk6xs5J0v2hYBfvifrPmfRkSZZkfCEK4F1mq nbJYy3vqszy9FnyXzJCic/LbUtKbgrfRimAAkDCdgPNRiu1tSyryrtk3gHH6S9oO7LBE aeaREDseVLQ8dHUY5N8MYuYWed2SesfM+TgpHV7I7b5Kv5Ke3mP7zTpJlk0G/xo+OLY1 DC7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504424; x=1754109224; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DiqQs9UeyD9dBqrMAhpgHRDznjYgytkYfxAEJHc3WqM=; b=gER4I0qZkDSMIYGVUWW/B8zIcBixx/6h04c59lmL9IpjbOKkmeQNmaKi2mj8nlBIwU bkdBp/cnqhW1QZnZ3Bc6jfhVgBHyENC1z9pD9pGTWKCUrKvp+pVZdCzepDn3QHHORdCA +3wwKQVPMWT4XU4mlZEZST0I04p1VDqVQQHZhe8U3ulCL1hXy1MIuej8sL1nHXPiJqN1 7tlVNSvqubgh31LkgPg01BzsG89rvf9ujewQJlsFznKpjL7/HveuJocu7rfdM6nDJQcI ZfqJHtJYS9KhaQ5MZbq0aVe/F+cld/UjJD2l52DGbFevx7a3kOSF8dZSK9x0GQoBoD4E uMvg== X-Forwarded-Encrypted: i=1; AJvYcCXUE9aJSURgXLWWs18I/ciym9jbcDoK+qk8jaGiHXBizC8jMqh6UqG9d2QqUKSlQWv0CZgsWuoJbQ3apBU=@vger.kernel.org X-Gm-Message-State: AOJu0YyMZmj6zaVwVVSMEB/Zn+SvtowL0kXEbyYLjzv6c/jAZIpCpu1s OvW8mfOXrGyNgVPv6WLLHdZRSErZHU7ZsKHP9nug4wqBjlPvGIataJ27 X-Gm-Gg: ASbGnctc9ne9CQ9ZxqvLyP8XZ/viZ3uz7VorXdx+ttNJ9CUB6LCNuCGMbA0O6PQCJ0W /aES6yXGq8yOkxeXRr+UvNGw4GDirLppzWGlH6doJQ6QVVzR9oYaKZDD1udLSQ+c3x6dziMslrY 4y5xhEx1CCJ/mJtlvKU1Vb0p2SyLf46/g685Mws4iQ87kyrSYTL5HnW3aTblfY7Yura3PF/MLxa yVgEzgek7qQuP7sqlGila8hF1++jjYpM6sk8zHb9wbwEfnRvEwvobkTmWekKzNoFrnDom9o7qqS 6UfssWiYdaRA0baa9wjvemiSRhDrnKSUCH78Xb6JtWGbC0iIfxibCoBjkrogqrgNGKbXOgjMzIB C1dB5SeUgaU/GBgzCMBYSoNDcDhqtEMQhLkatqEaWvdcu+aXUSyk= X-Google-Smtp-Source: AGHT+IFX9Vsx4swIGeE82fmmkBcCcRt9S8KkzP2tx9DgvyavfwY6YXizCOrgrpkDEs9yllbkh9T/OA== X-Received: by 2002:a05:620a:6d85:b0:7d3:f3a5:71d7 with SMTP id af79cd13be357-7e63c1beb27mr348119785a.40.1753504423833; Fri, 25 Jul 2025 21:33:43 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:43 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 08/20] staging: rtl8723bs: fix logical continuation style by moving to previous line Date: Sat, 26 Jul 2025 04:32:06 +0000 Message-Id: <20250726043218.386738-9-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reformatted a logical continuation to sit on the same line as the previous statement, as per kernel coding style guidelines. This improves code readability and avoids unnecessary line breaks. No functional changes. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 29 ++++++++++++----------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 0c985593ff0c..692d2526965f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -323,8 +323,8 @@ int rtw_is_same_ibss(struct adapter *adapter, struct wl= an_network *pnetwork) =20 inline int is_same_ess(struct wlan_bssid_ex *a, struct wlan_bssid_ex *b) { - return (a->ssid.ssid_length =3D=3D b->ssid.ssid_length) - && !memcmp(a->ssid.ssid, b->ssid.ssid, a->ssid.ssid_length); + return (a->ssid.ssid_length =3D=3D b->ssid.ssid_length) && + !memcmp(a->ssid.ssid, b->ssid.ssid, a->ssid.ssid_length); } =20 int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex *dst, = u8 feature) @@ -765,8 +765,8 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) } } else { if (rtw_chk_roam_flags(adapter, RTW_ROAM_ACTIVE)) { - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) - && check_fwstate(pmlmepriv, _FW_LINKED)) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) && + check_fwstate(pmlmepriv, _FW_LINKED)) { if (rtw_select_roaming_candidate(pmlmepriv) =3D=3D _SUCCESS) { receive_disconnect(adapter, pmlmepriv->cur_network.network.mac_address, @@ -908,8 +908,8 @@ void rtw_indicate_disconnect(struct adapter *padapter) if (rtw_to_roam(padapter) > 0) _clr_fwstate_(pmlmepriv, _FW_LINKED); =20 - if (check_fwstate(&padapter->mlmepriv, _FW_LINKED) - || (rtw_to_roam(padapter) <=3D 0) + if (check_fwstate(&padapter->mlmepriv, _FW_LINKED) || + (rtw_to_roam(padapter) <=3D 0) ) { rtw_os_indicate_disconnect(padapter); =20 @@ -944,8 +944,8 @@ void rtw_scan_abort(struct adapter *adapter) =20 start =3D jiffies; pmlmeext->scan_abort =3D true; - while (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) - && jiffies_to_msecs(start) <=3D 200) { + while (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) && + jiffies_to_msecs(start) <=3D 200) { if (adapter->bDriverStopped || adapter->bSurpriseRemoved) break; =20 @@ -1618,8 +1618,8 @@ void rtw_dynamic_check_timer_handler(struct adapter *= adapter) if (adapter->net_closed) return; =20 - if ((adapter_to_pwrctl(adapter)->fw_current_in_ps_mode) - && !(hal_btcoex_IsBtControlLps(adapter)) + if ((adapter_to_pwrctl(adapter)->fw_current_in_ps_mode) && + !(hal_btcoex_IsBtControlLps(adapter)) ) { u8 bEnterPS; =20 @@ -1766,8 +1766,8 @@ static int rtw_check_join_candidate(struct mlme_priv = *mlme =20 /* check ssid, if needed */ if (mlme->assoc_ssid.ssid[0] && mlme->assoc_ssid.ssid_length) { - if (competitor->network.ssid.ssid_length !=3D mlme->assoc_ssid.ssid_leng= th - || memcmp(competitor->network.ssid.ssid, mlme->assoc_ssid.ssid, + if (competitor->network.ssid.ssid_length !=3D mlme->assoc_ssid.ssid_leng= th || + memcmp(competitor->network.ssid.ssid, mlme->assoc_ssid.ssid, mlme->assoc_ssid.ssid_length) ) goto exit; @@ -1777,8 +1777,9 @@ static int rtw_check_join_candidate(struct mlme_priv = *mlme goto exit; =20 if (rtw_to_roam(adapter) > 0) { - if (jiffies_to_msecs(jiffies - competitor->last_scanned) >=3D mlme->roam= _scanr_exp_ms - || is_same_ess(&competitor->network, &mlme->cur_network.network) =3D=3D= false + if (jiffies_to_msecs(jiffies - competitor->last_scanned) >=3D + mlme->roam_scanr_exp_ms || + is_same_ess(&competitor->network, &mlme->cur_network.network) =3D=3D= false ) goto exit; } --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6905621507F for ; Sat, 26 Jul 2025 04:33:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504429; cv=none; b=YF3nylU6OVFyqKQI4LZPD2W192gF2feIQmAXpgUyksGP+nNGERBiHy0i3Tkkl6Qt9KkEaqVPFq8rFEDkRTKqpNNm2F51MdrsIaZeC4c0CC8ZKTeLjZf4XCvLAz1HlKkDyUNnXxhH1y3TCPFNLoCp3CHh3S/CaaAblg/NAhvkTR8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504429; c=relaxed/simple; bh=HbTYJpvbsizmO6AePks88UoqbxnEofkE+uZjPBDPOoo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=k4Af4Q/ChGOFsucYYV6yOag0pJXvbo8mUfdTQfuUGnE5zKQ07z5Qqk3YDcC9qAZ1y9Ml69AdPxCXIlWwplQxya5OOj39mekj738kmw0zRmpppQN4E37tFpHIBIwuups5LVO02I1EYe849+tRWEtwASaSY97RZYdPMl9dhLMnP8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cDi/asBl; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cDi/asBl" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7d45f5fde50so223632685a.2 for ; Fri, 25 Jul 2025 21:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504426; x=1754109226; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YINGwzP+WQ2B2pLZ+3JU3T3wxECudwibr/z31+tOBEA=; b=cDi/asBlTyOs5XN3gnUhlN/ouYrhYR1wGsfOTljZ9G08OEzzhIp35jx38Ov+HykNXA S7YBi8okE/z/1D7FlQh8nqpvNmA931PT/fzym1ava9jBBOd9VALoxJnAt/nwAxhkxRT/ zgoyoRGqYR8asgA7Eu54lLYDOyplf9CQ4GHGga65PC32b1Y4DejE5WMDs6imP9sbwmzY EHsMO6isE2lJtsYFrrO/MbFx4Eh4S6Y7ILmWCrwandFlIEPFIunD+Nu6ruMFz6kg5G/v TqLPKf5yMwznkmEjh+d4O8z5pNnE8yt5F2mv3GG6dXWreVN9Bh9eKpExdpbHl2h/GLty pQwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504426; x=1754109226; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YINGwzP+WQ2B2pLZ+3JU3T3wxECudwibr/z31+tOBEA=; b=MMsXWBkLjW6yQNdjDcTgU0VT9ZzoSFEx7CUlzuLxdkmKhflS7Li3gdHkFRex3wYIGA BVy2KiYtycAuZ2hS9EZqKQwQV3Z9qay4N9nVRS2RjCRBo/QVYoOewVhLtKHZkATJVmv9 BWQJRf7sYCO54n1tFMzgOtr7+f/CEJ9tiGMobEre0D/AtexN2TVDsIgd4Y75+eAij/Ep FvoiT0o+dvKmBBW87aguRYlo6s2jmeO08/CXOGg6DFnhMEAqUGgYQ1pieuzeD2zZ1IyY y4XAfvJHJQ5Zk2jaosq7FrgDWFWPd938iLRc2doHOuXL/7ztIr3HIWZ1tRzA2WAJTFn6 +yNw== X-Forwarded-Encrypted: i=1; AJvYcCVbd82n9DnB32CRRhyfTBYYnbC9LIzJX07DvMoSypd7uxbr2xunQuTvDuMrHFXszZJTpkRFlIO1hoo6qc4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+lUy492mrp+V5zfM3aKLwpyY53g4Zm6GkL/K8W4HNpVjdh1Oa xcv4n+gEcdmG5AQmZ5tfje46Nzz0lr/YQ1vjZr5WME/tBSRQ7vE2+5KCIJUHcg== X-Gm-Gg: ASbGncve23HWyaUzywSS0IdtQDqREIiMjfePAgAT18rUP6Ke3npnatOymoGz2yjAWWk dHhauD7AajtE0XWvLjbSKrHh+/iWsrMv7dqNFej0QOjdLNQdghPEfD0dVVzWFZWgrwu1sIwdLm7 t5EUdW7SK/UAWJXX1HSZMdi5hAZao00Nm5UwxhROuH1atUvyIHLjujhK9BFcyLi7Pcxs0XphZKK 3pCDHhh8Ghfm4yLLIlEx3w++8fTW7UzoGbsK0ru88ROepH473kWA/GB/+illTcwvPhqfI2YnZ5M hVgj4vIDgns1K6b14p4A03NmGBVFlYojDd7y1tt3XkFsRH5u0tKTJA5ZrAM5L0zaFPuW14lHvPV LFiGOsEjxbR5PFANp19MDoLZSKGdf1x4q0d6pMicJDwb89AVAqjQ= X-Google-Smtp-Source: AGHT+IGrlpeDG+M1XFYNQBMVlA5m1LG8vzAaNYW0s67UXCoEigoyFT+rBXnmZPZoEYP8bDGeD73U6g== X-Received: by 2002:a05:620a:5bd8:b0:7e3:3276:99f with SMTP id af79cd13be357-7e63bfae1d2mr537840285a.53.1753504426331; Fri, 25 Jul 2025 21:33:46 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:46 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 09/20] staging: rtl8723bs: fix indentation to align with open parenthesis Date: Sat, 26 Jul 2025 04:32:07 +0000 Message-Id: <20250726043218.386738-10-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Adjusted indentation of function arguments to align with the opening parenthesis, following kernel coding style guidelines. This enhances readability and maintains consistent formatting. No functional changes. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 692d2526965f..e709a0bd24f3 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -154,7 +154,7 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, str= uct wlan_network *pnetwor return; =20 if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true)) + (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true)) lifetime =3D 1; =20 if (!isfreeall) { @@ -241,7 +241,7 @@ signed int rtw_if_up(struct adapter *padapter) signed int res; =20 if (padapter->bDriverStopped || padapter->bSurpriseRemoved || - (check_fwstate(&padapter->mlmepriv, _FW_LINKED) =3D=3D false)) + (check_fwstate(&padapter->mlmepriv, _FW_LINKED) =3D=3D false)) res =3D false; else res =3D true; @@ -310,7 +310,7 @@ int rtw_is_same_ibss(struct adapter *adapter, struct wl= an_network *pnetwork) struct security_priv *psecuritypriv =3D &adapter->securitypriv; =20 if ((psecuritypriv->dot11PrivacyAlgrthm !=3D _NO_PRIVACY_) && - (pnetwork->network.privacy =3D=3D 0)) + (pnetwork->network.privacy =3D=3D 0)) ret =3D false; else if ((psecuritypriv->dot11PrivacyAlgrthm =3D=3D _NO_PRIVACY_) && (pnetwork->network.privacy =3D=3D 1)) @@ -391,7 +391,7 @@ struct wlan_network *rtw_get_oldest_wlan_network(struct= __queue *scanned_queue) } =20 void update_network(struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src, - struct adapter *padapter, bool update_ie) + struct adapter *padapter, bool update_ie) { long rssi_ori =3D dst->rssi; =20 @@ -447,9 +447,9 @@ static void update_current_network(struct adapter *adap= ter, struct wlan_bssid_ex struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; =20 rtw_bug_check(&pmlmepriv->cur_network.network, - &pmlmepriv->cur_network.network, - &pmlmepriv->cur_network.network, - &pmlmepriv->cur_network.network); + &pmlmepriv->cur_network.network, + &pmlmepriv->cur_network.network, + &pmlmepriv->cur_network.network); =20 if ((check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) && (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { @@ -1343,7 +1343,7 @@ void rtw_stassoc_event_callback(struct adapter *adapt= er, u8 *pbuf) spin_lock_bh(&pmlmepriv->lock); =20 if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true)) { + (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true)) { if (adapter->stapriv.asoc_sta_count =3D=3D 2) { spin_lock_bh(&pmlmepriv->scanned_queue.lock); ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, @@ -1442,7 +1442,7 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) } =20 if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || - check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { + check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { rtw_free_stainfo(adapter, psta); =20 if (adapter->stapriv.asoc_sta_count =3D=3D 1) { @@ -1768,7 +1768,7 @@ static int rtw_check_join_candidate(struct mlme_priv = *mlme if (mlme->assoc_ssid.ssid[0] && mlme->assoc_ssid.ssid_length) { if (competitor->network.ssid.ssid_length !=3D mlme->assoc_ssid.ssid_leng= th || memcmp(competitor->network.ssid.ssid, mlme->assoc_ssid.ssid, - mlme->assoc_ssid.ssid_length) + mlme->assoc_ssid.ssid_length) ) goto exit; } @@ -2010,7 +2010,7 @@ static int SecIsInPMKIDList(struct adapter *Adapter, = u8 *bssid) =20 for (i =3D 0; i < NUM_PMKID_CACHE; i++) if ((p->PMKIDList[i].bUsed) && - (!memcmp(p->PMKIDList[i].Bssid, bssid, ETH_ALEN))) + (!memcmp(p->PMKIDList[i].Bssid, bssid, ETH_ALEN))) return i; return -1; } --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1435217654 for ; Sat, 26 Jul 2025 04:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504431; cv=none; b=LVXQJShDOHz4ffk4SsMX/CFn8VdWFLJA1PPgvookfnrFKm0Es2WUxv1lxHN1/ALBjcKH0OLT5elJM2baHPoUR8bq4drHMYvWHw1qDYHmBMfChodqLVXVpR7kw134cXafokBbk98GVDc5/KdG0XM1wA+5ewQRCa2q7gx9fpInjg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504431; c=relaxed/simple; bh=EdxnZO1mKNHaUo/FDta0WRFmI4czY7CItQeP/9UpgWg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iWkpVUW7bfGMzpxxyGswGztob7Cizv2cd0ZM++RqhgDbnHiExQX2vUKQHt5PIW8TFWun+ZUmPxTChvhfcEvCSkyb6EKaiUtrykHug2ozV9/2kUMRKzgvxnC2oxSf0O5IiNJITs+/5B9xhv7PlsCJHMTMPkHGR4VHFe5QezfKvCE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EOF2BytB; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EOF2BytB" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7e32c9577ddso293916085a.0 for ; Fri, 25 Jul 2025 21:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504429; x=1754109229; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wsGndhJCxr7LdkFb1HaNLZopmDj3oLL9w7okD1l9Vhs=; b=EOF2BytBYxKGcBwCb8Jw2UHwiFrNjLQyNBGBLyEWI9d/f11bSkdwYSrrGKpiV7DZ9T z4sD0NW4u1UtnPv1+qOjAjB3W+9TUyajt4LZM8LHOaVnNrr3ewTy3Aw+hZBpZd0ap2fI BbqVOqtTEZ6gYBg4alfLw45ufsOnLjbQ5da/xL7+ZGmoXKsfV5sFQ9ib6L2y35Ewtopy 8Vnzaae3hbmwQO9+WFRD4VvKhvn6nsRPB615hfF7EqcfOp0OYAxJInbJHfjN1yiGyOs5 K7LYXHxPbhiZ68u4Tzh5N9uvAJzba5qa46Cr8HTAkXhmcUuAlYa3zdDF3T4635CW8ldz izJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504429; x=1754109229; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wsGndhJCxr7LdkFb1HaNLZopmDj3oLL9w7okD1l9Vhs=; b=sz0G/QziXMU98hLHsJcf869IJmNSW7BeUOVBS2JbEz3baQZVIyLUpozepLi+p/CNkf iu5YWxLJ6NWyMAeARmg1+MJxLp72bdMZKtNpBrF4W/qhQQmy0xjEsbIwXNERYR1egWuo PYttYx4VMdehn29iH59VpALKH/KQKwZM/tHOkg9eKwCA4GIpVgv2SzXt65RAXDQIqFf0 xTPsso1GtMwoGRPXoSpm0B8H1scmEYEzPcLIOQVYgHyYhvF2tl7AzOvUZAI/DMWI7cmJ 5ij+olGK8zKQc6nYM3MkNQLflkQ5yiqu6SXEL8wt6QLiZHVfXA7GIU5yGBTH4cPeoIFF WXKw== X-Forwarded-Encrypted: i=1; AJvYcCWPSEWOl8vQxAarS/Q1vlA2ITmBtvqZA/mW0d9BHVts/2p9+glaLm20sZp/rPULzwgloxl2rwO9SkdyJ7A=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf09STJWawcSm732fhIUJACwz5xd9Hmv1YVVjuEk0IkxIDI8wp wYF8HEILsttT7blJSq5iA1bZOEqJ0P2OUSVlU94a9xlEd/Mj2CkaUsst X-Gm-Gg: ASbGncu3turuCaqAGF3sSVdtnJjJ8SiEkibbDwYBMVWnw0Y9M5or8kH4iDeEoL6f4f1 i4Zqga0P95RcLiwkW6fnigPKON2VxtliHTRLJcvhIJ8wCiObfHKe11ELZ/XYay4hMkZQy2uggVM y9n2hNkZHvEKDu3gG+e5hymH2CUiuY+CXSQt9rMOfe3TSD7tf+cMHsBQZ7zA7UEXs+CiOaM6CIH OnmL2n6EUyaGLRvhTODMl5h6uJi2/Gn9PHAY2EAZLVDYmBoksUxT7cQ0EU97sW6+/B6PuRVtrTS 5YOS8/Wk9IxNRFdF64V9vK1lGsPVurX9c6LomgfvFgO9+oZ9Iah9zeaKI4BFXDlYrDbHZc7av40 qENxF5fGbG69PRZGRmpVPXPCGLg7QxolbhvalD2bUbocVBF8V8CQ= X-Google-Smtp-Source: AGHT+IF2+YIkjcc41lC9v8+3waLzCwcvEeYt2B9BhrVe0lQnXFX6zEQdSM6Kzv0Z4ZzooYHlZ1Hn5Q== X-Received: by 2002:ae9:ee18:0:b0:7e6:2faf:883a with SMTP id af79cd13be357-7e63bfa87c6mr386323785a.29.1753504428742; Fri, 25 Jul 2025 21:33:48 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:48 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 10/20] staging: rtl8723bs: adding asterisks in multi-line block comments Date: Sat, 26 Jul 2025 04:32:08 +0000 Message-Id: <20250726043218.386738-11-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Formatted multi-line block comments by adding leading asterisks (*) on each line, in accordance with kernel coding style guidelines. This improves consistency and readability of the comments. No functional changes. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 33 ++++++++++++----------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index e709a0bd24f3..161f149bf244 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -188,10 +188,10 @@ void _rtw_free_network_nolock(struct mlme_priv *pmlme= priv, struct wlan_network * } =20 /* - return the wlan_network with the matching addr - - Shall be called under atomic context... to avoid possible racing conditio= n... -*/ + * return the wlan_network with the matching addr + * + * Shall be called under atomic context... to avoid possible racing condit= ion... + */ struct wlan_network *_rtw_find_network(struct __queue *scanned_queue, u8 *= addr) { struct list_head *phead, *plist; @@ -293,10 +293,10 @@ void rtw_free_network_nolock(struct adapter *padapter= , struct wlan_network *pnet } =20 /* - return the wlan_network with the matching addr - - Shall be called under atomic context... to avoid possible racing conditio= n... -*/ + * return the wlan_network with the matching addr + * + * Shall be called under atomic context... to avoid possible racing condit= ion... + */ struct wlan_network *rtw_find_network(struct __queue *scanned_queue, u8 *a= ddr) { struct wlan_network *pnetwork =3D _rtw_find_network(scanned_queue, addr); @@ -462,8 +462,8 @@ static void update_current_network(struct adapter *adap= ter, struct wlan_bssid_ex } =20 /* -Caller must hold pmlmepriv->lock first. -*/ + * Caller must hold pmlmepriv->lock first. + */ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid= _ex *target) { struct list_head *plist, *phead; @@ -496,7 +496,8 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t } =20 /* If we didn't find a match, then get a new network slot to initialize - * with this beacon's information */ + * with this beacon's information + */ if (!target_find) { if (list_empty(&pmlmepriv->free_bss_pool.queue)) { /* If there are no more slots, expire the oldest */ @@ -1794,11 +1795,11 @@ static int rtw_check_join_candidate(struct mlme_pri= v *mlme } =20 /* -Calling context: -The caller of the sub-routine will be in critical section... -The caller must hold the following spinlock -pmlmepriv->lock -*/ + * Calling context: + * The caller of the sub-routine will be in critical section... + * The caller must hold the following spinlock + * pmlmepriv->lock + */ =20 int rtw_select_and_join_from_scanned_queue(struct mlme_priv *pmlmepriv) { --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64A352185AC for ; Sat, 26 Jul 2025 04:33:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504433; cv=none; b=F9PaiMmpu6xEkztJj8SBKAFf5Juo2Gu9NzTc38Rrt1sVkQlAacSKdS1Kf7WB3OyMOtBuabDmnknVtUa/UepI7B+VCRnYMfKAktKYNOYktIaPGHqXCwHf7uPsldTsf8+WH7b8iWreHiWF6J2Fq6E8YrG/0ojDoCx6tQ6QU4GjefQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504433; c=relaxed/simple; bh=spShQhbzwsDpuuBCF0J00kLiKd8sC/VG38gYV30hMzo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=humAcnfdmJ6YL3OW0ISVD4juFv02heZcjfUvaCNbmxDVrCu485bnzxTgZb89ceAHQaFrRpKbhrnxvEyQoJ6E9xUY4IUxe7dgywrq5z0CgLnIxKFxsV0ZqKCt7W+mNPH6qcIugxxcS7c/9HGVl99iRkqKGKzmAAePOtEEcrKcIz4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YXYNI/3c; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YXYNI/3c" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7e32c95775aso306167385a.3 for ; Fri, 25 Jul 2025 21:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504431; x=1754109231; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+EZ13gOR4MCpjhKGk8VIh6hqTqWWLNSk/iwMXtaMPUY=; b=YXYNI/3c1hSq1z/0QrQe+/MVvm291qDdXSLW2Zb7RoUusLGFsPd8qv8NjQ/NMCshTO IjAER7j+wtSdsnnBY0DgtWSvnVnBX7g7g41wTY7M4r6EkMIw/8P9wR2W/ivVXRhaEdI/ O2liNoP9W/txXN9BZDCkT9uloe7QVNBKWu0p1dkHKj7IuBbVpZGaTEVybg7l3u9YJyfK JJpWXF4N10Y5Y1iyxsn7qVpCZhPPftJIIahgdQybrHDk/Lf/Ul5MWU+URL0tfe1xphwL U27m0KSfupogDklr75ySn4PNC9OhmB3b5P1WaRBtDo+F+5tC15CopqIXsAeT8H3Myd1f YNfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504431; x=1754109231; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+EZ13gOR4MCpjhKGk8VIh6hqTqWWLNSk/iwMXtaMPUY=; b=BEemzgW+5RFckUJYtu4wZdNExGe/KfqnoNFcsEGf395jzTdO3z0eIGLYYyQDq2+I0p gD5zTBIrVIjMXuhcR/q+341v1l0WdcQJrkMMzTpvc5YcbG8DIRSzj0+okugfIaTERA1t sZv5QwuBcV5q4hUqekZp9G8xNZzCtlpJjBGdW2vKM0tyqmMPFPpSKAhDlI9RWPpPVRjw rFcR/8TXfTlV/PuqTuoLxTdFOXblM79NXcsQBwAN7W/rIEYroyHFSyEO/p0Xw6aNaZx0 6PAbc/FeVMAGi/PCQWOcAnnwcHyVy57ahi3u0IB1wlkcRBkfGgRlu9ijHBvJhlsYSU8t yAwQ== X-Forwarded-Encrypted: i=1; AJvYcCVngSdtRLSSGwdIMc1ezXqWF9Af3EqciJQxegPv98jKOkDk0qTudHetiryAzlZB+++aoENfQmGSd8HKKss=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+GB/z11EQhF+16i7UTFle9u4UphFx5hk71tLlwIZmo6LNluzb vda4tEIwBjdSjBHDloJoHdbssZ1bj8u8U+FwYtLiCg4FLvraVDg8PbIn X-Gm-Gg: ASbGncvqde1yxgKK/MzNIm20KHsD76bkB2jpVrmlq9a7jwqMEU2KFMlbiuEMbiLkGBH yHHEKr6R7N8qVIwQ8SZ1p3SYW6G6N4e6Lv++K469NDPVYVMJbjvKIKDid3FKCO8s9u6UBecxX1w e+jSa19q+EuPyx8ZQ5i/wgBHyu9zLz+d6GX4gulzpSHg6BVNsMZ515qDlkYRy5uCCG6dIB65111 ptPbzEghsobj4WYV7JdtyVXzEu72n8RoxC3pA9oefo2WMCgXd1P95r5gV1bY8oawhBv5n5uSkZa 0ZgUwcukv9zbuho3VTagMDHY88RC+SJCjzsBKCx4AnhH26CcQDKVaj7h1qwI/vMzzjggg6mpHoU Da42p4L4hU6uwbMHV72MILzGY7WElOiShbkDNzhGL4iEXC4JQz9k= X-Google-Smtp-Source: AGHT+IHSWMa30iDJm+pBR8Q765qRcpjOUuLJpjvifMALXHOQqjnCpC7lXlrGDs+Vnb96ZoSfDY4SPg== X-Received: by 2002:a05:620a:2193:b0:7e3:4417:2b14 with SMTP id af79cd13be357-7e63bfad12dmr592154585a.61.1753504431314; Fri, 25 Jul 2025 21:33:51 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:51 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 11/20] staging: rtl8723bs: remove space before semicolon Date: Sat, 26 Jul 2025 04:32:09 +0000 Message-Id: <20250726043218.386738-12-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Removed an unnecessary space before a semicolon to comply with kernel coding style. This change affects a single line. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 161f149bf244..547734f5492e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2105,7 +2105,7 @@ void rtw_update_registrypriv_dev_network(struct adapt= er *adapter) struct wlan_network *cur_network =3D &adapter->mlmepriv.cur_network; =20 /* adhoc no 802.1x */ - pdev_network->privacy =3D (psecuritypriv->dot11PrivacyAlgrthm > 0 ? 1 : 0= ) ; + pdev_network->privacy =3D (psecuritypriv->dot11PrivacyAlgrthm > 0 ? 1 : 0= ); =20 pdev_network->rssi =3D 0; =20 --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2DF821885D for ; Sat, 26 Jul 2025 04:33:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504437; cv=none; b=F7ZsTUTWhxG32PJIzfhqOVmKJv2gKbs3AYDnViuW3rIXYXwIpwD2bjp8rZjjQpCdiKnypIn+32sbd+tOJe5S+AehfZ9Zo16SDJIGyxqC0qDEQ2gBScBaxJK8g3tG9TJiod/9ISeq0uzvFdEYU+uBRaLoAQ488nlCSdfgJX33Au4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504437; c=relaxed/simple; bh=WvWtSSG1WQ0XnFbhnhRWLKw4dnXHRNMYRUC6Kw9zqM4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kZJYszzZGdsJJSHvj99JONWh90vU8Jwv/buUJscqedQtaSc157GKzw/sq1CJmr9MetJMQRrGQYEruuPX0zFLg1Q3Rb1WeXLVj1EbQul02eGiDi4Y3e5q8o4t3KOu2NZGp5Zk6bt6t4x9WLxtNO8VYylPlx0V2vUue9rdHe3nMFI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vme20EAt; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vme20EAt" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7e2c920058fso386257685a.0 for ; Fri, 25 Jul 2025 21:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504434; x=1754109234; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gC45lvNfo/ER/85bNnioTazhn/jQr+yHb1t5QvafK14=; b=Vme20EAtllB0fD8Iq8SsxE8rV+J0C4zQrTRxZ1bjokeFURXC//SCg6DFVUHOWCKmeO z1Se3QSPIbP0AP85hSzQdqAJNeomoYSyWSSWVJ7SBEraz5RWsyRWXIrDHZ8RvUAiIOW9 PJzCiUVl7c4l5zyVStwb/6RCm0GlT0ZsqP+sppkMIIiJPjEuy+Y8mGd86WLGyXfReuYf oeuZaMJYX7L9VcLwwIBFYS2hTRvwUiy9N0n6sDs8upuq8ZqOUwPbFwJHPknx98XoiGHc E6XNciBnuRexRINupYrckhEObu/yDEepWjfJPfH10EmJoIn1O08FDUOKFAwVKhxgKxRc ZJ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504434; x=1754109234; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gC45lvNfo/ER/85bNnioTazhn/jQr+yHb1t5QvafK14=; b=hQq3gu0/SqoFNSGGNCAWcpDoC819qkfPuNYAACtHRYv7VYIFBbvx1BEZY1hpYiMet5 8W+/ZnMmXMkc94xEtu8rCtPtagosT28mfAvzk29ItjCfWiE/LWVrqgBQiK4HYcQ1zfVP CnbwGhin0VcfXstQzKhgBdK4DMcasuIS8HzAAzPspgpy76j9Qy9BT0pam4vvRt0wf7+n 1xypS1jUEg3nYKXSSz9FvKEE3FpUVsOvUpYcLw2xtnoIzQba4UKe9RWFugCmPq7mCnMR S3MRQjTwXpiE47E4FGTlhQjNP7wdeloZ/9mAlWcyr7fVkoYb+7DhCNec5+/qrqGNxpwf X1/A== X-Forwarded-Encrypted: i=1; AJvYcCWsMoHGUONgzwTnRn5w9rgT1s2NoC1278O8dxyKE46e6Pzhubi1367+XciTgZGif1N0ht5VAMpuCxYz8jU=@vger.kernel.org X-Gm-Message-State: AOJu0YyhPg/lg8oskc0ThsmexcPG0HY6qTQJ9JjMbJvX70x1NHhka2yh 38I1zTVctS/Kq86kYlDlVLXlEEjr8LTs6NzjXzBYYFOf/WoEJUpNOXowDc/wYQ== X-Gm-Gg: ASbGnctDhNh4U406ZaF8czXzp2RZ4/4RWTm6PS4pE3dkjAkrEzSVvllHatxvMSsT9Aq 2fhy2sqfwFl3yJAuHBMul6Aav1AE+RS9WaJZuJrhjBlOGGcUEB5lP74XkAA1MXRcRCGNxvtJIdr kbQrl+V2naFmMbbbbHnrSDrymi4fn1QFF2g1y1Fu2rdq0cjiQqKbAdDTtZfzToR0bNQESQgVmpy P51SRQafCxUtB1/Zmm76txQTg7U1Rfr2UO5otgSgXFyVG9UJMTXEZOsvQVUv5TGH0glxZRYx5Om FeJVdWpOchzQMSElIrDJ7RwoXmP8vQUMJgTn4XMdiDVWoM+d03zXo0LKa9mbILLl3nDJ3m+xy3D sFrvScmxiUvEULT6FDgQlCz7TIQG7O59+P3uiIt8SBSC2QXnK+x0= X-Google-Smtp-Source: AGHT+IHeiQLQMrg9lJ4rQcscOTGZVVaWggM4N+/ThoNuwNXhuqUMPhFd9JyXB0i08pGlDPbIypg4pw== X-Received: by 2002:a05:620a:470d:b0:7d2:189a:5949 with SMTP id af79cd13be357-7e63badac12mr611023285a.28.1753504434208; Fri, 25 Jul 2025 21:33:54 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:53 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 12/20] staging: rtl8723bs: fix excessive indentation in nested if statement Date: Sat, 26 Jul 2025 04:32:10 +0000 Message-Id: <20250726043218.386738-13-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reduced indentation in a nested if-statement to match kernel coding style and improve readability. No functional changes introduced. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 547734f5492e..0679253355fb 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -1160,8 +1160,8 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) =20 ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, pnetwork= ->network.mac_address); if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { - if (ptarget_wlan) - ptarget_wlan->fixed =3D true; + if (ptarget_wlan) + ptarget_wlan->fixed =3D true; } } =20 --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F03121A428 for ; Sat, 26 Jul 2025 04:33:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504439; cv=none; b=newFBKt0QiqSnsEjjDRxcDIUMsDZXmGw1uUPKT4jfdfdYxWQVvPDPHP8RTeg/AFDprM3Gh0/6b5f3Ks9cmAkjdc8AwHcK2QctDJioFRpc3AAowwYopJJg/AJ9qgg9Q4aUwTkwpqUy2vsilRkwiqXV3XgdG1WZqo476SMre5cZ0Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504439; c=relaxed/simple; bh=bHpCkXw2jAUbdB0APKtn+P8IbyPZtBP4nbGI46DyLuI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iOUTvKRIe6BR3kEcKziar7IOLEMtUX5OUQJFtEc4fjbN4viiehzaxiqRrPBh9SUB/of/g1tdiBzwq7Xd8l36PANBnxXcLqMqedgzMpR4668Yp4xX9XXANdn0v0yJC7ppPz1unt4gQM8jE+QoWBF3/yGPtZ4+mEeePneoaD4Kmj8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J6wmrZ09; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J6wmrZ09" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7e1d89fcc31so273928985a.1 for ; Fri, 25 Jul 2025 21:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504437; x=1754109237; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=63m/SWyED5sYk+Oa2JkBziHJjgzvSnwpbvgqu5JEyLM=; b=J6wmrZ09NPufAjTl0qbWEeaelwWkgs4dr7cK2nDs1HJ7qGZPNhfUVEGdL9nt1lowBj tnJx0DD0+O8QDUtPTD707OYLXmfRhKUu0ZmPvvCSyr7KSPgVB9O/eez/ozyoe8RY9aCr znQUV+wUuzStPDk8+80ybGwy+6lRhTrBCsOasCB4W8lmFLdY44peceGZ2a/V/FmFMr4u yM/futW1UuG0fSAe7cgsqn5px30rFGC0IY8WdDOefkVTKjh2sJncmPWCVdVjP78G2mQl AAz1MmEHlAzd2RXkQmmjh4ngza1ZfK0PGcRsyT07TD+Z561v9HDNABUWAdfnNBErqLb9 eukQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504437; x=1754109237; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=63m/SWyED5sYk+Oa2JkBziHJjgzvSnwpbvgqu5JEyLM=; b=AChdXUz2UYOPFqGpsRStDpEIQhDZJuKhviBMpoTdGt9iNTcOpKC6hGranrjzhBRjVf QIGYkEKUnXnouCyqBMC/AnKTAPDj2dKdeUR95G6n9uh78iGI1n3ZLb1Yct4rEM3T7J/A OXyJRaUq+TurxuJbYeBZafbU/7gcPxVBAi3mckY0tkOGduEcxHDDhSGdfWNpYOYmNUP1 U0yr+C9GGhj0XKpyINkMNQ7IgGkzV6bBBUWO+0soq1Tmj9K20os3Lo2IkwNw2IBn9mQC aT4G9EIrAWj4duYId6SLvlWLBw1xJFN7er/gepxppQWs8ngQq7CkVpP/dYELY9rBkCdV 6mcg== X-Forwarded-Encrypted: i=1; AJvYcCXbatX3fMSVxQlEttTqfFgdvRgfUBZ7ul7n7cg2u8c6IbGvLD25CJB79WpTqrZkMOQNxAdwD7VhbqlKqQ0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywwpkv2PK4NKOJYo0CjdT5jM8LELJBmVojCtKyF1b1irlQDvSo6 +GYoSwaWDpEQyjizl5QaQkCrmDH6eG7ENSF/waWcn88WsvhZO68CFqkGwtFDBA== X-Gm-Gg: ASbGncuP4fuyxSkC12oAEM4fUJv1+kc6tIA2tRyKLnJjRvckcyvwy8ZyXxGgvTZG69M nhOt2yyo1A0zI1nYEEkZNeGgOKmFe1zdWlELeI2JmsgbRQ+W/PfKNKFgeXwMFHfh6+2dDMCh57s ziB+inlNtoeRHLHSkQn5eDLUaqKvObJyeRaq7jcQXoB7sA3KJSOZu/MuzCMX6wqsjfplYrQ+LSZ Jt9YxHVyhSNz+IulvqXnnZI3amoZVcFts0BUnetNgCUpOPO+mzmVZ0WPvBNrmdyQ1wlZaj5tYuJ Alpx1ewzph8+z53N6nj3eKZUyPdrbYrt7+bEg0fBREJDY1Q1tgPZis80UP9vF3PNduVZTj/FCY/ VhW2Pv8XhLzbk1nfUkJnutfDp2JQ6VA4NGupe4heeDIEOL9x6qFw3wT9LeZtp/Q== X-Google-Smtp-Source: AGHT+IGoCI3vD+pDpwPHdI/MTAevkKbu28bSsdg2wSHhYsvByghAdZ5a+1YJUELp9vOMzDuwhZjohg== X-Received: by 2002:a05:620a:370d:b0:7d3:f17d:10c8 with SMTP id af79cd13be357-7e63bf9d6d5mr613157185a.43.1753504436927; Fri, 25 Jul 2025 21:33:56 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:56 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 13/20] staging: rtl8723bs: fix unbalanced braces around conditional blocks Date: Sat, 26 Jul 2025 04:32:11 +0000 Message-Id: <20250726043218.386738-14-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fixed improperly balanced braces around conditional blocks to match kernel coding style and prevent potential confusion. This improves code structure and readability without changing logic. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 0679253355fb..3702d7e7a954 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -758,8 +758,9 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) } else { pmlmepriv->to_join =3D true; } - } else + } else { rtw_indicate_disconnect(adapter); + } =20 _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING); } @@ -1578,8 +1579,9 @@ void rtw_mlme_reset_auto_scan_int(struct adapter *ada= pter) else if (rtw_chk_roam_flags(adapter, RTW_ROAM_ACTIVE)) { if (check_fwstate(mlme, WIFI_STATION_STATE) && check_fwstate(mlme, _FW_L= INKED)) mlme->auto_scan_int_ms =3D mlme->roam_scan_int_ms; - } else + } else { mlme->auto_scan_int_ms =3D 0; /* disabled */ + } } =20 static void rtw_auto_scan_handler(struct adapter *padapter) @@ -2281,9 +2283,10 @@ unsigned int rtw_restructure_ht_ie(struct adapter *p= adapter, u8 *in_ie, operation_bw =3D padapter->mlmeextpriv.cur_bwmode; if (operation_bw > CHANNEL_WIDTH_40) operation_bw =3D CHANNEL_WIDTH_40; - } else + } else { /* TDLS: TODO 40? */ operation_bw =3D CHANNEL_WIDTH_40; + } } else { p =3D rtw_get_ie(in_ie, WLAN_EID_HT_OPERATION, &ielen, in_len); if (p && (ielen =3D=3D sizeof(struct ieee80211_ht_addt_info))) { --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC6FF21ADC6 for ; Sat, 26 Jul 2025 04:34:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504442; cv=none; b=DvUwfAVe+40YA2K417bdpfCAutmThDrniEjWouRi6huJSkM6lZHiOu8J+midkF0WNgfhj2AJygzx1Pkhh4RihqzMefkVYkHD1kIfwzEahWKvR0Yxqj58ja42ld9IVV9eGPB3nB1AAHqjwDbWLmf0G359VHpd2KjpoNOfuppJiF8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504442; c=relaxed/simple; bh=Z5OaX+7jHTU3mMvL+WEAgHUArV9m2T9NzvHRba30tZU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dtIqM+PGum38GijE+50SPaqtRfekfgPjTeoiDf4HEEIAWTzc/bZ4uwFQAKj6wz3xfnv/jdhih6tkOQu0Js9tQbnhwUbVN4pkWYThaiXkiQKvswdo+GqJXqyff+CTcTfjCBwA02YemoXBijtLywjoHmfUZuLIM/roxwkH1xST2tg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NZKZ7SS3; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NZKZ7SS3" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7e29616cc4fso249140485a.0 for ; Fri, 25 Jul 2025 21:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504439; x=1754109239; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ODpIvfyNJQSFOOSJUan5t1Okvzxpa4QfGplGbiE7DTQ=; b=NZKZ7SS3KJsfjXQZD6mFm0mgWKDjbr8pYajLqiggYP91AihPU5d87mXEZ7fK0CRMKL lhtkEr+GoPHZrrD3z/j/PB6DXTnD9NEDaOHFEDxVK89D8i/c+a6DL5F+j/n0/F1dVstC af0nj98aqqQhsBQQZJX2VVn8xnPN2FQ3L9zTQ5oN5WchiRfjvpELMQy9X47eEOnjpLBQ Zfs1oKmK6qMu6l2x39rbR34k0rA0HUZpluII+AeS2UbkrLlCCOVLHVJPEip0JuRj8FU8 O694flS1sGfZVBGRlWikqNNAshr5YCqN0Ebh9y+VawOH3R8VKYSLApTLxQiH/IUyfzgA RY8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504439; x=1754109239; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ODpIvfyNJQSFOOSJUan5t1Okvzxpa4QfGplGbiE7DTQ=; b=Fq3ZQDlKjSF8owJ7AgDkUgmPK8+kuk+nsBaO95LzKxeNOUOsMpVEW1gvMVXFIc6WYm 7FrlyozaUROHHWaXOkaZ3Wvl291hbHCUoSsN7salxkiPvTQVJN4JOAoD6/em+zTmmce7 wrv9RXGkHBra1dLrnyBLyqVvlmothTQ8xyBygS1XJRl9KLs/kBTsW5WXAIpCTy3co3X/ cJ5UzfWDXCslar0Tg+bT0IIdqF9Zv5oS9ei/3nEsVrpEjHEYrPd2aUHKPlIcZKJlqn83 fdbh4c1gxqa4E9JUrIRszhOy5i94bY8Exy97r9xdXGAiuYqNbWq0Gm+qiprGIx3rooG8 cXjg== X-Forwarded-Encrypted: i=1; AJvYcCWp2E9KnLxW4T5cASSQi6xdLEg5VNCncWJgxf8tAcGBHo5na09X7Z8rxDJsi8XfdInRCPeKiJ3zpHKipTc=@vger.kernel.org X-Gm-Message-State: AOJu0YxDzPaaVMenF+1i6Fa3o6kjKYTfadYQ0iiOUIScbEAADoa1MIOc RmdBPrvwI7IaxFfiGjn9i1RQf2qQdsJctJyfjAFWUIQN98FhULKBmsP1 X-Gm-Gg: ASbGncuxml1eutJvgzlJgIxpMxi8bba1NhVlIEUbQG6sO1MT8+998bhTMmkP/kzt6yP Pmryp7CCBzXlcWZSfjwD5SvwiNiyp/zoTKeHsVf45jCXmvMQjg4ZjCynhjokug9EAiwrOlAbCuZ su4Tq0/DCmouW/Vqn6XAldRC9PtwALxtIA/IfWrpJ5W2lAbdjYbABSNGrcJhhn3pJlWCBNQ5Y1T EEo6qr/jJH+mGyYSDCv7/E+g8+cawxPAZ1atAW3IdIxLoNt3rUF+IzDq7WgFTOVjbHqnZEein// PEWJS0dXbBDMj0P1uahsd9Jf8MFSGq0emF0nSMLe8BZFR/sSrGiCQ2k2H07gG3TUQ+1MQLczIOB rpUI+Dg02u19x3xfMTiaZvcSOEei7oA4IMKAtwjSAmW5Ye/Q3kq7VbcFOZN6aGw== X-Google-Smtp-Source: AGHT+IHSwjMogwktb6Ggg2pYyg91/CxlwjpPDIMYKadReDTC0+8wXd6HyXUmMXE9QwJMXp80jeRtaw== X-Received: by 2002:a05:620a:288e:b0:7e3:477d:53ae with SMTP id af79cd13be357-7e63c1b1868mr579325085a.54.1753504439572; Fri, 25 Jul 2025 21:33:59 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:33:59 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 14/20] staging: rtl8723bs: remove unnecessary parentheses around assignment Date: Sat, 26 Jul 2025 04:32:12 +0000 Message-Id: <20250726043218.386738-15-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Removed superfluous parentheses surrounding an assignment to match kernel coding style. This simplifies the expression and improves readability without altering logic. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 3702d7e7a954..d845eaecd615 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -700,7 +700,7 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) rtw_set_signal_stat_timer(&adapter->recvpriv); =20 if (pmlmepriv->to_join) { - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true)) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) { if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D false) { set_fwstate(pmlmepriv, _FW_UNDER_LINKING); =20 --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8CCB21C184 for ; Sat, 26 Jul 2025 04:34:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504445; cv=none; b=SsvatFsoNLhf/GagQqeyMxVTf/4PXI8M401kXKoV7ILRQzEmzw9cmZ7baTfHEcSepqWIH8VXZmual4ZT2wenbKrqRpj50eDX/C+nOozPu9u9uGN6I/fijD7ajpEb+0P/CB11U4QoPMaXLDSIN7e7GStVsYEP8wjfwmtnl7aM3Ng= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504445; c=relaxed/simple; bh=bM0Vvx92cKEQOLfqkhukRo406X8XLDfUAl5uTTOBuYs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=g6H2Qv7wPstaIG0CJ7IBOB8uH+diQcHMeOCMIsuMf2aaS85HBEM0LBdfYhWp+wnO8NuYX7/zPQFJ08MHZNuA8qa76L/n7EigQwCoW9x1R9wszwF5xZCfOpXUsiIcEplsCsUvW2/l/eJPYJv4+qA9Wml5aoVIZib80/72eEj7Vww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K2HQish+; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K2HQish+" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7e62a1cbf82so168415185a.2 for ; Fri, 25 Jul 2025 21:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504442; x=1754109242; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AFyIKyxFfSvkenjutTa3WXgF+K78uS/6Wm5w41WWk5k=; b=K2HQish+7zHayWYshK//UcdD3DJR0atYXo1YI/7kcWA5UCz2Vhjnkx60B96UZvSnZ/ /P2KYDLemySzalGhjMgMzF+6ZbdVGhhsLgpBC8edIQdtbXZXO4RGATL+O1bYe+yLw8LU f6BkCeWFXd0Q6EExY8riK0F2x6ZpoLFPf4RM/sp3CXeerjH8QrWz7IjM6fUbgTWSpJnn dAS3eTMVvLpYgOqZg5YRmw1DRzLI0C675XrpDLmtHididANEVHV0tb6Vrf1UgT+fH96b DW2nLKRad0mtfgemJnzK//M+3aOKNL56zM7fCQ/Et7rIDhyW6zzJ8rAiT9z1oROfVpT6 MXcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504442; x=1754109242; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AFyIKyxFfSvkenjutTa3WXgF+K78uS/6Wm5w41WWk5k=; b=H+iKs+BBmYH7w1KPiJf8Go3vOO+FKCtR8G7BGRqHM4a0ovA3LhcnN3syyS7wkE429l ZgtjLd9An/88i7qzVfe0XHkdWCOA2Chv0lZD6+5SLNkkl1W+PaFzVB0w+c5ZdavL0/8b C7N7vOuwZ5p8H0wxLV0WoFIkLRcgABdY+/TS5rtoLffP+8eMsEsbzhpLIdNu23FPdCrW 7QV4/EqvNTCzna4MtZkoQ0MF0+vl2UWiKTsChTyjOLd5HOuOUG6jpTB8yKKTqwmwuZFL pG+GjFit7qYNvKVNQmnYejRsyaAkkc/uItV0wMAnVc4i1YqqIhqM2QpT2NH/EYs/1M52 Q95w== X-Forwarded-Encrypted: i=1; AJvYcCWa3hLUdLbiagHiqsMS/wHkcdvAB8Tmo1pIrHBVFknGJblaEvtCQ6Ndr1/CKT0UhkCchzeij1Lo9P3natw=@vger.kernel.org X-Gm-Message-State: AOJu0YzHOTYMA0dD+KYTfPLL8mlVNOtb9425nMAgHlzF/J/vUt02bTgy VIm8eCzSdxlpLSn68BKP3mYs7ddpatQMTdONzDEuy9TzjD7RmCQW1FJD X-Gm-Gg: ASbGncswECW4LVD2/teAR0ABsfn/8+Ealnco3wHcc0OYU3BIh/MVwLcP9aYwmm/fVNt u/RnOnIBHSUL9OvfGenyPVAvM1hhY5PFL4aJ8HURWAZ40n5PNPljR7QRNL5ORfmtPny1UEOkNuy fzsHyE0zwYjUV1yU8os2IKDd1AdkirtMcyMeeVDw+O8U9AwqAOZFakFnlmEKRMKHxsxet7iEXb7 0GYKeDkmjc/j2BdrVzu4cm3tcfX9a4R+KQYh8nwxM9nAl9uHF3fC97AaiZQnZWfz7kYEpVp/zx2 H7pwbm1pQ2ngd9G3tYDSG58LzyiogI5XHU/Y0mUu0rtI1ZdolT940UxM+nMGSXUWt0wlCv6sPlb iRivP9mGfQklT+lx19D0/tdNLRGsy8F7ilPeZaHx6K/+TxYmyJIE= X-Google-Smtp-Source: AGHT+IFpFHZe0lJfxuzoFTC3VS+z3g4wsWyK4qBicXrUgk9/6HYdXvu+ijC0mv83e++I4g7KoxuBsw== X-Received: by 2002:a05:620a:2552:b0:7e3:426d:f45f with SMTP id af79cd13be357-7e63bfb09b8mr357945985a.34.1753504442457; Fri, 25 Jul 2025 21:34:02 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:34:02 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 15/20] staging: rtl8723bs: remove unnecessary braces for single statement blocks Date: Sat, 26 Jul 2025 04:32:13 +0000 Message-Id: <20250726043218.386738-16-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Removed braces from conditional blocks that contain only a single statement, as per Linux kernel coding style guidelines. This enhances code clarity and reduces visual clutter. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index d845eaecd615..fb7ab7eceb54 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -487,9 +487,8 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t break; } =20 - if (rtw_roam_flags(adapter)) { + if (rtw_roam_flags(adapter)) /* TODO: don't select network in the same ess as oldest if it's new eno= ugh*/ - } =20 if (!oldest || time_after(oldest->last_scanned, pnetwork->last_scanned)) oldest =3D pnetwork; @@ -2415,9 +2414,8 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *= pie, uint ie_len, u8 channe len =3D 0; p =3D rtw_get_ie(pie + sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_OPE= RATION, &len, ie_len - sizeof(struct ndis_802_11_fix_ie)); - if (p && len > 0) { + if (p && len > 0) /* todo: */ - } =20 if ((pregistrypriv->bw_mode & 0x0f) > 0) cbw40_enable =3D 1; --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 439F921CC79 for ; Sat, 26 Jul 2025 04:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504447; cv=none; b=ukeSGZl5rp++AWvG8gFCkPwlW26E5VonULyzl9xscbemEcMapatvGnicrPPNdhUd/PWrou04LARJqrRnfvUg4BbEKb05p3wkqVEINqS6thPsmyb1MJchpA0spqvTmvw47eMq+WgGspA9uRT00TVRctWKRAp8arSlORPhjScPWt0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504447; c=relaxed/simple; bh=95tRCUajd2YWzthjvIMZXiLAW0pTk6LVGoVuxLw9wO0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DU7rqMHwqmiYYXOdz9Ih07lbm0BXjPzSRotoGehEyLyKl9rIWAanuyEVamaSMCd+dUIIH+83PjuDvkkKrU/x7c9Ms+yFxEF1HcvfwKUa0c1FzSdbadEn12n3Gtlh+O1YYF3j/x8QBfZOH2oVS/I092zEhZkssn7WvxWxIRTGv7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X5W075o2; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X5W075o2" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7e62a1cbf83so274961085a.1 for ; Fri, 25 Jul 2025 21:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504445; x=1754109245; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a+oh4R8+Xz4P49bJ6RR1wQypz80s2da0SdRPMOzyOPc=; b=X5W075o2yz8dkSn6wL9QwLJyTcD5vGLdzUZPTRXHsuoOfxIEPJ+mi0odVowRuQBsz4 b5W3beNv2u6Dk3PpwjQ7bmoDWpb3T7s4aWsrafOeENb+FSAYJQ3GwMzPrNty2PxFvK/z w6ptlXk89k/CME1YVbwp0OdlVpyudk3YDlGWaMigzrzg38mk07ixqcJurumRekVQhDGt 6judQBHn6xaNK7TvNyqWtPhV1OFexLOp0rKB22DxfCXh4vF2BCW/wMA+m/aFBPiPh37G XOeHJfBpWln4tdP58+k6BpYgYOCBRkftbuoWk2nZDdvDrL9KnErlVCiWYv9YB6vrHpA5 r4fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504445; x=1754109245; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a+oh4R8+Xz4P49bJ6RR1wQypz80s2da0SdRPMOzyOPc=; b=WLo+KSjs3NDgC4vVY8S/0+Sh8OtgtXoaDWN3iKYdirZ9MzigRtNby5b0+BUM3iQ7RO ombbMqCnJTlyAcchCL9mb6UjsFTiMX55QX5LRoZGy+h1WHjkVMvBSR3ZIBXmV3FGS+KR 8EFETFKTeySwqZXUrwNM6Oi0uN86BQd1vxQjstGHc50ukR0ca0IHAw8bC3Lpo6Jaxiqy HW+NrhsCzNg/U2a+/ojPf89i/d6MI2VkuhzxWPu7LnyRvI33Ef8/vxn3K6rNQtEHbWto EH4Hzu75CQyV/0vJnISg1U2e1rhw13fmfS1yrWRzRiP4c/o23Yx0O3Sz+uNDL2x1NTPi 7b9A== X-Forwarded-Encrypted: i=1; AJvYcCUK5IEilPHNkxWa+GFcUUw/lZVPkxS8Ox4YqVOGe9y/LeiyV1v+Ffsz1CovDlGcQ4syZ82duCMscZLVWrc=@vger.kernel.org X-Gm-Message-State: AOJu0YzrZiMmnwSl/NjAVXwWbWmPkxAeFOpoX7IroaVmqwtwayap8u61 wNq3yvwgZfS3bpF1ilhISGAnTxxAagNh0RjCtpG9FwueP/8uWnms2lQbP5qapA== X-Gm-Gg: ASbGnctO49VezmpKdCK52SqPby7Bzo4YQwS9V6p38rIEhj+1CvcEg+jw/WuKSYavAP+ gYcjG8JbyT9C4fl0yUiZBzF0gbrM+UiLedVRQlls4AqT+x07BR2Wd3hDjSGQ1xw6on9Du7TVZVa prNWrC02nadop75HK8b0uvy21EatcnUbzZxWy0PuLKdpKJ9YoY8EEbz/P4slIYRaQEsJt6b5cMI rdZ8VA/rofa0fOwmlUmCrmu65TaHTfjkJHinY5lb/FisOJgoebpR+ukuA0vz2KRd+7CUYA2IrU2 nn8QEG8MgMsKOMNjvxMNICOniOiXns12QhDq6O26nfspY9Ftrk1iY3oDaKxyrN9BIplmOFN2sG2 9mVKMiIu6J62ZwplkUrkmG/qscXSeGuEfSn5BMpfbomyVbqW94zo= X-Google-Smtp-Source: AGHT+IENcPolz2NGbAdveExhQu7dx7/c6T6biciIaJRVqa3hpe/07ZSgoIvG0LIF/sal83OsbxKm5Q== X-Received: by 2002:a05:620a:109a:b0:7e6:28e8:2dab with SMTP id af79cd13be357-7e63bf8c5b4mr442052285a.40.1753504445233; Fri, 25 Jul 2025 21:34:05 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.34.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:34:04 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 16/20] staging: rtl8723bs: add braces to all arms of conditional statement Date: Sat, 26 Jul 2025 04:32:14 +0000 Message-Id: <20250726043218.386738-17-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Added braces to all branches of conditional statements for consistency and to prevent potential future errors when modifying or extending logic. This aligns with kernel coding style recommendations for clarity and maintainability. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index fb7ab7eceb54..7552f7e4d14a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -1571,11 +1571,11 @@ void rtw_mlme_reset_auto_scan_int(struct adapter *a= dapter) struct mlme_ext_priv *pmlmeext =3D &adapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 - if (pmlmeinfo->VHT_enable) /* disable auto scan when connect to 11AC AP */ + if (pmlmeinfo->VHT_enable) { /* disable auto scan when connect to 11AC AP= */ mlme->auto_scan_int_ms =3D 0; - else if (adapter->registrypriv.wifi_spec && is_client_associated_to_ap(ad= apter) =3D=3D true) + } else if (adapter->registrypriv.wifi_spec && is_client_associated_to_ap(= adapter) =3D=3D true) { mlme->auto_scan_int_ms =3D 60 * 1000; - else if (rtw_chk_roam_flags(adapter, RTW_ROAM_ACTIVE)) { + } else if (rtw_chk_roam_flags(adapter, RTW_ROAM_ACTIVE)) { if (check_fwstate(mlme, WIFI_STATION_STATE) && check_fwstate(mlme, _FW_L= INKED)) mlme->auto_scan_int_ms =3D mlme->roam_scan_int_ms; } else { --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCC3E21D3D4 for ; Sat, 26 Jul 2025 04:34:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504451; cv=none; b=a7da0QB3CU0vFrgeCbtTE9atLeRozvTxej/epqwVkyanrlTA0uoqm04CDKtKVb/SUoZOVzmJpVYpiJ2TlRnFJ0LJB8YTHFoPcPrNrCjzWFLGpSRC2Wuo3Vi5O3hS918G3GcGO0KgJ0hgYMXHUHDCPLZLHrBhExux/GgC0ftEN8Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504451; c=relaxed/simple; bh=SD0zswV1u0CGmvyxeeBf8KvgCVotkDI4w0dpQTwrq4k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cX4ghohqktfHFG/cck4Sz8Niw2Cl2PkgSAsU5DtiGiTyTw2vXFr/gp9k/cb/xWO3s6Rdbr2c8m2h777IoIhR87qSwcdLWKNyrLHlwRFW4OZghdq6Bls4nGMZkiqfsTVZ2INwIOxAezzWMLudkf+pyrE1LYzZMARJFVkVKRxP5GQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YtjMiiJT; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YtjMiiJT" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7e32c5a174cso247081085a.1 for ; Fri, 25 Jul 2025 21:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504448; x=1754109248; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aXnNS3kNW1BU5HzPFn0KRN0y0JHuPkxgBF0lcn+1alI=; b=YtjMiiJTYvv7aD8lbFq2CBxtnZdvN5y5O4bqh4C5H+vpsPrwiTwMTMZKj5uwDQ3AB/ eAignyxY0Mm6pe40GuURh6Su7LiBa0+8QNUfsO5w0qObAs7vNBsdNIexgXurrTSstg0c n6Ywje36e0Bfur+ve+1Is/bFtUppyC0IkD9T36r2uNw2c0vv9x0ZWePXuOJVaqKne/kz We//BRU+BW2AxzghueGz0qrD1z990kuQBViVrVl9oFz7GlkKh0w0S36tjM6FwlzWZR0F eAEAQnicI6u3isXY6cTxNx3UdjoyzG4wWEo9Id/6x9LAfs2d80HLsdjx1IqgX7kSh11x t20w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504448; x=1754109248; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aXnNS3kNW1BU5HzPFn0KRN0y0JHuPkxgBF0lcn+1alI=; b=rnTV1kVwDA4LUyDp73lfLB/f06GVUyAo6eu2KW4hBsiCHK0B3eujChim6gxUA2r8kv +9NYTzA4Xn8ZZ8rO3kNGQR7Oid8s9CR7MVv0xELzC27S5uj6cDAGzTBplPp5KadKOxtQ EVaYHX9wPSKi7YLrVeOXOfxXMW49UGXVM22vkguFn7Lpq3c9wM4Zj92gIHOW2DTi9ZGz 9WIE9/an0ZsuOzzuMaJVTfjHW0cjyaW6K0vIYMBULVEoUqBfcxJl1WDbhfJdb8UdK9Su yd6g08oMfXPBHjqQtuYbgNmR4AMUNxOx9FxmTesCr8sj3VNA5NGOCuuWmcfXQY+evHGz /F2g== X-Forwarded-Encrypted: i=1; AJvYcCUkHMNacXVusJjemhrxyQt8+fmKlrvflI3yHzUkOyr0WKXNQwjlQ+4tNjQmEXm56vEpujIFS0vpUjDxgl4=@vger.kernel.org X-Gm-Message-State: AOJu0YzVUOUuDAs9Eq7DIdgTWB/in+PMj2dndua2+Ca1ODeHFZ5XAXOV hae2LjnmYhsNk/ES62Alq9aGIeoVgjMcKKqc9SzC+jqrnvk4hshRdxaH X-Gm-Gg: ASbGncsDod3O5cXssQNoghUnxPoX1PmL7DmgKO2oM7xvuuTV3tcKLlNdcosuD5m/OUG n0mbyeFhjoWSnAST4cchOEKT2YurCVDKTA3yy0l5D5As3Z9ROkUOfXiqTbHRhK+nliF2daxmlw1 GE+RaLK+q/siP2RHki8TOvCLZGOogRaDPxdEXX8lL0BWw1adApQW2OD2jaFUcwif+8WQ5rOrjZv T4xtl39GDP8el+l7aah848XfmYPftpAjAvy4l1K/mn7N/mquBbnLkoyUfWN/2OCRA5taiKhpTsh bFMALqw/33nD7G+1oy88z4JEgDnGVsCAtb0Hc2nD1hqzEKMii4HDZZOnDbotlUKbw3/dZqgOiL+ co+aq95DywcrqD28DLtDQDLyx3XoIc+fFE7jD2/YIvULGywZyHno= X-Google-Smtp-Source: AGHT+IEIljk5xUO365R10IAg9Spbt4O71JMQ50AM7dIBDTN/HgutLWOPav+9wvQdCMsgptojJINyRA== X-Received: by 2002:a05:620a:25cb:b0:7d5:f350:e533 with SMTP id af79cd13be357-7e63c1be353mr449637585a.29.1753504447839; Fri, 25 Jul 2025 21:34:07 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:34:07 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 17/20] staging: rtl8723bs: add blank line after variable declarations Date: Sat, 26 Jul 2025 04:32:15 +0000 Message-Id: <20250726043218.386738-18-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Added a blank line after variable declarations in one location to improve code readability and follow kernel coding style guidelines. No functional changes. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 7552f7e4d14a..acacc2806dc9 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -1449,6 +1449,7 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) if (adapter->stapriv.asoc_sta_count =3D=3D 1) { /* a sta + bc/mc_stainfo (not Ibss_stainfo) */ u8 ret =3D _SUCCESS; + spin_lock_bh(&pmlmepriv->scanned_queue.lock); /* free old ibss network */ pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7561220F2F for ; Sat, 26 Jul 2025 04:34:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504453; cv=none; b=mCTLRfbYMau45bgEhnEwxoWSSVFM3mCaArgKksKQhBlrE4LzJtevi1jOZZcNaOYURfaaNJLkeOKzp9VccslF1o++M745BqgTVS6d33g10qfGKpjuuJgSdumZR9dj50HVLsYHvKErtsl2tV30hQNdZYiHcB6kLsegFqxgKK/llH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504453; c=relaxed/simple; bh=A2/8GWYF+QSMZie/dthNKmgZayVxmihhCGf1guv1yBE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OelKn7eZuy7bZldw0BO/8h2vUATmvsNLlsq0LUzvYUZT0sOHxJ1rqMW+v2lbGaizqUkt+tPR6z8Av1ixUTkkBBdetRBQobxna3VMhNNF4AMQ4y8V8Ty1gJcaBGHuKfuz2APbl7/bYl/4n3YauLbrCRxeIhoAaALB9QB6t5Z8qYY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q6vcNaU3; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q6vcNaU3" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-7e32cf22fdfso258981885a.0 for ; Fri, 25 Jul 2025 21:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504451; x=1754109251; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=godtxK4YgpknghXRHE2/UoeuQcLZlCjOGnevqfxGStw=; b=Q6vcNaU3Kuu8jSYZhQVp1QtXsCq9+Xs0Y/gZT3yTaC/a1qgvZP1nhaOB7bCY4jXmUl CsZDPGFwmP0qZBQli+b0kWKCFOs9B6VEz84f93TANFRahHx5Usc7diqxQ8r6/EgtfBeL c0uNKKNnV/Vk1ur+Cmuvuy6iyNZMB/8e9U5sv40D9vHegq08rnoodCGGxPl9ofcPZBe4 kWZQK7KFMP9/f6RSUahc/PYXnTvFrx8MorvlzeeGpMTS3fwI+5pt3N194HcH4Pyc0scS li3wEaBJHzA0Q1MUV9aLEd0xB9SwZvs5AjtbN7tH1TSuHC44mF2mZ7rOgV7RInKjcteF ePDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504451; x=1754109251; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=godtxK4YgpknghXRHE2/UoeuQcLZlCjOGnevqfxGStw=; b=Q7zYd8huDvu88kH3CT0CYBCbAEa4Yw05fHzNw66rrbEJdPPtHYAqWTI8xs7vexpKuT maJTBtjdFiJ9JrilnmWEfkTR7IcW2VSqpBmR34K7FjGW0PeHMGSahRyodcepgkMh1SXI WAHm+Idw0SSWxVptnhhYGiNn3+ZF05vSeGf6Obtpo98Ei0OQb3OCN1J7KgDwRm7paoNM A8Ymgxel5mfgT8+QgWc6ttEIah4+3SXZt7j/mlGpg6iSXUkcOkgzMloblykIfzljO2wo mCgIZSa70VBqLrMbjjKhj/OHrm7hbgC4YcYeIAvnQ/u7+6r/9OGZ2oKOZ8bTE+gDJMHG CCOQ== X-Forwarded-Encrypted: i=1; AJvYcCV8fefg6CbP2ENqiDy2NV/M5PKFsEblmOCOHVBAZRUENZi//q3LnaO8B/tFK8Cl2wT+rJD0Wtfk5sHj4LY=@vger.kernel.org X-Gm-Message-State: AOJu0YxXkn/jG2xcPpmTU16QX0v4DXsPQAVS40+k5jpokpNfK+VV+umn OsA5jqXdCkTEKomgTe6vOe+TWkNeehA2s96cYaQYKO4htmhOQtCXHIXe X-Gm-Gg: ASbGncvR5ozG7UeYip+hG8JX9es/BqZUicuEHbziLudg6q/i5gvUIGUnb+Qr1Qt4t8I N3hjp3vIQNZMr8W/TP+x3emdI7JNq2VxO6g+gOMV6OeGEHT9NmLdNk+EJV/PJfEJ+97ZbNh6Jot gUSP1xOR7P10K0juk3dd+F08jqO1kgXToeXkTvWvTZFHXsgZ2HzfSVTaWc+Hv9wuh5UGylNiExN WI1z1vAnqUuol7h3a5OqTzYhQ/o1VJ889LwSqEEkMwzYlRhFO4JEGvvEpubKLKuN1peWwaX3lp+ F3PLEg1mOLwmaxDK36b6QvA5Cu6OCo0C21nmY1UvGGZg3FxP2YE3gmTNBT7kRTREmbpaIL1Mttx +CNAtVs0mCYhpIR3ch1B2Csa3/fycnnlsxx1sL3QhlIAEoQ3B4To= X-Google-Smtp-Source: AGHT+IFlRrWov5o//lGeMP1IXBjemW48lt8HRdPARmz3fKpiukwPkFA3HSPqzwF9A2FesESVi2k0QA== X-Received: by 2002:a05:620a:710a:b0:7e6:28a9:daf5 with SMTP id af79cd13be357-7e63be3b659mr536419585a.3.1753504450787; Fri, 25 Jul 2025 21:34:10 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.34.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:34:10 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 18/20] staging: rtl8723bs: fix line ending with '(' Date: Sat, 26 Jul 2025 04:32:16 +0000 Message-Id: <20250726043218.386738-19-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fixed a line ending with an opening parenthesis '(' by adjusting formatting to comply with kernel coding style. No functional changes. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index acacc2806dc9..ecb7b3823010 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -1071,8 +1071,7 @@ static void rtw_joinbss_update_network(struct adapter= *padapter, * we use ptarget_wlan->network.phy_info.signal_strength instead (has sca= led) */ padapter->recvpriv.rssi =3D - translate_percentage_to_dbm( - ptarget_wlan->network.phy_info.signal_strength); + translate_percentage_to_dbm(ptarget_wlan->network.phy_info.signal_strengt= h); =20 rtw_set_signal_stat_timer(&padapter->recvpriv); =20 --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 156F720C469 for ; Sat, 26 Jul 2025 04:34:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504456; cv=none; b=nc8lKMwXN7guBAHpMCoEcDxZ+mDAFm+Lr+aKSWiY8oLlcniZWm0o++C3AskhFR0QK9LC9+6wPhnTab1aXOr1KSJboxjL8fwNxPuO2GNXnv7BAj29+tJKgPdzIdwwNiXCuIn0Hy6JZ6+R0uDs8ifMLY1gPm8KA+4n8sqHcIz4S3k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504456; c=relaxed/simple; bh=A9D78ix7GLbEAqRACr7Ln9fr5ydJNxAa+ETZFuRoLY8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QTogfMZpJNi4gcSdQqGwRxh+xEx+gmWiRI1EbIyJpwkK+4moJnjjr62mqMeVby5AAP9v7NSMnaInnrxZ/457mniZdXl+I3X0GeEKlXmL4+tK0eUqgvCGpu7XqZ3L5WCfEd1Xb0q974l8UHgMyfmxhiwGZETbXEd/LXg/1qDMRQ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=atOiWBta; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="atOiWBta" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7e344e0212eso242165985a.0 for ; Fri, 25 Jul 2025 21:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504454; x=1754109254; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E73v83Bn/ceqqEKIqnNpd+kYBPLgkp0XI+V5cR5WrdY=; b=atOiWBtaI1VAESD/nB02wS8rG1K2Ry0Bi7TwZdAtXw2hfYvVx+ZmkULhDatwwD9YFH 4lKSVxm790CHAs6bVBHsdsEclcwD13TPk+wlY0525VY3BSS8amC26nEiPnU0fl/VsQZJ QX8T5kzsdnGHop6nZd0x6ZQKnUM4P6iCSd0svgF7NJnBBXBleCvdfPq2ACnLDylUaut4 bg6IJ1ESUj/JgGzQ5sFabd97swt0njGZsqi/slnbRuaPf37AREA9USuGEim1ir+UvH2P cfyjSGHUxx8nnS10VfGcpXK5ZQf523+GlodayzNoMPoma+DASyB5/tfG+ugENFEGrnWr XXgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504454; x=1754109254; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E73v83Bn/ceqqEKIqnNpd+kYBPLgkp0XI+V5cR5WrdY=; b=bA4DwQbWKzZhrbymNd7UtsbStPpIcm63osJe8GDJ9/h6p0UOGIEYAtQvwg7ScxIivd itUAwbgEWAnGW9cCzZ2q2Nfz+5GX7n+uKWbcN5S7p09o0B8Ha+mWoY11OMF7xBJfxUFK gL5P4ogzxMulmukrXjOWDlvAzAvSK4yZOY7LeHPB8IyNFRI43ZJGxy/ubBZjtMCnE7U5 9GFE6RFd2M3QAf227raVi5ZXW2a40yExUtNT3PpWGf8OY4eDCUdN53vVnEaDJClyFbpC wkSdaNBx26UdLTTTEFJp+5Homkp5REY3ozWLL1UQ5QvNR5xzrh9ipH25X0IrB510By3l tiHA== X-Forwarded-Encrypted: i=1; AJvYcCXMSFDiurp51hUHtsBP4JDWgmyhKxcuSxf6pKj+OdkBXHGETKdN53yGVlFBPb9ZzJ7xOTnkUNoVuYH7z98=@vger.kernel.org X-Gm-Message-State: AOJu0YwKPedrvuAptKfQ6ctOHxQyolmubaAmniVA57MQp367bwYpipVI SirDPfut/SCXjXky78y673TpsU6ng0Gz3g79EBAiU+QZMh1icvNFK4bH6kYg+g== X-Gm-Gg: ASbGnctVjVhh4Ep/Zn0nmbTuYDNVyB/CV4yK5ZXK8F8Gd/VZ3Y1TMAp9ItIH6Xb3gC7 m5rNMZJ6Gbng24ukaVqvK1AkSMcoqJ14WXp5TV7QbxjVhOLhGQCKyUMQ/AWH87v3QoRfUGhgTMh SfZexS6KbtGzbP6hJY2mQk2W0yFtsdJrxyw415jSyq6Ize9foQhiAH76sBt1TgA5NOHHaorji1O fI9OS5tMBvkXg3VMMV3YP6TXyNecCGRz5AaH3nYAwNLN5Ls0aIFDpucQydRMrbwpzBecBnpZxsX TwmS3EINb2+hnnVtc5bZ5O2kXgaBjJMosML2C/7OgY43IC5NqfZEylemtxn8y9Z1rAUBkcIQ8JA nrB7rkmNginMw7chbNpaWnsmOSvrZwFkUzW89va566rNbVmj0+ifCXveoRsMmIg== X-Google-Smtp-Source: AGHT+IHHjE/vicHbTmy5H0DfyQviy6c6NHPxVnv7m9s0aAmGt/gwdfRLBiwM4RPsHvsWk2OBieK+aw== X-Received: by 2002:a05:620a:1905:b0:7e0:e2d7:e03 with SMTP id af79cd13be357-7e63ba6f332mr530200085a.7.1753504453916; Fri, 25 Jul 2025 21:34:13 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:34:13 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 19/20] staging: rtl8723bs: place constant on right side of comparison Date: Sat, 26 Jul 2025 04:32:17 +0000 Message-Id: <20250726043218.386738-20-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Placed constant on right side of comparison in one instance to conform to kernel coding style. No functional changes. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index ecb7b3823010..dbaaa2357ee5 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -746,11 +746,10 @@ void rtw_surveydone_event_callback(struct adapter *ad= apter, u8 *pbuf) } else { if (rtw_to_roam(adapter) !=3D 0) { if (rtw_dec_to_roam(adapter) =3D=3D 0 || - _SUCCESS !=3D rtw_sitesurvey_cmd(adapter, - &pmlmepriv->assoc_ssid, - 1, - NULL, 0) - ) { + rtw_sitesurvey_cmd(adapter, + &pmlmepriv->assoc_ssid, + 1, + NULL, 0) !=3D _SUCCESS) { rtw_set_to_roam(adapter, 0); rtw_free_assoc_resources(adapter, 1); rtw_indicate_disconnect(adapter); --=20 2.39.5 From nobody Mon Oct 6 01:29:04 2025 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4E09223DE9 for ; Sat, 26 Jul 2025 04:34:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504459; cv=none; b=lTmjSpzvZEaIfKm5TYnCM7ChbDyIp4rqzcweGBVLhWvahLMaaLaz/B9NoOhi++LqvE5/gMtm8m/kl4+FN23MI5egyTIyaEQU0MuTqW2RLgBBkaMhpxL8WD4jH+dW0AzESSOLrsmsbDoiRib951lvp3ABIr5x6oyaxnroN9tPI0M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753504459; c=relaxed/simple; bh=d2e+T2yU2a4AET8w22kASfi4lDBNypov0MLe6Ab0DR4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=MN8KMEGwrfRgjYCqhIaPwzlex12xMmZlBgKQlSP6YfR0ATZ4UcwIuIG/Mwm1UCpdXTuLbeKAz039yeh+4fNkemd4NZ6SokUoPs4JzYxWXc4NVCCKj2VYGu+hfi0riPSmbEl8KMIc6LEEnu68ZhxDQtDMp9tfqJ61Fc/VlrY52hs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PJxPqO1A; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PJxPqO1A" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7dfff5327fbso343023885a.1 for ; Fri, 25 Jul 2025 21:34:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753504457; x=1754109257; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GC+5ntkiMYOcg9q9ULRx/adh+E/wjCdGyK8BZoGwft8=; b=PJxPqO1AqsVIkDgc7ysMhK8grDNSbkIOGmmC0Cc3ZXd/cgQE5SLNG4BdyzMY2wF4I+ 4flhjG5x8LmmqLjXHcjdML7H744dzeREjb2y6RBxqK+Ps+VWiZ8VAO2sTTDjgBP65+hw TSX9cPYMkdbK6V0RFWugxot2t1566AhlRJvvs4vD5B8bS1/9nUWXARREX4bzQMeq/ndI litKAZaIo9NncoanAXS6UxgFihe76fGfzH5Aazr6a/D9BY72O/ZLGnkeURerpXnwRFyH hd2EpkJ24WJUpo1WVYXnn4/6iOTgY1Q3943UGQFyJsR0U70fxqhCEl+H+HBXxfjGyxzr 7Ing== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753504457; x=1754109257; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GC+5ntkiMYOcg9q9ULRx/adh+E/wjCdGyK8BZoGwft8=; b=S/jvnTknZLXE96muYt3hBw0pnrp3C+YJEIESveQZDCkH6pWZ10tIDXLkYxCuytQKyM 7dMeoPBl70WN4SjABj4t4U0rAvJ4kqIM2diQ/xYHx0UJ08PO/KalGnm2VoCUMkHcuZqU niPqtzBoE3TdzhfCHWpVGdFCiUHNVsYbCSf752978xiMjQrCyEs7ZdWxLXXJNWUmOkNc Lh7ICq/W3oFOGBEtGkazWMxldsNcg4dYuUBryFzlXYC2AmBBdpjyROYgsz0sp0cOhQIB 98DVFuaVLRbsPk3ENNsrHoRNOprjw8hbhpQFhLVwyBiVKF+7pC+6DA7gdSBQOBJi9bER pKGQ== X-Forwarded-Encrypted: i=1; AJvYcCW9tpaveKYhkdNm/gPFfjkr/B8bsso8/eQ41hUqgzd81L/OyQ7l6LDLbiLxZg/2rfKkNuw0d9DYo7Zok18=@vger.kernel.org X-Gm-Message-State: AOJu0YwDxl9Z/DUnkFbgK29Ti3vNM1elU3U1twLZoCR4YhvzsVMFi9Ye 1egFcD9Y1hXPZQDaPXZz3J1tciyGHWGlqSah1VXnt9JXBwfgDEcWbh5X X-Gm-Gg: ASbGnctmU/GapBuH+pxNF56ZX6qrJ8ahBXa6LhbywpG/b8xebx1F1IMAU1GoZuh48JZ Go0BOtS3ckagBb8f1STE0Vit+UBaZjGL/z+WTtZNps8vWK/xm9iaS/QPcFOIRxEhNLvdgWocL6k 72mR3ic1P0LLY6uqTaubedDYAqMz8mKPMReSEERTlACBrZYn7BLQBB0b5abzRvJ8+a4AAooGiuq pF3TihgIYezV7dP7gEjz3w92FfB93SKURFgh9+/HrjZ3tpPpsWDa9DqH5bxDLtB7Ry5HUgZUR+B H+0bWhvDXGVtS7vfjpF7hs4w3yYPtrIfoZTAqYnzLm3q680NFPN5r/wOT9sIGahSEnEtZOv9UgK 79MzlKnjTN27yrZ4wBOv41DWVNmIpCAr+FkT9GQthy4bhBlcTsjo= X-Google-Smtp-Source: AGHT+IEz2pv6WB1PyFs4FPgWVH3seutfTorp8cVLUTzAsCHl/hXSEJr0qXxLqZTGBIZh+iqHRC8RYg== X-Received: by 2002:a05:620a:2ae9:b0:7e2:c5ff:2078 with SMTP id af79cd13be357-7e63c1c74f7mr477625085a.37.1753504456831; Fri, 25 Jul 2025 21:34:16 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e6432a885asm70322185a.36.2025.07.25.21.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 21:34:16 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH 20/20] staging: rtl8723bs: merge nested if conditions for clarity and tab problems Date: Sat, 26 Jul 2025 04:32:18 +0000 Message-Id: <20250726043218.386738-21-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726043218.386738-1-vivek.balachandhar@gmail.com> References: <20250726043218.386738-1-vivek.balachandhar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Merged nested if conditions for clarity and fixed tab indentation in one place. No functional changes. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index dbaaa2357ee5..7c189a823c00 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -1157,8 +1157,8 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) rtw_free_stainfo(adapter, pcur_sta); =20 ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, pnetwork= ->network.mac_address); - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { - if (ptarget_wlan) + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true && + ptarget_wlan) { ptarget_wlan->fixed =3D true; } } --=20 2.39.5