From nobody Mon Oct 6 03:13:58 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C9C225A620; Fri, 25 Jul 2025 22:08:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753481305; cv=none; b=fMqxJJ/BuTarjg9xHBns68MTX5hPmD9n8cZ9XhvfjgBJPnIyLLSjwc5gHsguPqQicr8IcQ5wG7Z3wxtdnPbL1iWmgiXp0cBk6eHvQ0hfSSaPpWzxELjFK65Q6XTuQX7AHyCXjvE0DGw9IkzsQ2DmxOthzHTu3uij58KAPsSJeXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753481305; c=relaxed/simple; bh=KOj+eyujRFeFtivf7jk0L85lyc1oGzmXW8wKBy4jGDM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=N5L6Bg1VM+angUDQhkOxSvmvY0pHOzyAA7XDBnj5H23s96ArQQiroPSu2er/HkXcXLtJcRodzzxKExYjTuodzJDCl3Ynf05ISy90VZH2Hz7Jp8JQhUvb75uuHB3XKv1eKPIwiJGZt/TKo74OgFXyofJVw4ccYUGnHeCxZJR851M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=jPHjxce3; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="jPHjxce3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1753481301; bh=KOj+eyujRFeFtivf7jk0L85lyc1oGzmXW8wKBy4jGDM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=jPHjxce3npd5xnHdkz3C4QDZTc60arrhq0j9fg+m+fvrOnKcmqbAuo5QbEjc47rn7 LnJcQZtYzodBp0Y435QFOHG/tEWBqn4jzerS8TGXUjyuUnl/Wvt8qP0BBzWqd112n/ lu/YqLPXRwccdUIsjy9XA+tn21n573rhJcR8j5oJzXM8tx7Tn6MH3l58CoOBTB01IJ PUvCxuAbpIV2mLSSOefa1MMazN6vMBdmwMOV+lDacNDM2J+KX2Rcx/Wy12D6rLVmWL 2efbzuUL+43OdnrgVe1WSSkcrCCJwEUasq2m4JfHHsNzB+HyjwzWpu4oC1qE9KckQd c4Qe5/MNxMCCg== Received: from localhost (unknown [82.79.138.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with UTF8SMTPSA id AE2D017E131B; Sat, 26 Jul 2025 00:08:21 +0200 (CEST) From: Cristian Ciocaltea Date: Sat, 26 Jul 2025 01:08:06 +0300 Subject: [PATCH v2 04/18] usb: vhci-hcd: Avoid unnecessary use of braces Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250726-vhci-hcd-suspend-fix-v2-4-189266dfdfaa@collabora.com> References: <20250726-vhci-hcd-suspend-fix-v2-0-189266dfdfaa@collabora.com> In-Reply-To: <20250726-vhci-hcd-suspend-fix-v2-0-189266dfdfaa@collabora.com> To: Valentina Manea , Shuah Khan , Hongren Zheng , Greg Kroah-Hartman , "Brian G. Merrell" Cc: kernel@collabora.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 Improve code readability in vhci_urb_dequeue() by getting rid of a pair of braces and reduce the indentation level of the related code block. Signed-off-by: Cristian Ciocaltea --- drivers/usb/usbip/vhci_hcd.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c index dfdd6ae2cf95c7d5a24d97f713d86588c2dab350..cace9bbbd528602703869cf955f= 93b311fddd045 100644 --- a/drivers/usb/usbip/vhci_hcd.c +++ b/drivers/usb/usbip/vhci_hcd.c @@ -888,6 +888,7 @@ static int vhci_urb_dequeue(struct usb_hcd *hcd, struct= urb *urb, int status) struct vhci_priv *priv; struct vhci_device *vdev; unsigned long flags; + int ret; =20 spin_lock_irqsave(&vhci->lock, flags); =20 @@ -899,14 +900,10 @@ static int vhci_urb_dequeue(struct usb_hcd *hcd, stru= ct urb *urb, int status) return -EIDRM; } =20 - { - int ret =3D 0; - - ret =3D usb_hcd_check_unlink_urb(hcd, urb, status); - if (ret) { - spin_unlock_irqrestore(&vhci->lock, flags); - return ret; - } + ret =3D usb_hcd_check_unlink_urb(hcd, urb, status); + if (ret) { + spin_unlock_irqrestore(&vhci->lock, flags); + return ret; } =20 /* send unlink request here? */ --=20 2.50.0