From nobody Mon Oct 6 03:13:55 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70011270ED7; Fri, 25 Jul 2025 22:08:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753481316; cv=none; b=bqQVNh1QEcM5F+QaBbxKsZcLj+ehleKqpZ+/kVt97aoi1Da4Op4OvjxZd+Tuyq8O5Xk1LtSS/qT3TK/GCGibNUOTQo/4rM8CtrSRB6cx7bU75koZdKXq5u9mnAaCcB+v1pg7wIdmB969QY56Xo4Cv5n3VwHXDi9gPfmiq7Etgu0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753481316; c=relaxed/simple; bh=ow1ljpmkv02H9hsOpbrXGJDs1A/a1CXp5uwQULajhsE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lw2rV/0TE5vjBfhRm6ryj7RcJkLj3m4M2boUsCnwg/BByuNcBLay2u4aS3zSM0sF1SU+CHOjtpgXcUxsIBOaJAYSVM5q/aJ7whGRqk9JzEjQ2/Ld8eDr0xQ4MpOPzVktXyOA2xpsy4ziWjEcphaz0O4bXgxqKwrVtX8adp4UNGw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=bZyF680x; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="bZyF680x" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1753481312; bh=ow1ljpmkv02H9hsOpbrXGJDs1A/a1CXp5uwQULajhsE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=bZyF680x2IUDuJPlQI0q7ZatJ/E7GTnx5ELWQd0hJxdRgSqngA9JCi3gbISX/VAZQ yYrJ23h5UZuSNCGf2ykzM7Vmg3uFBnrsiuPB79V3X3plwp5RDnehZu/DaUYl9/wG+J 2LtF0V8+fGpoBTVqB5f7kO7PxMLYmFQ8+3LY4b0ym0h73/K8XsdKVmY4G0LCbF205U 9REAjHk3y2+OfCgNdBqAbk9h1PPO9iIDtLSASKWc0gJu+o6W8mYjfQ3AqVe7geYSEP wFb6RvKjJtaeTCJKFE/j6CaeEYOE3QUK6FZk8jchvMxrD3E2hPY/p6d9EsrJ0zgOW+ Ub89R9zgqvjrA== Received: from localhost (unknown [82.79.138.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with UTF8SMTPSA id 83A2517E157A; Sat, 26 Jul 2025 00:08:32 +0200 (CEST) From: Cristian Ciocaltea Date: Sat, 26 Jul 2025 01:08:19 +0300 Subject: [PATCH v2 17/18] usb: vhci-hcd: Switch to dev_err_probe() in probe path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250726-vhci-hcd-suspend-fix-v2-17-189266dfdfaa@collabora.com> References: <20250726-vhci-hcd-suspend-fix-v2-0-189266dfdfaa@collabora.com> In-Reply-To: <20250726-vhci-hcd-suspend-fix-v2-0-189266dfdfaa@collabora.com> To: Valentina Manea , Shuah Khan , Hongren Zheng , Greg Kroah-Hartman , "Brian G. Merrell" Cc: kernel@collabora.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 Replace pr_err() calls in vhci_hcd_probe() with dev_err_probe(), to simplify error handling a bit and improve consistency. Signed-off-by: Cristian Ciocaltea --- drivers/usb/usbip/vhci_hcd.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c index 73c5979fee3ce345ea2c212fea03adabde55243a..5d2983a6c2b05d2a769424e1595= b4212a806c2a2 100644 --- a/drivers/usb/usbip/vhci_hcd.c +++ b/drivers/usb/usbip/vhci_hcd.c @@ -1369,10 +1369,8 @@ static int vhci_hcd_probe(struct platform_device *pd= ev) * Our private data is also allocated automatically. */ hcd_hs =3D usb_create_hcd(&vhci_hc_driver, &pdev->dev, dev_name(&pdev->de= v)); - if (!hcd_hs) { - pr_err("create primary hcd failed\n"); - return -ENOMEM; - } + if (!hcd_hs) + return dev_err_probe(&pdev->dev, -ENOMEM, "create primary hcd failed\n"); =20 hcd_hs->has_tt =3D 1; =20 @@ -1381,22 +1379,21 @@ static int vhci_hcd_probe(struct platform_device *p= dev) * Call the driver's reset() and start() routines. */ ret =3D usb_add_hcd(hcd_hs, 0, 0); - if (ret !=3D 0) { - pr_err("usb_add_hcd hs failed %d\n", ret); + if (ret) { + dev_err_probe(&pdev->dev, ret, "usb_add_hcd hs failed\n"); goto put_usb2_hcd; } =20 hcd_ss =3D usb_create_shared_hcd(&vhci_hc_driver, &pdev->dev, dev_name(&pdev->dev), hcd_hs); if (!hcd_ss) { - ret =3D -ENOMEM; - pr_err("create shared hcd failed\n"); + ret =3D dev_err_probe(&pdev->dev, -ENOMEM, "create shared hcd failed\n"); goto remove_usb2_hcd; } =20 ret =3D usb_add_hcd(hcd_ss, 0, 0); if (ret) { - pr_err("usb_add_hcd ss failed %d\n", ret); + dev_err_probe(&pdev->dev, ret, "usb_add_hcd ss failed\n"); goto put_usb3_hcd; } =20 --=20 2.50.0