From nobody Mon Oct 6 03:11:24 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EB6725B2FA for ; Fri, 25 Jul 2025 20:34:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753475659; cv=none; b=btSYtYCQR1MELErdoeTNCVUMyfMuAmI40gnRTvWwD60U10lq6Y5XND/5yZonzUHCCH/IeG8QH0I9apo4uBcDXZVbuMMvN33o9/CEoRXKrgk3VxtTyC/zqnSA19FBuzFmeZmEYLBq8lfpl6XifV0FKtow6tDgS6GHno+VCArfUes= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753475659; c=relaxed/simple; bh=5GJGshMMt43RPwKYyto06JVmYi0YebWLNetCQjz6aKI=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=fEZtBSZKZUOG6wxFWNOryzDIFhT658ZE3snYRYrzB2k21cz6pVjeO460joYyE40B4KiAxlhVnzFmNkdUhb+19GoC9dJ5cfbOzvHL20xTkOa0L6sQcBgNQCY4VHF2SQL8+FukvdCi8KNyouV3021zTQupd9tHiUbApyvZhfFpCu0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jh6oy8pw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jh6oy8pw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D63D6C4CEE7; Fri, 25 Jul 2025 20:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753475658; bh=5GJGshMMt43RPwKYyto06JVmYi0YebWLNetCQjz6aKI=; h=Date:From:To:Cc:Subject:References:From; b=jh6oy8pwsi2obmuoI/NP9nwIkCyjIMA0xr3l/TDAWTJ0KO5R8x0o74qKZUP/q5F8S sHwm4lykbMJho/sh36s0bFI1f4Sk9XrgJT+oDXXH4/ryN3T311Ln8BbyVgjjJ+rx4l PUEibxpORLlyZ0v8agGdIIE/oHK9z2tdWUwaBvJgz2YKjmpCbAh7FkuG4we8SwmTtw /xaBPVAqJt1aUvn1uEUe8nOzoCswTvJrn8MuLZAMI3LoziaExrSfafcQLFfjKXw5b9 2xtweYySTfGB9wiQQPY1SqfjRiar+AXU6Vwaxqpk7MR7H7QlcjYgr0I1RKJnCwFffs vRDQtjG9hvawA== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1ufP7Y-00000001QeK-3sKb; Fri, 25 Jul 2025 16:34:24 -0400 Message-ID: <20250725203424.778464609@kernel.org> User-Agent: quilt/0.68 Date: Fri, 25 Jul 2025 16:34:02 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Tomas Glozar , John Kacur , Masami Hiramatsu , Mathieu Desnoyers , Gabriele Monaco , Nam Cao Subject: [for-next][PATCH 05/25] verification/dot2k: Remove __buff_to_string() References: <20250725203357.087558746@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Nam Cao str.join() can do what __buff_to_string() does. Therefore replace __buff_to_string() to make the scripts more pythonic. Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Link: https://lore.kernel.org/860d6002659f604c743e0f23d5cf3c99ea6a82d8.1751= 634289.git.namcao@linutronix.de Reviewed-by: Gabriele Monaco Signed-off-by: Nam Cao Signed-off-by: Steven Rostedt (Google) --- tools/verification/dot2/dot2k.py | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/tools/verification/dot2/dot2k.py b/tools/verification/dot2/dot= 2k.py index dd4b5528a4f2..0922754454b9 100644 --- a/tools/verification/dot2/dot2k.py +++ b/tools/verification/dot2/dot2k.py @@ -109,15 +109,6 @@ class dot2k(Dot2c): fd.close() return content =20 - def __buff_to_string(self, buff): - string =3D "" - - for line in buff: - string =3D string + line + "\n" - - # cut off the last \n - return string[:-1] - def fill_monitor_type(self): return self.monitor_type.upper() =20 @@ -148,19 +139,19 @@ class dot2k(Dot2c): buff.append("\tda_%s_%s(%s%s);" % (handle, self.name, even= t, self.enum_suffix)); buff.append("}") buff.append("") - return self.__buff_to_string(buff) + return '\n'.join(buff) =20 def fill_tracepoint_attach_probe(self): buff =3D [] for event in self.events: buff.append("\trv_attach_trace_probe(\"%s\", /* XXX: tracepoin= t */, handle_%s);" % (self.name, event)) - return self.__buff_to_string(buff) + return '\n'.join(buff) =20 def fill_tracepoint_detach_helper(self): buff =3D [] for event in self.events: buff.append("\trv_detach_trace_probe(\"%s\", /* XXX: tracepoin= t */, handle_%s);" % (self.name, event)) - return self.__buff_to_string(buff) + return '\n'.join(buff) =20 def fill_main_c(self): main_c =3D self.main_c @@ -210,7 +201,7 @@ class dot2k(Dot2c): buff =3D self.fill_model_h_header() buff +=3D self.format_model() =20 - return self.__buff_to_string(buff) + return '\n'.join(buff) =20 def fill_monitor_class_type(self): if self.monitor_type =3D=3D "per_task": @@ -242,7 +233,7 @@ class dot2k(Dot2c): tp_args_c =3D ", ".join([b for a,b in tp_args]) buff.append(" TP_PROTO(%s)," % tp_proto_c) buff.append(" TP_ARGS(%s)" % tp_args_c) - return self.__buff_to_string(buff) + return '\n'.join(buff) =20 def fill_monitor_deps(self): buff =3D [] @@ -250,7 +241,7 @@ class dot2k(Dot2c): if self.parent: buff.append(" depends on RV_MON_%s" % self.parent.upper()) buff.append(" default y") - return self.__buff_to_string(buff) + return '\n'.join(buff) =20 def fill_trace_h(self): trace_h =3D self.trace_h --=20 2.47.2