From nobody Mon Oct 6 03:11:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 197CC2EF66B; Fri, 25 Jul 2025 17:14:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753463655; cv=none; b=npZuVUtejpZYPY4S4OE/l3O2qAOl1M5KgcENVSj+CJAlJnB/XzWgRVWy9fKcwYdWTJcD9X3qeYOZrWKv8lNWiq9LQqTyYNfgSuATCluCD8XqqiLVWQe4tzV8UqeobQhREshMOryiC9dVHKPG8VfSvitsOrtEYpFVWrg0OpTDrWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753463655; c=relaxed/simple; bh=96RWDqAwsQ+BNNMMv40laI84yj5UkISKimL0LLvCq9U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BXNr84fBEPaxvAVChoYjqMkW+apNHdxkcWeZ1fUYPkVMksYPvntDsW8WMvciq/g2y0sKP7x1HcnnC6+tZaUgDX8OF4qVI8nsThbR/2gHaMdBzrhSLM9DCU7cnJgpEbDJuI2OwwUn62G7+dHAsvmau3S+n5kwYij7T3ATR1EsG90= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YIO8TXGe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YIO8TXGe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9B2AC4CEF9; Fri, 25 Jul 2025 17:14:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753463654; bh=96RWDqAwsQ+BNNMMv40laI84yj5UkISKimL0LLvCq9U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YIO8TXGe6al3/A2gMYESXZ67JW/eECXSwJ+fJR1BE6I8/xhxqbJaiwexsEKJvh2wb YOs4Laf2/rwRTcV8Prp6A24/J5KPrMwrOCH+elBTuwm0EcXrffvHZLZnDrRSgCy9rt clqLWgyn6Fe91EFC3uOf8p6ge5VbGmivvBqpXWQjJM8fr7wrb7u0lf6U2zvoF3nFjx B17R4ANRP6qqyrq1OJeua5hpqM8ShV+LtlI4zP8TKetqAf+y7FFgJVlzvCdxkPWDEe QltpyNhfiGF0gIpSeeWLoEL84HygEaUjwA2duTcc2/5mXmxtQDobdOI1zYFUZLUdo+ jvRYqHKbZsIzg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1ufLzn-000000000Gj-2DbO; Fri, 25 Jul 2025 19:14:11 +0200 From: Johan Hovold To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Madalin Bucur , Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , Felix Fietkau , Sean Wang , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , MD Danish Anwar , Roger Quadros , Richard Cochran , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Yangbo Lu Subject: [PATCH 1/5] net: dpaa: fix device leak when querying time stamp info Date: Fri, 25 Jul 2025 19:12:09 +0200 Message-ID: <20250725171213.880-2-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20250725171213.880-1-johan@kernel.org> References: <20250725171213.880-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference to the ptp device taken by of_find_device_by_node() when querying the time stamping capabilities. Note that holding a reference to the ptp device does not prevent its driver data from going away. Fixes: 17ae0b0ee9db ("dpaa_eth: add the get_ts_info interface for ethtool") Cc: stable@vger.kernel.org # 4.19 Cc: Yangbo Lu Signed-off-by: Johan Hovold Reviewed-by: Simon Horman --- drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c b/drivers/n= et/ethernet/freescale/dpaa/dpaa_ethtool.c index 9986f6e1f587..7fc01baef280 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c @@ -401,8 +401,10 @@ static int dpaa_get_ts_info(struct net_device *net_dev, of_node_put(ptp_node); } =20 - if (ptp_dev) + if (ptp_dev) { ptp =3D platform_get_drvdata(ptp_dev); + put_device(&ptp_dev->dev); + } =20 if (ptp) info->phc_index =3D ptp->phc_index; --=20 2.49.1 From nobody Mon Oct 6 03:11:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 196A12EE975; Fri, 25 Jul 2025 17:14:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753463655; cv=none; b=TiB4axhzzGA4XZkbk1wZ54byCUj4OD9APXQquKzjGWtbz0+CYVSkQev3jUGeApDkSqcC653RROOKHvBqSDIZl2W62CcKYcuoMe25O5HEtiu6M1SzJcOBYBC5Shfx2xGvgktzd914BEWT5P/zLC92BjanohRSLaxZCyR7W7JNhGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753463655; c=relaxed/simple; bh=DPOgPYviBfB+YHd/zP7d5WCcSDdGAgNwqCv1/XcAoio=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NigIXZtPGx+CGhrWPS5h6O9VsfcFDoEiUk9TKnI6kpvZJuWifm6pgn5BvVJO7nBokW2ugCetMHpRbS9uduDiKtTvhmwF51/u/a0iVSPeaGGjCNgmDdNimTwVuihwzpMrxjyoJseQEm0ctrfwIpM5vi4LISpMBSTwFUcZdsh7Iao= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HbaaHGfw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HbaaHGfw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A708EC4CEF4; Fri, 25 Jul 2025 17:14:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753463654; bh=DPOgPYviBfB+YHd/zP7d5WCcSDdGAgNwqCv1/XcAoio=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HbaaHGfwuUvzJ4UU3mc0H4B8VA77NIWevPWiNxidyDvyB+KE8ttALvA+Xl1nJRy7V 0hsiJAQhF+fKqRLiHP1K73YCiXd8+Od30h1tASREUj0vd50oZIV2be/a/9b0K/DW5M xm8G5oyTGxM++J8QhdjeSL0X3reRfHM1xEWoKE58ZkGxtbrLDrE05uDI9kpFeTTVYP 0ykmWRoP1yat8vdEBsVy2wXw3qjlRRNBWGF12i5eEK8aMQI642zJs3g+JzzUJ6Xv/i bkDITaAmmP5gJjs8deYXzhzyy2ljpbR8VA9jncXfZ8kFQpK7VcveWX7/qf/sTpJkKr xxxKqpwpmxT/A== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1ufLzn-000000000Gl-2XgC; Fri, 25 Jul 2025 19:14:11 +0200 From: Johan Hovold To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Madalin Bucur , Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , Felix Fietkau , Sean Wang , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , MD Danish Anwar , Roger Quadros , Richard Cochran , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 2/5] net: enetc: fix device and OF node leak at probe Date: Fri, 25 Jul 2025 19:12:10 +0200 Message-ID: <20250725171213.880-3-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20250725171213.880-1-johan@kernel.org> References: <20250725171213.880-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the references to the IERB OF node and platform device taken by of_parse_phandle() and of_find_device_by_node() during probe. Fixes: e7d48e5fbf30 ("net: enetc: add a mini driver for the Integrated Endp= oint Register Block") Cc: stable@vger.kernel.org # 5.13 Cc: Vladimir Oltean Signed-off-by: Johan Hovold Reviewed-by: Simon Horman --- drivers/net/ethernet/freescale/enetc/enetc_pf.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pf.c b/drivers/net/= ethernet/freescale/enetc/enetc_pf.c index f63a29e2e031..de0fb272c847 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_pf.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_pf.c @@ -829,19 +829,29 @@ static int enetc_pf_register_with_ierb(struct pci_dev= *pdev) { struct platform_device *ierb_pdev; struct device_node *ierb_node; + int ret; =20 ierb_node =3D of_find_compatible_node(NULL, NULL, "fsl,ls1028a-enetc-ierb"); - if (!ierb_node || !of_device_is_available(ierb_node)) + if (!ierb_node) return -ENODEV; =20 + if (!of_device_is_available(ierb_node)) { + of_node_put(ierb_node); + return -ENODEV; + } + ierb_pdev =3D of_find_device_by_node(ierb_node); of_node_put(ierb_node); =20 if (!ierb_pdev) return -EPROBE_DEFER; =20 - return enetc_ierb_register_pf(ierb_pdev, pdev); + ret =3D enetc_ierb_register_pf(ierb_pdev, pdev); + + put_device(&ierb_pdev->dev); + + return ret; } =20 static const struct enetc_si_ops enetc_psi_ops =3D { --=20 2.49.1 From nobody Mon Oct 6 03:11:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C25E2EF66C; Fri, 25 Jul 2025 17:14:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753463655; cv=none; b=mFAe55OI+2uPwkYKNctL8def0hM60OIbs+ciPGy58ewj/ixaVA01ljB2mrsfoTukHs2AoA4gwxP3b9nrJgSUgsKEqeaSAT7IftgX2A4yDNJVVDubGKxDOPNgyEhjOus4eXHylSVp9ry2OMPi0X/QKA0kHVdRGkdcK89cXAA/rTk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753463655; c=relaxed/simple; bh=gWZO1ES2r3jh5Yq67JXLsbmiESc165KttdqT3NHuvcw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MshE3zUfl5wC318sBIjr0da3vmTw3oUh3TxudyY8nRdyOnT6cI9sI1e+ZIDBBRiu0NLLexi56Dg0iq/e9w+/VgZMkkNOGCIDm+BRvJUVBn13DOx/Ow+w8B/S04CWJbRTJuJBApg/yrzH9/M+7VJCjQRSZU2yZZDmuhOmUoQlFFU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Hl1wDLS4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hl1wDLS4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC3B4C4CEFA; Fri, 25 Jul 2025 17:14:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753463654; bh=gWZO1ES2r3jh5Yq67JXLsbmiESc165KttdqT3NHuvcw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hl1wDLS4RHtasJPd9cADa4JxDlrhcvWQECdErTzeMhnBp1xwsq+q13wvPJxhoc2kz FN2URXemjnzNNmSAaGch5rdbzvWVbTuSzwqjge66PPZV4BmN8eYzzfS/+jrN7W1fk/ 3K3gME7exeOcgJ9z1cQ259SYUbt+Eu0wV4i1675vo9wUCg9LjgykI0v64PZ9CbY+FQ uGYhJbAQIksIkkGOArt7BWRWLReAr7W38T8C20KMcN/scav9OXVe7Rw18ItnxykKPV Aq/usys1+lcgIM1sWxyLazT0OFKkxqrpIS+yVQRQ8zK9t5kW+BVDWQrfEcx9PN793a 2grxKjo+vLG6w== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1ufLzn-000000000Gn-2s8N; Fri, 25 Jul 2025 19:14:11 +0200 From: Johan Hovold To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Madalin Bucur , Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , Felix Fietkau , Sean Wang , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , MD Danish Anwar , Roger Quadros , Richard Cochran , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Yangbo Lu Subject: [PATCH 3/5] net: gianfar: fix device leak when querying time stamp info Date: Fri, 25 Jul 2025 19:12:11 +0200 Message-ID: <20250725171213.880-4-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20250725171213.880-1-johan@kernel.org> References: <20250725171213.880-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference to the ptp device taken by of_find_device_by_node() when querying the time stamping capabilities. Note that holding a reference to the ptp device does not prevent its driver data from going away. Fixes: 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through= drvdata") Cc: stable@vger.kernel.org # 4.18 Cc: Yangbo Lu Signed-off-by: Johan Hovold Reviewed-by: Simon Horman --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net= /ethernet/freescale/gianfar_ethtool.c index 781d92e703cb..c9992ed4e301 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c @@ -1466,8 +1466,10 @@ static int gfar_get_ts_info(struct net_device *dev, if (ptp_node) { ptp_dev =3D of_find_device_by_node(ptp_node); of_node_put(ptp_node); - if (ptp_dev) + if (ptp_dev) { ptp =3D platform_get_drvdata(ptp_dev); + put_device(&ptp_dev->dev); + } } =20 if (ptp) --=20 2.49.1 From nobody Mon Oct 6 03:11:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EA9C7080D; Fri, 25 Jul 2025 17:14:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753463655; cv=none; b=ZiahcCQnVDP1oKwEEgT/e+9nKmEaAAlAOTMpmlwOVYtOURfVVV3q/bXXHtMxSCESC8FbBCk3vpFmY0Gsr+ag2oeI/3QTRCRUFbAAnzDkSJWAMDq0vFoPpFg0jMB3Mdqe9USAL1HT2uA9bYcBVe43FmV/ROJXBsN3oSsVTuGEVHc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753463655; c=relaxed/simple; bh=kqBmJJq9ufFHOESJhsjd3Onyd4cgOnDcJ4k/ti6hGV4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eHwdk6RdMCxncvy1FJtV7X5FDXotioJa9Xnx0XcEodVBNFsnpCxfmDwrhH0NPgQCbTh6xPltZV6H3tAJEbtv/UqjCT0F4YmOw2SvzdbmLxiATDvGbNq4w08t/SmMHYREiXE0Lw0hrX80WoIT43d16/geNkA/n9iVN2B3WYHRoGo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mZhoVzmj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mZhoVzmj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD2B4C4CEFB; Fri, 25 Jul 2025 17:14:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753463654; bh=kqBmJJq9ufFHOESJhsjd3Onyd4cgOnDcJ4k/ti6hGV4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mZhoVzmjTGSEG/8V6D2+TCofzITuvz4FXYSXvQpgd/INthke20gvu8WcB9wS2Njbq kYfrrq1G9XI+6f7vtzrfHumnzdCzR6pbNmZsiC5yr+hBKVb01QuqoLCjSwOEKkc5Id tLFFM9rWCj5WvNG0yELdSU2OLdHskwAYGeHssw2VRJZYum4kWIZgwKatgIhgw8zzqf /3ozk8CwEF7js2p2JtIaafdrBM9RXNkkMUsOETxXFEcKhfDYBss/1cORcvMfbh5Avj aGtgFCKJP5DTGGJnWgvmzDJuF+YKFQXZlIeL91qvZrd3GhK9u5w3/wDxpw8BuJm42H Ii4e3/GOR1u5g== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1ufLzn-000000000Gp-3CXB; Fri, 25 Jul 2025 19:14:11 +0200 From: Johan Hovold To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Madalin Bucur , Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , Felix Fietkau , Sean Wang , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , MD Danish Anwar , Roger Quadros , Richard Cochran , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 4/5] net: mtk_eth_soc: fix device leak at probe Date: Fri, 25 Jul 2025 19:12:12 +0200 Message-ID: <20250725171213.880-5-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20250725171213.880-1-johan@kernel.org> References: <20250725171213.880-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The reference count to the WED devices has already been incremented when looking them up using of_find_device_by_node() so drop the bogus additional reference taken during probe. Fixes: 804775dfc288 ("net: ethernet: mtk_eth_soc: add support for Wireless = Ethernet Dispatch (WED)") Cc: stable@vger.kernel.org # 5.19 Cc: Felix Fietkau Signed-off-by: Johan Hovold Reviewed-by: Simon Horman --- drivers/net/ethernet/mediatek/mtk_wed.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mediatek/mtk_wed.c b/drivers/net/ethernet= /mediatek/mtk_wed.c index 351dd152f4f3..4f3014fc389b 100644 --- a/drivers/net/ethernet/mediatek/mtk_wed.c +++ b/drivers/net/ethernet/mediatek/mtk_wed.c @@ -2794,7 +2794,6 @@ void mtk_wed_add_hw(struct device_node *np, struct mt= k_eth *eth, if (!pdev) goto err_of_node_put; =20 - get_device(&pdev->dev); irq =3D platform_get_irq(pdev, 0); if (irq < 0) goto err_put_device; --=20 2.49.1 From nobody Mon Oct 6 03:11:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FE852EF9A9; Fri, 25 Jul 2025 17:14:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753463655; cv=none; b=I+kounJ2ruUlIxbQP0C+0yfR4AgSeB9eKfa2ngEUqSjjZuzL8HQoe6acGOyBM2nkjzL5Rrr08HHbF90NiMu/kun2uMWyvL1wrlkY2zxLiddfNpxce38b8WVdlx3LNZVuy9YG8ho4btOEQHL3OJf9FGXVmgkgIRFcz4dBYhFaELY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753463655; c=relaxed/simple; bh=cCDHT3cnmuazKqCtjc+IW2jQ2SASLoMsrlCNSn0tgww=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CFUf089swU8E9y/XADVzGdsehAWlFLvRTnddwVN4rvlwcppv27FNNGXG800j7LtC3BqA7/FETvL0NA5DT+xgTSY07CrBjR7Fy8z58FXO8mt61C9kTTJhIj6R7sCN3hyWUWXXmRIr2Rrap2Ls8R6ZzxFmGG7+qul3MYdoCpJpwBE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kIrc1znd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kIrc1znd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04235C19421; Fri, 25 Jul 2025 17:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753463655; bh=cCDHT3cnmuazKqCtjc+IW2jQ2SASLoMsrlCNSn0tgww=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kIrc1zndoSUNRw7WQ5z4QlFcTrhfDr6rsT9Gla7l61iov06QI+H/BesipknkgOFmw 3t6wvTmqzgfo2RdUvbKbJfIGXxq/DaCRJL+QAPjkSuHdVXChcY6AkvBIq5CJ2sxPmM J3qbDPMz8qwSp7NRxZ0gnFCUSZnB2KuJDTywUz9ZNSLmMeZfxL2niG/I5nPQI6pKsG lTBjMSmBtG20FhhX4/AiPUqD3+TO2BBA+xwBSCk7N+sszjAVlJudcjaobIaHsWvPVY kzZOD+fRde/w+P5zO7hdqeJSuMiqmDvb4Y06xBoVFZ6GM7xBYCc5bjn9z56AFpgXm8 VpPSGSAmqYWfw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1ufLzn-000000000Gr-3csz; Fri, 25 Jul 2025 19:14:11 +0200 From: Johan Hovold To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Madalin Bucur , Claudiu Manoil , Vladimir Oltean , Wei Fang , Clark Wang , Felix Fietkau , Sean Wang , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , MD Danish Anwar , Roger Quadros , Richard Cochran , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 5/5] net: ti: icss-iep: fix device and OF node leaks at probe Date: Fri, 25 Jul 2025 19:12:13 +0200 Message-ID: <20250725171213.880-6-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20250725171213.880-1-johan@kernel.org> References: <20250725171213.880-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the references to the IEP OF node and device taken by of_parse_phandle() and of_find_device_by_node() when looking up IEP devices during probe. Drop the bogus additional reference taken on successful lookup so that the device is released correctly by icss_iep_put(). Fixes: c1e0230eeaab ("net: ti: icss-iep: Add IEP driver") Cc: stable@vger.kernel.org # 6.6 Cc: Roger Quadros Signed-off-by: Johan Hovold Reviewed-by: Simon Horman --- drivers/net/ethernet/ti/icssg/icss_iep.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/ti/icssg/icss_iep.c b/drivers/net/etherne= t/ti/icssg/icss_iep.c index 2a1c43316f46..50bfbc2779e4 100644 --- a/drivers/net/ethernet/ti/icssg/icss_iep.c +++ b/drivers/net/ethernet/ti/icssg/icss_iep.c @@ -685,11 +685,17 @@ struct icss_iep *icss_iep_get_idx(struct device_node = *np, int idx) struct platform_device *pdev; struct device_node *iep_np; struct icss_iep *iep; + int ret; =20 iep_np =3D of_parse_phandle(np, "ti,iep", idx); - if (!iep_np || !of_device_is_available(iep_np)) + if (!iep_np) return ERR_PTR(-ENODEV); =20 + if (!of_device_is_available(iep_np)) { + of_node_put(iep_np); + return ERR_PTR(-ENODEV); + } + pdev =3D of_find_device_by_node(iep_np); of_node_put(iep_np); =20 @@ -698,21 +704,28 @@ struct icss_iep *icss_iep_get_idx(struct device_node = *np, int idx) return ERR_PTR(-EPROBE_DEFER); =20 iep =3D platform_get_drvdata(pdev); - if (!iep) - return ERR_PTR(-EPROBE_DEFER); + if (!iep) { + ret =3D -EPROBE_DEFER; + goto err_put_pdev; + } =20 device_lock(iep->dev); if (iep->client_np) { device_unlock(iep->dev); dev_err(iep->dev, "IEP is already acquired by %s", iep->client_np->name); - return ERR_PTR(-EBUSY); + ret =3D -EBUSY; + goto err_put_pdev; } iep->client_np =3D np; device_unlock(iep->dev); - get_device(iep->dev); =20 return iep; + +err_put_pdev: + put_device(&pdev->dev); + + return ERR_PTR(ret); } EXPORT_SYMBOL_GPL(icss_iep_get_idx); =20 --=20 2.49.1