From nobody Mon Oct 6 03:11:23 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 876F92EACEA for ; Fri, 25 Jul 2025 12:42:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447325; cv=none; b=CJE4fcsFlf/gj/1g91m1203H0MvhhybHE3SKcF5xk03petOKq8MUp9wlm7woiRFV8HvD+gk7o4zZtm36qk3ruGpquS/VXSzNKNCIYfCqY3G2wgTknRTlLZW1YdkunS1Mk/Wu5LMETyUIAENDLiz/ynIkQYF6PKJ58DMgFceT1zs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447325; c=relaxed/simple; bh=/UtvtbF9UQFZcvkqoMh5MWKWlr2aj76x1NrMv7B8wx8=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=Xh/D+KHWAIsFnwOeV3572dKSfZ0QM/qvtrzxuVjWMikWg5ogNSYTAeTpszvtVC+IAxSCoy3fhdeAvg3zmYT+FMvnBZ4IdkzlHPPU4LR5tsA/JvnaVdzOS4qft0x1+zTrCTU+u+lA9kBWShCCP5dc/yHNbASNdlKDdfaTh78w7Tg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GCJELA8v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GCJELA8v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37E90C4CEEB; Fri, 25 Jul 2025 12:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753447325; bh=/UtvtbF9UQFZcvkqoMh5MWKWlr2aj76x1NrMv7B8wx8=; h=Date:From:To:Cc:Subject:References:From; b=GCJELA8vw3Dn/nzF+A2qGsqYER8QRLBvUtv7TeYXYOJYIN/faoQ2+Wz2X2DHAjpq+ ub3wJK34rwhW+PG9WP2aTgr3CavrW/aZF80AQPeuLOtwdOBv0PrNoejno9D1+erC2b Dmmn9+qj+ACURW2sKxL+0VdYymQ/bJvByawt1PVW/P+ioBatQEonYgHFUxqkrSOir7 b9VLuPorYF3cyo8HYkGrCVLWRaqPQXx03WW6b3Opyt9g4Z2qUQWf1D2MsDH6PjFljH FToCABl5KEDtawmijD3A6WvWnxSIlZ7jUWE1wFO8lj72Kwo9ipZV03lI2DgBPyxY10 JfTY7m8Jn+j2g== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1ufHkY-00000001Csx-2RrK; Fri, 25 Jul 2025 08:42:10 -0400 Message-ID: <20250725124210.435086464@kernel.org> User-Agent: quilt/0.68 Date: Fri, 25 Jul 2025 08:41:46 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Tony Luck , "Borislav Petkov (AMD)" Subject: [for-next][PATCH 1/9] tracing, AER: Hide PCIe AER event when PCIEAER is not configured References: <20250725124145.391996103@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The event aer_event is only used when CONFIG_PCIEAER is configured. It should not be created when it is not. When an event is created it creates around 5K of text and meta data regardless if the tracepoint is used or not. Instead of wasting this memory, put #ifdef around the event to not create it when it is not used. Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Cc: Tony Luck Link: https://lore.kernel.org/20250612094932.4a08abd6@batman.local.home Acked-by: Borislav Petkov (AMD) Signed-off-by: Steven Rostedt (Google) --- include/ras/ras_event.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/ras/ras_event.h b/include/ras/ras_event.h index 14c9f943d53f..c8cd0f00c845 100644 --- a/include/ras/ras_event.h +++ b/include/ras/ras_event.h @@ -252,6 +252,7 @@ TRACE_EVENT(non_standard_event, __print_hex(__get_dynamic_array(buf), __entry->len)) ); =20 +#ifdef CONFIG_PCIEAER /* * PCIe AER Trace event * @@ -337,6 +338,7 @@ TRACE_EVENT(aer_event, __print_array(__entry->tlp_header, PCIE_STD_MAX_TLP_HEADERLOG, 4) : "Not available") ); +#endif /* CONFIG_PCIEAER */ =20 /* * memory-failure recovery action result event --=20 2.47.2 From nobody Mon Oct 6 03:11:23 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF2392EBBB8 for ; Fri, 25 Jul 2025 12:42:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447325; cv=none; b=Y4FRCIjmQKuITBbZR0q9P3LQQSILVb6cZi21D41j8i5FNMZahKnD0YJkyq25loRM0ImfBGZ2ELBX7jRJGCFDRUCKn/Hgg7bVyyvl5Ec7lQxb8JVaOQdbfAdFhzPlcZWILroVjegeGp9Rk8haO8X+yLlRc17NivXzkAWVzBtcMVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447325; c=relaxed/simple; bh=mNUerDeWMDwuhNTWsVCTdRAnuIxvoe1URQ/NvdL0ibM=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=cSBVWL+VBf45L8REsfdN5xF3BmPIPZDfhVwSFJq/3ftwIYzV/ABqJYv0bsL+/l31PVDmYbY+siJJ/Xn+mOqtU0lg+FZpQsStqD5lCTGcJqQJagtEmVbqN0wJ+1ErL1krSk0lZtyZSApCTCtCkTk7ev1rPvcrxJT+GbiW/wD100w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QquobEAr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QquobEAr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E9C7C4CEF6; Fri, 25 Jul 2025 12:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753447325; bh=mNUerDeWMDwuhNTWsVCTdRAnuIxvoe1URQ/NvdL0ibM=; h=Date:From:To:Cc:Subject:References:From; b=QquobEArlq7Hg6aWcmobTEsqeLMD9GiqB3Ppuna/p/MNzJEaLcyX+Oc4+uuM8JGQ9 oXPWLPBWF+nCQEQsbvLmSc3/daR6Wp+nsZGZZKXMCUBf22n9LMcLnXwUAO3DrwFNm9 H+FjKuDXrxSll0LaIGKvpye1tq0uAVu0jl+lNdEJ6CfO/MtQkb1s/p8up8wKDYSGmU osFTRn0T7db2CWtgrhKFCv+/++vO32XgUZECCibf424IQwVgyyQ62oCz5vatZpJzUi tAu6zphQC9r+8vBfLK4dnBIijonvAN2vsHskiOex6so4IQqU5P93xUiwBxH2qbDlcn 75ZkPd91pvxKQ== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1ufHkY-00000001CtR-38WD; Fri, 25 Jul 2025 08:42:10 -0400 Message-ID: <20250725124210.604811699@kernel.org> User-Agent: quilt/0.68 Date: Fri, 25 Jul 2025 08:41:47 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Peter Zijlstra , Thomas Gleixner Subject: [for-next][PATCH 2/9] alarmtimer: Hide alarmtimer_suspend event when RTC_CLASS is not configured References: <20250725124145.391996103@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The trace event alarmtimer_suspend is only called when RTC_CLASS is defined. As every event created can create up to 5K of text and meta data regardless if it is called or not it should not be created and waste memory. Hide the event when CONFIG_RTC_CLASS is not defined. Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Cc: Peter Zijlstra Link: https://lore.kernel.org/20250612095828.6d75dfa3@batman.local.home Acked-by: Thomas Gleixner Signed-off-by: Steven Rostedt (Google) --- include/trace/events/alarmtimer.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/trace/events/alarmtimer.h b/include/trace/events/alarm= timer.h index 13483c7ca70b..8e9c76a7f21b 100644 --- a/include/trace/events/alarmtimer.h +++ b/include/trace/events/alarmtimer.h @@ -20,6 +20,7 @@ TRACE_DEFINE_ENUM(ALARM_BOOTTIME_FREEZER); { 1 << ALARM_REALTIME_FREEZER, "REALTIME Freezer" }, \ { 1 << ALARM_BOOTTIME_FREEZER, "BOOTTIME Freezer" }) =20 +#ifdef CONFIG_RTC_CLASS TRACE_EVENT(alarmtimer_suspend, =20 TP_PROTO(ktime_t expires, int flag), @@ -41,6 +42,7 @@ TRACE_EVENT(alarmtimer_suspend, __entry->expires ) ); +#endif /* CONFIG_RTC_CLASS */ =20 DECLARE_EVENT_CLASS(alarm_class, =20 --=20 2.47.2 From nobody Mon Oct 6 03:11:23 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D4272EBDD5 for ; Fri, 25 Jul 2025 12:42:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447326; cv=none; b=U0rfs7x4QjOcSM0xRF6k2ShrML/I9orSnUF7zt0qDx41kV6EE1ZxFAL6L/79l3xj2bzpncj29WvRajeY0K4v+DZvkNRYu4kAjUf1025Glg3Qhw2I5LPrW0O26nCHPOqLKPY4LPux4MSi/0K8pxV7bRnfbSvtoKAMjXozcebc9TI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447326; c=relaxed/simple; bh=wwD8akdN0/QOyuYxcJgvFCWsfpE9mN9oy+phuLPb93o=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=jYqOeGNAbown4yUjHpsUYGNKCWlYU+I9RyE4Ymi6PYQ1/W+NngXDf/t1QtsMMcE+YiOL6JtPs9ktGC17zAjERT9yN1yKrkeBkQksLechdpVaHEFbZwBbfT5NLBOvuTtfmZRMCvfPXGfLR9dDQUu4pLOLLUkQn7diazMlV+XeKGo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NFZEylB2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NFZEylB2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3A70C4CEF5; Fri, 25 Jul 2025 12:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753447325; bh=wwD8akdN0/QOyuYxcJgvFCWsfpE9mN9oy+phuLPb93o=; h=Date:From:To:Cc:Subject:References:From; b=NFZEylB2dPE//bgWVNgRTNm3Q4d49nTKo2uHPY9LuJ+6Xg5GerRiefWSihtds976F RqmwJvMc+a5V23Yg2BjuML8Ul6zjdf7/2dFXJ3JZdtWsmLMZ21cnKbc7Lkitihc0AA fS3eapgXzIELrCSFPF07xAaRIyaPVkp/RSSTHGTgm3Bc40oUQAxXsCxAu3nyAYd6S0 xsLUlyeoseTuGC0QMZlLEMVAbI4w0YaJJwXyRaqNM8D6eT6TpDyyGXWuYDo/ip+3VK kKK9BQtobJxJr3FOXfpEcuae7K7Bc07Rh4b2VPdV9KeZN9/fd0hs7JPxwK7MdTLE9a GqLMh3XacmThg== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1ufHkY-00000001Ctv-3q8M; Fri, 25 Jul 2025 08:42:10 -0400 Message-ID: <20250725124210.768285913@kernel.org> User-Agent: quilt/0.68 Date: Fri, 25 Jul 2025 08:41:48 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Madhavan Srinivasan , Michael Ellerman , Viresh Kumar , "Rafael J. Wysocki" Subject: [for-next][PATCH 3/9] PM: cpufreq: powernv/tracing: Move powernv_throttle trace event References: <20250725124145.391996103@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt As the trace event powernv_throttle is only used by the powernv code, move it to a separate include file and have that code directly enable it. Trace events can take up around 5K of memory when they are defined regardless if they are used or not. It wastes memory to have them defined in configurations where the tracepoint is not used. Cc: Masami Hiramatsu Cc: Mark Rutland Cc: Mathieu Desnoyers Cc: Andrew Morton Cc: Madhavan Srinivasan Cc: Michael Ellerman Link: https://lore.kernel.org/20250612145407.906308844@goodmis.org Fixes: 0306e481d479a ("cpufreq: powernv/tracing: Add powernv_throttle trace= point") Acked-by: Viresh Kumar Acked-by: Rafael J. Wysocki Signed-off-by: Steven Rostedt (Google) --- drivers/cpufreq/Makefile | 1 + drivers/cpufreq/powernv-cpufreq.c | 4 ++- drivers/cpufreq/powernv-trace.h | 44 +++++++++++++++++++++++++++++++ include/trace/events/power.h | 22 ---------------- kernel/trace/power-traces.c | 1 - 5 files changed, 48 insertions(+), 24 deletions(-) create mode 100644 drivers/cpufreq/powernv-trace.h diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile index d38526b8e063..681d687b5a18 100644 --- a/drivers/cpufreq/Makefile +++ b/drivers/cpufreq/Makefile @@ -21,6 +21,7 @@ obj-$(CONFIG_CPUFREQ_VIRT) +=3D virtual-cpufreq.o =20 # Traces CFLAGS_amd-pstate-trace.o :=3D -I$(src) +CFLAGS_powernv-cpufreq.o :=3D -I$(src) amd_pstate-y :=3D amd-pstate.o amd-pstate-trace.o =20 ##########################################################################= ######## diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cp= ufreq.c index a8943e2a93be..7d9a5f656de8 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -21,7 +21,6 @@ #include #include #include -#include =20 #include #include @@ -30,6 +29,9 @@ #include #include =20 +#define CREATE_TRACE_POINTS +#include "powernv-trace.h" + #define POWERNV_MAX_PSTATES_ORDER 8 #define POWERNV_MAX_PSTATES (1UL << (POWERNV_MAX_PSTATES_ORDER)) #define PMSR_PSAFE_ENABLE (1UL << 30) diff --git a/drivers/cpufreq/powernv-trace.h b/drivers/cpufreq/powernv-trac= e.h new file mode 100644 index 000000000000..8cadb7c9427b --- /dev/null +++ b/drivers/cpufreq/powernv-trace.h @@ -0,0 +1,44 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#if !defined(_POWERNV_TRACE_H) || defined(TRACE_HEADER_MULTI_READ) +#define _POWERNV_TRACE_H + +#include +#include +#include + +#undef TRACE_SYSTEM +#define TRACE_SYSTEM power + +TRACE_EVENT(powernv_throttle, + + TP_PROTO(int chip_id, const char *reason, int pmax), + + TP_ARGS(chip_id, reason, pmax), + + TP_STRUCT__entry( + __field(int, chip_id) + __string(reason, reason) + __field(int, pmax) + ), + + TP_fast_assign( + __entry->chip_id =3D chip_id; + __assign_str(reason); + __entry->pmax =3D pmax; + ), + + TP_printk("Chip %d Pmax %d %s", __entry->chip_id, + __entry->pmax, __get_str(reason)) +); + +#endif /* _POWERNV_TRACE_H */ + +/* This part must be outside protection */ +#undef TRACE_INCLUDE_PATH +#define TRACE_INCLUDE_PATH . + +#undef TRACE_INCLUDE_FILE +#define TRACE_INCLUDE_FILE powernv-trace + +#include diff --git a/include/trace/events/power.h b/include/trace/events/power.h index 6c631eec23e3..913181cebfe9 100644 --- a/include/trace/events/power.h +++ b/include/trace/events/power.h @@ -99,28 +99,6 @@ DEFINE_EVENT(psci_domain_idle, psci_domain_idle_exit, TP_ARGS(cpu_id, state, s2idle) ); =20 -TRACE_EVENT(powernv_throttle, - - TP_PROTO(int chip_id, const char *reason, int pmax), - - TP_ARGS(chip_id, reason, pmax), - - TP_STRUCT__entry( - __field(int, chip_id) - __string(reason, reason) - __field(int, pmax) - ), - - TP_fast_assign( - __entry->chip_id =3D chip_id; - __assign_str(reason); - __entry->pmax =3D pmax; - ), - - TP_printk("Chip %d Pmax %d %s", __entry->chip_id, - __entry->pmax, __get_str(reason)) -); - TRACE_EVENT(pstate_sample, =20 TP_PROTO(u32 core_busy, diff --git a/kernel/trace/power-traces.c b/kernel/trace/power-traces.c index 21bb161c2316..f2fe33573e54 100644 --- a/kernel/trace/power-traces.c +++ b/kernel/trace/power-traces.c @@ -17,5 +17,4 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(suspend_resume); EXPORT_TRACEPOINT_SYMBOL_GPL(cpu_idle); EXPORT_TRACEPOINT_SYMBOL_GPL(cpu_frequency); -EXPORT_TRACEPOINT_SYMBOL_GPL(powernv_throttle); =20 --=20 2.47.2 From nobody Mon Oct 6 03:11:23 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D17302EBDC3 for ; Fri, 25 Jul 2025 12:42:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447325; cv=none; b=hlwOB9q1QWbg6tO64RoeE4CCWvQnV47nsM8r34hAxSdUXShViuiqQGFNYfgxffZFgNG4ksfisCr4aeJG2dhf2hdhGReOcbWXlqgYg3mpCkPOFmH0nm3qJfneysU44HGCkl5ciy53UWO0UyDU/kk7ZQ+v0vRvdFrOES52omIYtSI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447325; c=relaxed/simple; bh=qcVYPuBO5Z4rgObuJEoioUnNNPKt/VjlMojXOPllFwA=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=kLpxh6P7ub71ZxGlfXrZYEuer0lG8MJ8XNnkFgNH65Y0JLJDL/ooD6vI7lS7suKEZA/ielS8J2wJW6Wnu/og7WDNxKGmxRNRLxWvNYylOu75W9mxo2eHZf1hKfGNbUzc3Lwuzah5aC9RbU2iihgcPeKqAl4/fK/YfHYRaQmNPg4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TRQ/eVSv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TRQ/eVSv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB84EC4CEE7; Fri, 25 Jul 2025 12:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753447325; bh=qcVYPuBO5Z4rgObuJEoioUnNNPKt/VjlMojXOPllFwA=; h=Date:From:To:Cc:Subject:References:From; b=TRQ/eVSvE2wFF1+iGgir8q3XiTYVgd8zGa/r5Ft5pKLOB3TP2vRXt/pzhdmTz+T49 YgiOUkdjjr/1rf6F4LJQLGdQb9U+F+OeTZcNVrTVbdat4m85ois3VVFUAcwZkwP1T9 6cnvNa6tKD9zjxF1rlYgYqDxpOyUSkv6RdZMoZQpHS6XDaqmtFsmJjOHlGu4WYESRq hUcR2wuBqult8KhpRHjxy3ys/CkbMx499M0VVueqNGEUmDOvXyJF1LwBg8BRlpC45J bL/DMie2ueQVZUmF287vDQHcOhb+diqR2qm8cIw+lImQJ0t+da3q0b6St98oJCbKQg 8uxtTZ7JwbmjA== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1ufHkZ-00000001CuP-0MZN; Fri, 25 Jul 2025 08:42:11 -0400 Message-ID: <20250725124210.936089481@kernel.org> User-Agent: quilt/0.68 Date: Fri, 25 Jul 2025 08:41:49 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Viresh Kumar , Madhavan Srinivasan , Michael Ellerman , "Rafael J. Wysocki" Subject: [for-next][PATCH 4/9] PM: tracing: Hide psci_domain_idle events under ARM_PSCI_CPUIDLE References: <20250725124145.391996103@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The events psci_domain_idle_enter and psci_domain_idle_exit events are only called when CONFIG_ARM_PSCI_CPUIDLE is defined. As each event can take up to 5K (less for DEFINE_EVENT()) regardless if they are used or not, it's best not to define them when they are not used. Add #ifdef around these events when they are not used. Cc: Masami Hiramatsu Cc: Mark Rutland Cc: Mathieu Desnoyers Cc: Andrew Morton Cc: Viresh Kumar Cc: Madhavan Srinivasan Cc: Michael Ellerman Link: https://lore.kernel.org/20250612145408.074769245@goodmis.org Acked-by: Rafael J. Wysocki Signed-off-by: Steven Rostedt (Google) --- include/trace/events/power.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/trace/events/power.h b/include/trace/events/power.h index 913181cebfe9..a10ad300d660 100644 --- a/include/trace/events/power.h +++ b/include/trace/events/power.h @@ -62,6 +62,7 @@ TRACE_EVENT(cpu_idle_miss, (unsigned long)__entry->state, (__entry->below)?"below":"above") ); =20 +#ifdef CONFIG_ARM_PSCI_CPUIDLE DECLARE_EVENT_CLASS(psci_domain_idle, =20 TP_PROTO(unsigned int cpu_id, unsigned int state, bool s2idle), @@ -98,6 +99,7 @@ DEFINE_EVENT(psci_domain_idle, psci_domain_idle_exit, =20 TP_ARGS(cpu_id, state, s2idle) ); +#endif =20 TRACE_EVENT(pstate_sample, =20 --=20 2.47.2 From nobody Mon Oct 6 03:11:23 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 652582ED171 for ; Fri, 25 Jul 2025 12:42:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447327; cv=none; b=bcxajLzSH5J8mp4e0kRgyT379yoOBwSDLdJxAqEpHLlmgtHzqmMlLqeUaSGUNFD2L4FOEJvmuzXWSC3CK7DKIL+e8BeX80q2F2sB0wKXy3aDv5sKJTMck6XCsYeK/fT4VUhThNHsOjTRyUCo46lSA4oW2BXYY+P34odfRIi1174= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447327; c=relaxed/simple; bh=ls3B46j2JflVkBk9DwvxOwQkXpB1wVMy8TeLXZLUHwE=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=ghW6ncxXs3RxdNZDYF8Vq8slWrzsVeQOVvPWQJko5oDwEvtBgwayCDP9iXNQ+4E/+65A1QUst1RIdrNatdETTXxMxnipbtyZyXHkUdfWQmfa5xaTDbg+XVuM/bAT1o+j37FFHmJdkod7qkE2fSLjWFlcAFe0GNDJ0CzwoZ006SI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KeHDQz55; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KeHDQz55" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF87CC4CEFC; Fri, 25 Jul 2025 12:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753447325; bh=ls3B46j2JflVkBk9DwvxOwQkXpB1wVMy8TeLXZLUHwE=; h=Date:From:To:Cc:Subject:References:From; b=KeHDQz55JOOwd1loFO+PEgLq67urE7+H/430NCyaCS9a8VDABAzF+T2isdpPpc1WT 8qzkZqnmNxCTKt2dmtnqhXXfBcHM3LpCMtQ4z77X+TFAJAXkIaDNFbDyU6brGrRGTK sJcI/14VzppJQ9ykbVRgBBTgwRdhwUJvJY/6AcYLvcCNS/LbOPm/FiXZpwqWPH0kug FqAM+IQxnKNUzjXVeMOi3miAZzDedR+9n91d0/Q4DN3wJ9a/4rI2g9Vvq6aiykW2KB oJC86XuwkDNMweq54fnhGZgw7bbQhL/POPmitgUcoaOBrmCPfLuBDmzQKJxl1Ej7lf vKiFSdJBFEwWQ== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1ufHkZ-00000001Cut-13WB; Fri, 25 Jul 2025 08:42:11 -0400 Message-ID: <20250725124211.106711710@kernel.org> User-Agent: quilt/0.68 Date: Fri, 25 Jul 2025 08:41:50 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Viresh Kumar , Madhavan Srinivasan , Michael Ellerman , "Rafael J. Wysocki" Subject: [for-next][PATCH 5/9] PM: tracing: Hide device_pm_callback events under PM_SLEEP References: <20250725124145.391996103@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The events device_pm_callback_start and device_pm_callback_end events are only called when CONFIG_PM_SLEEP is defined. As each event can take up to 5K regardless if they are used or not, it's best not to define them when they are not used. Add #ifdef around these events when they are not used. Cc: Masami Hiramatsu Cc: Mark Rutland Cc: Mathieu Desnoyers Cc: Andrew Morton Cc: Viresh Kumar Cc: Madhavan Srinivasan Cc: Michael Ellerman Link: https://lore.kernel.org/20250612145408.246703478@goodmis.org Acked-by: Rafael J. Wysocki Signed-off-by: Steven Rostedt (Google) --- include/trace/events/power.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/trace/events/power.h b/include/trace/events/power.h index a10ad300d660..5b1df5e1e092 100644 --- a/include/trace/events/power.h +++ b/include/trace/events/power.h @@ -212,6 +212,7 @@ TRACE_EVENT(cpu_frequency_limits, (unsigned long)__entry->cpu_id) ); =20 +#ifdef CONFIG_PM_SLEEP TRACE_EVENT(device_pm_callback_start, =20 TP_PROTO(struct device *dev, const char *pm_ops, int event), @@ -260,6 +261,7 @@ TRACE_EVENT(device_pm_callback_end, TP_printk("%s %s, err=3D%d", __get_str(driver), __get_str(device), __entry->error) ); +#endif =20 TRACE_EVENT(suspend_resume, =20 --=20 2.47.2 From nobody Mon Oct 6 03:11:23 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 231832EBDE8 for ; Fri, 25 Jul 2025 12:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447326; cv=none; b=ST7uvphrMEEjZfTJsJlBEu1uwm3+82ZOL+jO0eDs/MxKj/lf6qafVMk02g/qigts0nC5VqG0q3xnUsJo4p8bgKt6620omO1QjHiq16w8U+yK1o2zI9N2jCYVNfeTo1DlF99h1STcNSQeDx5SUgMvYyPLomVI2TG8N1lIwiJN7TE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447326; c=relaxed/simple; bh=TSYyYdc2kUVh5hhhFunzCcBGjyYSshiQxo01fjyU+Qc=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=Z1dcQF7sVV3rBwjxbpkcSbaNiBCH1BOomN/PY6Lpectl8DeTM3Y/X2rxUo94iiAyHL6UJ1kLUQHaGotwN6IlEmToSHyGbsdA4nDtuw+4Uwe5J2qoKv/f2NH3myohP5/80FH1uJ8Cu0mabjKYwtpVo7j7FTBCD34ARvj/fk82SUE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kqMVirwd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kqMVirwd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 037DBC4CEE7; Fri, 25 Jul 2025 12:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753447326; bh=TSYyYdc2kUVh5hhhFunzCcBGjyYSshiQxo01fjyU+Qc=; h=Date:From:To:Cc:Subject:References:From; b=kqMVirwdIQ4DlNhFpuXrM3MyqSZl1ERwls2kwjzHwqYGHDOOLWvKaYidJc0yUk+aV nwcnAeOsNnEPhvuXSxPQEN1w7syyKXgxoPi/vTtQmhYFZPS82LvoTVFW4rsOnCx35C TX2BDDMrFRSKrIOkCub6qBVGZnndWj8KvJgvpN4yo58rPzi/YjzEorLs3qsjt66N7D 17OUq9Ftu5r3HdQNYYLEbl6xUHbpy5tBRsyhLIst53H/pf/iOBBJHErQ/Rl1cCKi0s NWE4esgW2/Tcb9QSxQXKxeVq2efI6+wgnDg96ZqVpd9YUxbKJG1CZAmPCPFTc4OV+t qpFpLL6gD/mbw== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1ufHkZ-00000001CvN-1mFX; Fri, 25 Jul 2025 08:42:11 -0400 Message-ID: <20250725124211.273108187@kernel.org> User-Agent: quilt/0.68 Date: Fri, 25 Jul 2025 08:41:51 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Viresh Kumar , Madhavan Srinivasan , Michael Ellerman , "Rafael J. Wysocki" Subject: [for-next][PATCH 6/9] PM: tracing: Hide power_domain_target event under ARCH_OMAP2PLUS References: <20250725124145.391996103@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The power_domain_target event event is only called when CONFIG_OMAP2PLUS is defined. As each event can take up to 5K regardless if they are used or not, it's best not to define them when they are not used. Add #ifdef around these events when they are not used. Cc: Masami Hiramatsu Cc: Mark Rutland Cc: Mathieu Desnoyers Cc: Andrew Morton Cc: Viresh Kumar Cc: Madhavan Srinivasan Cc: Michael Ellerman Link: https://lore.kernel.org/20250612145408.415483176@goodmis.org Acked-by: Rafael J. Wysocki Signed-off-by: Steven Rostedt (Google) --- include/trace/events/power.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/trace/events/power.h b/include/trace/events/power.h index 5b1df5e1e092..82904291c2b8 100644 --- a/include/trace/events/power.h +++ b/include/trace/events/power.h @@ -319,6 +319,7 @@ DEFINE_EVENT(wakeup_source, wakeup_source_deactivate, TP_ARGS(name, state) ); =20 +#ifdef CONFIG_ARCH_OMAP2PLUS /* * The power domain events are used for power domains transitions */ @@ -350,6 +351,7 @@ DEFINE_EVENT(power_domain, power_domain_target, =20 TP_ARGS(name, state, cpu_id) ); +#endif =20 /* * CPU latency QoS events used for global CPU latency QoS list updates --=20 2.47.2 From nobody Mon Oct 6 03:11:23 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 561C52ECD08 for ; Fri, 25 Jul 2025 12:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447326; cv=none; b=pEzGPHUIzimpqBCrZ3/Uo0BczOmjaeW+LoZXPWF1bpwAS/Rl4xQCSaw5423Bu3x3SMncEBqOOEUldmmJCEmvxBVR2AgF5IxMc/FfvQ/3mPhppGki2uPHBdoPzjUA5pldkKh3ZqvsWWunFsHM+Fq0RCistZFgdwMHFk9BsUVbF04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447326; c=relaxed/simple; bh=HpbKDvo95agyRxLtCEKsJPtUQsdSgl9GXx/LyY8SJmk=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=EHtbIFRjc/vdWukwmGR+l3dUM2ZVLOHXod5To5jeCYZbN6NK4PVUpCq9ESkH3Jll8kaOWfrnS//5KRiEvE8QyFNNHaS1hpYbt7ZGz7gfnoPmyzS7SljX+NaP28FvOfTTWLEqEGSA7tqfgVVcIE0nEupQDBZutHhJiXHynXk6gJc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a8fb0VNb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a8fb0VNb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32555C4CEFA; Fri, 25 Jul 2025 12:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753447326; bh=HpbKDvo95agyRxLtCEKsJPtUQsdSgl9GXx/LyY8SJmk=; h=Date:From:To:Cc:Subject:References:From; b=a8fb0VNbJd5uGLi8XwD/dMnmlQXWUxCI0ji9N89Egws8SaDP2IMaToFVouckhFPmu sAn6+pxwuxC3lQn2P2ZsS9lvefqm6zVSpUqMDTKZ4/FRuPuDqhJ4/Avq5I5PJrIiN5 chZ+hp898zi9BPoyvUbqRsmmCqAMAr16dVuyMi0hKK2NNGlQC6b+6UA09k8Zqlt9ex iN01+tZXs+634lXFRzs+JJ0fRkTCgZ1Pv/ZJVIgpd0cWQYK8Md9PlkJfWDLRJfkQYF PVGfiFSXQRYVG3hKn5evdifKSCrR1/bgg3QfpZE6HrKruCHuWXjdLqjUAh/Hixju0H 1jdZo8uqpIyzw== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1ufHkZ-00000001Cvr-2UNc; Fri, 25 Jul 2025 08:42:11 -0400 Message-ID: <20250725124211.444127890@kernel.org> User-Agent: quilt/0.68 Date: Fri, 25 Jul 2025 08:41:52 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Greg Kroah-Hartman , "Arve =?utf-8?b?SGrDuG5u?= =?utf-8?b?ZXbDpWc=?= " , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Suren Baghdasaryan , Carlos Llamas , Alice Ryhl Subject: [for-next][PATCH 7/9] binder: Remove unused binder lock events References: <20250725124145.391996103@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt Trace events can take up to 5K each when they are defined, regardless if they are used or not. The binder lock events: binder_lock, binder_locked and binder_unlock are no longer used. Remove them. Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Cc: Greg Kroah-Hartman Cc: "Arve =3D?utf-8?b?SGrDuG5u?=3D =3D?utf-8?b?ZXbDpWc=3D?=3D " Cc: Todd Kjos Cc: Martijn Coenen Cc: Joel Fernandes Cc: Christian Brauner Cc: Suren Baghdasaryan Link: https://lore.kernel.org/20250612093408.3b7320fa@batman.local.home Fixes: a60b890f607d ("binder: remove global binder lock") Signed-off-by: Steven Rostedt (Google) Acked-by: Carlos Llamas Reviewed-by: Alice Ryhl --- drivers/android/binder_trace.h | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/drivers/android/binder_trace.h b/drivers/android/binder_trace.h index 16de1b9e72f7..97a78e5623db 100644 --- a/drivers/android/binder_trace.h +++ b/drivers/android/binder_trace.h @@ -34,27 +34,6 @@ TRACE_EVENT(binder_ioctl, TP_printk("cmd=3D0x%x arg=3D0x%lx", __entry->cmd, __entry->arg) ); =20 -DECLARE_EVENT_CLASS(binder_lock_class, - TP_PROTO(const char *tag), - TP_ARGS(tag), - TP_STRUCT__entry( - __field(const char *, tag) - ), - TP_fast_assign( - __entry->tag =3D tag; - ), - TP_printk("tag=3D%s", __entry->tag) -); - -#define DEFINE_BINDER_LOCK_EVENT(name) \ -DEFINE_EVENT(binder_lock_class, name, \ - TP_PROTO(const char *func), \ - TP_ARGS(func)) - -DEFINE_BINDER_LOCK_EVENT(binder_lock); -DEFINE_BINDER_LOCK_EVENT(binder_locked); -DEFINE_BINDER_LOCK_EVENT(binder_unlock); - DECLARE_EVENT_CLASS(binder_function_return_class, TP_PROTO(int ret), TP_ARGS(ret), --=20 2.47.2 From nobody Mon Oct 6 03:11:23 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 738BC2ECD1A for ; Fri, 25 Jul 2025 12:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447326; cv=none; b=hYWlAlf9avcSdh2qGvtGiS419+lu0vFCe47EB+bBiq5kxjR4kgTAziwijRBl2kzSMnPEFlgArnecOat04bri4+A0bAhVWq7nk3MLqdDnjBVWGUYXx8nJvF6N7NxBTk+Mf3U7aIF2q4Oe2LATBdJqT8GfnmPMHK4FCeAfNUGFbRc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447326; c=relaxed/simple; bh=Gd6c7GIye9x5ICs77K4Go8O7Rfxad14ZIzp+MYRxQeA=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=VjVFbiJG8yEDSceo7SxNrbFHbziBuNjW51tNAP+GWBQPDLpxRfrnGijHbLP672jkrdWx2kjiZ+j2BG4uo6hzTQkFEAbvLR4pXEaViWh7jKf19y0UL/zNSCffAGqMCIxn2FUB8HPPl+6ENmDPZFZCVc7+zGeLxvhvbPY6uNLoBfw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AQhy5j05; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AQhy5j05" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53C45C4CEEB; Fri, 25 Jul 2025 12:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753447326; bh=Gd6c7GIye9x5ICs77K4Go8O7Rfxad14ZIzp+MYRxQeA=; h=Date:From:To:Cc:Subject:References:From; b=AQhy5j05RSYn0AqmZwsLTuUTfX3N3XeD/olcRPCPzIQn3v9Z5p+dS6SGl0iCSeEYk qjO6XS1iJzg61vHmKYM9rVcjY+JyCqC68aK6XJH/XgqTzKPLQrA2O6HeBgR7QlzE16 SCylv+BV7gwIMd6HqeSNcYEPosEpJ0rmUDJ55GanUytr5OJ7ZDUlMRQH/7wwmT78Is qUw1MeVmcesqDJAEcrZ4TF/RrGiHKV2sU6i5s+80cCySS2SA+DJLftigdQG/boQ5os drpaeNW7mGtmYBivJak6SG9kWvoKWXbSe3zvrHQH58uvdamqp/KYFFsjCUyfdlhl+/ s/QVj8EV0A+uA== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1ufHkZ-00000001CwO-3BXv; Fri, 25 Jul 2025 08:42:11 -0400 Message-ID: <20250725124211.614005382@kernel.org> User-Agent: quilt/0.68 Date: Fri, 25 Jul 2025 08:41:53 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Will Deacon , Russell King , Thomas Gleixner , Valentin Schneider , Nicolas Pitre , Peter Zijlstra , Catalin Marinas Subject: [for-next][PATCH 8/9] tracing: arm: arm64: Hide trace events ipi_raise, ipi_entry and ipi_exit References: <20250725124145.391996103@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The ipi tracepoints are mostly generic, but the tracepoints ipi_raise, ipi_entry and ipi_exit are only used by arm and arm64. This means these trace events are wasting memory in all the other architectures that do not use them. Add CONFIG_HAVE_EXTRA_IPI_TRACEPOINTS and have arm and arm64 select it to enable these trace events. The config makes it easy if other architectures decide to trace these as well. Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Cc: Will Deacon Cc: Russell King Cc: Mark Rutland Cc: Thomas Gleixner Cc: Valentin Schneider Cc: Nicolas Pitre Cc: Peter Zijlstra Link: https://lore.kernel.org/20250722103714.64eba013@gandalf.local.home Signed-off-by: Steven Rostedt (Google) Acked-by: Catalin Marinas --- arch/arm/Kconfig | 1 + arch/arm64/Kconfig | 1 + include/trace/events/ipi.h | 58 ++++++++++++++++++++------------------ kernel/trace/Kconfig | 6 ++++ 4 files changed, 38 insertions(+), 28 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 3072731fe09c..e8f98217d0fc 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -102,6 +102,7 @@ config ARM select HAVE_BUILDTIME_MCOUNT_SORT select HAVE_DEBUG_KMEMLEAK if !XIP_KERNEL select HAVE_DMA_CONTIGUOUS if MMU + select HAVE_EXTRA_IPI_TRACEPOINTS select HAVE_DYNAMIC_FTRACE if !XIP_KERNEL && !CPU_ENDIAN_BE32 && MMU select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE select HAVE_EFFICIENT_UNALIGNED_ACCESS if (CPU_V6 || CPU_V6K || CPU_V7) &= & MMU diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 393d71124f5d..a027cb81dfcc 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -136,6 +136,7 @@ config ARM64 select CPU_PM if (SUSPEND || CPU_IDLE) select CPUMASK_OFFSTACK if NR_CPUS > 256 select DCACHE_WORD_ACCESS + select HAVE_EXTRA_IPI_TRACEPOINTS select DYNAMIC_FTRACE if FUNCTION_TRACER select DMA_BOUNCE_UNALIGNED_KMALLOC select DMA_DIRECT_REMAP diff --git a/include/trace/events/ipi.h b/include/trace/events/ipi.h index 3de9bfc982ce..9912f0ded81d 100644 --- a/include/trace/events/ipi.h +++ b/include/trace/events/ipi.h @@ -7,34 +7,6 @@ =20 #include =20 -/** - * ipi_raise - called when a smp cross call is made - * - * @mask: mask of recipient CPUs for the IPI - * @reason: string identifying the IPI purpose - * - * It is necessary for @reason to be a static string declared with - * __tracepoint_string. - */ -TRACE_EVENT(ipi_raise, - - TP_PROTO(const struct cpumask *mask, const char *reason), - - TP_ARGS(mask, reason), - - TP_STRUCT__entry( - __bitmask(target_cpus, nr_cpumask_bits) - __field(const char *, reason) - ), - - TP_fast_assign( - __assign_bitmask(target_cpus, cpumask_bits(mask), nr_cpumask_bits); - __entry->reason =3D reason; - ), - - TP_printk("target_mask=3D%s (%s)", __get_bitmask(target_cpus), __entry->r= eason) -); - TRACE_EVENT(ipi_send_cpu, =20 TP_PROTO(const unsigned int cpu, unsigned long callsite, void *callback), @@ -79,6 +51,35 @@ TRACE_EVENT(ipi_send_cpumask, __get_cpumask(cpumask), __entry->callsite, __entry->callback) ); =20 +#ifdef CONFIG_HAVE_EXTRA_IPI_TRACEPOINTS +/** + * ipi_raise - called when a smp cross call is made + * + * @mask: mask of recipient CPUs for the IPI + * @reason: string identifying the IPI purpose + * + * It is necessary for @reason to be a static string declared with + * __tracepoint_string. + */ +TRACE_EVENT(ipi_raise, + + TP_PROTO(const struct cpumask *mask, const char *reason), + + TP_ARGS(mask, reason), + + TP_STRUCT__entry( + __bitmask(target_cpus, nr_cpumask_bits) + __field(const char *, reason) + ), + + TP_fast_assign( + __assign_bitmask(target_cpus, cpumask_bits(mask), nr_cpumask_bits); + __entry->reason =3D reason; + ), + + TP_printk("target_mask=3D%s (%s)", __get_bitmask(target_cpus), __entry->r= eason) +); + DECLARE_EVENT_CLASS(ipi_handler, =20 TP_PROTO(const char *reason), @@ -127,6 +128,7 @@ DEFINE_EVENT(ipi_handler, ipi_exit, =20 TP_ARGS(reason) ); +#endif /* CONFIG_HAVE_EXTRA_IPI_TRACEPOINTS */ =20 #endif /* _TRACE_IPI_H */ =20 diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig index a3f35c7d83b6..35448f7233fe 100644 --- a/kernel/trace/Kconfig +++ b/kernel/trace/Kconfig @@ -53,6 +53,12 @@ config HAVE_DYNAMIC_FTRACE_WITH_DIRECT_CALLS config HAVE_DYNAMIC_FTRACE_WITH_CALL_OPS bool =20 +config HAVE_EXTRA_IPI_TRACEPOINTS + bool + help + For architectures that use ipi_raise, ipi_entry and ipi_exit + tracepoints. + config HAVE_DYNAMIC_FTRACE_WITH_ARGS bool help --=20 2.47.2 From nobody Mon Oct 6 03:11:23 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F28C2ECD34 for ; Fri, 25 Jul 2025 12:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447326; cv=none; b=Fmu5lw01WFVRGAq1hJqBUuRam6wKSxSmR5axK2Ea98JvuAvNyfLB6fer+NUIxycFDQ0fO1Qho/R04UbtBd0BwWDNgjUx1Lt8KkIsGbIJ5y1jd6/eIfbeGpO0GXkWPnG51nDpzWqiT2WaOuUjfjoHH4hubTkv9Q1FSGzE5nkjRZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753447326; c=relaxed/simple; bh=p8IGK4n6HKPRRjRVOFW5p1MfrK/F73ae7EmkoL2GcJQ=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=bs91cr7R8LAhayb4k7RCKEN7H9l8c7xl9tlJ4mqZqj3SKj6cjaAJkXNiFd/obUKWS5seS85hhEesnew5+UNFF0/oLp/yIAX1KqPxcETwzB4wpCHYZwElrKZuCx8U6hL1yjAMUM8j5414ysXiFatwnbwRR+Qo3a1YmAYkw/bJ98s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W4uKJDqN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W4uKJDqN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FFB8C4CEF8; Fri, 25 Jul 2025 12:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753447326; bh=p8IGK4n6HKPRRjRVOFW5p1MfrK/F73ae7EmkoL2GcJQ=; h=Date:From:To:Cc:Subject:References:From; b=W4uKJDqNkGeVeStRyxOeizHDNSs5KBMQkkk43B0N7WMyurkkWAn4FR+8E62ttKivQ ToS4YIN23yR1iZQE+0ai6m3eVtFGA9TjjEWFqRWrym/fyO0qD3ZAATLvFh4MDiH78K PFd9yERtKVrImVpUzWBlm8WJGdM7fb4v78T/KUB8lSUX8BwI7W7rYjSfIOvukbvQ/3 SDR+3ao+enTz3ywLw6WVC/JLMjWHXZILFxse4MHH0rHyqYpQrlQwqwrjzgq9agKxcx m+d0DbVwTj0x+m4AfS/oJm/JDsdXynSNubR6+HeGfUizDt5RVlKKdXWlpq9yXgj+lk akaFMa8SzmD2w== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1ufHkZ-00000001Cwu-3t2z; Fri, 25 Jul 2025 08:42:11 -0400 Message-ID: <20250725124211.779663463@kernel.org> User-Agent: quilt/0.68 Date: Fri, 25 Jul 2025 08:41:54 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Arnd Bergmann , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Catalin Marinas , Linus Torvalds Subject: [for-next][PATCH 9/9] tracing: Call trace_ftrace_test_filter() for the event References: <20250725124145.391996103@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The trace event filter bootup self test tests a bunch of filter logic against the ftrace_test_filter event, but does not actually call the event. Work is being done to cause a warning if an event is defined but not used. To quiet the warning call the trace event under an if statement where it is disabled so it doesn't get optimized out. Cc: Masami Hiramatsu Cc: Mark Rutland Cc: Mathieu Desnoyers Cc: Andrew Morton Cc: Arnd Bergmann Cc: Masahiro Yamada Cc: Nathan Chancellor Cc: Nicolas Schier Cc: Nick Desaulniers Cc: Catalin Marinas Cc: Linus Torvalds Link: https://lore.kernel.org/20250723194212.274458858@kernel.org Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_events_filter.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events= _filter.c index 3885aadc434d..e4581e10782b 100644 --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c @@ -2900,6 +2900,10 @@ static __init int ftrace_test_event_filter(void) if (i =3D=3D DATA_CNT) printk(KERN_CONT "OK\n"); =20 + /* Need to call ftrace_test_filter to prevent a warning */ + if (!trace_ftrace_test_filter_enabled()) + trace_ftrace_test_filter(1, 2, 3, 4, 5, 6, 7, 8); + return 0; } =20 --=20 2.47.2