From nobody Mon Oct 6 06:46:44 2025 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DAB52EE981 for ; Thu, 24 Jul 2025 16:33:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753374834; cv=none; b=F0ipMHByrfU1pyA1rI3Oi9GGJ9dP65rYqZFbNw6GBCabZZjnvuOJ33YU6ldU3mzuyRaEKntPgNnKgbOjO6x0emYjDEmlJjcn4hdhLCI2JC7ygnmfCN+v1rdI/IvBpR4GYN5ckQkl2EdJ8yPIASkZ6QW1F89knaYVojhRm1brmpw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753374834; c=relaxed/simple; bh=f7Cr96NR+m4Torc47Lz6ejudcvRm2aLJBuMaEPZby/8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=GklvoPLUBNDbyLx4ZFGtraUcRWI5uMAjXECdCXi2fzKDBNChjrqxIDPZptAu9KxG9lq/G8rRRkgX6hmwIGbPWZQtcqCPaNqjySk1/2EiZFJWAxEepPaSQUzlTHyruURjMQIyeEXyf7sTQsylHmJ6ubgPD1JlGvoldlb7icB6Tng= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Y7nKQ4ET; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Y7nKQ4ET" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2349fe994a9so9709665ad.1 for ; Thu, 24 Jul 2025 09:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1753374832; x=1753979632; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=ura5wcTj4QWPpkbDlo4EPw9VccDPgu2z7OWMW7MfOzQ=; b=Y7nKQ4ETf0uza2fHSGYhzu4ZleH8MtNH/7hMdDOVohjDoeBII6x5P2r7A3dYxG03l8 K/6Z12FMrbcE9BnVPYabFLJHNvdBFg+u0WB+VApT6Il8+zaVitqwNIhK26m22WScd8Bz TgStLEZVD2j0lg0PmIYdI/GNxqKxIo6c52CcAguDCULbl3ys0sTqZaYV8Ecs+wwd6XbZ j5OoGXBmJfbAQugdcb+UF66koBUFZ2BvDTHXuI2mu/AAukRDLOS9vDVPshlfq1L0+/Jo P0Z/xotxX9P2OVcmQrUlk3i5gVEcelQWq8igbVsCc/reWc4Xv477u/+Vqn1nDcUgGgb0 1sgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753374832; x=1753979632; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ura5wcTj4QWPpkbDlo4EPw9VccDPgu2z7OWMW7MfOzQ=; b=cfFXySmVemiKKl1D6ihMkOFF5ZYlJm+v8eS/Zsaze8VboKifOhU54N01RhJUukXF+J flO9jez7qN4bQPEVFN7VhwU569nEVVKcSwWxHxUxCSAM0PMC/4DkX1zrjlB9qF5nILEY eAa25xubtyDCm+cU5IOSOaoHccg05FNPTEHaLrtMPWhF83QD3HGPdt5qbZaOmI4jAF7v xillo/aXoJzL6AlPusRpXHGDvBvAtqn7Jsxl/eglmeQa378mpQbeJe3jWpc0SBc9vHu0 TMVTK8GKmGn/PckCOQjq250yWw2DUnaUbFM7MX2Tlb8hqDtDYOq+UiydObE3iij/dtZS HnIg== X-Forwarded-Encrypted: i=1; AJvYcCXpwTDiD2lUgXco6UeVsWl/YWIxUpVdXrQIZTuW3JCBPN4vAqVd5RBw+59V52DZStWTOnWrqfjpsjPlxco=@vger.kernel.org X-Gm-Message-State: AOJu0YxpztiPsBHgbnuPkQ2oK2ZvPYkGaQTCKM7J1Y5rvxuuPeZ39Jzz 3riTlNACNUZG9d+kdc16A4LzcjKEmdNwpO0eLIRVvs4isvxGHdVwwshRs4qTQY7B5Rf9O9RDh1b af249OhIyUw== X-Google-Smtp-Source: AGHT+IHpJd6vabYrSSti1Ja3w2Nm1/rMVDMaLq5NhuCPyXaWwsOvdwEXKWZ70ntOL4K2e/f5gEFFDX3xUsOO X-Received: from plbmn7.prod.google.com ([2002:a17:903:a47:b0:234:c5eb:fe1d]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:906:b0:235:779:edfd with SMTP id d9443c01a7336-23f981cd5cfmr103606605ad.39.1753374831951; Thu, 24 Jul 2025 09:33:51 -0700 (PDT) Date: Thu, 24 Jul 2025 09:32:55 -0700 In-Reply-To: <20250724163302.596743-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250724163302.596743-1-irogers@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250724163302.596743-16-irogers@google.com> Subject: [PATCH v6 15/22] perf bench synthesize: Avoid use of global perf_env From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , "Masami Hiramatsu (Google)" , Ravi Bangoria , Charlie Jenkins , Colin Ian King , Andi Kleen , Dmitry Vyukov , Graham Woodward , Ilkka Koskinen , Zhongqiu Han , Yicong Yang , Athira Rajeev , Kajol Jain , Li Huafei , "Steinar H. Gunderson" , Stephen Brennan , Chun-Tse Shao , Yujie Liu , "Dr. David Alan Gilbert" , Levi Yun , Howard Chu , Weilin Wang , Thomas Falcon , Matt Fleming , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , Zixian Cai , Steve Clevenger , Ben Gainey , Chaitanya S Prakash , Martin Liska , "=?UTF-8?q?Martin=20Li=C5=A1ka?=" , Song Liu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The benchmark doesn't use a data file and so the header perf_env isn't used. Stack allocate a host perf_env for use to avoid the use of the global perf_env. Signed-off-by: Ian Rogers --- tools/perf/bench/synthesize.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/tools/perf/bench/synthesize.c b/tools/perf/bench/synthesize.c index 9b333276cbdb..b3d493697675 100644 --- a/tools/perf/bench/synthesize.c +++ b/tools/perf/bench/synthesize.c @@ -114,12 +114,16 @@ static int run_single_threaded(void) .pid =3D "self", }; struct perf_thread_map *threads; + struct perf_env host_env; int err; =20 perf_set_singlethreaded(); - session =3D perf_session__new(NULL, NULL); + perf_env__init(&host_env); + session =3D __perf_session__new(/*data=3D*/NULL, /*tool=3D*/NULL, + /*trace_event_repipe=3D*/false, &host_env); if (IS_ERR(session)) { pr_err("Session creation failed.\n"); + perf_env__exit(&host_env); return PTR_ERR(session); } threads =3D thread_map__new_by_pid(getpid()); @@ -144,6 +148,7 @@ static int run_single_threaded(void) perf_thread_map__put(threads); =20 perf_session__delete(session); + perf_env__exit(&host_env); return err; } =20 @@ -154,17 +159,21 @@ static int do_run_multi_threaded(struct target *targe= t, u64 runtime_us; unsigned int i; double time_average, time_stddev, event_average, event_stddev; - int err; + int err =3D 0; struct stats time_stats, event_stats; struct perf_session *session; + struct perf_env host_env; =20 + perf_env__init(&host_env); init_stats(&time_stats); init_stats(&event_stats); for (i =3D 0; i < multi_iterations; i++) { - session =3D perf_session__new(NULL, NULL); - if (IS_ERR(session)) - return PTR_ERR(session); - + session =3D __perf_session__new(/*data=3D*/NULL, /*tool=3D*/NULL, + /*trace_event_repipe=3D*/false, &host_env); + if (IS_ERR(session)) { + err =3D PTR_ERR(session); + goto err_out; + } atomic_set(&event_count, 0); gettimeofday(&start, NULL); err =3D __machine__synthesize_threads(&session->machines.host, @@ -175,7 +184,7 @@ static int do_run_multi_threaded(struct target *target, nr_threads_synthesize); if (err) { perf_session__delete(session); - return err; + goto err_out; } =20 gettimeofday(&end, NULL); @@ -198,7 +207,9 @@ static int do_run_multi_threaded(struct target *target, =20 printf(" Average time per event %.3f usec\n", time_average / event_average); - return 0; +err_out: + perf_env__exit(&host_env); + return err; } =20 static int run_multi_threaded(void) --=20 2.50.0.727.gbf7dc18ff4-goog