From nobody Mon Oct 6 04:59:17 2025 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021072.outbound.protection.outlook.com [40.107.51.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F70925F98E; Thu, 24 Jul 2025 10:48:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.72 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753354091; cv=fail; b=N7QbOQMUuJ2fdg1RJxnh4ieNIGKEMpwIAyQgKmTU9AZQ1dy1cYkUg8FYaYlgA5s4rhsYa0qt+ovU/h0z+nYSfwkpiU0vniNJoljb9Yz3codI2muj4gduRBV0TmHOo+FWAYvg6z9ZPFyqcVKbXRPp8pCLrO6BlHbScVhPkY/tdr4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753354091; c=relaxed/simple; bh=ImgZJiBml5tory7v3EvOJphCsPJhnYRb0lDTYm7E6I8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=p9KJYxUZBFJjGlipeRz0KqFqFkHzojWxZ2A38LJqwXFatSXwT1Jkvu5YTRdweDfua+msEiGdBZIEoRy8hm5lz/bYSOQJufrCY2t0rnukZSaTJ75NnCH7GMOlS4YqTjk9Iv1UhT9FHnR21QQu1AWDAZ13HI7txdqtirP5XqnHIdU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io; spf=fail smtp.mailfrom=siliconsignals.io; arc=fail smtp.client-ip=40.107.51.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=siliconsignals.io ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JQUWXrVD6179Jl1778ez/Mvw86vIjrxRVqC3PA4MnDMRJS09c2Njx2cfZ7u+MEUVcRDmf2QSUFTkxkrIyDZcBxdsrVzNB+7HpXReX3PgsAvX+uSF/r9rg4yWVl65RFpGoPBnngG0X4Sup3IBwA7T7yOLzc6yrNZIVpEnjpWRjOYtSjmjJ+jGAmw+kZ58+cirdBUIBwHToreeHVYIn3hBbkKxoYH/mkZyhvu/n9tR7UKtaw+Ls5OpQnUtedyKeXJVJwMe3Ehb03eSPjoYGo+u8ZjFA9qFVryE/9oC3RWltmzmCdB1OI1jSleyr5WYx1kjgiXrYD3F/uRECu10TRA94w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=apEMJSAQfElNW5fYuo0Rq59NtXwOA7/EP/f1IwW5qYk=; b=l/h0N5acFZW1hrPMEzxTsiHpNLtURNIVWIlu3douww3VnsLDeyRRkLxvtw+Ry6Uv7wWZjtTOROD/JQ/iCqysOIBlLgJWFkCtf7h0N/eqTPYwj3G0oqo0989jaiMwpTZbuZ2pqm9M5pTXtnVtGlX/OH2+d505ZM/iiCXOTgaBZFlfVcZE4ys4BbYKGMyneRqu84FUWJIGv2iS87F2k+pCxnGmAluCCwzfhI8Hf6aJ/blaFZONXHFhD1D4KE9Zl+/dlmRylawo+jocpo112LOQGbNJdQ3hIGCslSgcLYgn5iYEDySa0PI+pcgj808dgyqK1S4xSMGymWD6sxkx/EQFEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) by PN0P287MB1634.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:186::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.22; Thu, 24 Jul 2025 10:48:04 +0000 Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418]) by PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418%6]) with mapi id 15.20.8964.021; Thu, 24 Jul 2025 10:48:04 +0000 From: Hardevsinh Palaniya To: sakari.ailus@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: laurent.pinchart@ideasonboard.com, Himanshu Bhavani , Hardevsinh Palaniya , Krzysztof Kozlowski , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , Ricardo Ribalda , "Bryan O'Donoghue" , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Sylvain Petinot , Benjamin Mugnier , Dongcheng Yan , Jingjing Xiong , Arnd Bergmann , Matthias Fend , Hans de Goede , Alan Stern , Heimir Thor Sverrisson , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 1/2] dt-bindings: media: i2c: Add ov2735 sensor Date: Thu, 24 Jul 2025 16:17:04 +0530 Message-Id: <20250724104711.18764-2-hardevsinh.palaniya@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250724104711.18764-1-hardevsinh.palaniya@siliconsignals.io> References: <20250724104711.18764-1-hardevsinh.palaniya@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN2PR01CA0125.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:6::10) To PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB3519:EE_|PN0P287MB1634:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f084208-c682-4ecb-09a4-08ddca9f912b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|7416014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UqtHHWS2EHT0FqG92Pj4ncskNFghQpYTfjafGzxwgG6AdjQXSmjQnmRjJLrf?= =?us-ascii?Q?eS3mY0trHBfSgk15/A/8n3TUy5/AK6BuJ75mJpcsFu20duh/hfjbviFBD/xJ?= =?us-ascii?Q?XLPS0e86d8cx8oWLzqgEOC/WNj84VgmNkhot4B1R9YA9SVKYr4yejrnSyNY2?= =?us-ascii?Q?MrkmUvLkj32K7tMvftyCYjp5ezkQU6S2d8fBdATyMCwd0qta4R2SLo9YCDNl?= =?us-ascii?Q?lg4sxBI71qMyHRlnogY+FUiOzFsNssJlq6m946ExnZc4aUfCyl+pNYCQtwvY?= =?us-ascii?Q?JoK+qZPCu8ksNuepOF5S2KYz1RC5tmz5utGorkGx6rp675i00pada4ncYQvb?= =?us-ascii?Q?q6+FxutkWJAPz6+FPpzPctUrwykNuFdYRMpPblzkcq8DN/KD/zTz+ETOV1pZ?= =?us-ascii?Q?cZzlaQq/1aM1qFirw9cNOPd9wzfLTgBwgQS45CRVxSBm0YDZP0XBRgZs/vJY?= =?us-ascii?Q?lVleIGVSrjf+e1Qk33Tvt2tOL8rvZ/zHcHkz/yJoI0Cz54La2CCgoRZboWGb?= =?us-ascii?Q?ypWvpmAN2GV//rKgDfaLLpn2H32kJltReI7ZtIymwNYeg2fE/ajHsJc+xwn5?= =?us-ascii?Q?0Z2dpeI/q7sX0zt3FGmnDyFqK7f43VP5vaRO0ZtFEm0vE1ybdrPUG/6CkVxs?= =?us-ascii?Q?9MrQLoIFxzX99SFaNWvE7dFtXpojjt67HgKkBFWPn0Lj5ARuh0bhum7AtHxH?= =?us-ascii?Q?EKeS+KxoVZKXA+VioSnZQP4C4UnQRuvXlB9iyAXUTLszP+qj/qoPeOO8ct2x?= =?us-ascii?Q?XR9kf3CLwNfLSv6ZDhHPVCIFlPl5EKUsEif1GUd22leFRPf30iUoX8mcIlEX?= =?us-ascii?Q?VvRb6fukWAYvEugFGpYs1te3718WfiY/68z9WYS2nNCbHADfyGwGuGMXmsaz?= =?us-ascii?Q?ZPC2p3DCnm4Z8DQagtYNlxFeaV7jO4Op/hKdVzCdoMlcmKHCKmkt2hUP0HMj?= =?us-ascii?Q?zcsB6Te2d3X35cDgkg4XaSlYHbn2RiGYiQcIXdwhC6IEdho0xVZS04xsnEWU?= =?us-ascii?Q?1osaTAbZMOpl4rR149dqwtsfa4A8EtpGE2JBP3CKwGT8j41YtHgZqlbc0Xtj?= =?us-ascii?Q?5pKPiiJ9+tzynT1G7az2WaijwV68T3lOBMr1fWs3X3WVqV3wXXb/71Mui6Xo?= =?us-ascii?Q?yRBS4xMvXj7bg6s8USLzvOhf/HwW8jVUFanzZuNi0GdOK4aj8rSZ4DTu9I2s?= =?us-ascii?Q?m4XFbgvn2nKO9k5Z417uWTbjJB+6IrjfflzcMNwWMPKglPgY9ZR9S4jUYbSX?= =?us-ascii?Q?ynSwakzxkL9NqUeL6XZ4vrLipGfEPEDuhvDqzdVNESzyMiRdRYVlqKxMf+pO?= =?us-ascii?Q?nzGPlLIe9+0AgQGUnJM68COwRHq0XgtUIol8PfGLuiGbrshhV8lRfJpQx91p?= =?us-ascii?Q?xFYXMQtT1CuL8pu6hrTf9E1bXwFmZXHT981bwxL64FA3QU86MzzMUoUN8MNj?= =?us-ascii?Q?e/NgdtMmFBA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB3519.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(7416014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E6CXi6STKBP8KaWP54pralUIxabnOE0Y2prmgxLr0eU07eFw/qLkCKX5CKkM?= =?us-ascii?Q?zUvXTz+bmwjZSgAPNysTJZoaDL5/zCtDp7HAhOSjvLVVgGf2VKrnbjjAX1eF?= =?us-ascii?Q?o3bXXMJzt7QJXO8EWFI/AyDMr3YcNOSbucPJyNnAhLTNt1Ps1nqjVRyCrU1J?= =?us-ascii?Q?Nr2XJ2dRcMdWA+w4FbBaBuWb66YYBHH6gjQPncYhEu30phItk+AMLGXsIFe3?= =?us-ascii?Q?OvE9VSU6ln5VXLBlrC9SNz0ny4n7BJTqkVpHj4D42gZVEd1LaKH1Yblf7mmo?= =?us-ascii?Q?78O7kiNuPvMRz7R3xwPudBId9cXMlPOHvWLTn5QQHbPj/MWHbZ+rN6/1lHBP?= =?us-ascii?Q?5RXwQQ8aCEYHmZCdWc16+cPnK1gDU77//oBHW3xIfRIR9G8dQgN5ifro+TWo?= =?us-ascii?Q?GZZANTPe9c3HXCsyxAPacnx8oPIMQqhHsybuyR6b2ZSlNK5/ouV+rG6T4rxf?= =?us-ascii?Q?iqBcok/ijM7mOQ5ECxfE/NtUpGhk1H6C6ztrx10maOjCsXdG8e1edt0+Nmfz?= =?us-ascii?Q?usi3Wrz6v/jxyf28N6juoCBhk56yQpA9nZZgN8r2ZMVgzi0izxF1NnwFosx0?= =?us-ascii?Q?UJ4eGYkgTs/1Mkd4pT+UCRvpeB4X5a2P3rN1tyWbLkKjOugJWm0FXDrkOV3l?= =?us-ascii?Q?tghMyUrf6ukZOglk/gspFU8c0182Cf8V3b95ASutfZVRnxaCnUrhSqAnk1V/?= =?us-ascii?Q?zRx20rrTS6WcKomxi2mNw3BnMAg1B3uaB3KffUbUIjASzVStJTLEG6fLc2JB?= =?us-ascii?Q?zo5ZuF8rL89uQ4l3ArT6vXp7o7RQDcCWvZd7ptdUZ1CMRCtUigxcNStyDA1l?= =?us-ascii?Q?xvezvXXuTxsV652TI3/UTeQzRV6emf5p9o8DdbxRHmWT/020BAd2V3t3FYzG?= =?us-ascii?Q?LehEjsgZ/1y5x57rMCCaojj/4o2y37DlOVEv3R5/uJEfhGIvrQmA+bEUU2BK?= =?us-ascii?Q?GEA8ySwcgUVHI4/GAIwxN61efV1LMPIMSl1bVGgiGZW0TFu5jonsddg9delx?= =?us-ascii?Q?d2dgmQzUkdVK65avfeYJDuA1YweTb/iAy6ioco5PvkIMjYTEzJCRNqb4OCgg?= =?us-ascii?Q?1GMd5OrajuG5KVnLkKrB/norsYmO0mn66vOoXVbcfyr2hEx53oS83DBDSPPc?= =?us-ascii?Q?ji4umk0j630AQEkWAkQ63CnBa5weuH2VepmrboeoQpdL9qCDWcda0L6Ijg2r?= =?us-ascii?Q?OrJR/D2uxuTu7a7mzjq+j2ZvWNEPCREN6eHq9N0cbur62h4L8PKkBhTmO51Y?= =?us-ascii?Q?/qE/XzwfBpYez2DQzfIw3i96O6PdX+ynhWzEXkciAm47+RMxNy+nPRIj9Ip6?= =?us-ascii?Q?hs75bDThvt1PUE6GcubDQxHb4AqEroYmpO2uP9EAeQLEOZk3GmWlCddZDX5u?= =?us-ascii?Q?/lDZpAfagigs5rO6i9fG1q80iqrVmxINz5YCbln71+p1JB+CkKA6Y6F7Zi4Y?= =?us-ascii?Q?aMpyfcO9O6NsmD+j5IJW7Dr43pY0grYfCullnPUJnL2DLBTAyFgDC9TbR1dk?= =?us-ascii?Q?KphJm6qHGmvAUjo2K5WdboG/i5eib35hDm+Qe4jzXrKUVa89om1A9mIgpqFN?= =?us-ascii?Q?SGH4Wno8CFVY71IYoWz5toLJPFfYRmqAD52kmMK2FsmIwG2PH6ciX4voWaT6?= =?us-ascii?Q?y+2NYzWUhh7N5LijJ0OLr7A=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: 5f084208-c682-4ecb-09a4-08ddca9f912b X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB3519.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2025 10:48:04.4863 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iEBDC2lMcmVsMEjnjaxih4a1v3FH0IUXZ1OnRRirRM9jL+5Hi7fCzGZqBr1d9mPufgwIrVfa3dBu7iEWLsx/1kw5TPmKA/Ig20PcZOGoe3qw0mxUvdapIWlnJGyhPdJD X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0P287MB1634 Content-Type: text/plain; charset="utf-8" From: Himanshu Bhavani Add bindings for Omnivision OV2735 sensor. Signed-off-by: Himanshu Bhavani Signed-off-by: Hardevsinh Palaniya Reviewed-by: Krzysztof Kozlowski --- .../bindings/media/i2c/ovti,ov2735.yaml | 109 ++++++++++++++++++ 1 file changed, 109 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov2735= .yaml diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml b= /Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml new file mode 100644 index 000000000000..9236829cc00d --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml @@ -0,0 +1,109 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ovti,ov2735.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: OmniVision OV2735 Image Sensor + +maintainers: + - Himanshu Bhavani + +description: + The OmniVision OV2735 is a 2MP (1920x1080) color CMOS image sensor contr= olled + through an I2C-compatible SCCB bus. it outputs RAW10 format and uses a 1= /2.7" + optical format. + +properties: + compatible: + const: ovti,ov2735 + + reg: + maxItems: 1 + + clocks: + items: + - description: XVCLK clock + + avdd-supply: + description: Analog Domain Power Supply + + dovdd-supply: + description: I/O Domain Power Supply + + dvdd-supply: + description: Digital Domain Power Supply + + reset-gpios: + maxItems: 1 + description: Reset Pin GPIO Control (active low) + + enable-gpios: + maxItems: 1 + description: + Active-low enable pin. Labeled as 'PWDN' in the datasheet, but acts = as + an enable signal. During power rail ramp-up, the device remains powe= red + down. Once power rails are stable, pulling this pin low powers on the + device. + + port: + description: MIPI CSI-2 transmitter port + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + items: + - const: 1 + - const: 2 + link-frequencies: true + + required: + - data-lanes + - link-frequencies + +required: + - compatible + - reg + - clocks + - avdd-supply + - dovdd-supply + - dvdd-supply + - port + +additionalProperties: false + +examples: + - | + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + camera-sensor@3c { + compatible =3D "ovti,ov2735"; + reg =3D <0x3c>; + clocks =3D <&ov2735_clk>; + + avdd-supply =3D <&ov2735_avdd>; + dovdd-supply =3D <&ov2735_dovdd>; + dvdd-supply =3D <&ov2735_dvdd>; + + reset-gpios =3D <&gpio1 6 GPIO_ACTIVE_LOW>; + enable-gpios =3D <&gpio2 11 GPIO_ACTIVE_LOW>; + + port { + cam_out: endpoint { + remote-endpoint =3D <&mipi_in_cam>; + data-lanes =3D <1 2>; + link-frequencies =3D /bits/ 64 <420000000>; + }; + }; + }; + }; --=20 2.34.1 From nobody Mon Oct 6 04:59:17 2025 Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazon11021120.outbound.protection.outlook.com [40.107.51.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7319D26B08C; Thu, 24 Jul 2025 10:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.51.120 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753354114; cv=fail; b=DQ/+Desle5rbuGsr0z2XeOsk6qBEQAFB3Ua96T9Yqy+Rc8MTTl2hBExaZmJEJEgUiXHRGQV2R4F5mNxoOfjW9tuuL/kevvPit/0phANDfsAOiPScXqzSrwdOyL4KtAWI87EvwMnvFWVdPJ4rWfRoqRHG5FcLjp8myy8yyoY7yzQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753354114; c=relaxed/simple; bh=/RHxu8XayMFoePxyxqpatMNEOqz/hoqZ7Jj4VLwjD8g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=t9w+gsB+byfB92PvZm3WCxzQQGmaLFoua0nJQMtCsohbg3lUPBDCf7u2K1TmmJhUDvgPh/tRZO+E8DZ77eINCZ2Os3/MamC8fG7c/ywjk9XkAc/JwMaU7dA7GSDBKFavpgZLmdAEfw5mE+tMQ0tmn32VNXxzxooWux7ayNUH/lY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io; spf=fail smtp.mailfrom=siliconsignals.io; arc=fail smtp.client-ip=40.107.51.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=siliconsignals.io Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=siliconsignals.io ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AFtrxFUeE9vUYru5SJ9seA3HDVhS7SO6LoAETx1uUyagzWcEkJCILX0N50oocWV1rbfL25JqgYmww3GeToAOQ0POU95EcetHxLe3HphMl++hiSioYYZdtY0lhs+Xk5J6CVZd/lC7mjoicubFAqoMGkHLdIMt3ujNAqjvhN8pqKVX2kneHTCI1Bb+CPJkvvHymPTOxuepRBscYukOByPQAewtjrxNiTZtbIi3sFSeZcaeJvbAwIUZAT/IBqk04PRycmJYYx+fOTU6Y+47A+yzJVlFJ6fJujJ+UZFC+zH1c8pgigqOAOFzqaCjhQDuHknHTUvYWmGXaAw6jrhgmlQ8iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/R5LwlXl7XNvO7vdBI2D08F932nevGpyPkuTkE6ZIPs=; b=qAzrLrrA9XM7UeGSkHqmxAp6SZsbNUEsricg1+eedHdEVQHsZ7ZnogUb+sIcQIjsM4+OPMSS/gTazYvmn7l9nBNokj6rCQ+ZWgX4K1l3g3Q83XxKM0Ws7DWOjbfix8p4/uqFlVl2ZsEvIf+cLVS0ZX8Qy3TJDmamfLpxLFKrtUXT6qlu/NOUxY3ANB+BwnOeMKlc+x1tZFkhTi9Iy6oGoYIDUjueEjNX1acOGtYp9E84kVIy6ktbzWCNzUeJLdA5AXe6hBA5JrK+hEZZXdBQWfk4SIT2NUqEiQkexL2J294A0Gcu5/21XAjP/lb1C6zhMAKWEW9afGPywgtFBo9dBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) by PN0P287MB0295.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:e6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.22; Thu, 24 Jul 2025 10:48:23 +0000 Received: from PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418]) by PN3P287MB3519.INDP287.PROD.OUTLOOK.COM ([fe80::5c9a:906e:318b:c418%6]) with mapi id 15.20.8964.021; Thu, 24 Jul 2025 10:48:23 +0000 From: Hardevsinh Palaniya To: sakari.ailus@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: laurent.pinchart@ideasonboard.com, Hardevsinh Palaniya , Himanshu Bhavani , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , Ricardo Ribalda , "Bryan O'Donoghue" , Hans de Goede , =?UTF-8?q?Andr=C3=A9=20Apitzsch?= , Benjamin Mugnier , Matthias Fend , Heimir Thor Sverrisson , Sylvain Petinot , Dongcheng Yan , Jingjing Xiong , Arnd Bergmann , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 2/2] media: i2c: add ov2735 image sensor driver Date: Thu, 24 Jul 2025 16:17:05 +0530 Message-Id: <20250724104711.18764-3-hardevsinh.palaniya@siliconsignals.io> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250724104711.18764-1-hardevsinh.palaniya@siliconsignals.io> References: <20250724104711.18764-1-hardevsinh.palaniya@siliconsignals.io> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PN2PR01CA0125.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:6::10) To PN3P287MB3519.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:229::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3P287MB3519:EE_|PN0P287MB0295:EE_ X-MS-Office365-Filtering-Correlation-Id: acf4af00-3164-4003-f808-08ddca9f9c7f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|7416014|366016|1800799024|38350700014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Yze/sFtMhF75T1msnOzfWY4S7A3col9mA0UQHK6AzLVoVRUUK4hoHDd1tkGe?= =?us-ascii?Q?YsJoCEX0YO+7uu3sc03aotpT/Az6u5A7VOy3Lrewl0ZeHyxku6a5cB9MTi+K?= =?us-ascii?Q?d5if/E/pwsCeXUgINPd2BPbq1U6+7FRzVeSozMDDt0oagPa79xpLeBgM46sb?= =?us-ascii?Q?iIQe+xJKO+8O0ywzSMGN925eMky/e+8CmKiTLmQS88IXuA2SvJ1Sm5V1HTjS?= =?us-ascii?Q?XcWQkVF8PRQPpz6odR9QWgCxQ3GGUZTW9FO4qGyePRtl8gFlaTdCbXeHwEwL?= =?us-ascii?Q?JxJ97Q7sgVreqvIwjEAwglvtFC1G6ulVomci0qvF4ocgXjxnmzSlJ/POFDL5?= =?us-ascii?Q?5r/XwqTRX4tHtoxOr+Rim2BEqY7H/laK82GOrDkbMQdtJ9TX8PJSj3oYczfi?= =?us-ascii?Q?Xjm0v1yYawviIwJlSeUzRMqnhGrCdU14T4m5nTkKqvCLV0xgv7zudO5LcfKj?= =?us-ascii?Q?ZzNI8vXIdY823yRrtePx5yKA3t5CGCS6iBonUXYdo1SZSNt2z0AvgdRuz8+I?= =?us-ascii?Q?D7H4Mte4PSfbvaz/kx0R8YAoulgXU0csUbt+LkCw+jEhY3DC1xUcbC4Wy4R8?= =?us-ascii?Q?o+y5RmI544aU8gngavdXQr8RukEZQjpXwY5/kOXzMoTfJZoLFEKFdOs1a7Ah?= =?us-ascii?Q?jP+O0IlUFLDDw80sZO/Hjn8wy8BeH0p2aZacCGCV/GNCbdC5e+NtSnngyD1O?= =?us-ascii?Q?L1/0stmhGnXyx+tiIcwGffvBEosF3uTdvZWU45cHdvpVhiDeQLvau46UBxgl?= =?us-ascii?Q?RTqym7ysdDcPN3VQ1nVlWQagfOwzVq0jlNfghBehaP2NOildqrFnwJoyDXZ1?= =?us-ascii?Q?E5MQM6PZg1yZuLFxt7MamGKFCx48XyfgDZgCbGXq4qsN0ttamtaoumTzaRkK?= =?us-ascii?Q?KD3xLwjJHwQyNXXKRvHoVm7fv97beOvr1wu2q5JxPVvGbbbpCaqYriUg/DMh?= =?us-ascii?Q?ZjSTvbbIhalAkdntYMTjUiSenZ8Mgdar1zorg872T4EWAI6cZ2ciIRcGG4YR?= =?us-ascii?Q?Wqm0r+edy6fRwwJzeKlfjKgZsBRG8qdbpei2LyAN5Bj97cGKl6qQG+ZxiqqS?= =?us-ascii?Q?2Uq7TMmxvXv+ATAnrfGPDdFR00cQC2sRWs+pmpZU/WTvdPnbS8n0T9481BhY?= =?us-ascii?Q?9Ea9rct4fxFj9nMo9vLPfRjcH65ZZbtgtEToxc3D5nKgGmt41UM8tInVYZaR?= =?us-ascii?Q?FmVOqXJkEDlN0YhWvaGqBqiGNyTqmUgVHIjqvVnhjtoJ85dKaWzrCGi02W8C?= =?us-ascii?Q?ynfizUVGR+dHTwb4fJa6kN8Cb2dp0CNdr5EGLBvuhmoqAmUz+j1YyDU1lcfU?= =?us-ascii?Q?lgLMpspX/FrnZJTSGsSjJRoEqgvck+DEajVapskUSjcGtbMcwvHaYlC9klay?= =?us-ascii?Q?cISwRVUtZKONY0iXFBGJM1Pzk86Dsn5h+0wKMHisJC7h67dGq95it8o+x+9d?= =?us-ascii?Q?MVaJbqX6vl1YeJdBfYZU7mtNgX57uAls5BqE2axJwMHm3D4MlhHRgw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN3P287MB3519.INDP287.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(7416014)(366016)(1800799024)(38350700014)(7053199007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NEYD2AuN516/DSRFw6rqZOgTNCWN/lhpE1rREENBrIaXP6DLpU6ACTsVH6lL?= =?us-ascii?Q?1A6oddO8c8d0AHPaXxzgrgs3Abg0F3UDcCe5W7vhws9pdfrvMKcNUFilyJbq?= =?us-ascii?Q?WHZitHQXrRbAxLSUa4WRdtVlC/QtLNOS0iuFmI1fsGWFilME5t82Zuc+ZV4X?= =?us-ascii?Q?hm6jv2R0CNIEsWij/fI7E/qnFCfMCUT8zrYPk6ma/uoXc6+Xs2Lxdqjl/QdI?= =?us-ascii?Q?PGgxKYCa4rzaNPOnhMPXjC/02PPs+tH4TVoYX4fsZeregD/cI4EPwOMEcCP4?= =?us-ascii?Q?J0LeBFrnFcly9c+dcorjEKCsZhrV+wZhVb+eeOcliysLg/V6eJsHGC/tbjaR?= =?us-ascii?Q?6x5Cr+YByHqaoTmoUxcDkXfuanH38JkhlEIXmf2GhipSmkCiJ8n8yyH3lWuu?= =?us-ascii?Q?cQ5Q8g85uBdJkGomU32cr9nyosRK7uogiEBcpnSalfCve0iNrVzUzffanIvP?= =?us-ascii?Q?8khtiljQYlVmPs10CyE4QpMq1Frvfkjkqo65fSPi4t6nI2jIoCIfVuykH0zq?= =?us-ascii?Q?ceXJBirQsWVf0QGOMwZ/We2rO6ycnefbletTLzzwyfJ6wU0TgFq0rx2dDs7U?= =?us-ascii?Q?ZMy6KBqUclqsf49HDzbwdV3BGfX73qD1/XHADvxF0P1VcMv+f0by3CNA+EW4?= =?us-ascii?Q?L/cl1B0EbhPqZTUBIyZROFlQ/D/2R6bw6RqkxC+ez3TMhOiGAIvFERcF/Vl7?= =?us-ascii?Q?boIsHTTHZPpfy5gmjDDvYQ4jSrZj2ezNTD2g5Lv6LOOUrzu/JX1kwdqTpUwo?= =?us-ascii?Q?+5eghsYlluWvbckqT0NvEq4tjKWKgVi3hkE9hxvPGqY4Z1+dA+lcn9eg/jEN?= =?us-ascii?Q?AVOY1uyE/RhUDjNAW8rAmg6eT/TWv1DNDkM1rC0GkDstCttagNaPUN6yeID/?= =?us-ascii?Q?aim1fuL9bPFdeDDMGAd6h4fu67hJBZ/gYERNWOs4Nlb3OYy4CyHaEWJIBY57?= =?us-ascii?Q?qRMMnuzOyIFaGve1fjGxhRGCaYVGJi8/MDR9Bfi3iK1+D9WF/g0TvrkvkFgx?= =?us-ascii?Q?zIU3uahDO9SpGr23cnoHYosOr7jhg+tH9oxlitk3TCw4Yt6wGPdwhBAT3Cis?= =?us-ascii?Q?IkwaYnjgIOXKkpYT2JVhGhUViZo2dW2tmX3QUjnQQRB+SGbv/abBOWfuL/ad?= =?us-ascii?Q?LRNZBCE+ngVlhjXkTou0o2gcmHO7LbWthIbVL2QaY+qsb3E49c8rqG6m3Fjg?= =?us-ascii?Q?0nd0fPQsOHYRIsAPKUWbiwC7vIcx2vsjkWZqgZLVjbApiUElppT8BQhrKAKd?= =?us-ascii?Q?hJa0wlG262OuXe+vS5jAqj2sENkTfvQYiVWNRME2S7IwVj96eQR42lR4TjjA?= =?us-ascii?Q?Wha0K2ZKEtsdHOZFY4NYkgial6xyYtggSX8c7GCC8SYa8s7JhHiPhqtEaaiD?= =?us-ascii?Q?aNeX6XCUXOcj/zQ7k2djuWHpbDszK9xQUCSi4+CFFGvMTopx2IElCK8paKqH?= =?us-ascii?Q?4GtbnOEg13uFMQN1QQPMPAug7H7RlRHwG7CF7DfxgFBguyTCWX7QApK/5nEL?= =?us-ascii?Q?NLdjgGuCdMzXP6isQ37eyvlydzwpQSq5a6JEWVv+Z1okXicprb9D20u6VwaB?= =?us-ascii?Q?2AxMiji+6VwrnWDS5Kcn3iKXXjqzdXX0/NXQ0e4Fhbz9qpRke0ZmjjXMEbAW?= =?us-ascii?Q?X354T5XrBi7GEv2wokPdd7A=3D?= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: acf4af00-3164-4003-f808-08ddca9f9c7f X-MS-Exchange-CrossTenant-AuthSource: PN3P287MB3519.INDP287.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2025 10:48:23.3533 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /ZiGpnsqpIt5YAydrKw15VVdngloV9fmE5+23+8rL/ElWZs+JpfVEWlE5+lmPgAfMy5wwwwcIkV2tNOCNC4RUdpOdIK4Dan6N4ow5SidsXkQhc4G+KD4CisSLwM7XHqK X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0P287MB0295 Content-Type: text/plain; charset="utf-8" Add a v4l2 subdevice driver for the Omnivision OV2735 sensor. The Omnivision OV2735 is a 1/2.7-Inch CMOS image sensor with an active array size of 1920 x 1080. The following features are supported: - Manual exposure an gain control support - vblank/hblank control support - Test pattern support control - Supported resolution: 1920 x 1080 @ 30fps (SGRBG10) Co-developed-by: Himanshu Bhavani Signed-off-by: Himanshu Bhavani Signed-off-by: Hardevsinh Palaniya --- MAINTAINERS | 9 + drivers/media/i2c/Kconfig | 10 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/ov2735.c | 1060 ++++++++++++++++++++++++++++++++++++ 4 files changed, 1080 insertions(+) create mode 100644 drivers/media/i2c/ov2735.c diff --git a/MAINTAINERS b/MAINTAINERS index 92e9d8c7708f..058bbfd9523b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -18471,6 +18471,15 @@ T: git git://linuxtv.org/media.git F: Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml F: drivers/media/i2c/ov2685.c =20 +OMNIVISION OV2735 SENSOR DRIVER +M: Hardevsinh Palaniya +M: Himanshu Bhavani +L: linux-media@vger.kernel.org +S: Maintained +T: git git://linuxtv.org/media.git +F: Documentation/devicetree/bindings/media/i2c/ovti,ov2735.yaml +F: drivers/media/i2c/ov2735.c + OMNIVISION OV2740 SENSOR DRIVER M: Tianshu Qiu R: Sakari Ailus diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 4b4c199da6ea..9646eab1b177 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -446,6 +446,16 @@ config VIDEO_OV2685 To compile this driver as a module, choose M here: the module will be called ov2685. =20 +config VIDEO_OV2735 + tristate "OmniVision OV2735 sensor support" + select V4L2_CCI_I2C + help + This is a Video4Linux2 sensor driver for the Sony + OV2735 camera. + + To compile this driver as a module, choose M here: the + module will be called ov2735. + config VIDEO_OV2740 tristate "OmniVision OV2740 sensor support" depends on ACPI || COMPILE_TEST diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile index 5873d29433ee..1adb27743fa1 100644 --- a/drivers/media/i2c/Makefile +++ b/drivers/media/i2c/Makefile @@ -93,6 +93,7 @@ obj-$(CONFIG_VIDEO_OV2640) +=3D ov2640.o obj-$(CONFIG_VIDEO_OV2659) +=3D ov2659.o obj-$(CONFIG_VIDEO_OV2680) +=3D ov2680.o obj-$(CONFIG_VIDEO_OV2685) +=3D ov2685.o +obj-$(CONFIG_VIDEO_OV2735) +=3D ov2735.o obj-$(CONFIG_VIDEO_OV2740) +=3D ov2740.o obj-$(CONFIG_VIDEO_OV4689) +=3D ov4689.o obj-$(CONFIG_VIDEO_OV5640) +=3D ov5640.o diff --git a/drivers/media/i2c/ov2735.c b/drivers/media/i2c/ov2735.c new file mode 100644 index 000000000000..4431adec0ecb --- /dev/null +++ b/drivers/media/i2c/ov2735.c @@ -0,0 +1,1060 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * V4L2 Support for the OV2735 + * + * Copyright (C) 2025 Silicon Signals Pvt. Ltd. + * + * Based on Rockchip ov2735 Camera Driver + * Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd. + * + * Inspired from ov8858, imx219, imx283 camera drivers + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#define OV2735_XCLK_FREQ (24 * HZ_PER_MHZ) + +/* Add page number in CCI private bits [31:28] of the register address */ +#define OV2735_PAGE_REG8(p, x) (((p) << CCI_REG_PRIVATE_SHIFT) | CCI_REG= 8(x)) +#define OV2735_PAGE_REG16(p, x) (((p) << CCI_REG_PRIVATE_SHIFT) | CCI_RE= G16(x)) + +#define OV2735_REG_PAGE_SELECT CCI_REG8(0xfd) + +/* Page 0 */ +#define OV2735_REG_CHIPID OV2735_PAGE_REG16(0x00, 0x02) +#define OV2735_CHIPID 0x2735 + +#define OV2735_REG_SOFT_REST OV2735_PAGE_REG8(0x00, 0x20) + +/* Clock Settings */ +#define OV2735_REG_PLL_CTRL OV2735_PAGE_REG8(0x00, 0x2f) +#define OV2735_REG_PLL_ENABLE 0x7f +#define OV2735_REG_PLL_OUTDIV OV2735_PAGE_REG8(0x00, 0x34) +#define OV2735_REG_CLK_MODE OV2735_PAGE_REG8(0x00, 0x30) +#define OV2735_REG_CLOCK_REG1 OV2735_PAGE_REG8(0x00, 0x33) +#define OV2735_REG_CLOCK_REG2 OV2735_PAGE_REG8(0x00, 0x35) + +/* Page 1 */ +#define OV2735_REG_STREAM_CTRL OV2735_PAGE_REG8(0x01, 0xa0) +#define OV2735_STREAM_ON 0x01 +#define OV2735_STREAM_OFF 0x00 + +#define OV2735_REG_UPDOWN_MIRROR OV2735_PAGE_REG8(0x01, 0x3f) +#define OV2735_REG_BINNING_DAC_CODE_MODE OV2735_PAGE_REG8(0x01, 0x30) +#define OV2735_REG_FRAME_LENGTH OV2735_PAGE_REG16(0x01, 0x0e) +#define OV2735_VTS_MAX 0x0fff +#define OV2735_REG_FRAME_EXP_SEPERATE_EN OV2735_PAGE_REG8(0x01, 0x0d) +#define OV2735_FRAME_EXP_SEPERATE_EN 0x10 +#define OV2735_REG_FRAME_SYNC OV2735_PAGE_REG8(0x01, 0x01) + +#define OV2735_REG_HBLANK OV2735_PAGE_REG16(0x01, 0x09) + +#define OV2735_REG_HS_MIPI OV2735_PAGE_REG8(0x01, 0xb1) +#define OV2735_REG_MIPI_CTRL1 OV2735_PAGE_REG8(0x01, 0x92) +#define OV2735_REG_MIPI_CTRL2 OV2735_PAGE_REG8(0x01, 0x94) +#define OV2735_REG_MIPI_CTRL3 OV2735_PAGE_REG8(0x01, 0xa1) +#define OV2735_REG_MIPI_CTRL4 OV2735_PAGE_REG8(0x01, 0xb2) +#define OV2735_REG_MIPI_CTRL5 OV2735_PAGE_REG8(0x01, 0xb3) +#define OV2735_REG_MIPI_CTRL6 OV2735_PAGE_REG8(0x01, 0xb4) +#define OV2735_REG_MIPI_CTRL7 OV2735_PAGE_REG8(0x01, 0xb5) +#define OV2735_REG_PREPARE OV2735_PAGE_REG8(0x01, 0x95) +#define OV2735_REG_R_HS_ZERO OV2735_PAGE_REG8(0x01, 0x96) +#define OV2735_REG_TRAIL OV2735_PAGE_REG8(0x01, 0x98) +#define OV2735_REG_R_CLK_ZERO OV2735_PAGE_REG8(0x01, 0x9c) +#define OV2735_REG_MIPI_COLOMN_NUMBER OV2735_PAGE_REG16(0x01, 0x8e) +#define OV2735_REG_MIPI_LINE_NUMBER OV2735_PAGE_REG16(0x01, 0x90) + +#define OV2735_REG_ANALOG_CTRL3 OV2735_PAGE_REG8(0x01, 0x25) +#define OV2735_REG_VNCP OV2735_PAGE_REG8(0x01, 0x20) + +/* BLC registers */ +#define OV2735_REG_BLC_GAIN_BLUE OV2735_PAGE_REG8(0x01, 0x86) +#define OV2735_REG_BLC_GAIN_RED OV2735_PAGE_REG8(0x01, 0x87) +#define OV2735_REG_BLC_GAIN_GR OV2735_PAGE_REG8(0x01, 0x88) +#define OV2735_REG_BLC_GAIN_GB OV2735_PAGE_REG8(0x01, 0x89) +#define OV2735_REG_GB_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf0) +#define OV2735_REG_BLUE_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf1) +#define OV2735_REG_RED_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf2) +#define OV2735_REG_GR_SUBOFFSET OV2735_PAGE_REG8(0x01, 0xf3) +#define OV2735_REG_BLC_BPC_TH_P OV2735_PAGE_REG8(0x01, 0xfc) +#define OV2735_REG_BLC_BPC_TH_N OV2735_PAGE_REG8(0x01, 0xfe) + +#define OV2735_REG_TEST_PATTERN OV2735_PAGE_REG8(0x01, 0xb2) +#define OV2735_TEST_PATTERN_ENABLE 0x01 +#define OV2735_TEST_PATTERN_DISABLE 0xfe + +#define OV2735_REG_LONG_EXPOSURE OV2735_PAGE_REG16(0x01, 0x03) +#define OV2735_EXPOSURE_MIN 4 +#define OV2735_EXPOSURE_STEP 1 + +#define OV2735_REG_ANALOG_GAIN OV2735_PAGE_REG8(0x01, 0x2= 4) +#define OV2735_ANALOG_GAIN_MIN 0x10 +#define OV2735_ANALOG_GAIN_MAX 0xff +#define OV2735_ANALOG_GAIN_STEP 1 +#define OV2735_ANALOG_GAIN_DEFAULT 0x10 + +/* Page 2 */ +#define OV2735_REG_V_START OV2735_PAGE_REG16(0x02, 0xa0) +#define OV2735_REG_V_SIZE OV2735_PAGE_REG16(0x02, 0xa2) +#define OV2735_REG_H_START OV2735_PAGE_REG16(0x02, 0xa4) +#define OV2735_REG_H_SIZE OV2735_PAGE_REG16(0x02, 0xa6) + +#define OV2735_LINK_FREQ_420MHZ (420 * HZ_PER_MHZ) +#define OV2735_PIXEL_RATE (168 * HZ_PER_MHZ) + +/* OV2735 native and active pixel array size. */ +static const struct v4l2_rect ov2735_native_area =3D { + .top =3D 0, + .left =3D 0, + .width =3D 1936, + .height =3D 1096, +}; + +static const struct v4l2_rect ov2735_active_area =3D { + .top =3D 8, + .left =3D 8, + .width =3D 1920, + .height =3D 1080, +}; + +static const char * const ov2735_supply_name[] =3D { + "avdd", /* Analog power */ + "dovdd", /* Digital I/O power */ + "dvdd", /* Digital core power */ +}; + +/* PLL_OUT =3D [PLL_IN * (pll_nc +3)] / [(pll_mc + 1) * (pll_outdiv + 1)] = */ +struct ov2735_pll_parameters { + u8 pll_nc; + u8 pll_mc; + u8 pll_outdiv; +}; + +struct ov2735 { + struct device *dev; + struct regmap *cci; + struct v4l2_subdev sd; + struct media_pad pad; + struct i2c_client *client; + struct clk *xclk; + struct gpio_desc *reset_gpio; + struct gpio_desc *enable_gpio; + struct regulator_bulk_data supplies[ARRAY_SIZE(ov2735_supply_name)]; + + /* V4L2 Controls */ + struct v4l2_ctrl_handler handler; + struct v4l2_ctrl *link_freq; + struct v4l2_ctrl *pixel_rate; + struct v4l2_ctrl *hblank; + struct v4l2_ctrl *vblank; + struct v4l2_ctrl *gain; + struct v4l2_ctrl *exposure; + struct v4l2_ctrl *test_pattern; + + u32 link_freq_index; + + u8 current_page; + struct mutex page_lock; +}; + +struct ov2735_mode { + u32 width; + u32 height; + u32 hts_def; + u32 vts_def; + u32 exp_def; + struct v4l2_rect crop; +}; + +static struct cci_reg_sequence ov2735_common_regs[] =3D { + { OV2735_REG_CLK_MODE, 0x15 }, + { OV2735_REG_CLOCK_REG1, 0x01 }, + { OV2735_REG_CLOCK_REG2, 0x20 }, + { OV2735_REG_BINNING_DAC_CODE_MODE, 0x00 }, + { OV2735_PAGE_REG8(0x01, 0xfb), 0x73 }, + { OV2735_REG_FRAME_SYNC, 0x01 }, + + /* Timing ctrl */ + { OV2735_PAGE_REG8(0x01, 0x1a), 0x6b }, + { OV2735_PAGE_REG8(0x01, 0x1c), 0xea }, + { OV2735_PAGE_REG8(0x01, 0x16), 0x0c }, + { OV2735_PAGE_REG8(0x01, 0x21), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x11), 0x63 }, + { OV2735_PAGE_REG8(0x01, 0x19), 0xc3 }, + + /* Analog ctrl */ + { OV2735_PAGE_REG8(0x01, 0x26), 0x5a }, + { OV2735_PAGE_REG8(0x01, 0x29), 0x01 }, + { OV2735_PAGE_REG8(0x01, 0x33), 0x6f }, + { OV2735_PAGE_REG8(0x01, 0x2a), 0xd2 }, + { OV2735_PAGE_REG8(0x01, 0x2c), 0x40 }, + { OV2735_PAGE_REG8(0x01, 0xd0), 0x02 }, + { OV2735_PAGE_REG8(0x01, 0xd1), 0x01 }, + { OV2735_PAGE_REG8(0x01, 0xd2), 0x20 }, + { OV2735_PAGE_REG8(0x01, 0xd3), 0x04 }, + { OV2735_PAGE_REG8(0x01, 0xd4), 0x2a }, + { OV2735_PAGE_REG8(0x01, 0x50), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x51), 0x2c }, + { OV2735_PAGE_REG8(0x01, 0x52), 0x29 }, + { OV2735_PAGE_REG8(0x01, 0x53), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x55), 0x44 }, + { OV2735_PAGE_REG8(0x01, 0x58), 0x29 }, + { OV2735_PAGE_REG8(0x01, 0x5a), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x5b), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x5d), 0x00 }, + { OV2735_PAGE_REG8(0x01, 0x64), 0x2f }, + { OV2735_PAGE_REG8(0x01, 0x66), 0x62 }, + { OV2735_PAGE_REG8(0x01, 0x68), 0x5b }, + { OV2735_PAGE_REG8(0x01, 0x75), 0x46 }, + { OV2735_PAGE_REG8(0x01, 0x76), 0x36 }, + { OV2735_PAGE_REG8(0x01, 0x77), 0x4f }, + { OV2735_PAGE_REG8(0x01, 0x78), 0xef }, + { OV2735_PAGE_REG8(0x01, 0x72), 0xcf }, + { OV2735_PAGE_REG8(0x01, 0x73), 0x36 }, + { OV2735_PAGE_REG8(0x01, 0x7d), 0x0d }, + { OV2735_PAGE_REG8(0x01, 0x7e), 0x0d }, + { OV2735_PAGE_REG8(0x01, 0x8a), 0x77 }, + { OV2735_PAGE_REG8(0x01, 0x8b), 0x77 }, + + { OV2735_REG_HS_MIPI, 0x83 }, + { OV2735_REG_MIPI_CTRL5, 0x0b }, + { OV2735_REG_MIPI_CTRL6, 0x14 }, + { OV2735_PAGE_REG8(0x01, 0x9d), 0x40 }, + { OV2735_REG_MIPI_CTRL3, 0x05 }, + { OV2735_REG_MIPI_CTRL2, 0x44 }, + { OV2735_REG_PREPARE, 0x33 }, + { OV2735_REG_R_HS_ZERO, 0x1f }, + { OV2735_REG_TRAIL, 0x45 }, + { OV2735_REG_R_CLK_ZERO, 0x10 }, + { OV2735_REG_MIPI_CTRL7, 0x70 }, + { OV2735_REG_ANALOG_CTRL3, 0xe0 }, + { OV2735_REG_VNCP, 0x7b }, + + /* BLC */ + { OV2735_REG_BLC_GAIN_BLUE, 0x77 }, + { OV2735_REG_BLC_GAIN_GB, 0x77 }, + { OV2735_REG_BLC_GAIN_RED, 0x74 }, + { OV2735_REG_BLC_GAIN_GR, 0x74 }, + { OV2735_REG_BLC_BPC_TH_P, 0xe0 }, + { OV2735_REG_BLC_BPC_TH_N, 0xe0 }, + { OV2735_REG_GB_SUBOFFSET, 0x40 }, + { OV2735_REG_BLUE_SUBOFFSET, 0x40 }, + { OV2735_REG_RED_SUBOFFSET, 0x40 }, + { OV2735_REG_GR_SUBOFFSET, 0x40 }, +}; + +static const struct ov2735_mode supported_modes[] =3D { + { + .width =3D 1920, + .height =3D 1080, + .exp_def =3D 399, + .hts_def =3D 2200, + .vts_def =3D 2545, + .crop =3D { + .top =3D 8, + .left =3D 8, + .width =3D 1920, + .height =3D 1080, + }, + }, +}; + +static const s64 link_freq_menu_items[] =3D { + OV2735_LINK_FREQ_420MHZ, +}; + +struct ov2735_pll_parameters pll_configs[] =3D { + /* For 420MHz pll_configs. */ + { + .pll_nc =3D 4, + .pll_mc =3D 0, + .pll_outdiv =3D 1, + }, +}; + +static const char * const ov2735_test_pattern_menu[] =3D { + "Disabled", + "Vertical Color", +}; + +static int ov2735_page_access(struct ov2735 *ov2735, + u32 reg, void *val, int *err, bool is_read) +{ + u8 page =3D (reg >> CCI_REG_PRIVATE_SHIFT) & 0xff; + u32 addr =3D reg & ~CCI_REG_PRIVATE_MASK; + int ret =3D 0; + + if (err && *err) + return *err; + + mutex_lock(&ov2735->page_lock); + + /* Perform page access before read/write */ + if (ov2735->current_page !=3D page) { + ret =3D cci_write(ov2735->cci, OV2735_REG_PAGE_SELECT, page, err); + if (ret) + goto err_mutex_unlock; + ov2735->current_page =3D page; + } + + if (is_read) + ret =3D cci_read(ov2735->cci, addr, (u64 *)val, err); + else + ret =3D cci_write(ov2735->cci, addr, *(u64 *)val, err); + +err_mutex_unlock: + mutex_unlock(&ov2735->page_lock); + return ret; +} + +static int ov2735_read(struct ov2735 *ov2735, u32 reg, u64 *val, int *err) +{ + return ov2735_page_access(ov2735, reg, val, err, true); +} + +static int ov2735_write(struct ov2735 *ov2735, u32 reg, u64 val, int *err) +{ + return ov2735_page_access(ov2735, reg, (void *)&val, err, false); +} + +static int ov2735_multi_reg_write(struct ov2735 *ov2735, + const struct cci_reg_sequence *regs, + unsigned int num_regs, int *err) +{ + unsigned int i; + int ret; + + for (i =3D 0; i < num_regs; i++) { + ret =3D ov2735_write(ov2735, regs[i].reg, regs[i].val, err); + if (ret) + return ret; + } + + return 0; +} + +static inline struct ov2735 *to_ov2735(struct v4l2_subdev *_sd) +{ + return container_of(_sd, struct ov2735, sd); +} + +static int ov2735_enable_test_pattern(struct ov2735 *ov2735, u32 pattern) +{ + int ret; + u64 val; + + ret =3D ov2735_read(ov2735, OV2735_REG_TEST_PATTERN, &val, NULL); + if (ret) + return ret; + + switch (pattern) { + case 0: + val &=3D ~OV2735_TEST_PATTERN_ENABLE; + break; + case 1: + val |=3D OV2735_TEST_PATTERN_ENABLE; + break; + } + + return ov2735_write(ov2735, OV2735_REG_TEST_PATTERN, val, NULL); +} + +static int ov2735_set_ctrl(struct v4l2_ctrl *ctrl) +{ + struct ov2735 *ov2735 =3D container_of(ctrl->handler, struct ov2735, + handler); + struct v4l2_mbus_framefmt *fmt; + struct v4l2_subdev_state *state; + u64 vts; + int ret =3D 0; + + state =3D v4l2_subdev_get_locked_active_state(&ov2735->sd); + fmt =3D v4l2_subdev_state_get_format(state, 0); + + if (ctrl->id =3D=3D V4L2_CID_VBLANK) { + /* Honour the VBLANK limits when setting exposure. */ + s64 max =3D fmt->height + ctrl->val - 4; + + ret =3D __v4l2_ctrl_modify_range(ov2735->exposure, + ov2735->exposure->minimum, max, + ov2735->exposure->step, + ov2735->exposure->default_value); + if (ret) + return ret; + } + + /* + * Applying V4L2 control value only happens + * when power is up for streaming. + */ + if (pm_runtime_get_if_in_use(ov2735->dev) =3D=3D 0) + return 0; + + switch (ctrl->id) { + case V4L2_CID_EXPOSURE: + ov2735_write(ov2735, OV2735_REG_LONG_EXPOSURE, ctrl->val, &ret); + break; + case V4L2_CID_ANALOGUE_GAIN: + ov2735_write(ov2735, OV2735_REG_ANALOG_GAIN, ctrl->val, &ret); + break; + case V4L2_CID_HBLANK: + ov2735_write(ov2735, OV2735_REG_HBLANK, ctrl->val, &ret); + break; + case V4L2_CID_VBLANK: + vts =3D ctrl->val + fmt->height; + ov2735_write(ov2735, OV2735_REG_FRAME_EXP_SEPERATE_EN, + OV2735_FRAME_EXP_SEPERATE_EN, &ret); + ov2735_write(ov2735, OV2735_REG_FRAME_LENGTH, vts, &ret); + break; + case V4L2_CID_TEST_PATTERN: + ret =3D ov2735_enable_test_pattern(ov2735, ctrl->val); + break; + default: + dev_err(ov2735->dev, "ctrl(id:0x%x, val:0x%x) is not handled\n", + ctrl->id, ctrl->val); + break; + } + ov2735_write(ov2735, OV2735_REG_FRAME_SYNC, 0x01, &ret); + + pm_runtime_put(ov2735->dev); + + return ret; +} + +static const struct v4l2_ctrl_ops ov2735_ctrl_ops =3D { + .s_ctrl =3D ov2735_set_ctrl, +}; + +static int ov2735_init_controls(struct ov2735 *ov2735) +{ + struct v4l2_ctrl_handler *ctrl_hdlr; + struct v4l2_fwnode_device_properties props; + const struct ov2735_mode *mode =3D &supported_modes[0]; + u64 hblank_def, vblank_def, exp_max; + int ret; + + ctrl_hdlr =3D &ov2735->handler; + ret =3D v4l2_ctrl_handler_init(ctrl_hdlr, 9); + if (ret) + return ret; + + ov2735->pixel_rate =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_PIXEL_RATE, 0, OV2735_PIXEL_RATE, + 1, OV2735_PIXEL_RATE); + + ov2735->link_freq =3D v4l2_ctrl_new_int_menu(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_LINK_FREQ, + ov2735->link_freq_index, + 0, link_freq_menu_items); + if (ov2735->link_freq) + ov2735->link_freq->flags |=3D V4L2_CTRL_FLAG_READ_ONLY; + + hblank_def =3D mode->hts_def - mode->width; + ov2735->hblank =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, V4L2_CI= D_HBLANK, + hblank_def, hblank_def, 1, hblank_def); + + vblank_def =3D mode->vts_def - mode->height; + ov2735->vblank =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_VBLANK, vblank_def, + OV2735_VTS_MAX - mode->height, + 1, vblank_def); + + exp_max =3D mode->vts_def - 4; + ov2735->exposure =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_EXPOSURE, OV2735_EXPOSURE_MIN, + exp_max, OV2735_EXPOSURE_STEP, mode->exp_def); + + ov2735->gain =3D v4l2_ctrl_new_std(ctrl_hdlr, &ov2735_ctrl_ops, + V4L2_CID_ANALOGUE_GAIN, OV2735_ANALOG_GAIN_MIN, + OV2735_ANALOG_GAIN_MAX, OV2735_ANALOG_GAIN_STEP, + OV2735_ANALOG_GAIN_DEFAULT); + + ov2735->test_pattern =3D v4l2_ctrl_new_std_menu_items(ctrl_hdlr, + &ov2735_ctrl_ops, V4L2_CID_TEST_PATTERN, + ARRAY_SIZE(ov2735_test_pattern_menu) - 1, + 0, 0, ov2735_test_pattern_menu); + if (ctrl_hdlr->error) { + ret =3D ctrl_hdlr->error; + dev_err(ov2735->dev, "control init failed (%d)\n", ret); + goto err_handler_free; + } + + ret =3D v4l2_fwnode_device_parse(ov2735->dev, &props); + if (ret) + goto err_handler_free; + + ret =3D v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, + &ov2735_ctrl_ops, &props); + if (ret) + goto err_handler_free; + + ov2735->sd.ctrl_handler =3D ctrl_hdlr; + + return 0; + +err_handler_free: + v4l2_ctrl_handler_free(ctrl_hdlr); + + return ret; +} + +static int ov2735_set_pll_ctrl(struct ov2735 *ov2735) +{ + struct ov2735_pll_parameters *pll_parameters; + u8 pll_ctrl; + u8 pll_outdiv; + int ret =3D 0; + + pll_parameters =3D &pll_configs[ov2735->link_freq_index]; + + /* BIT[7]: pll_clk_sel, BIT[6:2]: pll_nc, BIT[1:0]: pll_mc */ + pll_ctrl =3D ((pll_parameters->pll_nc << 2) | + (pll_parameters->pll_mc << 0)) & OV2735_REG_PLL_ENABLE; + + pll_outdiv =3D pll_parameters->pll_outdiv; + + ov2735_write(ov2735, OV2735_REG_PLL_CTRL, pll_ctrl, &ret); + ov2735_write(ov2735, OV2735_REG_PLL_OUTDIV, pll_outdiv, &ret); + + return ret; +} + +static int ov2735_set_framefmt(struct ov2735 *ov2735, + struct v4l2_subdev_state *state) +{ + const struct v4l2_mbus_framefmt *format; + const struct v4l2_rect *crop; + int ret =3D 0; + + format =3D v4l2_subdev_state_get_format(state, 0); + crop =3D v4l2_subdev_state_get_crop(state, 0); + + ov2735_write(ov2735, OV2735_REG_V_START, crop->top, &ret); + ov2735_write(ov2735, OV2735_REG_V_SIZE, format->height, &ret); + ov2735_write(ov2735, OV2735_REG_MIPI_LINE_NUMBER, format->height, &ret); + ov2735_write(ov2735, OV2735_REG_H_START, crop->left, &ret); + /* OV2735_REG_H_SIZE: Image half horizontal size */ + ov2735_write(ov2735, OV2735_REG_H_SIZE, (format->width / 2), &ret); + ov2735_write(ov2735, OV2735_REG_MIPI_COLOMN_NUMBER, format->width, &ret); + + return ret; +} + +static int ov2735_enable_streams(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state, u32 pad, + u64 streams_mask) +{ + struct ov2735 *ov2735 =3D to_ov2735(sd); + const struct ov2735_mode *mode; + const struct v4l2_mbus_framefmt *fmt; + int ret; + + fmt =3D v4l2_subdev_state_get_format(state, 0); + mode =3D v4l2_find_nearest_size(supported_modes, + ARRAY_SIZE(supported_modes), + width, height, + fmt->width, fmt->height); + + ret =3D pm_runtime_resume_and_get(ov2735->dev); + if (ret < 0) + return ret; + + /* Apply pll settings. */ + ret =3D ov2735_set_pll_ctrl(ov2735); + if (ret) { + dev_err(ov2735->dev, "failed to set frame format: %d\n", ret); + goto err_rpm_put; + } + + ret =3D ov2735_multi_reg_write(ov2735, ov2735_common_regs, + ARRAY_SIZE(ov2735_common_regs), NULL); + if (ret) { + dev_err(ov2735->dev, "%s failed to send mfg header\n", __func__); + goto err_rpm_put; + } + + /* Apply format settings. */ + ret =3D ov2735_set_framefmt(ov2735, state); + if (ret) { + dev_err(ov2735->dev, "failed to set frame format: %d\n", ret); + goto err_rpm_put; + } + + /* Apply customized values from user */ + ret =3D __v4l2_ctrl_handler_setup(ov2735->sd.ctrl_handler); + if (ret) + goto err_rpm_put; + + /* set stream on register */ + ret =3D ov2735_write(ov2735, OV2735_REG_STREAM_CTRL, OV2735_STREAM_ON, NU= LL); + if (ret) + goto err_rpm_put; + + return 0; + +err_rpm_put: + pm_runtime_put(ov2735->dev); + return ret; +} + +static int ov2735_disable_streams(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state, u32 pad, + u64 streams_mask) +{ + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret; + + /* set stream off register */ + ret =3D ov2735_write(ov2735, OV2735_REG_STREAM_CTRL, OV2735_STREAM_OFF, N= ULL); + if (ret) + dev_err(ov2735->dev, "%s failed to set stream\n", __func__); + + pm_runtime_put(ov2735->dev); + + return ret; +} + +static int ov2735_get_selection(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_selection *sel) +{ + switch (sel->target) { + case V4L2_SEL_TGT_CROP: + sel->r =3D *v4l2_subdev_state_get_crop(sd_state, 0); + return 0; + case V4L2_SEL_TGT_NATIVE_SIZE: + sel->r =3D ov2735_native_area; + return 0; + case V4L2_SEL_TGT_CROP_DEFAULT: + case V4L2_SEL_TGT_CROP_BOUNDS: + sel->r =3D ov2735_active_area; + return 0; + default: + return -EINVAL; + } +} + +static int ov2735_enum_mbus_code(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_mbus_code_enum *code) +{ + if (code->index >=3D 0) + return -EINVAL; + + code->code =3D MEDIA_BUS_FMT_SGRBG10_1X10; + + return 0; +} + +static int ov2735_enum_frame_size(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_frame_size_enum *fse) +{ + u32 code; + + if (fse->index >=3D ARRAY_SIZE(supported_modes)) + return -EINVAL; + + code =3D MEDIA_BUS_FMT_SGRBG10_1X10; + if (fse->code !=3D code) + return -EINVAL; + + fse->min_width =3D supported_modes[fse->index].width; + fse->max_width =3D fse->min_width; + fse->min_height =3D supported_modes[fse->index].height; + fse->max_height =3D fse->min_height; + + return 0; +} + +static void ov2735_set_framing_limits(struct ov2735 *ov2735, + const struct ov2735_mode *mode) +{ + u32 hblank, vblank_def; + + hblank =3D mode->hts_def - mode->width; + __v4l2_ctrl_modify_range(ov2735->hblank, hblank, hblank, 1, hblank); + + vblank_def =3D mode->vts_def - mode->height; + __v4l2_ctrl_modify_range(ov2735->vblank, vblank_def, + OV2735_VTS_MAX - mode->height, 1, vblank_def); +} + +static int ov2735_set_pad_format(struct v4l2_subdev *sd, + struct v4l2_subdev_state *sd_state, + struct v4l2_subdev_format *fmt) +{ + struct v4l2_mbus_framefmt *format; + const struct ov2735_mode *mode; + struct v4l2_rect *crop; + struct ov2735 *ov2735 =3D to_ov2735(sd); + + format =3D v4l2_subdev_state_get_format(sd_state, 0); + + mode =3D v4l2_find_nearest_size(supported_modes, + ARRAY_SIZE(supported_modes), + width, height, + fmt->format.width, fmt->format.height); + + fmt->format.width =3D mode->width; + fmt->format.height =3D mode->height; + fmt->format.field =3D V4L2_FIELD_NONE; + fmt->format.colorspace =3D V4L2_COLORSPACE_RAW; + fmt->format.quantization =3D V4L2_QUANTIZATION_FULL_RANGE; + fmt->format.xfer_func =3D V4L2_XFER_FUNC_NONE; + + if (fmt->which =3D=3D V4L2_SUBDEV_FORMAT_ACTIVE) + ov2735_set_framing_limits(ov2735, mode); + + *format =3D fmt->format; + + /* Initialize crop rectangle */ + crop =3D v4l2_subdev_state_get_crop(sd_state, 0); + *crop =3D mode->crop; + + return 0; +} + +static int ov2735_init_state(struct v4l2_subdev *sd, + struct v4l2_subdev_state *state) +{ + struct v4l2_subdev_format fmt =3D { + .which =3D V4L2_SUBDEV_FORMAT_TRY, + .format =3D { + .code =3D MEDIA_BUS_FMT_SGRBG10_1X10, + .width =3D supported_modes[0].width, + .height =3D supported_modes[0].height, + }, + }; + + ov2735_set_pad_format(sd, state, &fmt); + + return 0; +} + +static const struct v4l2_subdev_video_ops ov2735_video_ops =3D { + .s_stream =3D v4l2_subdev_s_stream_helper, +}; + +static const struct v4l2_subdev_pad_ops ov2735_pad_ops =3D { + .enum_mbus_code =3D ov2735_enum_mbus_code, + .get_fmt =3D v4l2_subdev_get_fmt, + .set_fmt =3D ov2735_set_pad_format, + .get_selection =3D ov2735_get_selection, + .enum_frame_size =3D ov2735_enum_frame_size, + .enable_streams =3D ov2735_enable_streams, + .disable_streams =3D ov2735_disable_streams, +}; + +static const struct v4l2_subdev_ops ov2735_subdev_ops =3D { + .video =3D &ov2735_video_ops, + .pad =3D &ov2735_pad_ops, +}; + +static const struct v4l2_subdev_internal_ops ov2735_internal_ops =3D { + .init_state =3D ov2735_init_state, +}; + +static int ov2735_power_on(struct device *dev) +{ + struct v4l2_subdev *sd =3D dev_get_drvdata(dev); + struct ov2735 *ov2735 =3D to_ov2735(sd); + int ret; + + gpiod_set_value_cansleep(ov2735->enable_gpio, 0); + /* + * Ensure device is inactive (PWDN high) before enabling power rails. + * As per datasheet, the PWDN pin (named 'enable_gpio' here) should be + * pulled low only after all power rails are stable. + */ + fsleep(3 * USEC_PER_MSEC); + + ret =3D regulator_bulk_enable(ARRAY_SIZE(ov2735_supply_name), + ov2735->supplies); + if (ret) { + dev_err(ov2735->dev, "failed to enable regulators\n"); + return ret; + } + + gpiod_set_value_cansleep(ov2735->enable_gpio, 1); + /* T4: delay from PWDN pulling low to RSTB pulling high. */ + fsleep(4 * USEC_PER_MSEC); + + ret =3D clk_prepare_enable(ov2735->xclk); + if (ret) { + dev_err(ov2735->dev, "failed to enable clock\n"); + goto err_regulator_off; + } + + gpiod_set_value_cansleep(ov2735->reset_gpio, 0); + /* T5: delay from RSTB pulling high to first I2C command */ + fsleep(5 * USEC_PER_MSEC); + + return 0; + +err_regulator_off: + regulator_bulk_disable(ARRAY_SIZE(ov2735_supply_name), ov2735->supplies); + return ret; +} + +static int ov2735_power_off(struct device *dev) +{ + struct v4l2_subdev *sd =3D dev_get_drvdata(dev); + struct ov2735 *ov2735 =3D to_ov2735(sd); + + gpiod_set_value_cansleep(ov2735->enable_gpio, 0); + clk_disable_unprepare(ov2735->xclk); + gpiod_set_value_cansleep(ov2735->reset_gpio, 1); + regulator_bulk_disable(ARRAY_SIZE(ov2735_supply_name), ov2735->supplies); + + return 0; +} + +static int ov2735_get_regulators(struct ov2735 *ov2735) +{ + unsigned int i; + + for (i =3D 0; i < ARRAY_SIZE(ov2735_supply_name); i++) + ov2735->supplies[i].supply =3D ov2735_supply_name[i]; + + return devm_regulator_bulk_get(ov2735->dev, + ARRAY_SIZE(ov2735_supply_name), + ov2735->supplies); +} + +static int ov2735_identify_module(struct ov2735 *ov2735) +{ + u64 chip_id; + int ret; + + ret =3D ov2735_read(ov2735, OV2735_REG_CHIPID, &chip_id, NULL); + if (ret) + return dev_err_probe(ov2735->dev, ret, "failed to read chip id %x\n", + OV2735_CHIPID); + + if (chip_id !=3D OV2735_CHIPID) + return dev_err_probe(ov2735->dev, -EIO, "chip id mismatch: %x!=3D%llx\n", + OV2735_CHIPID, chip_id); + + return 0; +} + +static int ov2735_parse_endpoint(struct ov2735 *ov2735) +{ + struct fwnode_handle *fwnode =3D dev_fwnode(ov2735->dev); + struct v4l2_fwnode_endpoint bus_cfg =3D { + .bus_type =3D V4L2_MBUS_CSI2_DPHY, + }; + struct fwnode_handle *ep; + unsigned long link_freq_bitmap; + int ret; + + ep =3D fwnode_graph_get_next_endpoint(fwnode, NULL); + if (!ep) + return dev_err_probe(ov2735->dev, -ENXIO, + "Failed to get next endpoint\n"); + + ret =3D v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg); + fwnode_handle_put(ep); + if (ret) + return ret; + + if (bus_cfg.bus.mipi_csi2.num_data_lanes !=3D 2) { + ret =3D dev_err_probe(ov2735->dev, -EINVAL, + "only 2 data lanes are supported\n"); + goto error_out; + } + + ret =3D v4l2_link_freq_to_bitmap(ov2735->dev, bus_cfg.link_frequencies, + bus_cfg.nr_of_link_frequencies, + link_freq_menu_items, + ARRAY_SIZE(link_freq_menu_items), + &link_freq_bitmap); + if (ret) { + ret =3D dev_err_probe(ov2735->dev, -EINVAL, + "only 420MHz frequency is available\n"); + goto error_out; + } + + ov2735->link_freq_index =3D __ffs(link_freq_bitmap); + +error_out: + v4l2_fwnode_endpoint_free(&bus_cfg); + + return ret; +}; + +static int ov2735_probe(struct i2c_client *client) +{ + struct ov2735 *ov2735; + unsigned int xclk_freq; + int ret; + + ov2735 =3D devm_kzalloc(&client->dev, sizeof(*ov2735), GFP_KERNEL); + if (!ov2735) + return -ENOMEM; + + ov2735->dev =3D &client->dev; + + v4l2_i2c_subdev_init(&ov2735->sd, client, &ov2735_subdev_ops); + ov2735->sd.internal_ops =3D &ov2735_internal_ops; + + ov2735->cci =3D devm_cci_regmap_init_i2c(client, 8); + if (IS_ERR(ov2735->cci)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->cci), + "failed to initialize CCI\n"); + + /* Set Current page to 0 */ + ov2735->current_page =3D 0; + + ret =3D devm_mutex_init(ov2735->dev, &ov2735->page_lock); + if (ret) + return dev_err_probe(ov2735->dev, ret, + "Failed to initialize lock\n"); + + /* Get system clock (xvclk) */ + ov2735->xclk =3D devm_v4l2_sensor_clk_get(ov2735->dev, NULL); + if (IS_ERR(ov2735->xclk)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->xclk), + "failed to get xclk\n"); + + xclk_freq =3D clk_get_rate(ov2735->xclk); + if (xclk_freq !=3D OV2735_XCLK_FREQ) + return dev_err_probe(ov2735->dev, -EINVAL, + "xclk frequency not supported: %u Hz\n", + xclk_freq); + + ret =3D ov2735_get_regulators(ov2735); + if (ret) + return dev_err_probe(ov2735->dev, ret, "failed to get regulators\n"); + + ret =3D ov2735_parse_endpoint(ov2735); + if (ret) + return dev_err_probe(ov2735->dev, ret, + "failed to parse endpoint configuration\n"); + + ov2735->reset_gpio =3D devm_gpiod_get_optional(ov2735->dev, + "reset", GPIOD_OUT_LOW); + if (IS_ERR(ov2735->reset_gpio)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->reset_gpio), + "failed to get reset GPIO\n"); + + ov2735->enable_gpio =3D devm_gpiod_get_optional(ov2735->dev, + "enable", GPIOD_OUT_LOW); + if (IS_ERR(ov2735->enable_gpio)) + return dev_err_probe(ov2735->dev, PTR_ERR(ov2735->enable_gpio), + "failed to get enable GPIO\n"); + + ret =3D ov2735_power_on(ov2735->dev); + if (ret) + return ret; + + ret =3D ov2735_identify_module(ov2735); + if (ret) + goto error_power_off; + + ret =3D ov2735_init_controls(ov2735); + if (ret) + goto error_power_off; + + /* Initialize subdev */ + ov2735->sd.flags |=3D V4L2_SUBDEV_FL_HAS_DEVNODE; + ov2735->sd.entity.function =3D MEDIA_ENT_F_CAM_SENSOR; + ov2735->pad.flags =3D MEDIA_PAD_FL_SOURCE; + + ret =3D media_entity_pads_init(&ov2735->sd.entity, 1, &ov2735->pad); + if (ret) { + dev_err_probe(ov2735->dev, ret, "failed to init entity pads\n"); + goto error_handler_free; + } + + ov2735->sd.state_lock =3D ov2735->handler.lock; + ret =3D v4l2_subdev_init_finalize(&ov2735->sd); + if (ret) { + dev_err_probe(ov2735->dev, ret, "subdev init error\n"); + goto error_media_entity; + } + + devm_pm_runtime_set_active_enabled(ov2735->dev); + devm_pm_runtime_get_noresume(ov2735->dev); + + ret =3D v4l2_async_register_subdev_sensor(&ov2735->sd); + if (ret) { + dev_err_probe(ov2735->dev, ret, + "failed to register ov2735 sub-device\n"); + goto error_subdev_cleanup; + } + + return 0; + +error_subdev_cleanup: + v4l2_subdev_cleanup(&ov2735->sd); + +error_media_entity: + media_entity_cleanup(&ov2735->sd.entity); + +error_handler_free: + v4l2_ctrl_handler_free(ov2735->sd.ctrl_handler); + +error_power_off: + ov2735_power_off(ov2735->dev); + + return ret; +} + +static void ov2735_remove(struct i2c_client *client) +{ + struct v4l2_subdev *sd =3D i2c_get_clientdata(client); + struct ov2735 *ov2735 =3D to_ov2735(sd); + + v4l2_async_unregister_subdev(sd); + v4l2_subdev_cleanup(&ov2735->sd); + media_entity_cleanup(&sd->entity); + v4l2_ctrl_handler_free(ov2735->sd.ctrl_handler); +} + +static DEFINE_RUNTIME_DEV_PM_OPS(ov2735_pm_ops, + ov2735_power_off, ov2735_power_on, NULL); + +static const struct of_device_id ov2735_id[] =3D { + { .compatible =3D "ovti,ov2735" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, ov2735_id); + +static struct i2c_driver ov2735_driver =3D { + .driver =3D { + .name =3D "ov2735", + .pm =3D pm_ptr(&ov2735_pm_ops), + .of_match_table =3D ov2735_id, + }, + .probe =3D ov2735_probe, + .remove =3D ov2735_remove, +}; +module_i2c_driver(ov2735_driver); + +MODULE_DESCRIPTION("OV2735 Camera Sensor Driver"); +MODULE_AUTHOR("Hardevsinh Palaniya = "); +MODULE_AUTHOR("Himanshu Bhavani "); +MODULE_LICENSE("GPL"); --=20 2.34.1