From nobody Mon Oct 6 06:29:00 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 222282749C0; Thu, 24 Jul 2025 08:12:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753344776; cv=fail; b=OaWgZ32FB21tVBv+UoO8HVlJ/o3e7b5n2mmL+B3OeNt6G0BJ9eFEGnI24CFYuonvUTJRsdBdNBEWE4CF5thgC4M06L4fBxJw6Dg+bECWm//jV1D3A5wpO3TuzyA1yoWU8us/h99y399xV4KMQRvhRYsOnKVX/nmKTO3ZE0oy4kQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753344776; c=relaxed/simple; bh=E9RQDaxbKiZMps8xDnQx2hZ869Uq49DGdglAL+dV9YQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=OKKBUcmGJSoLxUDvhv3sovKE3q7Lk6xVvRnVVADXzhjfeNmd95omkD4co4KNtgvL4YmUm56JXUAlzJZi+9jPQv26OlUjLoePEEHyadaMwyOFW4/gE6PmXliagJSGKtbf8qJmKU4P8GXUfzTccJsVvG/GHSDH1CNBFujq4xQi4FQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=AVX6Z+S/; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=L38nonaa; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="AVX6Z+S/"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="L38nonaa" Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56O6v17C003882; Thu, 24 Jul 2025 08:12:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=M5eVtfWqwxraPDY/rhe+MmSELT1iwW3OJDiVipfJDKM=; b= AVX6Z+S/V/ooV/ejol1PVcbx6uIoV/mNtrRNvTG1v971HcVH1eCGoK9GViIHRqpL QSReCpxJU02dtHKB7a4JzswAaW0z+YO2PVNWHFhU3ZNI/zrBM67OYvXQotjDHTDr tmp0cdt5uy2xFwriAT7MyOyvaUc45qPElUqF5hxKafAwojZQFn56bT4gqnKAGdVZ EaVbzjCLyhYbK93MbFEvfe845Evn3Eicyae0RCamqgLmoY8vpZE+cuh1ET2VmEsO +NyHtALsZSp7QprfNiOSGmZ9QmezkQ6NAi8piWmsZwj17SLwIy+g2occNOljll8R KIxNwqgDpg828wan7909GQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 48057r17vf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jul 2025 08:12:39 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 56O7IQ3k031428; Thu, 24 Jul 2025 08:12:38 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10on2041.outbound.protection.outlook.com [40.107.94.41]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4801thw688-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jul 2025 08:12:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RThpGH3wMzX9+xtIzdhYCiwdnIaxwtfeyIYeg4kRrisZHctljDTdsUsP/QmwpKOF+hTFe89KaauWRQuSIPO2efF+O3Ekc/2gyXvrN1wmKKBSzDW8beFt6BivhwvnAHwFmx1PU6EwTywD7nLRmD1XPHmgPMNE/XO97xhu2FZCpNZjOjTKCp1BSJbeAos9Bd0Dxwr07gZ8eb1F8Qx4oRcoejs/gSxzVpI1MKrd62Ylh79ALvTftVIED0CW6zaeDpFUQV3hUfSGnvntASGIJtsf7vLzLPfRJsEdWk8ceFc+kluLHGaWAOGoMcqxisnKv8B+Gq7fF+QOnZPJWXlYjf0JJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M5eVtfWqwxraPDY/rhe+MmSELT1iwW3OJDiVipfJDKM=; b=NKOcyELvtT5O86weJa23jpsWePg7Y5diJHCPdxNCYK4ZBjrRyKBtsxRah1VWQUeVMXQC+h9sz/b0T8xrJH/CZmBPrTuXznc4VNp3vBy6BvCTtUqQEBPuySlb2Ls8vhbR7KEurn77wHpsZH+sl/ZAPiaJE9NApw9voHu02ZmLf6pew3bVk78TbE8zao1eOxygHsW03Hanq7jDVy2QruCuP2bQ2rtg3iRXIRH/GrpSOnWhujjC/rHqOVpfru0ZJga/0Gi7gBwn8fa7+shU+C1Vi8+bzf09HAspO1WIbl/lXZjBQ4iY6Y6RBfP1eVhIsTZefVIp0ha6jH1gdGGGxUze+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M5eVtfWqwxraPDY/rhe+MmSELT1iwW3OJDiVipfJDKM=; b=L38nonaaip9uvV4Ifows0WUp4Zce21Sm5vz11hP1OLB4B/s0pfhXM4IMXaq5CCLG/FHkSr+LuTxnklk2svS3BOkmxJLzCpFUTklKOy5m/6SVNToqfKXkubTl7tvt4jVmw4SgmONMCmhcgzr/wCIkzPN8xWkLhK78NTgInTl3KYE= Received: from MN2PR10MB4320.namprd10.prod.outlook.com (2603:10b6:208:1d5::16) by SJ0PR10MB4815.namprd10.prod.outlook.com (2603:10b6:a03:2da::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.21; Thu, 24 Jul 2025 08:12:36 +0000 Received: from MN2PR10MB4320.namprd10.prod.outlook.com ([fe80::42ec:1d58:8ba8:800c]) by MN2PR10MB4320.namprd10.prod.outlook.com ([fe80::42ec:1d58:8ba8:800c%7]) with mapi id 15.20.8964.019; Thu, 24 Jul 2025 08:12:36 +0000 From: John Garry To: djwong@kernel.org, hch@lst.de, cem@kernel.org, dan.j.williams@intel.com, willy@infradead.org, jack@suse.cz, brauner@kernel.org, viro@zeniv.linux.org.uk Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, John Garry Subject: [PATCH v3 1/3] fs/dax: Reject IOCB_ATOMIC in dax_iomap_rw() Date: Thu, 24 Jul 2025 08:12:13 +0000 Message-ID: <20250724081215.3943871-2-john.g.garry@oracle.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20250724081215.3943871-1-john.g.garry@oracle.com> References: <20250724081215.3943871-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PH1PEPF000132FA.NAMP220.PROD.OUTLOOK.COM (2603:10b6:518:1::2b) To MN2PR10MB4320.namprd10.prod.outlook.com (2603:10b6:208:1d5::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB4320:EE_|SJ0PR10MB4815:EE_ X-MS-Office365-Filtering-Correlation-Id: f87b9187-06e8-4c92-9bf2-08ddca89d926 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FGNjGKags9QJiyenb+Wi2+NasEVDU1WVzxwotQHzjvTaRux6aG7aYixOEujE?= =?us-ascii?Q?Ugu06owuUNiKvIR30RQEU7YnxxVSbH51S3VWi3lpaRfVroRIdd9QRYAYoD4X?= =?us-ascii?Q?ck574njkoMM8yPyghnYhh79WE7gMh+c9EyCPHfZY+DD42ICy56YTaS9cVkCZ?= =?us-ascii?Q?uEBTOHJe6h9UUCpD7WHRlcnmjSYqjyZZ7Bt7TVNF/D3NeneN3+0/DhtKSK7F?= =?us-ascii?Q?IzhEj/UhH4e07vFLeRqrCBiPIOCDGBtonf4JF77u9nPfbk0lyNBaM3Jokqud?= =?us-ascii?Q?r+oGN+a6MkmoN7090A6S5f11T73eOVDWr6xDdgYyq0Uhde2cLR31s+iAbjGS?= =?us-ascii?Q?5ZzHft6lgPLbukovMwszMhVBgcfBma4UNRLRSLdLKb0Do/371Kk0DUEDB3iI?= =?us-ascii?Q?LRHcyB1r0A3N60Bmd9vJqoVqBCQVFiYBvOSFVtdGrN/sVBJ2S/bB+ImZHQdE?= =?us-ascii?Q?zPSV4e7+/fR0r89jXKWxjAkBcW4Mk26l93HTEEJQ1rggNMcVifuERUtlFVhP?= =?us-ascii?Q?ndyN/88T2eFfzwDHMlQlHxPrvbzoHk8T4seRhA9j+HqBE12v4LDVkQCerB30?= =?us-ascii?Q?S2xuMvC637cmzkc4fvDbsfrT//ZJIuwNeR9BLAQbkkEizzml+YKC+w2Lo4Gk?= =?us-ascii?Q?qB6Oe1q436Ggho20igM1xwm1B/Q5CPlpNLYfBU5xvbcX/2bz2iSUdqYVs9er?= =?us-ascii?Q?KhhH0BcFEyOWBxCB2fHyR+U0m0m76sC/ruZfDNnDBPNZrk8qHtV8DpdTgcYO?= =?us-ascii?Q?LXdGluMcFMnrgArhXGYzOO1q2Y5f0sCjYvmr6qhQxfpiaxiug/BpM9JI81xc?= =?us-ascii?Q?F+KUUQc/CmaNZETTsH1Q/9AnUZKOZ2RO2N6YUNgRyThSVBEVd/W5d7ft0kWi?= =?us-ascii?Q?K6p43lDKPjQN71BAWODhPXlZnAG7YsYeK5ppWTmPFN93dPvm38paF9oNOiW+?= =?us-ascii?Q?BHAZ32HW5wlOnmLOzcU9hI4ARMTBkNMKYzRyvGfFp8h39mEi1oAUC73O+EOS?= =?us-ascii?Q?fE1zVrfgtShd/DI88GkOaWQ91RzONpQLbkss1TEo6HB19kzWdPssKoyzOCIx?= =?us-ascii?Q?/vRc5mnoLAFB4VcpAtH5Jmdn6g1XkiSLipqcFUEiECCx5w2lpqF8keyxnYlO?= =?us-ascii?Q?reqvyrl46by9NEJf4JLuCisMtOo4jw1Ru/p5RxiKKI5HcM2/aJTMNluV4Yyb?= =?us-ascii?Q?lTpoOBaoqkJtexSF+xO8LxnIOq6e7yxTPAVX6X/F9xMjdyTmuju0RSxQno/V?= =?us-ascii?Q?CItQrMh+7hqA2sOGh9QrXUynegXPGPEvove5EuY9iWpMIPGjsVsP05AYX8tl?= =?us-ascii?Q?kNsa/qXxkfT7Lk1ZiEXSOCjyqREbrivk1VNcVvFGmTDoCDXmuCeCUfVxFpy2?= =?us-ascii?Q?NLYSiEQQVduM5Zbzz6su95ZdTlMH/KiFgzrBPV7G8ts8zU686Guu++bBL8YP?= =?us-ascii?Q?G82isXREr4I=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB4320.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?x9UPbuR6Fq2bkoKm+jH8q6trtbKhNa6yE568DMQpGmw787y5YtHcgGAx2O7B?= =?us-ascii?Q?i8F/RprCvvsvY7yTPPt0WSVf2zUYreXumqSe7peZvdvPPhryeDZZBm1KQcX9?= =?us-ascii?Q?60Sr1yXoEqPuMtET4HVQz65PnqO3mh9Ow3eBA0O2t93LUDuMeUeFuV78OhEm?= =?us-ascii?Q?3Pgq7+f/bVP8U9sO/cpR6yNLR5GWMqnY45E5C/kpnptZS6skrCL0uHpOnjas?= =?us-ascii?Q?d6YNv3jdZVJusjIfoLEeQVNbROjAIwTaUm5Vk7JY4Gbo7NQxSTv6JM4agtp3?= =?us-ascii?Q?u67PJVnXSyVxJolEig6DQk8ZTYY/r4GsyzsALhpt3Kze9HRRxBsaOb7uZihF?= =?us-ascii?Q?coXVL/DnZoIKrcgDwbG+AyerMAZb+1gjpEFg28qkefn0ojOECMf69qj8hAHY?= =?us-ascii?Q?mqZzrPEGsMvjJRo7KnrhiJPE4BdzzpXdETJc9RqHIRGANqQAqHlnphD29NJ7?= =?us-ascii?Q?cvM6WQ7xjcoY6AtaOIsSrUsXrujrV25UiK8S7ho/0arxYyjja98wcGY7P49Z?= =?us-ascii?Q?bdESTI90g5oDTAeVKiRV5g0LHvIoHoAXwV6aUpD+MwKmUVKfkvwx5HVzNgzH?= =?us-ascii?Q?nGaxX6KnNagFYfas/SToh2JvZbEyPPkB6/GAJzsUHI16SOheeOLcWycsZEX6?= =?us-ascii?Q?CZSA1ARSV2GyNp756+c+6iaopOuXS2tfIirSGbXWqAU9cWyZ9cvLcYR55J8b?= =?us-ascii?Q?dA/Rjri8XE+79tERsnvBvpZ7HcE+Kr2UDyNRJ7bybduchhHvAls4+HMb9Sbe?= =?us-ascii?Q?X+20aNiMGvb74sjQW4Rzai0DwtBCELrL0YexLCo5nQsZ86UKroKBtnHO95xO?= =?us-ascii?Q?N5YGH69uic3n+tRDB758lkaqZrIow+tsU8Rwj6IR5bNYUQ8AkFgEZXXMFXll?= =?us-ascii?Q?th0ipDpIesFPDLPgi84MY054PHfEjO4cp+X1nG6TAJPx39kBFyMaMoQF62YS?= =?us-ascii?Q?Xdy4fZ45IfkgpkXpHZXvcChoyXsu/u5nd5UX/YT2VZiNBq9qCeWD3VnbTL2Z?= =?us-ascii?Q?4YegabJIEbEcOI9yac5NeDYDnvXXyT/KtjbvDAIBf/8jNm79wMjtpHgwfoxb?= =?us-ascii?Q?wLxvALFnIsNolfjHmS0GBKo3S9/c6HzvbF07kt1D8q9a+sHIwuRloziFSzWu?= =?us-ascii?Q?i+is+gi0Pew9QdAR67d0+i0YVEYXRZl3KRJ96CkMBxuAtvTN++vO9Qud7Qo1?= =?us-ascii?Q?NgD5TdM8fWHFhXkFguTfugs+58DMve4XbkpCNq9zWgpQ4aCWf6eZ03FWBvvm?= =?us-ascii?Q?p7Cd5gZIyzz6f8mzux7VO9sziqdHcw6SILS7E/gDqfHP7/9SXmY+nmg+5YTX?= =?us-ascii?Q?btNNyfFvbNCNwHSczgxIUHRYUH9o7xbLTsgmLHdCMQgR19IN3tR0iZn7WrFn?= =?us-ascii?Q?2YMC+0vCZ07tm+H9yMRYQ2USAI5jBrqhaeiOotrco4WY04bzFZp65D2fh970?= =?us-ascii?Q?Gg6q+ah0dEI5AAMi1R3z/j2e9EzzJyPPT/LT88DWzDipl+VQbglUu82Rr6m/?= =?us-ascii?Q?Ewbr400TOXARmuhLns5BImFdu/ML3sXMC4XZLM4RJWLn0tgBzB6emXA+1u0E?= =?us-ascii?Q?c8ZG3TXuUo9RlXEBq/UseCc4J9Rj/eR961NlkLD2u2Ad/58Z5peb4loTqcAI?= =?us-ascii?Q?pw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: blrvkXk+MmS4mBODYeTou0bvNSXYduIkTs3soy1ZmlQT6w/pmxOO42N8x6jtq+ZXGxmxtG7pzdn8Mz9NSK5sIsoh6OC2NmmsRGx6pjFk83bJqneb/ntmbtGf///XLQW3e6tvIoj/dYh5tYbv1ggOqDHa8XpYwfMITs0oeUmVHkVH2DktHiJPfI1AQBAcjxkhcnnCCcRwYTwp/mhKUkBmJKYkk1+4ihVhkclqgC1BPwf86FVXa8VCPGqiBoizau89XNMVohqKT55g3WKEgKU7Z0MEnI7KMnA1D98cKitkBbfqPdq7cBSZTOzrP1zvXmSLuPqPlq020b/dMOZKJ7CcpJLTNVHGVDo2tWRRPLMFnAxfCEkleF+ky1ipIQFk8bQD2wEnDX3yDmlVaK1AChKA90Iu398gDjAmtRC7lMtGWCbant8GgMXa9gFMdXUIaayy530G3c7Ayso5uDu8+WZGqfLk8BvSFzasctpWVhmvcN77VU02A4fKHsVjYw/UDWRKXJqR7PwmsMXqPZ92N9gsq/VusBl6WLb4IgOC9G8gGrOulFIOZV6eNDx9JCcNNlxAnP3q6RdU+bXmSwmSPlLD4hUdqlypi9U/J7qt1yOoNes= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f87b9187-06e8-4c92-9bf2-08ddca89d926 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4320.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2025 08:12:36.0290 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fBu/10BgrXvB7VupsK1l3cTkLVDIK8sTQO+Wqxlwqu5O7mpwl2Q+D4fH8Ns9fhjFbWVAMLWb03mt4eFojcjwFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4815 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-24_01,2025-07-23_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2507240058 X-Authority-Analysis: v=2.4 cv=MNRgmNZl c=1 sm=1 tr=0 ts=6881eaf7 b=1 cx=c_pps a=e1sVV491RgrpLwSTMOnk8w==:117 a=e1sVV491RgrpLwSTMOnk8w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=Lbvx5G-rTOA9Ff6O7RQA:9 cc=ntf awl=host:13600 X-Proofpoint-ORIG-GUID: FEU5XnIiE2YqiuRfaflJVGfO33aR_6m5 X-Proofpoint-GUID: FEU5XnIiE2YqiuRfaflJVGfO33aR_6m5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI0MDA1OCBTYWx0ZWRfXybkV0PwBjsyR P7TLOAp5lpUCu27tiI7l3oeKMiZZsCAOac/unjUos2FzxV0LH4UelRdd5NlE1Ul2e21KRnGzQM5 CcZpGRRJvJR2opXdPJa3u9Dj48rz6nw7sO8q+kp1GKGx/ZL578wiW3GSVUrCwoqyHxsjSIZkMWC aEhx9ADVnAWfpuGFPB+zMNNZEJiYksor9zWEl7jNJtj92D2oxiZqkn6PvKDEomhYc2UPwMSEj2F b3a6Xgtu9yPQXKjrI4e9aZm2u1Rt99BnRBJcxwoY0tj/H6DkFiVeZ0IF3s5LfvPYd/zDhAS3Dd+ 3elUJ92Y3fRgxgCPEkY2RPNoxMiu0zhMY3EuAPX3orFsNhsTDGSHzesD2iIOCWqQMpDbwhpMDki s19KV+0/T2LBxptRt/9wkraT3ohOr5fkTOO82x8z8bdMDyfaZeg+9UgvOUiUjDSL+OUuP6n9 Content-Type: text/plain; charset="utf-8" The DAX write path does not support IOCB_ATOMIC, so reject it when set. Suggested-by: Darrick J. Wong Signed-off-by: John Garry Reviewed-by: "Darrick J. Wong" --- fs/dax.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/dax.c b/fs/dax.c index ea0c35794bf9..d9ce810fee9e 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -1756,6 +1756,9 @@ dax_iomap_rw(struct kiocb *iocb, struct iov_iter *ite= r, loff_t done =3D 0; int ret; =20 + if (WARN_ON_ONCE(iocb->ki_flags & IOCB_ATOMIC)) + return -EIO; + if (!iomi.len) return 0; =20 --=20 2.43.5 From nobody Mon Oct 6 06:29:00 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77AC22749C3; Thu, 24 Jul 2025 08:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753344777; cv=fail; b=Lr9lUs3ny405GFM7RbVqdH2RoM6WP0TumxWiIljcTCiphT0sJhp3g2/aWZBz52G6IO73EnGk7QU2DHdcItog6b4OjBcCTKJPDH4cZcO0WqM5f5pN+PXs3JpijgYSRj/FkTAKGpvan8TcIKIvyCNH0olMySYmYToHuIkoQPzJYl0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753344777; c=relaxed/simple; bh=k6GS8HJSLHDE7TPohWsleG4kRXArAkxiOx1Kih6ci70=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=D5iqyqthfT0apy9vbVSzp3nv4Zs1RIj8kRZbnxXkU23+TvDkzqcwF4QX8q5LmlIH+C6vTqfhoVvXfYLzSR83rYJB3MAPHZNaWGDaTrALmS4n3OBZ09oE7lAuUIOc9Nnpy4QejLChTiIzMNldz3t2MgzRfqtduWPFVU7E5Q14Fqg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=CVe7hCw0; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=vcfWLF23; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="CVe7hCw0"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="vcfWLF23" Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56O6ukIK030721; Thu, 24 Jul 2025 08:12:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=DhseojoRr4OEQaWq8W6XILqCmh8g/Uro20xjUfpIYgk=; b= CVe7hCw0XpjJREes5REKEMG0VSGlPoWFxkds7ZsIFGnR7dQKOrMZ8t/cndEHu4Em 5FP+N9/xDtZ6dcBObjH1eguRAx8irSS5H4nAYTGj7SSwdEgFkHaoYNGj8RDeDcdd J1JImBhrLeZN8Dvhc0IAfeS7wM7/Y2Fmi7Wy8LHnqF9UUNTzmXwmswUJx8Q5TYM4 gL0fnlpo6TfB4oyTwpBtH+FWFdt3g57Ojl42b6Vn7aWYA7b4IWtAddwCi3ZCsylC b/N/MebEjN8xAjHCgyGU7Q4u1qVDknlZombmFX0SyHyeG7XAUXMpfjSJT8Pj/L5q o27Uciye4uEOObUYfdL1pw== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 482cwhujhj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jul 2025 08:12:42 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 56O79eZH010475; Thu, 24 Jul 2025 08:12:41 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10on2058.outbound.protection.outlook.com [40.107.94.58]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4801tbjqv1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jul 2025 08:12:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Tp2HIYiFX+vdbs18XkrSvWtW43RbHgk1SVyh+qbd8Mq3kHjmCSABxAGPx5BcbpzpbfYLnSdlCo1p9vaLa1PKUxVWKGa6td+ZjhtFnJmhLlzUYDb9KQi9zZrU975g7mngIGvH1mlaaDb07H9jo2rOcvHlqJU/VuFcsicHaki1MvkvxcSzan8M6pccV1xFSC4vgkzfCeDVs71tWArt3Q1eKocIy/mpVlYxddBgCaEAQh7fd5vBRQfd/ojW/vjqDvS6qOQjqXUcXDONeP992z9iQmweIfX31hZqM40pwl9x+MFF6kU74y/+3ZuIB2VUsF4grF1EKAfFTjSOhNdKJFZDbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DhseojoRr4OEQaWq8W6XILqCmh8g/Uro20xjUfpIYgk=; b=QlYlV0Wxe8ehw9yU8NdMvNUm38DeU06AT5FzbE/bfklakFSfMUGLlMnLzI1KNcce2HOLD7n0gQj47Vw5/UVxvldOoO7JKNA8cypm4VgMU3GXI8r1vJ8jmlhfP8l3PBzl5OTKpXTfW3V+eH7HppOxMOIRA5lDctaUYcvEObCOkItZPDmY9S4TBzQftahhImJeyUraqdcaNUv+1flhI95HWBCCKUBEsJ2yvv50hXE0E91FBRfblQnm7hnC0c8pYFz2mAYnc6ksrY2QHStBbuQg1nE3dlX3e5nTddKn/h8d9aii63uFnDvwoqZ3V66PgVqc4yr3KBAy5FPKq9WrqMgHtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DhseojoRr4OEQaWq8W6XILqCmh8g/Uro20xjUfpIYgk=; b=vcfWLF23/7oGFSZ4xJX2UmXOWZm7/oedWeIJFOKr3I5FLAgp7l7oV0lUCORRBY+rvBPFCpdzyg2nRlgT8x/aVl0oJCynd0OHaU6eGFVY5ZwK3/yjdqPfT4aUnyFotPbnNIJ3MBTMCsx1y//fWA5GWATTLqqIII30QTVxJ0nRbOc= Received: from MN2PR10MB4320.namprd10.prod.outlook.com (2603:10b6:208:1d5::16) by SJ0PR10MB4815.namprd10.prod.outlook.com (2603:10b6:a03:2da::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.21; Thu, 24 Jul 2025 08:12:38 +0000 Received: from MN2PR10MB4320.namprd10.prod.outlook.com ([fe80::42ec:1d58:8ba8:800c]) by MN2PR10MB4320.namprd10.prod.outlook.com ([fe80::42ec:1d58:8ba8:800c%7]) with mapi id 15.20.8964.019; Thu, 24 Jul 2025 08:12:38 +0000 From: John Garry To: djwong@kernel.org, hch@lst.de, cem@kernel.org, dan.j.williams@intel.com, willy@infradead.org, jack@suse.cz, brauner@kernel.org, viro@zeniv.linux.org.uk Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, John Garry Subject: [PATCH v3 2/3] xfs: disallow atomic writes on DAX Date: Thu, 24 Jul 2025 08:12:14 +0000 Message-ID: <20250724081215.3943871-3-john.g.garry@oracle.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20250724081215.3943871-1-john.g.garry@oracle.com> References: <20250724081215.3943871-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PH1PEPF000132F0.NAMP220.PROD.OUTLOOK.COM (2603:10b6:518:1::33) To MN2PR10MB4320.namprd10.prod.outlook.com (2603:10b6:208:1d5::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB4320:EE_|SJ0PR10MB4815:EE_ X-MS-Office365-Filtering-Correlation-Id: e594da89-50a8-4a29-24b3-08ddca89da6d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DslJ59n9fVfuRAp5YXCDKTwtHWpq+NWnWVRo+yw1YC/QEN37BzIsXgZcTCQe?= =?us-ascii?Q?8Q8HiT17pVCL8OlrENT3XNA5Y61Ls5vc+B115CNIRRwIsNtDltvDWGBaTUcI?= =?us-ascii?Q?p3pOrx1kb5Zk6qqFWuAiWCN1PN1ofRZ2piONmdtmohe6zERjXx2kIqrBS0EL?= =?us-ascii?Q?M00WZsNXXI1z+twYg8c12121cauamFSF+5aewSSCAr/Q3ylyxei837LkCdvo?= =?us-ascii?Q?uopm3l87oqDhKTW/vYFKr/ykcgv0PaLya9CG6pmFoX9t8mcLsPWdtrt5sPcq?= =?us-ascii?Q?h839Vlje0SqPEyZLFqdQoKEVwdEo3+E5g4LVxARMoPRdIq4pssXWW1y8jkzu?= =?us-ascii?Q?k9g8W2RGBN989AqwaoXnWAooe/7OvRIrKVjQeC5wCu8h6gMkQdEFb1RtO+HL?= =?us-ascii?Q?tTXNNogg1Pnke3PJMtJ4Lvj7QLXP0Kf6Ct+SKMuCgDTrOuWCxSuuKu7H7dkl?= =?us-ascii?Q?hcAkNC+Ju8lNuuJFbKOcC4trGQ4PkS9Hgq8l+KGRFxWrgQT3pnjGgs0vDZ/7?= =?us-ascii?Q?c7nQbfSQfjIZS4d4ud3Xb6z/XqWDBltDq1B1VZKUhfe58UNbpaKYoh/cttWp?= =?us-ascii?Q?f+FIiORmlY2l+1tX/KcB6Kl4ngKQrPgd6R1nXfnit6JwtQ42BjL6eOXBN84H?= =?us-ascii?Q?TB6G8sFnyomn3e/zuvRek5GoInmxSmmmSdwVcJhXWeZsoXCjHda5IE9Ntq6W?= =?us-ascii?Q?CiqielikEa9V+0YTQopY19KhngyRdWK15LL2R4GCEVpTCClKcMdJ/TwCUmVB?= =?us-ascii?Q?wnkAd0uNdFId1PGIMTUGqHKn5WSARhVDSTPQ3CsKFx4mxBD1m5vTSBM02Dbk?= =?us-ascii?Q?sK2M4oJXiuEQvWY3XwAC8so6KjVxPk9JluW18Pqeh+hihJoigM0PjKqjFXV1?= =?us-ascii?Q?aBxE6KmUz+4sD8FnLpTgHlrY8Sl2jgDw2AwP1sA6mwkMeH+J6quYhaHXOT0j?= =?us-ascii?Q?yE9c22OL5LLx6KJ4RoRdAifZBDWdm/P4SH3aVV+G+EDeAF9vyfzA1HcQauOb?= =?us-ascii?Q?2l9nZvKdDC/NOaYs9A3Yjm2mAEoDmhN5gzKr/zFIkY5dHbtdFg77LOLqqvLW?= =?us-ascii?Q?bKfMJNixmwY0huCfOc+ji1+5ORyH1g7FXldYZoA7WgaIPP3Hy/LWyNUBXQLC?= =?us-ascii?Q?wjhnfEz7i5BWFkxTqlJKIdgPDflBWo4LWU1trCJy0ujfylOcW+60CCSbEfOm?= =?us-ascii?Q?FtaXx4UTh4ViUqjrZLwwnMk+vhMKn5k0mUiv5//xTdpzjyfSi7jHged57ITX?= =?us-ascii?Q?zqzHNCOV8/WXkeiHd2jI3OQdpLdpYXqBNqJ5goUbTlXAJijevMbDOXXwbrqz?= =?us-ascii?Q?NZaAPSh0CO0mm4mdJnJIEhi1w68+fSZrTsyaGevxAIkbeCSTY4UC4zUmZqgm?= =?us-ascii?Q?eDA+rl1xAAhONrY4LCuDA9OWE/5FUexOGN2GVoZ+kKyuNfkfaQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB4320.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n9i6ehdsQMKAyUqudDFzGy1qguLfO7PVK4dfsFHb3AuemMqOtvoVLnlAJYjq?= =?us-ascii?Q?4iRZBTvkd/D4qE7O/vjoYJaQIi/dsyfDrXt2GTPc8B5RoYEP0C77A2KoMzL1?= =?us-ascii?Q?AoQj5PLNBnUetMvr7qUBoBKHQjOX3wzIaVoEl3wCKsmPo5OcWBhWMDxFeeqF?= =?us-ascii?Q?u78T3IRLHEMRHysgosMEaiPbs9oZMSDIY2uHqmWsNyJEVlhN8BeuuaDok54P?= =?us-ascii?Q?Gw+EbE8Q30AYsaRm25zq52aQb4p9YEeq7OECsHGCOIZyvehPFAvupqB1uD8E?= =?us-ascii?Q?TcWaGTnGwJ2/ekr7iKXLqW3frDemopzyTt9yUZ6b3m0AyvKBcnv4mAEdTlbr?= =?us-ascii?Q?5XEWy9uJuoaLxFqwiBWEGcsCylXb1zCBfdPzX+Gz9rmwfblFFK87bV8lbknK?= =?us-ascii?Q?/nean5a1bHiFQU5XfmcxlBDSZY78nwYF+9BdUlIQ39dqsPU1yZETNL5pHbr0?= =?us-ascii?Q?wb5Ia4xeDNipmruIUIe32rF1pOjHgiyFmyWbZNsznLoe2NufRnCGNHv1YY40?= =?us-ascii?Q?YNHx+DyjI923LdIHmRUQqmUXud/jLkBVSx/lJTzY0mi/Zbc5SzNGQXAR7HN6?= =?us-ascii?Q?5MqYKDMHZWco28KFkb/owAsG2P55mTztRPW8xoisf5kwl7Bq5fPCSlgRCgHz?= =?us-ascii?Q?j0No9FHb7W5t+Yct8c815qb9BqcHRl7TlamzSWHYI6m2/4inIR3q10J6Isws?= =?us-ascii?Q?dM8pJcTaxHzNPErYyESWcwYeOqk7GadGY1Lxh/ft3RbjUntLbx/BmxnzF5Jg?= =?us-ascii?Q?AUWXJ+Wi6oQJ0swVtTHtR8StTv9ungId/mR7geWQjCZL6Vo7GBWoTNPUA+kL?= =?us-ascii?Q?MtksRkpyuWAOFjjl/46rNBjkmw36DdZfSJExGJRMlsxHVwfqueKgZC2anoYt?= =?us-ascii?Q?ThsFP+zTzNhs93DlR0+V5t7AQFWs6eTCJhapRNSlfesThlqFjTvxDzI5Sj89?= =?us-ascii?Q?HMjEE7PMucoJWHhu2N9neOsQgahFD6t23yWyQVC4re+yeln+TRdTl+uioWEs?= =?us-ascii?Q?7Tju5D9/xGNykOTKa4mM9/CncboC9KLln9eYRAPSE3gS/+isWTH+kGZhUnNF?= =?us-ascii?Q?MBLR1R+RMXrDVwZhdCAr2w6nqFiLAVnib+/46YdWAyJhVBwcnLLBPr1XstRU?= =?us-ascii?Q?85xRM5VaKbNiN63tfn5Hro03ZSCLZhqxOka7FRn2IO3OxprWCOxrG+4e+bXU?= =?us-ascii?Q?Cp1cte6tfzUHjdrVy6QiRn4toINjblWHFtrMpxxq07wMMbrZ+TQRB73lFRZT?= =?us-ascii?Q?FgDoIB4IjYm+1tYAVNyv7rGWEA2GA6q/8OIW3Z4NvIncPjYi9x3TmYd9g8lQ?= =?us-ascii?Q?QURWfVksTWy045g3GDE9VvAtsSYooWZ8eAR7hgfaK1P/t/NAj2QtpZM+26Jx?= =?us-ascii?Q?uO48oeIuP2JOFpFCoLqFyiNUI9GauOWsTlRTcYJhOK0uxcDLD2lKPGdrGzR0?= =?us-ascii?Q?45+LrSbT/drzXZc2Gnb8SaTA1NLBxwGmazy8zryL/OSMVth8DCgV1l+qbe9A?= =?us-ascii?Q?BlE6tzRE82T4VLZ75kB1fFutOW6ZFWNHunC2e0zxXGesuXvYTulydHf/t7hY?= =?us-ascii?Q?/njclxq0NxIs7WD9VKRlG/KTTMOf0SAaTbY+PUCy9t+LuSprXJWaEL/bVkqD?= =?us-ascii?Q?XQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kLWxz9uH2i+6Anp6muE73//taX1OBduDtuYzqflEGC2JkqtilDUL4UPR9z8z/BKuRU3N703fVjcIl7xFdbbujVnPj1BwvmcgvRUl6hiW8HYaFr8r1ReiFlevcUO2IC77FDiHqvVOzGVHH5pwUkj4u0yGnwvFhKSL8OhT4gI0YsP/+n00rh+rntSkHNlhpVu7LTyp11xTzElCVmwygNy+/Wu3fDbgdWvIWwDIzB2q+wv8pOAmF+OK+Cl+tIt034+CLaRQgfEma0s/NGHl+jWML2hPAa0JZ1/TSUT22Kh9gJLbJ5IX/7JXkLwHKlIcpYOykGZjVx/I8zVpOHzYHVIkw33WmARB10beL599xeeM7RFVd1Qxsm7fP5ImfXrqMlrPzyOb83CScQp/5djVWwsoo0IUp4Dr7l+x+Me30tgltUhAyWvUb+zRnHBtTo1ATLNPHc38fSV/Jnz3g7PVwFH+DSSnkvMaCiGMlmRu0RfiakdMxeNLRgnaAP2Prx3OZ4AI91nikoMNDcfXPS8Rlqf5hURI4ihqViu/1Svo+tZukbjvxJ6arFur9WnIkj0wbXH1cOYiZHRBajJ+O73hYuw6m4gNnPy2l9lVYSXGeBuzc8w= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e594da89-50a8-4a29-24b3-08ddca89da6d X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4320.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2025 08:12:38.3739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hGTbhjoOggT1h9wx7TQl8eQx+wPr20s5/TBaA2+LQ57EZRfDeE+HIyUQrWcjqSdYf/FloG+lfhqSvpcUJb1EVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4815 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-24_01,2025-07-23_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 phishscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2507240058 X-Proofpoint-GUID: Z4DtWBtfNy5YEHKa8slklX5d2nTg-NSw X-Proofpoint-ORIG-GUID: Z4DtWBtfNy5YEHKa8slklX5d2nTg-NSw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI0MDA1OCBTYWx0ZWRfX3bNe6cl4rggT rzwkZYCLwsXYGpVaI69ovvl0FWvrPTicTVbGghHuH2nmg8KKu8a4dZqAlnSouwvyd5ZI6jf1BfV zMboAmff7Qlmos47E8t8zHBAyISAy5LRKz7QsbMXLs4h13oiR95fBMcj/F9pZ5h+eEPG8D6WT0F wloEDaEFthyLqD+P82VgS6Jah57SoWAz85ZyyzkKJ0NAyahbVOzgnC7ipQNOJ8/zQvu2ypYcUtX 9XJCS31pN6vRBKf74XYhoFHAlT9l7uHGnITX5pjDnUUkoyJ/Ro1fsO3gh7LlfvIMyq/moQEiVoj c/KeUWxzAH6m/4XEuIbMaGIRQJIhwhpP9AbcNGf/aXO6LN3EH2lXJtXuDwvMS08OBfwQlA2ZFpI dC1WzkiAWowQY1w9QRwCvayQmWeAJ3phqmViEA+JtDR/+clsc6JhdB3/ZZwdWxkBGuDrsHKR X-Authority-Analysis: v=2.4 cv=IPoCChvG c=1 sm=1 tr=0 ts=6881eafa cx=c_pps a=OOZaFjgC48PWsiFpTAqLcw==:117 a=OOZaFjgC48PWsiFpTAqLcw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=yPCof4ZbAAAA:8 a=gOl9iw8zJ5YvPalRciMA:9 Content-Type: text/plain; charset="utf-8" Atomic writes are not currently supported for DAX, but two problems exist: - we may go down DAX write path for IOCB_ATOMIC, which does not handle IOCB_ATOMIC properly - we report non-zero atomic write limits in statx (for DAX inodes) We may want atomic writes support on DAX in future, but just disallow for now. For this, ensure when IOCB_ATOMIC is set that we check the write size versus the atomic write min and max before branching off to the DAX write path. This is not strictly required for DAX, as we should not get this far in the write path as FMODE_CAN_ATOMIC_WRITE should not be set. In addition, due to reflink being supported for DAX, we automatically get CoW-based atomic writes support being advertised. Remedy this by disallowing atomic writes for a DAX inode for both sw and hw modes. Reported-by: Darrick J. Wong Fixes: 9dffc58f2384 ("xfs: update atomic write limits") Reviewed-by: Darrick J. Wong Signed-off-by: John Garry --- fs/xfs/xfs_file.c | 6 +++--- fs/xfs/xfs_inode.h | 11 +++++++++++ fs/xfs/xfs_iops.c | 5 +++-- 3 files changed, 17 insertions(+), 5 deletions(-) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index ed69a65f56d7..979abcb25bc7 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -1099,9 +1099,6 @@ xfs_file_write_iter( if (xfs_is_shutdown(ip->i_mount)) return -EIO; =20 - if (IS_DAX(inode)) - return xfs_file_dax_write(iocb, from); - if (iocb->ki_flags & IOCB_ATOMIC) { if (ocount < xfs_get_atomic_write_min(ip)) return -EINVAL; @@ -1114,6 +1111,9 @@ xfs_file_write_iter( return ret; } =20 + if (IS_DAX(inode)) + return xfs_file_dax_write(iocb, from); + if (iocb->ki_flags & IOCB_DIRECT) { /* * Allow a directio write to fall back to a buffered diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h index 07fbdcc4cbf5..bd6d33557194 100644 --- a/fs/xfs/xfs_inode.h +++ b/fs/xfs/xfs_inode.h @@ -358,9 +358,20 @@ static inline bool xfs_inode_has_bigrtalloc(const stru= ct xfs_inode *ip) =20 static inline bool xfs_inode_can_hw_atomic_write(const struct xfs_inode *i= p) { + if (IS_DAX(VFS_IC(ip))) + return false; + return xfs_inode_buftarg(ip)->bt_awu_max > 0; } =20 +static inline bool xfs_inode_can_sw_atomic_write(const struct xfs_inode *i= p) +{ + if (IS_DAX(VFS_IC(ip))) + return false; + + return xfs_can_sw_atomic_write(ip->i_mount); +} + /* * In-core inode flags. */ diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index 149b5460fbfd..603effabe1ee 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c @@ -616,7 +616,8 @@ xfs_get_atomic_write_min( * write of exactly one single fsblock if the bdev will make that * guarantee for us. */ - if (xfs_inode_can_hw_atomic_write(ip) || xfs_can_sw_atomic_write(mp)) + if (xfs_inode_can_hw_atomic_write(ip) || + xfs_inode_can_sw_atomic_write(ip)) return mp->m_sb.sb_blocksize; =20 return 0; @@ -633,7 +634,7 @@ xfs_get_atomic_write_max( * write of exactly one single fsblock if the bdev will make that * guarantee for us. */ - if (!xfs_can_sw_atomic_write(mp)) { + if (!xfs_inode_can_sw_atomic_write(ip)) { if (xfs_inode_can_hw_atomic_write(ip)) return mp->m_sb.sb_blocksize; return 0; --=20 2.43.5 From nobody Mon Oct 6 06:29:00 2025 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13603274B23; Thu, 24 Jul 2025 08:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753344778; cv=fail; b=fVbbASTMHH/1hjm8y4h5RIShcgeMpYoWzAHwtERIDyoAlcfPgntIPb2kL3xnTMrp/BNfiudH0Dcgu+H+6W2mwhnA6PvpfTrv2y0zHNBgB/whABVmCDQTFazL8K3EE1M+l9UcNdVougmyBod9hnTSTTzpO1mCM675MVQSQMUeFZM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753344778; c=relaxed/simple; bh=xQWNenkyiOLhyYZH7o0KINx6UDNUk856xSDa5DITotc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=EQXkoXaTY/TXv40zSXyugQ+/BhPXvrNVSF0NIjmtJS8bjbKr9AuPaCICTLDNNp3CILhbzTcvERHGxJ89LEc0qTYtpbgUXTAgYkLzrUJKQFbq/YloaMAeZiMs/7soXBWKQS1ErTX6Mr9gi0uRxuyrtSVxwm4v07gNKQOKO6B13Zs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=CY4AXXqQ; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=spgP6ff+; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="CY4AXXqQ"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="spgP6ff+" Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56O6ukIM030721; Thu, 24 Jul 2025 08:12:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=xVQDAxQk6vDhayhbOTBkErCq+ReYNqcVAD/lg1BhNik=; b= CY4AXXqQ1jc28UhxdPMdVRgkSXr5ydhwYYkws2RFwgC2+/vwj3qCcCNPuHP3FlO7 ezf2WNjp3Jev9wjnHQpR9gglSGd9/tEOHaJ5Ko6l6Um5pJ15ixJ8cKIAXp6pI6uW 0L35BmHpn8ufbtLmIBL4HOEdMrlBcimdWKOPoBEIVaITAjIzzIjk+9mbv9Qz12v1 5LH8QHZan/tGIoxlGaAmLKeuoJeFWgUQOophsRbhWN3yK3B3wfmCrlp5yhcChw62 okkRyQuhU4y6huA4Yh9XtBJwyDPcHnKKFgfMtpN9jKimxsJkIYprrKllqFFn8DVL FqK+HXZUC5OTM1MTspsADg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 482cwhujhm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jul 2025 08:12:44 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 56O7swhu014382; Thu, 24 Jul 2025 08:12:43 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10on2068.outbound.protection.outlook.com [40.107.92.68]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4801thw53c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jul 2025 08:12:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gLXG0eOKwxeK60GM7mAW8vKcMbAHBpvBdzoDQyZz2bJ7qJVPzAAk84DGHhj2BwU+a6YAL02TDGJIZLwWvexZ0Nz2pyqzoKCLlx9PEZnjxg06xgI2xxEBjLSEubwnsjLusZ47u1fCzJhOd36+oDooRhhL85eOe9VnVGCqpzHCcBJLFeQMdwgKdf4+qpwcCxsjr3yLY5Ed4lyuZW6f6GgytwBDrPFGKp37FlZ5/7/lcRYAI5XpBMmOuhmaJ3Z2lShJT6DYj/6C0Kr9OclG3J3H8FStb7tYc7acwldLXJ9jSsSKVlboJn4CB7rBWylnjWoa6+R3k0U29mR9Oe7ij1tc1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xVQDAxQk6vDhayhbOTBkErCq+ReYNqcVAD/lg1BhNik=; b=HhtJdUXoEujsVCUWfB7O5GFUfl6/MXk3SPCHIV9qQ9bwdbJERsk4jEe73ZbMQXfZJu0dvNWUTD8XEKVQw4hL/fi8lNPNU4ALDHoHt8ii5MejOSzklqcz+waNp5heliuyShjEcVTzLNe6TBoz1qynjWkQJvtYkgCswKPjLO3KnZ1Fmb7KU28ZW71TJvy+M3KbcRNoDaXzJQOps0d78sz83VigMrUTy8Us7ZXWGYKKzW+JbNGHWmn69Yga50ZIgjJ6sUEmXhBkvcQwbG/55aXsgb2Bzkzp/vG4vrLLOFlVemPda6LkDINJaZPslK8yfUbiovK5MVgezxkLFvXHZlIYdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xVQDAxQk6vDhayhbOTBkErCq+ReYNqcVAD/lg1BhNik=; b=spgP6ff+iN7Arpyf5s1gofWFp6LMbiVsHn2FPYq198r2Cr2bIQJUQnId+ddUlKIjSl2gxbDWEuXg33/FoF6VBrGpG7kCcgiA43HYxkHaJj2OLgYza0kVqsq4IOnje6qXuHklZcsHLY2sF7lNQ1LLPiUHv+DZDFz1fFU+bp46/fw= Received: from MN2PR10MB4320.namprd10.prod.outlook.com (2603:10b6:208:1d5::16) by SJ0PR10MB4815.namprd10.prod.outlook.com (2603:10b6:a03:2da::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8964.21; Thu, 24 Jul 2025 08:12:40 +0000 Received: from MN2PR10MB4320.namprd10.prod.outlook.com ([fe80::42ec:1d58:8ba8:800c]) by MN2PR10MB4320.namprd10.prod.outlook.com ([fe80::42ec:1d58:8ba8:800c%7]) with mapi id 15.20.8964.019; Thu, 24 Jul 2025 08:12:40 +0000 From: John Garry To: djwong@kernel.org, hch@lst.de, cem@kernel.org, dan.j.williams@intel.com, willy@infradead.org, jack@suse.cz, brauner@kernel.org, viro@zeniv.linux.org.uk Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, John Garry Subject: [PATCH v3 3/3] xfs: reject max_atomic_write mount option for no reflink Date: Thu, 24 Jul 2025 08:12:15 +0000 Message-ID: <20250724081215.3943871-4-john.g.garry@oracle.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20250724081215.3943871-1-john.g.garry@oracle.com> References: <20250724081215.3943871-1-john.g.garry@oracle.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PH7PR13CA0006.namprd13.prod.outlook.com (2603:10b6:510:174::19) To MN2PR10MB4320.namprd10.prod.outlook.com (2603:10b6:208:1d5::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB4320:EE_|SJ0PR10MB4815:EE_ X-MS-Office365-Filtering-Correlation-Id: 51d9ad04-245d-4653-4cad-08ddca89dbd5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0Hhhza6gemqNxP+121F/viNooOf3HENp2DcHHs2kbnlYOuOxf+sbeWw9FfK0?= =?us-ascii?Q?tMUefknPiP6szYSwLEV7VWAZXCZ+ArAJsBCoYQU1h4DiINo/7VE24xnrxWA6?= =?us-ascii?Q?2qGjau2D8cc0EReXFKIELNY0XMVhaRogRIex7HCaADpuFCTWq6cI7hf/MwkK?= =?us-ascii?Q?ghYz6WbN0JvUvhhB2GIbdUfD5eiPbLYltScDaA2LfsXfVX99Hud14j0DNDCB?= =?us-ascii?Q?oPjSEHWmyItfy8RGUf4xxV9WLVwZH6QG9oON+j5/eQ2lMTSjtD/UYk9Xu8QS?= =?us-ascii?Q?+EpPvcjy01MMr6C9+40cf/8ETkQb2ruJ8BfYQQHLlWIAa9IvBkGz99owi3pG?= =?us-ascii?Q?b4qPyqJEvqVjiEkTak/4F5ZAOnsmWg+6A4m5hjcHqzYFjHy3DX16xlwhJor7?= =?us-ascii?Q?T90GVmNXiR+ViDBoa8a6zXfwWvrllV20AubSWPNY6rxv8ecCKgs2NGmn4bRF?= =?us-ascii?Q?9OevdKXSsmwpGiRL529azV1umeyufEH0m2zpRkfz63wqlm20YQ+7XsgNIFAq?= =?us-ascii?Q?TT3eORLTtCDyk+GJJZw+JIwXnRMdhseH7nZSgKa9IdHUkCIcV7C14dJYraLp?= =?us-ascii?Q?BeUEa7jgHYbhvPospEPejv0S6aPpv/47lDaqFV88AlFauTcFbiL+ura0ZXV1?= =?us-ascii?Q?NRYEXsxl94/knyXNPudmkZU345zOoVJ7cCFfIoJBxgqCA0X9QOfZ8FDzT6SR?= =?us-ascii?Q?UkJmsVjXhMV8IMXguQgrWrZNmiXjxEK+bnQtD1v6XVKKpVg+DIu2Z0sxpT/+?= =?us-ascii?Q?5NbzAOAAylMfJAYKzkI39vdp2kx23EDd2xHksV+VnnG1Dk8ItRwNtBkpYUeS?= =?us-ascii?Q?unPBQKI1da6d1eBS1zRcAKLriX+srDOkmong7an9+r9Vt+tyuFUgPzBY2Qkz?= =?us-ascii?Q?g5DA2Ixb2lDyZOs7aLGUqEtI6XGpH2fBnM9XHpjpotIYfpukRvFN/poun379?= =?us-ascii?Q?v/4sKEeYzbP4MuhawCF80aQT4qQ2oULt92Fw0JSiK/yzNh9i+Xw9+Gk18KON?= =?us-ascii?Q?oljaxrNfl4FfZqHLopEFz8uJo+gEgYFOGTHmCkRbjH7G6ssnUn56hSVs61Xn?= =?us-ascii?Q?UTj8NQEXGEqmvuadR1FfLGAkP+8RGs2CwEmAsjIHEiFagPBCRuBNOsMPs8q5?= =?us-ascii?Q?w5SFCVukjLbDUXDEDpI9GciFlVBTEqoXbo/I1Vquc+T6MuICWrVECE1XLXUm?= =?us-ascii?Q?JPnFNbr0qvbunRYIPPzKdrnVxeBXZLmboBNiFNv98VgC997NaMfLZZDFQTG0?= =?us-ascii?Q?6L1z7kd2buPKJrZzexeN33riv+nvUyyChPxDdEG2GAVNbO3UFDVL5b08B8JS?= =?us-ascii?Q?uyHgHpyLOIk+TLp5FwKblQYh3YdvcEyhXOAehI4/aHqJBd6EKdiov0VyTVEE?= =?us-ascii?Q?BINn8rGdgPeOhAv0D0CuRezCL93bHjqZxWf22f5wzxi6MvGSoRQyl1j42Xkn?= =?us-ascii?Q?KJGU/sY0K5I=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB4320.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aIyF7HtX3cV9vcv/L7Z0RJXZQ8rZJ+M0XBsmz+guChr5Dt9o5n60dVZleWs0?= =?us-ascii?Q?aBa1olFhIZuchrbyU27IBMs4Zy4DHmD51uylHhdsr6yq8QI8NQx1xqdr/P2/?= =?us-ascii?Q?xcwwjlypGAt/nYDLUQK/QoL0FcSvoYc1PjI0JZbYhvgJpoeL2lib3ZiLzYDn?= =?us-ascii?Q?FKmKEOv8Wa+bs+hltwSskL7fSpioJcqatKWF3Jou83DfRT+qsisYrEIcXRnk?= =?us-ascii?Q?qv2f7ylkKCR/EnndTifnjBtN9K2xfoUgTNzsSlevkiDTsoG5y66kYlg4AEVn?= =?us-ascii?Q?UoXNHzWlAiB/vm1tW+svbMxEhPC9f+iSwoLy+IcYDPFQMchf2YfOXXnrfj5z?= =?us-ascii?Q?a3QXk8PN43Bl37CNfSALaxrrUFZ6K1IAzF4XnRvPlS2o8R1Tb4ikeD9Rf3Te?= =?us-ascii?Q?iLE6+hyu36tSFNe1mO3DnIsWuVxXJqD4PijIjFI6vSYbuSjRHSq3xYHIvdlo?= =?us-ascii?Q?cQ1DgfqURPk2VPl54IDQ186xDU9ETCrmIQ04q7p+oj/eHm+23ILcb5JmYNf0?= =?us-ascii?Q?CLlwKJPLBY2Gp35+ivDHQRQrIpvAQdXo33ETxKfJlSqQOHpCGI274YN2HA5Y?= =?us-ascii?Q?6cb8XUSlnSrsiIxJBKtu88lxdEkao7KpK69StKrk/8p5twUZExg869CPtgKj?= =?us-ascii?Q?rIFCjr/XzXbkRid4cHvURUiY2oItBOZoYSSL56dq+rxh6A8AaU9YP99yCTGF?= =?us-ascii?Q?c4jZ9RKtXv/lnzAPvKkdzJVnazD1NpszqODCbHB7KzCdPcYybuNpkFHY36dy?= =?us-ascii?Q?GZ53orLYb9YuJddqvAwIotKBPUQKsy39JLFnBnpzt/Gzjs9YadFSUnDDNdQv?= =?us-ascii?Q?/pO//nAZ6rHgmN0D33Yn9hDnZorMGhta7vOAkMzzEo92SIVmXdAQ1/MX0Rp1?= =?us-ascii?Q?xprj0/wBYNsBNo8SdJvy2HGGUIgboAdszDLCkJVbSzkaV65QY+Izh5OaAaje?= =?us-ascii?Q?EEsp22OH4CZhiUTfAV7sMSLPxloZ9vM/yB/mmiz9JQXIsdIxqu1gFmwI38dO?= =?us-ascii?Q?9Y799MzFpe+2gbQas7YZ4jBCT7Ra0KDjPJbd6Nf5BrU8sM0jKFnmNTPmd0Y5?= =?us-ascii?Q?kEHq5XMmPkpe4XefPpPVAJ/QEs1FrIHRUNTnN1xcJzxY0OG9siQ/TSnoOpU1?= =?us-ascii?Q?PWqvm3LgM8ittYemkZBn325fgNEjA2hym1Fdc/9NX4KzrIUiRiBM7QWzae88?= =?us-ascii?Q?h/FaLBbjY53M9oSs0MxlRLb9ylnZl4I7BoLyOTC4x7JEcYzO/DZalz++f502?= =?us-ascii?Q?C3aqjNekFIG9fL+agG6PNwONC8JFxX6kBAwCePz5bB/lTf9YoYesla9F+P1K?= =?us-ascii?Q?NAl2mhuBVLT1YbW8AY6Gn1uWvahk5bSiioz2zwh7OKJED7F/WSyqOaXa/s9r?= =?us-ascii?Q?8nhHSOkjepta/hvTOm0HsQVogOvnsmuZwk3LeqvS4OR+3yrnDZbfFxq4ocxL?= =?us-ascii?Q?0YJq3bgGvq3BRNc3GwAyJQjhHd94Iewi++09Q4icvgnm9cVuow6If8f1U+GC?= =?us-ascii?Q?89rFruWetkl/YgzD87OmUt6Ma+QrNnSqfTs2NqFJCYDqG2xPDoByIFbspWZQ?= =?us-ascii?Q?AG6p0xjR1WSwhdcIopi2uNrj3MfGGPrO4IZy09mu7WqyYGSE6jBKC0Kfjc+o?= =?us-ascii?Q?IQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: sHcmZrK3uPbKA1ID/8Sp6Q+F7obyQ9Xr6xC4bEdrBJ7ElrJY8JlKCCUQst+f8csItf+qk9hZX+L9SeXl5ALakdQ+huLUhpZabpebnPEYG4QtTnfr2KH+00qa9qQ1rNYuk7rs++AXI+FipM4L4DizbjEJVNWiA860WvOTjv+GWX8MDd5MrpRMvvaD+VyLq5Ifb5rQyilI6cTwKw6HItHxxSms7evWm8qdunLc2YBeq/fNsSSGiS8KXMJgCr+0z9j9xPeXkCSIYJcQLfjQ9z/mrNO7F2yR3tWqYGYzSLyDpdvMN07HTfzrr2WWKDr0mSHrPqps8hB0k/0Mqgjg60sX6RM6IAj2opPbIJj3HnETie6lZKZiGxe/ElO2TjT0kTytobiLy+aQDwvQFOgdDRTkIvOmvFdfT/5OHbAU+EZ9Su/ebrJWpiTzLeZACnz4h19QTiNW11Ypa9R8WEmXV0N6nBnAppoq9NodGXoj74w9nkU7EtwAV2gtj8T0KAMb2Amv1i7TTx+ONhIRIbGj1QU2w9VIZ5o9spc9CV7ALEhFpOlCkD7xpuMTadLMN0ZBfuPRW8aASwxsDDyL8VVm4uPzFIPKWvxp4M+dIV0o3H5a0dU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51d9ad04-245d-4653-4cad-08ddca89dbd5 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4320.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2025 08:12:40.5568 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y+oHT0PohPPYOwMJVSi3zP6wLQPU3KQXnwAe9KZARfxF+Yr2a071n/7xsw1/NPen0jxREXS9+x5281Z7veZZ7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4815 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-24_01,2025-07-23_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2507240058 X-Proofpoint-GUID: 51o-2ZTNwQUCZhb0CST_BVG6CE1mnV2r X-Proofpoint-ORIG-GUID: 51o-2ZTNwQUCZhb0CST_BVG6CE1mnV2r X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI0MDA1OCBTYWx0ZWRfX7IaH59+nCa8M K12K6uX4KwgNcZU7pkCANZ3Zgw97yOBouarWdHODmOiqqWch3XuttsTxlqxMBiNxYdplNouMlk4 +gWfmXuMFjKg7vkWUBqn0hwFfar0ub/v9To567kdLEz9I26dIhsyELquIdAV7FbxUC5RG9tLQX8 wf5t1ZqdwdYR0nYnNPJHbZULf+wwAAHwrC7hfDgM4i3S07UXaYB2iUEinC8BX3qww5UK9rgJraJ RCwaofE5xyJzz6mu6VWQePnt/flX42nZjvjP4QFMPInbOLImW/3dIXZVUTQgR3s6B+o3nN2k3YM KiBR6YSGzRfF5fWhTHhnFHU42LK2PWDzYKXU2E9tXPCcOqBhPP90ZQjMo5tAgaqSuO9gfbfUGyO 2cY8gSOXVcyhDo09qLPlIvqGXbHtJfOoL1vGNZNVaegeoOmwt2FCSJc2AfaaUze5YDkoGmH6 X-Authority-Analysis: v=2.4 cv=IPoCChvG c=1 sm=1 tr=0 ts=6881eafc b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=GoEa3M9JfhUA:10 a=yPCof4ZbAAAA:8 a=qHfuuy2_jPFloYaPpNEA:9 cc=ntf awl=host:12061 Content-Type: text/plain; charset="utf-8" If the FS has no reflink, then atomic writes greater than 1x block are not supported. As such, for no reflink it is pointless to accept setting max_atomic_write when it cannot be supported, so reject max_atomic_write mount option in this case. It could be still possible to accept max_atomic_write option of size 1x block if HW atomics are supported, so check for this specifically. Fixes: 4528b9052731 ("xfs: allow sysadmins to specify a maximum atomic writ= e limit at mount time") Signed-off-by: John Garry Reviewed-by: "Darrick J. Wong" --- fs/xfs/xfs_mount.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index 0b690bc119d7..1ec70f4e57b4 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c @@ -784,6 +784,25 @@ xfs_set_max_atomic_write_opt( return -EINVAL; } =20 + if (xfs_has_reflink(mp)) + goto set_limit; + + if (new_max_fsbs =3D=3D 1) { + if (mp->m_ddev_targp->bt_awu_max || + (mp->m_rtdev_targp && mp->m_rtdev_targp->bt_awu_max)) { + } else { + xfs_warn(mp, + "cannot support atomic writes of size %lluk with no reflink or HW support= ", + new_max_bytes >> 10); + return -EINVAL; + } + } else { + xfs_warn(mp, + "cannot support atomic writes of size %lluk with no reflink support", + new_max_bytes >> 10); + return -EINVAL; + } + set_limit: error =3D xfs_calc_atomic_write_reservation(mp, new_max_fsbs); if (error) { --=20 2.43.5