From nobody Mon Oct 6 06:32:11 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E18BD1F3FF8 for ; Thu, 24 Jul 2025 07:20:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753341656; cv=none; b=pYfcbNrhHn+wFib0wELl5ONroaL871OSe8d/vPPKSfmYmWFoKWPXYMiq/+r5KOSBpv3Pojp1YBFyzQrhlveSX2gooTGRMY4XQwsBx9FtNjvcT29LzspBpib0rtjLsdV/P6fdAawfs0YkofjngzXH4ZedpDqqgexPPrLGSEKOGM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753341656; c=relaxed/simple; bh=4NHFOrnlJxQrpWKVDw/v6IQ1txu4TtPqma6pCCMo7x0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bQ/gBD8zbGW7SXep9MUQfmwrR4+H6WFqih8VFv2IO2jwW/8vE49bWwNvSBgpNQoKdoYKpvh8A0hvlFp0udAGqD5+dfSX8CqlwQRpNv9FGXRzxhJR80ub5bBX7Zmx8AECU43xv2pVW2e4gDdyRDQnHtjrviz+rY6AgPAQsBIqpLs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=hammernet.be; spf=fail smtp.mailfrom=hammernet.be; dkim=pass (2048-bit key) header.d=hammernet-be.20230601.gappssmtp.com header.i=@hammernet-be.20230601.gappssmtp.com header.b=s8jNm+X1; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=hammernet.be Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=hammernet.be Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hammernet-be.20230601.gappssmtp.com header.i=@hammernet-be.20230601.gappssmtp.com header.b="s8jNm+X1" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3a6e8b1fa37so498315f8f.2 for ; Thu, 24 Jul 2025 00:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hammernet-be.20230601.gappssmtp.com; s=20230601; t=1753341652; x=1753946452; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=S6sDyX31bMtEXVDsFLGoanfMyP7wfjYxyF/aDso/gRs=; b=s8jNm+X1lhGTKwKpyoL2ZYDc2ZfEldwQCKHTBf/VTBLPW3cs6UNLK5FzJELejo2c7Y OT7vKjw/h6BPBpJlE7GpFPV8exrOBCv2wfdQDv4FE7xg0XeR4+PBMsa8Q3Qc4ar7fEgL ltWXoSNji4J3RJpn3EoBYAD2pMJYlncIIBYrCqu45lzxe8AeFjtt2hmNIXNDqLc8FdxO hU1/6oDZKyh3GLaKIihVy4tm+vk1tdjZ5fDgEpaYcukPha/VQhAMCMri8EyWsLVjkQnj wYPYeUU7mZ0WEHoXEEHJ1ROmSXF12bbhfcHlEHSLc4vMqk4DUQjUnuX0JZtpSdfZ08kR azuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753341652; x=1753946452; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S6sDyX31bMtEXVDsFLGoanfMyP7wfjYxyF/aDso/gRs=; b=GV8lBR9tDWHNLUpJVSqWne7MwN7FSUbYnO4l1n22njN4EjQh6vIDETb40I2+t/TWBz WRcPirZ2B0QqgQdot94JLE7305qOb0J8N+U3tI0uougJzcat+yR/Gt15d0BSrtK+zFKr sOMYYOFGGsQ1CEX6vUR781a+eI0eOc7wtTcTdyIGVyXin/GtWg5ii4M1Bs1S/yqVT1N5 4wrsx7e2Ka3W04SUNNWs80/yJ6ZXIM0yMXg99pxugR8CZxENP9MBue6VnirVhZKJwpmY 1SBfq5CxjJ/KvQJfn/5t5/fbYx33vAUZUGNOdvVyDCVFtqsXHpg9+mKkxzWwCWYyc7Yi 53AA== X-Forwarded-Encrypted: i=1; AJvYcCWNFPbD+qaIL70JGYw3q2ueg/qaFMw1mLrWcel1r/vzTqkWQPy3IYauDb2SYkZvBgg4mFLDwZjwJ+FC5YU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx355533EH7X4vsQhvwHDKyz1YkRJYcCofyUi1tdDsKFfXjTeGz kJEC2TCMCDuAQrRvqETN2YQKbk9aeuc0Ov3mN8seUyDmx8PrbPCJiZe9UsC9rnlxSdM= X-Gm-Gg: ASbGncszdMmY79gWB+IPSeExyXH2g80aDFvDPwt+qeORC+9w7qrmypR2tzYYWfJkn8/ +ELs8tVHLcCIleKyY0/SoFaRl0wZSaZPKAEz13q2KtIm9zXSFAUzm3+O9upjU+Njeo+QFhU1pYY mYqUB6lrKDfCaNNQqrwu2OPZY/ueYwCwvi7ePx/hZzzLDEwGwEfrCDnWW3v2QHfHGYk1UiZ3VXL FN/cqUtGuVESIgFCUPeg01EseLY7YMP5XaonfBXs6V5cbQWbZ7yTD4atKDGZgB8duHK+gGkAGSu X400sv6j/ggyS2INv8i12B0Ak6GxqA1F7G1rwUTfkEM97FtUedzKbFE8ufMeGhhmgu6JnnT48Ey 45COfcMiH7SJh+AVpc+/4AY8gDXdQknpdXHU70D4NThdnoPaULg== X-Google-Smtp-Source: AGHT+IGtoPxWfQ+wEpGjs7bUDWFQ1oeDB2sB8phuc/KoP2/+fvLeJ4l89nxhivkNTcUZ5qQxIwrrZw== X-Received: by 2002:a5d:64e1:0:b0:3a4:bfda:1e9 with SMTP id ffacd0b85a97d-3b768f079a1mr5008877f8f.46.1753341651795; Thu, 24 Jul 2025 00:20:51 -0700 (PDT) Received: from pop-os.telenet.be ([2a02:1807:2a00:3400:871b:95ed:fb39:f517]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b76fc6d32dsm1253844f8f.24.2025.07.24.00.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jul 2025 00:20:51 -0700 (PDT) From: Hendrik Hamerlinck To: dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, joe@perches.com, corbet@lwn.net, apw@canonical.com Cc: skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, workflows@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Hendrik Hamerlinck Subject: [PATCH] checkpatch: validate commit tag ordering Date: Thu, 24 Jul 2025 09:20:32 +0200 Message-ID: <20250724072032.118554-1-hendrik.hamerlinck@hammernet.be> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Modified the checkpatch script to ensure that commit tags (e.g., Signed-off-by, Reviewed-by, Acked-by, Tested-by, etc.) appear in the correct order according to kernel conventions [1]. checkpatch.pl will now emit a BAD_TAG_ORDER warning when tags are out of the expected sequence. Multiple tags of the same type are allowed, but they must also follow the order. 'Link:' tags in the changelog are still allowed before the tag sequence begins, but once the sequence has started, any 'Link:' tags must follow the ordered commit tags.=20 Link: https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#or= dering-of-commit-tags # [1] Signed-off-by: Hendrik Hamerlinck Reported-by: Dan Carpenter Reported-by: syzbot+4ba6272678aa468132c8@syzkaller.appspotmail.com Suggested-by trailer," so enforcing it in checkpatch seems like wasted effo= rt --- Documentation/dev-tools/checkpatch.rst | 6 ++++ scripts/checkpatch.pl | 40 ++++++++++++++++++++++++++ 2 files changed, 46 insertions(+) diff --git a/Documentation/dev-tools/checkpatch.rst b/Documentation/dev-too= ls/checkpatch.rst index 76bd0ddb0041..696b42bf4ff5 100644 --- a/Documentation/dev-tools/checkpatch.rst +++ b/Documentation/dev-tools/checkpatch.rst @@ -599,6 +599,12 @@ Commit message =20 See: https://www.kernel.org/doc/html/latest/process/submitting-patches= .html#describe-your-changes =20 + **BAD_TAG_ORDER** + The tags in the commit message are not in the correct order according = to + community conventions. Common tags like Signed-off-by, Reviewed-by, + Tested-by, Acked-by, Fixes, Cc, etc., should follow a standardized seq= uence. + + See: https://www.kernel.org/doc/html/latest/process/maintainer-tip.htm= l#ordering-of-commit-tags =20 Comparison style ---------------- diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 664f7b7a622c..267ec02de9ec 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -661,6 +661,24 @@ foreach my $entry (@link_tags) { } $link_tags_search =3D "(?:${link_tags_search})"; =20 +# Ordered commit tags +our @commit_tags =3D ( + "Fixes:", + "Reported-by:", + "Closes:", + "Originally-by:", + "Suggested-by:", + "Co-developed-by:", + "Signed-off-by:", + "Tested-by:", + "Reviewed-by", + "Acked-by:", + "Cc:", + "Link:" +); +our $commit_tag_pattern =3D join '|', map { quotemeta($_) } @commit_tags; +our $commit_tags_regex =3D qr{(?xi: ^\s*($commit_tag_pattern))}; + our $tracing_logging_tags =3D qr{(?xi: [=3D-]*> | <[=3D-]* | @@ -2712,6 +2730,8 @@ sub process { =20 my $checklicenseline =3D 1; =20 + my $last_matched_tag; + sanitise_line_reset(); my $line; foreach my $rawline (@rawlines) { @@ -3258,6 +3278,26 @@ sub process { } } =20 +# Check commit tags sorting + if (!$in_header_lines && $line =3D~ $commit_tags_regex) { + my $tag =3D $1; + my ($tag_index) =3D grep { lc($commit_tags[$_]) eq lc($tag) } 0..$#comm= it_tags; + + if ($last_matched_tag && + $last_matched_tag->{tag_index} > $tag_index) { + WARN("BAD_TAG_ORDER", + "Tag '$tag' is out of order. Should come before '$last_matched_ta= g->{tag}'\n" . $herecurr); + } + + # Allow link tags to occur before the commit tags + if (lc($tag) ne "link:" || defined $last_matched_tag) { + $last_matched_tag =3D { + tag =3D> $tag, + tag_index =3D> $tag_index, + }; + } + } + # Check email subject for common tools that don't need to be mentioned if ($in_header_lines && $line =3D~ /^Subject:.*\b(?:checkpatch|sparse|smatch)\b[^:]/i) { --=20 2.43.0