From nobody Mon Oct 6 06:46:44 2025 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40A9A2116F6 for ; Thu, 24 Jul 2025 18:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753383096; cv=none; b=DBSQNejb66RBrPxYGAfQBPqgArX1z3zA9q0SKLnYGW7wVg3Y3510Jfv5o/gW5ndlfj1bswfSqwZ0rg49aJhevojvPIDJwt1ukUP9NqowzWQ9Reg5t0hYOL7w3OodgIf/601D6o2e/9WyYSQUeXqOxNILY5eMdBTWsWv8HiomtC4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753383096; c=relaxed/simple; bh=ZZmsQxNSXVSlKbD4hblSWDN+9ZTkdbUjQl3Id3eEgog=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IulquPJLVTPe8FkYKDKaA2rf1w+pApafiTM61tz+WY7Kb4MIz7kNiMkTFQW8Q0S2s65GIgZsjOh1jPSp7Es5PKraTkAkrFJczGfTBtWrICkpzp+H5uITBcqlu68KRWiG+lp9+Tkl4b2u8uYkppDGp4mx/MZFlZ8gQuQ3DQqbCus= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=grimler.se; spf=pass smtp.mailfrom=grimler.se; dkim=pass (1024-bit key) header.d=grimler.se header.i=@grimler.se header.b=d+4z05Es; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=grimler.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=grimler.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=grimler.se header.i=@grimler.se header.b="d+4z05Es" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=grimler.se; s=key1; t=1753383091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8FW//f7wNjk6myGF7GHWZ1mveETa44O0KLrX1cwlSIQ=; b=d+4z05EsoHp3A9zKEA1xISr3Uhg6aDfhZ3gujhjXQgDbBUeb6Mh065VqRc0TmQF4uvJ2Bd O8R45M1hOq5nx8TIRubv26yf9GVIjFGKsMqJyvPNHZnoasS3lEtMHIKvCztrrc3nbYBoEU XRIMVtivAOpQd5yPxGuGyp9za7m9yAc= From: Henrik Grimler Date: Thu, 24 Jul 2025 20:50:52 +0200 Subject: [PATCH v2 2/3] drm/bridge: sii9234: use dev_err_probe where applicable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250724-exynos4-sii9234-driver-v2-2-faee244f1d40@grimler.se> References: <20250724-exynos4-sii9234-driver-v2-0-faee244f1d40@grimler.se> In-Reply-To: <20250724-exynos4-sii9234-driver-v2-0-faee244f1d40@grimler.se> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, replicant@osuosl.org, linux-kernel@vger.kernel.org, Henrik Grimler X-Developer-Signature: v=1; a=openpgp-sha256; l=2016; i=henrik@grimler.se; h=from:subject:message-id; bh=ZZmsQxNSXVSlKbD4hblSWDN+9ZTkdbUjQl3Id3eEgog=; b=owEBbQGS/pANAwAKAbAHbkkLcWFrAcsmYgBogoCmRmfOnqSJs0gNwRXGMh1B9WLaJnlt4ZUHi gR22U6FtyuJATMEAAEKAB0WIQQsfymul4kfZBmp4s2wB25JC3FhawUCaIKApgAKCRCwB25JC3Fh a+t1B/wNatsEVxbiPHGP5Kd8Ya1L8+tIjsXa6O0VnAUFeTgnSgjKrEA10zxUtQjOwU2riHYfF7/ iPV1voGFqnfSasDLb+PBd/5EoymKF1tszPsh1qdSykbk80Z/4/ghjHO5BDU3gk6f9YHzRbwOOca dvKknWOS0fLRTByvXAlo1cHdWVxAE/3eOyOZb5HWy40YHgUTHdPFkZ6KiIK3EZRTK2vjZF/rYdQ b0zW+tf9Ff1lic1GKwJyb8tJGvKkBFDppHQTybUH4XvlpIOow/zZStTpMKVKyGp7+d8IRcOVZGO UYrbv6REXX15BtEsBP946uEMiCRWiDMEqh05PrdLKLuRZ94y X-Developer-Key: i=henrik@grimler.se; a=openpgp; fpr=2C7F29AE97891F6419A9E2CDB0076E490B71616B X-Migadu-Flow: FLOW_OUT In case of error during resource acquisition the driver should print an error message only if it is not deferred probe. Use dev_err_probe helper to handle this, which will also record defer probe reason for debugging. Signed-off-by: Henrik Grimler --- v2: no changes --- drivers/gpu/drm/bridge/sii9234.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9= 234.c index 930117bbba87285e62107389606897740516eb0a..0e0bb1bf71fdcef788715cfd6fa= 158a6992def33 100644 --- a/drivers/gpu/drm/bridge/sii9234.c +++ b/drivers/gpu/drm/bridge/sii9234.c @@ -825,10 +825,9 @@ static int sii9234_init_resources(struct sii9234 *ctx, } =20 ctx->gpio_reset =3D devm_gpiod_get(ctx->dev, "reset", GPIOD_OUT_LOW); - if (IS_ERR(ctx->gpio_reset)) { - dev_err(ctx->dev, "failed to get reset gpio from DT\n"); - return PTR_ERR(ctx->gpio_reset); - } + if (IS_ERR(ctx->gpio_reset)) + return dev_err_probe(ctx->dev, PTR_ERR(ctx->gpio_reset), + "failed to get reset gpio from DT\n"); =20 ctx->supplies[0].supply =3D "avcc12"; ctx->supplies[1].supply =3D "avcc33"; @@ -836,9 +835,7 @@ static int sii9234_init_resources(struct sii9234 *ctx, ctx->supplies[3].supply =3D "cvcc12"; ret =3D devm_regulator_bulk_get(ctx->dev, 4, ctx->supplies); if (ret) { - if (ret !=3D -EPROBE_DEFER) - dev_err(ctx->dev, "regulator_bulk failed\n"); - return ret; + dev_err_probe(ctx->dev, ret, "regulator_bulk failed\n"); } =20 ctx->client[I2C_MHL] =3D client; @@ -911,10 +908,9 @@ static int sii9234_probe(struct i2c_client *client) sii9234_irq_thread, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "sii9234", ctx); - if (ret < 0) { - dev_err(dev, "failed to install IRQ handler\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, + "failed to install IRQ handler\n"); =20 ret =3D sii9234_init_resources(ctx, client); if (ret < 0) --=20 2.50.1