From nobody Mon Oct 6 08:25:33 2025 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57F372749D1 for ; Wed, 23 Jul 2025 23:23:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753312992; cv=none; b=NAU9xZ8hPcLGdfrZGQKFZUikzxLP82FLNsNT9PhLF6sXk3mRlgm4LSBkZ69c1twfe7Ioq0BYnUhe+iz7DWctVL0gqSEfjaIKNEd686u23qwOzbC+RCn4fE7Z1yHg1WfjHxNoBT8ulVsJkTKxdWirB2y6iFdQNhGZ51lEgqzSMHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753312992; c=relaxed/simple; bh=Vo6tbVjdJL4lzlTuKJJDRAwcz+98CMZF7SiPUqEkxLQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=pf1/fjHd7zc6qwjD4NqS45L3rlqGOiA+j673CokfNYdaUdfuRuZosNeFmB/YdinuU5ofeCMCMzBDZgnZLg62qttW2hHavpAL+y3AqnYPQ2gGxGtmTb5o1Yqz/rOP7/ff3JIkhaK2sMZHDo38jWR9iXdwm6a4d7KDlKvzM/HAzj0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=HfMyHg8A; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HfMyHg8A" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-b1ffc678adfso287553a12.0 for ; Wed, 23 Jul 2025 16:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1753312991; x=1753917791; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MrcDIPxORzR9yt+tgwZuFcuDMoj49Q8f2loh+BQfr6I=; b=HfMyHg8AnryrejuqlYZ3nvVg4UrDCPjxb0+3bYZZIZEJJJWcCj6LH8uy4cs47KrBx0 TthGBXS+dEUx1uwMUr9EFofSMZo4XIIN6meDTY0Bs2BglwJlgZITByy9vcSPJUJbU6Zb ekURDrV76YfSY+wQslBS14bIabRg5br15wQ5IyV3p+RAn/35qoe/YuoTYZaoD+hTCG6C 3vEA7rla9KgO3EFWGlS7lJlzc84tXfGVxoHZcYeM62Dnz2wKWyNwrQqkX/0Je4JH12K/ KAeSZ6Yijb4kaYi9mre4IU7JpgbRvYZknNMPMjDg8HkTsHAInFw0ONwKHjhUua+++63f +Dew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753312991; x=1753917791; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MrcDIPxORzR9yt+tgwZuFcuDMoj49Q8f2loh+BQfr6I=; b=unQMMpPKWj42RdHthcsvgk+VmuPQQPaiajcPJnuIPjFxnIb+9Y8iOZZbMclfIs9vW6 kYfN+Ln3BqydhkuSJRDW9FGlzg7rnJdfF2E9jl16eZHJZYh37AlYUww8wG0CMMk3nkGN bGqsaNckwO/OE7rlOslMjPSEACl82M+nI19SiuwI7hO7g8X78lr1iDc13CK5Auujwwwj crI1Z8wCwvAfHaQWo/L/Dmw/I4qHOh54wffcls8RG3P0Gem2vmW9Q0UAiKca6yXorSci B4odGLQQjQjNRNELXkqHdBHX4041Qq6DrEGq18uCzFGD4Q1j/cOPECpZ9dLIHQ3abcFr uuEg== X-Forwarded-Encrypted: i=1; AJvYcCUKF7ScPaTyf9Ya5I7KXVW/IXvB7go1+D6SlH++IRvzgLvLwPZ7jKHUJy9QLqSotbK2kuc6DRYpBHP28cM=@vger.kernel.org X-Gm-Message-State: AOJu0YxnVltTIjtI4fc17sK3LdBYs9+hZK1Hg1AvTpA0xVtCiadqYkXo /2LAi9NTcU9UWG36zu5glG83bVLyc+p6/OFghnDpXDp2f7chCxuOF7wcIQGtcOxfpLj4io+3g8n /RnlMnRc1gQ== X-Google-Smtp-Source: AGHT+IFDE+kBOJYEVOILaCtT1VmDeMx0V3Sfa2nJ010p8G2+kgJm6eS0vfB2ty7mGIzMy5/ZPafr7Cv05stm X-Received: from pjvf3.prod.google.com ([2002:a17:90a:da83:b0:312:ea08:fa64]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5483:b0:313:d79d:87eb with SMTP id 98e67ed59e1d1-31e50800129mr7366836a91.35.1753312990676; Wed, 23 Jul 2025 16:23:10 -0700 (PDT) Date: Wed, 23 Jul 2025 16:22:09 -0700 In-Reply-To: <20250723232217.516179-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250723232217.516179-1-irogers@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250723232217.516179-9-irogers@google.com> Subject: [PATCH v8 08/16] perf python: Improve the tracepoint function if no libtraceevent From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Xu Yang , "Masami Hiramatsu (Google)" , Collin Funk , Howard Chu , Weilin Wang , Andi Kleen , "Dr. David Alan Gilbert" , Thomas Richter , Tiezhu Yang , Gautam Menghani , Thomas Falcon , Chun-Tse Shao , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: Arnaldo Carvalho de Melo Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The tracepoint function just returns the tracepoint id, this doesn't require libtraceevent which is only used for parsing the event format data. Implement the function using the id function in tp_pmu. No current code in perf is using this, the previous code migrated to perf.parse_events, but it feels good to have less ifdef HAVE_LIBTRACEEVENT. Signed-off-by: Ian Rogers Tested-by: Arnaldo Carvalho de Melo --- tools/perf/util/python.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index 3affde0ad15a..9c9972d77d1e 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c @@ -18,6 +18,7 @@ #include "record.h" #include "strbuf.h" #include "thread_map.h" +#include "tp_pmu.h" #include "trace-event.h" #include "metricgroup.h" #include "mmap.h" @@ -1544,10 +1545,6 @@ static const struct perf_constant perf__constants[] = =3D { static PyObject *pyrf__tracepoint(struct pyrf_evsel *pevsel, PyObject *args, PyObject *kwargs) { -#ifndef HAVE_LIBTRACEEVENT - return NULL; -#else - struct tep_event *tp_format; static char *kwlist[] =3D { "sys", "name", NULL }; char *sys =3D NULL; char *name =3D NULL; @@ -1556,12 +1553,7 @@ static PyObject *pyrf__tracepoint(struct pyrf_evsel = *pevsel, &sys, &name)) return NULL; =20 - tp_format =3D trace_event__tp_format(sys, name); - if (IS_ERR(tp_format)) - return PyLong_FromLong(-1); - - return PyLong_FromLong(tp_format->id); -#endif // HAVE_LIBTRACEEVENT + return PyLong_FromLong(tp_pmu__id(sys, name)); } =20 static PyObject *pyrf_evsel__from_evsel(struct evsel *evsel) --=20 2.50.0.727.gbf7dc18ff4-goog