From nobody Mon Oct 6 08:25:33 2025 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C472275AFA for ; Wed, 23 Jul 2025 23:23:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753313030; cv=none; b=jaf6BqdTplK5atRCKOLtv58jfuEuOAy/SDk7pkJGMKD/QhuC5iLPJsCngMYvDk+3EUelwCrvwvpzowCVC29OOZ5C9VGrvnwVA+YjqmzejdPNWUC6rvLfFH4DmUPBxZYD/mQR8LTsRo1IAQmbTkyc0SQsOrAY5ls9ytC6YCqKw5A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753313030; c=relaxed/simple; bh=6qy4zQxJd9iObH44/TfA2kLJQsc7FZcMvNtC6t4qI70=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=KH6U3wNYYqII+HbyGkhtrDLY8tzv9GY7cNFFpBNui0vVDESF04S56gkBHdmaHer4gQeNrVnrCte8M3JkzvgKZLgvusaVSP40sjem57LQN9kE3L7SlX2kU4O/Hl8mgtElVxkYWH8XkC2deELaf7x0ZY5eYT1yz0F8RLxH3973Nww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ziQdxrP2; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ziQdxrP2" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-31366819969so293605a91.0 for ; Wed, 23 Jul 2025 16:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1753313028; x=1753917828; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=P7L/9iYbbAfbCiLjp07E+9VacBofe7FyIakYtK/wA24=; b=ziQdxrP2T/+6sfA55WalwgbnqecKPcn40+CsMLQI6NW95LdnALO42EQnorfelzWtOm YZxKLSPPeRY6GaqRRSGIeLiVgLhe5s630Hl1BheYsq4AoGxx6YGmBrQxSJz0I1Y2w4hh v10vNMitCMcpsdkNpUTO8TbaBDfti+erGqOS1e++JFEA+lbgBr6ZvxJIYGEluuEVdv+N cB/pF96llH35mPBOycfdFHGuXpTeFPYru4UtDwi6qSy4mi9tQC+MwakcWzjgU2dbxkMQ TMGRhLtvGCRM87UiZJ49zD2gt7voxWpZ8KPw5xsv3rQPUqSygbD+O5K1yMfB2/NDAvsN QSrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753313028; x=1753917828; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P7L/9iYbbAfbCiLjp07E+9VacBofe7FyIakYtK/wA24=; b=vaXEoXn4z42gx6iOSxC2qg9e2bwXygatTH05m4ORFoNXADD0jZ/yDOhY4m+lyq39h9 ozt4c0cIZvLYs94lf4EkRahxSXFZtxwJDk4tO5yV5nK1Xu6gADNr905+OEpYZeoCelHi /qPHLDzsz2flMOOx9LH8WezLfnGX3t4QkqGmRByi0rH0Q5rsSYmXl06CXAPo12E5QAYg BFSCLuONIkbHHiOwbVo8GDc1DfpOITgMR0iLqcyD2rpWJhbciJPi29/G2zh83SwsvNmo MpO84CHCuNREELr6P5UCM/Z7Eg7bmIzkPWBDKdLWYsZ9RFxTtryqFng5YHl97cvNvXV6 vUUA== X-Forwarded-Encrypted: i=1; AJvYcCWUjFqpe5TABT+XE99oRDAcJt1k46F7/jmJwVKisNoIOpKemmfCng6mwgqG5FPcGqT35eQmaNs9Q5BT/QY=@vger.kernel.org X-Gm-Message-State: AOJu0YxTpYNCffroTfWyU8VEKxQ8htRNN7gGJ2bngN5MeNXdLxn2AnGK L5ZC7pagLX2lyFrU4JaMvY8QSeTzBxVcnXXJ4dsWdq24FQGsB25W9dlbPQW6CkHpX8PXY4/J+0P 2+H8EDsgsAw== X-Google-Smtp-Source: AGHT+IE/D7PzYjCG9Zlx+Bga7Nh7Tq9VRp0u+XmJK7AFAItxnBwTSW1JYcGN5IoLTTGlCI8VUqfQw2yWYG2l X-Received: from pjbee12.prod.google.com ([2002:a17:90a:fc4c:b0:31c:2fe4:33b8]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2e0d:b0:31e:3bbc:e9e6 with SMTP id 98e67ed59e1d1-31e507e61a5mr7087139a91.19.1753313028432; Wed, 23 Jul 2025 16:23:48 -0700 (PDT) Date: Wed, 23 Jul 2025 16:22:16 -0700 In-Reply-To: <20250723232217.516179-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250723232217.516179-1-irogers@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250723232217.516179-16-irogers@google.com> Subject: [PATCH v8 15/16] perf python: Add metrics function From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Xu Yang , "Masami Hiramatsu (Google)" , Collin Funk , Howard Chu , Weilin Wang , Andi Kleen , "Dr. David Alan Gilbert" , Thomas Richter , Tiezhu Yang , Gautam Menghani , Thomas Falcon , Chun-Tse Shao , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: Arnaldo Carvalho de Melo Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The metrics function returns a list dictionaries describing metrics as strings mapping to strings, except for metric groups that are a string mapping to a list of strings. For example: ``` >>> import perf >>> perf.metrics()[0] {'MetricGroup': ['Power'], 'MetricName': 'C10_Pkg_Residency', 'PMU': 'default_core', 'MetricExpr': 'cstate_pkg@c10\\-residency@ / TSC', 'ScaleUnit': '100%', 'BriefDescription': 'C10 residency percent per packag= e'} ``` Signed-off-by: Ian Rogers Tested-by: Arnaldo Carvalho de Melo --- tools/perf/util/python.c | 83 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 83 insertions(+) diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index bee7c8a69bad..a8ba1379cf21 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c @@ -2073,7 +2073,90 @@ static PyObject *pyrf__parse_metrics(PyObject *self,= PyObject *args) return result; } =20 +static PyObject *pyrf__metrics_groups(const struct pmu_metric *pm) +{ + PyObject *groups =3D PyList_New(/*len=3D*/0); + const char *mg =3D pm->metric_group; + + if (!groups) + return NULL; + + while (mg) { + PyObject *val =3D NULL; + const char *sep =3D strchr(mg, ';'); + size_t len =3D sep ? (size_t)(sep - mg) : strlen(mg); + + if (len > 0) { + val =3D PyUnicode_FromStringAndSize(mg, len); + if (val) + PyList_Append(groups, val); + + Py_XDECREF(val); + } + mg =3D sep ? sep + 1 : NULL; + } + return groups; +} + +static int pyrf__metrics_cb(const struct pmu_metric *pm, + const struct pmu_metrics_table *table __maybe_unused, + void *vdata) +{ + PyObject *py_list =3D vdata; + PyObject *dict =3D PyDict_New(); + PyObject *key =3D dict ? PyUnicode_FromString("MetricGroup") : NULL; + PyObject *value =3D key ? pyrf__metrics_groups(pm) : NULL; + + if (!value || PyDict_SetItem(dict, key, value) !=3D 0) { + Py_XDECREF(key); + Py_XDECREF(value); + Py_XDECREF(dict); + return -ENOMEM; + } + + if (!add_to_dict(dict, "MetricName", pm->metric_name) || + !add_to_dict(dict, "PMU", pm->pmu) || + !add_to_dict(dict, "MetricExpr", pm->metric_expr) || + !add_to_dict(dict, "MetricThreshold", pm->metric_threshold) || + !add_to_dict(dict, "ScaleUnit", pm->unit) || + !add_to_dict(dict, "Compat", pm->compat) || + !add_to_dict(dict, "BriefDescription", pm->desc) || + !add_to_dict(dict, "PublicDescription", pm->long_desc) || + PyList_Append(py_list, dict) !=3D 0) { + Py_DECREF(dict); + return -ENOMEM; + } + Py_DECREF(dict); + return 0; +} + +static PyObject *pyrf__metrics(PyObject *self, PyObject *args) +{ + const struct pmu_metrics_table *table =3D pmu_metrics_table__find(); + PyObject *list =3D PyList_New(/*len=3D*/0); + int ret; + + if (!list) + return NULL; + + ret =3D pmu_metrics_table__for_each_metric(table, pyrf__metrics_cb, list); + if (ret) { + Py_DECREF(list); + errno =3D -ret; + PyErr_SetFromErrno(PyExc_OSError); + return NULL; + } + return list; +} + static PyMethodDef perf__methods[] =3D { + { + .ml_name =3D "metrics", + .ml_meth =3D (PyCFunction) pyrf__metrics, + .ml_flags =3D METH_NOARGS, + .ml_doc =3D PyDoc_STR( + "Returns a list of metrics represented as string values in dictionaries= .") + }, { .ml_name =3D "tracepoint", .ml_meth =3D (PyCFunction) pyrf__tracepoint, --=20 2.50.0.727.gbf7dc18ff4-goog