From nobody Mon Oct 6 08:23:13 2025 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB6C3283FF7 for ; Wed, 23 Jul 2025 10:02:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753264956; cv=none; b=BMiwB8nFABXJhI0Ayke8tpoBUSZyFpCsbY5K7t3CjA4DUZpGR4XTkEXJvexerEoVx3qZRK9U6Vamtwc84odIgsXycIQXqEYF2TBRbe7x5Kf6xBa1rJToLrCnrV+I/N53XalYhdcAD+8LR+x28JUR9JA87WoARNddvEFIbNsTiUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753264956; c=relaxed/simple; bh=dVNC3ShRwc9rraYqV1NZd7Qv0LqdAYPie3YmmaCJa10=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=plYWYlY9yyx2DQRw6l7EMTN6sJ7hdAutUv8A/31aTupRDWsgcVrO8iH05/8taeMpVBVW0lAwZ3XrKraTg0tZXinJLTJ0fxwCRLfMPgrEsBwGDnx1GgdBM/ciSuD0nPx/fT6oZauDeuiKECE3j/EJC1iRPHjxlk3C0Fg2B7Vt6IU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=LwNk8W8/; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LwNk8W8/" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E073DF06; Wed, 23 Jul 2025 12:01:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1753264914; bh=dVNC3ShRwc9rraYqV1NZd7Qv0LqdAYPie3YmmaCJa10=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=LwNk8W8/vE8k1ufkgq4T8LE0WquQYZBYxzEnaHEh0ukdbqh2IncvIs4jGy8fGLu/j TWi3rz+gkG9VomX3/R/+FKqmvwfZ5FfctDS2lU+yAEBK8Kvbm7KlGPBsCAei3DYl0o 4bpDBAS2XJVgYpT46I2JzQ1p7MiEYWY0IpJK/KZQ= From: Tomi Valkeinen Date: Wed, 23 Jul 2025 13:01:28 +0300 Subject: [PATCH 1/2] phy: cdns-dphy: Store hs_clk_rate and return it Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250723-cdns-dphy-hs-clk-rate-fix-v1-1-d4539d44cbe7@ideasonboard.com> References: <20250723-cdns-dphy-hs-clk-rate-fix-v1-0-d4539d44cbe7@ideasonboard.com> In-Reply-To: <20250723-cdns-dphy-hs-clk-rate-fix-v1-0-d4539d44cbe7@ideasonboard.com> To: Vinod Koul , Kishon Vijay Abraham I Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Parth Pancholi , Devarsh Thakkar , Francesco Dolcini , Tomi Valkeinen , Aradhya Bhatia , Jayesh Choudhary X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1463; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=dVNC3ShRwc9rraYqV1NZd7Qv0LqdAYPie3YmmaCJa10=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBogLM2ScIg+pul+KwrIVolm8pm4A+8750e3elZX p+uM4p6A7+JAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCaICzNgAKCRD6PaqMvJYe 9ZRAD/sG6tZeQJxjzmSEfufkletE6/L+9BXyM0XAKgiRFBVEVwAaVB29HqAAsgWIBCdIg5wNXog xl3gMmU1FwbeaAUr4Zww/NaVvWIOspQJrrZq0tvTiEGGvCgOfN2q6O3aI5LFdFj9OgEaPecblp1 us8rgSqmYRYjkivlDzeXNTzfLesqs5/NOG4u3K/cyWr7z9uU1thjywADA2mCZCm32Y3CIZjVkxs 7j3ZuuBI+VsCrVYyg2Ct54Pdos5qVlUIbS/ZhV7Jpfc0OJconlajYr5gYz/S87iKjfllkEXUoWD U8V8fS5yp055xxYAQxSugUv+zMfVv2oGZKUUk2IULoO8yp6gjnmK5LRIGkNPEZiZKCRVN8PvewV pxREnQQWd0gST319Cjv09703hYuDl3CAnE3HC1swQ5ao11ruDz+Bb7I3T9aWQYNkDXxdVcXE/aQ Pq551oFRsCGb6FaoPQlr9WizNiI6bcPJm3DtN+Zhl3inPX7XqoUMsNRpRjL18Q58yJgCeb+0KHz k6bU4toQTsBU3bd7ShVM7jm5TuM2Or6iEAY0GOj7hCJXD6YqxKJfXSByOTEg7jMaLDtF95867Pg HjSr2Oo2EaD46uGqWH/P+Eh0U/KnI9s+ifIrtrXzeFZlsY1C0LmiXdBe56tQ44dzCpmyS/RRIPq 252Xho0K+r24fNg== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 The DPHY driver does not return the actual hs_clk_rate, so the DSI driver has no idea what clock was actually achieved. Set the realized hs_clk_rate to the opts struct, so that the DSI driver gets it back. Reviewed-by: Aradhya Bhatia Tested-by: Parth Pancholi Tested-by: Jayesh Choudhary Acked-by: Vinod Koul Reviewed-by: Devarsh Thakkar Signed-off-by: Tomi Valkeinen --- drivers/phy/cadence/cdns-dphy.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dph= y.c index ed87a3970f83..f79ec4fab409 100644 --- a/drivers/phy/cadence/cdns-dphy.c +++ b/drivers/phy/cadence/cdns-dphy.c @@ -79,6 +79,7 @@ struct cdns_dphy_cfg { u8 pll_ipdiv; u8 pll_opdiv; u16 pll_fbdiv; + u32 hs_clk_rate; unsigned int nlanes; }; =20 @@ -154,6 +155,9 @@ static int cdns_dsi_get_dphy_pll_cfg(struct cdns_dphy *= dphy, cfg->pll_ipdiv, pll_ref_hz); =20 + cfg->hs_clk_rate =3D div_u64((u64)pll_ref_hz * cfg->pll_fbdiv, + 2 * cfg->pll_opdiv * cfg->pll_ipdiv); + return 0; } =20 @@ -297,6 +301,7 @@ static int cdns_dphy_config_from_opts(struct phy *phy, if (ret) return ret; =20 + opts->hs_clk_rate =3D cfg->hs_clk_rate; opts->wakeup =3D cdns_dphy_get_wakeup_time_ns(dphy) / 1000; =20 return 0; --=20 2.43.0 From nobody Mon Oct 6 08:23:13 2025 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60A2628E610 for ; Wed, 23 Jul 2025 10:02:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753264960; cv=none; b=W4l+8VBHahTCl4ERKlDHU7H+I7Fy07Vo2H/PXHOk181AnBU3OLiDjL462SV/RvdpvoVPiu7CjkrlamTk97EdMkYDAlCUgtRkwT09ZRUXuC9QSVQ5RtKdIm4UApv19x+Zq88bhF3lJ1BsZ8XYCCbBT97POILEvDSfarBD4NfZssA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753264960; c=relaxed/simple; bh=ubLhijbPFpmnKtpMPd2eMRomUhKyh3UJpvvcvParxTk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IaxOz7pYA3w2+0hqX+ZQHcdnfytCg2nDCfHjJVMzCi745dv5xmwRez+0CgW9SdWf1uW9GuKavzEB8wiJsoXo/KL92ZlhkZh8jSXEUKDW6RT5E7Ua+Jd2DktXSouYkzMGZu++uSCOSsjaMR8/8j2B76YKcuqyDeTmFm1K/1rGmeQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=nn2QlpMx; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nn2QlpMx" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 89BB2F0B; Wed, 23 Jul 2025 12:01:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1753264915; bh=ubLhijbPFpmnKtpMPd2eMRomUhKyh3UJpvvcvParxTk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=nn2QlpMxwtJrNobp3egnfC+cSiif2h4aMklMu1ALmLW9yq1N83masvUj9gxNE3cbt Np7gLOFSHB8ifTTwufdbUcYemL6BfRrIABiT1aXP4H1H/mgsU+fkuQDfu89xmk2X6i ADQCITZ+EVRCmP1B9CIJCS4ChNTGVONZ2zD42rb8= From: Tomi Valkeinen Date: Wed, 23 Jul 2025 13:01:29 +0300 Subject: [PATCH 2/2] phy: cdns-dphy: Remove leftover code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250723-cdns-dphy-hs-clk-rate-fix-v1-2-d4539d44cbe7@ideasonboard.com> References: <20250723-cdns-dphy-hs-clk-rate-fix-v1-0-d4539d44cbe7@ideasonboard.com> In-Reply-To: <20250723-cdns-dphy-hs-clk-rate-fix-v1-0-d4539d44cbe7@ideasonboard.com> To: Vinod Koul , Kishon Vijay Abraham I Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Parth Pancholi , Devarsh Thakkar , Francesco Dolcini , Tomi Valkeinen , Aradhya Bhatia , Jayesh Choudhary X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2424; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=ubLhijbPFpmnKtpMPd2eMRomUhKyh3UJpvvcvParxTk=; b=kA0DAAgB+j2qjLyWHvUByyZiAGiAszaiEm1o5niwWdlRP1o0/dLv5mQAyuYraUhEINRMvLG4g 4kCMwQAAQgAHRYhBMQ4DD6WXv2BB5/zp/o9qoy8lh71BQJogLM2AAoJEPo9qoy8lh71Rs8P/RNO CxjDTLGNiQyEic6a6DKs3HawdH3SYQSbZG8uZJcM8S47wgQzWrOKx53aUQvLF/l6xrA8s7/ZMAb UCRqxfRVuijRjvG09z+JrUTkyWR4EhvXBjXwomzn15ol7/N36YyJyjQxyFZc69vT8DsGF3nlWmx BtprOepyyUkeknqoXiSvw58+c0LV7pvClLTqIyL413iaiHSPw0txGOgc9QY1qdwpkDBpu2kYzmh 2f/H6x+3kwjxwfax02ZRgFWGI/LT5IhlB1Mkql5sEPfZG76vhmMHkSQiTeLZduz48NIE0FDqZzb 9D2jaJIekz0LCY4dEp9L3al982mEqNWVgjOndgKiBT7KWGvNQKKnF4zgERHb80xSOlkx5n7HlWb crRQCdE4Y5SR7TsjWeiucokiXgtc+vEU4DiDYug5tmAwlmnpMspi/SLPUZZM/6Zb1ZLnUvetSup c1aK2pqI8YJ1GsNFMZcF7TmPbOpQzZeLUPBFJNKp6jNcsYYL+xxyk5YWhFHSzQemDuyLBHGmTgn uhiQ8wSHdbYjkAZxKd0QPX3IidhZUZPvS8CC2nybJ2lZdK40TYkT4bveTKeXek2/nE2VRmY+X3Z HbmwPvbOoxSkWzsIWnNIqL+jbaBh1RQ/xZZXvZFJl0botqQO1SOKrs/NyaiOlqR1T0BW4KaFD6O QyBvS X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 The code in cdns-dphy has probably been part of a DSI driver in the past. Remove DSI defines and variables which are not used or do not actually do anything. Also rename cdns_dsi_get_dphy_pll_cfg() to cdns_dphy_get_pll_cfg(), i.e. drop the "dsi", as it's not relevant here. Reviewed-by: Aradhya Bhatia Tested-by: Parth Pancholi Acked-by: Vinod Koul Tested-by: Jayesh Choudhary Reviewed-by: Devarsh Thakkar Signed-off-by: Tomi Valkeinen --- drivers/phy/cadence/cdns-dphy.c | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dph= y.c index f79ec4fab409..33a42e72362e 100644 --- a/drivers/phy/cadence/cdns-dphy.c +++ b/drivers/phy/cadence/cdns-dphy.c @@ -55,14 +55,6 @@ #define DPHY_PSM_CFG_FROM_REG BIT(0) #define DPHY_PSM_CLK_DIV(x) ((x) << 1) =20 -#define DSI_HBP_FRAME_OVERHEAD 12 -#define DSI_HSA_FRAME_OVERHEAD 14 -#define DSI_HFP_FRAME_OVERHEAD 6 -#define DSI_HSS_VSS_VSE_FRAME_OVERHEAD 4 -#define DSI_BLANKING_FRAME_OVERHEAD 6 -#define DSI_NULL_FRAME_OVERHEAD 6 -#define DSI_EOT_PKT_SIZE 4 - #define DPHY_TX_J721E_WIZ_PLL_CTRL 0xF04 #define DPHY_TX_J721E_WIZ_STATUS 0xF08 #define DPHY_TX_J721E_WIZ_RST_CTRL 0xF0C @@ -117,10 +109,9 @@ static const unsigned int tx_bands[] =3D { 870, 950, 1000, 1200, 1400, 1600, 1800, 2000, 2200, 2500 }; =20 -static int cdns_dsi_get_dphy_pll_cfg(struct cdns_dphy *dphy, - struct cdns_dphy_cfg *cfg, - struct phy_configure_opts_mipi_dphy *opts, - unsigned int *dsi_hfp_ext) +static int cdns_dphy_get_pll_cfg(struct cdns_dphy *dphy, + struct cdns_dphy_cfg *cfg, + struct phy_configure_opts_mipi_dphy *opts) { unsigned long pll_ref_hz =3D clk_get_rate(dphy->pll_ref_clk); u64 dlane_bps; @@ -289,15 +280,13 @@ static int cdns_dphy_config_from_opts(struct phy *phy, struct cdns_dphy_cfg *cfg) { struct cdns_dphy *dphy =3D phy_get_drvdata(phy); - unsigned int dsi_hfp_ext =3D 0; int ret; =20 ret =3D phy_mipi_dphy_config_validate(opts); if (ret) return ret; =20 - ret =3D cdns_dsi_get_dphy_pll_cfg(dphy, cfg, - opts, &dsi_hfp_ext); + ret =3D cdns_dphy_get_pll_cfg(dphy, cfg, opts); if (ret) return ret; =20 --=20 2.43.0