From nobody Mon Oct 6 10:16:08 2025 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 331802DECCC for ; Tue, 22 Jul 2025 10:37:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753180638; cv=none; b=kzHXxZktcYjFneEbusCLFoUICkNfA9Oz7RwcQXR+9pQ6pFBpEjOoj4I9+3oiJgZnk86Lnln+E5wa2dz2eW/4L/SM32f7VzFTwpovBD8QZE26mQWSpcVz3gMustU8PTTtJFVtHEd+z6xz+ZIHi2Xmo0/634SRdM+YlZSnTwSdA1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753180638; c=relaxed/simple; bh=Uu0KyPQm4WIIkWykK1EPIZXCY66nvgOqnqJpxxXLb8Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qkbnOU27yVGTeGgxvPcOg9l9+cHvT6hm0jJcSTCCSX7F256I4xyOJ5mm80s00UyLKG+gqzemiOp5xHxbS9it3RFDyYOwkj1SKZZ0cdo3wD4WSifkDzXSg2wNAOsrEs8NzIiqmUJKEdVd7k0g472OiXTwFmtR5LkytgATsdDPvyg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=R3qRy5hz; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="R3qRy5hz" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-60c01b983b6so10765448a12.0 for ; Tue, 22 Jul 2025 03:37:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1753180635; x=1753785435; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fOaQOy4NwCzyitlYEvpuiMsUEgnozIVGmGmKLfL9eXI=; b=R3qRy5hzOLKjG9ie98wATV1+UQv1rwOTOrYld63m9Ogp/bT90sUq2o/3nl2lLN5gtS mq2ynhm2ndgEzOXWoTQqs/1AdyNi4xqlYhHvMyId8wrTV/OwGHnTVLHJAszLhAUaMw7F eBj7QAHUSkr2l+2UNr6jm+I4oLsUFc94e1NFU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753180635; x=1753785435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fOaQOy4NwCzyitlYEvpuiMsUEgnozIVGmGmKLfL9eXI=; b=MMM2bsK6mYk+kEYj9p0PU2sVL3JW7jrCS8s/EkClTzbWD0BRPt71Hpggjmc7DUycd4 de4XJMCsSHBmmVoollIFa2/uA+ec4gACqmzRzCJgnkDnV6JMhg0A1DUFPnSfjx5AO/ha yoal7v7YKn3neDtS0ygA32p2qT6qth1oQXbqnQyRNmcYK/TQci0FWSTvEo9a5WAmWe6D EWO4dURSJ3AeFFwb9FIyt/1s1BuvTAULNzh5hhgihkgUwAmqNv4IMf1cM2OF1+VW0zaZ IzpSg/tPZMtFDywZ4Xtcv+YSmdcexPQcrY29mLkPJXJltuQCKibgq5/RgPwoOE3EJ98c RRrg== X-Gm-Message-State: AOJu0YwaA6iKDOURS3tESoTV5oO8QTbokhHIZwm+l19Syo2ifADwiydg 8EXyaDaiLLfRmJXoNV7nvjujp917vafUKWs64NbIvKwpM9TYqdPf6L7C6AEs0Ay0wMad8zJGajO sRuvG X-Gm-Gg: ASbGncv3my+2UXl8oqG5dRdVP3mPztC7k0UrZWvtoCuEiI8KFWtPmX5vGpJReAl9Jps kM+ja6G5ZnmkG0zLheFqXD55mVj5TxBrU4A8mibVEvH5Z3WPsP4UwLEU8ZP4za23ejmqSiKaF1l jcgb8uVDLyxkxz74/pmRwRr9aVRl2v9FIf9OhToO+Ul1n3FKcROzvL0StXk8gEJ8MROPvPZ2fdd c6BV1tPKfSHmegH+OgQBosHL+xqE/a4VNrh1Dg6FJPfySpIlQ1r+g6ssDCc+Jzh2Xz558R0xyyD /Y8QIho3Y+GrDEu9KZnF+jOpoj6iRWQ6j9uoeeE1wEDezetsax2QpdFiWaKBdqAI+tFQzjaTTQr q4vi3ttlJrCeiwhzPDcv/ewA/KNpBmsnzMd49Aoo6l5UABsqnSTGcGijldeo= X-Google-Smtp-Source: AGHT+IGu/rHAsJZdTDesHIy4THsJpwWha/3OdhJMXkmdfz+OLlrTD1ZQyBKwuFnDcJvQVIDplpGbew== X-Received: by 2002:a17:907:2d20:b0:adb:2f9b:e16f with SMTP id a640c23a62f3a-af153339173mr333989466b.16.1753180635127; Tue, 22 Jul 2025 03:37:15 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:2bba:d7b0:8e79:c982]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6ca310e2sm844568766b.79.2025.07.22.03.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 03:37:14 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Michael Trimarchi , Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH 1/4] Input: imx6ul_tsc - fix typo in register name Date: Tue, 22 Jul 2025 12:36:15 +0200 Message-ID: <20250722103706.3440777-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> References: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Michael Trimarchi Replace 'SETING' with 'SETTING'. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- drivers/input/touchscreen/imx6ul_tsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchsc= reen/imx6ul_tsc.c index 6ac8fa84ed9f..c2c6e50efc54 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -55,7 +55,7 @@ #define ADC_TIMEOUT msecs_to_jiffies(100) =20 /* TSC registers */ -#define REG_TSC_BASIC_SETING 0x00 +#define REG_TSC_BASIC_SETTING 0x00 #define REG_TSC_PRE_CHARGE_TIME 0x10 #define REG_TSC_FLOW_CONTROL 0x20 #define REG_TSC_MEASURE_VALUE 0x30 @@ -192,7 +192,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) =20 basic_setting |=3D tsc->measure_delay_time << 8; basic_setting |=3D DETECT_4_WIRE_MODE | AUTO_MEASURE; - writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETING); + writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); =20 writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); =20 --=20 2.43.0 From nobody Mon Oct 6 10:16:08 2025 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9380E2E1723 for ; Tue, 22 Jul 2025 10:37:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753180640; cv=none; b=YRjK5/bE9M2GPBcyNuq4A/6WK4p+JHw2ZfZsRCTaeTEee57VFiFS/AHpq2vvEXPEwRq5Qh+pwoE+hkiQTIb8St9YiHQ+XsGcTsY4kYfYbEKYn0n+70v9PuC/INCwwgiei6DwtM1ptb0lIK7g2iMNuffDPiM0SoiGm1ZewdQzExA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753180640; c=relaxed/simple; bh=6DM9dMZAtcwlDKvhQvsmdFJDn+355Evyd4COdeLDukI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Whl+8B2kVk2MpI9QoFTXosQTFQRCa1UHm9QvqTklGdnno1H1Kl0qEZBH1brfdTTRXBHyyC273hWUdfxS3x3yNyv4VTTJzREUTsWrudKrAGdz75v3tlnVmemfdcxjGl0EIqIznZO46OV9WJ8wGV7aVGvFai436pWkTkDV4kA5Eq0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=Um0vZbyW; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="Um0vZbyW" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ae3b336e936so993625066b.3 for ; Tue, 22 Jul 2025 03:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1753180637; x=1753785437; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GtY6xQODciaFQXT13QEjMt2xFfxEtt0WYueluTMBhAE=; b=Um0vZbyWwagJoJVoyvzt10dufXbWiL9BGSf+gyy83x4GxniBv0Oh/KyASUkabJNAUv yqKz8yorgGOLhv3OffBbkgUhnovWOstmmvFbET8yAwMMQmzo3YJ9Am9WfQDFuHX1GGOj yG3YRxoz4ZeHiLmsNaqE9EDhg1eVta4sUyq4M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753180637; x=1753785437; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GtY6xQODciaFQXT13QEjMt2xFfxEtt0WYueluTMBhAE=; b=uKJLECcBrJNbcpo3zxrVbX4v+F4660eGrppzXd/NeZluEScWIG2wcDySGsbljzlq9s +u6N+TASgwhdNE5uxY4PTjCXzaTxyf7Tr+UCM377Rfw0pT4/Z68pFrBc84Gcdv3IU20r vPO1Na/3cTQzLTCL8y7xWMkV40OAZJf0ct5r3PkZI7dG7cT3Z75XvDhRY2n8Xz6gxB4K OC6Ox3EdCsDafVF/ThYADJR1bYZIHPOtEecQZa6gYjjg7UjuZ0smXEdEMV35vZL5argg t0cgFfLmcCA5wZ5fSLd4DR84PS0PVOVOdv1rx0kh3UfCTtd6/kHzUSL3R2S2UeOjsNhs MczA== X-Gm-Message-State: AOJu0YwKilGduhBp5TLgoFkhmGRA7mcbD+EvG3zJlLohMWODL+maPpm5 3pOO2jlk5ZjGGgP5Tvt1UdP28RqUxA7ER4z/TA7A3bCin9KeiwVWjH2xnZAulBFAPRQI7hz+JNC OKm+5 X-Gm-Gg: ASbGncvVNuBxutXElpRmykyXo9bemm6kdqqtmueEvwpEHSTzm/GW7wm6yL/2Su0SdEd 2T+vftk74WUWheoklO7zPvowyja/XihtOZMG6yae4T7hMU5+OWnyot1D5ETpIubIRT7lgU0UE/3 YiXvETpFDgEOdGZZoiRP5rDNuoPrlMoPbOrnzjIc4+M6mjn+9MBzDUsM3F3gj5f3ZJfV2rzQAHN pE34lMQyAt7WYL6D0GhubgSbXuhxkyryEERQoQm15vZwL2fDJdjNZEPbNEMdRCCNDnZkDtyH1wa DDedxH1eJEYKEza7kK7F5gtFqUM+NJkDZMT6WfKkRCVttJ138S3/byjdiNMkXuBxq+Olz7OP6Ad 19H/gioLFOC/2pININU+j9ULJmFP4GfNR1l6cj5gVdQJERF/OSf4iDXlsd8I= X-Google-Smtp-Source: AGHT+IGaHOYHJrE7/OlnHeCdJT7X6M+1OGRNxK7Jx2o38iPchbY1YGECx/VXRXtQUdO2o2c/K0RoAQ== X-Received: by 2002:a17:906:9fc9:b0:ae3:cd73:e95a with SMTP id a640c23a62f3a-ae9ce0d2aedmr2549138266b.36.1753180636628; Tue, 22 Jul 2025 03:37:16 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:2bba:d7b0:8e79:c982]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6ca310e2sm844568766b.79.2025.07.22.03.37.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 03:37:16 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Conor Dooley , Dmitry Torokhov , Fabio Estevam , Haibo Chen , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH 2/4] dt-bindings: input: touchscreen: fsl,imx6ul-tsc: add fsl,glitch-threshold Date: Tue, 22 Jul 2025 12:36:16 +0200 Message-ID: <20250722103706.3440777-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> References: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for glitch threshold configuration. A detected signal is valid only if it lasts longer than the set threshold; otherwise, it is regarded as a glitch. Signed-off-by: Dario Binacchi --- .../input/touchscreen/fsl,imx6ul-tsc.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul= -tsc.yaml b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-= tsc.yaml index 678756ad0f92..2fee2940213f 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.ya= ml +++ b/Documentation/devicetree/bindings/input/touchscreen/fsl,imx6ul-tsc.ya= ml @@ -62,6 +62,23 @@ properties: description: Number of data samples which are averaged for each read. enum: [ 1, 4, 8, 16, 32 ] =20 + fsl,glitch-threshold: + $ref: /schemas/types.yaml#/definitions/uint32 + default: 0 + enum: [ 0, 1, 2, 3 ] + description: | + Indicates the glitch threshold. The threshold is defined by number + of clock cycles. A detect signal is only valid if it is exist longer + than threshold; otherwise, it is regarded as a glitch. + 0: Normal function: 8191 clock cycles + Low power mode: 9 clock cycles + 1: Normal function: 4095 clock cycles + Low power mode: 7 clock cycles + 2: Normal function: 2047 clock cycles + Low power mode: 5 clock cycles + 3: Normal function: 1023 clock cycles + Low power mode: 3 clock cycles + required: - compatible - reg @@ -94,4 +111,5 @@ examples: measure-delay-time =3D <0xfff>; pre-charge-time =3D <0xffff>; touchscreen-average-samples =3D <32>; + fsl,glitch-threshold =3D <2>; }; --=20 2.43.0 From nobody Mon Oct 6 10:16:08 2025 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 038462E06DC for ; Tue, 22 Jul 2025 10:37:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753180641; cv=none; b=Ss46/eqy45cWWY57nlRgdoPfTH7cIiee6SG9iu3KlD6WJRpCxH3cX3vD26Xlz2J1ExgXhYD2YUhaASx7QEvZrT9t89CyKro9i3Yy3pHH5yxoV/xLa1lAuViPt8erK2XluL0eiYJZcCx9vOYMXCQ53KMVrU+DTgWkA4dtSbUKK7A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753180641; c=relaxed/simple; bh=mAnzVAui+Zh2pgPs+xFJHjOfsAlD+iZi1XelY8rp6FQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QmvOgXtIGhOvMIsT7Kr6xl0SzUYxFKI3oz5fy6UkomGyEyOpgkJd/EYG5s9yo98H3nczu5uSAozmdhLllXZA/2ABm07dXXM55QUnx/Jnu2hTdFql9uDuGqhdyg56JnYlOPM2FQXVudqgdr1AsekewyrkhM75lHUOV3y0ALlhaSY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=R8lacz1W; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="R8lacz1W" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-607434e1821so7600582a12.0 for ; Tue, 22 Jul 2025 03:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1753180638; x=1753785438; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B0R5rRW0Dwv8g9EBflVK6bi6TKX/71M89TmluJsUG60=; b=R8lacz1WPk5aCKoaeN2EZyoqiHYTl8ljgWG15zNWMdAcJCvLgttVFZsYmFka4qMfuK KSQGTEk6zhP1N7FWJLrevRncDHyAzt2wVWPhWRW2V023P2yv2PlAjUQbN/1UKKj9wHSS zzT1kBByHRGfK6U6w6ZXTcN71i81WN1otjqUs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753180638; x=1753785438; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B0R5rRW0Dwv8g9EBflVK6bi6TKX/71M89TmluJsUG60=; b=DoQ5PbA4SEkqzs5YeJfZzJf83wPC4aBtsdSDveZfhKkSxyHD9Nk7mkXv0yeh5rc74s +5kS65bmQlm4ZmGZy1sY9KrniKsazAHbu4WD10BEEgD7+LO690YmuQMRtWxQL7J4mh7e AwlcjQukpQo+/9fErCGS7E0pUN1+W0Ej0RlAgytNN1PG1Acg2NyUt/uLU14oGqacJGkn 8bn55HATubqElik2s/cTt7tWwJyGMYtSwAo8BwjYF3gU7boMQR0qA6nK1mITE5oZa0sv +SyHQiKbjmWR+tG7uOiJ3SfzsIQa/bY5hpO+QX2XcmjuvSjv6Ug9by37nWIC7DkOzqBR pOoQ== X-Gm-Message-State: AOJu0YzYkB6JYfXzHiQAs0g2rBmcATFzXApE7QcuEvzTP5vxtjD5Yr5J Ga07tqG1l8pIhyEWNFLBTNkZqE6z8wmnYDYwgXh9L7J6T1Nv6Nhzv8BOG00x2uiOcQrmqd12KPy E7duZ X-Gm-Gg: ASbGncv398irgjh5dM6Ifi1y9ILsgkE5XJ/uUW3fHcKL5tzZvq3vAWDoHVWYHbXx3dL CypZLjgjQbUjgq1nX/zROzkxUxwWRZKpmXCUrxi1aFM42g7AdvE6UQ9VKbyo3fZvJAKlWl2eFli BdQ8g25rkibuyG/a/OvUfHE61DaBQQ41rSjHBp8wrFYQoOIC4SymBV54uFm3uGfJh6qGGg2zRp9 eWFLnXdgoNxguA9eHb2XNVHIgd63q7dwqfn36jBrLZoksQn9kmOSPK0x3JNaFYBXhbUU4AJFxGH Erxk//xAAt1a5bQojD0ft/foTPDiSZRonjUxepHWqCafs8XGntKggsn2t7EfRIct9pJ9ERddpQx ymO2ulzoW+E3WK91jx2NaoVU6PuS3S/Go9ujrpj0kYA0gEpILU8Igcw1sbqk= X-Google-Smtp-Source: AGHT+IF5XH+ULXAJm2Yd7fdwy7Og8oahMPwKCKBYQfiU9IiXyUwIgGfm5dtLgUZCNSYYUrIZy4YonA== X-Received: by 2002:a17:907:cb81:b0:ae9:c494:1ade with SMTP id a640c23a62f3a-ae9ce199db0mr2520430366b.53.1753180638060; Tue, 22 Jul 2025 03:37:18 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:2bba:d7b0:8e79:c982]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6ca310e2sm844568766b.79.2025.07.22.03.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 03:37:17 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH 3/4] Input: imx6ul_tsc - set glitch threshold by DTS property Date: Tue, 22 Jul 2025 12:36:17 +0200 Message-ID: <20250722103706.3440777-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> References: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Set the glitch threshold previously hardcoded in the driver. The change is backward compatible. Signed-off-by: Dario Binacchi --- drivers/input/touchscreen/imx6ul_tsc.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchsc= reen/imx6ul_tsc.c index c2c6e50efc54..a6066643bd48 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -74,7 +75,8 @@ #define MEASURE_INT_EN 0x1 #define MEASURE_SIG_EN 0x1 #define VALID_SIG_EN (0x1 << 8) -#define DE_GLITCH_2 (0x2 << 29) +#define DE_GLITCH_MASK GENMASK(30, 29) +#define DE_GLITCH_DEF 0x02 #define START_SENSE (0x1 << 12) #define TSC_DISABLE (0x1 << 16) #define DETECT_MODE 0x2 @@ -92,6 +94,7 @@ struct imx6ul_tsc { u32 pre_charge_time; bool average_enable; u32 average_select; + u32 de_glitch; =20 struct completion completion; }; @@ -188,13 +191,15 @@ static void imx6ul_tsc_channel_config(struct imx6ul_t= sc *tsc) static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) { u32 basic_setting =3D 0; + u32 debug_mode2; u32 start; =20 basic_setting |=3D tsc->measure_delay_time << 8; basic_setting |=3D DETECT_4_WIRE_MODE | AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); =20 - writel(DE_GLITCH_2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); + debug_mode2 =3D FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); + writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2); =20 writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME); writel(MEASURE_INT_EN, tsc->tsc_regs + REG_TSC_INT_EN); @@ -501,6 +506,17 @@ static int imx6ul_tsc_probe(struct platform_device *pd= ev) return -EINVAL; } =20 + err =3D of_property_read_u32(np, "fsl,glitch-threshold", &tsc->de_glitch); + if (err) + tsc->de_glitch =3D DE_GLITCH_DEF; + + if (tsc->de_glitch > FIELD_MAX(DE_GLITCH_MASK)) { + dev_err(&pdev->dev, + "fsl,glitch-threshold (%u) must be less or equal to %lu\n", + tsc->de_glitch, FIELD_MAX(DE_GLITCH_MASK)); + return -EINVAL; + } + err =3D input_register_device(tsc->input); if (err) { dev_err(&pdev->dev, --=20 2.43.0 From nobody Mon Oct 6 10:16:08 2025 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A4C42E3393 for ; Tue, 22 Jul 2025 10:37:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753180644; cv=none; b=P1oo1UHf6/ceb3wUaz8nEZCTNoXYdoQJvLEhDR/pb4sl/GuIWMdlvYgeEe/NsQ0Oo6aVUkAkZIXO618dvStz8bMeenQVfAx6yIuqx4FgXSArTs4726O2s14SpJ9M9pT+PyXnVILmtFkrQpYwt2SAsQN6CGXVW+DDQsP98wJ9N6I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753180644; c=relaxed/simple; bh=544owQth2eYHOtuZem85B7R//X9yXkusHL8qgRLe1MY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QF+6rkmjrDrJU8T30XoXRb1bF06QguqeZVybzTYVPCKBQWp/wNvy5/FbYi6hTZ8k8fjudD0Askls7Q4QiLd4AQvBqI97NpqcIOYqvqieigKR6uNcH4+qm4TYq10Yvix4fFZOYtdwU2vdRW2qqc1QQgjbHXBbUoFER3ZBikm6Y48= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=cZTJWNCt; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="cZTJWNCt" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ae3703c2a8bso937019566b.0 for ; Tue, 22 Jul 2025 03:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1753180640; x=1753785440; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2oVD/JfoNNaDmsm+Xmi5oDSaNjfSX3YkjZgxJuhnDRo=; b=cZTJWNCt1oahuTLJgvUnpaJFe383xquzJRztA6ETtINmQNOaYXJeJ3GHLnRHlbUjUb yCoOduARpvSfVQU+bVttIVQ06FIuONYw1KfhzLNjawfxxucNZMgxyqR6Pq+Yx++tIhoC 65pTJs66Q3DwRNMNqdVDeLI0ZtApL88SxTPl4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753180640; x=1753785440; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2oVD/JfoNNaDmsm+Xmi5oDSaNjfSX3YkjZgxJuhnDRo=; b=v44Z9Q3AeSJl8axATqeJPTf1IdsECvsEU+T4kLW2gYnENL+iLfiDIHEyZVt41bb8Cu 6vOjiTn1CjDRpfGSghFovvqBCjuqRH5LhXUq0We9wVhvoWdjWxI2njhBrWzTe8nJSjAj 1gNZL+CesMmdMmBxlSzA68xc27jcyIzIw0cMH0pPS+ZHNFt5ter2Ktru+/PS4XRiFllF ZAyycgvboh6utVfgv0rfjAlfrWsIhKRsv0B/gyHXREsHJflZFB30L5++dp6TtX3bkNJg SNf6Wu9fC4FtlJfcq03WI2IZCneoovzImtnBiJQdGHyIbzuB+5jIyprCs7HY30wIuV0p DVIw== X-Gm-Message-State: AOJu0YyoEHIJKX10qRwY5XSePS1ZVeoc1+CbTK/H+feX8AswFfrwWH26 fMYDW2vqvAOTX3UX1zi3pDLwnLXBAg+4LbvntoB8C9ZLV58Oj1pv3brLTTkNyIZpK/WjLTwtNkk kQmnG X-Gm-Gg: ASbGnctS9F7B6WBWqtf9QzDvEzRi/2EbOWFe+LE/9pe83z27U9eqF4DIWa7olgMH0Nj FdealjZzYJqlPQidvLk8gXrIVV0D9eW+rhZc746uhyYClFdXqiAQNUpCAeEdbJN/b2mOM3by7o9 UX7tpcp1aw9a6R1kutodGsuNUg73g2wY47n11lMW3Nw1E16cRsM5jFLX5Vd7ms/Lz6WJU0kcTx+ LF4S6mBFhOi1VVF4ilEBo0Fgf+TmEsvLPuTM1YgZJAFZKh28pDmWOXBOaDmTrIOysT3oQANlgU9 Twb7D6sKIDc5P3mjJpVxC/nMRwA2RI2jYE28LSndaLSQG2ayKkUqdi9qrjb8k/BR7l2kPP+RH4P eOBj5+VItH8PXf6PO+X97kFJwOIhqgf7jx8kSdzQDOcMhZ/9zwRdm1pVFoAM= X-Google-Smtp-Source: AGHT+IGStQC9p3KnKnSdXHMyUMvaqHcAacRkAh69PXIKKkeDsY2m0YgH1GOz6iF/AlAHUl9+4h+0Uw== X-Received: by 2002:a17:907:3e93:b0:ae3:d026:36cd with SMTP id a640c23a62f3a-aec6a6235eemr1682182966b.42.1753180639487; Tue, 22 Jul 2025 03:37:19 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:6474:ebbf:2bba:d7b0:8e79:c982]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6ca310e2sm844568766b.79.2025.07.22.03.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 03:37:19 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Dmitry Torokhov , Fabio Estevam , Michael Trimarchi , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: [PATCH 4/4] Input: imx6ul_tsc - use BIT, FIELD_{GET,PREP} and GENMASK macros Date: Tue, 22 Jul 2025 12:36:18 +0200 Message-ID: <20250722103706.3440777-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> References: <20250722103706.3440777-1-dario.binacchi@amarulasolutions.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace opencoded masking and shifting, with BIT(), GENMASK(), FIELD_GET() and FIELD_PREP() macros. Signed-off-by: Dario Binacchi --- drivers/input/touchscreen/imx6ul_tsc.c | 88 ++++++++++++++------------ 1 file changed, 48 insertions(+), 40 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchsc= reen/imx6ul_tsc.c index a6066643bd48..e74999c5e22f 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -21,25 +21,23 @@ #include =20 /* ADC configuration registers field define */ -#define ADC_AIEN (0x1 << 7) +#define ADC_AIEN BIT(7) +#define ADC_ADCH_MASK GENMASK(4, 0) #define ADC_CONV_DISABLE 0x1F -#define ADC_AVGE (0x1 << 5) -#define ADC_CAL (0x1 << 7) -#define ADC_CALF 0x2 -#define ADC_12BIT_MODE (0x2 << 2) -#define ADC_CONV_MODE_MASK (0x3 << 2) +#define ADC_AVGE BIT(5) +#define ADC_CAL BIT(7) +#define ADC_CALF BIT(1) +#define ADC_CONV_MODE_MASK GENMASK(3, 2) +#define ADC_12BIT_MODE 0x2 #define ADC_IPG_CLK 0x00 -#define ADC_INPUT_CLK_MASK 0x3 -#define ADC_CLK_DIV_8 (0x03 << 5) -#define ADC_CLK_DIV_MASK (0x3 << 5) -#define ADC_SHORT_SAMPLE_MODE (0x0 << 4) -#define ADC_SAMPLE_MODE_MASK (0x1 << 4) -#define ADC_HARDWARE_TRIGGER (0x1 << 13) -#define ADC_AVGS_SHIFT 14 -#define ADC_AVGS_MASK (0x3 << 14) +#define ADC_INPUT_CLK_MASK GENMASK(1, 0) +#define ADC_CLK_DIV_8 0x03 +#define ADC_CLK_DIV_MASK GENMASK(6, 5) +#define ADC_SAMPLE_MODE BIT(4) +#define ADC_HARDWARE_TRIGGER BIT(13) +#define ADC_AVGS_MASK GENMASK(15, 14) #define SELECT_CHANNEL_4 0x04 #define SELECT_CHANNEL_1 0x01 -#define DISABLE_CONVERSION_INT (0x0 << 7) =20 /* ADC registers */ #define REG_ADC_HC0 0x00 @@ -66,20 +64,26 @@ #define REG_TSC_DEBUG_MODE 0x70 #define REG_TSC_DEBUG_MODE2 0x80 =20 +/* TSC_MEASURE_VALUE register field define */ +#define X_VALUE_MASK GENMASK(27, 16) +#define Y_VALUE_MASK GENMASK(11, 0) + /* TSC configuration registers field define */ -#define DETECT_4_WIRE_MODE (0x0 << 4) -#define AUTO_MEASURE 0x1 -#define MEASURE_SIGNAL 0x1 -#define DETECT_SIGNAL (0x1 << 4) -#define VALID_SIGNAL (0x1 << 8) -#define MEASURE_INT_EN 0x1 -#define MEASURE_SIG_EN 0x1 -#define VALID_SIG_EN (0x1 << 8) +#define MEASURE_DELAY_TIME_MASK GENMASK(31, 8) +#define DETECT_5_WIRE_MODE BIT(4) +#define AUTO_MEASURE BIT(0) +#define MEASURE_SIGNAL BIT(0) +#define DETECT_SIGNAL BIT(4) +#define VALID_SIGNAL BIT(8) +#define MEASURE_INT_EN BIT(0) +#define MEASURE_SIG_EN BIT(0) +#define VALID_SIG_EN BIT(8) #define DE_GLITCH_MASK GENMASK(30, 29) #define DE_GLITCH_DEF 0x02 -#define START_SENSE (0x1 << 12) -#define TSC_DISABLE (0x1 << 16) +#define START_SENSE BIT(12) +#define TSC_DISABLE BIT(16) #define DETECT_MODE 0x2 +#define STATE_MACHINE_MASK GENMASK(22, 20) =20 struct imx6ul_tsc { struct device *dev; @@ -115,19 +119,20 @@ static int imx6ul_adc_init(struct imx6ul_tsc *tsc) =20 adc_cfg =3D readl(tsc->adc_regs + REG_ADC_CFG); adc_cfg &=3D ~(ADC_CONV_MODE_MASK | ADC_INPUT_CLK_MASK); - adc_cfg |=3D ADC_12BIT_MODE | ADC_IPG_CLK; - adc_cfg &=3D ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE_MASK); - adc_cfg |=3D ADC_CLK_DIV_8 | ADC_SHORT_SAMPLE_MODE; + adc_cfg |=3D FIELD_PREP(ADC_CONV_MODE_MASK, ADC_12BIT_MODE) | + FIELD_PREP(ADC_INPUT_CLK_MASK, ADC_IPG_CLK); + adc_cfg &=3D ~(ADC_CLK_DIV_MASK | ADC_SAMPLE_MODE); + adc_cfg |=3D FIELD_PREP(ADC_CLK_DIV_MASK, ADC_CLK_DIV_8); if (tsc->average_enable) { adc_cfg &=3D ~ADC_AVGS_MASK; - adc_cfg |=3D (tsc->average_select) << ADC_AVGS_SHIFT; + adc_cfg |=3D FIELD_PREP(ADC_AVGS_MASK, tsc->average_select); } adc_cfg &=3D ~ADC_HARDWARE_TRIGGER; writel(adc_cfg, tsc->adc_regs + REG_ADC_CFG); =20 /* enable calibration interrupt */ adc_hc |=3D ADC_AIEN; - adc_hc |=3D ADC_CONV_DISABLE; + adc_hc |=3D FIELD_PREP(ADC_ADCH_MASK, ADC_CONV_DISABLE); writel(adc_hc, tsc->adc_regs + REG_ADC_HC0); =20 /* start ADC calibration */ @@ -167,19 +172,21 @@ static void imx6ul_tsc_channel_config(struct imx6ul_t= sc *tsc) { u32 adc_hc0, adc_hc1, adc_hc2, adc_hc3, adc_hc4; =20 - adc_hc0 =3D DISABLE_CONVERSION_INT; + adc_hc0 =3D FIELD_PREP(ADC_AIEN, 0); writel(adc_hc0, tsc->adc_regs + REG_ADC_HC0); =20 - adc_hc1 =3D DISABLE_CONVERSION_INT | SELECT_CHANNEL_4; + adc_hc1 =3D FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_4); writel(adc_hc1, tsc->adc_regs + REG_ADC_HC1); =20 - adc_hc2 =3D DISABLE_CONVERSION_INT; + adc_hc2 =3D FIELD_PREP(ADC_AIEN, 0); writel(adc_hc2, tsc->adc_regs + REG_ADC_HC2); =20 - adc_hc3 =3D DISABLE_CONVERSION_INT | SELECT_CHANNEL_1; + adc_hc3 =3D FIELD_PREP(ADC_AIEN, 0) | + FIELD_PREP(ADC_ADCH_MASK, SELECT_CHANNEL_1); writel(adc_hc3, tsc->adc_regs + REG_ADC_HC3); =20 - adc_hc4 =3D DISABLE_CONVERSION_INT; + adc_hc4 =3D FIELD_PREP(ADC_AIEN, 0); writel(adc_hc4, tsc->adc_regs + REG_ADC_HC4); } =20 @@ -194,8 +201,9 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc) u32 debug_mode2; u32 start; =20 - basic_setting |=3D tsc->measure_delay_time << 8; - basic_setting |=3D DETECT_4_WIRE_MODE | AUTO_MEASURE; + basic_setting |=3D FIELD_PREP(MEASURE_DELAY_TIME_MASK, + tsc->measure_delay_time); + basic_setting |=3D AUTO_MEASURE; writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING); =20 debug_mode2 =3D FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch); @@ -255,7 +263,7 @@ static bool tsc_wait_detect_mode(struct imx6ul_tsc *tsc) =20 usleep_range(200, 400); debug_mode2 =3D readl(tsc->tsc_regs + REG_TSC_DEBUG_MODE2); - state_machine =3D (debug_mode2 >> 20) & 0x7; + state_machine =3D FIELD_GET(STATE_MACHINE_MASK, debug_mode2); } while (state_machine !=3D DETECT_MODE); =20 usleep_range(200, 400); @@ -283,8 +291,8 @@ static irqreturn_t tsc_irq_fn(int irq, void *dev_id) =20 if (status & MEASURE_SIGNAL) { value =3D readl(tsc->tsc_regs + REG_TSC_MEASURE_VALUE); - x =3D (value >> 16) & 0x0fff; - y =3D value & 0x0fff; + x =3D FIELD_GET(X_VALUE_MASK, value); + y =3D FIELD_GET(Y_VALUE_MASK, value); =20 /* * In detect mode, we can get the xnur gpio value, --=20 2.43.0