From nobody Mon Oct 6 10:13:22 2025 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31BC8265CCB for ; Tue, 22 Jul 2025 20:36:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753216569; cv=none; b=V2i1urAdlw3furyDtJWBUnbSG84guFJrdBG7lrO9YQv9utFPbVu1q6fnDZRYXGs9kkvXob86w9qojuWQtsh4aBqYedVK8p7IdoK/H4MrTEjC6SjUVLkrbJLzEcqGOIu5+aIKIslVwySmrrit0gVDIoqUZc4Gm8HqSJzA+kGv3a0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753216569; c=relaxed/simple; bh=8bxoz11IclHWwjha5/jlpRbpgbpr8raTeUpA7+6w/j0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Ix9DHWg7XZcmVHY6cEhPUj15p6sllGmjSjd+WsfKxSHd6v5llaIBRWWU/KZXFcohA9/UnuWoxt8Bv57WdoB/dUb8Tw2ofYM3rd5UG3zty0T23GGIba8wl1at1R3encRflzqRAAa1i8i+ga/fmOmvk2L71pPU3a5abcsiz20Ve9E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=WjdYQDiB; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WjdYQDiB" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-234bfe37cccso46651765ad.0 for ; Tue, 22 Jul 2025 13:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1753216567; x=1753821367; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=7Fwnd8+rlpdsPWzSX90R7aWBxNlk9l7Bj+L/1PupwCc=; b=WjdYQDiB92cR9AruDl2lkyk9gryK8tDF7kOGF93H1KdIQYVkO9HqeOFuegd2fkZSvf 8QkHKYW/foizIqssLnEQns+m+ftqa0ecaHdOiivyCzKxcxd69/LKu26apT2BQrT8uaWv NuQR+VHIMkfH27xcemTbEAgjGETDWwDjPjwyI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753216567; x=1753821367; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7Fwnd8+rlpdsPWzSX90R7aWBxNlk9l7Bj+L/1PupwCc=; b=PkSvH11jaeovxOxiHC/yWTAPJ4JJvAjsFGnSGEEPlbAIcVDrGJCcFkF/yeMqUbphpT ANyszKvRPDK0ds5TLEbw12terTnj6bvOC0YAEpIgO5bOH1oKqp5tIgi4B8NUpRoPDh9n +oqsoS9wfSC+fV0s618OIsuJ675F/3F2c9RCvcbMGvTF9VV7rgYfyjfOlnoa4wnABl/4 1fqQub5Wjd+4DG+gQ/slH/73zgH/mIcWcyT0ZTXXhR/Q8LQHkbq6BarF+MZ6vkaINeAi TMJytGmOaqhyOIskPV5kTsVJqM07HAqzyutJL709H9iZEzMOThzjrE4HNykVQHXUDBXa CZ/Q== X-Forwarded-Encrypted: i=1; AJvYcCWdMb8UTUwOgM1Paqhmo4F2+PTd9SF6oOi/wdsmb5Lw9JonlVHg3ThfxoqAXahZ+F+Ki3qbL9BIduSaGf4=@vger.kernel.org X-Gm-Message-State: AOJu0YyW92cBgqDkCllKMFKVl3Orc24cCwrxT8iHD7x8Sa6RFnQLbOVs i2lOZZudCWkvUMy5m/Ph67TOUceMQmHK8UmB4Yqw75sW+gfz4A/fejst4GicafJA+hV7IJHGglu dCPI= X-Gm-Gg: ASbGnctYuqVwzYxThIxesAG/+7fl8ZcRbaApT/ByyrnAr1MzB1KnLd/dRPN8Sn/LqTH ZOxMx5D4Yl7zgkuCeKXTqe3HSFBvhAwOQjsogaZlNnImR6dLz/dFYEFBS9k+KwcusEm+vNALLT9 mRtQdnxxjFoGA9JNukz7CrhjFF7DlR3RM49IjKZjOAvOXdpWxb+M8bLZbRb74m6OssJtJrmyODV kjYFRP6+B9bAVsL8tmtxpMYh//L1uUeCJeyyFi3TgW75uGwoRfIyI/DfGch92TEuhPPuLpsSJS4 PEUaEedVid6XqVfpwEmYjOubNqcD/JHG1tN0WOexz+fZSehdvF+z4+Dy/5l9O0cIdggzg2PrGcY 2FgjuXWCQsmq8Xh6kb9xfpeOnj5Rub0bZaHK44xKGB3zAOrc= X-Google-Smtp-Source: AGHT+IFsAM+0JFqi5v2GadpRvqr/FUdYl9fpGwYmPAtyAQxHuYzzs2yAOgbD4ESE29lV23bc2w2r2g== X-Received: by 2002:a17:903:faf:b0:236:15b7:62f6 with SMTP id d9443c01a7336-23f982036a4mr4849565ad.34.1753216567319; Tue, 22 Jul 2025 13:36:07 -0700 (PDT) Received: from ballway23.roam.corp.google.com ([136.27.48.153]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23e3b5e2cfasm82211765ad.30.2025.07.22.13.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 13:36:06 -0700 (PDT) From: Allen Ballway Date: Tue, 22 Jul 2025 13:35:43 -0700 Subject: [PATCH] media: ov8865: move mode_configure out of state_configure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250722-mode_configure-v1-1-5ea35052a01f@chromium.org> X-B4-Tracking: v=1; b=H4sIAB72f2gC/x3MQQqAIBBA0avIrBPUkKSrRETpaLNIQykC6e5Jy 7f4v0LBTFhgZBUy3lQoxQbZMbD7GgNycs2ghNJiUIofyeFiU/QUrozcCCm035zptYMWnRk9Pf9 wmt/3A0nt4RlgAAAA X-Change-ID: 20250722-mode_configure-80105fbd835d To: Hans de Goede , Sakari Ailus , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Allen Ballway X-Mailer: b4 0.14.2 ov8865_mode_configure() only needs to be called on sensor init, but it can be called multiple times from ov8865_state_configure(). Move ov8865_mode_configure() to ov8865_sensor_init(). Signed-off-by: Allen Ballway --- drivers/media/i2c/ov8865.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c index 95ffe7536aa6aba814f4e5c3d12e7279470b2f07..1d1a1f261bf4ab5c09848402dc0= 57e2f572504e7 100644 --- a/drivers/media/i2c/ov8865.c +++ b/drivers/media/i2c/ov8865.c @@ -2304,14 +2304,6 @@ static int ov8865_state_configure(struct ov8865_sens= or *sensor, if (sensor->state.streaming) return -EBUSY; =20 - /* State will be configured at first power on otherwise. */ - if (pm_runtime_enabled(sensor->dev) && - !pm_runtime_suspended(sensor->dev)) { - ret =3D ov8865_mode_configure(sensor, mode, mbus_code); - if (ret) - return ret; - } - ret =3D ov8865_state_mipi_configure(sensor, mode, mbus_code); if (ret) return ret; @@ -2384,6 +2376,13 @@ static int ov8865_sensor_init(struct ov8865_sensor *= sensor) } =20 /* Configure current mode. */ + ret =3D ov8865_mode_configure(sensor, sensor->state.mode, + sensor->state.mbus_code); + if (ret) { + dev_err(sensor->dev, "failed to configure mode\n"); + return ret; + } + ret =3D ov8865_state_configure(sensor, sensor->state.mode, sensor->state.mbus_code); if (ret) { --- base-commit: 6832a9317eee280117cd695fa885b2b7a7a38daf change-id: 20250722-mode_configure-80105fbd835d Best regards, --=20 Allen Ballway